Serge Gautherie [Tue, 15 Sep 2020 11:56:51 +0000 (13:56 +0200)]
[BROWSEUI][USER32] Explicitly use MAKEINTRESOURCEW() for consistency (#3192)
Michael Stamper [Mon, 14 Sep 2020 19:48:06 +0000 (20:48 +0100)]
[KDBG] Fixed handle leak in KdbpSymLoadModuleSymbols() when RosSymCreateFromFile() fails (#3184)
Joachim Henze [Mon, 14 Sep 2020 15:12:16 +0000 (17:12 +0200)]
[WDMAUD.DRV] Workaround multiple issues with AC97 driver from rapps
By taking alternative code-paths in WdmAud and bypassing Sysaudio.
This relies on the patch 0.4.15-dev-765-g
b8e936a57b4770e133772cf2dd66f30671a1524b
It fixes the following bugs/regressions:
-CORE-13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash
-CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II"
-CORE-8726/CORE-9986/CORE-16564 AC97 driver is now working in the same session where driver was installed, no reboot-orgies needed anymore
-CORE-9981 almost 100% fixed, DosBox + Commander Keen6 properly plays music instead of garbled output,
same improvement for ScummVM 2.0 with Monkey Island 2
The playback is not yet *entirely* perfect, still a few hiccups now and then, but
by orders of magnitude better than before.
Katayama Hirofumi MZ [Mon, 14 Sep 2020 04:25:45 +0000 (13:25 +0900)]
[SHELL32_APITEST] Strengthen ShellExecCmdLine testcase (#3164)
- Add tests for "My Documents" and "Control Panel".
- Add some comments for usability.
CORE-16939
Hermès Bélusca-Maïto [Mon, 14 Sep 2020 03:39:48 +0000 (05:39 +0200)]
[SHELL32] Fix boot to shell, addendum to commit
14599b0a.
shell32.ShellMessageBoxW redirects to shlwapi.ShellMessageBoxWrapW.
However the latter one (shlwapi) is exported by ordinal only.
Trying to use in shell32.spec file the following syntax:
182 varargs ShellMessageBoxW() shlwapi.ShellMessageBoxWrapW
will therefore fail at runtime, because Windows/ReactOS will fail to
snap shlwapi.ShellMessageBoxWrapW.
Using instead an export by orginal:
182 varargs ShellMessageBoxW() shlwapi.#388
actually fails as well, but at link time, by both MSVC' LINK and GNU's
dlltool.
This generates a .def file containing the line:
ShellMessageBoxW=shlwapi.#388 @182
It is not clear why it fails, because according to:
https://docs.microsoft.com/en-us/cpp/build/reference/exports?view=vs-2019
and
https://devblogs.microsoft.com/oldnewthing/
20121116-00/?p=6073
this should be possible.
However one encounters the same errors as those described at:
https://groups.google.com/forum/#!topic/microsoft.public.vc.language/AVnx-EnYdsY
and
https://www.xspdf.com/questions/22333.shtml
...
So instead we use another trick, that appears to be already in use in
the shell32.spec. Since the shlwapi functions are imported because we
link to it, this means that ShellMessageBoxWrapW() is already available
through this import. So we can specify it in the .spec file as is,
without a full name prefixed with "shlwapi." .
Therefore the associated shell32.ShellMessageBoxW function will instead
link to the small ShellMessageBoxWrapW() import stub that is generated
automatically.
Serge Gautherie [Sun, 13 Sep 2020 21:42:09 +0000 (23:42 +0200)]
[PROGMAN][CRT][USER32] Do not use LoadLibraryEx() NT6+ flags (#3152)
CORE-12004
Kyle Katarn [Sun, 13 Sep 2020 21:16:19 +0000 (23:16 +0200)]
[TRANSLATION][SHELL32] Localization of "System Folder" in My Computer types (#3168)
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: JoseSanchezz <67137372+JoseSanchezz@users.noreply.github.com>
Jose Carlos Jesus [Sun, 13 Sep 2020 21:14:05 +0000 (22:14 +0100)]
[TRANSLATION][SCREENSAVERS][SYSSETUP] Add Portuguese (PT) translation (#3156)
Kyle Katarn [Sun, 13 Sep 2020 21:12:52 +0000 (23:12 +0200)]
[RAPPS][CONSRV] French translation update (#3160)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Kyle Katarn [Sun, 13 Sep 2020 21:05:04 +0000 (23:05 +0200)]
[SHELL32] Improve Format dialog debug log (trivial) (#3176)
- Logging of name for unknown filesystem.
- Fix some trace content as not only HDD could be affected.
Kyle Katarn [Sun, 13 Sep 2020 21:02:09 +0000 (23:02 +0200)]
[FORMAT] Fix of output text overlap in console when finished (#3177)
At the end of the format operation, text in console got overwritten and leftovers from previous line remained displayed.
Kyle Katarn [Sun, 13 Sep 2020 21:01:07 +0000 (23:01 +0200)]
[FORMAT] French translation fix (#3178)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Sat, 4 Jul 2020 20:19:45 +0000 (22:19 +0200)]
[CMD] Document the two extra file attributes the enhanced batch/FOR variables %~aX could handle on Windows >= 8.
They are currently specified for documentation purposes (i.e. what
Windows 8+ CMD.EXE can report) but not used yet, since ReactOS does not
support them.
Hermès Bélusca-Maïto [Sat, 12 Sep 2020 15:00:42 +0000 (17:00 +0200)]
[CMD] SHIFT: Use _istdigit().
Hermès Bélusca-Maïto [Sat, 12 Sep 2020 18:29:54 +0000 (20:29 +0200)]
[CMD] Use pointers to const strings in error functions, where applicable.
Hermès Bélusca-Maïto [Sat, 12 Sep 2020 18:01:27 +0000 (20:01 +0200)]
[CMD] Minor formatting only.
Hermès Bélusca-Maïto [Sun, 13 Sep 2020 16:21:29 +0000 (18:21 +0200)]
[SHELL32][SHLWAPI] Forward shell32.ShellMessageBoxW directly to shlwapi.ShellMessageBoxWrapW. (#3179)
This makes ShellMessageBoxW use the correct implementation where the
text buffer size is dynamic, instead of having a too small hardcoded
size.
Fixes CORE-17271.
See also PR #3172 by Kyle Katarn, supplemented with some ideas from
Mark Jansen.
However we cannot straightforwardly implement ShellMessageBoxA around
ShellMessageBoxW, by converting some parameters from ANSI to UNICODE,
because there may be some variadic ANSI strings, associated with '%s'
printf-like formatters inside the format string, that would also need
to be converted; however there is no way for us to find these and perform
the conversion ourselves.
Therefore, we re-implement ShellMessageBoxA by doing a copy-paste ANSI
adaptation of the shlwapi.ShellMessageBoxWrapW function.
Note that, on Vista+ onwards, shlwapi implements both ShellMessageBoxA/W,
and shell32 directly forwards these exports to shlwapi, thus avoiding
these workarounds.
[PSDK] Explicily use WINAPIV for the variadic ShellMessageBoxA/W functions.
[INCLUDE/REACTOS] Add ShellMessageBoxWrapW in shlwapi_undoc.h .
He Yang [Sun, 13 Sep 2020 19:00:08 +0000 (03:00 +0800)]
[RAPPS] Update Chinese Simplified (zh-CN) translation (#3155)
Addendum to
7a11c65.
Adam Stachowicz [Sun, 13 Sep 2020 15:22:11 +0000 (15:22 +0000)]
[NTOBJSHEX] Update Polish (pl-PL) translation (#3175)
Addendum to
e358d1d. CORE-17268
Timo Kreuzer [Wed, 9 Sep 2020 17:18:27 +0000 (19:18 +0200)]
[MSVCRT] Add vista exports
Timo Kreuzer [Tue, 3 Mar 2020 18:36:49 +0000 (19:36 +0100)]
[MSVCRT] -i386 -> -arch=i386 for consistency
Timo Kreuzer [Tue, 3 Mar 2020 18:34:23 +0000 (19:34 +0100)]
[MSVCRT] Fix some architecture specific exports
Katayama Hirofumi MZ [Sun, 13 Sep 2020 08:33:57 +0000 (17:33 +0900)]
[MSPAINT] Improve Japanese (ja-JP) translation 3
Katayama Hirofumi MZ [Sun, 13 Sep 2020 08:15:57 +0000 (17:15 +0900)]
[NTOBJSHEX] Improve Japanese (ja-JP) translation
Katayama Hirofumi MZ [Sun, 13 Sep 2020 08:15:05 +0000 (17:15 +0900)]
[MSPAINT] Improve Japanese (ja-JP) translation 2
Katayama Hirofumi MZ [Sun, 13 Sep 2020 08:01:49 +0000 (17:01 +0900)]
[MSPAINT] Improve Japanese (ja-JP) translation
Katayama Hirofumi MZ [Sun, 13 Sep 2020 07:50:15 +0000 (16:50 +0900)]
[CONSRV] Improve Japanese (ja-JP) translation
Katayama Hirofumi MZ [Sun, 13 Sep 2020 07:39:29 +0000 (16:39 +0900)]
[NTOBJSHEX] Add Japanese (ja-JP) translation
Michael Stamper [Tue, 8 Sep 2020 21:59:09 +0000 (21:59 +0000)]
[WDMAUD] Fix race condition bug with USE_MMIXER_LIB defined (#3148)
Remove misuse of multithreading and use NtDeviceIoContol with completion apc
callback instead (mirrors usage of WriteFileEx in WdmAudCommitWaveBufferByLegacy).
This fixes a crash caused by race condition. Code was simulating completion
callback using a thread, this resulted in single threaded code being executed
simultaneously by multiple threads.
CORE-17214
Serge Gautherie [Sat, 12 Sep 2020 19:38:06 +0000 (21:38 +0200)]
[KERNEL32] GetPriorityClass(): Return explicit 0, not FALSE (match return type) (#3170)
Stanislav Motylkov [Sat, 12 Sep 2020 19:18:18 +0000 (22:18 +0300)]
[NTOBJSHEX] Update Russian (ru-RU) translation
Addendum to
e358d1d. CORE-17268
Kyle Katarn [Sat, 12 Sep 2020 17:43:59 +0000 (19:43 +0200)]
[NTOBJSHEX] Localize the descriptions of the NT object and registry shell extension (#3167)
CORE-17268
chirsz [Sat, 12 Sep 2020 16:23:05 +0000 (00:23 +0800)]
[CONSRV] Improve zh-CN translation (#3157)
The new word is more in line with PRC people's usage habits, and it
is actually used in the Simplified Chinese translation of Windows.
Katayama Hirofumi MZ [Sat, 12 Sep 2020 15:47:56 +0000 (00:47 +0900)]
[SHELL32_APITEST] Strengthen ShellExecuteW testcase (#3165)
Add tests for special folders. CORE-16939
Timo Kreuzer [Sat, 12 Sep 2020 13:04:02 +0000 (15:04 +0200)]
[KERNEL32_VISTA][NTDLL_VISTA][RTL_VISTA] Move Vista Rtl functions from kernel32_vista and ntdll_vista to rtl_vista (#3149)
* Move RtlRunOnce functions from kernel32_vista to rtl_vista and export them from ntdll_vista
* Move condvar.c and srw.c from ntdll_vista to rtl_vista
* Move ntdll_vista build script to a subfolder of ntdll
The RtlRunOnce functions are taken from wine, completely unmodified.
The code that was in kernel32_vista had change that used a global keyed_event handle, but was never initialized, so we were still passing NULL thus using the global ExpCritSecOutOfMemoryEvent.
Timo Kreuzer [Thu, 10 Sep 2020 15:25:42 +0000 (17:25 +0200)]
[ASM] Fix boot with VS 16.7.3 / MSVC 19.27
See https://developercommunity.visualstudio.com/content/problem/
1180800/ml-x86-assume-directive-causes-invalid-code-genera.html
Mark Jansen [Thu, 3 Sep 2020 16:12:25 +0000 (18:12 +0200)]
[CABMAN] Replace linked lists with std::list
CORE-17231
Katayama Hirofumi MZ [Sat, 12 Sep 2020 00:40:48 +0000 (09:40 +0900)]
[FONTEXT] Initial implementation of CFontExt::DoGetFontTitle (#3127)
This PR is a preparation of fonts folder implementation. CORE-12861
Mark Jansen [Thu, 10 Sep 2020 21:40:52 +0000 (23:40 +0200)]
[CERTUTIL] Add skeleton application with support for -hashfile
Nguyen Trung Khanh [Fri, 11 Sep 2020 12:51:35 +0000 (19:51 +0700)]
[FILESYSTEMS] Fix pool memory disclosure in filesystem drivers supporting FS_INFORMATION_CLASS.FileFsVolumeInformation (#2975)
* FileFsVolumeInformation-memory-disclosure
* remove unnecessary assignment to 0
* fix
Nguyen Trung Khanh [Fri, 11 Sep 2020 12:47:43 +0000 (19:47 +0700)]
[FILESYSTEMS] Fix pool memory disclosure in NtQueryAttributesFile handlers (#2926)
Fix pool memory disclosure caused by alignment bytes at the end of the _FILE_BASIC_INFORMATION structure
Joachim Henze [Fri, 11 Sep 2020 00:24:42 +0000 (02:24 +0200)]
[SHELL32] Fix regression CORE-12364
The sorting in explorer broke by
SVN r73128 == git
24fcf531e78423b314a2d6a4ac750df69e478e3a
Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
Kyle Katarn [Thu, 10 Sep 2020 18:48:40 +0000 (20:48 +0200)]
[SHELL32] Show "size on disk" in file/folder properties (#3107)
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Mark Jansen [Mon, 18 May 2020 19:39:34 +0000 (21:39 +0200)]
[SHLWAPI] Fix SHLoadIndirectString executing code when loading a string
Mark Jansen [Mon, 18 May 2020 19:38:56 +0000 (21:38 +0200)]
[SHLWAPI_APITEST] Add test showing SHLoadIndirectString should load a dll as datafile
Oleg Dubinskiy [Tue, 30 Jun 2020 17:42:29 +0000 (20:42 +0300)]
[DBGENG] Import dbgeng.dll from Wine Staging 4.18
CORE-17153.
Oleg Dubinskiy [Tue, 30 Jun 2020 17:38:29 +0000 (20:38 +0300)]
[PSDK] Import dbgeng.h header from Wine Staging 4.18
Required by Wine's dbgeng.dll CORE-17153.
Serge Gautherie [Wed, 24 Jun 2020 18:41:44 +0000 (20:41 +0200)]
[CMAKE] Remove obsolete '_ROSBE_VERSION' checks
following upgrade to RosBE (2.1 and now) 2.2.
Doug Lyons [Thu, 10 Sep 2020 16:15:12 +0000 (11:15 -0500)]
[GDI32_APITEST] Create StretchBlt Regression Test (#3109)
* Add gdi32_apitest:StretchBlt regression test.
* Give Wine proper credit for base code.
Katayama Hirofumi MZ [Thu, 10 Sep 2020 10:03:20 +0000 (19:03 +0900)]
[SHELLFIND] Split encoding detection code (#3147)
Split encoding detection code to improve code quality. This is follow-up of #3134 (
7376cde). CORE-17250
Timo Kreuzer [Sat, 21 Sep 2019 17:51:56 +0000 (19:51 +0200)]
[NTDLL] Add Vista exports
Timo Kreuzer [Sat, 21 Sep 2019 17:31:40 +0000 (19:31 +0200)]
[NTDLL] Mark 2k3 only functions and improve some arch specific definitions
Omer I.S [Tue, 8 Sep 2020 21:01:56 +0000 (00:01 +0300)]
[INPUT.CPL] Update Hebrew translation (#3121)
Kyle Katarn [Tue, 8 Sep 2020 19:57:13 +0000 (21:57 +0200)]
[BOOT][DIRECTX][SHELL32] Unneeded semicolons (trivial) (#3133)
Except in 3rd-party code.
CORE-13162
Kyle Katarn [Tue, 8 Sep 2020 19:55:45 +0000 (21:55 +0200)]
[EXPLORER] Registry key not closed on error (#3136)
CORE-14519
Kyle Katarn [Tue, 8 Sep 2020 19:52:24 +0000 (21:52 +0200)]
[SOLITAIRE] French translation update (#3138)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
James Tabor [Tue, 8 Sep 2020 18:15:16 +0000 (13:15 -0500)]
[Printing] Fix Typos and Test Regressions
Fix WinSpool API regressions.
Fix typos and debug prints.
James Tabor [Tue, 8 Sep 2020 17:52:28 +0000 (12:52 -0500)]
[GDI32] Force Return if other Type of Device Requested
Fix CORE-17241 assert.
Victor Perevertkin [Tue, 8 Sep 2020 11:51:20 +0000 (14:51 +0300)]
[NTOS:IO] Fix a reference leak in IopSynchronousCall on failure case
Co-authored-by: Vadim Galyant <vgal@rambler.ru>
Mark Jansen [Thu, 3 Sep 2020 16:13:21 +0000 (18:13 +0200)]
[CABMAN] Ensure we are minimally building with c++11
Mark Jansen [Sun, 30 Aug 2020 18:38:43 +0000 (20:38 +0200)]
[CABMAN] Move CCFDATAStorage to a separate header
Mark Jansen [Sun, 30 Aug 2020 13:31:04 +0000 (15:31 +0200)]
[CABMAN] Replace some dynamically allocated strings with std::string
CORE-17231
Mark Jansen [Sun, 6 Sep 2020 19:30:23 +0000 (21:30 +0200)]
[ATL][ATL_APITEST] Add CString::Tokenize + testcase
Joachim Henze [Mon, 7 Sep 2020 18:32:00 +0000 (20:32 +0200)]
[SDK][NDK][PSTYPES] Fix regressions CORE-17247 & CORE-17248
By reverting the guilty rev 0.4.14-dev-1239-g
7481bda679eccdf1eba3666e500074dcb966e748
and placing a C_ASSERT() to protect us from doing the
same fault again in the future. (proposed by Mark Jansen)
This will allow again to use kernel32.dll from 2k3sp2 to
reach desktop and it will allow Google Earth to run again.
Unfortunately it will break CORE-16757 again,
but we did not ship that improvement yet
and we believe that revert to be correct.
When approaching CORE-16757 later, make sure to double-check
also CORE-17247 & CORE-17248 with your fix.
We did excessive testing here, see
https://jira.reactos.org/browse/CORE-17247?focusedCommentId=125166&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-125166
Katayama Hirofumi MZ [Mon, 7 Sep 2020 13:30:47 +0000 (22:30 +0900)]
[SHELLFIND] Encoding-aware file search (#3134)
Consider UTF-8/UTF-16/UTF-16BE encodings in file search. Recognize UTF-8/UTF-16/UTF-16BE BOM and NULs at the beginning of the file contents. Optimize for speed.
CORE-17250
Katayama Hirofumi MZ [Mon, 7 Sep 2020 08:11:31 +0000 (17:11 +0900)]
[BROWSEUI] Improve Japanese translation
Katayama Hirofumi MZ [Mon, 7 Sep 2020 06:48:25 +0000 (15:48 +0900)]
[SHELLFIND] Fix directory search upon non-empty word/phrase query (#3130)
If the search phrase was not empty, it must not match the directory. CORE-17244
Victor Perevertkin [Mon, 7 Sep 2020 01:57:17 +0000 (04:57 +0300)]
[NTOS:IO] Fix IRP stack location check in IoForwardIrpSynchronously
We are doing IoCallDriver here, so the valid stack location should be
CurrentLocation <= Irp->StackCount (just a check for a completly incorrect value)
&& CurrentLocation > 1 (ensure that we have a place for another call)
CORE-17189
Co-authored-by: Thomas Faber <thomas.faber@reactos.org>
Katayama Hirofumi MZ [Mon, 7 Sep 2020 00:42:43 +0000 (09:42 +0900)]
[BROWSEUI][SHELL32] Implement MoveTo/CopyTo buttons (#3128)
Implement the actions of the MoveTo/CopyTo/Delete buttons.
CORE-11132
Katayama Hirofumi MZ [Mon, 7 Sep 2020 00:33:21 +0000 (09:33 +0900)]
[BROWSEUI] Set DT_VCENTER to Explorer bars (#3135)
Make the captions of the explorer bars vertically centered.
Doug Lyons [Sun, 6 Sep 2020 16:08:03 +0000 (11:08 -0500)]
[GDI32] Fix double cx's in call to HANDLE_METADC in win32ss painting.c (#3137)
Fix copy-paste error.
He Yang [Sat, 29 Aug 2020 12:32:59 +0000 (20:32 +0800)]
[RAPPS] settings read/write refactor (#3101)
* [RAPPS] move settings-related stuff to a separate file
* [RAPPS] refactor reg read/write
* [RAPPS] add params for Load/SaveSettings, no longer use global vars
He Yang [Wed, 26 Aug 2020 09:10:51 +0000 (17:10 +0800)]
[RAPPS] improve ConInitStdStreams initialization logic (#3098)
He Yang [Tue, 25 Aug 2020 09:06:30 +0000 (17:06 +0800)]
[RAPPS] cmdline enhancement (#3087)
* [RAPPS] now command-line option supports begin with both / and -
* [RAPPS] Add help command with /?
* [RAPPS] add /find command
* [RAPPS] add /info option
* [RAPPS] add copyright and contact e-mail
赫杨 [Wed, 19 Aug 2020 13:44:50 +0000 (21:44 +0800)]
[RAPPS] Display package name in UI too
赫杨 [Sun, 16 Aug 2020 19:04:45 +0000 (03:04 +0800)]
[RAPPS] now /INSTALL option use PkgName instead of software name
currently, PkgName is the name of ini file in DB (without suffix)
赫杨 [Sun, 16 Aug 2020 18:46:37 +0000 (02:46 +0800)]
[RAPPS] add m_szPkgName for AvailableApps
赫杨 [Sat, 15 Aug 2020 19:38:28 +0000 (03:38 +0800)]
[RAPPS] reduce the chance assert failed
赫杨 [Wed, 5 Aug 2020 09:22:07 +0000 (17:22 +0800)]
[RAPPS] some renaming
赫杨 [Mon, 3 Aug 2020 13:54:01 +0000 (21:54 +0800)]
[RAPPS] fix the bug that Toolbar is not working
赫杨 [Fri, 31 Jul 2020 19:57:35 +0000 (03:57 +0800)]
[RAPPS] update some file-header
update some header to newer format, update purpose and add my name to those file I've modified
He Yang [Wed, 29 Jul 2020 10:50:57 +0000 (18:50 +0800)]
[RAPPS] appview displaymode support (#3008)
* [RAPPS] add function to set view-mode
* [RAPPS] move toolbar and searchbar into appview
* [RAPPS] remove settings and exit button from toolbar
* [RAPPS] add code to switch between list and tile mode
* [RAPPS] add auto-arrange for listview
* [RAPPS] adjust the minimum size of AppView
* [RAPPS] now image list of listview is stored inside the class
* [RAPPS] add list mode, and old list-mode are detail mode now
* [RAPPS] add check for unimplemented view mode
He Yang [Fri, 24 Jul 2020 08:07:43 +0000 (16:07 +0800)]
[RAPPS] application-view refactor (#3003)
* [RAPPS] separate application-view from gui.cpp
* [RAPPS] make the code looks more clear
* [RAPPS] fix & improve tab-order handle
* [RAPPS] now double-click / right-click & install an item will install exactly this app
* [RAPPS] add handling for DWORD timestamp for InstallDate
* [RAPPS] make the code setting column style more clear
* [RAPPS] change the owner of popup-menu
* [RAPPS] now the popup menu (the one when right-click listview) now belongs to application-view
He Yang [Tue, 21 Jul 2020 14:13:39 +0000 (22:13 +0800)]
[RAPPS] listview refactor (#2970)
This makes it easier to maintain the listview, and better separates the application list and listview.
* [RAPPS] fix memory leak when cleanup. some renaming are also done
* [RAPPS] move the code adding apps info inside class CAppsListView
* [RAPPS] add table view, create listview and AppInfoDisplay inside it
* [RAPPS] rename INSTALLED_INFO as CInstalledApplicationInfo
now it corresponds with CAvailableApplicationInfo
* [RAPPS] add CInstalledApps
* [RAPPS] optimize the speed when refreshing listview
* [RAPPS] correctly handle Enum for InstalledApps
* [RAPPS] make check all working properly (this also fixes some bugs)
the old version has some bugs when check all items after switching tags in tree-view
* [RAPPS] add handling for wow64
* [RAPPS] use an inline function to replace INSERT_TEXT macro
* [RAPPS] fix the bug that StatusBar won't update when switching tags
* [RAPPS] now TableView always reset bIsAscending in SetDisplayMode
* [RAPPS] rename TableView to ApplicationView
* [RAPPS] now bIsAscending would be reset when switching column in listview
He Yang [Mon, 29 Jun 2020 20:40:40 +0000 (04:40 +0800)]
[RAPPS] move icon to a field in .txt file (#2941)
* [RAPPS] move icon to a field in .txt file
* [RAPPS] add function PathAppendNoDirEscapeW, apply it.
He Yang [Sun, 21 Jun 2020 16:20:45 +0000 (00:20 +0800)]
[RAPPS] rename snapshot to screenshot, filename to location (#2939)
赫杨 [Sat, 20 Jun 2020 05:00:02 +0000 (13:00 +0800)]
[RAPPS] update broken-img icon
He Yang [Sun, 21 Jun 2020 10:26:41 +0000 (18:26 +0800)]
[RAPPS] snapshot url support (#2925)
* [RAPPS] add snapshot url support
* [RAPPS] fix snapshot prev window won't update if size not changed
* [RAPPS] fix crash after cancel download
* [RAPPS] show broken-img if failed to create file / make network request
* [RAPPS] create a snapshots folder if it does not exist
* [RAPPS] add a helper function to perform callback
* [RAPPS] check bIsCancelled when handling ERROR_INVALID_HANDLE
* [RAPPS] remove W suffix for AsyncInetDownload
* [RAPPS] add assert for unknown event
* [RAPPS] Improve AsyncInetDownload error handling
* [RAPPS] move DisplayFailed to private, fix crash when cancelling
* [RAPPS] check for ERROR_INTERNET_OPERATION_CANCELLED
* [RAPPS] improve error logging
* [RAPPS] remove \r in error logging
* [RAPPS] rewrite AsyncInet
He Yang [Sun, 14 Jun 2020 13:22:58 +0000 (21:22 +0800)]
[RAPPS] Screenshot preview and other trivial fixes (#2894)
* add one more layer of window
* using Path* API to operate path
* always use rappmgr.cab as file name when downloading db. ignore the URL
* add snapshot preview window
* show a broken-image icon when failed to load image
* add a padding between image and content, and make sure always some space is reserved for richedit
* hide the padding if snapshot window does not have a width
* some work to avoid blinking when window resizing
* add WM_PRINTCLIENT handling
He Yang [Fri, 5 Jun 2020 15:32:08 +0000 (23:32 +0800)]
[RAPPS] add a layer of window above the richedit (#2871)
* add one more layer of window
* use ATL to create window
* set pLink to NULL to avoid wild pointer
Katayama Hirofumi MZ [Sun, 6 Sep 2020 13:48:29 +0000 (22:48 +0900)]
[SHELL32] Make 'hwndServer == NULL' spams quiet
Katayama Hirofumi MZ [Sun, 6 Sep 2020 12:51:08 +0000 (21:51 +0900)]
[BROWSEUI_APITEST] Follow-up of #3123 (
94a413a)
Mark Jansen [Sun, 6 Sep 2020 12:32:59 +0000 (14:32 +0200)]
[BROWSEUI] Stop the address edit box trying to parse a null pidl
Mark Jansen [Sun, 6 Sep 2020 12:28:56 +0000 (14:28 +0200)]
[ZIPFLDR] Fix PathCompactPathW writing out of bounds
CORE-17245
Joachim Henze [Sun, 6 Sep 2020 02:35:33 +0000 (04:35 +0200)]
[CMAKE] Fix regressions CORE-17243 & CORE-17246
By sledge-hammer-reverting of
0.4.15-dev-689-g
7ffb6a09c370ef51de554a1ce913f871d72b76ca
and 0.4.15-dev-688-g
1234223f417c2ea9617af0f7a1d80934861eb7d1
Sorry, but the negative impact for other devs and the
whole project are just unbearable.
Stuff got committed meanwhile even so I had to act.
The improvements may be reapplied later when the
negative consequences are under control.
Katayama Hirofumi MZ [Sat, 5 Sep 2020 23:03:09 +0000 (08:03 +0900)]
[BROWSEUI_APITEST] Strengthen SHExplorerParseCmdLine testcase a bit (#3123)
CORE-14177
Kyle Katarn [Sat, 5 Sep 2020 14:59:10 +0000 (16:59 +0200)]
[NTUSER] Demote ERR to TRACE, also some minor corrections (#3132)
Katayama Hirofumi MZ [Sat, 5 Sep 2020 09:46:49 +0000 (18:46 +0900)]
[EXPLORER] Implement HSHELL_ACTIVATESHELLWINDOW (#3125)
Implement HSHELL_ACTIVATESHELLWINDOW shell hook.
Hermès Bélusca-Maïto [Thu, 3 Sep 2020 22:17:15 +0000 (00:17 +0200)]
[CMD] Code formatting for IsValidPathName, IsExistingFile, IsExistingDirectory, and use INVALID_FILE_ATTRIBUTES instead of an hardcoded value.
Kyle Katarn [Thu, 3 Sep 2020 19:20:54 +0000 (21:20 +0200)]
[SETUP] French translation of missing elements (#3111)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>