Amine Khaldi [Mon, 3 Nov 2014 14:36:57 +0000 (14:36 +0000)]
[SHELL32]
* Move control.cpp to the wine folder.
* Rename control.cpp to control.c.
* Partially sync control.c with Wine 1.7.27.
CORE-8540
svn path=/branches/shell-experiments/; revision=65224
Amine Khaldi [Mon, 3 Nov 2014 13:59:23 +0000 (13:59 +0000)]
[SHELL32]
* Move shpolicy.cpp to the wine folder.
* Rename shpolicy.cpp to shpolicy.c.
* Sync shpolicy.c with Wine 1.7.27.
CORE-8540
svn path=/branches/shell-experiments/; revision=65223
Amine Khaldi [Mon, 3 Nov 2014 13:43:01 +0000 (13:43 +0000)]
[SHELL32]
* Apply Wine commit
e330a128 by Alexandre Julliard: Use Shell_GetImageLists to retrieve image lists instead of using a global variable.
CORE-8540
svn path=/branches/shell-experiments/; revision=65222
Amine Khaldi [Mon, 3 Nov 2014 13:29:18 +0000 (13:29 +0000)]
[SHELL32]
* Move shellpath.cpp to the wine folder.
* Rename shellpath.cpp to shellpath.c.
* Partially sync shellpath.c with Wine 1.7.27.
CORE-8540
svn path=/branches/shell-experiments/; revision=65221
Amine Khaldi [Mon, 3 Nov 2014 12:17:30 +0000 (12:17 +0000)]
[SHELL32]
* Move shell32_main.cpp to the wine folder.
* Rename shell32_main.cpp to shell32_main.c.
* Partially sync shell32_main.c with Wine 1.7.27.
* Update the location of shell32_main.h in inclusions.
CORE-8540
svn path=/branches/shell-experiments/; revision=65217
Amine Khaldi [Mon, 3 Nov 2014 12:13:40 +0000 (12:13 +0000)]
[SHELL]
* Mark _ILGetExtension and _ILGetFileType as EXTERN_C.
* __inline before return type.
* Some tiny style consistency fixes.
svn path=/branches/shell-experiments/; revision=65216
Amine Khaldi [Mon, 3 Nov 2014 12:10:23 +0000 (12:10 +0000)]
[SHELL]
* __inline before return type.
svn path=/branches/shell-experiments/; revision=65215
Giannis Adamopoulos [Mon, 3 Nov 2014 11:33:23 +0000 (11:33 +0000)]
[EXPLORER_NEW]
- Fix build
svn path=/branches/shell-experiments/; revision=65214
Amine Khaldi [Mon, 3 Nov 2014 10:52:20 +0000 (10:52 +0000)]
[SHELL32]
* Allow shdebugstr_guid() to be used from C code too.
* Move shellole.cpp to the wine folder.
* Rename shellole.cpp to shellole.c.
* Sync shellole.c with Wine 1.7.27.
CORE-8540
svn path=/branches/shell-experiments/; revision=65213
Giannis Adamopoulos [Mon, 3 Nov 2014 10:38:21 +0000 (10:38 +0000)]
[SHELL32]
- Add shell32.cpp and move there CShell32Module, DllGetVersion, DllMain, DllCanUnloadNow, DllGetClassObject, DllRegisterServer, DllUnregisterServer, DllInstall, IDefClFImpl, IDefClF_fnConstructor and SHCreateDefClassObject
- Now shell32_main.cpp and shellole.cpp have code that can be converted back to C and synced to wine
svn path=/branches/shell-experiments/; revision=65212
Giannis Adamopoulos [Mon, 3 Nov 2014 10:12:24 +0000 (10:12 +0000)]
[SHELL32]
- Move SHGetDesktopFolder to desktop.cpp
svn path=/branches/shell-experiments/; revision=65211
David Quintana [Mon, 3 Nov 2014 04:16:56 +0000 (04:16 +0000)]
[EXPLORER-NEW]
* Rename a few I<x>Impl to C<x>
* Refactor the toolbar code of notification area into its own class.
* Also refactor away the code specific to the toolbar control into a CToolbar class. Todo: move the CToolbar class into some header file.
svn path=/branches/shell-experiments/; revision=65209
Giannis Adamopoulos [Sun, 2 Nov 2014 23:50:54 +0000 (23:50 +0000)]
[SHELL32]
- Remove an old todo file that described the things that were implemented in the shell-experiments branch
svn path=/branches/shell-experiments/; revision=65208
Giannis Adamopoulos [Sun, 2 Nov 2014 23:41:24 +0000 (23:41 +0000)]
[SHELL32]
- Move shellstring.c to a new folder called wine. More files should be moved there eventually.
svn path=/branches/shell-experiments/; revision=65207
Giannis Adamopoulos [Sun, 2 Nov 2014 23:30:48 +0000 (23:30 +0000)]
[SHELL32]
- Move files that implement dialogs and property sheets in dialogs folder
svn path=/branches/shell-experiments/; revision=65206
Giannis Adamopoulos [Sun, 2 Nov 2014 22:52:49 +0000 (22:52 +0000)]
[SHELL32]
- Remove authors.cpp
svn path=/branches/shell-experiments/; revision=65201
David Quintana [Sun, 2 Nov 2014 22:26:44 +0000 (22:26 +0000)]
[EXPLORER-NEW]
* Refactor startmnu.cpp into three separate files. startctxmnu.cpp contains the context menu handler for the start button, and startmnusite.cpp contains the former IStartMenuSiteImpl, renamed to CStartMenuSite.
svn path=/branches/shell-experiments/; revision=65200
David Quintana [Sun, 2 Nov 2014 21:52:54 +0000 (21:52 +0000)]
[EXPLORER-NEW]
* Refactor the desktop thread/creation code.
svn path=/branches/shell-experiments/; revision=65199
David Quintana [Sun, 2 Nov 2014 20:18:54 +0000 (20:18 +0000)]
[EXPLORER-NEW]
* Convert codebase to C++ and make use of C++ classes for the COM objects.
svn path=/branches/shell-experiments/; revision=65197
David Quintana [Sun, 2 Nov 2014 20:17:23 +0000 (20:17 +0000)]
[RSHELL]
[STOBJECT]
* Some nitpicking.
[SHELL32]
* Fix missing null-termination by using proper string literals.
svn path=/branches/shell-experiments/; revision=65194
David Quintana [Sun, 2 Nov 2014 20:13:56 +0000 (20:13 +0000)]
[SHELL32]
* Fix GCC build.
svn path=/branches/shell-experiments/; revision=65193
Giannis Adamopoulos [Sun, 2 Nov 2014 17:49:28 +0000 (17:49 +0000)]
[SHELL32]
- Remove lots of typecasts in CDefView
- Use strict typed itemids
svn path=/branches/shell-experiments/; revision=65185
Amine Khaldi [Sun, 2 Nov 2014 16:12:38 +0000 (16:12 +0000)]
* Sync up to trunk head (r65183).
svn path=/branches/shell-experiments/; revision=65184
Giannis Adamopoulos [Sun, 2 Nov 2014 13:35:03 +0000 (13:35 +0000)]
[ATL]
- Add a couple of macros needed for the time we will be able to support aggregation with ATL
svn path=/branches/shell-experiments/; revision=65182
Amine Khaldi [Sun, 2 Nov 2014 11:16:37 +0000 (11:16 +0000)]
[SHELL32]
* Fix GCC build.
svn path=/branches/shell-experiments/; revision=65180
Giannis Adamopoulos [Sun, 2 Nov 2014 00:26:22 +0000 (00:26 +0000)]
[SHELL32]
- Add an evil header that is going to simplify our C++ code in the shell a lot
- Use the new CListView in the implementation of CDefView to make it more readable and maintainable
svn path=/branches/shell-experiments/; revision=65176
Giannis Adamopoulos [Fri, 31 Oct 2014 22:32:01 +0000 (22:32 +0000)]
[RSHELL]
- A HACK notice was more obvious than needed (I got what I asked after all).
- Reenable opening the printers folder since it works now
svn path=/branches/shell-experiments/; revision=65161
Giannis Adamopoulos [Fri, 31 Oct 2014 22:30:21 +0000 (22:30 +0000)]
[SHELL32]
- Do not release the pointer to the ShellView that was just created
- Fixes a crash when showing the Printers shell folder
svn path=/branches/shell-experiments/; revision=65160
David Quintana [Fri, 31 Oct 2014 18:37:40 +0000 (18:37 +0000)]
[BROWSEUI]
* Implement hiding the statusbar from the view menu. Based on patch by Christoph von Wittich.
svn path=/branches/shell-experiments/; revision=65158
David Quintana [Fri, 31 Oct 2014 15:57:56 +0000 (15:57 +0000)]
[EXPLORER-NEW]
* Some nitpicking.
[STOBJECT]
* Fix the notification not having an assigned callback message id.
svn path=/branches/shell-experiments/; revision=65151
Amine Khaldi [Fri, 31 Oct 2014 15:32:05 +0000 (15:32 +0000)]
[INCLUDE/REACTOS]
* Fix GCC build.
svn path=/branches/shell-experiments/; revision=65149
Amine Khaldi [Fri, 31 Oct 2014 15:27:51 +0000 (15:27 +0000)]
* Sync up to trunk head (r65147).
svn path=/branches/shell-experiments/; revision=65148
Amine Khaldi [Fri, 31 Oct 2014 15:16:51 +0000 (15:16 +0000)]
[SHELL32]
* Rename shellstring.cpp to shellstring.c and update it against Wine 1.7.27.
CORE-8540
svn path=/trunk/; revision=65147
Amine Khaldi [Fri, 31 Oct 2014 14:29:26 +0000 (14:29 +0000)]
[SHELL32]
* Move TRASH_CanTrashFile and TRASH_TrashFile declarations to recyclebin.h.
* Do not include xdg.h in shlfileop.cpp anymore.
* Remove the now unneeded xdg.h.
svn path=/trunk/; revision=65146
Pierre Schweitzer [Fri, 31 Oct 2014 14:21:35 +0000 (14:21 +0000)]
[NTFS]
- Move FSCTL_GET_NTFS_VOLUME_DATA implementation in its own function GetNfsVolumeData(), so remove it from NtfsUserFsRequest()
- Add support for FSCTL_GET_NTFS_FILE_RECORD in NtfsUserFsRequest()
- Implement GetNtfsFileRecord() which returns a file record. Not fully sure about its implementation, this is to be checked.
This does not really improve the nfi situation in any kind yet...
CORE-8725
svn path=/trunk/; revision=65145
Pierre Schweitzer [Fri, 31 Oct 2014 14:16:15 +0000 (14:16 +0000)]
[NTOSKRNL]
Testman confirms that IopParseDevice() hack is no longer required.
So, this is the end of this 8y old hack.
Now ReactOS is able to properly use its storage stack (who said, amazing?)
Bisous IopParseDevice() hack :-)
svn path=/trunk/; revision=65144
Jérôme Gardou [Fri, 31 Oct 2014 11:35:32 +0000 (11:35 +0000)]
[OPENGL32]
- Do not crash if thread data was not allocated
svn path=/trunk/; revision=65143
Pierre Schweitzer [Fri, 31 Oct 2014 11:22:26 +0000 (11:22 +0000)]
[NTOSKRNL]
Revert r65120...
Which was reverting r65119...
Which was reverting r65117...
Which was reverting r65110...
Which was reverting r65107...
Which was reverting r65104!
To make it short? Fuck you IopParseDevice() hack!
And this time, I hope this is the right one!
I couldn't reproduce any of the previous issues in my WC.
svn path=/trunk/; revision=65142
Pierre Schweitzer [Fri, 31 Oct 2014 11:17:43 +0000 (11:17 +0000)]
[NTOSKRNL]
Some fixes and missing implementations in RawFS:
- Remove some magic values for VCB state
- Add a local VPB in our VCB. This will allow diverting the IO VPB with ours in case of dismount (and thus, will fix dismount)
- Implement support for said VPB in both RawCheckForDismount() and RawInitializeVcb()
- Now, dismount is handled in RawCheckForDismount() directly, and not in functions calling it
- Handle streams in RawClose
- Handle VCB being dismounted in RawCreate()
- Handle dismount also in RawCleanup() (not only in RawClose())
This fixes volume locking and dismounting in RawFS. And thus, allows FS swap in case of raw volume formating in first stage :-).
More to follow!
svn path=/trunk/; revision=65141
Jérôme Gardou [Fri, 31 Oct 2014 11:04:12 +0000 (11:04 +0000)]
[FASTFAT]
- Fix renaming files in case the target file already exists.
- Plug a few reference count leaks on FCBs.
CORE-8660 #comment fixed in r65140 #resolve
CORE-8633 #comment fixed in r65140 #resolve
CORE-4758 #comment fixed in r65140 #resolve
svn path=/trunk/; revision=65140
Jérôme Gardou [Fri, 31 Oct 2014 11:03:56 +0000 (11:03 +0000)]
[NTOS/SE]
- Allocate the new ACL for the token with the right pool.
Fixes google chrome BAD_POOL_CALLER bugcheck.
svn path=/trunk/; revision=65139
Amine Khaldi [Fri, 31 Oct 2014 10:40:48 +0000 (10:40 +0000)]
[FTP]
* Plug a leak. CID 513875.
CORE-7975
svn path=/trunk/; revision=65138
Amine Khaldi [Fri, 31 Oct 2014 10:24:48 +0000 (10:24 +0000)]
[LOGOFF]
* LocalFree should only be executed if AllocAndLoadString() succeeds. Spotted by Thomas Faber.
svn path=/trunk/; revision=65137
Amine Khaldi [Fri, 31 Oct 2014 10:20:55 +0000 (10:20 +0000)]
[IPCONFIG]
* Plug some leaks. CIDs 716301 => 716305.
CORE-7975
svn path=/trunk/; revision=65136
Amine Khaldi [Fri, 31 Oct 2014 09:53:18 +0000 (09:53 +0000)]
[FINGER]
* Addendum to r37084.
* Really fixes CIDs 500624 and 500625 which were marked as fixed.
CORE-7975
svn path=/trunk/; revision=65135
Amine Khaldi [Fri, 31 Oct 2014 09:43:48 +0000 (09:43 +0000)]
[FINGER]
* Plug a leak. CID
1102406.
CORE-7975
svn path=/trunk/; revision=65134
Amine Khaldi [Fri, 31 Oct 2014 09:22:59 +0000 (09:22 +0000)]
[LOGOFF]
* Plug some leaks. CIDs 716284 and 716285.
CORE-7975
svn path=/trunk/; revision=65133
Amine Khaldi [Fri, 31 Oct 2014 09:08:43 +0000 (09:08 +0000)]
[SHELL32]
* Plug a leak. CID 716474.
CORE-7975
svn path=/trunk/; revision=65132
Kamil Hornicek [Fri, 31 Oct 2014 00:21:03 +0000 (00:21 +0000)]
[WIN32K]
- check for an attached surface a bit earlier in GreExtTextOutW
- fixes Foobar 2000
CORE-7425
svn path=/trunk/; revision=65131
Pierre Schweitzer [Thu, 30 Oct 2014 21:12:38 +0000 (21:12 +0000)]
[VFATLIB]
When we're done with formatting, attempt to umount the volume, so that it can be remounted properly by FastFAT.
svn path=/trunk/; revision=65130
Pierre Schweitzer [Thu, 30 Oct 2014 20:56:40 +0000 (20:56 +0000)]
[FASTFAT]
On the road for getting rid of IopParseDevice() hack....
- Add support for FSCTL_LOCK_VOLUME, FSCTL_UNLOCK_VOLUME, FSCTL_DISMOUNT_VOLUME in VfatFileSystemControl()
- Implement VfatLockOrUnlockVolume(). This brings some kind of volume locking to FastFAT FSD. It's likely not fully accurate and welcome to race conditions. But, its main purpose is to be used in usetup. So, this is fine for now.
- Stubplement VfatDismountVolume(). This will be implemented later on, but should be relatively straightforward as it requires volume to be locked (so, we're the last ones on it :-)).
svn path=/trunk/; revision=65129
Sylvain Petreolle [Thu, 30 Oct 2014 20:50:30 +0000 (20:50 +0000)]
[APPWIZ][SYSSETUP]
Enforce focus of the Wine Gecko download prompt in second stage.
Patch by Ismael Ferreras Morezuelas (swyter)
svn path=/trunk/; revision=65128
Hervé Poussineau [Thu, 30 Oct 2014 20:22:57 +0000 (20:22 +0000)]
[FREELDR] Move down the requirement of highest usable address
This fixes PXE boot in QEMU, where highest usable address is 0x9c400.
svn path=/trunk/; revision=65127
Christoph von Wittich [Thu, 30 Oct 2014 19:00:19 +0000 (19:00 +0000)]
[EXPLORER-NEW]
fix gcc build
svn path=/branches/shell-experiments/; revision=65125
David Quintana [Thu, 30 Oct 2014 14:55:56 +0000 (14:55 +0000)]
[EXPLORER_NEW]
* Cleanup some window procs.
* Fix some redraw issues in the notification area due to misuse of themeing.
svn path=/branches/shell-experiments/; revision=65124
Amine Khaldi [Thu, 30 Oct 2014 13:29:44 +0000 (13:29 +0000)]
[BOOTDATA]
* Romanian translation update by Ștefan Fulea.
CORE-8630 #resolve #comment Committed in r65123. Thanks!
svn path=/trunk/; revision=65123
Kamil Hornicek [Thu, 30 Oct 2014 12:15:11 +0000 (12:15 +0000)]
[INTL]
- don't display garbage in the location combo box
svn path=/trunk/; revision=65122
Amine Khaldi [Thu, 30 Oct 2014 11:52:53 +0000 (11:52 +0000)]
* Sync up to trunk head (r65120).
svn path=/branches/shell-experiments/; revision=65121
Pierre Schweitzer [Thu, 30 Oct 2014 08:39:03 +0000 (08:39 +0000)]
[NTOSKRNL]
Actually enable again the hack...
For whatever reason, it works with my WC but not with clean trunk...
Where are the you, magic and silent patch that fixes it? :-(
svn path=/trunk/; revision=65120
Pierre Schweitzer [Thu, 30 Oct 2014 07:49:37 +0000 (07:49 +0000)]
[NTOSKRNL]
Finally, disable again the IopParseDevice hack.
Just for the record, opening a volume with FILE_READ_EA or FILE_READ_DATA is legal and works in Windows (NTFS Info for instance opens it with GENERIC_READ).
Let's hope we can rid of this hack forever now... It's been with us since 2006!
svn path=/trunk/; revision=65119
Pierre Schweitzer [Thu, 30 Oct 2014 07:46:25 +0000 (07:46 +0000)]
[FASTFAT]
Don't over-reference our FCB in case of volume opening (vfatAttachFCBToFileObject() already references it).
This fixes 1st stage and beyond with IopParseDevice hack off
svn path=/trunk/; revision=65118
Pierre Schweitzer [Wed, 29 Oct 2014 23:28:15 +0000 (23:28 +0000)]
[NTOSKRNL]
Reenable IopParseDevice hack for now.
Out of fixes for tonight.
svn path=/trunk/; revision=65117
Pierre Schweitzer [Wed, 29 Oct 2014 23:10:31 +0000 (23:10 +0000)]
[FASTFAT]
Now that we start to honor the storage stack (ie, without the IopParseDevice hack ;-)), we have to let FSDs forward device IOCTLs.
This allows back copying files on 1st stage
svn path=/trunk/; revision=65116
Pierre Schweitzer [Wed, 29 Oct 2014 22:51:16 +0000 (22:51 +0000)]
[FASTFAT]
Don't attempt to mount any partition just because we have a valid partition table...
Restrict this to them being marked as FAT or compatible.
svn path=/trunk/; revision=65115
David Quintana [Wed, 29 Oct 2014 22:50:27 +0000 (22:50 +0000)]
[RSHELL]
* Hopefully fix the start menu closing randomly. May have side-effects, but I think it's best to be conservative here and prefer the possibility of the menu staying open unexpectedly, rather than closing unexpectedly.
svn path=/branches/shell-experiments/; revision=65114
Pierre Schweitzer [Wed, 29 Oct 2014 22:40:16 +0000 (22:40 +0000)]
[NTFS]
Addendum to r65112
svn path=/trunk/; revision=65113
Pierre Schweitzer [Wed, 29 Oct 2014 22:36:55 +0000 (22:36 +0000)]
[NTFS]
Implement support for the FSCTL_GET_NTFS_VOLUME_DATA user request in NtfsUserFsRequest().
This makes NTFSInfo capable of working in ReactOS :-). A picture to show it: http://www.heisspiter.net/~Pierre/rostests/NTFS_info.png
Yes, NTFS Zone isn't computed yet. I'll have a look at it later on.
This doesn't fix nfi.exe though. If it can get its data, it cannot continue. It loops forever on a FSCTL we don't handle yet.
CORE-8725
svn path=/trunk/; revision=65112
David Quintana [Wed, 29 Oct 2014 22:28:51 +0000 (22:28 +0000)]
[BROWSEUI]
* Allow the static items in the Favorites menu to be received by the shell browse window.
* Handle the Organize Favorites menu item by opening either the USER favorites, or the COMMON version of the folder.
[RSHELL]
* Send the proper HWND together with the HMENU, when sending callbacks.
svn path=/branches/shell-experiments/; revision=65111
Sylvain Petreolle [Wed, 29 Oct 2014 22:22:24 +0000 (22:22 +0000)]
[NTOSKRNL]
Reapply r65107.
We need fixes, not hacks.
Sorry for being popular^W pressure ;)
svn path=/trunk/; revision=65110
Eric Kohl [Wed, 29 Oct 2014 22:17:23 +0000 (22:17 +0000)]
[NETAPI32]
NetUserModalsGet:
- Return the proper maximum password age.
- Remove dead code.
svn path=/trunk/; revision=65109
Sylvain Petreolle [Wed, 29 Oct 2014 21:34:01 +0000 (21:34 +0000)]
[UNIATA]
Update to 0.45c1.
svn path=/trunk/; revision=65108
Pierre Schweitzer [Wed, 29 Oct 2014 21:22:36 +0000 (21:22 +0000)]
[NTOSKRNL]
Reenable hack due to popular pressure.
Still better than fixing it, it seems...
So, break again volume opening.
svn path=/trunk/; revision=65107
Pierre Schweitzer [Wed, 29 Oct 2014 18:42:05 +0000 (18:42 +0000)]
[NTFS]
Finally, move old stuff back from disk.sys to ntfs.sys now it can be properly reached on volume opening:
- Halfplement NtfsUserFsRequest() and add support for IRP_MN_USER_FS_REQUEST in NtfsFsdFileSystemControl()
- Also, use the proper FSCTL code: FSCTL_GET_NTFS_VOLUME_DATA which exists and is documented instead of FSCTL_GET_NTFS_VOLUME_DATA. Spotted by Christoph.
CORE-8725
svn path=/trunk/; revision=65106
Pierre Schweitzer [Wed, 29 Oct 2014 18:25:30 +0000 (18:25 +0000)]
[DISK]
Revert r65097 and r65090.
Thanks to r65104, now the FSCTLs go to the right place: the FSDs!
Thanks to Thomas for pointing out that NTFSinfo was really talking with the FSD on Windows and not to disk.sys
CORE-8725
svn path=/trunk/; revision=65105
Pierre Schweitzer [Wed, 29 Oct 2014 18:20:43 +0000 (18:20 +0000)]
[NTOSKRNL]
Disable the IopParseDevice hack. It appears it was triggered on volume opening and thus was breaking volume opening which were then forwarded down to disk.sys.
Not sure how legit it is to have it anylonger.
At least, disabling it reenables volume opening in ReactOS and associated FSCTL!
Alex & Aleksey, can you review please?
CORE-8725
svn path=/trunk/; revision=65104
Kamil Hornicek [Wed, 29 Oct 2014 18:20:03 +0000 (18:20 +0000)]
[NLS]
- fix the code page value
- also fixes intl.cpl showing date format string in the code page list
svn path=/trunk/; revision=65103
Kamil Hornicek [Wed, 29 Oct 2014 16:59:44 +0000 (16:59 +0000)]
[KERNEL32]
- remove bunch of stray pragmas
- add a czech translation to stop debug spam reported in CORE-8720
svn path=/trunk/; revision=65102
Kamil Hornicek [Wed, 29 Oct 2014 14:27:09 +0000 (14:27 +0000)]
[BOOTDATA]
- add metrics to classic themes (the flag 0xb0001 will result in a kinda esoteric value of type REG_QWORD)
- fixes switching from Lautus back to a classic theme
CORE-8718
svn path=/trunk/; revision=65100
David Quintana [Wed, 29 Oct 2014 12:32:46 +0000 (12:32 +0000)]
[BROWSEUI]
* Fix a 'pasta.
* Open something less stupid when clicking on "Is this copy legal?" in the Help menu.
svn path=/branches/shell-experiments/; revision=65099
David Quintana [Wed, 29 Oct 2014 11:52:45 +0000 (11:52 +0000)]
[RSHELL]
* Fix assumption that the USER folder will always exist and only the COMMON folder may be missing. Allows the Start Menu to work in livecd.
[BROWSEUI]
* Apply the same fix to the Favorites folder, although the LiveCD does not currently have the folder so it will not work regardless.
svn path=/branches/shell-experiments/; revision=65098
Pierre Schweitzer [Wed, 29 Oct 2014 11:31:19 +0000 (11:31 +0000)]
[DISK]
Actually, sysinternals used to release the source code of NTFSInfo (thanks Christoph!), so we know a bit more about the interface of the user FS request.
So, implement a bit more of the interface to validate it properly works (and so far, it does!)
CORE-8725
svn path=/trunk/; revision=65097
Amine Khaldi [Wed, 29 Oct 2014 11:25:42 +0000 (11:25 +0000)]
* Sync up to trunk head (r65095).
* Thank you Kamil for r65087 ;)
svn path=/branches/shell-experiments/; revision=65096
David Quintana [Wed, 29 Oct 2014 11:14:28 +0000 (11:14 +0000)]
[BROWSEUI]
* Implement File->Close
svn path=/branches/shell-experiments/; revision=65095
David Quintana [Tue, 28 Oct 2014 22:28:28 +0000 (22:28 +0000)]
[BROWSEUI]
* Implement executing the items from the Favorites menu.
svn path=/branches/shell-experiments/; revision=65094
Timo Kreuzer [Tue, 28 Oct 2014 22:16:24 +0000 (22:16 +0000)]
[GDI32]
Improve functions in coord.c:
- Use GdiGetDcAttr() where appropriate
- Fix SetLastError() usage
- Add annotations
- improve variable naming
- Add some comments
svn path=/trunk/; revision=65093
David Quintana [Tue, 28 Oct 2014 22:13:18 +0000 (22:13 +0000)]
[RSHELL]
* Remove a few GCC unused-but-set-variable warnings.
svn path=/branches/shell-experiments/; revision=65092
Pierre Schweitzer [Tue, 28 Oct 2014 21:59:57 +0000 (21:59 +0000)]
[DISK]
Get ready to enter into the 10th dimension... So:
- Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl() function. The way it is added to the DriverObject is a big hack, class2 is not supposed to have such requests, so, we do it in its back. Fear!
- Stubplement the NtfsRussinovichism() function. This is the only function we're supposed to call with IRP MJ FSCTRL and with IRP MN USRFSRQST. Its purpose (when its implemented) is to reply back to the M. Russinovich tools (NFI & NTFSInfo) so that they can directly dump NTFS information without going into NTFS driver. They kind of bypass it.
We do all agree this is a ugly hack. But it exists in Windows, as these tools work in Windows. And it would be useful they actually work in ReactOS.
Soon, we'll be able to publish a book "ReactOS Internals" where we speak about undocumented FS controls to dump NTFS information to show how well our NTFS works ;-).
svn path=/trunk/; revision=65090
Eric Kohl [Tue, 28 Oct 2014 21:57:41 +0000 (21:57 +0000)]
[NET]
Display more password information in the NET USER command.
svn path=/trunk/; revision=65089
David Quintana [Tue, 28 Oct 2014 21:40:50 +0000 (21:40 +0000)]
[RSHELL]
* CMenuBand: Refcount before assigning a return pointer.
* CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will be exactly one OnFinalMessage for each OnCreate.
* CMenuToolbars: Add a debug message.
* CStartMenu: Refcount correctly.
svn path=/branches/shell-experiments/; revision=65088
Kamil Hornicek [Tue, 28 Oct 2014 21:38:26 +0000 (21:38 +0000)]
[WIN32K]
- addendum to revision 64877 which slightly changed UserDrawCaption's logic
- fixes window title being drawn over the icon
svn path=/trunk/; revision=65087
Timo Kreuzer [Tue, 28 Oct 2014 21:09:01 +0000 (21:09 +0000)]
[GDI32]
- Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)
svn path=/trunk/; revision=65086
Pierre Schweitzer [Tue, 28 Oct 2014 20:39:42 +0000 (20:39 +0000)]
[FASTFAT]
For now, disable the VfatSetRenameInformation() asserts in trunk.
They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out.
CORE-8721 #resolve #comment Fixed with r65085
svn path=/trunk/; revision=65085
Giannis Adamopoulos [Tue, 28 Oct 2014 19:52:04 +0000 (19:52 +0000)]
Revert unwanted change
svn path=/branches/shell-experiments/; revision=65084
Giannis Adamopoulos [Tue, 28 Oct 2014 19:50:49 +0000 (19:50 +0000)]
[RSHELL]
- Do not release CMenuDeskBar more times than necessary
- Should fix the start menu
svn path=/branches/shell-experiments/; revision=65083
Pierre Schweitzer [Tue, 28 Oct 2014 19:17:59 +0000 (19:17 +0000)]
[NTFS]
Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free space on a volume.
The implementation is likely under-optimized... But wwell, the rest of the FSD is not better. Who talked about caching?! ;-)
Because pictures are more relevant than words in such case: http://www.heisspiter.net/~Pierre/rostests/NTFS_disksize.png
svn path=/trunk/; revision=65082
David Quintana [Tue, 28 Oct 2014 18:37:44 +0000 (18:37 +0000)]
[BROWSEUI]
* Disable the Tools menu items until they are implemented.
svn path=/branches/shell-experiments/; revision=65081
David Quintana [Tue, 28 Oct 2014 18:32:21 +0000 (18:32 +0000)]
[BROWSEUI]
* Properly return the toolbar status on QueryStatus.
* Properly make use of the returned into from QueryStatus.
svn path=/branches/shell-experiments/; revision=65080
David Quintana [Tue, 28 Oct 2014 17:33:22 +0000 (17:33 +0000)]
Fix GCC build.
svn path=/branches/shell-experiments/; revision=65078
Giannis Adamopoulos [Tue, 28 Oct 2014 17:32:01 +0000 (17:32 +0000)]
Merge r65001 from shell-experiments branch:
[user32]
- Properly notify the theme engine that the caption needs to be repainted on WM_SETICON
- Fixes a classic frame appearing when themes are enabled and we navigate to a different folder
svn path=/trunk/; revision=65077
Ged Murphy [Tue, 28 Oct 2014 17:07:47 +0000 (17:07 +0000)]
[WINLOGON]
- Stop the log from being spammed when the session is idle and no screensaver is set
- Also checking if my login still works :)
svn path=/trunk/; revision=65076