reactos.git
4 years ago[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655
Robert Naumann [Thu, 28 Jul 2016 13:27:33 +0000 (13:27 +0000)]
[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655

svn path=/trunk/; revision=72032

4 years ago[DOC]
Pierre Schweitzer [Thu, 28 Jul 2016 07:39:37 +0000 (07:39 +0000)]
[DOC]
Mark BTRFS as synced

svn path=/trunk/; revision=72031

4 years ago[CONSRV]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 23:30:53 +0000 (23:30 +0000)]
[CONSRV]
- Do not hardcode the values of some flags used with GetKeyState.
- Rework a bit the 'OnScroll' function.
- Implement mouse scrolling the console.
CORE-9900 #resolve
CORE-8394
- In mouse selection mode, allow the user to enlarge the current selection area by pressing the SHIFT key together with clicking on some point.

svn path=/trunk/; revision=72030

4 years ago[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need...
Amine Khaldi [Wed, 27 Jul 2016 21:38:56 +0000 (21:38 +0000)]
[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need to mention it in every single build.

svn path=/trunk/; revision=72028

4 years ago[SHELL32]
Giannis Adamopoulos [Wed, 27 Jul 2016 20:51:36 +0000 (20:51 +0000)]
[SHELL32]
- Query the drop effect from the key state. After latest wine sync we correctly get all possible effects instead of the effect of the last DragOver event.
CORE-11681

svn path=/trunk/; revision=72026

4 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:32:05 +0000 (19:32 +0000)]
[BTRFS]
Import three fixes from my local GitHub repository:
- Don't attempt to remove Vcb from list twice on shutdown
- Properly add CCB to root_file
- Init cache for root_file so that cache uninit on shutdown isn't problematic

This fixes BTRFS in ReactOS.
These fixes have already been submitted upstream (https://github.com/maharmstone/btrfs/pull/23).

CORE-11674

svn path=/trunk/; revision=72024

4 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:24:26 +0000 (19:24 +0000)]
[BTRFS]
Sync btrfs to 0.5.
This breaks BTRFS in ReactOS.

CORE-11674

svn path=/trunk/; revision=72023

4 years ago[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local difference...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:17:35 +0000 (19:17 +0000)]
[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request.
ROSTESTS_234

svn path=/trunk/; revision=72022

4 years ago[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:12:35 +0000 (19:12 +0000)]
[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine currently has).
CORE-11689

svn path=/trunk/; revision=72021

4 years ago[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:05:52 +0000 (19:05 +0000)]
[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path.
ROSTESTS-234

svn path=/trunk/; revision=72020

4 years ago[KMTESTS]
Pierre Schweitzer [Wed, 27 Jul 2016 16:40:30 +0000 (16:40 +0000)]
[KMTESTS]
Add missing dependency

svn path=/trunk/; revision=72019

4 years ago[NTOS:PO]
Thomas Faber [Wed, 27 Jul 2016 11:15:52 +0000 (11:15 +0000)]
[NTOS:PO]
- Send power IRPs to the top of the device stack instead of the PDO
CORE-10110 #resolve

svn path=/trunk/; revision=72017

4 years ago[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:48:41 +0000 (00:48 +0000)]
[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging 1.9.15.
(Add also the patch "Add patch to support IDF_CHECKFIRST in SetupPromptForDisk." by DarkPlayer - 541cc8d08661980dfe80fe2bb9dd27c91879e09f)

svn path=/trunk/; revision=72009

4 years ago[SETUPAPI]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:10:14 +0000 (00:10 +0000)]
[SETUPAPI]
- Transform the cached OsVersionInfo structure into a OSVERSIONINFOEXW that is then reused in SetupDiGetActualSectionToInstallExW.
- Remove few unused hardcoded strings.
- Add two TRACEs in SetupDiGetActualSectionToInstallExW to debug diverse INF file installation problems.
- parser.c: enclose the contents of the for-loop inside braces.
- Implement pSetupSetGlobalFlags and pSetupModifyGlobalFlags, see https://msdn.microsoft.com/en-us/library/bb432397(v=vs.85).aspx
- Popup an error message box in InstallHinfSectionW if an error happened and if interactive setup is allowed (through the global setup flags).

svn path=/trunk/; revision=72008

4 years ago[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:57:40 +0000 (19:57 +0000)]
[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously initialized.
CORE-10182 #resolve

svn path=/trunk/; revision=72007

4 years ago[INF]: Use the correct icon for audio controller devices in the device manager. By...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:09:18 +0000 (19:09 +0000)]
[INF]: Use the correct icon for audio controller devices in the device manager. By Jared Smudde.
CORE-11679 #resolve #comment Committed, thanks!

svn path=/trunk/; revision=72006

4 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 15:09:04 +0000 (15:09 +0000)]
[BROWSEUI]
- CExplorerBand: Implement showing the context menu on right click.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72004

4 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 14:31:38 +0000 (14:31 +0000)]
[BROWSEUI]
- CExplorerBand: Expand the tree view to the current folder when a new folder is browser (either with the addressbar or by double clicking a folder).
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72003

4 years ago[NTOSKRNL_VISTA]
Pierre Schweitzer [Mon, 25 Jul 2016 20:45:48 +0000 (20:45 +0000)]
[NTOSKRNL_VISTA]
Implement KeQueryActiveProcessorCount().

CORE-11674

svn path=/trunk/; revision=72001

4 years ago[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification...
Hermès Bélusca-Maïto [Mon, 25 Jul 2016 20:24:30 +0000 (20:24 +0000)]
[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification by myself):
◾ Don't return TRUE when CB_SETITEMDATA fails.
◾ Avoid pScheme NULL dereference if allocation fails. CID 1223154
◾ Avoid overflowing the destiny buffer by using StringCchCopy() CID 510953
and:
1) Make it more readable by returning as soon as possible when an error happens.
2) Make it more readable by reducing the nested ifs-checks.
3) Remove the added string in the combobox if the sound scheme buffer mem allocation fails (pt.3 modified).
CORE-11603 #resolve #comment Thanks!

svn path=/trunk/; revision=72000

4 years ago[TOOLS]
Thomas Faber [Mon, 25 Jul 2016 19:28:40 +0000 (19:28 +0000)]
[TOOLS]
- Fix MSVC 2013+ build. Patch by Victor Matovykh.
CORE-11575 #resolve

svn path=/trunk/; revision=71998

4 years ago[SHELL32]
Thomas Faber [Mon, 25 Jul 2016 19:25:46 +0000 (19:25 +0000)]
[SHELL32]
- Add missing dependency

svn path=/trunk/; revision=71997

4 years ago[ADVAPI32] silence debug spam
Christoph von Wittich [Mon, 25 Jul 2016 11:07:44 +0000 (11:07 +0000)]
[ADVAPI32] silence debug spam

svn path=/trunk/; revision=71995

4 years ago[WIN32K:NTUSER]
Thomas Faber [Mon, 25 Jul 2016 10:45:30 +0000 (10:45 +0000)]
[WIN32K:NTUSER]
- Fix UserDrawCaptionBar debug spam

svn path=/trunk/; revision=71994

4 years ago[NTOS:CC]
Thomas Faber [Mon, 25 Jul 2016 08:48:50 +0000 (08:48 +0000)]
[NTOS:CC]
- Unconditionally acquire the VACB lock during map/pin/unpin operations and release it appropriately
CORE-11555 #resolve
CORE-11654 CORE-11504 CORE-11328 #comment This might be fixed with r71993. Could you retry please?

svn path=/trunk/; revision=71993

4 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 18:25:50 +0000 (18:25 +0000)]
[NTVDM]
Implement the VGA AC Color Select register.
Implement INT 0x10, AH = 0x10, subfunction AL = 0x13.

svn path=/trunk/; revision=71992

4 years ago[NTOS:CC]
Thomas Faber [Sun, 24 Jul 2016 17:10:30 +0000 (17:10 +0000)]
[NTOS:CC]
- Centralize VACB locking/unlocking into inline functions for easier instrumentation

svn path=/trunk/; revision=71991

4 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 15:45:50 +0000 (15:45 +0000)]
[NTVDM]
Always reset the AC latch before writing to the AC index register.
CORE-11669 #resolve #comment Should be fixed in revision r71990.

svn path=/trunk/; revision=71990

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 24 Jul 2016 15:24:50 +0000 (15:24 +0000)]
[EVENTVWR]
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637

svn path=/trunk/; revision=71989

4 years ago[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521
Amine Khaldi [Sat, 23 Jul 2016 21:33:40 +0000 (21:33 +0000)]
[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521

svn path=/trunk/; revision=71986

4 years ago[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
Mark Jansen [Sat, 23 Jul 2016 20:35:11 +0000 (20:35 +0000)]
[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
As suggested by Thomas :)

svn path=/trunk/; revision=71985

4 years ago[MPR]
Pierre Schweitzer [Sat, 23 Jul 2016 19:52:23 +0000 (19:52 +0000)]
[MPR]
Provide ReactOS specific implementation for WNetGetConnection(), we cannot use Wine's due to Wine specific MountMgr calls.

svn path=/trunk/; revision=71984

4 years ago[SHELL32] close hKey in error case
Christoph von Wittich [Sat, 23 Jul 2016 19:39:16 +0000 (19:39 +0000)]
[SHELL32] close hKey in error case

svn path=/trunk/; revision=71983

4 years ago[NTOS:IO]
Thomas Faber [Sat, 23 Jul 2016 18:18:11 +0000 (18:18 +0000)]
[NTOS:IO]
- Avoid infinite loop in IopMountVolume. Brought to you by Vadim Galyant.
CORE-11663 #resolve

svn path=/trunk/; revision=71982

4 years ago[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE...
Mark Jansen [Sat, 23 Jul 2016 13:15:19 +0000 (13:15 +0000)]
[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE-10439

svn path=/trunk/; revision=71981

4 years ago[SHELL32] cache entries of "New" menu
Christoph von Wittich [Sat, 23 Jul 2016 12:31:30 +0000 (12:31 +0000)]
[SHELL32] cache entries of "New" menu
CORE-10439

svn path=/trunk/; revision=71980

4 years ago[SHELL32]
Giannis Adamopoulos [Sat, 23 Jul 2016 08:42:38 +0000 (08:42 +0000)]
[SHELL32]
- CDefView: Add the skeleton check that should be used to implement moving items in the CDefView. Nothing more is implemented because GetKeyState is completely unreliable.

svn path=/trunk/; revision=71979

4 years ago[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 14:15:09 +0000 (14:15 +0000)]
[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
CORE-7645

svn path=/trunk/; revision=71978

4 years ago[ADVPACK]: Add file version information resource.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 13:19:25 +0000 (13:19 +0000)]
[ADVPACK]: Add file version information resource.
CORE-7645 #comment Please retest the installation of Visual Basic 6 runtime with revision >= 71977.

svn path=/trunk/; revision=71977

4 years ago[USETUP]
Eric Kohl [Thu, 21 Jul 2016 20:53:43 +0000 (20:53 +0000)]
[USETUP]
Keyboard Modifier LEDs not working in usetup.
Patch by Carlo Bramini.
CORE-3368 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71976

4 years ago[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE...
Mark Jansen [Thu, 21 Jul 2016 17:29:41 +0000 (17:29 +0000)]
[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE-11606 #resolve #comment Thanks!

svn path=/trunk/; revision=71975

4 years ago[SERIAL]
Thomas Faber [Wed, 20 Jul 2016 12:50:58 +0000 (12:50 +0000)]
[SERIAL]
- Properly stub SerialPower
CORE-11648

svn path=/trunk/; revision=71974

4 years ago[PARPORT]
Thomas Faber [Wed, 20 Jul 2016 12:21:11 +0000 (12:21 +0000)]
[PARPORT]
- Properly stub FdoPower and PdoPower
CORE-11648

svn path=/trunk/; revision=71973

4 years ago[PCIIDEX]
Thomas Faber [Wed, 20 Jul 2016 11:49:22 +0000 (11:49 +0000)]
[PCIIDEX]
- Add a stub for PciIdeXPowerDispatch
CORE-11648

svn path=/trunk/; revision=71972

4 years ago[SERVICES]
Eric Kohl [Tue, 19 Jul 2016 21:30:45 +0000 (21:30 +0000)]
[SERVICES]
Service logon page:
- Handle the interactive service type flag.
- Change the service configuration in the apply function.

svn path=/trunk/; revision=71971

4 years ago[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed...
Amine Khaldi [Tue, 19 Jul 2016 18:12:15 +0000 (18:12 +0000)]
[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed CORE-11511.

svn path=/trunk/; revision=71970

4 years ago[NTOS:KE]
Thomas Faber [Tue, 19 Jul 2016 12:51:49 +0000 (12:51 +0000)]
[NTOS:KE]
- Load LDT on context switch if required.
CORE-11511 #resolve

svn path=/trunk/; revision=71967

4 years ago[REGEDIT]
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 22:27:17 +0000 (22:27 +0000)]
[REGEDIT]
- Minor whitespace fixes in main.c
- Use a correct info msgbox title when showing regedit command-line usage. Something to think about: translate the cmdline usage! :)

svn path=/trunk/; revision=71966

4 years ago[SERVMAN]
Eric Kohl [Mon, 18 Jul 2016 21:49:19 +0000 (21:49 +0000)]
[SERVMAN]
Service logon property page:
- Fix initialization and display bugs.
- Start work on the 'Apply' function. It doe not apply changes yet.
- Add password check messages.

svn path=/trunk/; revision=71965

4 years ago[BOOTDATA]: Disable automatic debugger startup on application crash. This allows...
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 19:25:53 +0000 (19:25 +0000)]
[BOOTDATA]: Disable automatic debugger startup on application crash. This allows getting back the error popup as we used to have, and also warn the user there was indeed a problem, instead of silently start the default debugger (that I've set to an unexistant "drwtsn.exe") and fail silently, since that default debugger doesn't exist.
CORE-11508

svn path=/trunk/; revision=71964

4 years ago[USER32_WINETEST] Sync with Wine Staging 1.9.14.
Amine Khaldi [Mon, 18 Jul 2016 15:48:27 +0000 (15:48 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.14.

svn path=/trunk/; revision=71963

4 years ago[USER32] Add missing lprc check in SetRect().
Amine Khaldi [Mon, 18 Jul 2016 15:46:38 +0000 (15:46 +0000)]
[USER32] Add missing lprc check in SetRect().

svn path=/trunk/; revision=71962

4 years ago[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater...
Amine Khaldi [Mon, 18 Jul 2016 10:44:58 +0000 (10:44 +0000)]
[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater's changes. CORE-11368 ROSTESTS-233

svn path=/trunk/; revision=71961

4 years ago[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638
Amine Khaldi [Mon, 18 Jul 2016 10:27:56 +0000 (10:27 +0000)]
[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638

svn path=/trunk/; revision=71960

4 years ago[User32]
James Tabor [Mon, 18 Jul 2016 02:35:46 +0000 (02:35 +0000)]
[User32]
- Fix log out shutdown dialog window input. See CORE-11633 #resolve

svn path=/trunk/; revision=71959

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 17 Jul 2016 23:06:03 +0000 (23:06 +0000)]
[EVENTVWR]
Commit "Part 1" of my Improvements for the Event Log Viewer. See CORE-11637 description for more details (too long to stay there).

svn path=/trunk/; revision=71958

4 years ago[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde...
Mark Jansen [Sat, 16 Jul 2016 17:49:27 +0000 (17:49 +0000)]
[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde. CORE-11146 #resolve #comment Thanks!

svn path=/trunk/; revision=71956

4 years agoOoops! These were not meant to be committed!
Eric Kohl [Sat, 16 Jul 2016 17:41:44 +0000 (17:41 +0000)]
Ooops! These were not meant to be committed!

svn path=/trunk/; revision=71955

4 years ago[SERVICES]
Eric Kohl [Sat, 16 Jul 2016 17:39:37 +0000 (17:39 +0000)]
[SERVICES]
Check for NULL pointers before derreferecing them in ScmIsSameServiceAccount().
Patch by Victor Martinez Calvo.
CORE-11599 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71954

4 years ago[ADVAPI32]
Eric Kohl [Sat, 16 Jul 2016 16:18:17 +0000 (16:18 +0000)]
[ADVAPI32]
Remove unneeded NULL checks at CreateServiceA/W and ChangeServiceConfigW/A().
Patch by Victor Martinez Calvo.
CORE-11610 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71953

4 years ago[LSASRV]
Eric Kohl [Sat, 16 Jul 2016 14:57:33 +0000 (14:57 +0000)]
[LSASRV]
Fix cleanup in LsarRetrievePrivateData().
Modified patch by Victor Martinez Calvo.
CORE-11611 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71952

4 years ago[WS2_32]
Thomas Faber [Sat, 16 Jul 2016 07:49:30 +0000 (07:49 +0000)]
[WS2_32]
- Fix a few ws2_32:getaddrinfo test failures. Based on a patch by Peter Hater.
CORE-11368

svn path=/trunk/; revision=71951

4 years ago[KERNEL32]
Thomas Faber [Sat, 16 Jul 2016 07:08:21 +0000 (07:08 +0000)]
[KERNEL32]
- Fix GetComputerNameEx behavior with regard to NULL/non-NULL buffers and size calculation
CORE-11368

svn path=/trunk/; revision=71950

4 years ago[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE...
Mark Jansen [Fri, 15 Jul 2016 23:33:53 +0000 (23:33 +0000)]
[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE-9809 #resolve #comment Thanks!

svn path=/trunk/; revision=71949

4 years ago[PSDK]: Add two missing flags concerning custom-drawn controls.
Hermès Bélusca-Maïto [Fri, 15 Jul 2016 21:12:52 +0000 (21:12 +0000)]
[PSDK]: Add two missing flags concerning custom-drawn controls.

svn path=/trunk/; revision=71948

4 years ago[KERNEL32] Check the return buffer for NULL before initializing the unicode string...
Amine Khaldi [Fri, 15 Jul 2016 20:18:20 +0000 (20:18 +0000)]
[KERNEL32] Check the return buffer for NULL before initializing the unicode string buffer with it. By Peter Hater. CORE-11368

svn path=/trunk/; revision=71947

4 years ago[NtGdi]
James Tabor [Fri, 15 Jul 2016 20:13:33 +0000 (20:13 +0000)]
[NtGdi]
- Make SetBkColor work the same as client side.

svn path=/trunk/; revision=71946

4 years ago[EVENTVWR]: Fix transparency problems for some icons.
Hermès Bélusca-Maïto [Thu, 14 Jul 2016 18:58:05 +0000 (18:58 +0000)]
[EVENTVWR]: Fix transparency problems for some icons.

svn path=/trunk/; revision=71944

4 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 13:04:08 +0000 (13:04 +0000)]
[BOOTLIB]
Fix checksum computation

CID #1363451

svn path=/trunk/; revision=71941

4 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 12:58:29 +0000 (12:58 +0000)]
[BOOTLIB]
Fix out of bounds read.

CID #1363549

svn path=/trunk/; revision=71940

4 years ago[BOOTMGR]
Pierre Schweitzer [Thu, 14 Jul 2016 12:46:31 +0000 (12:46 +0000)]
[BOOTMGR]
Don't use uninit var.

CID #1363650

svn path=/trunk/; revision=71939

4 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 12:40:17 +0000 (12:40 +0000)]
[BOOTLIB]
Don't deal with uninit ptr.

CID #1363698

svn path=/trunk/; revision=71938

4 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 14 Jul 2016 12:21:57 +0000 (12:21 +0000)]
[NTOSKRNL]
Assert that the allocated buffers are not leaked.

CID #1248416

svn path=/trunk/; revision=71937

4 years ago[MUP]
Pierre Schweitzer [Thu, 14 Jul 2016 12:07:05 +0000 (12:07 +0000)]
[MUP]
Don't deal with uninit ptr.

CID #1322222

svn path=/trunk/; revision=71936

4 years ago[ACPPAGE] Remove unused var. CID 1363705
Mark Jansen [Wed, 13 Jul 2016 18:44:51 +0000 (18:44 +0000)]
[ACPPAGE] Remove unused var. CID 1363705

svn path=/trunk/; revision=71934

4 years ago[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID...
Mark Jansen [Wed, 13 Jul 2016 18:33:42 +0000 (18:33 +0000)]
[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID 1363551

svn path=/trunk/; revision=71933

4 years ago[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63...
Mark Jansen [Wed, 13 Jul 2016 18:10:37 +0000 (18:10 +0000)]
[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63, 65-70, 76, 78, 85, 88, 90

svn path=/trunk/; revision=71932

4 years ago[APPHELP] Dereference after null check (default_dir). CID 1363509
Mark Jansen [Wed, 13 Jul 2016 18:02:16 +0000 (18:02 +0000)]
[APPHELP] Dereference after null check (default_dir). CID 1363509

svn path=/trunk/; revision=71931

4 years ago[NTOSKRNL_VISTA]
Thomas Faber [Wed, 13 Jul 2016 17:48:21 +0000 (17:48 +0000)]
[NTOSKRNL_VISTA]
- Avoid ugly hacks
CORE-11596 #resolve

svn path=/trunk/; revision=71930

4 years ago[NET]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 17:35:16 +0000 (17:35 +0000)]
[NET]
No need to check for whether 'pBuffer' is NULL to call NetApiBufferFree, because:
- 'pBuffer' was used above this call without any particular checks;
- 'pBuffer' can be only null when NetUserEnum fails with an error different from NERR_Success or ERROR_MORE_DATA. But this case was actually checked for before using 'pBuffer'.
By Victor Martinez aka. Mr.Coverity ^^ :)
CID 1363629
CORE-11598 #resolve

svn path=/trunk/; revision=71929

4 years ago[NTOSKRNL_VISTA lib]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 16:43:16 +0000 (16:43 +0000)]
[NTOSKRNL_VISTA lib]
Initialize utf8_ch_len to zero before using it (at each turn of the for-loop). As I couldn't find this code in Wine, I couldn't see whether they already fixed it or not. Caught by Victor.
CORE-11596

svn path=/trunk/; revision=71928

4 years ago[SETUP]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 16:33:37 +0000 (16:33 +0000)]
[SETUP]
- Fix leaking 'pSetupData' in case of failure. CID 1363604
- Since we know that in the remaining of the code, 'pSetupData' is a valid pointer, we can free it at the very end without rechecking whether it was NULL or not.
CORE-11591 #resolve

svn path=/trunk/; revision=71927

4 years ago[MAGNIFY]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 16:27:39 +0000 (16:27 +0000)]
[MAGNIFY]
Missing break. CID 1363532
CORE-11593 #resolve

svn path=/trunk/; revision=71926

4 years ago[MKHIVE]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 16:23:12 +0000 (16:23 +0000)]
[MKHIVE]
- Fix usage of the 'Status' variable. CID 1363689
- Fix some DPRINTs.
CORE-11595 #resolve

svn path=/trunk/; revision=71925

4 years ago[CHARMAP]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 15:50:44 +0000 (15:50 +0000)]
[CHARMAP]
Don't overrun FillGrid() when accessing the last elements. Rewrite the code using 'for' loops, in the same style as what is done elsewhere in the code. CID 1363552
CORE-11597 #resolve

svn path=/trunk/; revision=71924

4 years ago[BOOTLIB]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 15:43:08 +0000 (15:43 +0000)]
[BOOTLIB]
- BiOpenKey is being feed with the wrong ElementHandle, it should be feed with ElementsHandle one. CID 1363670 . By Victor Martinez Calvo. CORE-11600 #resolve
[BOOTMGR]
- Fix an Assign vs Compare issue. CID 1363558 .  By Victor Martinez Calvo. CORE-11592 #resolve

svn path=/trunk/; revision=71923

4 years ago[BOOTLIB] Remove stray semicolon from a condition in ConsoleCreateLocalInputConsole...
Amine Khaldi [Wed, 13 Jul 2016 09:08:34 +0000 (09:08 +0000)]
[BOOTLIB] Remove stray semicolon from a condition in ConsoleCreateLocalInputConsole(). Patch by Victor for CID 1363701. CORE-11588

svn path=/trunk/; revision=71919

4 years ago[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 4. CORE-11368
James Tabor [Wed, 13 Jul 2016 03:16:00 +0000 (03:16 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 4. CORE-11368

svn path=/trunk/; revision=71918

4 years ago[User32]
James Tabor [Wed, 13 Jul 2016 03:09:01 +0000 (03:09 +0000)]
[User32]
- Sync/port up to Wine Staging 1.9.11 or current. See CORE-11368.

svn path=/trunk/; revision=71917

4 years ago[NtUser]
James Tabor [Wed, 13 Jul 2016 03:04:20 +0000 (03:04 +0000)]
[NtUser]
- Fix crash in User32:win:test_winproc_handles. See CORE-11368.

svn path=/trunk/; revision=71916

4 years ago[User32]
James Tabor [Wed, 13 Jul 2016 00:40:07 +0000 (00:40 +0000)]
[User32]
- Fix regression in API:RealGetWindowClass test due to wine sync/port.
- ReactOS use of DIALOG_get_info is an enhanced fork of the same wine function.

svn path=/trunk/; revision=71915

4 years ago[CONCFG]: Add needed inclusion for StrSafe functions.
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 00:09:36 +0000 (00:09 +0000)]
[CONCFG]: Add needed inclusion for StrSafe functions.

svn path=/trunk/; revision=71914

4 years ago[CONSRV]
Hermès Bélusca-Maïto [Wed, 13 Jul 2016 00:06:09 +0000 (00:06 +0000)]
[CONSRV]
- Fix potential Out-of-bounds access during string copy/concatenation. CID 1322098.
- Fix check for NULL after potential dereference. CID 1322175.

svn path=/trunk/; revision=71913

4 years ago[SHELL32]
Hermès Bélusca-Maïto [Tue, 12 Jul 2016 23:00:50 +0000 (23:00 +0000)]
[SHELL32]
- Use StringCbCopyW

[PROGMAN]
- Use StringCbCopyW: CID #1363712.
- Don't read registry values in a registry key if we failed to open it. CID #514350.

svn path=/trunk/; revision=71912

4 years ago[USETUP]
Hermès Bélusca-Maïto [Tue, 12 Jul 2016 22:30:55 +0000 (22:30 +0000)]
[USETUP]
- Don't hardcode buffer string size in GetPartTypeStringFromPartitionType calls.
- Possibly check whether the first character of the PartTypeString string is NULL before printing a generic partition information in case the partition type is unknown. We might check instead for the STRING_FORMATUNKNOWN string...
- Don't check for PartTypeString being NULL since it's not a pointer. CID #1363481 and CID #1363494.

svn path=/trunk/; revision=71911

4 years ago[KERNEL32_WINETEST] Sync with Wine Staging 1.9.14 except thread tests. CORE-11511
Amine Khaldi [Tue, 12 Jul 2016 21:10:24 +0000 (21:10 +0000)]
[KERNEL32_WINETEST] Sync with Wine Staging 1.9.14 except thread tests. CORE-11511

svn path=/trunk/; revision=71910

4 years ago[NTDLL_WINETEST] Partial sync with Wine Staging 1.9.14. CORE-11368 holds some remaini...
Amine Khaldi [Tue, 12 Jul 2016 20:40:20 +0000 (20:40 +0000)]
[NTDLL_WINETEST] Partial sync with Wine Staging 1.9.14. CORE-11368 holds some remaining tests.

svn path=/trunk/; revision=71909

4 years ago[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 3. CORE-11368
James Tabor [Tue, 12 Jul 2016 20:08:44 +0000 (20:08 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 3. CORE-11368

svn path=/trunk/; revision=71907

4 years ago[Win32SS]
James Tabor [Tue, 12 Jul 2016 20:06:30 +0000 (20:06 +0000)]
[Win32SS]
- Update (Sync/Port) User32:Text to Wine Staging 1.9.11, see CORE-11368.

svn path=/trunk/; revision=71906

4 years ago[Win32SS]
James Tabor [Tue, 12 Jul 2016 18:23:04 +0000 (18:23 +0000)]
[Win32SS]
- Cleanup error codes for Classes and Menus.
- Update (Sync/Port) User32:Dialog to Wine Staging 1.9.11, see CORE-11368.
- Now pass exactly the same tests as windows, except for the two ToDos lines 1596 & 1617. The other test failures are on wine for not being compatible!

svn path=/trunk/; revision=71904