Timo Kreuzer [Sat, 2 Jan 2010 19:41:03 +0000 (19:41 +0000)]
[NTOS]
Move spinlock inline functions into their own header, so they can be shared with hal.
svn path=/branches/ros-amd64-bringup/; revision=44893
Timo Kreuzer [Sat, 2 Jan 2010 16:32:20 +0000 (16:32 +0000)]
[KD64]
- Remove unused variable
svn path=/branches/ros-amd64-bringup/; revision=44888
Timo Kreuzer [Sat, 2 Jan 2010 16:31:41 +0000 (16:31 +0000)]
[KE]
Move the .text and .code64 tag before all functions in trap.S
svn path=/branches/ros-amd64-bringup/; revision=44887
Timo Kreuzer [Sat, 2 Jan 2010 16:22:43 +0000 (16:22 +0000)]
[KE]
- KxAcquireSpinLock: check for already owned lock only on debug builds, fix check in inner loop, don't call Kii386SpinOnSpinLock inside the inner loop, but instead of it, simplify the code
- stubplement Kii386SpinOnSpinLock in C
svn path=/branches/ros-amd64-bringup/; revision=44886
Timo Kreuzer [Fri, 1 Jan 2010 12:17:24 +0000 (12:17 +0000)]
[HAL]
Don't spin with an interlocked operation.
svn path=/branches/ros-amd64-bringup/; revision=44849
Timo Kreuzer [Thu, 31 Dec 2009 23:45:36 +0000 (23:45 +0000)]
[HAL]
Replace the asm implementations of HalpAcquireSystemHardwareSpinLock and HalpReleaseCmosSpinLock with C implementations. The old ones didn't work on SMP, as they were only compiled once as UP.
svn path=/branches/ros-amd64-bringup/; revision=44840
Timo Kreuzer [Thu, 31 Dec 2009 21:43:20 +0000 (21:43 +0000)]
fix build of halxbox
svn path=/branches/ros-amd64-bringup/; revision=44837
Timo Kreuzer [Thu, 31 Dec 2009 21:31:14 +0000 (21:31 +0000)]
fix spec file for x86
svn path=/branches/ros-amd64-bringup/; revision=44836
Timo Kreuzer [Thu, 31 Dec 2009 21:23:01 +0000 (21:23 +0000)]
[HAL]
- Move the rest from halamd64 to halx86
svn path=/branches/ros-amd64-bringup/; revision=44835
Timo Kreuzer [Thu, 31 Dec 2009 20:46:45 +0000 (20:46 +0000)]
[HAL]
- rename halmp to halmps
- remove hal_generic_pc
- remove some stuff from halamd64
svn path=/branches/ros-amd64-bringup/; revision=44834
Timo Kreuzer [Thu, 31 Dec 2009 19:46:47 +0000 (19:46 +0000)]
use a directory.rbuild for halx86
svn path=/branches/ros-amd64-bringup/; revision=44833
Timo Kreuzer [Thu, 31 Dec 2009 19:26:37 +0000 (19:26 +0000)]
[HAL]
some improvements
svn path=/branches/ros-amd64-bringup/; revision=44832
Timo Kreuzer [Thu, 31 Dec 2009 16:51:05 +0000 (16:51 +0000)]
[HAL]
- begin integrating halamd64 into halx86
- Move some amd64 specific stuff into halx86
- use hal_generic for amd64, too
svn path=/branches/ros-amd64-bringup/; revision=44831
Timo Kreuzer [Thu, 31 Dec 2009 16:47:09 +0000 (16:47 +0000)]
[HAL]
- fix indentation
- add HalDisableSystemInterrupt and HalEnableSystemInterrupt stubs
svn path=/branches/ros-amd64-bringup/; revision=44830
Timo Kreuzer [Thu, 31 Dec 2009 15:38:34 +0000 (15:38 +0000)]
[HAL]
- fix pspec
- entrypoint should be HalInitSystem
svn path=/branches/ros-amd64-bringup/; revision=44829
Timo Kreuzer [Thu, 31 Dec 2009 15:31:20 +0000 (15:31 +0000)]
[HAL]
use the pspec for amd64, too
svn path=/branches/ros-amd64-bringup/; revision=44828
Timo Kreuzer [Thu, 31 Dec 2009 15:19:17 +0000 (15:19 +0000)]
[HAL]
- Raname each architecture's default hal (halup) to "hal" (Windows does that, too) and get rid of the duplicated stub hal.
svn path=/branches/ros-amd64-bringup/; revision=44827
Timo Kreuzer [Thu, 31 Dec 2009 15:12:16 +0000 (15:12 +0000)]
fix a typo
svn path=/branches/ros-amd64-bringup/; revision=44826
Timo Kreuzer [Thu, 31 Dec 2009 14:57:24 +0000 (14:57 +0000)]
[HAL]
- Move i386 specific code into i386 folder
- Move up specific code into up folder
svn path=/branches/ros-amd64-bringup/; revision=44825
Timo Kreuzer [Thu, 31 Dec 2009 14:29:50 +0000 (14:29 +0000)]
[HAL]
- Implement architecture specific HalpSetInterruptGate, replacing SetInterruptGate
svn path=/branches/ros-amd64-bringup/; revision=44823
Samuel Serapion [Thu, 31 Dec 2009 07:42:39 +0000 (07:42 +0000)]
Fix Property USERMODE on x86
svn path=/branches/ros-amd64-bringup/; revision=44821
Samuel Serapion [Thu, 31 Dec 2009 07:26:46 +0000 (07:26 +0000)]
Fix build after r44818
svn path=/branches/ros-amd64-bringup/; revision=44820
Timo Kreuzer [Thu, 31 Dec 2009 01:56:39 +0000 (01:56 +0000)]
- mciGetCreatorTask returns HTASK not HANDLE
- remove broken LargeInteger functions from wintrnl.h
svn path=/branches/ros-amd64-bringup/; revision=44818
Samuel Serapion [Wed, 30 Dec 2009 07:53:02 +0000 (07:53 +0000)]
Add definitions for the x86bios emulator.
http://www.geoffchappell.com/viewer.htm?doc=studies/windows/km/hal/api/x86bios/index.htm
svn path=/branches/ros-amd64-bringup/; revision=44807
Timo Kreuzer [Mon, 28 Dec 2009 20:03:17 +0000 (20:03 +0000)]
Add ksamd64.h. This is a temporary solution until it's autogenerated. Note to self: veryfy offsets before using them!
svn path=/branches/ros-amd64-bringup/; revision=44798
Timo Kreuzer [Mon, 28 Dec 2009 17:53:26 +0000 (17:53 +0000)]
Remove the totally broken asm implementation of KeQueryPerformanceCounter and replace it with a much simpler C version using __rdtsc().
svn path=/branches/ros-amd64-bringup/; revision=44795
Samuel Serapion [Mon, 28 Dec 2009 06:38:19 +0000 (06:38 +0000)]
Implement HalpInitPICs
svn path=/branches/ros-amd64-bringup/; revision=44791
Samuel Serapion [Mon, 28 Dec 2009 04:55:58 +0000 (04:55 +0000)]
Sync to trunk (r44789)
svn path=/branches/ros-amd64-bringup/; revision=44790
Samuel Serapion [Mon, 28 Dec 2009 04:46:04 +0000 (04:46 +0000)]
ignore some warnings by gcc 4.4.2
svn path=/branches/ros-amd64-bringup/; revision=44789
Timo Kreuzer [Mon, 28 Dec 2009 04:39:02 +0000 (04:39 +0000)]
Implement KiGeneralProtectionFault a bit
svn path=/branches/ros-amd64-bringup/; revision=44788
Samuel Serapion [Mon, 28 Dec 2009 03:09:37 +0000 (03:09 +0000)]
Fix Build.
svn path=/branches/ros-amd64-bringup/; revision=44787
Samuel Serapion [Mon, 28 Dec 2009 03:02:12 +0000 (03:02 +0000)]
Fix broken merge
svn path=/branches/ros-amd64-bringup/; revision=44786
Samuel Serapion [Mon, 28 Dec 2009 01:37:31 +0000 (01:37 +0000)]
Unhack ntoskrnl, fixes many x86 regressions.
svn path=/branches/ros-amd64-bringup/; revision=44785
Timo Kreuzer [Mon, 28 Dec 2009 01:28:29 +0000 (01:28 +0000)]
remove unneded parameter
svn path=/branches/ros-amd64-bringup/; revision=44784
Samuel Serapion [Mon, 28 Dec 2009 01:07:10 +0000 (01:07 +0000)]
- Fix LPBLOCKINGCALLBACK
- Don't use size_t for string sizes.
- Fixes warnings.
svn path=/branches/ros-amd64-bringup/; revision=44783
Timo Kreuzer [Mon, 28 Dec 2009 00:51:53 +0000 (00:51 +0000)]
reduce diff to trunk
svn path=/branches/ros-amd64-bringup/; revision=44782
Timo Kreuzer [Mon, 28 Dec 2009 00:37:29 +0000 (00:37 +0000)]
[KE]
Make trap handling cleaner / simplify stack layout by using the P1Home ... P5 members of KTRAP_FRAME and KEXCEPTION_FRAME as save area for function parameters.
svn path=/branches/ros-amd64-bringup/; revision=44781
Timo Kreuzer [Sun, 27 Dec 2009 23:54:01 +0000 (23:54 +0000)]
spaces -> tabs in rbuild file
svn path=/trunk/; revision=44780
Timo Kreuzer [Sun, 27 Dec 2009 22:06:48 +0000 (22:06 +0000)]
reduce differences to trunk
svn path=/branches/ros-amd64-bringup/; revision=44779
Timo Kreuzer [Sun, 27 Dec 2009 21:30:36 +0000 (21:30 +0000)]
fix USERMODE=0 compilation
svn path=/branches/ros-amd64-bringup/; revision=44778
Benedikt Freisen [Sun, 27 Dec 2009 21:15:08 +0000 (21:15 +0000)]
Tool box, color palette and status bar can be hidden and shown using menu entry and/or shortcut.
svn path=/trunk/; revision=44777
Eric Kohl [Sun, 27 Dec 2009 19:46:13 +0000 (19:46 +0000)]
[lsalib]
Fix indentation. No code changes.
svn path=/trunk/; revision=44776
James Tabor [Sun, 27 Dec 2009 19:43:46 +0000 (19:43 +0000)]
[gdi32]
- Add notes, fix CombineRgn and cleanup.
svn path=/trunk/; revision=44775
Eric Kohl [Sun, 27 Dec 2009 19:10:30 +0000 (19:10 +0000)]
Move the client-side LSA functions from secur32.dll to the new static library lsalib because these functions will be shared between ntoskrnl.exe, advapi32.dll and secur32.dll.
svn path=/trunk/; revision=44774
Samuel Serapion [Sun, 27 Dec 2009 18:19:20 +0000 (18:19 +0000)]
Implement KeGetTrapFrame and KeGetExceptionFrame macros.
svn path=/branches/ros-amd64-bringup/; revision=44773
Samuel Serapion [Sun, 27 Dec 2009 18:03:16 +0000 (18:03 +0000)]
Fix warning cast to 'unsigned int' loses precision.
svn path=/branches/ros-amd64-bringup/; revision=44772
Samuel Serapion [Sun, 27 Dec 2009 17:55:04 +0000 (17:55 +0000)]
sync to trunk (44770)
svn path=/branches/ros-amd64-bringup/; revision=44771
Gregor Schneider [Sun, 27 Dec 2009 15:43:48 +0000 (15:43 +0000)]
[win32k] Handle invalid palette index by using the first palette entry
svn path=/trunk/; revision=44770
Gregor Schneider [Sun, 27 Dec 2009 15:08:41 +0000 (15:08 +0000)]
[win32k]
- Set the number of mapped colors depending on the usage parameter
- Use pure PALETTERGB color values when no palette is selected
- Fixes true color issue mentioned in r44712
svn path=/trunk/; revision=44769
Gregor Schneider [Sun, 27 Dec 2009 13:02:19 +0000 (13:02 +0000)]
[win32k]
- Create DIB section palettes with the number of colors mapped from the logical palette
- Validate logical palette access, set to black for invalid indices
- gdi32:palette test now succeeds
svn path=/trunk/; revision=44768
Timo Kreuzer [Sat, 26 Dec 2009 22:55:53 +0000 (22:55 +0000)]
[GENINC]
Lots of fixes and updates.
svn path=/trunk/; revision=44767
Timo Kreuzer [Sat, 26 Dec 2009 19:36:24 +0000 (19:36 +0000)]
[KDBG]
Hackfix the problem with attaching to processes introduced in r44743, by lowering IRQL to passive level, although interrupts are off. Needed because KDBG calls pageable code.
svn path=/trunk/; revision=44766
James Tabor [Sat, 26 Dec 2009 19:19:33 +0000 (19:19 +0000)]
[Win32k]
- Rewritten NtGdiCombineRgn.
- Add two function's to support locking and Rgn attributes. These function's will replace all the normal Rgn locking ones.
svn path=/trunk/; revision=44765
Samuel Serapion [Sat, 26 Dec 2009 06:40:23 +0000 (06:40 +0000)]
[rbuild]
- fix mkhive command try 2.
- 100% tested
svn path=/branches/ros-amd64-bringup/; revision=44764
Samuel Serapion [Sat, 26 Dec 2009 06:23:47 +0000 (06:23 +0000)]
[rbuild]
Really fix mkhive command.
svn path=/branches/ros-amd64-bringup/; revision=44763
Samuel Serapion [Sat, 26 Dec 2009 06:07:38 +0000 (06:07 +0000)]
[rbuild]
- Fix make install.
- Fix mkhive command.
- Automatically generate reactos.dff using the installfile and installbase attributes found in rbuild files.
-- Fixes race to grab reactos.dff on concurrent builds in the same tree.
-- Makes the result of make install, make livecd and make bootcd the same(some modules arent in reactos.dff but have installfile/base attributes, which means they got intto livecd/install but not bootcd!)
-- Works really great with rosapps/rostests.
-- Downside is some files now exist inside and outside the generated cab file, maybe this could be useful if we wanted to have a package that contained reactos and an app that installed it from livecd... just thinking out loud...
svn path=/branches/ros-amd64-bringup/; revision=44762
Gregor Schneider [Fri, 25 Dec 2009 17:54:41 +0000 (17:54 +0000)]
[win32k]
- IntGetDIBColorTable: return the number of actually copied color table entries
- DIB_CreateDIBSection: simplify calculation of palette entry count
- IntHandleSpecialColorType: remove leftover debug print
svn path=/trunk/; revision=44761
Eric Kohl [Fri, 25 Dec 2009 16:41:06 +0000 (16:41 +0000)]
The service thread must receive all commands.
svn path=/trunk/; revision=44760
Eric Kohl [Fri, 25 Dec 2009 15:08:03 +0000 (15:08 +0000)]
RQueryServiceConfigA/W: Add missing dependency information.
svn path=/trunk/; revision=44759
Johannes Anderwald [Fri, 25 Dec 2009 12:24:42 +0000 (12:24 +0000)]
[PORTCLS]
- Return status code of operation
- Cancel all irps when pin state is set to stop. Fixes ReactOS portcls regression under WindowsXP
- Handle IRP_MN_READ_CONFIG
svn path=/trunk/; revision=44758
Johannes Anderwald [Fri, 25 Dec 2009 02:54:24 +0000 (02:54 +0000)]
[PSDK]
- Fix KSEVENTSETID_AudioControlChange definition
svn path=/trunk/; revision=44757
Johannes Anderwald [Fri, 25 Dec 2009 01:21:29 +0000 (01:21 +0000)]
[MMIXER]
- Store correct mixer handle in the mixer info
- mmixer can now handle set / get volume and on-off (mute) requests
svn path=/trunk/; revision=44756
Johannes Anderwald [Fri, 25 Dec 2009 01:17:39 +0000 (01:17 +0000)]
[KS]
- Store missing result of operation
- Fixes a regression of KsStudio
svn path=/trunk/; revision=44755
Timo Kreuzer [Thu, 24 Dec 2009 23:17:18 +0000 (23:17 +0000)]
[freeldr]
Fix apic base
svn path=/branches/ros-amd64-bringup/; revision=44754
Christoph von Wittich [Thu, 24 Dec 2009 09:01:43 +0000 (09:01 +0000)]
[gdi32]
fix typo in comment
svn path=/trunk/; revision=44753
James Tabor [Thu, 24 Dec 2009 07:42:38 +0000 (07:42 +0000)]
[gdi32]
- Enable and fix more region user code.
svn path=/trunk/; revision=44752
James Tabor [Thu, 24 Dec 2009 07:03:46 +0000 (07:03 +0000)]
[gdi32]
- Set the last arg to 1 for GetTextExtentPoint support mode.
svn path=/trunk/; revision=44751
James Tabor [Thu, 24 Dec 2009 06:57:48 +0000 (06:57 +0000)]
[gdi32] - Move OpenPrinterW out from static.
svn path=/trunk/; revision=44750
Samuel Serapion [Thu, 24 Dec 2009 04:12:02 +0000 (04:12 +0000)]
[ntoskrnl]
- enable KdpEnableSafeMem for amd64
- unhack ExInitPoolLookasidePointers
- hackplement KiInitializeContextThread
- Remove extended eflag code from kdb, its useless.
- Rewrite KdbpCmdGdtLdtIdt
- Enable KdbpCmdTss
- misc kdb fixes.
svn path=/branches/ros-amd64-bringup/; revision=44749
Timo Kreuzer [Thu, 24 Dec 2009 03:45:21 +0000 (03:45 +0000)]
[GENINC]
This is going to be a host tool that autogenerates assembly definitions from the target headers. This is done in two steps: 1) a raw data file is compiled with the target compiler using the target headers 2) The host tool parses this data file and creates an appropriate .h or .inc file.
So far there's only the source for the data file, which is halfway complete and currently compiled as bootloader type, as we don't seem to have raw binary target.
WIP
svn path=/trunk/; revision=44748
James Tabor [Wed, 23 Dec 2009 23:30:26 +0000 (23:30 +0000)]
[gdi32]
- Move more region code from stubs into the appropriate file.
- Enable and fix more user code.
svn path=/trunk/; revision=44747
James Tabor [Wed, 23 Dec 2009 23:10:32 +0000 (23:10 +0000)]
[gdi32]
- Move region code from stubs into the appropriate file.
- Enable and fix SetRectRgn user code.
svn path=/trunk/; revision=44746
James Tabor [Wed, 23 Dec 2009 20:12:28 +0000 (20:12 +0000)]
[Win32k]
- Set error if no handle is provided.
svn path=/trunk/; revision=44745
Timo Kreuzer [Wed, 23 Dec 2009 18:43:27 +0000 (18:43 +0000)]
[i8042prt]
- Fix Ctrl-Scroll key combination, by ignoring ACK codes and not relying on a 0xe0 sequence code, which is not being sent at least on VBox.
- Fix Tab-K handling at high irql, by moving it out of the DPC routine into the ISR.
svn path=/trunk/; revision=44743
Gregor Schneider [Wed, 23 Dec 2009 17:48:27 +0000 (17:48 +0000)]
[msvcrt] Update c++ symbol demangling to Wine 1.1.35 (msvcrt:cpp test buffer overrun)
svn path=/trunk/; revision=44742
Gregor Schneider [Wed, 23 Dec 2009 17:41:20 +0000 (17:41 +0000)]
[win32k] NtGdiSetDIBitsToDeviceInternal:
- Choose the number of scan lines from the parameter and the bitmap size
- Add scan line offset to the destination rectangle top left corner (fixes drawing images line by line)
- Add debug print for further problem solving (deactivated)
svn path=/trunk/; revision=44741
Christoph von Wittich [Wed, 23 Dec 2009 16:02:37 +0000 (16:02 +0000)]
[winmm_winetest]
sync winmm_winetest to wine 1.1.35
svn path=/trunk/; revision=44740
Christoph von Wittich [Wed, 23 Dec 2009 15:58:59 +0000 (15:58 +0000)]
[wldap32_winetest]
sync wldap32_winetest to wine 1.1.35
svn path=/trunk/; revision=44739
Christoph von Wittich [Wed, 23 Dec 2009 15:57:45 +0000 (15:57 +0000)]
[advapi32_winetest]
add eventlog tests to build
svn path=/trunk/; revision=44738
Timo Kreuzer [Wed, 23 Dec 2009 15:32:54 +0000 (15:32 +0000)]
Fix release builds
svn path=/trunk/; revision=44737
Christoph von Wittich [Wed, 23 Dec 2009 15:15:54 +0000 (15:15 +0000)]
[advapi32_winetest]
sync advapi32_winetest with wine 1.1.35
svn path=/trunk/; revision=44736
Christoph von Wittich [Wed, 23 Dec 2009 15:15:21 +0000 (15:15 +0000)]
[psdk]
add EVENTLOG_FULL_INFORMATION structure (from wine)
svn path=/trunk/; revision=44735
Eric Kohl [Wed, 23 Dec 2009 14:59:47 +0000 (14:59 +0000)]
Assign the services Dhcp, EventLog, PlugPlay and RpcSs to the LocalSystem account.
svn path=/trunk/; revision=44734
Eric Kohl [Wed, 23 Dec 2009 14:32:15 +0000 (14:32 +0000)]
- RChangeServiceConfigA/W: Update the service group properly and fix the ANSI to Unicode string conversion.
This fixes one winetest.
svn path=/trunk/; revision=44733
Christoph von Wittich [Wed, 23 Dec 2009 12:10:58 +0000 (12:10 +0000)]
[kernel32]
fix typos in comments (as in wine 1.1.35)
svn path=/trunk/; revision=44732
Christoph von Wittich [Wed, 23 Dec 2009 11:36:17 +0000 (11:36 +0000)]
[netapi32]
sync netapi32 with wine 1.1.35
svn path=/trunk/; revision=44731
Christoph von Wittich [Wed, 23 Dec 2009 11:32:32 +0000 (11:32 +0000)]
[inetcomm]
sync inetcomm with wine 1.1.35
svn path=/trunk/; revision=44730
Christoph von Wittich [Wed, 23 Dec 2009 11:28:12 +0000 (11:28 +0000)]
[shell32]
partial shlview winesync to wine 1.1.35
svn path=/trunk/; revision=44729
Christoph von Wittich [Wed, 23 Dec 2009 11:21:41 +0000 (11:21 +0000)]
[shell32]
partial SHGetFileInfoW winesync to wine 1.1.35 (fixes uninitialized memory access)
svn path=/trunk/; revision=44728
Christoph von Wittich [Wed, 23 Dec 2009 11:17:00 +0000 (11:17 +0000)]
[shell32]
partial shelllink winesync to wine 1.1.35 (fixes a memory leak)
svn path=/trunk/; revision=44727
Christoph von Wittich [Wed, 23 Dec 2009 11:13:35 +0000 (11:13 +0000)]
[kernel32]
sync enumerate_mapped_resources and update_add_resource to wine 1.1.35
svn path=/trunk/; revision=44726
Christoph von Wittich [Wed, 23 Dec 2009 10:56:54 +0000 (10:56 +0000)]
[crt]
import _wcsupr_s from wine 1.1.35
svn path=/trunk/; revision=44725
Christoph von Wittich [Wed, 23 Dec 2009 10:44:24 +0000 (10:44 +0000)]
[crt]
sync wcscpy_s with wine 1.1.35
svn path=/trunk/; revision=44724
Johannes Anderwald [Wed, 23 Dec 2009 10:43:17 +0000 (10:43 +0000)]
[WDMAUD.DRV]
- Fix build
svn path=/trunk/; revision=44723
Samuel Serapion [Wed, 23 Dec 2009 03:36:40 +0000 (03:36 +0000)]
Lazy port of kdbg to AMD64. Kdbg is very x86 specific but thankfully amd64 isn't that diferent. It can query register values, list modules, and dump PCR. Other stuff is broken and needs further debugging such as KdpSafe API, IDT, GDT, LDT offsets and disasm code. Backtraces not available because of missing unwind data. Special thanks to Physicus for making this commit possible.
svn path=/branches/ros-amd64-bringup/; revision=44722
Johannes Anderwald [Wed, 23 Dec 2009 03:05:11 +0000 (03:05 +0000)]
[WDMAUD.DRV]
- Move the routines which interact wdmaud.sys to legacy.c
- Implement opening / closing of audio pins as well as writing / reading audio bytes from / to it
- By defining USE_MMIXER_LIB, wdmaud.drv bypasses wdmaud+sysaudio and directly writes/reads the audio bytes to portcls.
svn path=/trunk/; revision=44721
Johannes Anderwald [Wed, 23 Dec 2009 02:49:18 +0000 (02:49 +0000)]
[MMIXER]
- Implement a function for controlling the wave pin state
svn path=/trunk/; revision=44720
Johannes Anderwald [Tue, 22 Dec 2009 18:08:51 +0000 (18:08 +0000)]
[MMIXER]
- Fix a bug in the file header
svn path=/trunk/; revision=44717
Eric Kohl [Tue, 22 Dec 2009 17:00:45 +0000 (17:00 +0000)]
If the user doubleclicked a treeview item, make sure the doubleclicked item has already been selected. Otherwise the user can expand or collapse a treeview iten and a previously selected item get opened. That's not what we want.
svn path=/trunk/; revision=44716
Eric Kohl [Tue, 22 Dec 2009 16:57:27 +0000 (16:57 +0000)]
Fix a typo. Use lpStartServiceName instead of lpServiceName.
This fixes two winetests.
svn path=/trunk/; revision=44714