reactos.git
3 years ago[FASTFAT]
Pierre Schweitzer [Sun, 19 Feb 2017 11:22:21 +0000 (11:22 +0000)]
[FASTFAT]
Avoid uninit variable usage.

CID 14012571401259

svn path=/trunk/; revision=73836

3 years ago[LOCALMON]
Thomas Faber [Sun, 19 Feb 2017 10:31:37 +0000 (10:31 +0000)]
[LOCALMON]
- Avoid a potential double free in InitializePrintMonitor2. CID 1401299
- Avoid a use after free in LocalmonClosePort. CID 1401298

svn path=/trunk/; revision=73835

3 years ago[UXTHEME] -The code to draw the classic style borders was copied from win32k, so...
Giannis Adamopoulos [Sun, 19 Feb 2017 10:23:26 +0000 (10:23 +0000)]
[UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667

svn path=/trunk/; revision=73834

3 years ago[SHELL32] -Try to fix themes when opening the control panel applet from the control...
Giannis Adamopoulos [Sun, 19 Feb 2017 09:10:03 +0000 (09:10 +0000)]
[SHELL32] -Try to fix themes when opening the control panel applet from the control panel.

svn path=/trunk/; revision=73833

3 years ago[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek...
Mark Jansen [Sat, 18 Feb 2017 22:54:31 +0000 (22:54 +0000)]
[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!

svn path=/trunk/; revision=73832

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 21:37:56 +0000 (21:37 +0000)]
[FASTFAT]
Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.

svn path=/trunk/; revision=73831

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 21:24:31 +0000 (21:24 +0000)]
[FASTFAT]
Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.
This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.
A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.

This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.
The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.

svn path=/trunk/; revision=73830

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 18:35:48 +0000 (18:35 +0000)]
[FASTFAT]
Move ReadVolumeLabel() to fsctl.c close to functions that need it

svn path=/trunk/; revision=73829

3 years ago[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case...
Giannis Adamopoulos [Sat, 18 Feb 2017 18:14:32 +0000 (18:14 +0000)]
[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.

svn path=/trunk/; revision=73828

3 years ago[KMTESTS:MM]
Thomas Faber [Sat, 18 Feb 2017 14:22:44 +0000 (14:22 +0000)]
[KMTESTS:MM]
- Add some stricter checks and improved error handling in NtCreateSection_user

svn path=/trunk/; revision=73827

3 years ago[USBSTOR]
Thomas Faber [Sat, 18 Feb 2017 11:47:40 +0000 (11:47 +0000)]
[USBSTOR]
- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077

svn path=/trunk/; revision=73826

3 years ago[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ...
Mark Jansen [Sat, 18 Feb 2017 11:25:31 +0000 (11:25 +0000)]
[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621

svn path=/trunk/; revision=73825

3 years ago[PSDK]
Thomas Faber [Sat, 18 Feb 2017 09:30:59 +0000 (09:30 +0000)]
[PSDK]
- Fix KsFilterFactoryGetDevice
CORE-11794

svn path=/trunk/; revision=73824

3 years ago[SHELL32]
Kamil Hornicek [Fri, 17 Feb 2017 23:39:39 +0000 (23:39 +0000)]
[SHELL32]
- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).

svn path=/trunk/; revision=73823

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 22:25:03 +0000 (22:25 +0000)]
[FASTFAT]
Generalize the usage of functions pointers for FatX vs Fat specific code (direntry).
This should also help speeding up FastFAT.

svn path=/trunk/; revision=73822

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 21:24:12 +0000 (21:24 +0000)]
[FASTFAT]
In the FCB, get rid of the FCB_IS_FATX_ENTRY flag. It makes no sense to have it on each and every file as the VCB already has such flag

svn path=/trunk/; revision=73821

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 18:06:38 +0000 (18:06 +0000)]
[FASTFAT]
Fix a typo brought in r73819

svn path=/trunk/; revision=73820

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 17:58:18 +0000 (17:58 +0000)]
[FASTFAT]
More FastFAT cleanup.
Except a light performances boost due to useless checks removal in read/write and to some functions inlining

More to follow...

svn path=/trunk/; revision=73819

3 years ago[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.
Giannis Adamopoulos [Fri, 17 Feb 2017 17:23:17 +0000 (17:23 +0000)]
[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.

svn path=/trunk/; revision=73818

3 years ago[DBGHELP] Add experimental rsym support. CORE-12773
Mark Jansen [Fri, 17 Feb 2017 16:18:15 +0000 (16:18 +0000)]
[DBGHELP] Add experimental rsym support. CORE-12773

svn path=/trunk/; revision=73817

3 years ago[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773
Mark Jansen [Fri, 17 Feb 2017 16:15:49 +0000 (16:15 +0000)]
[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773

svn path=/trunk/; revision=73816

3 years ago[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve
Mark Jansen [Fri, 17 Feb 2017 16:12:19 +0000 (16:12 +0000)]
[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve

svn path=/trunk/; revision=73815

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:58:26 +0000 (13:58 +0000)]
[LIBTIFF]
- Fix GCC non-PCH build
CORE-12775

svn path=/trunk/; revision=73814

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:43:05 +0000 (13:43 +0000)]
[LIBTIFF]
- Update to version 4.0.7
CORE-12775 #resolve

svn path=/trunk/; revision=73813

3 years ago[WIN32K]
Kamil Hornicek [Fri, 17 Feb 2017 13:13:36 +0000 (13:13 +0000)]
[WIN32K]
- The pattern bitmap can get deleted during the GDI cleanup for process before the brush itself.
- Gets rid of some of those pesky "GreDeleteObject: Trying to delete invalid object" debug prints.

svn path=/trunk/; revision=73812

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:05:50 +0000 (13:05 +0000)]
[LIBTIFF]
- Use the official libtiff 4.0.3 def file to determine exported functions (instead of exporting everything in GCC builds, nothing in MSVC builds)
- Remove unused ROS-diffs
CORE-6898 CORE-12275

svn path=/trunk/; revision=73811

3 years ago[PING]
Kamil Hornicek [Fri, 17 Feb 2017 12:30:14 +0000 (12:30 +0000)]
[PING]
- Addendum to r73626. Convert the print specifiers too so that ping doesn't only output the old specifiers themselves.

svn path=/trunk/; revision=73810

3 years ago[WINDOWSCODECS]
Thomas Faber [Fri, 17 Feb 2017 12:17:20 +0000 (12:17 +0000)]
[WINDOWSCODECS]
- Fix some MSVC-specific definitions

svn path=/trunk/; revision=73809

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 11:38:05 +0000 (11:38 +0000)]
[FASTFAT]
Thomas->happiness++;

svn path=/trunk/; revision=73808

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 11:08:38 +0000 (11:08 +0000)]
[FASTFAT]
Fix a few ugly things.
Both Thomas & cppcheck should be happier now!

svn path=/trunk/; revision=73807

3 years ago[WIN32k]
Giannis Adamopoulos [Fri, 17 Feb 2017 11:07:14 +0000 (11:07 +0000)]
[WIN32k]
 -Fix a couple of cases where we use the versioned class atom instead of the non versioned one.

[USER32]
- Add support for versioned classes in RegisterClassExWOWW, GetClassInfoExW, GetClassInfoExA, UnregisterClassA, UnregisterClassW, and User32CreateWindowEx
- Make ClassNameToVersion return the name of the versioned class and the library name that implements it while preserving a hack that lets user32 know which classes are registered by comctl32 (this is needed because the default activation context doesn't contain the non versioned classes yet).
- Make VersionRegisterClass to load the specified library and make it register its classes which is used when the class is not registered yet but its manifest is active.

svn path=/trunk/; revision=73806

3 years ago[LIBJPEG]
Thomas Faber [Fri, 17 Feb 2017 11:05:50 +0000 (11:05 +0000)]
[LIBJPEG]
- Update to version 9b
CORE-12775

svn path=/trunk/; revision=73805

3 years ago[LIBPNG]
Thomas Faber [Fri, 17 Feb 2017 10:42:03 +0000 (10:42 +0000)]
[LIBPNG]
- Update to version 1.6.28
CORE-12775

svn path=/trunk/; revision=73804

3 years ago[COMCTL32]
Giannis Adamopoulos [Fri, 17 Feb 2017 10:04:24 +0000 (10:04 +0000)]
[COMCTL32]
- Add and install a manifest for comctl32 version 5.82.
- Since our comctl32 tries to imitate both version 5 and version 6, register its classes twice, once while having the version 6 manifest active and once when having the version 5 active.
- Register the themed versions of the built in controls while having the version 6 manifest active (and register them as global classes). This breaks theming of built in controls until versioned classes get implemented.
- Do not try to subclass the dialog class. This is incorrect and can lead to problems like in CORE-8534, CORE-12727, CORE-8387. This removes the background texture of the themed tabs which will be implemented in the future in uxtheme using api hooks.
This breaks a great deal of theming but keep in mind that it is in the middle of a transition to have them implemented correctly without the terrible side effects (broken ansi conversion, not always  using themes for built in controls. However comctl32 is now ready for versioned classes to be enabled.
CORE-12285

svn path=/trunk/; revision=73803

3 years ago[SPIDER]
Kamil Hornicek [Wed, 15 Feb 2017 10:53:41 +0000 (10:53 +0000)]
[SPIDER]
- Make the formatting a bit more consistent.

[EVENTVWR]
- Remove an useless cast.

svn path=/trunk/; revision=73802

3 years ago[BOOTLIB]: Fix assembly file containing Archx86TransferTo32BitApplicationAsm to use...
Alex Ionescu [Wed, 15 Feb 2017 00:53:15 +0000 (00:53 +0000)]
[BOOTLIB]: Fix assembly file containing Archx86TransferTo32BitApplicationAsm to use assume:nothing, otherwise we end up with SS segment overrides everywhere.
[BOOTLIB]: Correctly bias access to GDT/IDT registers by 2 bytes since this is a 48-bit instruction. The loaded GDT/IDT was previously invalid and causing random GPFs.
[BOOTLIB]: Fix EfiStall in protected mode. It was previously not stalling.
[BOOTLIB]: Fix calculation in MmMapPhysicalAddress
[BOOTLIB]: Fix missing goto in MmSelectMappingAddress which broke the function in real mode.
[BOOTLIB]: Fix incorrect ranges in MmSelectMappingAddress.
[BOOTLIB]: Fix incorrect offset calculation in MmSelectMappingAddress.
Now hitting (as expected), unimplemented virtual code path in BlMmMapPhysicalAddressEx.

svn path=/trunk/; revision=73801

3 years ago[RUNDLL32] -Load and activate the manifest of the hosted dll before loading the library.
Giannis Adamopoulos [Tue, 14 Feb 2017 09:47:13 +0000 (09:47 +0000)]
[RUNDLL32] -Load and activate the manifest of the hosted dll before loading the library.

svn path=/trunk/; revision=73799

3 years ago[NEWDEV] -Use manifest_hosted.rc.
Giannis Adamopoulos [Tue, 14 Feb 2017 09:41:38 +0000 (09:41 +0000)]
[NEWDEV] -Use manifest_hosted.rc.

svn path=/trunk/; revision=73798

3 years ago[BOOTLIB]: Clarify some attributes now that their meaning is clearer.
Alex Ionescu [Mon, 13 Feb 2017 23:47:06 +0000 (23:47 +0000)]
[BOOTLIB]: Clarify some attributes now that their meaning is clearer.
[BOOTLIB]: Implement MmSelectMappingAddress and fix its prototype.
[BOOTLIB]: Implement MmPapPageAllocatorExtend and fix MmPapAllocatePagesInRange to use it.
We are trying to choose VA 0 for PA 0x8000 and currently fail due to conflicts. TBD.

svn path=/trunk/; revision=73797

3 years ago[UMPNPMGR]
Eric Kohl [Mon, 13 Feb 2017 22:59:40 +0000 (22:59 +0000)]
[UMPNPMGR]
PNP_GetDeviceList and PNP_GetDeviceListSize:
- Do not return CR_CALL_NOT_IMPLEMENTED by default.
- pulLength is counted in characters, not in bytes!
- Use the correct Relations value for PowerRelations.

[NDK]
Add the PowerRelations value to a comment.

[DEVMGR]
CM_Get_Device_ID_List_Size_ExW and CM_Get_Device_ID_List_ExW count the buffer length in characters, not in bytes!

svn path=/trunk/; revision=73796

3 years ago[NTOSKRNL]
Eric Kohl [Mon, 13 Feb 2017 22:38:11 +0000 (22:38 +0000)]
[NTOSKRNL]
Implement IopGetDeviceRelations().

svn path=/trunk/; revision=73795

3 years ago[SHELL32] -Call CPlApplet export of control panel applets with the correct activation...
Giannis Adamopoulos [Mon, 13 Feb 2017 22:09:14 +0000 (22:09 +0000)]
[SHELL32] -Call CPlApplet export of control panel applets with the correct activation context.

svn path=/trunk/; revision=73794

3 years ago[FASTFAT]
Pierre Schweitzer [Mon, 13 Feb 2017 21:17:26 +0000 (21:17 +0000)]
[FASTFAT]
In order to make VfatVerify() work on something else than floppies, ask for change count when issuing IOCTL_DISK_CHECK_VERIFY

svn path=/trunk/; revision=73793

3 years ago[UXTHEME] -Move the global variables for the scrollbars into the WND_CONTEXT. Hook...
Giannis Adamopoulos [Mon, 13 Feb 2017 18:45:18 +0000 (18:45 +0000)]
[UXTHEME] -Move the global variables for the scrollbars into the WND_CONTEXT. Hook ThemeGetScrollInfo to set the correct tracking position as tracking is handled completely in uxtheme. Fixes scrolling while dragging the scrollbar thumb in the listview control.

svn path=/trunk/; revision=73792

3 years ago[UXTHEME] -Remove an overzealous check that prevented the scrollbar from being repain...
Giannis Adamopoulos [Mon, 13 Feb 2017 17:31:14 +0000 (17:31 +0000)]
[UXTHEME] -Remove an overzealous check that prevented the scrollbar from being repainted when the cursor was moving in it.

svn path=/trunk/; revision=73791

3 years ago[UXTHEME] -Fix the size of the thump in the themed scrollbar. CORE-7988
Giannis Adamopoulos [Mon, 13 Feb 2017 17:27:13 +0000 (17:27 +0000)]
[UXTHEME] -Fix the size of the thump in the themed scrollbar. CORE-7988

svn path=/trunk/; revision=73790

3 years ago[COMCTL32] -Fix drawing the borders of themed controls. Patch by Sylvain Deverre...
Giannis Adamopoulos [Mon, 13 Feb 2017 15:08:47 +0000 (15:08 +0000)]
[COMCTL32] -Fix drawing the borders of themed controls. Patch by Sylvain Deverre. CORE-10761

svn path=/trunk/; revision=73789

3 years ago[BROWSEUI] -Fix a couple of cases where the tree view can cause a crash.
Giannis Adamopoulos [Mon, 13 Feb 2017 15:04:03 +0000 (15:04 +0000)]
[BROWSEUI] -Fix a couple of cases where the tree view can cause a crash.

svn path=/trunk/; revision=73788

3 years ago[USER32_APITEST]: Add a couple more tests for GetClassInfoExW.
Giannis Adamopoulos [Mon, 13 Feb 2017 09:58:06 +0000 (09:58 +0000)]
[USER32_APITEST]: Add a couple more tests for GetClassInfoExW.

svn path=/trunk/; revision=73787

3 years ago[WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact...
Giannis Adamopoulos [Mon, 13 Feb 2017 09:56:35 +0000 (09:56 +0000)]
[WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact return value.

svn path=/trunk/; revision=73786

3 years ago[WIN32K:NTUSER]
Thomas Faber [Sun, 12 Feb 2017 23:09:35 +0000 (23:09 +0000)]
[WIN32K:NTUSER]
- Kill a noisy debug print

svn path=/trunk/; revision=73785

3 years ago[FASTFAT]
Pierre Schweitzer [Sun, 12 Feb 2017 19:31:31 +0000 (19:31 +0000)]
[FASTFAT]
Don't attempt to verify volume if it was already verified in between

svn path=/trunk/; revision=73784

3 years ago[WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the...
Giannis Adamopoulos [Sun, 12 Feb 2017 12:11:18 +0000 (12:11 +0000)]
[WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the versioned class name. Show that NtUserFindWindowEx needs the non versioned class name.

svn path=/trunk/; revision=73783

3 years ago[SMSS]
Pierre Schweitzer [Sun, 12 Feb 2017 08:49:53 +0000 (08:49 +0000)]
[SMSS]
Remove useless nullptr check

svn path=/trunk/; revision=73782

3 years ago[SERVMAN]
Pierre Schweitzer [Sun, 12 Feb 2017 08:42:03 +0000 (08:42 +0000)]
[SERVMAN]
Remove duplicated condition

svn path=/trunk/; revision=73781

3 years ago[FASTFAT]
Pierre Schweitzer [Sun, 12 Feb 2017 08:25:42 +0000 (08:25 +0000)]
[FASTFAT]
Remove useless assignement

svn path=/trunk/; revision=73780

3 years ago[IP]
Thomas Faber [Sat, 11 Feb 2017 23:13:45 +0000 (23:13 +0000)]
[IP]
- Handle chained pbuf structures in TCPSendDataCallback
CORE-10715

svn path=/trunk/; revision=73779

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 11 Feb 2017 20:26:33 +0000 (20:26 +0000)]
[FASTFAT]
In case of an error while trying to verify the volume, only return STATUS_WRONG_VOLUME is raw mounts are allowed

svn path=/trunk/; revision=73778

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 11 Feb 2017 18:33:47 +0000 (18:33 +0000)]
[FASTFAT]
Remove useless assignement

svn path=/trunk/; revision=73777

3 years ago[REGEDIT]
Kamil Hornicek [Sat, 11 Feb 2017 16:02:49 +0000 (16:02 +0000)]
[REGEDIT]
- Fix a possible null pointer dereference. CID 731448
- Check string length before copying into a fixed size buffer. CID 515207
- Bail out of _CmdWndProc if keyPath is null. CID 1102164
- Use strsafe functions. CID 1102477

svn path=/trunk/; revision=73776

3 years ago[CRT]
Thomas Faber [Sat, 11 Feb 2017 15:55:56 +0000 (15:55 +0000)]
[CRT]
- Add missing _sgdt declaration in intrin.h

svn path=/trunk/; revision=73775

3 years ago[IP]
Thomas Faber [Sat, 11 Feb 2017 13:36:05 +0000 (13:36 +0000)]
[IP]
- Apparently MIN_TRACE isn't enough to get printed...
CORE-10715

svn path=/trunk/; revision=73774

3 years ago[USER32] -class.c: Try to use 4 space indentation. Convert tabs to spaces.
Giannis Adamopoulos [Sat, 11 Feb 2017 12:18:06 +0000 (12:18 +0000)]
[USER32] -class.c: Try to use 4 space indentation. Convert tabs to spaces.

svn path=/trunk/; revision=73773

3 years ago[IP]
Thomas Faber [Sat, 11 Feb 2017 11:46:38 +0000 (11:46 +0000)]
[IP]
- Print some debugging information when hitting 'p->tot_len == p->len' assertion in TCPSendDataCallback.
CORE-10715

svn path=/trunk/; revision=73772

3 years ago[IPHLPAPI][NETCFGX]
Thomas Faber [Sat, 11 Feb 2017 10:54:09 +0000 (10:54 +0000)]
[IPHLPAPI][NETCFGX]
- Don't check arrays against NULL. CID 513720, 513721, 13220481322049

svn path=/trunk/; revision=73771

3 years ago[UMPNPMGR]
Kamil Hornicek [Sat, 11 Feb 2017 10:34:35 +0000 (10:34 +0000)]
[UMPNPMGR]
- Fix a possible null pointer dereference. CID 515158

svn path=/trunk/; revision=73770

3 years ago[USER32_APITEST] -Add more tests for versioned classes.
Giannis Adamopoulos [Sat, 11 Feb 2017 10:01:13 +0000 (10:01 +0000)]
[USER32_APITEST] -Add more tests for versioned classes.

svn path=/trunk/; revision=73769

3 years ago[User32]
James Tabor [Fri, 10 Feb 2017 16:05:15 +0000 (16:05 +0000)]
[User32]
- Patch by Dmitry Timoshkov : Fix groupbox rectangle calculation in the button's WM_SETTEXT handler. BUTTON_CalcLabelRect should use the button font. Otherwise WM_SETTEXT handler gets wrong rectangle to erase an old text.
- Fixes CORE-12464.

svn path=/trunk/; revision=73768

3 years ago[KERNEL32_APITESTS]: Add more tests for FindActCtxSectionStringW.
Giannis Adamopoulos [Fri, 10 Feb 2017 00:00:28 +0000 (00:00 +0000)]
[KERNEL32_APITESTS]: Add more tests for FindActCtxSectionStringW.

svn path=/trunk/; revision=73767

3 years ago[WINLOGON][MSGINA] -Remove resource manifests. These two components need some special...
Giannis Adamopoulos [Thu, 9 Feb 2017 13:27:36 +0000 (13:27 +0000)]
[WINLOGON][MSGINA] -Remove resource manifests. These two components need some special handling regarding manifests.

svn path=/trunk/; revision=73766

3 years ago[NTOSKRNL] Fix some possible overruns in FsRtlIsNameInExpressionPrivate + add a test...
Mark Jansen [Thu, 9 Feb 2017 00:12:36 +0000 (00:12 +0000)]
[NTOSKRNL] Fix some possible overruns in FsRtlIsNameInExpressionPrivate + add a test from Thomas. CORE-12121

svn path=/trunk/; revision=73765

3 years ago[HIVECLS]: Fix /file switch in the open command for MSThemes files.
Hermès Bélusca-Maïto [Wed, 8 Feb 2017 23:34:08 +0000 (23:34 +0000)]
[HIVECLS]: Fix /file switch in the open command for MSThemes files.

svn path=/trunk/; revision=73764

3 years ago[FONTVIEW][HIVECLS]: Addendum to r73755 and r73759: .otc is an OpenType Font Collecti...
Hermès Bélusca-Maïto [Wed, 8 Feb 2017 23:30:05 +0000 (23:30 +0000)]
[FONTVIEW][HIVECLS]: Addendum to r73755 and r73759: .otc is an OpenType Font Collection file .

svn path=/trunk/; revision=73763

3 years agoJe parle la france.
Hermès Bélusca-Maïto [Wed, 8 Feb 2017 23:00:43 +0000 (23:00 +0000)]
Je parle la france.

svn path=/trunk/; revision=73762

3 years ago[HIVECLS]: Fix few command paths.
Hermès Bélusca-Maïto [Wed, 8 Feb 2017 22:53:28 +0000 (22:53 +0000)]
[HIVECLS]: Fix few command paths.

svn path=/trunk/; revision=73761

3 years ago[TASKMGR]
Kamil Hornicek [Wed, 8 Feb 2017 22:52:46 +0000 (22:52 +0000)]
[TASKMGR]
- ellipsis is a pointer not an array. CID 1321855

svn path=/trunk/; revision=73760

3 years ago[HIVECLS|FONTVIEW] Fix fontview registration and add additional extensions. Patch...
Mark Jansen [Wed, 8 Feb 2017 22:41:10 +0000 (22:41 +0000)]
[HIVECLS|FONTVIEW] Fix fontview registration and add additional extensions. Patch by Katayama Hirofumi MZ. CORE-6621

svn path=/trunk/; revision=73759

3 years ago[SHELL32] CDefaultContextMenu: Fix starting applications with just one 'static' menu...
Mark Jansen [Wed, 8 Feb 2017 22:24:47 +0000 (22:24 +0000)]
[SHELL32] CDefaultContextMenu: Fix starting applications with just one 'static' menu item.

svn path=/trunk/; revision=73758

3 years ago[FONTVIEW] Add support for font collections + show some extra font properties. Patch...
Mark Jansen [Wed, 8 Feb 2017 17:56:22 +0000 (17:56 +0000)]
[FONTVIEW] Add support for font collections + show some extra font properties. Patch by Katayama Hirofumi MZ. CORE-6621
Some minor changes by me

svn path=/trunk/; revision=73755

3 years ago[EVENTVWR]
Kamil Hornicek [Tue, 7 Feb 2017 22:33:02 +0000 (22:33 +0000)]
[EVENTVWR]
- Attempt to speed up loading and displaying logs in EnumEventsThread:
- Rewriting the code fix an infinite loop that could happen under low memory conditions (this potentially speeds things up quite a lot).
- Remove ListView subclassing - sorry Hermès but not only it keeps constantly redrawing under Windows but also adds too much overhead.
- Don't read the event log records one by one but in chunks of roughly 0x7ffff bytes (maximum size allowed).
- Use poor man's "caching" of the event user name (optimizing/caching rest of the stuff in the loop didn't yield any significant speed up).

Result: Loading ~40000 records under Win7 went from 4.5 minutes to 65 seconds.

svn path=/trunk/; revision=73749

3 years ago[KERNEL32] Silence some noise during process creation.
Mark Jansen [Tue, 7 Feb 2017 16:45:50 +0000 (16:45 +0000)]
[KERNEL32] Silence some noise during process creation.

svn path=/trunk/; revision=73748

3 years ago[USER32_APITEST]: Add more tests for RegisterClassEx.
Giannis Adamopoulos [Tue, 7 Feb 2017 12:11:26 +0000 (12:11 +0000)]
[USER32_APITEST]: Add more tests for RegisterClassEx.

svn path=/trunk/; revision=73747

3 years ago[GDI32_APITEST] Add tests for font creation. Patch by Katayama Hirofumi MZ. CORE...
Mark Jansen [Tue, 7 Feb 2017 11:37:36 +0000 (11:37 +0000)]
[GDI32_APITEST] Add tests for font creation. Patch by Katayama Hirofumi MZ. CORE-6621

svn path=/trunk/; revision=73746

3 years ago[CRT_APITEST] Add additional test for __getmainargs
Mark Jansen [Tue, 7 Feb 2017 10:35:35 +0000 (10:35 +0000)]
[CRT_APITEST] Add additional test for __getmainargs

svn path=/trunk/; revision=73745

3 years ago[WIN32SS] Mute a major spammer in AHK tests.
Mark Jansen [Tue, 7 Feb 2017 10:33:42 +0000 (10:33 +0000)]
[WIN32SS] Mute a major spammer in AHK tests.

svn path=/trunk/; revision=73744

3 years ago[BOOTLIB] Additional EfiPrintf conversion like r73736 for MSVC 2013
Mark Jansen [Tue, 7 Feb 2017 10:32:20 +0000 (10:32 +0000)]
[BOOTLIB] Additional EfiPrintf conversion like r73736 for MSVC 2013

svn path=/trunk/; revision=73743

3 years ago[BOOTLIB]: Implement MmFwGetMemoryMap when virtual memory is being enabled.
Alex Ionescu [Tue, 7 Feb 2017 04:26:21 +0000 (04:26 +0000)]
[BOOTLIB]: Implement MmFwGetMemoryMap when virtual memory is being enabled.
[BOOTLIB]: Implement MmPapAllocatePagesInRange when virtual memory is being enabled.
What's left now is implementing extension for the PA allocator when VM is enabled.

svn path=/trunk/; revision=73742

3 years ago[BOOTLIB]: Finish implementing Mmx86pMapMemoryRegions.
Alex Ionescu [Tue, 7 Feb 2017 03:34:49 +0000 (03:34 +0000)]
[BOOTLIB]: Finish implementing Mmx86pMapMemoryRegions.

svn path=/trunk/; revision=73741

3 years ago[BOOTLIB]: Implement most of Mmx86pMapMemoryRegions. Just missing the UEFI mappings...
Alex Ionescu [Tue, 7 Feb 2017 01:52:57 +0000 (01:52 +0000)]
[BOOTLIB]: Implement most of Mmx86pMapMemoryRegions. Just missing the UEFI mappings now.

svn path=/trunk/; revision=73740

3 years ago[BOOTLIB]: Don't use PTE_BASE/PDE_BASE in bootlib. Use MmPteBase and MmPdeBase instead.
Alex Ionescu [Tue, 7 Feb 2017 01:35:11 +0000 (01:35 +0000)]
[BOOTLIB]: Don't use PTE_BASE/PDE_BASE in bootlib. Use MmPteBase and MmPdeBase instead.
[BOOTLIB]: Implement MmDefpMapPhysicalAddress, MmDefpTranslateVirtualAddress. Fix definition of Mmx86MapPhysicalAddress.

svn path=/trunk/; revision=73739

3 years ago[BOOTLIB]: Implement BlMmIsTranslationEnabled and MmMapPhysicalAddress. MmDefpMapPhys...
Alex Ionescu [Mon, 6 Feb 2017 23:13:47 +0000 (23:13 +0000)]
[BOOTLIB]: Implement BlMmIsTranslationEnabled and MmMapPhysicalAddress. MmDefpMapPhysicalAddress is missing at this point.

svn path=/trunk/; revision=73738

3 years ago[USERENV]
Hermès Bélusca-Maïto [Mon, 6 Feb 2017 22:58:20 +0000 (22:58 +0000)]
[USERENV]
- Fix some DPRINTs;
- Add parameter validation in CreateUserProfileExW;
- Return the directory path of the created profile in CreateUserProfileExW, if the user wants it;
- Add value type validation for RegQueryValueExW calls;
- Use ARRAYSIZE where needed;
- Add parameter validation in GetAllUsersProfileDirectoryA, GetDefaultUserProfileDirectoryA;
- Correctly return error code in GetAllUsersProfileDirectoryW, GetDefaultUserProfileDirectoryW, GetProfilesDirectoryW and GetUserProfileDirectoryW. Should fix the userenv_apitest:GetProfileDirs tests.

svn path=/trunk/; revision=73737

3 years ago[BOOTLIB]: Make the EfiPrintf with __FUNCTION__ work also on GCC. Also, on MSVC ...
Hermès Bélusca-Maïto [Mon, 6 Feb 2017 22:46:57 +0000 (22:46 +0000)]
[BOOTLIB]: Make the EfiPrintf with __FUNCTION__ work also on GCC. Also, on MSVC (2010 at least), concatenating without converting __FUNCTION__ to unicode and adding 'L' for the "\r\n" returned error C2308.

svn path=/trunk/; revision=73736

3 years ago[USERENV_APITEST]: Add some simple tests for Get[AllUsers|DefaultUser|User]Profile...
Hermès Bélusca-Maïto [Mon, 6 Feb 2017 22:14:50 +0000 (22:14 +0000)]
[USERENV_APITEST]: Add some simple tests for Get[AllUsers|DefaultUser|User]Profile[s]Directory APIs (checking return values & last errors).

svn path=/trunk/; revision=73735

3 years ago[BOOTLIB]: Finish implementation of MmMdRemoveRegionFromMdlEx for other straddling...
Alex Ionescu [Mon, 6 Feb 2017 22:11:21 +0000 (22:11 +0000)]
[BOOTLIB]: Finish implementation of MmMdRemoveRegionFromMdlEx for other straddling scenarios.
[BOOTLIB]: Implement Mmx86MapInitStructure and most of Mmx86InitializeMemoryMap.
[BOOTLIB]: Continue implementation of MmDefInitializeTranslation.
[BOOTLIB]: More explicitly mark paths which are not yet implemented for paging mode yet (but only on compilers that don't give compiler errors when trying to use __FUNCTION__.

svn path=/trunk/; revision=73734

3 years ago[FASTFAT]
Pierre Schweitzer [Mon, 6 Feb 2017 19:43:48 +0000 (19:43 +0000)]
[FASTFAT]
Take the volume label into account when comparing the FAT volumes in case of a verify.
This helps avoiding remounting every removable device on verify. Current hack is only kept for FATX volumes for now.

svn path=/trunk/; revision=73733

3 years ago[BOOTLIB]: Don't use __getcallerseflags() in Archx86IsCpuidSupported -- __readeflags...
Alex Ionescu [Mon, 6 Feb 2017 19:34:15 +0000 (19:34 +0000)]
[BOOTLIB]: Don't use __getcallerseflags() in Archx86IsCpuidSupported -- __readeflags should be good enough.

svn path=/trunk/; revision=73732

3 years ago[ACCESS]
Eric Kohl [Mon, 6 Feb 2017 19:22:48 +0000 (19:22 +0000)]
[ACCESS]
Get rid of the calculated control positions and sizes.

svn path=/trunk/; revision=73731

3 years agoCleanly compiles with both VS/GCC on my system even though bcd.h is not included...
Alex Ionescu [Mon, 6 Feb 2017 19:21:01 +0000 (19:21 +0000)]
Cleanly compiles with both VS/GCC on my system even though bcd.h is not included. I have no idea how. Evidence in IRC channel.

svn path=/trunk/; revision=73730

3 years ago[BOOTLIB]: Implement MmPaReserveSelfMapPages, MmPaReleaseSelfMapPages
Alex Ionescu [Mon, 6 Feb 2017 19:07:17 +0000 (19:07 +0000)]
[BOOTLIB]: Implement MmPaReserveSelfMapPages, MmPaReleaseSelfMapPages
[BOOTLIB]: Stub MmDefMoveVirtualAddressRange, MmDefZeroVirtualAddressRange, MmDefRelocateSelfMap, MmDefpDestroySelfMap, MmDefpUnmapVirtualAddress, MmDefpRemapVirtualAddress, MmDefpMapPhysicalAddress, MmDefpTranslateVirtualAddress,
[BOOTLIB]: Implement MmDefpFlushTlbEntry, MmDefpFlushTlb
[BOOTLIB]: Implement MmPaReleaseSelfMapPages, MmPaReserveSelfMapPages.
[BOOTLIB]: Implement Archx86IsCpuidSupported, BlArchIsCpuIdFunctionSupported, BlArchCpuId, BlArchGetPerformanceCounter.
[BOOTLIB]: Implement MmArchInitialize.
[BOOTLIB]: Implement most of MmDefInitializeTranslation. Almost ready to turn on paging.

svn path=/trunk/; revision=73729