Joachim Henze [Fri, 10 Apr 2020 16:59:15 +0000 (18:59 +0200)]
[ZIPFLDR] CORE-16823 fr-FR Translate 'Click next to extract'
Joachim Henze [Fri, 10 Apr 2020 16:32:04 +0000 (18:32 +0200)]
[STOBJECT] CORE-16598 fr-FR translation of 'Adjust Power Settings'
Katayama Hirofumi MZ [Fri, 10 Apr 2020 14:08:31 +0000 (23:08 +0900)]
[BROWSEUI] Add 'm_' prefix to CExplorerBand members (#2524)
Add 'm_' prefix to the variable members of class CExplorerBand for readability.
CORE-13950
Katayama Hirofumi MZ [Fri, 10 Apr 2020 12:57:58 +0000 (21:57 +0900)]
[SHELL32] Simplify CChangeNotify::ShouldNotify
CORE-13950
Katayama Hirofumi MZ [Fri, 10 Apr 2020 12:51:22 +0000 (21:51 +0900)]
[SHELL32] Improve CChangeNotify::ShouldNotify
Shell change notification was not sent to My Documents.
CORE-13950
Eric Kohl [Fri, 10 Apr 2020 11:40:10 +0000 (13:40 +0200)]
[USBSTOR] Add missing compatible device id 5
Jérôme Gardou [Fri, 10 Apr 2020 09:23:58 +0000 (11:23 +0200)]
[IPHLPAPI] Do not use free() on buffer allocated with HeapAlloc
Katayama Hirofumi MZ [Fri, 10 Apr 2020 09:16:31 +0000 (18:16 +0900)]
[SHELLEXT][ZIPFLDR] SendTo Zip compressed folder needs notification
CORE-16818
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 21:20:54 +0000 (23:20 +0200)]
[W32TIME][BOOTDATA] Export SvchostEntry_W32Time() as an alias to W32TmServiceMain, and use the former as the service entry point specified in the registry, for Windows compatibility.
Hervé Poussineau [Thu, 9 Apr 2020 17:47:01 +0000 (19:47 +0200)]
[NTOS] Add a #define __ROS_ROSSYM__ when using rossym
Use it where needed.
Tibor Lajos Füzi [Thu, 9 Apr 2020 19:49:34 +0000 (21:49 +0200)]
[TRANSLATION] Hungarian translation update (#2519)
Hungarian translation update for solitaire, spider solitaire, winemine, task manager.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 18:37:01 +0000 (20:37 +0200)]
[LIB:ARBITER] Addendum to
374f2b4d: Fix build.
- No need to use a PCH when compiling a 1-file library.
- Add the _NTSYSTEM_ definition.
- Since the arbiter.h file is to be included by the users of this
library, namely only kernel-mode NT components (incl. NTOS), there
is no need to include the standard kernel-mode headers in it.
Include these headers instead in the private implementation of the
library, arbiter.c.
Serge Gautherie [Thu, 9 Apr 2020 17:42:00 +0000 (19:42 +0200)]
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)
Import
https://source.winehq.org/git/wine.git/commit/
83acbb79c1a059cbfec58fbb05619e7a6f703f2d
Related to CORE-13950
Vadim Galyant [Thu, 9 Apr 2020 17:19:00 +0000 (19:19 +0200)]
[HALX86][PCIX] Statically link HALx86 and PCIX to the arbiter library. (#2471)
Vadim Galyant [Thu, 26 Mar 2020 14:45:59 +0000 (18:45 +0400)]
[NTOS][SDK:LIB] Add a Resources Arbiter library, to be used by bus drivers (acpi, pci), kernel and legacy hal (PIC HAL). (#2471)
Bișoc George [Thu, 9 Apr 2020 17:06:00 +0000 (19:06 +0200)]
[MSGINA] Redraw only the animation bar scroll (#2518)
Invalidating and updating the whole window is a waste of computation resources and may cause certain controls notably the text string control to flicker. So instead, just invalidate the specific portion of the client area which is the animation bar.
Serge Gautherie [Thu, 9 Apr 2020 16:54:15 +0000 (18:54 +0200)]
[MSGINA] gui: Remove superfluous DLG_DATA.TimerID (#2505)
And use a timer ID define, with a positive value; report SetTimer() failure.
Mas Ahmad Muhammad [Thu, 9 Apr 2020 16:49:45 +0000 (23:49 +0700)]
[TRANSLATION] Add and update Indonesian translations (#2506)
- CMDUTILS: attrib, label (update translation)
- USETUP (add translation)
- HOTPLUG (add translation)
- CONSRV (update translation)
- USERSRV (update translation)
- USER32 (update translation)
- ACLUI (update translation)
- LICCPA (update translation)
- SUBST (update translation)
- REGSVR32 (update translation)
- REGEDIT-CLB (update translation)
- ACPPAGE (update translation)
- TIMEDATE (update translation)
- SOLITAIRE (update translation)
- FDEBUG (update translation)
- SYSSETUP (update translation)
Joachim Henze [Thu, 9 Apr 2020 16:16:24 +0000 (18:16 +0200)]
[SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file)
Julen Urizar Compains [Thu, 9 Apr 2020 16:13:46 +0000 (18:13 +0200)]
[TRANSLATION] Multiple minor fixes and addings. (#2516)
- Applications: eventvwr, fltmgr, servman.
- rosapps: arping, CTM, fontsub, fraginator, imagesoft, systeminfo, vcdcontroltool, vgafontedit.
- CPLs: desk.cpl.
- ReactOS Setup GUI app.
- Screensavers: butterflies, maze, Starfield.
- System: NTVDM, printing/monitors/localmon; the freeze dialog in user32, the error strings in usersrv.
Katayama Hirofumi MZ [Thu, 9 Apr 2020 15:57:08 +0000 (00:57 +0900)]
[SHELL32_APITEST] Add SHAppBarMessage testcase (#2517)
Add a testcase for shell32!SHAppBarMessage function. CORE-7237
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 15:45:40 +0000 (17:45 +0200)]
[BOOTVID] Addendum to
5f2ca473: Forgot to include the precompiled header.
Vadim Galyant [Wed, 8 Apr 2020 16:20:03 +0000 (20:20 +0400)]
[FREELDR] Add parsing boot options from .ini files. (#2511)
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
William Kent [Thu, 9 Apr 2020 14:13:33 +0000 (10:13 -0400)]
[APISETS] Forward _seh_filter_{dll,exe} (#2513)
Since these functions are forwarded to a different function name, update.py misses them.
The choice of target comes from Wine:
https://github.com/wine-mirror/wine/blob/
a98ca88dd1139ad8e16e63fbb349c2fc5e9ad332/dlls/ucrtbase/ucrtbase.spec#L1877-L1878
William Kent [Thu, 9 Apr 2020 14:11:31 +0000 (10:11 -0400)]
[DRWTSN32] Recognize EXCEPTION_WINE_STUB (#2514)
DrWtsn32.exe recognizes several standard exception codes, and prints their names in the crash log. However, EXCEPTION_WINE_STUB is not in this list, and as such it is treated as an unknown error and printed as "--". Having this error code given a name at the start of the crash dump is useful, as it allows me to identify calls to unimplemented issues more readily.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 12:24:52 +0000 (14:24 +0200)]
[SDK:SUBSYS] conmsg.h: Some DWORDs -> ULONGs.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 12:23:27 +0000 (14:23 +0200)]
[FLTMGR][NDK] Fix typos.
Dmitry Borisov [Wed, 8 Apr 2020 05:42:05 +0000 (11:42 +0600)]
[BOOTVID] Code refactoring. (#2510)
- Abstract the VGA and LCD code.
- Create a common file for all platforms.
Dmitry Borisov [Wed, 8 Apr 2020 05:25:11 +0000 (11:25 +0600)]
[BOOTVID] Move the VGA code into the PC directory. (#2510)
Dmitry Borisov [Mon, 6 Apr 2020 21:48:01 +0000 (03:48 +0600)]
[BOOTVID][NTOSKRNL][HALX86] Move hardcoded coordinates of bootvid into one place. (#2504)
Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Katayama Hirofumi MZ [Thu, 9 Apr 2020 07:56:54 +0000 (16:56 +0900)]
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
Victor Perevertkin [Thu, 9 Apr 2020 01:02:06 +0000 (04:02 +0300)]
[CMAKE] Add --gc-sections flag to GCC linker.
This returns C++ binaries size to normal (on GCC 8.4).
I don't see any noticable effect of this on GCC 4.7.2
CORE-16670
Victor Perevertkin [Thu, 9 Apr 2020 00:04:44 +0000 (03:04 +0300)]
[ROSAUTOTEST] Revert
9ff3adb. This fixes MSVC build.
This reverts commit
9ff3adb7d7c6636a1d040d8e53f7203e9d1815a3.
Katayama Hirofumi MZ [Wed, 8 Apr 2020 23:19:47 +0000 (08:19 +0900)]
[SHELL32] Follow-up of #2432
Fixed hang of FireFox.
Victor Perevertkin [Wed, 8 Apr 2020 23:08:10 +0000 (02:08 +0300)]
[ROSAUTOTEST] Change custom auto_array_ptr to std::unique_ptr
Katayama Hirofumi MZ [Wed, 8 Apr 2020 22:30:14 +0000 (07:30 +0900)]
[SHELL32] Implement shell change notification (#2432)
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
James Tabor [Wed, 8 Apr 2020 19:49:38 +0000 (14:49 -0500)]
[User32] Fix Dialog Hang
Patch by JIRA contributor I_Kill_Bugs. See CORE-5078.
Also: https://bugs.winehq.org/show_bug.cgi?id=48749
Mark Jansen [Tue, 7 Apr 2020 18:47:47 +0000 (20:47 +0200)]
[SHIMLIB] Fix gcc8 build crashing when using shims
Victor Perevertkin [Sat, 21 Dec 2019 01:02:47 +0000 (04:02 +0300)]
[TCPIP] Remove duplicate declarations from ticonsts.h
Victor Perevertkin [Fri, 20 Dec 2019 20:19:41 +0000 (23:19 +0300)]
[SDK][IP] Pass IP options to ReceiveDatagramHandler
Victor Perevertkin [Mon, 18 Nov 2019 17:55:10 +0000 (20:55 +0300)]
[TCPIP] Implement IOCTL_ICMP_ECHO_REQUEST in tcpip.sys
Also clean up ICMP handling code in sdk/lib/drivers/ip
CORE-10760
Victor Perevertkin [Mon, 18 Nov 2019 17:54:03 +0000 (20:54 +0300)]
[IPHLPAPI] Make icmp functions use IOCTL_ICMP_ECHO_REQUEST from tcpip.sys
This adds missing features like using events and APCs within IcmpSendEcho2
functions and others.
CORE-10742 CORE-14411
Co-authored-by: Tim Crawford <crawfxrd@gmail.com>
Victor Perevertkin [Fri, 22 Nov 2019 19:04:56 +0000 (22:04 +0300)]
[SDK][IP] Fix formatting
Victor Perevertkin [Sat, 16 Nov 2019 23:29:55 +0000 (02:29 +0300)]
[TCPIP][FORMATTING] Format TiDispatch function. No functional changes
Joachim Henze [Mon, 6 Apr 2020 19:28:45 +0000 (21:28 +0200)]
[USETUP] de-DE Whitespace nitpicking CORE-16792
To harmonize it to 3 separator-spaces how it is done
historically in other dlgs.
Joachim Henze [Mon, 6 Apr 2020 18:55:18 +0000 (20:55 +0200)]
[USETUP] de-DE Fix typo CORE-16792
Fix typo in my last changeset
0.4.14-dev-1323-g
d079342e0a0684b4fb6530ee7ea4728f2a0ae985
Joachim Henze [Mon, 6 Apr 2020 18:49:44 +0000 (20:49 +0200)]
[USETUP] de-DE Overhaul german translation CORE-16792
Joachim Henze [Mon, 6 Apr 2020 15:11:45 +0000 (17:11 +0200)]
[USETUP] de-DE Split a line of text into two parts CORE-16791
Julen Urizar Compains [Mon, 6 Apr 2020 11:17:20 +0000 (13:17 +0200)]
[TRANSLATION] Updating Spanish translation (#2503)
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.
- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
Vadim Galyant [Fri, 24 Jan 2020 00:29:40 +0000 (09:29 +0900)]
[NTOS:MM] Since the _MMPTE_SUBSECTION structure for x86 (without PAE) uses the SubsectionAddressLow truncated by the least significant three bits, the _CONTROL_AREA, _LARGE_CONTROL_AREA, _SUBSECTION, _MSUBSECTION structures must be 8-byte aligned.
Corresponding checks in MmArmInitSystem() have been removed.
Thomas Faber [Sun, 8 Mar 2020 19:05:02 +0000 (20:05 +0100)]
[NTOS:MM] In MmArmInitSystem, perform self-tests after per-arch initialization.
Mm(Non)PagedPoolStart won't be initialized otherwise, making the tests
pretty pointless.
Thomas Faber [Sun, 8 Mar 2020 19:03:33 +0000 (20:03 +0100)]
[NTOS:MM] Initialize MmSubsectionBase on x86 builds. CORE-16731
Spotted by Vadim Galyant.
Thomas Faber [Sat, 22 Feb 2020 11:31:54 +0000 (12:31 +0100)]
[NTOS:MM] Get rid of unnecessary MmZeroingPageThreadActive.
Thomas Faber [Sun, 16 Feb 2020 19:23:07 +0000 (20:23 +0100)]
[NTOS:MM] Fix MmZeroingPageThreadActive race condition.
If a thread calls MiInsertPageInFreeList after the zero page thread has
woken up from its wait but before it acquired the PFN lock,
MmZeroingPageEvent might get set again even though there is no additional
work to be done.
By setting MmZeroingPageThreadActive together with the event, the variable
correctly indicates for future callers that the zero thread will process
newly added free pages.
This partially reverts r72990.
Thomas Faber [Sun, 23 Feb 2020 15:18:18 +0000 (16:18 +0100)]
[NTOS:PO] Call power IRP handlers at PASSIVE_LEVEL when needed. CORE-11648 CORE-16704
This means we now correctly handle the DO_POWER_PAGABLE flag.
In particular, Windows's usbhub.sys calls KeDelayExecutionThread from a
power IRP dispatch routine. We now handle this correctly.
James Tabor [Mon, 6 Apr 2020 02:11:44 +0000 (21:11 -0500)]
[Win32SS] Fix Mask for Draw Frame States
Fixes drawing of caption bar buttons.
See CORE-8808.
Eric Kohl [Sun, 5 Apr 2020 16:29:32 +0000 (18:29 +0200)]
[DEVMGR] CDeviceView::RecurseChildDevices: Skip invalid device nodes
CORE-16780
Thomas Faber [Sat, 4 Apr 2020 19:30:22 +0000 (21:30 +0200)]
[MBEDTLS] Update to version 2.7.14. CORE-16787
Thomas Faber [Wed, 1 Apr 2020 20:27:34 +0000 (22:27 +0200)]
[ACPICA] Update to version
20200326. CORE-16783
Eric Kohl [Sun, 5 Apr 2020 07:48:14 +0000 (09:48 +0200)]
[HOTPLUG] Add the context menu to the device tree view
Colin Finck [Sat, 4 Apr 2020 18:34:41 +0000 (20:34 +0200)]
[ROSAUTOTEST] Submit results to https://reactos.org:8443 instead of https://tlsv1.reactos.org
It is much easier server-side to maintain a different TLS configuration on another port rather than another subdomain.
Mark Jansen [Sat, 4 Apr 2020 16:37:18 +0000 (18:37 +0200)]
[RAPPS] Ensure the download dialog is always destroyed
Ideally, this entire download thing should be rewritten, but that is
something for another day.
Mark Jansen [Tue, 17 Mar 2020 21:35:53 +0000 (22:35 +0100)]
[ATL] Add some hacks for gcc,
since parsing templates is not something it can do
Mark Jansen [Tue, 17 Mar 2020 19:54:45 +0000 (20:54 +0100)]
[RAPPS] Use the provided SizeBytes for the progress,
when the host does not give a file size
Mark Jansen [Tue, 17 Mar 2020 19:54:07 +0000 (20:54 +0100)]
[RAPPS] Enable ATL assertions
Mark Jansen [Tue, 17 Mar 2020 19:53:26 +0000 (20:53 +0100)]
[ATL] Fix an ATLASSERT expression
Mark Jansen [Tue, 17 Mar 2020 19:52:43 +0000 (20:52 +0100)]
[INCLUDE/CRT] Add some debug macro implementations for _DEBUG
CORE-11834
Mark Jansen [Sun, 15 Mar 2020 21:17:30 +0000 (22:17 +0100)]
[CRT] Implement _CrtDbgReport and _CrtDbgReportW
Most functionality is working, except output to file
CORE-11835
Eric Kohl [Sat, 4 Apr 2020 16:13:03 +0000 (18:13 +0200)]
[HOTPLUG] Display devices that are attached to a removable device
Vadim Galyant [Sat, 4 Apr 2020 12:30:40 +0000 (15:30 +0300)]
[NTOS:PNP] Add set functions for debugging PNP and IO managers. (#2457)
Useful functions for debugging IO and PNP managers:
PipDumpDeviceNodes() - displays information about a node(s) in the device tree;
PipDumpResourceRequirementsList() - displays information about a Io List;
PipDumpCmResourceList() - displays information about a Cm List
The tree list of devices (DEVICE_NODE structures) is perhaps the main one in the PnP manager. They also store information about the hardware resources required and assigned to devices.
These functions can help with debugging. For example, you can call PipDumpDeviceNodes() before and after device enumeration and compare the resulting information.
For PipDumpDeviceNodes() it is possible to optionally output:
- allocated resources and boot configuration resources
- resources required
- translated resources
It is possible to displays both a single node and the entire tree.
Optionally, you can display child nodes.
The information output format for resource lists is maximally compressed, since often the only debugging port is a monitor.
The DebugLevel parameter allows dumping in two modes:
0 - unconditional;
1 - if NDEBUG is not defined in "debug.c".
Vadim Galyant [Sat, 4 Apr 2020 12:26:15 +0000 (15:26 +0300)]
[NTOS:MM] Make the definitions and macros for x86 more human-readable. (#2487)
- Move also PDE_MAPPED_VA definition from common miarm.h to ..arch/mm.h.
- Add assert "PAE not yet implemented".
Julen Urizar Compains [Sat, 4 Apr 2020 11:10:34 +0000 (13:10 +0200)]
[TRANSLATION][USETUP] Update Spanish translation of USetup. (#2497)
Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
Colin Finck [Sat, 4 Apr 2020 10:57:50 +0000 (12:57 +0200)]
[ROSAUTOTEST] Use tlsv1.reactos.org for submitting test results now that reactos.org is TLS 1.2+
We still need to be able to submit test results from Windows Server 2003, which supports TLS 1.0 only.
Oleg Dubinskiy [Sat, 7 Mar 2020 19:42:35 +0000 (21:42 +0200)]
[QCAP] Import qcap.dll from Wine Staging 3.3. CORE-16350 (#2421)
Fix also MSVC build.
[DOC] Add qcap entry in README.WINE
Co-Authored-By: Thomas Faber <18138474+ThFabba@users.noreply.github.com>
Oleg Dubinskiy [Sat, 7 Mar 2020 19:35:35 +0000 (21:35 +0200)]
[DXSDK] Sync axextend.idl with Wine Staging 3.3 (#2421)
Required by Wine's qcap.dll CORE-16350
[DXSDK] Restore all deleted code in axextend.idl to propely fix compilation
Also regularize some parts of added code and replace IAMStreamControl interface
with Wine's one, because otherwise compilation fails.
Hermès Bélusca-Maïto [Fri, 3 Apr 2020 16:40:00 +0000 (18:40 +0200)]
[TASKKILL] Merge our updated terminate_processes() function with the one
from Wine, using __REACTOS__ defines to separate the changes.
We note that in effect it completely contains the functionality of
Wine's send_close_messages(), so we keep that latter disabled.
Bișoc George [Fri, 3 Apr 2020 15:46:30 +0000 (17:46 +0200)]
[UTILMAN] Implement the Registry management code skeleton (#2456)
The following SaveAppSettings(), QueryAppSettings() and InitAppRegKey() are helper functions.
This is merely a base Registry skeleton for Utility Manager as more work on it has to come later.
He Yang [Fri, 3 Apr 2020 15:37:53 +0000 (10:37 -0500)]
[TASKKILL] Improve taskkill utility (#2459)
Make the argument process of command utility "taskkill" behave same as what Windows does.
Now options are no longer detected as parameters when placed after options that accept one.
For example, `taskkill /im /f` will no longer regard `/f` as a process name.
If `/?` and `/f` options appear more than once, an error will be reported, telling they are not allowed more than once.
(e.g. `taskkill /f /pid 1000 /f`)
If only one option `/f` is given without `/pid` or `/im`, an eerror will be reported, telling that one must specify `/pid` or `/im`.
(e.g. `taskkill /f`)
Additional changes:
- Combine SendCloseMessages() and TerminateProcesses() functions.
- Protect new written code with `#ifdef __REACTOS__`
Serge Gautherie [Fri, 3 Apr 2020 13:06:25 +0000 (15:06 +0200)]
[WIN32K:NTUSER] ntuser.h: Rename NtUserWaitForInputIdle() 3rd parameter (#2499)
Addendum to
568b6d05.
Serge Gautherie [Fri, 3 Apr 2020 12:01:22 +0000 (14:01 +0200)]
[WINETESTS] Remove forced _WIN32_WINNT defines (#2463)
Only comctl32 is affected.
Import
https://source.winehq.org/git/wine.git/commit/
be3cda6ec0856d143d4737ee9306844569b76e15
Serge Gautherie [Fri, 3 Apr 2020 11:59:34 +0000 (13:59 +0200)]
[PSDK] guiddef.h: Remove unwanted '&& !defined(CINTERFACE)' (#2492)
Cherry-pick
https://source.winehq.org/git/wine.git/commit/
4626db2bb2a61cdceb00e0e346628062ee51aade
Import
https://source.winehq.org/git/wine.git/commit/
54f58769fee73a55675d503e0281e8f381a8e8b1
https://source.winehq.org/git/wine.git/commit/
34f3e7793b40d0eac60c373f66f262be2e0d5cdb
Hermès Bélusca-Maïto [Thu, 2 Apr 2020 17:55:35 +0000 (19:55 +0200)]
[RPCRT4] Handle ERROR_BAD_NETPATH failure if an RPC pipe connection is done on an non-existing UNC path.
Addendum to
5274857d (see originally commit
13f41d74). CORE-6561
James Tabor [Fri, 3 Apr 2020 08:58:29 +0000 (03:58 -0500)]
[NTUser] Fix Strings and Format to Hooks
Allocate heap instead of data segment to be used for callbacks on user side.
Move and correct initial hook call out setup. Use it in more than one hook call.
This fixes issues with strings out of alignment and use of kernel pointers.
See CORE-13907 and CORE-16769. KsStudio still needs retested.
Small wow update.
Stanislav Motylkov [Thu, 2 Apr 2020 17:57:53 +0000 (20:57 +0300)]
[SYSDM] Cumulative update 2020-04-01 for SMBIOS parser (#2495)
Hermès Bélusca-Maïto [Thu, 2 Apr 2020 16:25:44 +0000 (18:25 +0200)]
[RPCRT4] Addendum to support for remote pipes names in ncacn_pipe_name() (
24cd7bbe).
CORE-6561 CORE-13442
- Call GetComputerNameA() only when a non-empty server name has been
provided, thus slightly improving speed for the most common case when
local calls (with an empty server name) are done.
- When a server name is passed, trim any leading UNC server prefix since
the latter will be restored when building the pipe name string.
Jérôme Gardou [Mon, 23 Mar 2020 09:41:00 +0000 (09:41 +0000)]
[README] Add "open in Gitpod" button
Jérôme Gardou [Tue, 17 Mar 2020 11:53:18 +0000 (11:53 +0000)]
[GITPOD]Add gitpod config
this commit adds support for Gitpod.io, a free automated
dev environment that makes contributing and generally working on GitHub
projects much easier. It allows anyone to start a ready-to-code dev
environment for any branch, issue and pull request with a single click.
Joachim Henze [Sat, 17 Feb 2018 19:28:15 +0000 (20:28 +0100)]
[RDBSS] Avoid CORE-13938
Pierre recommended this workaround for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"
This workaround was recurrently applied for all releases
0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13.
I never got any reply in the regression-ticket and recurrently
applying this over and over again is a waste of time.
So I decided to commit to master today, but will leave
the ticket unresolved, so when a proper fix will arrive in the future,
the existing ticket will remind us to undo this workaround.
Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
Vadim Galyant [Thu, 2 Apr 2020 10:15:33 +0000 (13:15 +0300)]
[NTOS:MM] Using the macro MiIsPteOnPdeBoundary(). (#2496)
The SYSTEM_PD_SIZE constant should not be used to determine the page boundary for page tables. It is better to use the portable MiIsPteOnPdeBoundary() macro for this.
Jared Smudde [Wed, 1 Apr 2020 09:42:24 +0000 (04:42 -0500)]
[STOBJECT] Change eject hardware dialog buttons from OK/Cancel to just OK. (#2493)
It's just an information dialog that needs one button, it's not actually doing different actions based on user input.
Mark Jansen [Mon, 30 Mar 2020 17:41:14 +0000 (19:41 +0200)]
[SPEC2DEF] Omit skipped exports from ordinal numbering.
CORE-16769
Eric Kohl [Tue, 31 Mar 2020 20:43:42 +0000 (22:43 +0200)]
[HOTPLUG] Display class icons for removable devices
Victor Perevertkin [Tue, 31 Mar 2020 09:29:56 +0000 (12:29 +0300)]
[CONFIGURE] Simplify version detection for modern Visual Studio
Jared Smudde [Mon, 30 Mar 2020 21:54:17 +0000 (16:54 -0500)]
[HOTPLUG] Add 32 pixel icon. (#2486)
Add a 32 pixel icon to the main icon for hotplug.cpl so the Safely Remove Hardware dialog looks normal.
Eric Kohl [Mon, 30 Mar 2020 21:11:44 +0000 (23:11 +0200)]
[HOTPLUG] Show removable devices and update the list on arrival and removal.
Joachim Henze [Mon, 30 Mar 2020 15:18:16 +0000 (17:18 +0200)]
[ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
Just to satisfy static code analysis. No change in behavior expected.
The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/
By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
Hervé Poussineau [Sun, 29 Mar 2020 22:03:02 +0000 (00:03 +0200)]
[NTOS:KD] Move dump of stack trace on crash to debugger
Release builds now show again the bugcheck screen, instead of freezing.
Hervé Poussineau [Sun, 29 Mar 2020 21:58:21 +0000 (23:58 +0200)]
[NTOS:KE] Remove dead code
Hervé Poussineau [Sat, 28 Mar 2020 23:30:53 +0000 (00:30 +0100)]
[NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
This was broken by commit
a890fc64d17e7c4a09a3cbe24e0dfc972d743dda
Hervé Poussineau [Sat, 28 Mar 2020 22:51:03 +0000 (23:51 +0100)]
[NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
This was broken by commit
f7ec84eea0790899ca34b79f2ec5a308204254ac