Pierre Schweitzer [Fri, 4 Aug 2017 19:46:32 +0000 (19:46 +0000)]
[NFS]
And make NP a bit more discrete when not really used...
svn path=/trunk/; revision=75484
Pierre Schweitzer [Fri, 4 Aug 2017 19:43:42 +0000 (19:43 +0000)]
[NFS]
Make hack introduced in r75415 more verbose.
CORE-8204
CORE-11327
svn path=/trunk/; revision=75483
Pierre Schweitzer [Fri, 4 Aug 2017 19:23:42 +0000 (19:23 +0000)]
[RDBSS]
Implement RxSetDispositionInfo(): this allows deleting files on a remote NFS share!
CORE-8204
CORE-11327
CORE-13636
svn path=/trunk/; revision=75482
Pierre Schweitzer [Fri, 4 Aug 2017 19:18:42 +0000 (19:18 +0000)]
[RDBSS]
On cleanup, only take the quick path if the file was already orphaned
CORE-11327
svn path=/trunk/; revision=75481
Pierre Schweitzer [Fri, 4 Aug 2017 19:05:11 +0000 (19:05 +0000)]
[RXCE]
In RxRemoveNameNetFcb(), check if name was already removed. MS doesn't do this, but as we use double linked-list macros
that perform extra sanity checks, this is required. This can be called twice for a single FCB.
CORE-11327
CORE-13632
CORE-13636
svn path=/trunk/; revision=75480
Pierre Schweitzer [Fri, 4 Aug 2017 12:18:52 +0000 (12:18 +0000)]
[KERNEL32]
Don't leak a handle when renaming a source file which is a MS mount point or a file without the reparse attribute while we can query its reparse information.
CORE-13635
svn path=/trunk/; revision=75478
Giannis Adamopoulos [Fri, 4 Aug 2017 09:12:33 +0000 (09:12 +0000)]
[hivecls.inf] -Add an option to immediately enable an msstyles file with right click.
svn path=/trunk/; revision=75477
Giannis Adamopoulos [Fri, 4 Aug 2017 08:53:06 +0000 (08:53 +0000)]
[DESK.CPL]
-Improve the hack that lets it process arguments by using the process command line instead of the one shell32 gives to the cpl.
-Implement a new action called ActivateMSTheme that activates an msstyle file without showing any gui. If no file is passed, the classic theme is activated thus making it possible to switch themes from command line (or any other application may need to switch themes by launching desk.cpl).
svn path=/trunk/; revision=75476
Mark Jansen [Thu, 3 Aug 2017 20:52:01 +0000 (20:52 +0000)]
[RAPPS] Remove Burnaware free. CORE-12194 #resolve
svn path=/trunk/; revision=75475
Pierre Schweitzer [Thu, 3 Aug 2017 20:47:41 +0000 (20:47 +0000)]
[RDBSS]
Don't attempt to dereference NULL-ptr if CCB isn't set.
Fixes crash in RxFsdCommonDispatch() under rare circumstances.
CORE-11327
svn path=/trunk/; revision=75474
Pierre Schweitzer [Thu, 3 Aug 2017 20:23:39 +0000 (20:23 +0000)]
[RXCE]
In spite of what its name may look like: SyncEvent is a notification event, not a sync event.
Use the correct event for synchronization. This avoids infinite wait in certain circumstances in RxScavengeFobxsForNetRoot()
CORE-11327
svn path=/trunk/; revision=75473
Hermès Bélusca-Maïto [Thu, 3 Aug 2017 14:56:07 +0000 (14:56 +0000)]
[FREELDR][INFLIB]: It is perfectly correct to retrieve the field of index == 0 of an INF line, by using the InfGetStringField() helper (corresponding to the SetupGetStringField() API).
svn path=/trunk/; revision=75472
Pierre Schweitzer [Tue, 1 Aug 2017 18:04:18 +0000 (18:04 +0000)]
[RXCE]
Make code that deals with DBG stuff only built in DBG builds
CORE-11327
CORE-13610
svn path=/trunk/; revision=75468
Thomas Faber [Tue, 1 Aug 2017 09:11:52 +0000 (09:11 +0000)]
[ACPICA]
- Update to version
20170728
CORE-13625 #resolve
svn path=/trunk/; revision=75467
Pierre Schweitzer [Tue, 1 Aug 2017 06:35:20 +0000 (06:35 +0000)]
[RDBSS]
For non dbg builds, don't implement macro defined functions RxCheckShareAccess(), RxRemoveShareAccess(), RxSetShareAccess(), RxUpdateShareAccess()
CORE-11327
CORE-13610
svn path=/trunk/; revision=75465
Giannis Adamopoulos [Mon, 31 Jul 2017 16:11:09 +0000 (16:11 +0000)]
[SYSSETUP.INF] -Move registering comctl32.dll and ole32.dll much earlier in the setup.
svn path=/trunk/; revision=75464
Giannis Adamopoulos [Mon, 31 Jul 2017 13:10:46 +0000 (13:10 +0000)]
[COMCTL32] -Fix some failed tests for TB_GETMETRICS. Add support for button spacing.
svn path=/trunk/; revision=75463
Giannis Adamopoulos [Mon, 31 Jul 2017 13:04:09 +0000 (13:04 +0000)]
[COMCTL32_APITESTS] -Add toolbar tests for TB_SETBUTTONSIZE, TB_SETPADDING, TB_GETBUTTONSIZE, TB_GETMETRICS.
svn path=/trunk/; revision=75462
Pierre Schweitzer [Mon, 31 Jul 2017 10:35:18 +0000 (10:35 +0000)]
[RXCE]
Only implement RxTrackerUpdateHistory() if RDBSS_TRACKER is defined
CORE-11327
CORE-13610
svn path=/trunk/; revision=75461
Pierre Schweitzer [Mon, 31 Jul 2017 09:33:01 +0000 (09:33 +0000)]
[RDBSS]
For non dbg builds, don't implement macro defined functions RxDumpCurrentAccess(), RxDumpWantedAccess()
CORE-11327
CORE-13610
svn path=/trunk/; revision=75460
Mark Jansen [Sun, 30 Jul 2017 14:04:44 +0000 (14:04 +0000)]
[REGEDIT] Fix the search dialog not opening when the root node is selected. Patch by Joachim Henze (reactosfanboy).
Small changes by me.
CORE-13071 #resolve #comment Thanks!
svn path=/trunk/; revision=75458
Mark Jansen [Sun, 30 Jul 2017 13:37:35 +0000 (13:37 +0000)]
[SDK][XML2SDB] Simplify include / exclude node specification.
svn path=/trunk/; revision=75457
Mark Jansen [Sun, 30 Jul 2017 12:47:57 +0000 (12:47 +0000)]
[SHIMENG] Partial rewrite to make the code easier to maintain.
- Protect ARRAY access with macro's / helper functions.
- Do not store objects in the ARRAY data, but store pointers to the objects.
- Rewrite import hooking to use an ARRAY instead of single linked lists.
svn path=/trunk/; revision=75455
Mark Jansen [Sun, 30 Jul 2017 12:46:53 +0000 (12:46 +0000)]
[ACPPAGE] Fix the shell extension asking to add an empty layer.
svn path=/trunk/; revision=75454
Pierre Schweitzer [Sun, 30 Jul 2017 12:24:26 +0000 (12:24 +0000)]
[RDBSS]
Implement RxPrepareToReparseSymbolicLink().
This allows symbolic links to work on a NFS share, we can now follow links that would have been exported by the server.
Safe to merge.
CORE-8204
CORE-11327
CORE-13615
svn path=/trunk/; revision=75451
Pierre Schweitzer [Sun, 30 Jul 2017 08:54:09 +0000 (08:54 +0000)]
[RDBSS]
When CcFlushCache fails, properly set status before leaving.
CORE-11327
svn path=/trunk/; revision=75445
Pierre Schweitzer [Sun, 30 Jul 2017 08:46:01 +0000 (08:46 +0000)]
[NFSD]
In case NFS session expires while reading/writing to a file, renew the session instead of just failing.
This avoids not being able to transfer any file with slow connection, and not being able to transfer big files with normal connection.
CORE-8204
CORE-13484
svn path=/trunk/; revision=75444
Pierre Schweitzer [Sun, 30 Jul 2017 08:31:59 +0000 (08:31 +0000)]
[KERNEL32]
In case of synchronous read, it's legit for the FSD to notify EOF by returning success & zero read length.
It fixes never ending reads when copying a file from NFS to local disk.
CORE-8204
CORE-11327
CORE-13484
svn path=/trunk/; revision=75443
Pierre Schweitzer [Sun, 30 Jul 2017 08:22:34 +0000 (08:22 +0000)]
[RXCE]
Don't forget to set RX_CONTEXT_FLAG_FROM_POOL flag when allocating a new RX_CONTEXT structure from pool.
This avoids leaking it afterwards and exhausting NP pool when using NFS.
CORE-8204
CORE-11327
CORE-13484
CORE-13604
svn path=/trunk/; revision=75442
Pierre Schweitzer [Sun, 30 Jul 2017 07:58:25 +0000 (07:58 +0000)]
[RXCE]
- Implement RxAcquireFcbForLazyWrite(), RxAcquireFcbForReadAhead(), RxReleaseFcbFromLazyWrite(), RxReleaseFcbFromReadAhead()
This makes RXCE better at dealing with Cc (and the other way round ;-)). This notably avoids infinite acquire loops from Cc when writing on a NFS share.
CORE-8204
CORE-11327
svn path=/trunk/; revision=75441
Giannis Adamopoulos [Sat, 29 Jul 2017 13:57:29 +0000 (13:57 +0000)]
[EXPLORER] -Fix calculatting the size of the tray icons for ral this time. When positioning the windows in the tray take into account the theme content margins.
svn path=/trunk/; revision=75440
Giannis Adamopoulos [Sat, 29 Jul 2017 09:43:48 +0000 (09:43 +0000)]
[UXTHEME] -Fix for the 3rd or 4th time the bug where the caption window overflows over the caption buttons which was last broken by me in 74960. CORE-13435
svn path=/trunk/; revision=75439
Giannis Adamopoulos [Sat, 29 Jul 2017 09:25:15 +0000 (09:25 +0000)]
[UXHTEME] - ThemeDrawCaptionText: Get the TMT_CONTENTALIGNMENT theme property and position the text accordingly. Patch by Stas'M. CORE-13600
svn path=/trunk/; revision=75438
Giannis Adamopoulos [Sat, 29 Jul 2017 08:52:04 +0000 (08:52 +0000)]
[COMCTL32] -Take into account the upper theme margin when drawing the icon so that it doesn't look misplaced. This makes the themed taskbar buttons look more or less good despite the fact that we completely ignore the left and right margins.
svn path=/trunk/; revision=75437
James Tabor [Sat, 29 Jul 2017 01:59:07 +0000 (01:59 +0000)]
[User32]
- Patch by MudHead : Combobox sends a message to the deselect the text when focus is lost.
CORE-10266 #resolve
svn path=/trunk/; revision=75436
Mark Jansen [Fri, 28 Jul 2017 19:00:27 +0000 (19:00 +0000)]
[APPHELP] Various cleanup tasks
- Move debug heap functionality to a separate file
- Clean includes
- Remove msvcrt dependency
- Clean up string usage
- Remove some higher level functions in favor of their ntdll counterparts (wip).
svn path=/trunk/; revision=75432
Giannis Adamopoulos [Fri, 28 Jul 2017 10:04:38 +0000 (10:04 +0000)]
[EXPLORER] -Implement changing the size of the icons in the notification area when the non client metrics change. Now they always have the size of the title bar icon. Center vertically or horizontally the notification area in the taskbar.
svn path=/trunk/; revision=75430
Mark Jansen [Thu, 27 Jul 2017 20:36:51 +0000 (20:36 +0000)]
[APPHELP] Use DbgPrint instead of OutputDebugString + fix SDBAPI_DEBUG_ALLOC
svn path=/trunk/; revision=75429
Hermès Bélusca-Maïto [Thu, 27 Jul 2017 19:08:55 +0000 (19:08 +0000)]
[ATL]: - Both the CAtlList class and its helper class CNode do not support copy construction. - Remove a redundant call to GetFreeNode().
CORE-13597
svn path=/trunk/; revision=75427
Thomas Faber [Thu, 27 Jul 2017 18:48:19 +0000 (18:48 +0000)]
[DLLS]
- Fix import order
- Remove unnecessary imports
svn path=/trunk/; revision=75426
Pierre Schweitzer [Thu, 27 Jul 2017 10:22:57 +0000 (10:22 +0000)]
[EXT2]
Import commits by Kaho Ng <ngkaho1234@gmail.com> from upstream:
-
b7657e5 Ext3Fsd: Introduce VCB_RO_COMPAT_READ_ONLY flag for struct VCB
-
e7c1142 Ext3Fsd: EXT4_FEATURE_INCOMPAT_64BIT is not supported
-
785943f Ext3Fsd: fix issue #6
Refuse mounting filesystems with incompatible flags. This avoids corrupting 64bits filesystems.
Patch by Lubomir Rintel
CORE-13589
svn path=/trunk/; revision=75422
Pierre Schweitzer [Thu, 27 Jul 2017 09:43:56 +0000 (09:43 +0000)]
[KERNEL32_VISTA]
Delay load NTDLL_vista, in order to save *380KB* at boot.
CORE-13361
svn path=/trunk/; revision=75421
Pierre Schweitzer [Thu, 27 Jul 2017 09:37:10 +0000 (09:37 +0000)]
[RDBSS]
- Misc fixes with DPRINTS
[RXCE]
- In RxFinalizeSrvOpen, always dereference the FCB, it's always referenced on SRV_OPEN creation
- Misc fixes with DPRINTS
With that revision and r75419, I'm now able to mount a NFS share, browse it, read a file from it, and unmount it.
We're OK regarding references counting!
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75420
Pierre Schweitzer [Thu, 27 Jul 2017 09:33:11 +0000 (09:33 +0000)]
[SHELL32]
Revert r75348.
Because of r75349, this revision was made useless, and even worse, it was leaking a handle to the directory where the FSD doesn't support notifications.
Also made some debug traces more useful
svn path=/trunk/; revision=75419
Benedikt Freisen [Thu, 27 Jul 2017 09:29:42 +0000 (09:29 +0000)]
[MSPAINT]
- Enable drag cancellation -- patch by Katayama Hirofumi MZ
CORE-13395 #resolve
svn path=/trunk/; revision=75418
Pierre Schweitzer [Wed, 26 Jul 2017 20:00:30 +0000 (20:00 +0000)]
[NFS]
Huge "hack" for ReactOS.
In case we're asked to unmount a NFS share, and there are still active FCBs, browse the prefix table for active NET_ROOT, and then, dump their associated FCBs (prefix + refcount).
It seems we only leak the root FCB.
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75415
Pierre Schweitzer [Wed, 26 Jul 2017 19:57:50 +0000 (19:57 +0000)]
[DDK]
Define RxIsFcbTableLockAcquired
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75414
Thomas Faber [Wed, 26 Jul 2017 14:49:35 +0000 (14:49 +0000)]
[ACPICA]
- Update to version
20170629
CORE-13538 #resolve
svn path=/trunk/; revision=75412
Pierre Schweitzer [Wed, 26 Jul 2017 09:55:30 +0000 (09:55 +0000)]
[COPYSUP]
Remove leftovers from some attempted ugly things.
Should fix MSVC build
svn path=/trunk/; revision=75410
Pierre Schweitzer [Wed, 26 Jul 2017 09:28:41 +0000 (09:28 +0000)]
[RDBSS]
- Implement RxFastIoWrite()
- Finish implementation of RxFastIoCheckIfPossible()
[COPYSUP]
- Implement FsRtlCopyWrite2()
This brings (in link with r75398 fast IO writes to RDBSS, and thus NFS!
CORE-8204
CORE-11327
svn path=/trunk/; revision=75409
James Tabor [Wed, 26 Jul 2017 02:52:00 +0000 (02:52 +0000)]
[NtUser]
- Broadcast the appropriate messages to notify a change in display parameters and color. This should fix rollback issues from setting display modes. See CORE-12571 and CORE-13212.
svn path=/trunk/; revision=75407
Giannis Adamopoulos [Tue, 25 Jul 2017 22:41:26 +0000 (22:41 +0000)]
[COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button will be implemented in a later commit as it caused me some problems.
svn path=/trunk/; revision=75406
David Quintana [Tue, 25 Jul 2017 18:12:33 +0000 (18:12 +0000)]
[FREELDR]
Fix compilation on ARM.
svn path=/trunk/; revision=75404
David Quintana [Tue, 25 Jul 2017 17:30:21 +0000 (17:30 +0000)]
[BOOTLIB]
[BOOTMGR]
Disabled x86-specific code when building ARM.
[LIBSUPP]
Use a hack to replace inline asm which is not supported by MSVC ARM.
[DBGHELP]
Fix ARM register access from context struct.
[MSVCRT]
Fix typo in spec file.
[NTOSKRNL]
[WIN32SS]
Add asm dependency to *sys modules.
[CPPRT]
Add one of the missing constructor aliases. There's more, but my brain is fried at this point.
[BTRFS]
Define-away an include for x86-specific intrinsics.
This is the first batch of fixes for building reactos using the MSVC ARM toolchain. A lot more work is needed to get a full build including rostests and rosapps.
svn path=/trunk/; revision=75403
Pierre Schweitzer [Tue, 25 Jul 2017 12:09:11 +0000 (12:09 +0000)]
[RDBSS]
- Implement RxCommonSetInformation(), RxpSetInfoMiniRdr(), RxSetBasicInfo()
- Stub RxSetAllocationInfo(), RxSetDispositionInfo(), RxSetEndOfFileInfo(), RxSetPipeInfo(), RxSetPositionInfo(), RxSetRenameInfo(), RxSetSimpleInfo()
CORE-8204
CORE-11327
svn path=/trunk/; revision=75402
Pierre Schweitzer [Tue, 25 Jul 2017 11:34:36 +0000 (11:34 +0000)]
[XDK]
Define FILE_ATTRIBUTE_INTEGRITY_STREAM
svn path=/trunk/; revision=75401
James Tabor [Mon, 24 Jul 2017 23:48:08 +0000 (23:48 +0000)]
[NtUser]
- Initialize rectangle to all zero's. See CORE-13582.
svn path=/trunk/; revision=75400
David Quintana [Mon, 24 Jul 2017 18:37:25 +0000 (18:37 +0000)]
[CABMAN]
Fix pointer math ('unsigned long' will truncate the pointer).
[MKISOFS/SCHILY TOOLS]
Fix the invalid assumption that a 'long' variable can hold pointers. Will be sent upstream.
With this the whole of reactos and rostests builds on x64. Rosapps still has issues.
svn path=/trunk/; revision=75399
Pierre Schweitzer [Mon, 24 Jul 2017 17:05:05 +0000 (17:05 +0000)]
[RDBSS]
- Implement __RxWriteReleaseResources(), RxCommonWrite(), RxCompleteMdl(), RxGetTopIrpIfRdbssIrp(), RxLowIoWriteShell(), RxLowIoWriteShellCompletion()
- Finish implementation of RxCommonCleanup() so that it handles setting EOF on a file
- Finish implementation of RxCommonCreate() so that it handles sharing violations and attempts to scavenge open files
[RXCE]
- Implement RxpScavengeFobxs(), RxpTrackDereference(), RxpTrackReference(), RxPurgeFobx(), RxPurgeRelatedFobxs(), RxReinitializeContext(), RxSetFileSizeWithLock(), RxScavengeFobxsForNetRoot()
- Fix a bug in RxPrefixTableLookupName() where it was badly handling nodes in scavenger
This commits brings several improvments to the NFS driver.
First of all, now, the driver handles creating, extending and writing to files!
It also handles purging dormant opened files when a file opening fails because of a sharing violation
Finally, it also brings something to look at our references issues in RDBSS to help finding out why our FCB are never (or nearly) dereferenced
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75398
David Quintana [Mon, 24 Jul 2017 15:09:22 +0000 (15:09 +0000)]
[APITESTS]
MSVCRT_CRT_APITEST: Remove getmainargs tests from X64 build.
DELAYIMP: Fix callback prototype.
CComHeapPtr: Fix implementation of IMallocSpy to match the actual interface.
[WINETESTS]
ntdll: Disable 'generated' tests when not i386 platform, since they were generated for x86 and not x64 or ARM.
Fixes x64 compilation for tests.
svn path=/trunk/; revision=75397
David Quintana [Mon, 24 Jul 2017 15:08:16 +0000 (15:08 +0000)]
[BOOTLIB]
Stub out some arch-specific functions (fixes x64 build).
[USBPORT]
Actually fix x64 build. The old code was not working at all, but the bootlib errors cancelled the build earlier than I thought.
The X64 compilation now succeeds, but cabman crashes trying to generate the bootcd.
svn path=/trunk/; revision=75396
David Quintana [Mon, 24 Jul 2017 10:40:55 +0000 (10:40 +0000)]
[EXPLORER]
[RSHELL]
[NTOBJSHEX]
[BROWSEUI]
[SHELL32]
Get rid of the unused "placement new" operators.
svn path=/trunk/; revision=75394
David Quintana [Mon, 24 Jul 2017 10:37:53 +0000 (10:37 +0000)]
[USBPORT]
Oops, brainfart (Fixes 32bit build).
svn path=/trunk/; revision=75393
David Quintana [Mon, 24 Jul 2017 10:34:06 +0000 (10:34 +0000)]
[MSPAINT]
Correct callback return type (Fixes X64 build).
[USETUP]
Correct definition of the struct (fixes X64 build).
[USBPORT]
Improve struct size checks so they are X64-compatible (fixes X64 build).
The build as a whole still fails due to bootlib, but implementing those is beyond my expertise.
svn path=/trunk/; revision=75392
Mark Jansen [Sat, 22 Jul 2017 20:23:33 +0000 (20:23 +0000)]
[SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)
CORE-13426 #resolve #comment Thanks!
svn path=/trunk/; revision=75391
Mark Jansen [Sat, 22 Jul 2017 18:27:32 +0000 (18:27 +0000)]
[WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.
CORE-13567 #resolve #comment Thanks!
svn path=/trunk/; revision=75390
Giannis Adamopoulos [Sat, 22 Jul 2017 17:13:06 +0000 (17:13 +0000)]
[EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size and position of the taskbar but I add it back since it updates the cached rects for all four positions.
svn path=/trunk/; revision=75389
Mark Jansen [Sat, 22 Jul 2017 16:55:08 +0000 (16:55 +0000)]
[SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.
CORE-13428 #resolve #comment Thanks!
svn path=/trunk/; revision=75388
Hermès Bélusca-Maïto [Sat, 22 Jul 2017 15:54:40 +0000 (15:54 +0000)]
[UNATTEND]: Move a comment sign ';' to a better place.
svn path=/trunk/; revision=75387
Giannis Adamopoulos [Sat, 22 Jul 2017 09:13:33 +0000 (09:13 +0000)]
[EXPLORER] -Implement the minimum taskbar size for the vertical position.
svn path=/trunk/; revision=75386
Giannis Adamopoulos [Fri, 21 Jul 2017 14:32:15 +0000 (14:32 +0000)]
[BROWSEUI]
-CBandSite: Remove CCS_NORESIZE style. This is a hack probably needed because our rebar control is buggy.
[EXPLORER]
-CTaskBand::GetBandInfo: Use the toolbar button size as the minimum and integral size for the band.
-CTaskSwitchWnd: Use the system small icon size for the size of the icon. Recreate the image list if this size changes. This together with the size of the font are the only factors for the size of the toolbar and consequently for the size of the band and if it is the only band, the size of the taskbar. Don't use TB_SETBUTTONSIZE. Now the size of the image list and the font dictate the size.
-CTrayWindow: In the classic theme make the start button have the same height with the tasks toolbar button height. Improve the calculation of the size of the taskbar in FitToRebar.
These changes should make the taskbar and the toolbar have a proper size. On top of that the taskbar is finally resizable (however our rebar is too buggy and still fills only the first line in the taskbar). While testing this I noticed that moving the taskbar in the sides of the screen is buggy now. I'm not sure if this was uncovered by these changes, if this was broken before or this was caused by these changes (looks unlikely to me) but will be fixed in subsequent commits).
svn path=/trunk/; revision=75385
Sylvain Petreolle [Thu, 20 Jul 2017 21:32:16 +0000 (21:32 +0000)]
Revert r70669, it was a change in an unused 3rd party file.
CORE-10629
svn path=/trunk/; revision=75383
James Tabor [Thu, 20 Jul 2017 20:26:14 +0000 (20:26 +0000)]
[NtUser]
- Patch by Huw Davies : Explicitly set last error to ERROR_SUCCESS.
- Remove hack and added a note.
svn path=/trunk/; revision=75382
James Tabor [Thu, 20 Jul 2017 19:57:25 +0000 (19:57 +0000)]
[NtUser]
- Patch by Fabian Maurer : Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests.
svn path=/trunk/; revision=75381
James Tabor [Thu, 20 Jul 2017 19:46:17 +0000 (19:46 +0000)]
[NtUser]
- Patch by Alex Henrie : Tell MENU_SuspendPopup which message to remove.
svn path=/trunk/; revision=75380
James Tabor [Thu, 20 Jul 2017 19:40:17 +0000 (19:40 +0000)]
[NtUser]
- Remove unused code and reintegrate wine code.
svn path=/trunk/; revision=75379
Sylvain Petreolle [Wed, 19 Jul 2017 20:33:58 +0000 (20:33 +0000)]
Patch by Mike Swanson :
This adds support for Esperanto as a language and a keyboard layout based on the one from X.Org.
CORE-11021
svn path=/trunk/; revision=75378
Daniel Reimer [Wed, 19 Jul 2017 19:23:47 +0000 (19:23 +0000)]
[CAROOT]
Updates root CAs to recent ones.
svn path=/trunk/; revision=75377
Hervé Poussineau [Wed, 19 Jul 2017 09:19:11 +0000 (09:19 +0000)]
[SETUPAPI] Do not crash when encountering a device with HardwareIDs
svn path=/trunk/; revision=75374
Sylvain Petreolle [Tue, 18 Jul 2017 22:48:18 +0000 (22:48 +0000)]
[BDASUP]
Add digital TV tuning device driver to build.
svn path=/trunk/; revision=75372
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 21:30:20 +0000 (21:30 +0000)]
[REACTOS]: Russian translation update part 2/2 by amber: time-zones.
svn path=/trunk/; revision=75370
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 21:26:25 +0000 (21:26 +0000)]
[REACTOS]: Russian translation update part 1/2 by amber.
CORE-13248
svn path=/trunk/; revision=75369
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 20:55:34 +0000 (20:55 +0000)]
[CRT]: Add a missing _munlock call, caught by Serge Gautherie.
CORE-11568
svn path=/trunk/; revision=75368
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 17:17:22 +0000 (17:17 +0000)]
[CMD]: Update the description of the START command, with the commutators that are known to work.
Translators, please update the translations based on en-US!
svn path=/trunk/; revision=75366
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 16:11:18 +0000 (16:11 +0000)]
[MSVCRT][CRT]: Improvements/fixes over popen(), from Wine code and ported by Andreas Maier: the popen_handles array, which is used in _pclose, was never filled. _popen correctly fills it now.
Should fix returned codes by popen() and pclose(), which are functions that are called by windres, and this latter expects them to succeed. This was not the case before, in ROS, and therefore
trying to e.g. compile ROS within ROS failed from time to time with windres throwing the error that "preprocessing failed".
CORE-11568 #resolve
svn path=/trunk/; revision=75365
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 15:27:40 +0000 (15:27 +0000)]
[MSVCRT_APITEST]: Commit a simple test for popen(), by Andreas Maier.
CORE-11568
svn path=/trunk/; revision=75364
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 12:47:18 +0000 (12:47 +0000)]
[RXCE]: Fix bug, thanks MSVC! (warning C4553)
svn path=/trunk/; revision=75363
Eric Kohl [Sun, 16 Jul 2017 21:48:30 +0000 (21:48 +0000)]
[NETAPI32]
DsAddressToSiteNamesExW: Remove dead code.
This bug was found by Christian Bosch. Thanks a lot!
svn path=/trunk/; revision=75362
Giannis Adamopoulos [Sun, 16 Jul 2017 15:13:02 +0000 (15:13 +0000)]
[SHELL32]
-CRegFolder: Implement CRegFolder::EnumObjects. Change its constructor to receive an extra parameter for the name of the key that should be enumerated.
-CEnumIDListBase: Add a new method called AppendItemsFromEnumerator to facilitate merging the contents from one IEnumIDList to another.
-Use the above in the enumerators of CControlPanelFolder, CDesktopFolder and CDrivesFolder to make them significantly simpler.
svn path=/trunk/; revision=75360
Mark Jansen [Sun, 16 Jul 2017 13:56:08 +0000 (13:56 +0000)]
[SHIMENG] Pass shim commandline to shims. CORE-11329
svn path=/trunk/; revision=75359
Mark Jansen [Sun, 16 Jul 2017 13:50:23 +0000 (13:50 +0000)]
[SHIMLIB] Add debug print functionality for shims. CORE-11329
svn path=/trunk/; revision=75358
Mark Jansen [Sun, 16 Jul 2017 13:47:16 +0000 (13:47 +0000)]
[ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
svn path=/trunk/; revision=75357
Mark Jansen [Sun, 16 Jul 2017 13:44:18 +0000 (13:44 +0000)]
[SHELL32] Do not dereference a nullpointer for logging. CORE-13552
svn path=/trunk/; revision=75356
Sylvain Petreolle [Sun, 16 Jul 2017 13:37:29 +0000 (13:37 +0000)]
Patch by Serge Gautherie:
[BOOTDATA]
hivesys.inf: Put 'Mup' service back in 'File System' group. (Fix r72450)
Fixes installation of Vmware Tools which was always hanging.
CORE-12107 #resolve
svn path=/trunk/; revision=75355
Pierre Schweitzer [Sat, 15 Jul 2017 11:41:24 +0000 (11:41 +0000)]
[RDBSS]
Complementary to r75353: implement RxCancelNotifyChangeDirectoryRequestsForFobx()
CORE-11327
svn path=/trunk/; revision=75354
Pierre Schweitzer [Sat, 15 Jul 2017 10:05:32 +0000 (10:05 +0000)]
[RDBSS]
Implement RxNotifyChangeDirectory(), RxLowIoNotifyChangeDirectoryCompletion(), RxCancelNotifyChangeDirectoryRequestsForVNetRoot()
This means the first parts of the directory watch are here. Though, NFS driver doesn't support these, but at least, it reduces the UNIMPLEMENTED spam!
CORE-11327
svn path=/trunk/; revision=75353
Giannis Adamopoulos [Sat, 15 Jul 2017 09:38:45 +0000 (09:38 +0000)]
[SHELL32] -Move CFSExtractIcon_CreateInstance to CFSFolder.cpp
svn path=/trunk/; revision=75352
Mark Jansen [Sat, 15 Jul 2017 09:24:30 +0000 (09:24 +0000)]
[USBPORT] Fix incorrect transfer direction for URBs. Patch by Vadim Galyant. CORE-13546
svn path=/trunk/; revision=75351
Giannis Adamopoulos [Sat, 15 Jul 2017 09:18:06 +0000 (09:18 +0000)]
[SHELL32]
- CDesktopFolder: Create the enumerators of the internal fs folders and add their items in its own list instead of calling CreateFolderEnumList which enumerates ... files.
- Remove CEnumIDListBase::CreateFolderEnumList and move its code to CFileSysEnum::Initialize.
svn path=/trunk/; revision=75350
Pierre Schweitzer [Sat, 15 Jul 2017 07:48:47 +0000 (07:48 +0000)]
[SHELL32]
In case a FSD doesn't support directory changes notifications, don't try to requeue a notification each time it returns 0 data.
Just quit instead.
CORE-13549
svn path=/trunk/; revision=75349