21 months ago[DDK][PSDK] Added the rest of the defines for netkvm
Benjamin Aerni [Mon, 6 May 2019 05:34:58 +0000 (22:34 -0700)]
[DDK][PSDK] Added the rest of the defines for netkvm

21 months ago[DDK][PSDK] Add some missing NDIS definitions/types. Caught by Benjamin Aerni.
Hermès Bélusca-Maïto [Sun, 5 May 2019 21:18:45 +0000 (23:18 +0200)]
[DDK][PSDK] Add some missing NDIS definitions/types. Caught by Benjamin Aerni.

21 months ago[POWERCFG] Fix power scheme deletion
Eric Kohl [Sun, 5 May 2019 20:48:53 +0000 (22:48 +0200)]
[POWERCFG] Fix power scheme deletion

CORE-12566, CORE-12567

21 months ago[POWERCFG] Improve the error handling in AddPowerScheme() and keep track of the curre...
Eric Kohl [Sun, 5 May 2019 20:01:54 +0000 (22:01 +0200)]
[POWERCFG] Improve the error handling in AddPowerScheme() and keep track of the current power scheme.

21 months ago[NOTEPAD] Duplicate notepad.exe in SystemRoot. CORE-16003 (#1555)
Oleg Dubinskiy [Sun, 5 May 2019 17:48:37 +0000 (20:48 +0300)]
[NOTEPAD] Duplicate notepad.exe in SystemRoot. CORE-16003 (#1555)

This is also done on Windows for backwards compatibility with Windows 3.x/9x.
But, it's also used (i.e. "required") by some installers, like Doom 3 Demo installer and Battlefield 1942 Single Player Demo installer, for successful opening of their Readme file at the end of their installation!

21 months ago[KERNEL32] Misc. fixes to DefineDosDeviceW
Pierre Schweitzer [Sun, 5 May 2019 16:31:43 +0000 (18:31 +0200)]
[KERNEL32] Misc. fixes to DefineDosDeviceW

- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.

21 months ago[NTOS:CM] Check for correct status from ZwQueryObject. CORE-15882
Thomas Faber [Sun, 5 May 2019 15:56:10 +0000 (17:56 +0200)]
[NTOS:CM] Check for correct status from ZwQueryObject. CORE-15882

Fixes regression in ntdll_apitest:NtLoadUnloadKey from d570482bc72.

21 months ago[POWERCFG] Really fix the power schemes exceptions!
Eric Kohl [Sun, 5 May 2019 15:00:57 +0000 (17:00 +0200)]
[POWERCFG] Really fix the power schemes exceptions!

21 months ago[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces
Pierre Schweitzer [Sun, 5 May 2019 12:18:09 +0000 (14:18 +0200)]
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces

It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.

21 months ago[NTOS:PNP] Reduce the size of the pool buffer in IopGetParentIdPrefix. CORE-15882 1507/head
Thomas Faber [Thu, 18 Apr 2019 05:41:50 +0000 (07:41 +0200)]
[NTOS:PNP] Reduce the size of the pool buffer in IopGetParentIdPrefix. CORE-15882

21 months ago[NTOS:CM] Reduce the size of some unnecessarily large stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:31:34 +0000 (10:31 +0200)]
[NTOS:CM] Reduce the size of some unnecessarily large stack buffers. CORE-15882

21 months ago[NTOS:CM] Simplify CmpGetRegistryPath to avoid unnecessary stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:25:52 +0000 (10:25 +0200)]
[NTOS:CM] Simplify CmpGetRegistryPath to avoid unnecessary stack buffers. CORE-15882

21 months ago[NTOS:CM] Avoid a fixed-length stack buffer in CmpCmdHiveOpen. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 07:37:37 +0000 (09:37 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpCmdHiveOpen. CORE-15882

21 months ago[NTOS:CM] Avoid a fixed-length stack buffer in CmpAddToHiveFileList. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 10:10:23 +0000 (12:10 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpAddToHiveFileList. CORE-15882

21 months ago[NTOS] Use correct buffer size when calling MiResolveImageReferences. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 06:25:23 +0000 (08:25 +0200)]
[NTOS] Use correct buffer size when calling MiResolveImageReferences. CORE-15882

21 months ago[NTOS:PNP] Avoid a fixed-length stack buffer in IopActionConfigureChildServices....
Thomas Faber [Sun, 24 Mar 2019 14:04:37 +0000 (15:04 +0100)]
[NTOS:PNP] Avoid a fixed-length stack buffer in IopActionConfigureChildServices. CORE-15882

21 months ago[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 13:47:59 +0000 (14:47 +0100)]
[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882

21 months ago[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 09:44:46 +0000 (10:44 +0100)]
[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882

21 months ago[KERNEL32] Reduce QueryDosDeviceA memory footprint
Pierre Schweitzer [Sun, 5 May 2019 08:12:59 +0000 (10:12 +0200)]
[KERNEL32] Reduce QueryDosDeviceA memory footprint

by using TEB static unicode string (which is already
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.

21 months ago[KERNEL32] Reduce DefineDosDeviceA memory footprint
Pierre Schweitzer [Sun, 5 May 2019 07:25:34 +0000 (09:25 +0200)]
[KERNEL32] Reduce DefineDosDeviceA memory footprint

by using TEB static unicode string (which is already

21 months ago[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
Hermès Bélusca-Maïto [Sat, 4 May 2019 23:10:39 +0000 (01:10 +0200)]
[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
CORE-13182 CORE-13196

- Use the correct character height & width.
- Additions: use StringCch*() when initializing the dialog title.

[CONSRV:CONCFG] Minor fixes.

- When retrieving font characteristics in ConCfgReadUserSettings(),
  check for NULL/zero values that indicate that we should use default
  ones instead.
- Rename 'dwNumSubKeys' into 'dwNumValues'.

21 months ago[MC] Add message tranlations. Supplement to 3acec58f.
Eric Kohl [Sat, 4 May 2019 21:13:28 +0000 (23:13 +0200)]
[MC] Add message tranlations. Supplement to 3acec58f.

21 months ago[NET] Replace remaining strings of the NET ACCOUNTS command by messages
Eric Kohl [Sat, 4 May 2019 19:08:27 +0000 (21:08 +0200)]
[NET] Replace remaining strings of the NET ACCOUNTS command by messages

21 months ago[ROSAUTOTEST] Don't disallow buffering for journal file
Pierre Schweitzer [Fri, 3 May 2019 10:13:51 +0000 (12:13 +0200)]
[ROSAUTOTEST] Don't disallow buffering for journal file

This fixes back journal in ReactOS "at low costs". Indeed,
because write are improperly aligned right now, journaling
just fails.
With that patch, Cc will take care of aligning writes and
journal will be written again. Because flush operations
happen at each and every write to the journal, we expect
changes to land on disk quickly (not as quickly as if
they were directly written). But that's a good trade off
between over engineering and fixing a broken feature.


21 months ago[AUTOCHK] Don't check any volume on boot
Pierre Schweitzer [Sat, 4 May 2019 08:57:33 +0000 (10:57 +0200)]
[AUTOCHK] Don't check any volume on boot

This will avoid triggering a FAT repair on
unclean FAT volumes.

If dosfstools.fsck works fine in Linux, its
usage on ReactOS triggers worse corruption
than unclean shutdown.

Given I've no time for debugging this, I
kill it off.


21 months ago[WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP
Katayama Hirofumi MZ [Sat, 4 May 2019 01:07:24 +0000 (10:07 +0900)]
[WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP

21 months ago[WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0)
Katayama Hirofumi MZ [Sat, 4 May 2019 00:56:09 +0000 (09:56 +0900)]
[WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0)

21 months ago[APPSHIM_APITEST] Fix 2k3 test failures 1550/head
Mark Jansen [Wed, 1 May 2019 20:48:08 +0000 (22:48 +0200)]
[APPSHIM_APITEST] Fix 2k3 test failures

21 months ago[HIDParser] Fix MSVC build
jimtabor [Thu, 2 May 2019 19:33:07 +0000 (14:33 -0500)]
[HIDParser] Fix MSVC build

Attempt to fix build for MSVC.
This effected local build GCC system with newer Ninja version. Not sure
if this has an effect.

21 months ago[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which...
Eric Kohl [Thu, 2 May 2019 18:21:32 +0000 (20:21 +0200)]
[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState.

21 months ago[HID] Use hidparser static library for HidP_* functions
Hervé Poussineau [Sat, 27 Apr 2019 12:17:10 +0000 (14:17 +0200)]
[HID] Use hidparser static library for HidP_* functions

hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.

21 months ago[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library
Hervé Poussineau [Sat, 27 Apr 2019 09:19:46 +0000 (11:19 +0200)]
[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library

Interface between both is not anymore the HidParser_* functions, but
the HidP_* functions and the AllocFunction/FreeFunction/DebugFunctions/

21 months ago[SERIAL] Immediately complete read IRP if all requested bytes have been found in...
Hervé Poussineau [Thu, 2 May 2019 11:26:46 +0000 (13:26 +0200)]
[SERIAL] Immediately complete read IRP if all requested bytes have been found in circular buffer

Previously, we had to wait to receive another byte to finish the first IRP.

21 months ago[I8042PRT] Do not assert on unknown IOCTL
Hervé Poussineau [Sat, 27 Apr 2019 21:07:39 +0000 (23:07 +0200)]
[I8042PRT] Do not assert on unknown IOCTL

21 months ago[NtGDI] Set Xform flags if a changed
jimtabor [Thu, 2 May 2019 16:56:55 +0000 (11:56 -0500)]
[NtGDI] Set Xform flags if a changed

Missed more flags changes.

21 months ago[NtGDI] Set Xform flags if a changed
jimtabor [Thu, 2 May 2019 15:16:50 +0000 (10:16 -0500)]
[NtGDI] Set Xform flags if a changed

Missed flags changes.

21 months ago[NtGDI] Adding Support for Viewport TextOut
jimtabor [Thu, 2 May 2019 15:11:11 +0000 (10:11 -0500)]
[NtGDI] Adding Support for Viewport TextOut

Add Viewport changes to Text Out Batch.

21 months ago[COMDLG32] Fix treatment of wrong filename extension (#1545)
Katayama Hirofumi MZ [Thu, 2 May 2019 13:48:01 +0000 (22:48 +0900)]
[COMDLG32] Fix treatment of wrong filename extension (#1545)

Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270

21 months ago[NTDLL_APITEST] Query sector size for NtWriteFile tests
Pierre Schweitzer [Thu, 2 May 2019 11:59:47 +0000 (13:59 +0200)]
[NTDLL_APITEST] Query sector size for NtWriteFile tests

21 months ago[NTDLL_APITEST] Add tests for alignment for NtWriteFile
Pierre Schweitzer [Thu, 2 May 2019 10:07:46 +0000 (12:07 +0200)]
[NTDLL_APITEST] Add tests for alignment for NtWriteFile
This mimics the usage of WriteFile which is done in rosautotest.


21 months ago[GDI32] Add batch flag for Text Out
James Tabor [Thu, 2 May 2019 04:24:53 +0000 (23:24 -0500)]
[GDI32] Add batch flag for Text Out

Set batch flag for Text Out with font and attributes change sets.

21 months ago[GDI32] Fix MS build
James Tabor [Thu, 2 May 2019 01:53:06 +0000 (20:53 -0500)]
[GDI32] Fix MS build

Fix old uncovered code.

21 months ago[GDI32] Update signal flags for batch.
James Tabor [Thu, 2 May 2019 01:33:09 +0000 (20:33 -0500)]
[GDI32] Update signal flags for batch.

Add removed flags for batch signaling. This will allow syncing of
changed Xfroms after batched drawing. Disable calls to kernel mode since
the code is closely identical. Kernel calls are for init time when
PDCATTR is normally zero. ReactOS seems to work better keeping this from
While making code changes add Xform state flags from:

Test BOT results:,67254,67255

21 months ago[OSK] Hotfix for PR #1536 (#1549) 1549/head
Bișoc George [Wed, 1 May 2019 08:33:13 +0000 (10:33 +0200)]
[OSK] Hotfix for PR #1536 (#1549)


21 months ago[ACGENRAL] Add a test shim 1534/head
Mark Jansen [Tue, 30 Apr 2019 20:51:28 +0000 (22:51 +0200)]
[ACGENRAL] Add a test shim

21 months ago[ROSAPPS] Add a test application for shims
Mark Jansen [Tue, 30 Apr 2019 20:50:21 +0000 (22:50 +0200)]
[ROSAPPS] Add a test application for shims

21 months ago[APPHELP] Add ordinal import support
Mark Jansen [Sun, 11 Feb 2018 21:40:51 +0000 (22:40 +0100)]
[APPHELP] Add ordinal import support

21 months ago[POWERCFG] Fix indentation. No code changes!
Eric Kohl [Wed, 1 May 2019 11:16:00 +0000 (13:16 +0200)]
[POWERCFG] Fix indentation. No code changes!

21 months ago[GDI32_APITEST] Improve SetMapMode testcase (#1547)
Katayama Hirofumi MZ [Wed, 1 May 2019 09:28:18 +0000 (18:28 +0900)]
[GDI32_APITEST] Improve SetMapMode testcase (#1547)

Check the relation of mode change and viewport change. CORE-14994

21 months ago[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)
Katayama Hirofumi MZ [Wed, 1 May 2019 07:51:00 +0000 (16:51 +0900)]
[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)

Add WORLD_XFORM_CHANGED flag to some positioning functions.
Fix IntExtTextOutW function for TA_UPDATECP alignment, so that it can correctly update the current position. CORE-14994

21 months ago[KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come!
Katayama Hirofumi MZ [Wed, 1 May 2019 07:15:23 +0000 (16:15 +0900)]
[KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come!

21 months ago[NTOS/MM] Ensure ImageBase is not used uninitialized 1537/head
Mark Jansen [Sat, 27 Apr 2019 21:58:01 +0000 (23:58 +0200)]
[NTOS/MM] Ensure ImageBase is not used uninitialized

21 months ago[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented...
Hermès Bélusca-Maïto [Mon, 29 Apr 2019 20:51:35 +0000 (22:51 +0200)]
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989

21 months ago[OSK] Make the buttons themed
Bișoc George [Mon, 22 Apr 2019 13:01:18 +0000 (15:01 +0200)]
[OSK] Make the buttons themed

Our On-Screen Keyboard has a manifest and the buttons (the ones with BS_ICON styles) aren't rendered with the specific theme as it should be but instead it takes the classic theme.

The code relies on NM_CUSTOMDRAW notification, which is more intuitive and efficient than doing owner-drawn operations as NM_CUSTOMDRAW allows the controls to use styles whereas you cannot do it on owner-drawn controls.


22 months ago[WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt
Katayama Hirofumi MZ [Mon, 29 Apr 2019 10:42:04 +0000 (19:42 +0900)]
[WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt

22 months ago[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 05:45:44 +0000 (14:45 +0900)]
[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)

Fix NtGdiTransformPoints, gdi32!DPtoLP, gdi32!LPtoDP and gdi32!SetMapMode functions. Fix CORE-15983. CORE-15983

22 months ago[APITESTS] set_module_type(win32u module)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 03:49:54 +0000 (12:49 +0900)]
[APITESTS] set_module_type(win32u module)

22 months ago[APITESTS] Add NtGdiTransformPoints testcase (#1542)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 00:13:22 +0000 (09:13 +0900)]
[APITESTS] Add NtGdiTransformPoints testcase (#1542)

Add a testcase for NtGdiTransformPoints function. set_module_type(win32u... win32dll) CORE-15983

22 months ago[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-functi...
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 20:47:14 +0000 (22:47 +0200)]
[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-function as well, in order to reflect the actual name of the corresponding test.

22 months agoAdd a shared "port" directory for POSIX functions needed by multiple host tools ...
Colin Finck [Sat, 27 Apr 2019 14:19:26 +0000 (16:19 +0200)]
Add a shared "port" directory for POSIX functions needed by multiple host tools (getopt/mkstemps) and import the one and only getopt from glibc.

This finally fixes our duplicated getopt functions from different sources and gives us an up to date and the most compatible implementation.
isohybrid actually relies on a glibc-specific getopt behavior that we previously hacked into the reactos_support_code.c implementation derived from BSD/mingw-w64.
widl also needs getopt and previously used an even older BSD-derived code.

22 months ago[ISOHYBRID] Fix the remaining warnings properly.
Colin Finck [Sat, 27 Apr 2019 09:35:04 +0000 (11:35 +0200)]
[ISOHYBRID] Fix the remaining warnings properly.

I will send these changes upstream (minus the REACTOS_ISOHYBRID_EFI_MAC_SUPPORT ifdefs).

22 months ago[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)
Timo Kreuzer [Mon, 15 Apr 2019 11:29:33 +0000 (13:29 +0200)]
[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)

22 months ago[CONSRV] Cache the console window system menu handle; simplify its initialization...
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 19:47:55 +0000 (21:47 +0200)]
[CONSRV] Cache the console window system menu handle; simplify its initialization code.

22 months ago[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
Serge Gautherie [Sun, 28 Apr 2019 19:19:42 +0000 (21:19 +0200)]

No functional change otherwise.

22 months ago[ACCESS] Reposition the "ToggleKeys" group box control (#1541)
Bișoc George [Sun, 28 Apr 2019 18:21:38 +0000 (20:21 +0200)]
[ACCESS] Reposition the "ToggleKeys" group box control (#1541)


22 months ago[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. ... 1065/head
Andrew Boyarshin [Mon, 26 Nov 2018 12:49:15 +0000 (19:49 +0700)]
[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. (#1065)

- The 2nd parameter is already passed in user-mode by GetThreadDesktop().
  It is then used by NtUserGetThreadDesktop() as a fallback for console

- Lookup and validate the thread by using the IntTID2PTI() helper.
- Don't reference the desktop with too many access rights.
- Get rid of the old-school DECLARE_RETURN() & co. macros.

Co-authored-by: Hermès Bélusca-Maïto <>
22 months ago[WIN32SS][NTGDI] Fix wrong IN/OUT (#1539)
Katayama Hirofumi MZ [Sun, 28 Apr 2019 15:24:57 +0000 (00:24 +0900)]
[WIN32SS][NTGDI] Fix wrong IN/OUT (#1539)

22 months ago[POWERCFG] Fix minor power scheme issues
Eric Kohl [Sun, 28 Apr 2019 11:18:12 +0000 (13:18 +0200)]
[POWERCFG] Fix minor power scheme issues

- Really fix the exception that occurs on closing the property sheet.
- Use the correct scheme ID when the current power scheme is set.

22 months ago[ROSAUTOTEST] "Enforce" ending '\n' on C___Exception messages (#1533)
Serge Gautherie [Sun, 28 Apr 2019 10:20:37 +0000 (12:20 +0200)]
[ROSAUTOTEST] "Enforce" ending '\n' on C___Exception messages (#1533)

22 months ago[FORMATTING] appveyor.yml: Remove an extra space (#1538)
Serge Gautherie [Sun, 28 Apr 2019 01:23:27 +0000 (03:23 +0200)]
[FORMATTING] appveyor.yml: Remove an extra space (#1538)

Addendum to 48f98e88.

22 months ago[WINSRV] Implement SrvGetThreadConsoleDesktop(). CORE-13470
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 00:40:20 +0000 (02:40 +0200)]
[WINSRV] Implement SrvGetThreadConsoleDesktop(). CORE-13470

It retrieves the handle to the desktop assigned to the specified
thread belonging to a console application, which is going to be
where the input thread of this console is.

22 months ago[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension
Katayama Hirofumi MZ [Sat, 27 Apr 2019 23:43:24 +0000 (08:43 +0900)]
[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension

22 months ago[NFS] Fix a typo in the precompiled header.
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 23:40:09 +0000 (01:40 +0200)]
[NFS] Fix a typo in the precompiled header.

22 months ago[POWERCFG] Fix an exception that occurs when the control panel is closed.
Eric Kohl [Sat, 27 Apr 2019 17:00:33 +0000 (19:00 +0200)]
[POWERCFG] Fix an exception that occurs when the control panel is closed.

22 months ago[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee().... 803/head
Hermès Bélusca-Maïto [Thu, 23 Aug 2018 19:30:56 +0000 (21:30 +0200)]
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803)

This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.

22 months ago[MODERN.MSSTYLES] Remove trailing whitespace. 1527/head
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 15:01:47 +0000 (17:01 +0200)]
[MODERN.MSSTYLES] Remove trailing whitespace.

22 months ago[THEMES] Reorganize files for future compatability.
Jake Collins [Tue, 23 Apr 2019 20:46:42 +0000 (21:46 +0100)]
[THEMES] Reorganize files for future compatability.

Moved current theme assets into their own dedicated
files in preparation for .theme support.


22 months ago[COMDLG32] Save open/save location by extension (#1514)
Katayama Hirofumi MZ [Sat, 27 Apr 2019 14:02:34 +0000 (23:02 +0900)]
[COMDLG32] Save open/save location by extension (#1514)

Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114

22 months ago[SDK][INCLUDE] Use FALSE for BOOL in msgdump.h
Katayama Hirofumi MZ [Sat, 27 Apr 2019 13:06:37 +0000 (22:06 +0900)]
[SDK][INCLUDE] Use FALSE for BOOL in msgdump.h

22 months ago[CMAKE] Fix LINK_DEPENDS usage
Timo Kreuzer [Sat, 27 Apr 2019 09:26:03 +0000 (11:26 +0200)]

Up to CMake 3.3 LINK_DEPENDS was ignored in non-Makefile generators. See also Since CMake 3.4 it is no longer ignored, but requires CMP0005 policy to be set to NEW and it requires a full path which was already correctly used on GCC, but not on MSVC builds.

22 months ago[CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)
Andrew Cook [Sat, 27 Apr 2019 09:33:37 +0000 (19:33 +1000)]
[CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)

* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables

* LINK_DEPENDS is semicolon separated

* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header

22 months ago[SDK][INCLUDE] small fix for msgdump.h
Katayama Hirofumi MZ [Sat, 27 Apr 2019 09:30:29 +0000 (18:30 +0900)]
[SDK][INCLUDE] small fix for msgdump.h

22 months ago[WIN32SS][NTGDI] Use UNICODE_NULL for consistency
Katayama Hirofumi MZ [Sat, 27 Apr 2019 07:17:37 +0000 (16:17 +0900)]
[WIN32SS][NTGDI] Use UNICODE_NULL for consistency

22 months ago[WIN32SS][NTGDI] FireFox checkmark fix CORE-15303 (#1535)
Katayama Hirofumi MZ [Sat, 27 Apr 2019 00:38:01 +0000 (09:38 +0900)]
[WIN32SS][NTGDI] FireFox checkmark fix CORE-15303 (#1535)

The font size was a bit larger than expected. FireFox will show checkmarks correctly in View menu. CORE-15303

22 months ago[POWERCFG] Show the name of the power scheme in the delete confirmation message box
Eric Kohl [Fri, 26 Apr 2019 21:12:36 +0000 (23:12 +0200)]
[POWERCFG] Show the name of the power scheme in the delete confirmation message box

22 months ago[POWERCFG] Some small cleanup
Eric Kohl [Fri, 26 Apr 2019 19:51:48 +0000 (21:51 +0200)]
[POWERCFG] Some small cleanup

- Replace %1 by %s in IDS_CONFIG1 and IDS_CONFIG2

22 months ago[WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)
Katayama Hirofumi MZ [Fri, 26 Apr 2019 12:56:36 +0000 (21:56 +0900)]
[WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)

Fix CORE-15785. When LOGFONT.lfFaceName[0] == 0, then enumeration of font substitutes had failed. CORE-15785

22 months ago[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so...
Colin Finck [Fri, 26 Apr 2019 08:30:24 +0000 (10:30 +0200)]
[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so increase it to 170 seconds.

This is still below the 180 seconds before sysreg2 kills the entire VM.
I've added a comment to clarify that.

22 months ago[PSDK] Improve lmrepl.h
Timo Kreuzer [Sun, 21 Apr 2019 10:59:23 +0000 (12:59 +0200)]
[PSDK] Improve lmrepl.h

Added public domain header. This file was originally imported in r8283 from w32api where is has no copyright.

22 months ago[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started...
Colin Finck [Wed, 24 Apr 2019 08:48:15 +0000 (10:48 +0200)]
[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.

unattend.inf only allows to add RunOnce entries, which are in theory only executed on the first boot after installation.
For almost a decade, this worked anyway to start regtest.cmd again after a ReactOS crash, because the registry and thus the deletion of the RunOnce entry wasn't stored on disk in case of a crash.
Thanks to Sylvain for the hint!

As Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot, exit the script just after adding the Run key.
Otherwise, rosautotest.exe would be started twice, with catastrophic results.

22 months ago[ROSAUTOTEST] Cache the result of GetLastError().
Colin Finck [Tue, 23 Apr 2019 09:37:58 +0000 (11:37 +0200)]
[ROSAUTOTEST] Cache the result of GetLastError().

22 months ago[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log...
Colin Finck [Tue, 23 Apr 2019 07:17:05 +0000 (09:17 +0200)]
[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log output within 2 minutes, the test process is killed, and we continue with the next test.

This is a rather graceful approach compared to sysreg2's 3 minute timeout before killing and restarting the entire VM.
Since we added autochk for FAT filesystems, the filesystem is often "fixed" after a reset with the consequence that ReactOS doesn't boot up anymore.
The sysreg2 restart code still remains for handling tests causing BSODs.

22 months ago[POWERCFG] Fix the initialization of the power schemes page
Eric Kohl [Thu, 25 Apr 2019 22:03:27 +0000 (00:03 +0200)]
[POWERCFG] Fix the initialization of the power schemes page


22 months ago[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5
Oleg Dubinskiy [Sun, 14 Apr 2019 18:00:12 +0000 (21:00 +0300)]
[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5

22 months ago[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522) 1522/head
Jared Smudde [Tue, 23 Apr 2019 05:47:02 +0000 (00:47 -0500)]
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)

CORE-13516, CORE-13518

22 months ago[MPR] Implement the function WNetDisconnectDialog(). (#1522)
Jared Smudde [Tue, 23 Apr 2019 05:46:28 +0000 (00:46 -0500)]
[MPR] Implement the function WNetDisconnectDialog(). (#1522)

CORE-13516, CORE-13518

22 months ago[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)
Jared Smudde [Tue, 23 Apr 2019 05:45:49 +0000 (00:45 -0500)]
[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)

CORE-13516, CORE-13518

22 months ago[APPWIZ.CPL] Set a default shortcut-link description (#1520)
Katayama Hirofumi MZ [Wed, 24 Apr 2019 01:44:44 +0000 (10:44 +0900)]
[APPWIZ.CPL] Set a default shortcut-link description (#1520)


22 months ago[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler...
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:41:41 +0000 (03:41 +0200)]
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.

22 months ago[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure...
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:36:27 +0000 (03:36 +0200)]
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().