Katayama Hirofumi MZ [Sat, 1 Apr 2023 02:33:36 +0000 (11:33 +0900)]
[KERNEL32] LCMapString: Fullwidth/halfwidth conversion (#5206)
- Add file dll/win32/kernel32/winnls/string/dakuten.h.
- Add file dll/win32/kernel32/winnls/string/full2half.h.
- Support LCMAP_FULLWIDTH and LCMAP_HALFWIDTH in LCMapString.
CORE-11700
valmorflores [Thu, 30 Mar 2023 23:37:45 +0000 (20:37 -0300)]
[NOTEPAD][OSK] Improve/Add Portuguese (Brazilian pt-BR and Portugal pt-PT) translations (#5124)
Co-authored-by: Julen Urizar Compains <julenuri@hotmail.com>
Doug Lyons [Thu, 30 Mar 2023 11:31:13 +0000 (06:31 -0500)]
[SHELL32_APITESTS] Add ROS.ico test file. Improve shell32:ExtractIconEx tests (#5169)
Improve shell32:ExtractIconEx tests by updating it and adding more test files and 1 new icon file.
JIRA issue: ROSTESTS-381
Add new ROS.ico file which has both a normal icon and a PNG one.
Update testing to test for count of icons in file and separately extract the 0th one.
Add tests for sysicon.ico, explorer.exe and the new ROS.ico files.
Hermès Bélusca-Maïto [Wed, 29 Mar 2023 01:36:24 +0000 (03:36 +0200)]
[NTOS:KD] Fix build, addendum to commit
f3dd7133.
This one was more subtle because the prompt (KdIoReadLine) functionality
makes a call-back to KDBG own command history getter function KdbGetHistoryEntry.
It is planned for this to become a registered optional callback pointer.
Hermès Bélusca-Maïto [Wed, 29 Mar 2023 00:55:06 +0000 (02:55 +0200)]
Fix build, addendum to commit
35180b3a
Hermès Bélusca-Maïto [Wed, 29 Mar 2023 00:06:35 +0000 (02:06 +0200)]
[NTOS:KDBG] Isolate terminal and input-related routines from the rest of KDBG. (#5188)
This is done in preparation for moving all this functionality in a
separate KDTERM "KD Terminal Driver" DLL.
Additionally:
- Flush the terminal input before sending ANSI escape sequences.
- In KDBG pager, always use the correct reading-key function (the
same used also for reading keys for a line of user input), and not
the simplistic two-call KdbpGetCharSerial + KdbpTryGetCharSerial
that would split the \r \n across calls.
- Call KdbpGetCommandLineSettings() in KdbInitialize() at BootPhase 0,
which is indirectly called by KdDebuggerInitialize0(). And fix its
command-line parsing too.
Joachim Henze [Tue, 28 Mar 2023 23:23:00 +0000 (01:23 +0200)]
[SYSSETUP] Tweak IDD_COMPUTERPAGE positioning (#5198)
- make all 3 input boxes IDC_COMPUTERNAME, IDC_ADMINPASSWORD1, IDC_ADMINPASSWORD2 on this page the same length for all languages and start and end at same x-coord, e.g. sk-SK.rc, uk-UA.rc
- let the input boxes end at the same x as the edits in the previous dlg IDD_OWNERPAGE
- respect the right margin of the dialog with all controls for all languages, makes it look more harmonic to previous and next dlg, see video:
- make the input fields as wide as possible, but not wider, depending on what the language allowed I used width of 139, 148, 163 (163 is same as the EDITs in IDD_OWNERPAGE used)
- fix too small x offset for some controls in some languages like bg-BG.rc, that looked very off
- in zh-CN.rc fix the maximum allowed length for computer name from 63 to 15
- ja-JP.rc 15 is max chars for computer name, not 63
- Fix it-IT text truncation "Organizzazione" in IDD_OWNERPAGE
- pl-PL.rc Steal some wisdom from 0.4.9 to better stick with en-US.rc dimensions.
Hermès Bélusca-Maïto [Mon, 20 Mar 2023 16:49:15 +0000 (17:49 +0100)]
[NTOS:KD:KDBG] Isolate the read-line (prompt) functionality in a separate file.
Rename KdbpReadCommand as KdIoReadLine. Extract the last-command
repetition functionality out of KdIoReadLine and put it where it
belongs: only in the KDBG command main loop KdbpCliMainLoop.
Hermès Bélusca-Maïto [Tue, 28 Mar 2023 12:13:48 +0000 (14:13 +0200)]
[NTOS:KDBG] Use KdbpSendCommandSerial() to send specific ANSI escape sequences.
Use this function instead of KdpDprintf(), otherwise, we send them to
**ALL** the display providers, including for example dmesg. Replaying
the listing with dmesg would then cause the terminal to misbehave later.
For example, it would send the answer of a "Query Device Attributes"
command, as the response to a query for terminal size...
Katayama Hirofumi MZ [Tue, 28 Mar 2023 13:31:26 +0000 (22:31 +0900)]
[MSPAINT][ATL] Encapsulation: mainWindow (#5178)
- Add DoCreate methods to CFullscreenWindow, CMiniatureWindow, and CMainWindow classes.
- Do encapsulation around mainWindow and _tWinMain.
- Add GetOpenFileName, GetSaveFileName, and ChooseColor helper methods to CMainWindow class.
- Move some code in WinMain into CMainWindow::OnCreate.
- Delay creation of CFullscreenWindow and CMiniatureWindow.
- Extend ATL CImage class as CImageDx in newly-created atlimagedx.h of mspaint.
CORE-18867
Katayama Hirofumi MZ [Tue, 28 Mar 2023 12:09:27 +0000 (21:09 +0900)]
[KERNEL32] LCMapString: Sync to Wine a little (#5203)
Preparation for LCMAP_FULLWIDTH and LCMAP_HALFWIDTH support.
Slightly synchronize lang.c to locale.c in Wine's dlls/kernelbase.
CORE-11700
Katayama Hirofumi MZ [Tue, 28 Mar 2023 08:20:20 +0000 (17:20 +0900)]
[NTOSKRNL] Fix build in Release; #include 'kd.h'
Katayama Hirofumi MZ [Tue, 28 Mar 2023 01:00:22 +0000 (10:00 +0900)]
[KERNEL32] Follow-up of #5200 (
5d1ae45)
Add "Voiced Iteration Marks" to convert.
CORE-11700
Hermès Bélusca-Maïto [Mon, 27 Mar 2023 23:33:55 +0000 (01:33 +0200)]
[NTOS:KD] Use local print-like functions for output, instead of the kernel-internal KdpDprintf.
Indeed, the latter won't be accessible once those KD IO functions
get moved out into a separate KDTERM.DLL.
Katayama Hirofumi MZ [Mon, 27 Mar 2023 23:37:17 +0000 (08:37 +0900)]
[KERNEL32] LCMapString: Hiragana/Katakana conversion (#5200)
Implement LCMAP_KATAKANA and LCMAP_HIRAGANA flags. CORE-11700
Katayama Hirofumi MZ [Mon, 27 Mar 2023 23:12:38 +0000 (08:12 +0900)]
[BLUE] Optimize ScrIoControl for speed (#5185)
Optimize IOCTL_CONSOLE_FILL_OUTPUT_ATTRIBUTE and IOCTL_CONSOLE_FILL_OUTPUT_CHARACTER for speed by using cache. CORE-18838
Hermès Bélusca-Maïto [Mon, 27 Mar 2023 20:40:09 +0000 (22:40 +0200)]
[NTOS:KDBG] Move command history management in a separate file. Simplify duplicated code in KdbpReadCommand.
Hermès Bélusca-Maïto [Mon, 27 Mar 2023 21:13:53 +0000 (23:13 +0200)]
[NTOS:KD] Split internal/kd.h into a part shared in the whole kernel and a private part only used within ntoskrnl/kd.
Hermès Bélusca-Maïto [Sun, 26 Mar 2023 00:32:33 +0000 (01:32 +0100)]
[NTOS:KD] Update file headers.
Hermès Bélusca-Maïto [Sun, 26 Mar 2023 00:28:59 +0000 (01:28 +0100)]
[NTOS:KD:KDBG] Move some files to a better place.
Katayama Hirofumi MZ [Mon, 27 Mar 2023 10:42:47 +0000 (19:42 +0900)]
[COMCTL32][USER32] WM_IME_CHAR: Rely on DefWindowProc... (#5191)
Use DefWindowProc... for WM_IME_CHAR handling. CORE-15289, CORE-11700
Joachim Henze [Sun, 26 Mar 2023 23:09:31 +0000 (01:09 +0200)]
[SYSSETUP] Delete obsolete lt-LT.rc
syssetup/lang/lt-LT.rc is a 100% copy of en-US.rc. Not a single string or path within did differ.
The file emerged once during some refactoring when parts from userenv were moved to syssetup in SVN r73518 == git
c24dcb3ff25fb5469f8153c19d03fa183c2d9c8b .
By deduplicating that file syssetup.dll shrinks for GCC8.4.0dbg RosBEWin2.2.2
and it will speed up the development of that module if one rc-file less has to be groomed everytime something is added into syssetup.dll.
It is quicker to recreate that file later if some use for translation would evolve in the module.
I linked this commit against CORE-18893 although my commit did neither introduce
nor would solve that bug of 'the language not generating any startmenu entries'!
I stumbled over the file being a total copy of en-US
after that ticket was created already and then compared the contents of lt-LT.rc to en-US.rc
So I though the linking would make kind of sense.
I installed in lithuanian before and after my commit. No change!
lt-LT.rc was the last one of such rc copy-pastes in [SYSSETUP], I double-checked them all now.
Joachim Henze [Sun, 26 Mar 2023 03:04:41 +0000 (05:04 +0200)]
[SYSSETUP] Fix font glitch in ja-JP.rc (#5192)
CORE-18706
George Bișoc [Sat, 25 Mar 2023 18:47:26 +0000 (19:47 +0100)]
[KMTESTS:OB] Refactor OBJ_DIRECTORY_TYPE_INFO_SIZE define construct
Object types are mere type names with no backslash. Also remove wcslen()
from the define, it's not needed.
Joachim Henze [Sat, 25 Mar 2023 17:21:39 +0000 (18:21 +0100)]
[SYSSETUP] Fix typo in german de-DE.rc
That typo was introduced by 0.4.15-dev-3638-g
3f053db3e704db680cdc7b48ff97eb64299fdd39
and did only affect the master branch.
Joachim Henze [Sat, 25 Mar 2023 13:15:22 +0000 (14:15 +0100)]
[SYSSETUP] Delete obsolete fi-FI.rc
syssetup/lang/fi-FI.rc is a 100% copy of en-US.rc. Not a single string or path within did differ.
The file emerged once during some refactoring when parts from userenv were moved to syssetup in SVN r73518 == git
c24dcb3ff25fb5469f8153c19d03fa183c2d9c8b .
By deduplicating that file syssetup.dll shrinks from 1.374.208 -> 1.361.920 for GCC8.4.0dbg RosBEWin2.2.2
and it will speed up the development of that module if one rc-file less has to be groomed everytime something is added into syssetup.dll.
It is quicker to recreate that file later if some use for translation would evolve in the module.
I linked this commit against CORE-18893 although my commit did neither introduce
nor would solve that bug of 'the language not generating any startmenu entries'!
I stumbled over the file being a total copy of en-US
after I saw that glitch and created the ticket and then compared the contents of fi-FI.rc to en-US.rc
So I though the linking would make kind of sense.
I installed in finnish before and after my commit. No change!
Thamatip Chitpong [Sat, 25 Mar 2023 13:00:26 +0000 (20:00 +0700)]
[AFD] ReceiveActivity: Don't return STATUS_FILE_CLOSED in case of FCB overread (#4972)
Based on patch by KRosUser. Remove the Overread member. The new test in ws2_32:recv confirms that this special behavior is never needed.
CORE-18328
Katayama Hirofumi MZ [Sat, 25 Mar 2023 12:31:32 +0000 (21:31 +0900)]
[EXPLORER] Improve Clock text color for High Contrast (#5180)
Use GetSysColor(COLOR_BTNTEXT) to get the system color in CTrayClockWnd::OnPaint. CORE-18886
George Bișoc [Thu, 23 Mar 2023 09:08:57 +0000 (10:08 +0100)]
Tag Win32SS related PRs with "Win32SS" label
George Bișoc [Sun, 19 Mar 2023 21:38:31 +0000 (22:38 +0100)]
[KMTESTS:OB] Write some object information querying tests
George Bișoc [Sun, 19 Mar 2023 21:04:21 +0000 (22:04 +0100)]
[NTOS:OB] Implement name information querying on ObjectBasicInformation case
Currently there is no implementation support for object name information
querying when someone queries information about an object with ObjectBasicInformation
class case. Some device drivers may take use of such information.
NameInfoSize is a size that is the sum of all name directories of an object,
including path separators. TypeInfoSize is a size that is pointed by
the size of a type object itself, therefore this size remains pretty much
fixed depending on the kind of an object.
For more information:
https://www.geoffchappell.com/studies/windows/km/ntoskrnl/inc/api/ntobapi/object_basic_information.htm
http://undocumented.ntinternals.net/index.html?page=UserMode%2FUndocumented%20Functions%2FNT%20Objects%2FType%20independed%2FNtQueryObject.html
Thamatip Chitpong [Thu, 23 Mar 2023 09:22:10 +0000 (16:22 +0700)]
[NTUSER] VerifyWnd: Remove pointless SEH and simplify the function (#5125)
Ratin Gao [Sat, 4 Mar 2023 06:34:08 +0000 (14:34 +0800)]
[KERNEL32] GlobalMemoryStatusEx should handle error and return FALSE when failed
Artyom Ovsyannikov [Thu, 23 Mar 2023 05:33:18 +0000 (08:33 +0300)]
[NOTEPAD] Russian (ru-RU) translation update (#5181)
Google Translate helped me to translate some lines.
Katayama Hirofumi MZ [Thu, 23 Mar 2023 03:24:40 +0000 (12:24 +0900)]
[COMCTL32][USER32] EDIT: Half-implement WM_IME_SETCONTEXT handling (#5182)
Add WM_IME_SETCONTEXT handling to the window procedure of the EDIT control. CORE-11700, CORE-15289
Katayama Hirofumi MZ [Thu, 23 Mar 2023 03:24:00 +0000 (12:24 +0900)]
[COMCTL32][USER32] EDIT: Half-implement WM_IME_STARTCOMPOSITION (#5183)
Improve WM_IME_STARTCOMPOSITION handling in the window procedure of the EDIT control. CORE-15289, CORE-11700
Hermès Bélusca-Maïto [Wed, 22 Mar 2023 18:45:33 +0000 (19:45 +0100)]
[NTOS:KD] DbgKdGetStringApi implementation: Ensure the returned string is NULL-terminated.
Addendum to commit
84e32e4e.
Explain more accurately what's going on regarding the returned string
and the inaccurate claims made in the official DbgPrompt documentation
in MSDN. (Has been verified by looking through the traffic in WinDbg
debugging of Windows and ReactOS.)
Hermès Bélusca-Maïto [Wed, 22 Mar 2023 16:02:19 +0000 (17:02 +0100)]
[NTOS:KD64] Format string of KdpDprintf can be const.
Joachim Henze [Wed, 22 Mar 2023 05:18:54 +0000 (06:18 +0100)]
[UNIATA] PROPERLY mark the rosdiff when touching 3rd party code
This is an addendum to 0.4.15-dev-5854-g
08248e83a0babebef805a0df3bdd0d59b2e7b82e from (#5053).
The review requests had not been addressed entirely before committing!
Katayama Hirofumi MZ [Wed, 22 Mar 2023 01:42:21 +0000 (10:42 +0900)]
[MSPAINT] Simplify OFNHookProc and FileExtFromFilter
... by using PathFindExtension and PathFindFileName.
CORE-18867
Katayama Hirofumi MZ [Wed, 22 Mar 2023 00:09:38 +0000 (09:09 +0900)]
[COMCTL32][USER32] EDIT: Default processing on WM_IME_SELECT/WM_IME_CONTROL (#5173)
Do default processing on WM_IME_SELECT and WM_IME_CONTROL messages in EDIT controls. CORE-11700, CORE-15289
Katayama Hirofumi MZ [Tue, 21 Mar 2023 23:10:26 +0000 (08:10 +0900)]
[MSPAINT] Improve CMiniatureWindow::OnPaint
CORE-18867
Atharva Kulkarni [Tue, 21 Mar 2023 22:01:18 +0000 (03:31 +0530)]
[UNIATA] Fix Memory leak while claiming PCI IDE controller (#5053)
HalAssignSlotResources will allocate a new resource list which the caller must free.
Katayama Hirofumi MZ [Tue, 21 Mar 2023 04:15:08 +0000 (13:15 +0900)]
[MSPAINT] Simplify TextEdit by using SizeBox (#5177)
Reduce source code. CORE-18867
Katayama Hirofumi MZ [Tue, 21 Mar 2023 04:13:53 +0000 (13:13 +0900)]
[MSPAINT] Tool settings: Reduce magic numbers (#5168)
Many coordinates are dynamically calculated. It is adjustable against client area change.
- Fix some brush/eraser shapes for pixel perfection.
- Reduce magic numbers in toolssettings.cpp.
- Refactoring.
CORE-18867
Katayama Hirofumi MZ [Mon, 20 Mar 2023 23:59:40 +0000 (08:59 +0900)]
[NOTEPAD] Use _countof macro from <stdlib.h> (#5170)
- Remove the definition of ARRAY_SIZE macro.
- Replace ARRAY_SIZE and ARRAYSIZE with _countof.
CORE-18837
Katayama Hirofumi MZ [Mon, 20 Mar 2023 22:26:04 +0000 (07:26 +0900)]
[REGEDIT] Move '#include <crtdbg.h>' and add _CRTDBG_MAP_ALLOC
- Add #include <stdlib.h>.
- Move #include <crtdbg.h> to "regedit.h".
- Add #define _CRTDBG_MAP_ALLOC before #include <crtdbg.h>.
CORE-18876
Katayama Hirofumi MZ [Mon, 20 Mar 2023 22:21:31 +0000 (07:21 +0900)]
[NTUSER] ime.c: Add parameter to ERR(...)
Follow-up of
94f22bd.
CORE-11700
Serge Gautherie [Mon, 20 Mar 2023 21:19:30 +0000 (22:19 +0100)]
[NOTEPAD] LoadIcon() needs no DestroyIcon() (#5142)
CORE-18369
Katayama Hirofumi MZ [Mon, 20 Mar 2023 13:59:05 +0000 (22:59 +0900)]
[MSPAINT] Move '#include <crtdbg.h>' and add _CRTDBG_MAP_ALLOC
CORE-18867
Katayama Hirofumi MZ [Mon, 20 Mar 2023 13:55:12 +0000 (22:55 +0900)]
[NOTEPAD] Move '#include <crtdbg.h>' and add _CRTDBG_MAP_ALLOC (#5176)
CORE-18837
Katayama Hirofumi MZ [Mon, 20 Mar 2023 10:12:25 +0000 (19:12 +0900)]
[NTUSER] ime.c: Add ERR(...) to the exception handlers
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 10:10:04 +0000 (19:10 +0900)]
[NTUSER] NtUserSetImeInfoEx: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 10:08:38 +0000 (19:08 +0900)]
[NTUSER] NtUserGetImeInfoEx: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 10:06:44 +0000 (19:06 +0900)]
[NTUSER] NtUserBuildHimcList: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 10:04:18 +0000 (19:04 +0900)]
[NTUSER] NtUserGetImeHotKey: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 09:59:42 +0000 (18:59 +0900)]
[NTUSER] IntSendMessageToUI: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 09:49:23 +0000 (18:49 +0900)]
[NTUSER] IntNotifyImeShowStatus: Use _SEH2_YIELD
CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 07:33:11 +0000 (16:33 +0900)]
[USER32_APITEST] Follow-up of
c39bf0d
Avoid buffer overflow. CORE-15289, CORE-11700
Katayama Hirofumi MZ [Mon, 20 Mar 2023 07:17:50 +0000 (16:17 +0900)]
[USER32_APITEST] Improve MessageStateAnalyzer testcase
CORE-15289, CORE-11700
Hermès Bélusca-Maïto [Mon, 20 Mar 2023 02:10:14 +0000 (03:10 +0100)]
[NTOS:KDBG] Temporarily HACK-work-around symbols loading by disabling them at BootPhase 0.
Of course, now that we **correctly** set the LoadSymbools setting,
we attempt loading symbols at BootPhase 0 and everything goes awry!
So introduce that hack to fallback to our old behaviour.
A proper fix (and removal of the hack) will be done in future commits.
Hermès Bélusca-Maïto [Mon, 20 Mar 2023 01:28:16 +0000 (02:28 +0100)]
[NTOS:KDBG] Fix parsing the boot command line for the (NO)LOADSYMBOLS options.
Addendum to commit
de892d5b.
The boot options get stripped of their optional command switch '/'
(and replaced by whitspace separation) by the NT loader. Also, forbid
the presence of space between the optional '=' character following
(NO)LOADSYMBOLS.
In addition, fix the default initialization of LoadSymbols in KdbSymInit():
we cannot rely on MmNumberOfPhysicalPages in BootPhase 0 since at this point,
the Memory Manager hasn't been initialized and this variable is not yet set.
(We are called by KdInitSystem(0) -> KdDebuggerInitialize0 at kernel init.)
It gets initialized later on between BootPhase 0 and 1.
Also display a nice KDBG signon showing the status of symbols loading.
Jose Carlos Jesus [Sun, 19 Mar 2023 19:32:24 +0000 (16:32 -0300)]
[TRANSLATION] Improvements to portuguese (pt-PT) translation (#5154)
For: hivedef.inf, powercfg.cpl, sysdm.cpl
and: netshell.dll, netcfgx.dll, shell32.dll, userenv.dll
Also fix "My Documents" and "My Network Places" folder names.
Justin Miller [Sun, 19 Mar 2023 19:13:16 +0000 (12:13 -0700)]
[FREELDR] Support compiling freeldr as a UEFI loader + Implement UI functions (#5171)
First batch of changes to implement a UEFI version of freeldr:
- Compile freeldr as EFI binary on top of the existing loader.
- Stub out various functions so we can create a UEFI machine-type in freeldr.
- Implement all of the video output functions so we can display a pretty freeldr BSoD :)
Hermès Bélusca-Maïto [Sun, 19 Mar 2023 16:46:00 +0000 (17:46 +0100)]
[FREELDR] Fix missing exports and .edata section after commit
728694f6.
CORE-18880
Thomas Faber [Sun, 19 Mar 2023 16:39:09 +0000 (12:39 -0400)]
[WS2_32_APITEST] Test overlapping recv overread. CORE-18328
Thomas Faber [Sun, 19 Mar 2023 13:26:24 +0000 (09:26 -0400)]
[WS2_32_APITEST] Add a test for recv overread. CORE-18328
Katayama Hirofumi MZ [Sun, 19 Mar 2023 01:42:10 +0000 (10:42 +0900)]
[MSPAINT] Make sizeboxes window-less (#5166)
Reduce window controls and integrate to the canvas window.
- The sizeboxes are absorbed by canvasWindow.
- class CSizeboxWindow is deleted.
- Add enum CANVAS_HITTEST.
- Add getSizeBoxRect, getSizeBoxHitTest, and drawSizeBoxes helper functions in sizebox.cpp.
CORE-18867
Hermès Bélusca-Maïto [Thu, 9 Mar 2023 16:30:34 +0000 (17:30 +0100)]
[FREELDR] Move platform-specific build targets into dedicated .cmake files. (#5141)
- Keep the common definitions and file lists in CMakeLists.txt
- Move PC-AT & compatibles (PC-98, XBOX) definitions in pcat.cmake
- Future UEFI-specific definitions will be in an uefi.cmake
Hermès Bélusca-Maïto [Thu, 9 Mar 2023 16:26:38 +0000 (17:26 +0100)]
[FREELDR] Move common x64 runtime-specific ASM helpers to a misc file.
Co-authored-by: Justin Miller <justinmiller100@gmail.com>
Dmitry Borisov [Sat, 18 Mar 2023 15:57:52 +0000 (21:57 +0600)]
[DDK:NDIS] Fix definition of broadcast address macro (#5155)
ff:ff:ff:ff:ff:ff is the broadcast MAC address.
CORE-8724
Katayama Hirofumi MZ [Sat, 18 Mar 2023 08:19:56 +0000 (17:19 +0900)]
[MSPAINT] Save ToolBox visibility (#5167)
According to my registry analysis, the target value is HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Applets\Paint\General-Bar3:Visible.
- Add ShowToolBox registry setting.
CORE-18867
Katayama Hirofumi MZ [Sat, 18 Mar 2023 08:12:28 +0000 (17:12 +0900)]
[MSPAINT] Save paletteWindow visibility (#5167)
According to my registry analysis, HKCU\Software\Microsoft\Windows\CurrentVersion\Applets\Paint\General-Bar4:Visible is the target value.
- Improve ReadDWORD helper function.
- Add ShowPalette registry setting.
- Simplify RegistrySettings::Load and RegistrySettings::Store.
CORE-18867
Hermès Bélusca-Maïto [Tue, 14 Mar 2023 17:50:30 +0000 (18:50 +0100)]
[NTOS:KD] Improve the display of the output providers' signons.
Hermès Bélusca-Maïto [Wed, 15 Mar 2023 19:31:28 +0000 (20:31 +0100)]
[NTOS:MM] Simplify definitions of MM_SYSLDR_NO_IMPORTS and MM_SYSLDR_BOOT_LOADED.
Hermès Bélusca-Maïto [Sat, 18 Mar 2023 02:06:54 +0000 (03:06 +0100)]
[SDK] driverspecs.h: Add missing dummy _IRQL_limited_to_() definition (when _PREFAST_ is not defined).
Addendum to commit
8a688204.
Katayama Hirofumi MZ [Fri, 17 Mar 2023 23:24:19 +0000 (08:24 +0900)]
[MSPAINT] Encapsulation: hNontranspIcon and hTranspIcon
CORE-18867
Katayama Hirofumi MZ [Fri, 17 Mar 2023 23:09:26 +0000 (08:09 +0900)]
[MSPAINT] Encapsulation: hCurFill, hCurColor etc.
CORE-18867
Katayama Hirofumi MZ [Fri, 17 Mar 2023 10:18:07 +0000 (19:18 +0900)]
[MSPAINT] Add Static Edge to toolbars
- Add WS_EX_STATICEDGE to paletteWindow.
- Remove CCS_NODIVIDER from toolbar.
CORE-18867
Katayama Hirofumi MZ [Fri, 17 Mar 2023 10:01:42 +0000 (19:01 +0900)]
[MSPAINT] Delete useless "STATIC" control
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:51:12 +0000 (07:51 +0900)]
[MSPAINT] Move UpdateCanvas's code to newly-defined CCanvasWindow::Update
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:45:14 +0000 (07:45 +0900)]
[MSPAINT] Rename scrollbox as canvas
- s/CScrollboxWindow/CCanvasWindow/
- s/scrollboxWindow/canvasWindow/
- s/UpdateScrollbox/UpdateCanvas/
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:28:42 +0000 (07:28 +0900)]
[MSPAINT] Remove extra scrlClientWindow (#5162)
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:28:01 +0000 (07:28 +0900)]
[MSPAINT] Refactor about Recent Files (#5163)
Define MAX_RECENT_FILES macro as 4.
Remove strFile1, ..., strFile4 settings and add strFiles[MAX_RECENT_FILES] for Most Recently Used (MRU) files.
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:26:44 +0000 (07:26 +0900)]
[MSPAINT] Restore the main window saved show state (#5158)
Our mspaint didn't remember the maximized status of the main window. CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 22:25:51 +0000 (07:25 +0900)]
[MSPAINT] Unlink HHCTRL.OCX and use dynamic load (#5165)
Unlink HHCTRL.OCX by modifying CMakeLists.txt. Add DoHtmlHelpW helper function. CORE-18879, CORE-18867
George Bișoc [Wed, 15 Mar 2023 18:52:29 +0000 (19:52 +0100)]
[NTDLL_APITEST] Write some tests for NtQueryOpenSubKeys
Katayama Hirofumi MZ [Thu, 16 Mar 2023 09:13:28 +0000 (18:13 +0900)]
[MSPAINT] Delete needless CMainWindow::OnSetCursor
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 08:56:05 +0000 (17:56 +0900)]
[MSPAINT] Delete useless CFullscreenWindow::OnSetCursor
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 08:49:05 +0000 (17:49 +0900)]
[MSPAINT] Delete needless CMiniatureWindow::OnSetCursor
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 08:26:27 +0000 (17:26 +0900)]
[MSPAINT] Delete needless CToolBox::OnSetCursor
CORE-18867
Katayama Hirofumi MZ [Thu, 16 Mar 2023 01:18:54 +0000 (10:18 +0900)]
[NOTEPAD] Use full path for non-existent file (#5152)
In HandleCommandLine function, use GetFullPathName API to get the full path of a non-existent file. CORE-18259, CORE-18837
Robert Naumann [Tue, 14 Mar 2023 19:09:19 +0000 (20:09 +0100)]
[REGEDIT] import Wine commit
f5fe9a6 by Hugh McMaster.
https://github.com/wine-mirror/wine/commit/
f5fe9a6cf9121004ecdf5c0b285fcd88ec8a0d94
This removes the ROS-diff caused by CORE-18603's fix
Katayama Hirofumi MZ [Wed, 15 Mar 2023 06:09:26 +0000 (15:09 +0900)]
[MSPAINT] Delete unused global variables (lfTextFont, ...
hfontTextFont, hwndEditCtl, textToolText, and textToolTextMaxLen).
CORE-18867
Doug Lyons [Wed, 15 Mar 2023 01:57:54 +0000 (20:57 -0500)]
Fix buffer read past end problem. (#5146)
Fixes crashes in regedit-find affecting CORE-15896 and CORE-18230. After possible RegQueryValueExW append 3 zero bytes to guarantee that we will end with a UNICODE NULL.
Katayama Hirofumi MZ [Tue, 14 Mar 2023 22:29:25 +0000 (07:29 +0900)]
[MSPAINT] Avoid flickering when resizing (#5144)
- Add CPaletteWindow::OnEraseBkgnd to avoid flickering.
- Add getColorBoxRect and drawColorBox helper functions to draw a color box.
- Add CPaletteWindow::DoHitTest helper function to do a hit test.
- Improve CPaletteWindow::OnPaint by using a memory bitmap.
- Improve readability of CMainWindow::alignChildrenToMainWindow.
CORE-18867
Katayama Hirofumi MZ [Tue, 14 Mar 2023 22:28:15 +0000 (07:28 +0900)]
[NOTEPAD] Delete license.c (no use) (#5159)
File license.c is not used. Reduce source code. CORE-18837
Katayama Hirofumi MZ [Tue, 14 Mar 2023 22:27:29 +0000 (07:27 +0900)]
[NOTEPAD] Use new-style file header (#5160)
CORE-18837
Jose Carlos Jesus [Tue, 14 Mar 2023 21:27:14 +0000 (18:27 -0300)]
[SHELL32] Give opportunity to rename file/folder on its creation (#5139)
* [SHELL32] Fix issue when creating a new file or folder. No chance to rename the displayed name.
The CNewMenu::SelectNewItem method starts with a request to notify the View object about a new item by calling SHChangeNotify.
After creating and obtaining the new PIDL by calling ILFindLastID, the CDefView::SelectItem method is called.
This method fails right from the start when calling LV_FindItemByPidl which returns -1, thus preventing the user from being given the opportunity to change the name displayed by default.
This failure is due to the fact that this object has not yet been added to the CDefView::m_ListView list. This is caused by the asynchronous nature of SHChangeNotify.
Thanks to Giannis Adamopoulos for the big help.
Katayama Hirofumi MZ [Tue, 14 Mar 2023 05:17:12 +0000 (14:17 +0900)]
[MSPAINT] CImageAreaWindow should inherit CWindowImpl<CImgAreaWindow>
... instead of CWindowImpl<CMainWindow>.
CORE-18867