14 years agoDon't use MenuCleanupRosMenuItemInfo for an array of Items allocated on the heap!
Colin Finck [Sat, 14 Jun 2008 00:00:20 +0000 (00:00 +0000)]
Don't use MenuCleanupRosMenuItemInfo for an array of Items allocated on the heap!
This function is meant to be used for a single menu item info and just frees the memory allocated for dwTypeInfo.

Replaced this with a simple HeapFree call to free the memory for the whole array allocated in MenuGetAllRosMenuItemInfo.
Fixes a heap corruption discovered by encoded.

See issue #3349 for more details.

svn path=/trunk/; revision=33959

14 years agoRevert parts of r33578:
Colin Finck [Fri, 13 Jun 2008 23:14:27 +0000 (23:14 +0000)]
Revert parts of r33578:
- First of all, MenuSetItemData is only called from InsertMenuA/W and ModifyMenuA/W.
  Therefore the passed MENUITEMINFO structure will always be empty, so it makes no sense to check for flags in this structure.
  This way, I could simplify the code block for MF_BITMAP.
- Also fType = MFT_BITMAP and fMask = MIIM_BITMAP at the same time passed to win32k don't work.
  Changing this back to only set fMask fixes bitmap menus.
- Furthermore the data for MF_OWNERDRAW is really stored in dwItemData and not in dwTypeData.
  The MSDN documentation for InsertMenu applies here, not the one for the MENUITEMINFO structure.
  This fixes owner-drawn menus like the one in Abiword.

See issue #3272 for more details.

svn path=/trunk/; revision=33958

14 years ago- german translation of explorer completed
Matthias Kupfer [Fri, 13 Jun 2008 20:33:42 +0000 (20:33 +0000)]
- german translation of explorer completed
- minor fix for label text size in german version of desk.cpl

svn path=/trunk/; revision=33957

14 years agoAdd notes, no code change.
James Tabor [Fri, 13 Jun 2008 18:19:28 +0000 (18:19 +0000)]
Add notes, no code change.

svn path=/trunk/; revision=33956

14 years agoMSDB KB 145994 ( yBaseUnit...
Timo Kreuzer [Fri, 13 Jun 2008 13:33:53 +0000 (13:33 +0000)]
MSDB KB 145994 ( yBaseUnit is textmetric->tmHeight not average text extent. Testing confirms that GdiGetCharDimension returns this as height. This makes dialog boxes less stretched in height. Still not identical to XP. calx.exe: On XP yBaseUnit == 13, on ROS == 14 (was 16 before)

svn path=/trunk/; revision=33955

14 years agoRevert 33953. This is completely wrong! WINE doesn't quite get the ordinals right...
Thomas Bluemel [Fri, 13 Jun 2008 13:14:08 +0000 (13:14 +0000)]
Revert 33953. This is completely wrong! WINE doesn't quite get the ordinals right. Ordinal 200 really should be SHCreateDesktop and ordinal 201 really should be SHDesktopMessageLoop. I am currently working on a patch for this. The fact that explorer-new was able to start with these changes is just pure coincidence.

svn path=/trunk/; revision=33954

14 years ago- Implement AddCommasW
Dmitry Chapyshev [Fri, 13 Jun 2008 07:58:34 +0000 (07:58 +0000)]
- Implement AddCommasW
- Implement SHLocalAlloc
- Implement SHLocalFree
- Implement SHLocalReAlloc
explorer-new starts in reactos now!

svn path=/trunk/; revision=33953

14 years agoAdd missing definitions
Thomas Bluemel [Thu, 12 Jun 2008 23:38:09 +0000 (23:38 +0000)]
Add missing definitions

svn path=/trunk/; revision=33952

14 years agoPatch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), modified by me:
Timo Kreuzer [Thu, 12 Jun 2008 20:50:12 +0000 (20:50 +0000)]
Patch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), modified by me:
The freetype asm function FT_MulFix clobbers the edx register, but doesn't tell it to gcc explicitly, so when inlined versions were resulting in wrong results. Fix it by also marking edx as output register.
Also enable commented out code in win32k again that works correctly now.
By me:
I modified the patch to not alter any 3rd party code, but instead I copied the fuction to _ftmulfix_ros.c and also coplied the container file ftbase.c which now uses the fixed function from our private file.
This fixes a bunch of text output issues (underscore, text marking)
See issue #3346 for more details.

svn path=/trunk/; revision=33951

14 years agoLookup DrawCaptionTemp () only once during startup
Thomas Bluemel [Thu, 12 Jun 2008 16:50:57 +0000 (16:50 +0000)]
Lookup DrawCaptionTemp () only once during startup

svn path=/trunk/; revision=33950

14 years agoFix call to DrawCaptionTemp ()
Thomas Bluemel [Thu, 12 Jun 2008 15:45:09 +0000 (15:45 +0000)]
Fix call to DrawCaptionTemp ()

svn path=/trunk/; revision=33949

14 years ago- Fix a bug in timedate.cpl, where an incorrect color was passed.
Aleksey Bragin [Thu, 12 Jun 2008 09:50:12 +0000 (09:50 +0000)]
- Fix a bug in timedate.cpl, where an incorrect color was passed.
- Add bounds checking for GetSystemMetrics both in user32 and in kernel counterpart.
- Based on a patch from bug 3316.
See issue #3316 for more details.

svn path=/trunk/; revision=33947

14 years ago- Formatting cleanup for the previously patched functions.
Aleksey Bragin [Thu, 12 Jun 2008 09:40:33 +0000 (09:40 +0000)]
- Formatting cleanup for the previously patched functions.

svn path=/trunk/; revision=33946

14 years agoOriol Pique <>
Aleksey Bragin [Thu, 12 Jun 2008 09:35:24 +0000 (09:35 +0000)]
Oriol Pique <>
- Minor patch to HEAP_GetPtr to include magic value in debug output.
- Fixing the parameters checking in HEAP_InitSubHeap (it is currently not used - put between #if 0 / #endif ).
- Correcting HEAP_FindFreeBlock which was logging error message as warning (while still returning NULL to caller) by changing severity of logged message.
- Implementing RtlEnumProcessHeaps (previously stubbed out).
- Fixing sanity checks in and implementation of RtlGetProcessHeaps (previously
the function was not checking for the counter value, and also was not assigning anything to the returned value; now this seems to be corrected.
- Fixing RtlValidateProcessHeaps implementation (the function was stubbed out because (most probably, I wasn't able to find a bug mentioning this) it was previously using a global lock for all heaps (which probably could cause some problems in the kernel), now it only locks heaps belonging to the given process - and this is the correct behaviour.

Aleksey Bragin <>
- Fix typo in ntuser.c, and low severity of debug message.
See issue #2964 for more details.

svn path=/trunk/; revision=33945

14 years ago- Fix two bugs in MiDoMappedCopy: MI_MAPPED_PAGES is pages, not bytes; and a misuse...
Aleksey Bragin [Thu, 12 Jun 2008 09:18:11 +0000 (09:18 +0000)]
- Fix two bugs in MiDoMappedCopy: MI_MAPPED_PAGES is pages, not bytes; and a misuse of TotalSize / BufferSize.
- Fix similar mistake in MiDoPoolCopy.
- Patch from bug 3341.
See issue #3341 for more details.

svn path=/trunk/; revision=33944

14 years ago- Prevent a misunderstanding: kdHandleException means the debugger did NOT handle...
Aleksey Bragin [Thu, 12 Jun 2008 08:56:13 +0000 (08:56 +0000)]
- Prevent a misunderstanding: kdHandleException means the debugger did NOT handle the exception. Fix the logic, and thus fix vectored exception handling which led to 2nd stage hang in qemu.
- TODO: This ContinueType thing should be reworked into a better logic.
See issue #3344 for more details.

svn path=/trunk/; revision=33943

14 years agoUpdated Wordpad, XCopy, WInhlp32 to WIne 1.0rc4
Daniel Reimer [Thu, 12 Jun 2008 06:23:44 +0000 (06:23 +0000)]
Updated Wordpad, XCopy, WInhlp32 to WIne 1.0rc4
I skipped Collibri's Typo-Fix in the German Wordpad RC File. Collibri, plz send this to Wine.

svn path=/trunk/; revision=33942

14 years agoUpdated Winefile to Wine 1.0rc4.
Daniel Reimer [Thu, 12 Jun 2008 06:22:23 +0000 (06:22 +0000)]
Updated Winefile to Wine 1.0rc4.
Renamed it to Winfile, because this is the name it has under windows.

svn path=/trunk/; revision=33941

14 years ago- We now implement more proper context switching.
ReactOS Portable Systems Group [Thu, 12 Jun 2008 04:32:45 +0000 (04:32 +0000)]
- We now implement more proper context switching.
- This fixes an issue where code was using PCR->CurrentThread but x86/shared routines use PRCB->CurrentThread.
- Added a note to explain the difference, and we now set both.
- We currently stop at Phase 1 HAL Initialization.

svn path=/trunk/; revision=33940

14 years agoUse band styles provided by the IDeskBand interface
Thomas Bluemel [Thu, 12 Jun 2008 03:12:02 +0000 (03:12 +0000)]
Use band styles provided by the IDeskBand interface

svn path=/trunk/; revision=33939

14 years agoMore IBandSite support code
Thomas Bluemel [Thu, 12 Jun 2008 01:14:18 +0000 (01:14 +0000)]
More IBandSite support code

svn path=/trunk/; revision=33938

14 years ago- We now implement a super-basic (and probably broken) context switching mechanism.
ReactOS Portable Systems Group [Thu, 12 Jun 2008 00:40:53 +0000 (00:40 +0000)]
- We now implement a super-basic (and probably broken) context switching mechanism.
- We completely ignore setting the thread to the right scheduler state, and don't do any APC delivery checking, or any other work.
- We now implement a basic KiThreadStartup, which behaves properly (we believe). Doesn't handle user-mode threads yet, though.
- This gets us through PspSystemThreadStartup, and..
- We now reach Phase1InitializationDiscard! A major step has been reached, now it's time to cleanup what has been done until now and verify it to be correct.
- Then we move on... the next two things will be 1) Hal Initialization (setting up the timer) and 2) Displaying the boot logo.
- Graphics will require using the PL-110 LCD Controller.

svn path=/trunk/; revision=33937

14 years ago- We now implement a skeleton framework for context switching
ReactOS Portable Systems Group [Wed, 11 Jun 2008 19:13:25 +0000 (19:13 +0000)]
- We now implement a skeleton framework for context switching
- The only things we do are swap the stack and then display the old/new thread/stack.
- More work to be done to actually save the non-volatiles, prepare the thread state, and restore the volatiles for the new thread.
- Then we will return to the saved return address, and we should be in Phase 1 with working thread switching/scheduling.

svn path=/trunk/; revision=33935

14 years ago- We now make appropriate space on the stack to save the old IRQL in the trap frame.
ReactOS Portable Systems Group [Wed, 11 Jun 2008 18:39:44 +0000 (18:39 +0000)]
- We now make appropriate space on the stack to save the old IRQL in the trap frame.
- Save the old IRQL and assert it in the interrupt handler.
- Fix KTRAP_FRAME structure.

svn path=/trunk/; revision=33934

14 years ago- Fix build on ARM:
ReactOS Portable Systems Group [Wed, 11 Jun 2008 16:48:07 +0000 (16:48 +0000)]
- Fix build on ARM:
  - _iob is already defined as a dll_import
  - _rotl intrinsic is now implemented (should use rol instruction, but not sure on the syntax!)
  - Add a stub psctx.h for ARM
  - Added InterlockedEXchangePointers
  - Fix uninitialized variable warning in ex/resource.c
- Start to implement interrupt handling:
  - We now have a rudimentary interrupt handler that takes care of software interrupts
  - We now have a rudimentary DPC handler which takes care of switching to the next thread, if any
  - We now setup the HAL Interrupt Source -> IRQL Table (The IRQLMask Table).
  - Implemented HalGetInterruptSource, which allows us to get the interrupt # that cause the IRQ.
    Note: this wasn't needed on Alpha/PPC/MIPS NT ports, because that information is stored on the CPU,
    and the kernel could read it -- we must abstract it through the HAL.
  - Add the OldIrql to the TRAP_FRAME, we don't use it yet.
- We are now ready to context switch to the Phase 1 thread.

svn path=/trunk/; revision=33933

14 years ago- minor fix of german wordpad menu entry
Matthias Kupfer [Wed, 11 Jun 2008 12:31:23 +0000 (12:31 +0000)]
- minor fix of german wordpad menu entry
- german translation of dialog resource of keyboard layout switcher completed including start menu entry

svn path=/trunk/; revision=33932

14 years ago- Fix build.
Aleksey Bragin [Wed, 11 Jun 2008 12:00:09 +0000 (12:00 +0000)]
- Fix build.

svn path=/trunk/; revision=33931

14 years ago- Fix typos in NDK structures.
Aleksey Bragin [Wed, 11 Jun 2008 11:48:59 +0000 (11:48 +0000)]
- Fix typos in NDK structures.

svn path=/trunk/; revision=33930

14 years ago- Unregress KDBG: It has to increment EIP in case of STATUS_BREAKPOINT to skip over...
Aleksey Bragin [Wed, 11 Jun 2008 11:34:04 +0000 (11:34 +0000)]
- Unregress KDBG: It has to increment EIP in case of STATUS_BREAKPOINT to skip over the current instruction, but now do it inside KDBG's exception handler.
- In Kd and GDB exception handler wrappers, return FALSE if kdDoNotHandleException, and return TRUE otherwise (kdHandled / kdContinue). After my previous commit these functions were always returning FALSE / exception not handled.

svn path=/trunk/; revision=33929

14 years ago- Revert 33689 as breaking mIRC installation.
Aleksey Bragin [Wed, 11 Jun 2008 09:05:39 +0000 (09:05 +0000)]
- Revert 33689 as breaking mIRC installation.
See issue #3328 for more details.

svn path=/trunk/; revision=33928

14 years ago- Completely rewrite most of stdio functions by merging Wine's msvcrt code adapted...
Aleksey Bragin [Wed, 11 Jun 2008 08:54:46 +0000 (08:54 +0000)]
- Completely rewrite most of stdio functions by merging Wine's msvcrt code adapted for ReactOS.
- Leave and refactor existing underlying linux-code based sprintf implementation into lnx_ prefixed functions.
- Misc source code and headers cleanup.
- Fixes bugs 2910, 2803.
See issue #2803 for more details.

svn path=/trunk/; revision=33927

14 years agoFix warnings.
James Tabor [Wed, 11 Jun 2008 04:45:42 +0000 (04:45 +0000)]
Fix warnings.

svn path=/trunk/; revision=33926

14 years agoMore IDeskBar support
Thomas Bluemel [Wed, 11 Jun 2008 03:52:45 +0000 (03:52 +0000)]
More IDeskBar support

svn path=/trunk/; revision=33925

14 years agoImprove IBandSite support a bit
Thomas Bluemel [Wed, 11 Jun 2008 03:37:56 +0000 (03:37 +0000)]
Improve IBandSite support a bit

svn path=/trunk/; revision=33924

14 years agoFix a small bug
Thomas Bluemel [Wed, 11 Jun 2008 03:36:21 +0000 (03:36 +0000)]
Fix a small bug

svn path=/trunk/; revision=33923

14 years agoRetool SetSysColors and use SEH.
James Tabor [Tue, 10 Jun 2008 21:57:16 +0000 (21:57 +0000)]
Retool SetSysColors and use SEH.

svn path=/trunk/; revision=33922

14 years agoEnable the user to modify the profile information of a user account.
Eric Kohl [Tue, 10 Jun 2008 21:56:19 +0000 (21:56 +0000)]
Enable the user to modify the profile information of a user account.

svn path=/trunk/; revision=33921

14 years agoUse server information for GetSystemMetrics.
James Tabor [Tue, 10 Jun 2008 21:09:31 +0000 (21:09 +0000)]
Use server information for GetSystemMetrics.

svn path=/trunk/; revision=33920

14 years agoMatthias Kupfer (matthias DOT kupfer AT informatik DOT tu-chemnitz DOT de)
Colin Finck [Tue, 10 Jun 2008 19:19:59 +0000 (19:19 +0000)]
Matthias Kupfer (matthias DOT kupfer AT informatik DOT tu-chemnitz DOT de)
- Give the Run Dialog resources a default title (only done in German and English resources so far, others still need to be done)
- Add support for passing no title to RunFileDlg, so that it uses the default title
- Pass no hardcoded english title in Explorer and Task-Manager.
  I slightly modified the patch to also remove the other hardcoded text passed in Explorer.

See issue #3340 for more details.

svn path=/trunk/; revision=33919

14 years agoFix build, add float to long union for dword transfer.
James Tabor [Tue, 10 Jun 2008 05:48:18 +0000 (05:48 +0000)]
Fix build, add float to long union for dword transfer.

svn path=/trunk/; revision=33918

14 years agoMove NtGdiAngleArc to arc.c.
James Tabor [Tue, 10 Jun 2008 05:25:37 +0000 (05:25 +0000)]
Move NtGdiAngleArc to arc.c.

svn path=/trunk/; revision=33917

14 years agoMove AngleArc out of stubs.
James Tabor [Tue, 10 Jun 2008 05:14:35 +0000 (05:14 +0000)]
Move AngleArc out of stubs.

svn path=/trunk/; revision=33916

14 years agoshlwapi.dll is already loaded, no need to use LoadLibrary
Thomas Bluemel [Tue, 10 Jun 2008 03:13:12 +0000 (03:13 +0000)]
shlwapi.dll is already loaded, no need to use LoadLibrary

svn path=/trunk/; revision=33915

14 years ago- Don't lookup DrawCaptionTempA/W by ordinal but rather by name
Thomas Bluemel [Tue, 10 Jun 2008 02:58:13 +0000 (02:58 +0000)]
- Don't lookup DrawCaptionTempA/W by ordinal but rather by name
- Various minor fixes

svn path=/trunk/; revision=33914

14 years agoDo a more correct check in EDIT_IsInsideDialog ()
Thomas Bluemel [Tue, 10 Jun 2008 00:31:10 +0000 (00:31 +0000)]
Do a more correct check in EDIT_IsInsideDialog ()

svn path=/trunk/; revision=33913

14 years agofix an endless loop bug
Timo Kreuzer [Mon, 9 Jun 2008 20:57:30 +0000 (20:57 +0000)]
fix an endless loop bug
See issue #2142 for more details.

svn path=/trunk/; revision=33912

14 years agoFixed four more winetests, code taken from wine again
Gregor Brunmar [Mon, 9 Jun 2008 19:14:36 +0000 (19:14 +0000)]
Fixed four more winetests, code taken from wine again

svn path=/trunk/; revision=33910

14 years agoFixed 11 winetests for edit boxes based on code from wine but tweaked for ReactOS
Gregor Brunmar [Mon, 9 Jun 2008 19:07:54 +0000 (19:07 +0000)]
Fixed 11 winetests for edit boxes based on code from wine but tweaked for ReactOS

svn path=/trunk/; revision=33909

14 years agoadd simple TTF icon to fontview
Timo Kreuzer [Mon, 9 Jun 2008 18:10:02 +0000 (18:10 +0000)]
add simple TTF icon to fontview

svn path=/trunk/; revision=33908

14 years ago- Fix Ellipes, for Filip Navara, nice work!
James Tabor [Mon, 9 Jun 2008 16:46:52 +0000 (16:46 +0000)]
- Fix Ellipes, for Filip Navara, nice work!
- Ref:
- Test:

svn path=/trunk/; revision=33907

14 years agoMove old pie code into arc.
James Tabor [Sun, 8 Jun 2008 19:00:50 +0000 (19:00 +0000)]
Move old pie code into arc.

svn path=/trunk/; revision=33906

14 years ago- Update dciddi.h header based on Magnus's patch.
Aleksey Bragin [Sun, 8 Jun 2008 18:26:22 +0000 (18:26 +0000)]
- Update dciddi.h header based on Magnus's patch.
- Fix dciman32.dll compilation.

svn path=/trunk/; revision=33905

14 years agoSynced shlwapi_winetest.exe with Wine HEAD
Pierre Schweitzer [Sun, 8 Jun 2008 17:14:50 +0000 (17:14 +0000)]
Synced shlwapi_winetest.exe with Wine HEAD

svn path=/trunk/; revision=33904

14 years agoSySynced shlwapi.dll with Wine HEAD
Pierre Schweitzer [Sun, 8 Jun 2008 17:13:54 +0000 (17:13 +0000)]
SySynced shlwapi.dll with Wine HEAD

svn path=/trunk/; revision=33903

14 years ago- Remove duplicate code
Dmitry Chapyshev [Sun, 8 Jun 2008 15:04:00 +0000 (15:04 +0000)]
- Remove duplicate code
- Fix formatting
- Add checking parameters for more functions

svn path=/trunk/; revision=33902

14 years ago- User properties:
Eric Kohl [Sun, 8 Jun 2008 13:34:42 +0000 (13:34 +0000)]
- User properties:
  Fix a memory leak.
  Enable the Apply button when the users full name or description is changed.
- Group properties:
  The group description can be changed.
  Update the group list when the group description changes.

svn path=/trunk/; revision=33901

14 years agoFix debug message
Hervé Poussineau [Sun, 8 Jun 2008 09:52:56 +0000 (09:52 +0000)]
Fix debug message

svn path=/trunk/; revision=33899

14 years ago- Add gdiplus test to bootcd
Dmitry Chapyshev [Sun, 8 Jun 2008 09:49:48 +0000 (09:49 +0000)]
- Add gdiplus test to bootcd

svn path=/trunk/; revision=33898

14 years ago- Add wine test for gdiplus
Dmitry Chapyshev [Sun, 8 Jun 2008 09:47:47 +0000 (09:47 +0000)]
- Add wine test for gdiplus

svn path=/trunk/; revision=33897

14 years agoadd dummy test for dciman32 for now, real test will come later
Magnus Olsen [Sun, 8 Jun 2008 08:29:04 +0000 (08:29 +0000)]
add dummy test for dciman32 for now, real test will come later

svn path=/trunk/; revision=33896

14 years ago- Magnus: Reformat clip.c source code to better match overall coding style. No code...
Aleksey Bragin [Sun, 8 Jun 2008 07:31:10 +0000 (07:31 +0000)]
- Magnus: Reformat clip.c source code to better match overall coding style. No code logic change.

svn path=/trunk/; revision=33895

14 years agoUpdate NtUserInitializeClientPfnArrays add additional structures and types for future...
James Tabor [Sun, 8 Jun 2008 03:34:25 +0000 (03:34 +0000)]
Update NtUserInitializeClientPfnArrays add additional structures and types for future support.

svn path=/trunk/; revision=33894

14 years agoFix some region leaks: GdiSelectVisRgn copies the region, so the given one it must...
Timo Kreuzer [Sun, 8 Jun 2008 00:43:07 +0000 (00:43 +0000)]
Fix some region leaks: GdiSelectVisRgn copies the region, so the given one it must be deleted afterwards. This code is not perfect ~ as Jim already said, not completed. But it's at least working correctly now. Say welcome to a stable running Firefox 1.5.
Also added some DPRINTs on failures.

svn path=/trunk/; revision=33893

14 years agoReal fix for the broken netapi32.dll.
Eric Kohl [Sat, 7 Jun 2008 22:50:55 +0000 (22:50 +0000)]
Real fix for the broken netapi32.dll.

svn path=/trunk/; revision=33892

14 years agoFix for broken netapi32.dll.
Eric Kohl [Sat, 7 Jun 2008 22:44:15 +0000 (22:44 +0000)]
Fix for broken netapi32.dll.

svn path=/trunk/; revision=33891

14 years ago- Group properties: Display the SID of well-known members.
Eric Kohl [Sat, 7 Jun 2008 22:31:24 +0000 (22:31 +0000)]
- Group properties: Display the SID of well-known members.
- User properties: Store changes to the general settings.

svn path=/trunk/; revision=33890

14 years agoWrite the complete error message to debug log, instead of partial information
Hervé Poussineau [Sat, 7 Jun 2008 20:44:57 +0000 (20:44 +0000)]
Write the complete error message to debug log, instead of partial information

svn path=/trunk/; revision=33889

14 years ago- Cleanup leftovers and bugs from GreatLord's fix. I think this is my last "postfix...
Aleksey Bragin [Sat, 7 Jun 2008 12:58:48 +0000 (12:58 +0000)]
- Cleanup leftovers and bugs from GreatLord's fix. I think this is my last "postfix" of GreatLord's commits to trunk.

svn path=/trunk/; revision=33886

14 years agoBugFix : NtGdiStretchDIBitsInternal
Magnus Olsen [Sat, 7 Jun 2008 11:35:53 +0000 (11:35 +0000)]
BugFix : NtGdiStretchDIBitsInternal
it did not check after some NULL pointer and did crash in firefox.
and some reason  NtGdiCreateCompatibleBitmap fail in some case, that what happen in firefox 1.5.

svn path=/trunk/; revision=33885

14 years agofix one winetest for Bitmap and add note why some alpha blend test fails.
Magnus Olsen [Sat, 7 Jun 2008 10:15:38 +0000 (10:15 +0000)]
fix one winetest for Bitmap and add note why some alpha blend test fails.

svn path=/trunk/; revision=33884

14 years agoFixed Alphablend crash in win32k
Magnus Olsen [Sat, 7 Jun 2008 09:43:35 +0000 (09:43 +0000)]
Fixed Alphablend crash in win32k

svn path=/trunk/; revision=33883

14 years ago- Revert 33881, PatBlt may be buggy, but what was introduced in 33881 was a non-worki...
Aleksey Bragin [Sat, 7 Jun 2008 09:20:05 +0000 (09:20 +0000)]
- Revert 33881, PatBlt may be buggy, but what was introduced in 33881 was a non-working hack. Unregresses FF2.0 installer having a black rectangle in the bottom of its window.

svn path=/trunk/; revision=33882

14 years agodisable NtGdiPatBlt code, in some case it can cause random crash and have some graphi...
Magnus Olsen [Sat, 7 Jun 2008 07:58:39 +0000 (07:58 +0000)]
disable NtGdiPatBlt code, in some case it can cause random crash and have some graphic glichters it need be rewrite.

svn path=/trunk/; revision=33881

14 years agorevert some change I did in r33877 for buch.c object it cause to many regress
Magnus Olsen [Sat, 7 Jun 2008 07:22:09 +0000 (07:22 +0000)]
revert some change I did in r33877 for buch.c object it cause to many regress

svn path=/trunk/; revision=33880

14 years agoThis does fix bug 3237. I've run this patch for two months now, it is still in the...
James Tabor [Sat, 7 Jun 2008 02:58:15 +0000 (02:58 +0000)]
This does fix bug 3237. I've run this patch for two months now, it is still in the rough and needs cleaning up. Separates Owned and Class styles and gives them their own DCes.

svn path=/trunk/; revision=33879

14 years agosmall cleanup thx irc: aicom for notice this.
Magnus Olsen [Sat, 7 Jun 2008 01:18:55 +0000 (01:18 +0000)]
small cleanup thx irc: aicom for notice this.

svn path=/trunk/; revision=33878

14 years agoadd a NULL check in IntGdiInitBrushInstance if XlateObj is NULL fall back to use...
Magnus Olsen [Sat, 7 Jun 2008 01:14:12 +0000 (01:14 +0000)]
add a NULL check in IntGdiInitBrushInstance if XlateObj is NULL fall back to use white as default color when GDIBRUSH_IS_SOLID are set.

svn path=/trunk/; revision=33877

14 years agoBitBlt
Magnus Olsen [Sat, 7 Jun 2008 00:51:38 +0000 (00:51 +0000)]
Make it act bit more like windows, use PatBlt instead for BitBlt for no ROP source for it bit faster
Thx irc Goplat found my bug in the macro.

svn path=/trunk/; revision=33876

14 years agoBugFix : NtGdiPatBlt did not call on NtGdiMaskBlt when source have been set in ROP
Magnus Olsen [Fri, 6 Jun 2008 23:37:41 +0000 (23:37 +0000)]
BugFix : NtGdiPatBlt did not call on NtGdiMaskBlt when source have been set in ROP

svn path=/trunk/; revision=33873

14 years agoBugFix : NtGdiBitblt follow member BitmapDest and BitmapSrc one of them can be NULL...
Magnus Olsen [Fri, 6 Jun 2008 23:09:42 +0000 (23:09 +0000)]
BugFix : NtGdiBitblt follow member BitmapDest and BitmapSrc one of them can be NULL in NtGdiBitBlt logic so do not try access members in null pointer

svn path=/trunk/; revision=33872

14 years ago- Fix KDBG's EIP munging.
Aleksey Bragin [Fri, 6 Jun 2008 21:51:21 +0000 (21:51 +0000)]
- Fix KDBG's EIP munging.
- Don't make single-step break into KDBG if it comes from user-mode.
- Don't make KDBG return "continue" for breakpoint/singlestep, it should return "do not handle exception".
- Add 20 new invalid instructions detected instead of crashing/"UNHANDLED CODE".
- Fix DR registry handling (set DebugActive = TRUE when needed, and set Context->Dr7).
- Fix set/get context: These two functions didn't work at all. Get actually performed a Set, and Vice-versa. Also, Set would incorrectly set the frame of the caller, not the target thread. Also, the trap frame pointer wasn't being grabbed correctly for kernel-mode callers.
- Move the code to a non-portable i386 directory, since the code is architecture-specific.
- Move GET_SET_CTX_CONTENT out to ps.h.

svn path=/trunk/; revision=33871

14 years ago- Fix a major bug while closing a process that was debugging another process, which...
Aleksey Bragin [Fri, 6 Jun 2008 21:43:37 +0000 (21:43 +0000)]
- Fix a major bug while closing a process that was debugging another process, which would cause a bugcheck because it tried to kill itself while it was being killed -- instead, it should try killing the debuggee! fixes the bug that arty and I fought about when he said "process killing seems broken" and tried to add delayed-object-closing. Patch by Alex Ionescu.
- Remove a leftover from kernel32 which assumed that if "BeingDebugged" was TRUE, the library was being tested on an XP machine.

svn path=/trunk/; revision=33870

14 years ago- Change the registry name from Registry to REGISTRY, which fixes almost all Wine...
Aleksey Bragin [Fri, 6 Jun 2008 21:40:37 +0000 (21:40 +0000)]
- Change the registry name from Registry to REGISTRY, which fixes almost all Wine registry tests and any other application using the registry in case-sensitive mode, because the real name is REGISTRY.
- Add SEH to NtCreate/OpenKey, which fixes the rest of the wine registry tests.
- Fix PnP Manager code that was doing case sensitive registry access with "Registry".

svn path=/trunk/; revision=33869

14 years ago- Update RtlIsTextUnicode (fixes some ntdll rtlstr winetests).
Aleksey Bragin [Fri, 6 Jun 2008 21:33:43 +0000 (21:33 +0000)]
- Update RtlIsTextUnicode (fixes some ntdll rtlstr winetests).

svn path=/trunk/; revision=33868

14 years ago- Sync tahoma fonts with wine head
Dmitry Chapyshev [Fri, 6 Jun 2008 19:40:27 +0000 (19:40 +0000)]
- Sync tahoma fonts with wine head

svn path=/trunk/; revision=33867

14 years ago- Update many parts of CRT, and misc cleanup.
Aleksey Bragin [Fri, 6 Jun 2008 17:49:24 +0000 (17:49 +0000)]
- Update many parts of CRT, and misc cleanup.
- Largely based on the patch by Samuel Serapion.
- Include file.c from Wine's msvcrt, but exclude its contents from the build process for now.

svn path=/trunk/; revision=33866

14 years ago- Move scanf.c into strings, it belongs there.
Aleksey Bragin [Fri, 6 Jun 2008 12:20:28 +0000 (12:20 +0000)]
- Move scanf.c into strings, it belongs there.
- Move thread.c to process, and remove outdated/duplicated copy.
- Sync threadx with Wine.
- Update README.WINE accordingly.

svn path=/trunk/; revision=33865

14 years ago- Fix a typo.
Aleksey Bragin [Fri, 6 Jun 2008 11:26:14 +0000 (11:26 +0000)]
- Fix a typo.

svn path=/trunk/; revision=33864

14 years agoAttempt to fix bug 3259. Use IntGdiCleanDC for error checking.
James Tabor [Fri, 6 Jun 2008 02:59:12 +0000 (02:59 +0000)]
Attempt to fix bug 3259. Use IntGdiCleanDC for error checking.

svn path=/trunk/; revision=33863

14 years agocommit 33747 did remove almost all redirect to ntdll and to some internal functions...
Magnus Olsen [Thu, 5 Jun 2008 23:51:27 +0000 (23:51 +0000)]
commit 33747 did remove almost all redirect to ntdll and to some internal functions, I re add thuse redirect
also by mistake   _seh_longjmp_unwind was not longer redirected to  seh_longjmp_unwind it is now again
thx irc nick : Goplat to notice this.

svn path=/trunk/; revision=33862

14 years agopatch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat):
Timo Kreuzer [Thu, 5 Jun 2008 22:23:19 +0000 (22:23 +0000)]
patch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat):
fix coordinate transformation for NtGdiSetDIBitsToDevice,
fixes bug 3200
See issue #3294 for more details.

svn path=/trunk/; revision=33861

14 years agoco_MsqTranslateMouseMessage:
Timo Kreuzer [Thu, 5 Jun 2008 16:57:27 +0000 (16:57 +0000)]
- add a comment about who removes a message from a queue
- fix filter handling (typo)
- correct the callers next list entry, if it might have been deleted. Yes, it's ugly, but the only way I could currently think of without rewriting everything and it was already ugly before. This fixes bug 2317 and some random crashes with FF.
See issue #2317 for more details.

svn path=/trunk/; revision=33860

14 years agoIntEngGradientFill: don't assert, if no CLIPOBJ is given, instead handle this case...
Timo Kreuzer [Thu, 5 Jun 2008 00:23:27 +0000 (00:23 +0000)]
IntEngGradientFill: don't assert, if no CLIPOBJ is given, instead handle this case in EngGradientFill, creating a CLIPOBJ from bounds rect.

svn path=/trunk/; revision=33859

14 years agoThis should do it for pen. Tested the same with wine tests.
James Tabor [Wed, 4 Jun 2008 21:05:18 +0000 (21:05 +0000)]
This should do it for pen. Tested the same with wine tests.

svn path=/trunk/; revision=33858

14 years agoSorry, I should have spotted this when I was in here.. I think this takes care of...
James Tabor [Wed, 4 Jun 2008 17:45:18 +0000 (17:45 +0000)]
Sorry, I should have spotted this when I was in here.. I think this takes care of the leak and crash. Wine testing is back with the same errors. So we are good to go.

svn path=/trunk/; revision=33857

14 years ago- fix mem leak when failing to create an extpen with penstyles
Timo Kreuzer [Wed, 4 Jun 2008 16:15:24 +0000 (16:15 +0000)]
- fix mem leak when failing to create an extpen with penstyles
- rename a tag, change a tag, remove unused tag

svn path=/trunk/; revision=33856

14 years agoPrevent a crash if the list is empty and check for zero. If (List is Empty! DCE!...
James Tabor [Wed, 4 Jun 2008 16:07:47 +0000 (16:07 +0000)]
Prevent a crash if the list is empty and check for zero. If (List is Empty! DCE!) is called before the crash, this means we have a thread that is not finished running before shutdown. There is a proper way for handling this

svn path=/trunk/; revision=33855

14 years ago- libcntpr does not need console/file versions of scanf.
Aleksey Bragin [Wed, 4 Jun 2008 10:52:54 +0000 (10:52 +0000)]
- libcntpr does not need console/file versions of scanf.

svn path=/trunk/; revision=33854

14 years ago- Fix crtdll build.
Aleksey Bragin [Wed, 4 Jun 2008 10:41:17 +0000 (10:41 +0000)]
- Fix crtdll build.

svn path=/trunk/; revision=33853

14 years ago- Misc cleanup of kmtest.
Aleksey Bragin [Wed, 4 Jun 2008 09:50:19 +0000 (09:50 +0000)]
- Misc cleanup of kmtest.
- Add paged/nonpaged pools test routines.
- Comment out invocations of other tests temporary.

svn path=/trunk/; revision=33852