reactos.git
4 years ago[USBAUDIO] Fix compilation issues
Oleg Dubinskiy [Thu, 1 Aug 2019 20:37:35 +0000 (23:37 +0300)]
[USBAUDIO] Fix compilation issues

4 years ago[DEVMGR] Fix wonky action menu
Eric Kohl [Sat, 3 Aug 2019 12:53:00 +0000 (14:53 +0200)]
[DEVMGR] Fix wonky action menu

Patch by Pi_User5.

CORE-10364

4 years ago[FONTS][SETUP] Add Franklin Gothic Medium fonts (#1786)
Katayama Hirofumi MZ [Sat, 3 Aug 2019 10:03:27 +0000 (19:03 +0900)]
[FONTS][SETUP] Add Franklin Gothic Medium fonts (#1786)

Add "Franklin Gothic Medium" fonts. CORE-16272

- Add "Franklin Gothic Medium" and "Franklin Gothic Medium Italic" fonts by duplicating Alexei Vanyashin's "Libre Franklin" fonts and renaming them.
- Delete some "Franklin Gothic Medium" font substitutes.
- Add LICENSE file.

I made these font files by using FontForge. Their family name is "Franklin Gothic Medium". Their display names are "Franklin Gothic Medium" and "Franklin Gothic Medium Italic". Their font filenames are framd.ttf and framdit.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

Alexei Vanyashin's "Libre Franklin" fonts are available at https://github.com/alexeiva/Libre-Franklin .

4 years ago[FONTS][SETUP] Add Palatino Linotype fonts (#1785)
Katayama Hirofumi MZ [Sat, 3 Aug 2019 07:24:32 +0000 (16:24 +0900)]
[FONTS][SETUP] Add Palatino Linotype fonts (#1785)

Add "Palatino Linotype" fonts. CORE-16272

- Add "Palatino Linotype", "Palatino Linotype Bold", "Palatino Linotype Bold Italic" and "Palatino Linotype Italic" fonts by duplicating "DejaVu Serif" fonts and renaming them.
- Delete some "Palatino Linotype" font substitutes.
- Add LICENSE file.

I made these font files by using FontForge. Their family name is "Palatino Linotype". Their display names are "Palatino Linotype", "Palatino Linotype Bold", "Palatino Linotype Bold Italic" and "Palatino Linotype Italic". Their font filenames are pala.ttf, palab.ttf, palabi.ttf and palai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

4 years ago[FONTS] s/Geogia/Georgia/
Katayama Hirofumi MZ [Sat, 3 Aug 2019 02:28:10 +0000 (11:28 +0900)]
[FONTS] s/Geogia/Georgia/

4 years ago[FONTS][SETUP] Add Geogia fonts (#1784)
Katayama Hirofumi MZ [Sat, 3 Aug 2019 01:43:09 +0000 (10:43 +0900)]
[FONTS][SETUP] Add Geogia fonts (#1784)

Add "Geogia" fonts. CORE-16272

- Add "Geogia", "Geogia Bold", "Geogia Bold Italic" and "Geogia Italic" fonts by duplicating FreeSerif fonts and renaming them.
- Delete some "Geogia" font substitutes.
- Add LICENSE file.

I made these font files by using FontForge. Their family name is "Geogia". Their display names are "Geogia", "Geogia Bold", "Geogia Bold Italic" and "Geogia Italic". Their font filenames are georgia.ttf, georgiab.ttf, georgiaz.ttf and georgiai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

4 years ago[FONTS][BOOTDATA][SETUP] Add Courier New fonts (#1783)
Katayama Hirofumi MZ [Sat, 3 Aug 2019 00:05:14 +0000 (09:05 +0900)]
[FONTS][BOOTDATA][SETUP] Add Courier New fonts (#1783)

Add "Courier New" fonts. CORE-16272

- Add "Courier New", "Courier New Bold", "Courier New Bold Italic" and "Courier New Italic" fonts by duplicating FreeMono fonts and renaming them.
- Delete some "Courier New" font substitutes.
- Add LICENSE file.

I made these font files by using FontForge. Their family name is "Courier New". Their display names are "Courier New", "Courier New Bold", "Courier New Bold Italic" and "Courier New Italic". Their font filenames are cour.ttf, courbd.ttf, courbi.ttf and couri.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

4 years ago[FONTS][SETUP][BOOTDATA] Add Arial fonts (#1781)
Katayama Hirofumi MZ [Fri, 2 Aug 2019 11:37:53 +0000 (20:37 +0900)]
[FONTS][SETUP][BOOTDATA] Add Arial fonts (#1781)

Add Arial fonts. CORE-16272

- Add "Arial", "Arial Bold", "Arial Bold Italic" and "Arial Italic" fonts by duplicating Liberation Sans fonts and renaming them.
- Disable some Arial font substitutes.
- Add LICENSE file.

I made these font files by using FontForge. Their family name is "Arial". Their display names are "Arial", "Arial Bold", "Arial Bold Italic" and "Arial Italic". Their font filenames are arial.ttf, arialbd.ttf, arialbi.ttf and ariali.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

4 years ago[WIN32SS][NTGDI] Improve IntGetOutlineTextMetrics (#1760)
Katayama Hirofumi MZ [Fri, 2 Aug 2019 11:28:30 +0000 (20:28 +0900)]
[WIN32SS][NTGDI] Improve IntGetOutlineTextMetrics (#1760)

Improve size checking of IntGetOutlineTextMetrics function.

4 years ago[KERNEL32] Minor enhancements for CreateRemoteThread(). (#804) 804/head
Hermès Bélusca-Maïto [Thu, 23 Aug 2018 19:44:53 +0000 (21:44 +0200)]
[KERNEL32] Minor enhancements for CreateRemoteThread(). (#804)

- Add some cleanup code in failure code paths, instead of asserting.
- Move BasepNotifyCsrOfThread() helper to the only file where it is used.
- Don't use ERROR_DBGBREAK in failure paths but just DPRINT the error
  message: we handle the failures properly.
- When creating the remote thread, sync its service tag with the parent
  thread's one.

4 years ago[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. (#802) 802/head
Hermès Bélusca-Maïto [Thu, 26 May 2016 02:44:25 +0000 (04:44 +0200)]
[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. (#802)

- kernel32!BaseCreateStack() is compatible with ntdll!RtlpCreateUserStack().
- When checking whether a stack guard page can be added, its size has to
  be accounted for in the checking logic.
- We have to satisfy the PEB::MinimumStackCommit constraint.
- We cannot use PEB::GuaranteedStackBytes in BaseCreateStack() since it is
  nowhere initialized (default is 0). It gets initialized to a non-zero
  value when the user manually calls SetThreadStackGuarantee().
  https://www.installsetupconfig.com/win32programming/windowsthreadsprocessapis7_6.html

- RtlpCreateUserStack(): Fix memory leak in failure case.
- RtlpFreeUserStack() doesn't need to return anything.

See also commit 1bc59379 (r59868).

CORE-11319

4 years ago[MEDIA][FONTS] Add Hebrew MS Sans Serif (ssee1255.fon)
Katayama Hirofumi MZ [Thu, 1 Aug 2019 03:29:43 +0000 (12:29 +0900)]
[MEDIA][FONTS] Add Hebrew MS Sans Serif (ssee1255.fon)

4 years ago[WIN32SS][NTGDI][NTUSER] Make gusLanguageID USHORT (#1776)
Katayama Hirofumi MZ [Wed, 31 Jul 2019 13:24:01 +0000 (22:24 +0900)]
[WIN32SS][NTGDI][NTUSER] Make gusLanguageID USHORT (#1776)

Every language ID is an unsigned integer.

- Make gusLanguageID unsigned.
- Make the return value type of UserGetLanguageID unsigned.

4 years ago[FREETYPE] Improve font rendering with font hinting workaround (#1771)
Katayama Hirofumi MZ [Wed, 31 Jul 2019 12:57:42 +0000 (21:57 +0900)]
[FREETYPE] Improve font rendering with font hinting workaround (#1771)

CORE-15762, CORE-16232
It seems some fonts are blurry or in bad rendering because of FreeType Font Hinting implementation.
This PR is subpixel2.patch from CORE-16232, based on the following comment:
https://bugs.launchpad.net/ubuntu/+source/freetype/+bug/1722508/comments/29

4 years ago[SETUP] Add codepage-specific font substitutes (#1772)
Katayama Hirofumi MZ [Wed, 31 Jul 2019 08:43:08 +0000 (17:43 +0900)]
[SETUP] Add codepage-specific font substitutes (#1772)

Add codepage-specific font substitutes for i18n. CORE-16266

4 years ago[INTL] Addendum to CORE-16252
Joachim Henze [Tue, 30 Jul 2019 23:58:42 +0000 (01:58 +0200)]
[INTL] Addendum to CORE-16252

That change was not intended.in
commit 0.4.13-dev-740-g
8b67edd8fa2b51d7d5a710e8867123246b72f524

Thx to Stas'M for noticing the windres warning.

4 years ago[INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252
Joachim Henze [Tue, 30 Jul 2019 21:12:24 +0000 (23:12 +0200)]
[INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252

v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaafbccb0e9b52926d41626d5a4dc38cd

Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.

4 years ago[LSASRV] Improvements to LsapLogonUser()
Eric Kohl [Tue, 30 Jul 2019 21:09:32 +0000 (23:09 +0200)]
[LSASRV] Improvements to LsapLogonUser()

- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.

4 years ago[CONFIGURE] Add MSVC compiler 19.22.27905 (VS Community 2019) (#1774)
Stanislav Motylkov [Tue, 30 Jul 2019 21:01:23 +0000 (00:01 +0300)]
[CONFIGURE] Add MSVC compiler 19.22.27905 (VS Community 2019) (#1774)

4 years ago[SETUP] Sort font substitutes (#1770)
Katayama Hirofumi MZ [Tue, 30 Jul 2019 13:05:11 +0000 (22:05 +0900)]
[SETUP] Sort font substitutes (#1770)

Sort the font substitute setting lists in base/setup/lib/muifonts.h .

4 years ago[SETUP] Delete 'Comic Sans MS' font substitutes (#1769)
Katayama Hirofumi MZ [Tue, 30 Jul 2019 10:09:23 +0000 (19:09 +0900)]
[SETUP] Delete 'Comic Sans MS' font substitutes (#1769)

Enable real 'Comic Sans MS' font by deleting the 'Comic Sans MS' font substitutes. CORE-16251

4 years ago[WIN32SS][NTGDI] Fix and improve font dumping (#1768)
Katayama Hirofumi MZ [Tue, 30 Jul 2019 09:15:56 +0000 (18:15 +0900)]
[WIN32SS][NTGDI] Fix and improve font dumping (#1768)

Fix and improve font dumping. CORE-16245
- FontGDI->FontObj is not a pointer.
- "%s" does null check, so we remove redundant null checks.
- Add FaceName and StyleName dumping.

4 years ago[FREELDR] Improve some *GetFileInformation() traces.
Hermès Bélusca-Maïto [Mon, 29 Jul 2019 22:57:22 +0000 (00:57 +0200)]
[FREELDR] Improve some *GetFileInformation() traces.

4 years ago[FREELDR] Fix remaining hwdisk and FATX bugs (#1766)
Stanislav Motylkov [Mon, 29 Jul 2019 22:27:36 +0000 (01:27 +0300)]
[FREELDR] Fix remaining hwdisk and FATX bugs (#1766)

- DiskGetFileInformation() should return relative addresses -- relative to the beginning of the "device" (partition, or disk) in question.
- FatXSearchDirectoryBufferForFile() should assign file attributes.
- Minor code style improvements in FatOpenVolume().

CORE-16216 CORE-16248

Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
4 years ago[KBDHU] Fix Hungarian keyboard layout. (#1765)
Tibor Lajos Füzi [Mon, 29 Jul 2019 19:55:24 +0000 (21:55 +0200)]
[KBDHU] Fix Hungarian keyboard layout. (#1765)

CORE-15567

4 years ago[NtGDI] Fix one size region test.
jimtabor [Mon, 29 Jul 2019 18:02:07 +0000 (13:02 -0500)]
[NtGDI] Fix one size region test.

See CORE-16246, the clip region may be the same size but more complex
than the callers simple region.

4 years ago[FREELDR] Implement proper partition type detection and handling (#1762)
Stanislav Motylkov [Mon, 29 Jul 2019 12:25:54 +0000 (15:25 +0300)]
[FREELDR] Implement proper partition type detection and handling (#1762)

- This allows to detect and dynamically handle different partitioning schemes.
- Implemented detection of MBR, GPT, Xbox-BRFR, and partitionless disks.
- Currently only MBR and Xbox-BRFR partitions are handled and tested.

CORE-9841 CORE-15768 CORE-16216 CORE-16248

4 years ago[USER32] Fix build after 51d031cc ; addendum to f21871fb (r69249) and cf98f01e (r7265...
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 23:38:10 +0000 (01:38 +0200)]
[USER32] Fix build after 51d031cc ; addendum to f21871fb (r69249) and cf98f01e (r72650). CORE-10194

4 years ago[MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHour...
Eric Kohl [Sun, 28 Jul 2019 22:10:26 +0000 (00:10 +0200)]
[MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing.

4 years ago[USER32] Use the correct __REACTOS__ define.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:32:14 +0000 (00:32 +0200)]
[USER32] Use the correct __REACTOS__ define.

4 years ago[NDK] Use the correct __REACTOS__ define.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:31:56 +0000 (00:31 +0200)]
[NDK] Use the correct __REACTOS__ define.

4 years ago[NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position...
Jose Carlos Jesus [Sun, 28 Jul 2019 22:20:40 +0000 (23:20 +0100)]
[NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761)

4 years ago[PSDK] ks.h : Fix some IOCTL values, caught by Ben Nottelling.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:20:07 +0000 (00:20 +0200)]
[PSDK] ks.h : Fix some IOCTL values, caught by Ben Nottelling.

4 years ago[W32TIME] Use an event to stop the service
Eric Kohl [Sun, 28 Jul 2019 20:37:17 +0000 (22:37 +0200)]
[W32TIME] Use an event to stop the service

CORE-16180

4 years ago[FREELDR] Trivial improvements (#1757)
Stanislav Motylkov [Sun, 28 Jul 2019 16:20:53 +0000 (19:20 +0300)]
[FREELDR] Trivial improvements (#1757)

* [FREELDR] Fix uninitialized string in DiskGetBootPath()

CORE-16216 CORE-16248

* [FREELDR] xboxdisk: Add comment and fix code style

4 years ago[DLLs] Fix .spec files regarding OLE-specific exports. 1601/head
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:23:02 +0000 (00:23 +0200)]
[DLLs] Fix .spec files regarding OLE-specific exports.

- Do not use hardcoded ordinals, add missing '-private'.
  Except for MSXML3, OLE32 and RSAENH, see commit bff824b2 for more details.

- SHSVCS: The 6 first exports are nonamed with ordinals. Replace exported
  commented stubs by actual exported stubs instead.

Co-Authored-By: Timo Kreuzer <timo.kreuzer@reactos.org>
4 years ago[SPEC2DEF] Check whether OLE-specific exports do not have assigned ordinals, as they...
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:11:18 +0000 (00:11 +0200)]
[SPEC2DEF] Check whether OLE-specific exports do not have assigned ordinals, as they should be.

The check is done at the same time as when we check also that these
exports are marked PRIVATE or not.

This permits us to check for the same conditions as MS' LINK.EXE, but
here on GCC builds as well.

See the following pages for more details:
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4104
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4222

In this last page (LNK4222), the specified list of exports is incomplete.
Manual tests showed that the very same list as for LNK4104 is checked.

4 years ago[MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and...
Eric Kohl [Sun, 28 Jul 2019 12:57:46 +0000 (14:57 +0200)]
[MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete.

4 years ago[GDI32] Allow functions to access printing support.
jimtabor [Sat, 27 Jul 2019 19:15:42 +0000 (14:15 -0500)]
[GDI32] Allow functions to access printing support.

Reapplying lost committed code.

4 years ago[GDI32] Add more to Local DC structure.
jimtabor [Sat, 27 Jul 2019 19:13:14 +0000 (14:13 -0500)]
[GDI32] Add more to Local DC structure.

Make the two structures identical. These are used for printing and
enhanced metafile support.

4 years ago[PSDK] Add missing UnregisterDeviceNotification() to winuser.h.
Eric Kohl [Sat, 27 Jul 2019 17:59:32 +0000 (19:59 +0200)]
[PSDK] Add missing UnregisterDeviceNotification() to winuser.h.

4 years ago[AUDIOSVC] Fix the coding style. No code changes!
Eric Kohl [Sat, 27 Jul 2019 14:54:15 +0000 (16:54 +0200)]
[AUDIOSVC] Fix the coding style. No code changes!

4 years ago[USETUP] Use "L" key instead of "D" for deleting partitions at 1st setup stage
Oleg Dubinskiy [Fri, 28 Jun 2019 13:45:32 +0000 (16:45 +0300)]
[USETUP] Use "L" key instead of "D" for deleting partitions at 1st setup stage

4 years ago[REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result...
Timo Kreuzer [Sun, 26 May 2019 11:37:31 +0000 (13:37 +0200)]
[REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result still unsigned

4 years ago[WIN32SS] Addendum to font alignment CORE-16133
Joachim Henze [Sat, 27 Jul 2019 08:00:42 +0000 (10:00 +0200)]
[WIN32SS] Addendum to font alignment CORE-16133

addendum to 0.4.13-dev-707-g
0e4db883e5727569b5c3a35da3a6f8c5e921bbf3

Jim Tabor intended to structurally use flTextAlign over
lTextAlign internally within IntExtTextOutW().
He initially committed these changes in 0.4.12-dev-805-g
3377fe184efa77e7c4971c2ac70ed33ab12f0724

But we unintentionally lost these changes via 0.4.13-dev-370-g
8f482af0a876d269cca64288f114eb1fe1180ef0

Many thanks to Doug Lyons who helped a lot with fixing CORE-16133.

4 years ago[MEDIA][FONTS] Add Comic Sans MS fonts (comic.ttf, comicbd.ttf) (#1754)
Katayama Hirofumi MZ [Sat, 27 Jul 2019 05:53:06 +0000 (14:53 +0900)]
[MEDIA][FONTS] Add Comic Sans MS fonts (comic.ttf, comicbd.ttf) (#1754)

Add Comic Sans MS font files. CORE-16237

Add "Comic Relief" fonts by Jeff Davis under SIL Open Font License in the name of "Comic Sans MS". We cannot choose Comic Sans MS currently but it's font engine's bug.

4 years ago[WINHLP32] All the lang resource files are in UTF-8.
Hermès Bélusca-Maïto [Fri, 26 Jul 2019 12:53:03 +0000 (14:53 +0200)]
[WINHLP32] All the lang resource files are in UTF-8.

4 years ago[USER32_APITEST] Add #include 'precomp.h' in MessageStateAnalyzer
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:45:11 +0000 (21:45 +0900)]
[USER32_APITEST] Add #include 'precomp.h' in MessageStateAnalyzer

4 years ago[USER32_APITEST] Move <strsafe.h> #inclusion
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:30:36 +0000 (21:30 +0900)]
[USER32_APITEST] Move <strsafe.h> #inclusion

4 years ago[WIN32SS][NTGDI] text/font vertical alignment patch CORE-16133
Katayama Hirofumi MZ [Fri, 26 Jul 2019 10:13:00 +0000 (19:13 +0900)]
[WIN32SS][NTGDI] text/font vertical alignment patch CORE-16133

Based on Doug Lyons' patch. It partially fix CORE-16246 and CORE-16133.
Selection area is not fixed yet.

4 years ago[CODEOWNERS] Add UniATA (#1689)
Serge Gautherie [Wed, 24 Jul 2019 17:59:07 +0000 (19:59 +0200)]
[CODEOWNERS] Add UniATA (#1689)

4 years ago [TRANSLATION] Hebrew Translations For Setup (#1750)
Shy Zedaka [Wed, 24 Jul 2019 17:56:48 +0000 (20:56 +0300)]
 [TRANSLATION] Hebrew Translations For Setup (#1750)

4 years ago[DSOUND_NEW] Remove unused dsound_convert.c file (#1748)
Oleg Dubinskiy [Wed, 24 Jul 2019 17:56:33 +0000 (20:56 +0300)]
[DSOUND_NEW] Remove unused dsound_convert.c file (#1748)

4 years ago[USER32_APITEST][INCLUDE] Add MessageStateAnalyzer testcase (#1732)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:45:55 +0000 (01:45 +0900)]
[USER32_APITEST][INCLUDE] Add MessageStateAnalyzer testcase (#1732)

I want to visualize the message stream and verify the states of each message. ROSTESTS-328

- Add a testcase named MessageStateAnalyzer into user32_apitest.
- Also fix type casts in <windowsx.h>.

4 years ago[USER32][NTUSER] Fix menu arrow drawing (of DrawFrameControl) (#1752)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:40:33 +0000 (01:40 +0900)]
[USER32][NTUSER] Fix menu arrow drawing (of DrawFrameControl) (#1752)

CORE-13211
user32!DrawFrameControl drawed invalid menu arrow when the width is shorter than the height.

- Use the squared rectangle.
- Draw it in the transparent background mode.
- Save the old background mode of HDC.

This PR will fix UltraISO's bug.

4 years ago[MEDIA][FONTS] RAPPS checkmark fix (#1751)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 06:39:10 +0000 (15:39 +0900)]
[MEDIA][FONTS] RAPPS checkmark fix (#1751)

The checkmarks of RAPPS were strange. This PR will fix the checkmark ("b") of 12px bitmap glyph of Marlett.ttf font file. CORE-14872

4 years ago[MEDIA][FONTS] Add copyright notice of TransGaming Technologies
Katayama Hirofumi MZ [Tue, 23 Jul 2019 12:55:38 +0000 (21:55 +0900)]
[MEDIA][FONTS] Add copyright notice of TransGaming Technologies

With some font error fixed. CORE-16226

4 years ago[MEDIA][FONTS] Renewal of Marlett.ttf (#1749)
Katayama Hirofumi MZ [Tue, 23 Jul 2019 07:03:30 +0000 (16:03 +0900)]
[MEDIA][FONTS] Renewal of Marlett.ttf (#1749)

Renewal of Marlett.ttf font file. CORE-16226, CORE-14872

- Based on Ged Murphy's Marlett.ttf (See https://github.com/reactos/reactos/blob/527f2f90577662e8eba1b1b62f958c39b3cd4358/media/fonts/Marlett.ttf).
- Erase the centered triangles.
- Adjustment of glyphs.
- Clarify the copyright ownership.
- Tested with 3 test programs (RadioAndCheck, PixelPerfectGlyph and MarlettCompare).

4 years ago[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. ... 1684/head
Doug-Lyons [Sat, 22 Jun 2019 16:23:11 +0000 (11:23 -0500)]
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684)
CORE-16123

- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
  their non-volatile counterparts.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
4 years ago[UMPNPMGR] Implement registry functions for SuppressUI and SuppressNewHWUI handling... 1683/head
Bișoc George [Wed, 19 Jun 2019 15:51:11 +0000 (17:51 +0200)]
[UMPNPMGR] Implement registry functions for SuppressUI and SuppressNewHWUI handling. (#1683)
CORE-15897

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
4 years ago[SRVSVC][WKSSVC] Set the stop pending status before stopping the services and stop...
Eric Kohl [Sun, 21 Jul 2019 16:56:02 +0000 (18:56 +0200)]
[SRVSVC][WKSSVC] Set the stop pending status before stopping the services and stop the RPC listener on shutdown as well.

4 years ago[WMISERV][WUAUSERV] Stop the service if the stop event creation fails.
Eric Kohl [Sun, 21 Jul 2019 16:51:33 +0000 (18:51 +0200)]
[WMISERV][WUAUSERV] Stop the service if the stop event creation fails.

4 years ago[TRANSLATIONS] Update Turkish translations (#1650)
Erdem Ersoy [Sun, 21 Jul 2019 15:49:12 +0000 (18:49 +0300)]
[TRANSLATIONS] Update Turkish translations (#1650)

Translations for Solitaire, Spider, WinMine, Notepad, Wordpad & Write, MSPaint, MPlay32, SndRec32, WinHlp32, SndVol32, TaskMgr and Calc.

4 years ago[W32TIME] Use a reasonable fallback of 9 hours. (#1724) 1724/head
Benjamin Aerni [Sat, 13 Jul 2019 06:42:10 +0000 (23:42 -0700)]
[W32TIME] Use a reasonable fallback of 9 hours. (#1724)
CORE-16181

This allows preventing spamming the time servers if the registry entry
becomes corrupted or missing. Also, disallow a setting of less than
2 minutes for the same reasons, and instead use the fallback of 9 hours.

4 years ago[DSOUND_NEW] Completely fix gcc compilation (addendum to 25e98eb). (#1740) 1740/head
Oleg Dubinskiy [Fri, 19 Jul 2019 13:32:07 +0000 (16:32 +0300)]
[DSOUND_NEW] Completely fix gcc compilation (addendum to 25e98eb). (#1740)
CORE-16128

4 years ago[OSK] Use new coordinates on keyboard layout changing (#1745)
Bișoc George [Sun, 21 Jul 2019 14:52:25 +0000 (16:52 +0200)]
[OSK] Use new coordinates on keyboard layout changing (#1745)

CORE-16214

4 years ago[WIN32SS][GDI] Assume pso->sizlBitmap.cy positiveness (#1743)
Katayama Hirofumi MZ [Sun, 21 Jul 2019 12:39:05 +0000 (21:39 +0900)]
[WIN32SS][GDI] Assume pso->sizlBitmap.cy positiveness (#1743)

We assume pso->sizlBitmap.cy is positive. CORE-15995

Because pso->sizlBitmap.cy is certificated as a positive value after initialization in SURFACE_AllocSurface, so we can safely omit abs and labs (absolute) function calls for it.

4 years ago[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094 1607/head
Michael Maltsev [Mon, 3 Jun 2019 09:35:58 +0000 (12:35 +0300)]
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094

4 years ago[MEDIA][FONTS] Shrink Marlett.ttf file size
Katayama Hirofumi MZ [Sun, 21 Jul 2019 06:17:02 +0000 (15:17 +0900)]
[MEDIA][FONTS] Shrink Marlett.ttf file size

4 years ago[FONTS][NTGDI] Change Marlett.ttf charset and delete charset hacks
Katayama Hirofumi MZ [Sun, 21 Jul 2019 03:59:06 +0000 (12:59 +0900)]
[FONTS][NTGDI] Change Marlett.ttf charset and delete charset hacks

4 years ago[MSCONFIG][ROSAPPS] Remove explicit MINGW_HAS_SECURE_API since it is already enabled...
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 23:06:54 +0000 (01:06 +0200)]
[MSCONFIG][ROSAPPS] Remove explicit MINGW_HAS_SECURE_API since it is already enabled globally. CORE-16224

4 years ago[WIN32K:NTGDI] Improve allocated resources cleanup in failure paths of IntGdiLoadFont...
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 22:47:58 +0000 (00:47 +0200)]
[WIN32K:NTGDI] Improve allocated resources cleanup in failure paths of IntGdiLoadFontsFromMemory().

- Use an auxiliary list where we add the new enumerated faces, for easy
  roll-back in case a failure happens during font loading. Only at the
  very end when font loading has been successfully done, the auxiliary
  list is appended to the corresponding global or per-proceess font list.

- Perform actual cleanup in case of failures.

- Introduce CleanupFontEntryEx() helper to simplify cleanup in
  IntGdiLoadFontsFromMemory() in failure paths; implement
  CleanupFontEntry() around it.

Additions:

- Perform string buffer NULL check in IntGdiAddFontResource().
- Reorder memory unmapping and section object dereferencing in
  IntGdiAddFontResource().
- Move DuplicateUnicodeString() upwards.
- Mark explicitly the Marlett font handling hacks.

4 years ago[SRVSVC] Make the server service stoppable.
Eric Kohl [Sat, 20 Jul 2019 20:48:17 +0000 (22:48 +0200)]
[SRVSVC] Make the server service stoppable.

4 years ago[WKSSVC] Make the workstation service stoppable.
Eric Kohl [Sat, 20 Jul 2019 20:43:39 +0000 (22:43 +0200)]
[WKSSVC] Make the workstation service stoppable.

4 years ago[WUAUSERV] Make the wuauserv service startable and stoppable.
Eric Kohl [Sat, 20 Jul 2019 17:27:22 +0000 (19:27 +0200)]
[WUAUSERV] Make the wuauserv service startable and stoppable.

4 years ago[WIN32SS][NTGDI] Support raster fonts (*.fnt and *.fon) (#1739)
Katayama Hirofumi MZ [Sat, 20 Jul 2019 14:47:29 +0000 (23:47 +0900)]
[WIN32SS][NTGDI] Support raster fonts (*.fnt and *.fon) (#1739)

Add raster font (*.fnt and *.fon files) support. CORE-16165

- Add IntGetCharSet() function to get the charset by index and/or the number of charsets.
- Make IntGdiLoadFontsFromMemory() a non-recursive function.
- IntGetOutlineTextMetrics() accepts raster fonts.
- Improve CharMap handling (especially TT_PLATFORM_APPLE_UNICODE).
- Write the raster font file info to the registry.
- Don't request font size for raster fonts in IntRequestFontSize() function.

4 years ago[WMISVC] Accept stop and shutdown commands when the service is running.
Eric Kohl [Sat, 20 Jul 2019 13:50:35 +0000 (15:50 +0200)]
[WMISVC] Accept stop and shutdown commands when the service is running.

4 years ago[GEN_BASEADDRESS] Add framebuf.dll and framebuf_new.dll to exclude ist in gen_baseadd...
Timo Kreuzer [Wed, 1 May 2019 07:44:33 +0000 (09:44 +0200)]
[GEN_BASEADDRESS] Add framebuf.dll and framebuf_new.dll to exclude ist in gen_baseaddress.py

4 years ago[TOOLS] Make gen_baseaddress.py python 3 compatible
Timo Kreuzer [Mon, 29 Apr 2019 15:00:18 +0000 (17:00 +0200)]
[TOOLS] Make gen_baseaddress.py python 3 compatible

4 years ago[CMAKE] Update base addresses
Timo Kreuzer [Mon, 29 Apr 2019 14:07:06 +0000 (16:07 +0200)]
[CMAKE] Update base addresses

4 years ago[NTOSKRNL] Replace overlapping strcopy with memmove
Timo Kreuzer [Sun, 28 Apr 2019 18:23:35 +0000 (20:23 +0200)]
[NTOSKRNL] Replace overlapping strcopy with memmove

Fixes 4 GCC 8 warnings of the kind:
ntoskrnl/kdbg/kdb_cli.c:3015:21: error: 'strcpy' accessing 1 byte at offsets 0 and [0, 2147483647] may overlap 1 byte at offset 0 [-Werror=restrict]
                     strcpy(p2, p2 + j);
                     ^~~~~~~~~~~~~~~~~~

4 years ago[CRT] Use sprintf_s instead of sprintf
Timo Kreuzer [Sun, 28 Apr 2019 16:27:22 +0000 (18:27 +0200)]
[CRT] Use sprintf_s instead of sprintf

Fixes GCC 8 warning:
sdk/lib/crt/misc/i10output.c:83:25: error: '%d' directive writing between 1 and 11 bytes into a region of size 6 [-Werror=format-overflow=]
     sprintf(format, "%%.%dle", prec);
                         ^~
sdk/lib/crt/misc/i10output.c:83:21: note: directive argument in the range [-21474836482147483646]
     sprintf(format, "%%.%dle", prec);
                     ^~~~~~~~~
sdk/lib/crt/misc/i10output.c:83:5: note: 'sprintf' output between 6 and 16 bytes into a destination of size 8
     sprintf(format, "%%.%dle", prec);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[VFATLIB] Use RtlStringCbPrintfA instead of sprintf
Timo Kreuzer [Sun, 28 Apr 2019 18:38:25 +0000 (20:38 +0200)]
[VFATLIB] Use RtlStringCbPrintfA instead of sprintf

Fixes GCC 8 warning:
sdk/lib/fslib/vfatlib/check/boot.c:173:27: error: '%02x' directive writing between 2 and 8 bytes into a region of size between 0 and 15 [-Werror=format-overflow=]
   sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
                           ^~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:16: note: directive argument in the range [0, 2147483647]
   sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
                ^~~~~~~~~~~~~~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:3: note: 'sprintf' output between 8 and 31 bytes into a destination of size 20
   sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    (unsigned)(p - (uint8_t *) b), *p, *q);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[OLEAUT32] Use snprintf instead of sprintf
Timo Kreuzer [Sun, 28 Apr 2019 16:07:51 +0000 (18:07 +0200)]
[OLEAUT32] Use snprintf instead of sprintf

Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
                                       ^~                     ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[FREELDR] Use RtlStringCbPrintfA instead of sprintf
Timo Kreuzer [Sun, 28 Apr 2019 15:48:58 +0000 (17:48 +0200)]
[FREELDR] Use RtlStringCbPrintfA instead of sprintf

Fixes GCC 8 warnings like:
boot/freeldr/freeldr/disk/scsiport.c:806:31: error: 'partition(0)' directive writing 12 bytes into a region of size between 1 and 64 [-Werror=format-overflow=]
     sprintf(PartitionName, "%spartition(0)", ArcName);
                               ^~~~~~~~~~~~
boot/freeldr/freeldr/disk/scsiport.c:806:5: note: 'sprintf' output between 13 and 76 bytes into a destination of size 64
     sprintf(PartitionName, "%spartition(0)", ArcName);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[FASTFAT] Copy an entire field, instead of half-copying it with RtlCopyMemory
Timo Kreuzer [Sun, 28 Apr 2019 13:50:08 +0000 (15:50 +0200)]
[FASTFAT] Copy an entire field, instead of half-copying it with RtlCopyMemory

Fixes GCC 8 warning:
sdk/include/crt/mingw32/intrin_x86.h:76:12: error: 'memmove' offset [21, 40] from the object at 'DirContext' is out of the bounds of referenced subobject 'Attrib' with type 'unsigned char' at offset 19 [-Werror=array-bounds]
     return memmove(dest, source, num);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[FRAMEDYN] Fix broken asm (.code64 is for x64 only)
Timo Kreuzer [Sun, 28 Apr 2019 12:49:31 +0000 (14:49 +0200)]
[FRAMEDYN] Fix broken asm (.code64 is for x64 only)

4 years ago[KERNEL32] Improve path name handling
Timo Kreuzer [Sat, 27 Apr 2019 16:58:08 +0000 (18:58 +0200)]
[KERNEL32] Improve path name handling

Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
                 strncat(PathBuffer, "\\twain_32.dll", 13);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[MSPAINT] Don't use SIZEOF on a pointer
Timo Kreuzer [Sat, 27 Apr 2019 16:53:59 +0000 (18:53 +0200)]
[MSPAINT] Don't use SIZEOF on a pointer

Fixes GCC 8 warning:
base/applications/mspaint/definitions.h:16:31: error: division 'sizeof (LPWSTR {aka wchar_t*}) / sizeof (WCHAR {aka wchar_t})' does not compute the number of array elements [-Werror=sizeof-pointer-div]
 #define SIZEOF(a)  (sizeof(a) / sizeof((a)[0]))
                     ~~~~~~~~~~^~~~~~~~~~~~~~~~
base/applications/mspaint/main.cpp:134:55: note: in expansion of macro 'SIZEOF'
                 lstrcpyn(pon->lpOFN->lpstrFile, Path, SIZEOF(pon->lpOFN->lpstrFile));
                                                       ^~~~~~

4 years ago[MSGINA] Fix copying the TokenSource string
Timo Kreuzer [Sat, 27 Apr 2019 16:42:21 +0000 (18:42 +0200)]
[MSGINA] Fix copying the TokenSource string

TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "User32  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[ADVAPI32] Fix copying the TokenSource string
Timo Kreuzer [Sat, 27 Apr 2019 14:05:40 +0000 (16:05 +0200)]
[ADVAPI32] Fix copying the TokenSource string

TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "Advapi  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 years ago[PSDK] Remove default value for BSTR parameter in msxml2.idl
Timo Kreuzer [Mon, 3 Jun 2019 07:14:21 +0000 (09:14 +0200)]
[PSDK] Remove default value for BSTR parameter in msxml2.idl

Fixes GCC 8 warning:
In file included from base/applications/msconfig_new/xmldomparser.hpp:26,
                 from base/applications/msconfig_new/toolspage.cpp:11:
sdk/include/psdk/msxml2.h:12705:20: error: ISO C++ forbids converting a string constant to 'BSTR' {aka 'wchar_t*'} [-Werror=write-strings]
         BSTR uri = L"x") = 0;
                    ^~~~

4 years ago[PSDK][CRT] Add some casts to make GCC 8 happy
Timo Kreuzer [Mon, 3 Jun 2019 07:07:36 +0000 (09:07 +0200)]
[PSDK][CRT] Add some casts to make GCC 8 happy

4 years ago[PSDK] Add DECLSPEC_SELECTANY to GUIDs to make GCC 8 happy
Timo Kreuzer [Sat, 27 Apr 2019 20:16:49 +0000 (22:16 +0200)]
[PSDK] Add DECLSPEC_SELECTANY to GUIDs to make GCC 8 happy

4 years ago[CMAKE] Globally enable secure CRT functions
Timo Kreuzer [Mon, 29 Apr 2019 07:56:29 +0000 (09:56 +0200)]
[CMAKE] Globally enable secure CRT functions

"This is what Windows does" (tm)

4 years ago[CRT] Remove _wctime_s from time.h
Timo Kreuzer [Sun, 28 Apr 2019 20:05:32 +0000 (22:05 +0200)]
[CRT] Remove _wctime_s from time.h

4 years ago[CMAKE] Define _GLIBCXX_HAVE_BROKEN_VSWPRINTF to fix build with GLIBCXX and our c...
Timo Kreuzer [Mon, 29 Apr 2019 08:02:13 +0000 (10:02 +0200)]
[CMAKE] Define _GLIBCXX_HAVE_BROKEN_VSWPRINTF to fix build with GLIBCXX and our c++ headers

4 years ago[CMAKE] Disable some overly sensitive warnings
Timo Kreuzer [Sun, 28 Apr 2019 20:17:19 +0000 (22:17 +0200)]
[CMAKE] Disable some overly sensitive warnings

-Wno-unused-const-variable
-Wno-unused-local-typedefs
-Wno-deprecated

4 years ago[ACPICA] Update to version 20190703. CORE-16202
Thomas Faber [Sun, 14 Jul 2019 09:01:36 +0000 (11:01 +0200)]
[ACPICA] Update to version 20190703. CORE-16202

4 years ago[TRANSLATION] Hebrew Translation for Services (#1741)
Shy Zedaka [Fri, 19 Jul 2019 15:08:33 +0000 (18:08 +0300)]
[TRANSLATION] Hebrew Translation for Services (#1741)