Andrei Miloiu [Sun, 21 May 2023 12:40:49 +0000 (15:40 +0300)]
[EXPLORER] Update Romanian translation (#5294)
Andrei Miloiu [Sun, 21 May 2023 12:37:26 +0000 (15:37 +0300)]
[DESK] Update Romanian translation (#5298)
Andrei Miloiu [Sun, 21 May 2023 12:31:12 +0000 (15:31 +0300)]
[FC] Update Romanian translation (#5292)
Andrei Miloiu [Sun, 21 May 2023 12:30:01 +0000 (15:30 +0300)]
[DISKPART] Update Romanian translation (#5296)
Doug Lyons [Sun, 21 May 2023 09:18:00 +0000 (04:18 -0500)]
[SHELL32][USER32] Fix icon regression and one test (#5207)
Jose Carlos Jesus [Sat, 20 May 2023 18:48:30 +0000 (14:48 -0400)]
[UTILMAN] Fix content order in IDC_LISTBOX (#5289)
OSK et Magnify are mixed at initialization (language dependent),
LBS_STANDARD includes LBS_SORT style that changes the content in the listbox.
Patch by KRosUser.
CORE-18274
Philippe Morin [Sat, 20 May 2023 18:45:05 +0000 (20:45 +0200)]
[TRANSLATION][BROWSEUI] Improve French (fr-FR) translation (#5295)
CORE-18914
Stanislav Motylkov [Sat, 20 May 2023 12:02:04 +0000 (15:02 +0300)]
[UTILMAN] Fix resource file headers. No code changes.
Addendum to
636f2e32.
Andrei Miloiu [Sat, 20 May 2023 15:44:56 +0000 (18:44 +0300)]
[SOLITAIRE] Update Romanian translation (#5293)
Jose Carlos Jesus [Fri, 19 May 2023 08:27:19 +0000 (04:27 -0400)]
[UTILMAN] Add Portuguese (pt-PT) translation (#5290)
Dmitry Borisov [Thu, 18 May 2023 18:05:50 +0000 (00:05 +0600)]
[FREELDR] Fix builds for PC-98 and Xbox platforms (#5275)
Fix broken build after UEFI support merge.
Addendum to commit
150f72127.
CORE-11954, CORE-16216, CORE-17977
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Thu, 18 May 2023 10:43:23 +0000 (12:43 +0200)]
[ATTRIB] Improve command-line parsing. (#5288)
Fix arguments parsing and redundant code in case no file specification
has been given.
(Handles both "attrib" and "attrib +h /s" as given in example.)
Jose Carlos Jesus [Thu, 18 May 2023 10:16:49 +0000 (06:16 -0400)]
[REGEDIT] Creating a new Key should add a new entry even when no child exist. CORE-18878 (#5274)
- Avoid using a NULL pointer when My Computer is selected, by disabling the New Key menu item.
- Simplifies and fix code style in GetItemPath function.
- Add a new entry even when no child items exist.
CORE-18878
Hermès Bélusca-Maïto [Thu, 18 May 2023 10:12:39 +0000 (12:12 +0200)]
[ATTRIB] Simplify the ErrorMessage() function.
And send the errors to the error stream.
Hermès Bélusca-Maïto [Sat, 13 May 2023 20:49:10 +0000 (22:49 +0200)]
[ATTRIB] Reorganize resource file headers.
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Hermès Bélusca-Maïto [Sun, 20 Mar 2022 21:55:06 +0000 (22:55 +0100)]
[NTOS:LPC] Ensure debug-traced pointer-given user-mode data is captured. (#4399)
CORE-18098
Hermès Bélusca-Maïto [Sun, 20 Mar 2022 21:53:25 +0000 (22:53 +0100)]
[NTOS:LPC] Turn a DPRINT1 into an LPCTRACE. (#4399)
CORE-18098
Hermès Bélusca-Maïto [Wed, 17 May 2023 13:48:10 +0000 (15:48 +0200)]
[KERNEL32] CreateProcessInternalW: Initialize uninitialized ClientId.
This situation happens when either of the two "goto VdmShortCircuit;"
code paths are taken when starting a DOS or WoW16 app.
Hermès Bélusca-Maïto [Wed, 17 May 2023 11:56:12 +0000 (13:56 +0200)]
[KERNEL32] Minor comments improvements in CreateProcessInternalW.
Thamatip Chitpong [Wed, 17 May 2023 10:41:28 +0000 (17:41 +0700)]
[TASKMGR] Add status bar description for "Properties" and "Open File Location" menu items (#5280)
Also fix access key collision for en-US/el-GR.
Timo Kreuzer [Wed, 10 May 2023 17:28:20 +0000 (20:28 +0300)]
[NTOS:KE/x64] Fix KiConvertToGuiThread
- Do not allocate a new stack, if the thread already has a large one. This prevents the function from freeing a large stack as a normal stack and subsequently leaking system PTEs.
- Fix the check for failure of PsConvertToGuiThread (test eax, not rax, for being negative, because by default rax is zero extended from eax, not sign extended). This fixes an infinite loop on failure.
Timo Kreuzer [Fri, 12 May 2023 19:28:54 +0000 (22:28 +0300)]
[USER32_APITEST] Add tests for GetClassInfo
Timo Kreuzer [Fri, 12 May 2023 19:35:55 +0000 (22:35 +0300)]
[USER32_APITEST] Add tests for [Get|Set]Window[Word|Long|LongPtr]
Hermès Bélusca-Maïto [Wed, 29 Dec 2021 00:05:00 +0000 (01:05 +0100)]
[RAPPS] Centralize RAPPS exposed names: registry & user local settings (#4214)
Centralize the names of the RAPPS' registry setting sub-key, and
user local settings & offline apps database sub-directories.
- Change the name of the application database sub-directory from
"rapps\rapps" to "RApps\appdb".
- Adjust the documentation to reflect this.
- Simplify CConfigParser constructor by removing GetINIFullPath().
Jose Carlos Jesus [Thu, 11 May 2023 14:28:59 +0000 (10:28 -0400)]
[CPL:INPUT] Fix "Dvorak" typo in all .rc files (#5277)
CORE-18843
Katayama Hirofumi MZ [Thu, 11 May 2023 04:01:02 +0000 (13:01 +0900)]
[APPWIZ] start_params: Simplify using L"..."
Katayama Hirofumi MZ [Thu, 11 May 2023 03:27:18 +0000 (12:27 +0900)]
[ADVAPI32_APITEST] IsTextUnicode: Use __LINE__ to identify test entry
CORE-18837
Stanislav Motylkov [Wed, 10 May 2023 18:28:47 +0000 (20:28 +0200)]
[NTOS:PNP] IopEnumerateDetectedDevices(): Fix CmResourceList leak
CORE-18962
Katayama Hirofumi MZ [Wed, 10 May 2023 11:24:21 +0000 (20:24 +0900)]
[NTUSER] Implement THREADSTATE_CHECKCONIME (#5272)
- Add THREADSTATE_CHECKCONIME handling in NtUserGetThreadState function.
CORE-11700
Hermès Bélusca-Maïto [Sun, 26 Dec 2021 03:05:10 +0000 (04:05 +0100)]
[RAPPS] Cleanup headers inclusions (#4206)
Katayama Hirofumi MZ [Wed, 10 May 2023 05:04:01 +0000 (14:04 +0900)]
[IMM32][NTUSER][SDK] Add ImmCallImeConsoleIME (#5271)
- Add <jpnvkeys.h>.
- Add imm32!ImmCallImeConsoleIME.
CORE-11700
Stanislav Motylkov [Mon, 8 May 2023 13:50:21 +0000 (15:50 +0200)]
[NTOS:PNP] IopEnumerateDetectedDevices(): Formatting only
CORE-18962
Stanislav Motylkov [Mon, 8 May 2023 13:49:46 +0000 (15:49 +0200)]
[NTOS:PNP] Move Firmware Mapper functions into new file
CORE-18962
Hermès Bélusca-Maïto [Sun, 7 May 2023 20:13:03 +0000 (22:13 +0200)]
[FREELDR] PeLdrLoadImage: FileName -> FilePath and make it const.
Katayama Hirofumi MZ [Sun, 7 May 2023 13:55:46 +0000 (22:55 +0900)]
[KERNEL32][SDK] RegisterConsoleIME and UnregisterConsoleIME (#5270)
The conime.exe program exists in WinXP/Win2k3 and it realizes Console IME. conime.exe calls kernel32!RegisterConsoleIME and kernel32!UnregisterConsoleIME. To realize Console IME, these two functions are required. CORE-11700
Artyom Ovsyannikov [Sun, 5 Mar 2023 14:49:00 +0000 (14:49 +0000)]
[TASKMGR][TASKKILL][HIVESYS] Russian translation update (#5120)
Philippe Morin [Fri, 5 May 2023 19:32:40 +0000 (21:32 +0200)]
[TRANSLATION][DESK.CPL] Improve French translation (#5218)
Thamatip Chitpong [Wed, 5 Oct 2022 01:33:28 +0000 (08:33 +0700)]
[WINLOGON] Implement logoff and MessageBeep sounds support (#4755)
CORE-13951
Thamatip Chitpong [Wed, 5 Oct 2022 04:51:06 +0000 (11:51 +0700)]
[REACTOS] Add converted sound files (#4755)
CORE-13951
Add ReactOS_Critical_Stop.wav and ReactOS_Notify.wav
Dmitry Borisov [Fri, 5 May 2023 16:04:35 +0000 (22:04 +0600)]
[NTOS:CM] Initialize the alternative system architecture field on PC-98 builds (#5136)
This is needed by some 3rd party drivers.
CORE-17977
Thamatip Chitpong [Fri, 5 May 2023 12:19:34 +0000 (19:19 +0700)]
[WINMM] Winmm fixes for system sound (#4635)
CORE-13951
MIDIMAP_LoadSettings and PlaySound:
Use RegOpenCurrentUser to access the appropriate HKEY_CURRENT_USER key.
This allows functions that use HKEY_CURRENT_USER to be called from system
processes while impersonating, for example: winlogon.
PlaySound:
- Open the correct registry key.
- Expand environment strings if registry value type is REG_EXPAND_SZ.
- Handle "SystemDefault" event and improve flags handling.
- Don't use proc_PlaySound as thread proc.
- Fix SND_ASYNC flag for system processes.
Move get_mmio* code out of proc_PlaySound to fix impersonation problem.
Tom Brogan [Fri, 5 May 2023 11:35:32 +0000 (07:35 -0400)]
[SHELL32] Improve disk properties pie chart (#5239)
CORE-18906
- Increase the vertical height of the disk space pie chart and center
the "Drive %c" label below it.
- Add a 1 pixel outline at the sides and bottom of the disk properties
pie chart.
- Explicitly set the outline pen instead of relying on the DC's default pen.
- Widen "Disk Cleanup" button on ja-JP locale, to prevent the text from
being clipped due to the larger font size and spacing.
Splitwirez [Fri, 5 May 2023 11:32:44 +0000 (07:32 -0400)]
[THEMES] Several fixes for Lautus style (#5253)
- CheckBoxes now show checkmarks when checked;
- Titlebar text alignment is now consistent between restored/maximized windows;
- 2-column Start Menu header now shows its intended background image.
Joachim Henze [Fri, 5 May 2023 11:30:21 +0000 (13:30 +0200)]
[REGEDIT] de-DE.rc Fix accelerator collision (#5265)
Alt+D in german translation is already reserved for the file menu "&Datei"
in ROS and in MS Windows, thus we cannot use the same as accelerator
for focusing the address bar.
So for german we will use Alt+S instead, which is the same shortcut that
german MS+ROS explorer use for focusing their address bar.
This is an addendum to commit
f908d37bb from PR #4885
which broke the german file-menu accelerator.
Katayama Hirofumi MZ [Fri, 5 May 2023 08:00:05 +0000 (17:00 +0900)]
[NTUSER] Remember old KL for Chinese IMEs (#5266)
The Chinese user uses Ctrl+Space key combination to switch between the IME keyboard and the non-IME keyboard. To enable Ctrl+Space, the system has to remember the previous keyboard layout. In IntImmActivateLayout function, remember the previous keyboard layout (hklPrev) to switch back for Chinese IMEs. CORE-18950
Timo Kreuzer [Fri, 14 Apr 2023 10:07:11 +0000 (13:07 +0300)]
[NTOS:KDBG] Only load symbols on x86
Symbol loading leads to a hang on x64 boot in 2nd stage and KDBG symbols don't work on x64 anyway.
Justin Miller [Wed, 3 May 2023 18:56:06 +0000 (11:56 -0700)]
[FREELDR][SDK] Build UEFI bootloader for ARM32 (#5196)
CORE-17604
- Disable some functions for ARM32;
- Remove some link options not used on ARM;
- Add get _controlfp() to LIBCNTPR to link properly on ARM;
- Unify Freeldr UI Drawing on ARM;
- Add qemu UART debugging for ARM32/ARM64.
Katayama Hirofumi MZ [Tue, 2 May 2023 22:45:35 +0000 (07:45 +0900)]
[KBSWITCH] Rely on GetKeyboardLayoutList for getting list (#5263)
- Use GetKeyboardLayoutList to get the keyboard list instead of using Preload registry key.
- Get the special IDs from registry to handle special HKLs in newly-added LoadSpecialIds function.
- Add GetKLIDFromHKL, GetHKLFromLayoutNum, UpdateLayoutList, and GetKLIDFromLayoutNum helper functions.
CORE-13145, CORE-10667, CORE-18924
Katayama Hirofumi MZ [Tue, 2 May 2023 22:39:05 +0000 (07:39 +0900)]
[EXPLORER][RUNDLL32] Restore minimized non-task windows (#5228)
The minimized non-task windows were not usable due to the bugs. In some situations, the system will restore the minimized non-task windows.
- Add IsTaskWnd helper function.
- Add SendPulseToTray function to send a pulse to the tray window.
- At some shell hook handlings, send a pulse to the tray window.
- Add IgnorePulse flag to control the timing of restoring.
- Add a timer to reset IgnorePulse flag.
- If the pulse has come and IgnorePulse flag is false, then restore the minimized non-task windows.
- Modify the rundll32 window procedure.
- Use WINDOWPLACEMENT to restore the minimized windows.
CORE-13895, CORE-18350
Joachim Henze [Mon, 1 May 2023 14:50:01 +0000 (16:50 +0200)]
[REGEDIT] Strip redundant include, minor formatting (#5264)
strsafe.h is already included via regedit.h
Vincent Franchomme [Sun, 30 Apr 2023 16:26:30 +0000 (18:26 +0200)]
[EXT2FS] Align with upstream and mark ReactOS diff (#5245)
NOTE: There are no new features in this PR, we stay with upstream version 0.69.
CORE-18645
- Add ifdefs to distinguish ReactOS code/fixes from the upstream code;
- If upstream code was overriden, reintroduce it in #else section;
- Re-align .rc version info with upstream (0.69).
Jose Carlos Jesus [Sun, 30 Apr 2023 13:40:10 +0000 (14:40 +0100)]
[SHELL32] Enable Network Connection Rename (#5073)
CORE-18750
- Add Network Connection pidl type 0x99;
- Add binary comparison to pidl memory range.
Doug Lyons [Sun, 30 Apr 2023 13:34:26 +0000 (08:34 -0500)]
[SETUPAPI] Sync setupapi/queue.c to Wine 4.8 (#5233)
Sync setupapi/queue.c to Wine 4.8 to improve cab extraction.
This fixes 'fixme:(dll/win32/setupapi/queue.c:418) awful hack: extracting cabinet'
Jose Carlos Jesus [Sun, 30 Apr 2023 13:21:20 +0000 (14:21 +0100)]
[COMDLG32] Enable saving files with different extension (#4903)
As on Windows, gives precedence to the user's extension in file names if there is one.
Otherwise appends the selected extension. If not selected, append default extension.
Justin Miller [Sun, 30 Apr 2023 12:57:10 +0000 (05:57 -0700)]
[FREELDR] Add disk access handlers for UEFI (#5219)
CORE-11953
Joachim Henze [Sat, 29 Apr 2023 21:02:03 +0000 (23:02 +0200)]
[E1000] Stop logging MAC, is sensitive data of log-contributors (#5254)
Katayama Hirofumi MZ [Fri, 28 Apr 2023 22:28:56 +0000 (07:28 +0900)]
[KBSWITCH] Delete SHLoadRegUIString hack (#5260)
Because shlwapi!SHLoadRegUIString function is already implemented, so we don't need the hack any more. CORE-10667
Katayama Hirofumi MZ [Fri, 28 Apr 2023 22:27:54 +0000 (07:27 +0900)]
[INPUT] Remove fake SHLoadRegUIStringW hack (#5258)
Because shlwapi!SHLoadRegUIStringW function is already implemented, so we don't need the hack any more. CORE-11700
Katayama Hirofumi MZ [Fri, 28 Apr 2023 12:48:45 +0000 (21:48 +0900)]
[NOTEPAD] Delete my name from resource copyright text (#5261)
The copyright text was too long. CORE-18837
Katayama Hirofumi MZ [Thu, 27 Apr 2023 23:28:57 +0000 (08:28 +0900)]
[RICHED20] RichEdit: CompForm and CandForm (#5257)
Correctly display the composition window and the candidate window.
- At update_caret function, set the position and font of the composition window.
- We don't use internal composition string. Rely on the composition window.
- Improve WM_IME_SETCONTEXT, WM_IME_CONTROL, WM_IME_SELECT, WM_IME_STARTCOMPOSITION, WM_IME_COMPOSITION and WM_IME_ENDCOMPOSITION message handlings.
CORE-11700
Mark Jansen [Wed, 19 Apr 2023 18:27:31 +0000 (20:27 +0200)]
[ATL] Take _ATL_FREE_THREADED into account
When it is not defined, COM should not be initialize multithreaded
Katayama Hirofumi MZ [Thu, 27 Apr 2023 11:35:41 +0000 (20:35 +0900)]
[ADVPACK_APITEST] Add advpack_apitest:DelNode testcase (#5256)
Preparation for advpack!DelNodeA/W functions implementation. CORE-13275, ROSTESTS-276
Mark Jansen [Wed, 19 Apr 2023 18:30:24 +0000 (20:30 +0200)]
[SHELL32] Implement SHQueryRecycleBinW
Mark Jansen [Wed, 12 Apr 2023 21:25:36 +0000 (23:25 +0200)]
[ATL] Add CAtlList::SwapElements
Katayama Hirofumi MZ [Tue, 25 Apr 2023 09:04:36 +0000 (18:04 +0900)]
[REGEDIT] Check whether pszSelectKey is NULL on CDN_FILEOK (#5255)
Avoid crash on exporting root. Add NULL check of pszSelectKey on CDN_FILEOK handling. CORE-18938
Thamatip Chitpong [Mon, 24 Apr 2023 18:11:46 +0000 (01:11 +0700)]
[NTUSER] Improve MsqPostMessage (#5225)
- MsqPostMessage: Fill Message structure before InsertTailList. For style consistency.
- MsqPostMessage: Fix the use of MessageQueue variable
Mark Jansen [Sat, 15 Apr 2023 20:22:07 +0000 (22:22 +0200)]
[ATL_APITEST] Add test for OBJECT_ENTRY_AUTO
CORE-18936
Mark Jansen [Sat, 15 Apr 2023 20:21:33 +0000 (22:21 +0200)]
[ATL] Add OBJECT_ENTRY_AUTO for simpler com object registration
Of course gcc needs a nasty hack to include the symbol.
CORE-18936
Mark Jansen [Wed, 19 Apr 2023 18:44:01 +0000 (20:44 +0200)]
[PSDK] Add some more argument names
George Bișoc [Sat, 22 Apr 2023 15:18:57 +0000 (17:18 +0200)]
[NTOS:OB] Fix the SAL2 annotation of ObQueryTypeInfo
The data has to be written into ObjectTypeInfo based on the return length,
not only what is provided by the input buffer length. Fix suggested by
Hermès.
George Bișoc [Sat, 15 Apr 2023 10:55:32 +0000 (12:55 +0200)]
[NTOS:OB] Properly calculate the return length in ObQueryTypeInfo
On a x86 system aligning the return length pointer to a 4-byte boundary
works best since pointers in general are 4-byte aligned for x86 systems.
However, what happens on a AMD64 system is that we still align this pointer
to 4-byte, ObjectTypeInfo is a 8-byte pointer and we might write into
the return length past the 4-byte boundary.
If one were to allocate a pool of memory with that length and query all
the object types info and free the said pool of memory thereafter, the
system will crash with BAD_POOL_HEADER because ObQueryTypeInfo overwrote
the return length past the 4-byte boundary length therefore leading up with
corrupted memory blocks in the pool header.
This symptom of BAD_POOL_HEADER happens exactly the same in Windows Server
2003 x64 Edition. Newer versions of Windows like 10 aren't affected.
But, Windows has another bug where they are using MaximumLength for the
calculation of the needed length to be returned to caller. MaximumLength
does not guarantee you that it includes the NULL-terminator in the length
and that potentially leads to a buffer overrun.
Also annotate the ObQueryTypeInfo function with SAL2.
https://processhacker.sourceforge.io/doc/object_8c_source.html (read the
comment in KphObjectTypeInformation).
Atharva Kulkarni [Fri, 21 Apr 2023 10:44:31 +0000 (16:14 +0530)]
[SCSIPORT] Flush and Free Map Registers (#5190)
- Flush Map registers once the DMA completes
- Free Map registers once the DMA completes
- Add support for SGL allocated from NonPagedPool
Test:
Force Allocations of SGL from Non Paged Pool and ensure OS boots and functions properly
Test Logs:
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
DHCPCSVC: Adapter Name: [{
7cd69ac0-dabb-410a-b927-
cb3961d174da}] (dynamic)
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
WARNING: HalCalculateScatterGatherListSize at hal\halx86\generic\dma.c:1168 is UNIMPLEMENTED!
SpiAdapterControlFORCING ALLOCATION FROM SGPOOL
SpiAdapterControlFORCING ALLOCATION FROM SGPOO
Adam Słaboń [Wed, 19 Apr 2023 21:12:11 +0000 (23:12 +0200)]
[NTOS:MM] MmCanFileBeTruncated: Check whether second (optional) parameter was passed (#5248)
Second parameter is optional, so mark it as such and check whether it was passed. Fixes a sporadic 0x24 bugcheck caused by access violation when running ReactOS on NTFS volume with WinXP ntfs.sys.
Vincent Franchomme [Tue, 18 Apr 2023 08:03:16 +0000 (10:03 +0200)]
[I8042PRT] Add Dell Latitude D410 to the hack list (#5246)
Mark Jansen [Mon, 17 Apr 2023 11:38:00 +0000 (13:38 +0200)]
[GITHUB] Add Labeler rule for ATL
Mark Jansen [Mon, 17 Apr 2023 11:37:45 +0000 (13:37 +0200)]
[GITHUB] Add Labeler rule for shell stuff
Mark Jansen [Wed, 12 Apr 2023 20:21:41 +0000 (22:21 +0200)]
[ATL] Add CString::AppendFormat
Timo Kreuzer [Fri, 3 Feb 2023 16:26:49 +0000 (18:26 +0200)]
[USER32_APITEST] Comment out a test for GetMessageTime that randomly fails on Windows
Timo Kreuzer [Fri, 3 Feb 2023 16:18:14 +0000 (18:18 +0200)]
[JSCRIPT_WINETEST] Disable a test that fails on Windows 2003
Timo Kreuzer [Fri, 3 Feb 2023 13:33:16 +0000 (15:33 +0200)]
[NTDLL_APITEST] Fix a test for NtMapViewOfSection
Timo Kreuzer [Thu, 2 Feb 2023 18:34:06 +0000 (20:34 +0200)]
[NTDLL_APITEST] Try to fix test for NtMapViewOfSection
Remove a 0 sized test.dll, which overwrites an already present proper test.dll
Timo Kreuzer [Thu, 2 Feb 2023 15:37:37 +0000 (17:37 +0200)]
[WIN32KNT_APITEST] Disable test for NtGdiDdQueryDirectDrawObject
Timo Kreuzer [Thu, 2 Feb 2023 14:22:48 +0000 (16:22 +0200)]
[STATIC_CRT_APITEST] Add todo to tests that fail on Windows
Timo Kreuzer [Thu, 2 Feb 2023 11:48:56 +0000 (13:48 +0200)]
[SHELL32_APITEST] Disable CUserNotification test
The test doesn't work on Windows 2003, because the balloon window does not close itself.
Timo Kreuzer [Thu, 2 Feb 2023 10:04:54 +0000 (12:04 +0200)]
[KERNEL32_APITEST] Make tests pass on Windows 2003
Timo Kreuzer [Wed, 1 Feb 2023 22:16:19 +0000 (00:16 +0200)]
[USER32_APITEST] Remove "ugly ros hack"
This hack corrupts memory and causes test failures on Windows.
Timo Kreuzer [Wed, 1 Feb 2023 14:34:08 +0000 (16:34 +0200)]
[IPHLPAPI_APITEST] Fix tests so they pass on Windows 2003 and Windows 10
Timo Kreuzer [Tue, 31 Jan 2023 12:08:46 +0000 (14:08 +0200)]
[GDIPLUS_WINETEST] Make tests pass on Windows 2003
Hervé Poussineau [Sun, 16 Apr 2023 16:48:15 +0000 (18:48 +0200)]
[WIN32SS:ENG] Do not free LDEV if unloading a driver failed
Currently, LDEVOBJ_bUnloadImage always returns FALSE due to missing functionality in ntoskrnl.
LDEVOBJ_vFreeLDEV contains an assert that driver is correctly unloaded before freeing it.
Prevent this assert by calling LDEVOBJ_vFreeLDEV only if LDEVOBJ_bUnloadImage succeed.
This can be easily triggered if DrvEnableDriver function (called in LDEVOBJ_bEnableDriver) fails.
Adam Słaboń [Sun, 19 Mar 2023 12:58:27 +0000 (13:58 +0100)]
[MKISOFS] Fix MSVC build on ARM hosts
Check also for MSVC target machine macros on ARM
Thamatip Chitpong [Tue, 28 Mar 2023 11:49:34 +0000 (18:49 +0700)]
[HHCTRL.OCX] Reduce ROS diff
Timo Kreuzer [Wed, 28 Dec 2022 14:15:28 +0000 (15:15 +0100)]
[PSEH] Change return type of filter function prototype to avoid broken return from inside it.
Timo Kreuzer [Tue, 27 Dec 2022 15:43:10 +0000 (17:43 +0200)]
[NTOS/CC] Fix broken usage of _SEH2_FINALLY
Finally handlers are - unlike except blocks - not part of the function they are in, but separate functions, which are called during unwind. PSEH implements them on GCC using nested functions. While "return" from a finally handler is allowed with native SEH, it's handled by the compiler through an extra unwinding operation using _local_unwind, WHICH IS NOT SUPPORTED BY PSEH! With PSEH, returning from a finally handler does not return from the function, instead it will only return from the finally handler and the function will continue below the finally handler as if there was no return at all. To fix this, the return is removed and an additional success check is added.
Also use _SEH_VOLATILE to make sure the variable assignment is not optimized away by the compiler and add zero out the result parameters on error.
Timo Kreuzer [Sun, 22 Jan 2023 08:26:13 +0000 (10:26 +0200)]
[NTOS/CC] Fix calls to CcRosEnsureVacbResident
The function returns BOOLEAN, not NTSTATUS! Also wrap it in SEH, because it can throw an exception on failure.
Timo Kreuzer [Wed, 1 Feb 2023 16:29:38 +0000 (18:29 +0200)]
[USER32_WINETEST] Change module type to win32cui to be able to see test results
Mark Jansen [Mon, 3 Apr 2023 18:12:39 +0000 (20:12 +0200)]
[CODEOWNERS] Add Giannis and myself as reviewer for shell related stuff
Thamatip Chitpong [Wed, 12 Apr 2023 20:20:46 +0000 (03:20 +0700)]
[NTUSER] co_UserDestroyWindow: Validate window before destroying it (#5054)
Prevent the window from being destroyed twice
fixes BSOD 0x1E CORE-18821
Thamatip Chitpong [Wed, 12 Apr 2023 20:00:37 +0000 (03:00 +0700)]
[MMSYS] Improve sound test button (#4879)
- Make sound test button able to stop the sound (like WinXP's mmsys.cpl)
- Change stop icon
- Add documentation for GetSoundDuration
Hermès Bélusca-Maïto [Mon, 28 Nov 2022 01:48:55 +0000 (02:48 +0100)]
[NTOS:KDBG] Only use the direct KdbPrintf instead of KdbpPrint (pager) inside the exception handler (outside the debugger main loop).
Hermès Bélusca-Maïto [Wed, 12 Apr 2023 16:38:47 +0000 (18:38 +0200)]
[NTOS:KDBG] Use local KdbPrintf function for DPRINT1 instead of DbgPrint...
... that would otherwise cause a debugger re-entry.
Also use KdbPuts/Printf instead of KdpDprintf that won't be available
once KDBG is moved out of it.