3 years ago[SAMSRV] Update Chinese translation
Luo Yufan [Mon, 18 Mar 2019 13:42:36 +0000 (21:42 +0800)]
[SAMSRV] Update Chinese translation

3 years ago[RICHED20] Simplify MSVC thiscall & stdcall wrappers. 1332/head
Thomas Faber [Sat, 2 Feb 2019 14:52:13 +0000 (15:52 +0100)]
[RICHED20] Simplify MSVC thiscall & stdcall wrappers.

Imports Wine commit b64511c00a5.

3 years agoMerge branch 'master' of
jimtabor [Mon, 18 Mar 2019 22:30:01 +0000 (17:30 -0500)]
Merge branch 'master' of

3 years ago[NtUser] Support SWP_FRAMECHANGED
jimtabor [Mon, 18 Mar 2019 22:28:33 +0000 (17:28 -0500)]

Implement SWP_FRAMECHANGED support for non-changing window to force a

Patch dedicated to Katayama Hirofumi MZ.

3 years ago[USERENV] UnloadUserProfile: When a profiles ref count gets 0, delete the profile...
Eric Kohl [Mon, 18 Mar 2019 22:24:06 +0000 (23:24 +0100)]
[USERENV] UnloadUserProfile: When a profiles ref count gets 0, delete the profile if the user is a member of the guests group.

3 years ago[ACPPAGE] Revamp the 'edit' page to easier select different layers 1422/head
Mark Jansen [Sun, 17 Mar 2019 12:31:31 +0000 (13:31 +0100)]
[ACPPAGE] Revamp the 'edit' page to easier select different layers

3 years ago[CALC] Update to version 1.12 -- Update whatsnew.txt 1421/head
Carlo-Bramini [Sun, 4 Nov 2018 10:38:31 +0000 (11:38 +0100)]
[CALC] Update to version 1.12 -- Update whatsnew.txt

3 years ago[CALC] Added "Minute of arc" and "Second of arc" to the "Angles" units. CORE-5939
Carlo-Bramini [Sun, 4 Nov 2018 10:08:44 +0000 (11:08 +0100)]
[CALC] Added "Minute of arc" and "Second of arc" to the "Angles" units. CORE-5939

3 years ago[CALC] Add new, and fix existing units conversions. CORE-5939
Carlo-Bramini [Fri, 24 Aug 2018 18:08:54 +0000 (20:08 +0200)]
[CALC] Add new, and fix existing units conversions. CORE-5939

- Add support for new conversion units:
  * AREA: 'mu', 'rai'.
  * LENGTH: 'chi', 'cun'. 'sun' optimized.
  * TIME: 'nanoseconds'.
  * WEIGHT: 'Kan', 'Kin'.

- Add support for thailand measure system; invaluable help from
  this page:

- Add ZHANG (Chinese), and DANBO, JEONGBO (Korean) units.

See details here:

- Rewritten some units formula by using scientific notation.
- Improved precision of parsec unit coversion formula.

3 years ago[CALC] Fix wrong button size in french. CORE-12359
Carlo-Bramini [Sun, 12 Aug 2018 09:35:17 +0000 (11:35 +0200)]
[CALC] Fix wrong button size in french. CORE-12359

3 years ago[CALC] Fix buttons transitions. Improve UI code readability. CORE-8526
Carlo-Bramini [Tue, 7 Aug 2018 18:47:28 +0000 (20:47 +0200)]
[CALC] Fix buttons transitions. Improve UI code readability. CORE-8526

- Improve code readability by using suitable UI function names.

3 years ago[CALC] Improvements and fixes for the numeric text output. CORE-8486
Carlo-Bramini [Tue, 7 Aug 2018 17:58:28 +0000 (19:58 +0200)]
[CALC] Improvements and fixes for the numeric text output. CORE-8486

- Fixed bug 12.37 13/06/2009 into multiprecision display (unicode only).
- Fixed bug when calculator was closed with statistics dialog open.
- Fixed bug in XrY operator.
- Fixed error into conversion unit.
- Do not append decimal separator if "ERROR" messages are printed.
- Remove call to _tcslen() and use return value of GetDlgItemText() where possible.

3 years ago[CALC] Resource files formatting only.
Carlo-Bramini [Mon, 6 Aug 2018 19:11:59 +0000 (21:11 +0200)]
[CALC] Resource files formatting only.

3 years ago[CALC] Improve the handling of configuration settings. CORE-3085, CORE-8486
Carlo-Bramini [Mon, 6 Aug 2018 19:00:43 +0000 (21:00 +0200)]
[CALC] Improve the handling of configuration settings. CORE-3085, CORE-8486

Configuration is read from WIN.INI under W32S/Win9x/Me and from the registry
for all NT platforms.

Although with INI file mapping the keys are still saved in the registry
even on NT, I added handling of different platforms for writing directly
the configuration in the right place.

3 years ago[CALC] Add theming support, requires Windows XP or later. CORE-13343
Carlo-Bramini [Mon, 6 Aug 2018 18:23:12 +0000 (20:23 +0200)]
[CALC] Add theming support, requires Windows XP or later. CORE-13343

- Fix errors if a theme api is missing.
- Add callback to functions for drawing themed transparent background.
- Fix drawing glitch when theming is applied.
- Redraw on theme change: automatically redraw the window if the
  theme is changed while the application is active.
- Colours are now declared though RGB() macro.
- Removed safe DS_SHELLFONT declaration.

3 years ago[CALC] Add support for HTML-Help. CORE-15019
Carlo-Bramini [Mon, 6 Aug 2018 18:22:36 +0000 (20:22 +0200)]
[CALC] Add support for HTML-Help. CORE-15019

3 years ago[CALC] Improve headers inclusion.
Carlo-Bramini [Mon, 6 Aug 2018 17:58:23 +0000 (19:58 +0200)]
[CALC] Improve headers inclusion.

3 years ago[CALC] Improve multi-precision support, and powers/roots. CORE-8486
Carlo-Bramini [Mon, 6 Aug 2018 07:54:21 +0000 (09:54 +0200)]
[CALC] Improve multi-precision support, and powers/roots. CORE-8486

- Added support for average of squares and mean of squares into statistical functions.
- pop() and push() functions in RPN engines now work with nodes instead of stack units.
- Moved the POW and SQR operations near the operators.

- Fix number of digits for IEEE-754 constants.
- Show all available digits in exp notation.

- Update help correspondingly.

3 years ago[CALC] Rename files only.
Carlo-Bramini [Mon, 6 Aug 2018 07:52:59 +0000 (09:52 +0200)]
[CALC] Rename files only.

3 years ago[USERENV] Implement GetProfileType().
Eric Kohl [Sun, 17 Mar 2019 16:51:32 +0000 (17:51 +0100)]
[USERENV] Implement GetProfileType().

3 years ago[USERENV] LoadUserProfileW: Check the user for Administators and Guests group members...
Eric Kohl [Sun, 17 Mar 2019 11:44:54 +0000 (12:44 +0100)]
[USERENV] LoadUserProfileW: Check the user for Administators and Guests group membership and set the State value accordingly.


3 years ago[NETAPI32] NetUserEnum, NetUserGetInfo: Get the user privileges and auth flags for...
Eric Kohl [Sun, 17 Mar 2019 11:34:49 +0000 (12:34 +0100)]
[NETAPI32] NetUserEnum, NetUserGetInfo: Get the user privileges and auth flags for info levels 1, 2, 3, 4 and 11.

3 years ago[USERENV] Store the profiles load time, flags and state in the profile list.
Eric Kohl [Sat, 16 Mar 2019 18:12:25 +0000 (19:12 +0100)]
[USERENV] Store the profiles load time, flags and state in the profile list.

3 years ago[SHELL32] Disable the Hardware tab in the properties dialog for Network drives (...
Jared Smudde [Sat, 16 Mar 2019 14:37:56 +0000 (09:37 -0500)]
[SHELL32] Disable the Hardware tab in the properties dialog for Network drives (#1249)

This matches Windows behaviour.

3 years ago[MEDIA][INF] Improve network adapter names
Stanislav Motylkov [Sat, 9 Mar 2019 18:00:54 +0000 (21:00 +0300)]
[MEDIA][INF] Improve network adapter names

3 years ago[SNDVOL32] Small Italian translation update (#1415)
Daniele Campione [Sat, 16 Mar 2019 14:33:57 +0000 (15:33 +0100)]
[SNDVOL32] Small Italian translation update (#1415)

3 years agoMerge pull request #1253 from SergeGautherie/SergeGautherie/PRonly_Log2Lines_handle_e...
Serge Gautherie [Sat, 16 Mar 2019 10:23:27 +0000 (11:23 +0100)]
Merge pull request #1253 from SergeGautherie/SergeGautherie/PRonly_Log2Lines_handle_escape_cmd_Path-LineOut

[LOG2LINES] handle_escape_cmd(): Remove 2 unused parameters

3 years ago[LOG2LINES] Add a TODO, Use a snprintf()
Serge Gautherie [Wed, 16 Jan 2019 16:46:27 +0000 (17:46 +0100)]
[LOG2LINES] Add a TODO, Use a snprintf()

Addendum to c5d8d8d.

3 years ago[SYSDM] Update SMBIOS parsing code
Stanislav Motylkov [Thu, 7 Mar 2019 00:33:39 +0000 (03:33 +0300)]
[SYSDM] Update SMBIOS parsing code

3 years ago[USERENV] Use a reference counter when loading and unloading profiles. Unload the...
Eric Kohl [Sat, 16 Mar 2019 06:45:30 +0000 (07:45 +0100)]
[USERENV] Use a reference counter when loading and unloading profiles. Unload the hive only when the reference counter reaches 0. This fixes the remaining bugs in "userenv_apitest LoadUserProfile".

3 years ago[COMCTL32] Combobox Implement logic for set and get dropdown height CORE-15833
Joachim Henze [Sat, 16 Mar 2019 01:11:00 +0000 (02:11 +0100)]
[COMCTL32] Combobox Implement logic for set and get dropdown height CORE-15833

by import of Wine commit
merged from current Wine head.

Thanks to patches author Fabian Maurer
and also Doug Lyons for tests and adding initial the merge-patch.

3 years ago[USERENV] Use a mutex to serialize profile loading and unloading.
Eric Kohl [Fri, 15 Mar 2019 19:54:03 +0000 (20:54 +0100)]
[USERENV] Use a mutex to serialize profile loading and unloading.

3 years ago[OLE32] Implement WS_EX_ACCEPTFILES (#1403)
Katayama Hirofumi MZ [Fri, 15 Mar 2019 13:31:13 +0000 (22:31 +0900)]
[OLE32] Implement WS_EX_ACCEPTFILES (#1403)

The window that has WS_EX_ACCEPTFILES extended style, should pretend like a drop target that accepts CF_HDROP data. CORE-11238

3 years agoUpdated release version on readme
Benjamin Aerni [Thu, 14 Mar 2019 15:46:54 +0000 (08:46 -0700)]
Updated release version on readme

3 years ago[README] Improve the layout of the Quick-Links; add the chat link (#1409)
Alexander Rechitskiy [Thu, 14 Mar 2019 23:04:57 +0000 (02:04 +0300)]
[README] Improve the layout of the Quick-Links; add the chat link (#1409)

3 years ago[USERENV] LoadUserProfileW: If a user profile has already been loaded, just open...
Eric Kohl [Thu, 14 Mar 2019 22:47:34 +0000 (23:47 +0100)]
[USERENV] LoadUserProfileW: If a user profile has already been loaded, just open and return the profile key.

3 years ago[SHIMENG] Implement experimental support for multiple hooks on the same function 1417/head
Mark Jansen [Wed, 13 Mar 2019 19:15:18 +0000 (20:15 +0100)]
[SHIMENG] Implement experimental support for multiple hooks on the same function

3 years ago[SDK][SHIMENG] Ensure that module entrypoints are not called while loading the shim...
Mark Jansen [Mon, 11 Mar 2019 21:51:46 +0000 (22:51 +0100)]
[SDK][SHIMENG] Ensure that module entrypoints are not called while loading the shim engine
This is done by marking everything that is already loaded but not 'processed'.
After the shim engine is done initializing, the original state is restored,
with the exception of the shim engine itself.

3 years ago[LDR] Do not call module entrypoints while loading the shim engine.
Mark Jansen [Mon, 11 Mar 2019 21:48:37 +0000 (22:48 +0100)]
[LDR] Do not call module entrypoints while loading the shim engine.
Manually call the shim engine entrypoint

3 years ago[SHIMENG] Don't crash on a shim not found
Mark Jansen [Mon, 11 Mar 2019 21:47:22 +0000 (22:47 +0100)]
[SHIMENG] Don't crash on a shim not found

3 years ago[SHIMENG] Find shims case-insensitive
Mark Jansen [Mon, 11 Mar 2019 21:46:18 +0000 (22:46 +0100)]
[SHIMENG] Find shims case-insensitive

3 years ago[ACLAYERS] Add stubplemented IgnoreLoadLibrary shim
Mark Jansen [Sun, 10 Mar 2019 23:04:13 +0000 (00:04 +0100)]
[ACLAYERS] Add stubplemented IgnoreLoadLibrary shim

3 years ago[APPSHIM_APITEST] Add test for IgnoreLoadLibrary
Mark Jansen [Sun, 10 Mar 2019 22:54:41 +0000 (23:54 +0100)]
[APPSHIM_APITEST] Add test for IgnoreLoadLibrary

3 years ago[ACLAYERS] Simplify ForceDXSetupSuccess as suggested by Thomas
Mark Jansen [Sun, 10 Mar 2019 22:09:23 +0000 (23:09 +0100)]
[ACLAYERS] Simplify ForceDXSetupSuccess as suggested by Thomas

3 years ago[GDI32] Fix issue after a Flush
James Tabor [Thu, 14 Mar 2019 17:00:53 +0000 (12:00 -0500)]
[GDI32] Fix issue after a Flush

While flushing the DC handle goes down with the flush. This was not a
regression, just untested old code.

3 years ago[UNIATA] Update to version 46e8. CORE-15843 1416/head
Thomas Faber [Wed, 13 Mar 2019 11:36:23 +0000 (12:36 +0100)]
[UNIATA] Update to version 46e8. CORE-15843

3 years ago[UNIATA] Remove an unnecessary ROS-diff.
Thomas Faber [Wed, 13 Mar 2019 11:35:49 +0000 (12:35 +0100)]
[UNIATA] Remove an unnecessary ROS-diff.

3 years ago[WIN32SS:NTGDI] Fix missing text in labels and buttons for .NET apps. CORE-15000
Hermès Bélusca-Maïto [Thu, 14 Mar 2019 00:36:45 +0000 (01:36 +0100)]
[WIN32SS:NTGDI] Fix missing text in labels and buttons for .NET apps. CORE-15000

There was a missing break statement in ftGdiGetGlyphOutline().
Found by JIRA contributor 'I_Kill_Bugs' :-)

Add also brackets around 'case's to make code navigation easier.

3 years ago[User32] Support WM_COPYGLOBALDATA
jimtabor [Wed, 13 Mar 2019 17:16:52 +0000 (12:16 -0500)]

Implement support for WM_COPYGLOBALDATA. Needs more tests.

Tested DropTest from CORE-15836.

3 years ago[DOC] Update 3rd party readme file. CORE-15280
Thomas Faber [Tue, 12 Mar 2019 03:45:44 +0000 (04:45 +0100)]
[DOC] Update 3rd party readme file. CORE-15280

3 years ago[MAINTAINERS] Add 3rd party library files that I've been syncing.
Thomas Faber [Tue, 12 Mar 2019 03:45:34 +0000 (04:45 +0100)]
[MAINTAINERS] Add 3rd party library files that I've been syncing.

CORE-15280 CORE-14291 CORE-13739 CORE-13451 ...

3 years agoRevert "[FREETYPE] Fix 3 regressions in one patch"
Joachim Henze [Tue, 12 Mar 2019 17:57:21 +0000 (18:57 +0100)]
Revert "[FREETYPE] Fix 3 regressions in one patch"

This reverts commit 0.4.12-dev-856-g
CORE-15785, CORE-15558, CORE-15755.

As requested by Pierre, we have very strong indication, that it broke and

3 years ago[SETUPLIB][USETUP] Improve disk HW numbering, removable disk support, and "super...
Hermès Bélusca-Maïto [Mon, 11 Mar 2019 23:13:25 +0000 (00:13 +0100)]
[SETUPLIB][USETUP] Improve disk HW numbering, removable disk support, and "super-floppy" partitioning.

Nowadays more and more people try to install ReactOS from removable
drives (e.g. USB sticks) onto fixed HDDs, or try to install it into
USB sticks too.

Both fixed and removable drives, as well as partitions on these, are
represented in NT using the same device name format:

  \Device\HarddiskM\PartitionN ,

with an increasing disk number M. Using this number for building the
corresponding firmware-specific ARC multi(x)disk(y)rdisk(z) path used
by the NT/ROS loader (FreeLdr, ...) is then prone to error since there
may have  been  removable drives  inserted  and  accounted for in the
calculation  of  the disk number.  These drives must be  correctly
subtracted in order to generate the correct ARC path, valid once all
the removable drives have been ejected (which should also be the
situation seen from the BIOS when booting up, except of course if you
boot on a USB stick).

This problem is now solved. Note that it matters only for the disks
that have also been enumerated by the firmware (BIOS; Int 13h). We
don't have to care about the other drives, since the ARC path will be
of a different format and will not use the disk number (instead, the
SCSI coordinates are used).

We also try to enumerate all the disks found in all the possible disk
adapters and  controllers enumerated  in the Hardware registry tree
(and that are visible by FreeLdr) in order to cover all.

Finally, we detect whether a disk reports as  a "super-floppy",  i.e.
an unpartitioned disk with a valid VBR. This is indeed how a standard
floppy disk looks like, or how USB sticks are partitioned on Windows.
Such disk is reported has having only one single partition starting at
the beginning of the disk, with partition number == 0, its type being
FAT16 non-bootable.
This allows us to forbid creating any new partitions on such disks.
Note that accessing either \Device\HarddiskN\Partition0 or Partition1
on such a disk returns the same data.
Note also that on the contrary, regular MBR-partitioned disks would
report at least four partitions entries, instead of just one.

The other improvements are:

- Do *NOT* write any MBR on a disk partitioned as "super-floppy".

- Fix the computed disk identifier, of format: %08x-%08x-%c .
  The numbers are respectively the checksum of the first sector, and
  the disk signature. The terminating letter is A or X, depending
  whether the first sector ends with 0x55AA/0xAA55 or not (see also
  commit 5053f1f5).

- Warn if the user attempts to install ReactOS on a disk that is not
  visible by the  firmware of his computer,  because it may not be

3 years ago[NETAPI32] NetUserAdd, NetUserSetInfo: Start to set parm_err in case of invalid param...
Eric Kohl [Tue, 12 Mar 2019 00:02:47 +0000 (01:02 +0100)]
[NETAPI32] NetUserAdd, NetUserSetInfo: Start to set parm_err in case of invalid parameters.

3 years ago[NETAPI32] NetUserSetInfo: Support the logon hours for level 2, 3, 4, 22 and 1020...
Eric Kohl [Mon, 11 Mar 2019 23:20:07 +0000 (00:20 +0100)]
[NETAPI32] NetUserSetInfo: Support the logon hours for level 2, 3, 4, 22 and 1020. Also make sure that we do not leak memory on invalid levels.

3 years ago[NETAPI32] NetUserGetInfo: Build and return the users SID for level 4 and 23.
Eric Kohl [Mon, 11 Mar 2019 21:28:42 +0000 (22:28 +0100)]
[NETAPI32] NetUserGetInfo: Build and return the users SID for level 4 and 23.

3 years ago[FREETYPE] Fix 3 regressions in one patch
Joachim Henze [Mon, 11 Mar 2019 19:10:14 +0000 (20:10 +0100)]
[FREETYPE] Fix 3 regressions in one patch

Fixes regression CORE-15785 (Zim Desktop Wiki 0.67 crashed) and
Fixes regression CORE-15755 (NLite used wrong font)

without reintroducing regression CORE-15558 (AbiWord 2.6.8 font enumeration)

This is achieved by partial revert of
and got ack of Katayama Hirofumi MZ.

Thanks to patches author Doug Lyons.

3 years ago[TRANSLATION] Hindi translation of the shell extensions. (#1405)
Arnav Bhatt [Mon, 11 Mar 2019 15:52:21 +0000 (21:22 +0530)]
[TRANSLATION] Hindi translation of the shell extensions. (#1405)

3 years agoMerge pull request #1412 from njlyf2011/improve-zh-translation
Luo Yufan [Mon, 11 Mar 2019 15:50:17 +0000 (23:50 +0800)]
Merge pull request #1412 from njlyf2011/improve-zh-translation

[TRANSLATION] Update Traditional Chinese translation

3 years ago[EXPLORER] Show the Desktop Russian translation update
Oleg Dubinskiy [Mon, 11 Mar 2019 14:07:34 +0000 (16:07 +0200)]
[EXPLORER] Show the Desktop Russian translation update

3 years ago[USBUHCI_NEW] Fix an infinite loop. 1392/head
Thomas Faber [Wed, 6 Mar 2019 09:20:39 +0000 (10:20 +0100)]
[USBUHCI_NEW] Fix an infinite loop.

3 years ago[USBPORT] Implement interface setting in USBPORT_OpenInterface.
Thomas Faber [Wed, 6 Mar 2019 08:59:41 +0000 (09:59 +0100)]
[USBPORT] Implement interface setting in USBPORT_OpenInterface.

3 years ago[USBPORT] Correctly handle alternate settings returned from USBPORT_ParseConfiguratio...
Thomas Faber [Wed, 6 Mar 2019 08:57:23 +0000 (09:57 +0100)]
[USBPORT] Correctly handle alternate settings returned from USBPORT_ParseConfigurationDescriptor.

The last parameter of USBPORT_ParseConfigurationDescriptor is a pointer
to a boolean indicating whether any alternate interface settings were
found for the specified interface.
Interpreting it as an alternate setting value, as we did before,
would always override the alternate setting to '1' (if any alternate
descriptors were present), therefore selecting the wrong interface
setting, and possibly causing a buffer overflow on the InterfaceList's
Pipes array.

Found by Special Pool.

3 years ago[USBPORT] Correctly find interface descriptor in USBPORT_ParseConfigurationDescriptor
Thomas Faber [Wed, 6 Mar 2019 08:22:55 +0000 (09:22 +0100)]
[USBPORT] Correctly find interface descriptor in USBPORT_ParseConfigurationDescriptor

There can be other descriptors between the config descriptor and the
first interface descriptor, so we specifically need to check for
the interface descriptor type and skip anything before that.
We also need to guard against bLength == 0, which would cause an
infinite loop, instead of doing a second bDescriptorType check.

3 years ago[USBPORT] Acquire EndpointSpinLock in addition to MiniportSpinLock in USBPORT_ReopenPipe.
Thomas Faber [Wed, 6 Mar 2019 08:23:26 +0000 (09:23 +0100)]
[USBPORT] Acquire EndpointSpinLock in addition to MiniportSpinLock in USBPORT_ReopenPipe.

3 years ago[USBPORT] Release StateChangeSpinLock before acquiring MiniportSpinLock.
Thomas Faber [Tue, 5 Mar 2019 21:27:15 +0000 (22:27 +0100)]
[USBPORT] Release StateChangeSpinLock before acquiring MiniportSpinLock.

Found by Driver Verifier.

3 years ago[USBPORT] Leave IRP status untouched for unhandled interfaces.
Thomas Faber [Tue, 5 Mar 2019 21:23:46 +0000 (22:23 +0100)]
[USBPORT] Leave IRP status untouched for unhandled interfaces.

Found by Driver Verifier.

3 years ago[USBPORT] Don't change the status of IRP_MJ_SYSTEM_CONTROL requests.
Thomas Faber [Tue, 5 Mar 2019 16:28:20 +0000 (17:28 +0100)]
[USBPORT] Don't change the status of IRP_MJ_SYSTEM_CONTROL requests.

Found by Driver Verifier.

3 years ago[USBHUB_NEW] Don't leak IRP_MJ_SYSTEM_CONTROL requests.
Thomas Faber [Wed, 6 Mar 2019 08:21:39 +0000 (09:21 +0100)]

Found by Driver Verifier.

3 years ago[NTOS:IO] Enable privilege check in NtLoadDriver.
Thomas Faber [Tue, 5 Mar 2019 11:33:12 +0000 (12:33 +0100)]
[NTOS:IO] Enable privilege check in NtLoadDriver.

3 years ago[USETUP] Use for-loops; simplify the code.
Hermès Bélusca-Maïto [Tue, 5 Mar 2019 01:00:13 +0000 (02:00 +0100)]
[USETUP] Use for-loops; simplify the code.

3 years ago[SETUPLIB][USETUP] Remove CurrentDisk/Partition from the partlist lib code, and move...
Hermès Bélusca-Maïto [Tue, 5 Mar 2019 00:42:33 +0000 (01:42 +0100)]
[SETUPLIB][USETUP] Remove CurrentDisk/Partition from the partlist lib code, and move these into the UI code.

- Add also some validation ASSERTs and simplify the code here and there.

- The installation partition is called "InstallPartition", while the
  global "CurrentPartition" is the disk region currently selected in
  the partition UI list, on which prtitioning operations are effectued.

- Extend CheckActiveSystemPartition() to use an optional alternative
  disk or partition in case the actual system partition (present in the
  first disk) cannot be used, e.g. because we don't support writes on it.

3 years ago[SETUPLIB] Improve the discovery of the active system partition.
Hermès Bélusca-Maïto [Mon, 25 Feb 2019 22:43:20 +0000 (23:43 +0100)]
[SETUPLIB] Improve the discovery of the active system partition.

CORE-7749, CORE-6305, CORE-13205

3 years ago[NET] Display the country along with the users country code.
Eric Kohl [Sun, 10 Mar 2019 21:00:41 +0000 (22:00 +0100)]
[NET] Display the country along with the users country code.

3 years ago[TRANSLATION] Update Hebrew translations (#1408)
Shy Zedaka [Sun, 10 Mar 2019 18:21:57 +0000 (20:21 +0200)]
[TRANSLATION] Update Hebrew translations (#1408)

3 years ago[USETUP] Improve the formatter & check-disk state machine. CORE-7749
Hermès Bélusca-Maïto [Mon, 25 Feb 2019 19:29:16 +0000 (20:29 +0100)]
[USETUP] Improve the formatter & check-disk state machine. CORE-7749

- Find or set the active system partition only once, when we start the
  formatting stage. If the system partition is to be created in some
  non-partitioned space, we create it.

- A file-system check is always scheduled for both the system and the
  installation partitions.

- If the system partition was already formatted (which usually means
  that it already existed on the system), don't ask for formatting it.


- For each partition to be formatted, the file-system menu list is
  re-created, in order to display only the FSes that are compatible
  with the selected partition, and allow to give the user the choice
  to keep the existing file-system only if the selected partition was
  already formatted.

- Check whether the user attempts to delete the partition on which
  the installation source is present, only if it is not "new" and is

- Check first whether the current partition is the system partition,

3 years ago[SETUPLIB][USETUP] Minor improvements.
Hermès Bélusca-Maïto [Sun, 24 Feb 2019 18:04:57 +0000 (19:04 +0100)]
[SETUPLIB][USETUP] Minor improvements.

- Make some partitioning functions not dependent on the selected "CurrentPartition".
- Add some sanity checks.
- Improve some of the "is-partitioned" checks.

3 years ago[SETUPLIB][USETUP] Factor out the usage of FS provider structures.
Hermès Bélusca-Maïto [Sun, 24 Feb 2019 16:52:33 +0000 (17:52 +0100)]
[SETUPLIB][USETUP] Factor out the usage of FS provider structures.

Similarly to FMIFS this structure should be private. Instead file-system
names are passed to the helper functions, allowing to use the names
returned by the FS drivers. The names are then internally mapped to the
corresponding FS providers.

In particular this allows to handle the "RAW" file-system and to assign
the 'Unformatted' flag to partitions having this FS.

Finally this helps us refining the checks performed to see whether the
current "active" system partition uses a supported file-system.

3 years ago[ACLAYERS] Implement the ForceDXSetupSuccess shim 1399/head
Mark Jansen [Thu, 7 Mar 2019 23:32:20 +0000 (00:32 +0100)]
[ACLAYERS] Implement the ForceDXSetupSuccess shim
This shim is used on older installers that try to install DirectX,
but encounter errors doing so with the bundled setup.

3 years ago[APPSHIM_APITEST] Add tests for ForceDXSetupSuccess
Mark Jansen [Thu, 7 Mar 2019 20:18:52 +0000 (21:18 +0100)]
[APPSHIM_APITEST] Add tests for ForceDXSetupSuccess

3 years ago[ACLAYERS][ACGENRAL] Do not use the crt entrypoint.
Mark Jansen [Tue, 9 Oct 2018 22:19:54 +0000 (00:19 +0200)]
[ACLAYERS][ACGENRAL] Do not use the crt entrypoint.

3 years ago[AFD] Don't reallocate buffers if windows sizes didn't change
Pierre Schweitzer [Sun, 10 Mar 2019 11:27:30 +0000 (12:27 +0100)]
[AFD] Don't reallocate buffers if windows sizes didn't change

3 years ago[WIN32K] Keep a reference on an ETHREAD while THREADINFO exists
Timo Kreuzer [Tue, 13 Mar 2018 22:00:17 +0000 (23:00 +0100)]
[WIN32K] Keep a reference on an ETHREAD while THREADINFO exists

3 years ago[NET] Move the remaining IDS_GENERIC_PAGE strings into the command messages and fix...
Eric Kohl [Sun, 10 Mar 2019 08:55:15 +0000 (09:55 +0100)]
[NET] Move the remaining IDS_GENERIC_PAGE strings into the command messages and fix a size restriction of ConPrintf().

3 years ago[NET] Add help message for the NET USER command and move the IDS_GENERIC_PAGE string...
Eric Kohl [Sun, 10 Mar 2019 07:59:32 +0000 (08:59 +0100)]
[NET] Add help message for the NET USER command and move the IDS_GENERIC_PAGE string into the help messages.

3 years ago[NET] Implement the NET SYNTAX pseudo command.
Eric Kohl [Sun, 10 Mar 2019 00:04:26 +0000 (01:04 +0100)]
[NET] Implement the NET SYNTAX pseudo command.

3 years ago[NET] Fix some 'net help' and 'net user' issues.
Eric Kohl [Sat, 9 Mar 2019 23:30:27 +0000 (00:30 +0100)]
[NET] Fix some 'net help' and 'net user' issues.

3 years ago[NETAPI32] Initialize parm_err
Eric Kohl [Sat, 9 Mar 2019 19:26:00 +0000 (20:26 +0100)]
[NETAPI32] Initialize parm_err

3 years ago[Win32SS] Add TextOut to GDI Batch
James Tabor [Sat, 9 Mar 2019 04:21:41 +0000 (22:21 -0600)]
[Win32SS] Add TextOut to GDI Batch

Add fix ups to PolyPatBlt and freetype.
TextOut supports 580 characters w/o Dx and Dx at a max of 193 characters
with Dx*1, both if offset is 0.

Noticed a lot of over drawing with start menu from ComCtl32 SB_SETTEXT
going through User32 DrawText/Worker ExtTextOutW. Explain why it might
be slowing down.

If issues arise, commenting out lines in win32ss/include/gdi32p.h can

else if (Cmd == GdiBCTextOut) cjSize = 0;//sizeof(GDIBSTEXTOUT); <----
this one most of all.
 else if (Cmd == GdiBCExtTextOut) cjSize = 0;//sizeof(GDIBSEXTTEXTOUT);

Test results:,66262

3 years ago[BOOTDATA] Fix Volgograd time zone (UTC+04:00)
Stanislav Motylkov [Fri, 8 Mar 2019 21:11:00 +0000 (00:11 +0300)]
[BOOTDATA] Fix Volgograd time zone (UTC+04:00)


3 years ago[SHUTDOWN] Small Italian translation update (#1397)
Daniele Campione [Fri, 8 Mar 2019 14:49:56 +0000 (15:49 +0100)]
[SHUTDOWN] Small Italian translation update (#1397)

3 years ago[TRANSLATION] Hindi translation of SYSSETUP AND SAMSRV. (#1400)
Arnav Bhatt [Fri, 8 Mar 2019 14:48:20 +0000 (20:18 +0530)]
[TRANSLATION] Hindi translation of SYSSETUP AND SAMSRV. (#1400)

3 years agoHindi translation of comdlg32. (#1391) 1396/head
Arnav Bhatt [Thu, 7 Mar 2019 09:05:08 +0000 (14:35 +0530)]
Hindi translation of comdlg32. (#1391)

Hindi translation of comdlg32.

3 years ago[WALLPAPER] Add ReactOS Soft Blue (#1376)
Foxlet [Wed, 6 Mar 2019 22:14:08 +0000 (17:14 -0500)]
[WALLPAPER] Add ReactOS Soft Blue (#1376)


3 years ago[WALLPAPERS] Added Silhouette collection (#1383)
polar [Wed, 6 Mar 2019 22:12:18 +0000 (22:12 +0000)]
[WALLPAPERS] Added Silhouette collection (#1383)


3 years ago[ZIPFLDR] Allow the shell extension to extract passworded zip files 1382/head
Mark Jansen [Wed, 27 Feb 2019 21:18:52 +0000 (22:18 +0100)]
[ZIPFLDR] Allow the shell extension to extract passworded zip files

3 years ago[ZLIB] Restore 'uncrypt' functionality in minizip
Mark Jansen [Wed, 27 Feb 2019 21:18:44 +0000 (22:18 +0100)]
[ZLIB] Restore 'uncrypt' functionality in minizip

3 years ago[ZIPFLDR] Move CConfirmReplace to a new file
Mark Jansen [Wed, 27 Feb 2019 21:18:32 +0000 (22:18 +0100)]
[ZIPFLDR] Move CConfirmReplace to a new file

3 years ago[DRWTSN32] Print some extra exception info 1384/head
Mark Jansen [Thu, 28 Feb 2019 22:10:43 +0000 (23:10 +0100)]
[DRWTSN32] Print some extra exception info

3 years ago[NTOS:PS] Use NULL instead of 0 in ps/kill.c
Timo Kreuzer [Thu, 12 Jul 2018 13:18:53 +0000 (15:18 +0200)]
[NTOS:PS] Use NULL instead of 0 in ps/kill.c