reactos.git
2 years ago[WINDOWSCODECS] Forgot to commit this file. Addendum to ae80686. CORE-14434
Amine Khaldi [Mon, 5 Mar 2018 22:56:09 +0000 (23:56 +0100)]
[WINDOWSCODECS] Forgot to commit this file. Addendum to ae80686. CORE-14434

2 years ago[SHELL32] Fix item order in Folder Options (#415)
Katayama Hirofumi MZ [Mon, 5 Mar 2018 22:40:41 +0000 (07:40 +0900)]
[SHELL32] Fix item order in Folder Options (#415)

2 years ago[SHLWAPI] Implement SHAreIconsEqual
Mark Jansen [Mon, 5 Mar 2018 21:43:05 +0000 (22:43 +0100)]
[SHLWAPI] Implement SHAreIconsEqual
CORE-14425

2 years ago[SHLWAPI_APITEST] Add test for SHAreIconsEqual
Mark Jansen [Mon, 5 Mar 2018 21:18:21 +0000 (22:18 +0100)]
[SHLWAPI_APITEST] Add test for SHAreIconsEqual

2 years ago[WINDOWSCODECS] Fix stack pointer corruption when handling PNGs.
Thomas Faber [Mon, 5 Mar 2018 17:51:24 +0000 (18:51 +0100)]
[WINDOWSCODECS] Fix stack pointer corruption when handling PNGs.

Without PNG_API_RULE defined, these functions (like all others) aren't stdcall.

2 years ago[AFD_APITEST] Introduce a test for directly creating and using sockets via AFD. CORE...
Thomas Faber [Sun, 25 Feb 2018 09:34:49 +0000 (10:34 +0100)]
[AFD_APITEST] Introduce a test for directly creating and using sockets via AFD. CORE-9810

The initial tests in send.c validate correct behavior of send/sendto on
disconnected sockets (CORE-9810), fixed in r68129.
However, the helper functions are generic, so they can be used for additional
tests against AFD. Because AFD's create packet structure changes between
Windows versions, the functions check the OS version to determine the right
layout.
Tests succeed on Win2003 as well as Win10.

2 years ago[MSI_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 23:31:58 +0000 (00:31 +0100)]
[MSI_WINETEST] Sync with Wine Staging 3.3. CORE-14434

2 years ago[MSI] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 23:30:58 +0000 (00:30 +0100)]
[MSI] Sync with Wine Staging 3.3. CORE-14434

2 years ago[WINDOWSCODECS_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 23:20:56 +0000 (00:20 +0100)]
[WINDOWSCODECS_WINETEST] Sync with Wine Staging 3.3. CORE-14434

2 years ago[WINDOWSCODECS] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 23:19:05 +0000 (00:19 +0100)]
[WINDOWSCODECS] Sync with Wine Staging 3.3. CORE-14434

2 years ago[D3DCOMPILER_43] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 23:15:03 +0000 (00:15 +0100)]
[D3DCOMPILER_43] Sync with Wine Staging 3.3. CORE-14434

2 years ago[DBGHELPHOST] Fix the *nix build.
Amine Khaldi [Sun, 4 Mar 2018 23:07:53 +0000 (00:07 +0100)]
[DBGHELPHOST] Fix the *nix build.

2 years ago[DBGHELP] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 22:54:20 +0000 (23:54 +0100)]
[DBGHELP] Sync with Wine Staging 3.3. CORE-14434

2 years ago[RPCRT4_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 22:52:30 +0000 (23:52 +0100)]
[RPCRT4_WINETEST] Sync with Wine Staging 3.3. CORE-14434

2 years ago[RPCRT4] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 22:48:59 +0000 (23:48 +0100)]
[RPCRT4] Sync with Wine Staging 3.3. CORE-14434

2 years ago[VFDLIB] More 64 bit fixes
Timo Kreuzer [Wed, 28 Feb 2018 06:05:59 +0000 (07:05 +0100)]
[VFDLIB] More 64 bit fixes

2 years ago[PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER
Timo Kreuzer [Tue, 27 Feb 2018 21:48:32 +0000 (22:48 +0100)]
[PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER
- Make sure the DWLP_* values are correct on _WIN64
- Don't use the DWL_* constants, they are not portable. Enforce this by removing them entirely from winuser.h
- Make sure Get/SetWindowLong*Ptr* is used and pointers are not truncated to LONG

2 years ago[SHLWAPI_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 12:26:14 +0000 (13:26 +0100)]
[SHLWAPI_WINETEST] Sync with Wine Staging 3.3. CORE-14434

2 years ago[OLEAUT32_WINETEST] Fix non-PCH build.
Amine Khaldi [Sun, 4 Mar 2018 12:25:28 +0000 (13:25 +0100)]
[OLEAUT32_WINETEST] Fix non-PCH build.

2 years ago[SHLWAPI] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 12:17:11 +0000 (13:17 +0100)]
[SHLWAPI] Sync with Wine Staging 3.3. CORE-14434

2 years ago[OLEAUT32_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 12:15:59 +0000 (13:15 +0100)]
[OLEAUT32_WINETEST] Sync with Wine Staging 3.3. CORE-14434

2 years ago[OLEAUT32] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 12:14:52 +0000 (13:14 +0100)]
[OLEAUT32] Sync with Wine Staging 3.3. CORE-14434

2 years ago[INCLUDE/WINE] Import heap.h from Wine Staging 3.3. CORE-14434
Amine Khaldi [Sun, 4 Mar 2018 12:10:02 +0000 (13:10 +0100)]
[INCLUDE/WINE] Import heap.h from Wine Staging 3.3. CORE-14434

2 years ago[TRANSLATION][SUBST] Update Simplified Chinese translation. (#414)
Luo Yufan [Sun, 4 Mar 2018 02:37:20 +0000 (10:37 +0800)]
[TRANSLATION][SUBST] Update Simplified Chinese translation. (#414)

2 years ago[TRANSLATION] Polish translation update (#413)
Adam Słaboń [Sat, 3 Mar 2018 20:24:46 +0000 (21:24 +0100)]
[TRANSLATION] Polish translation update (#413)

Translation update for sndvol32, shell32 (right click drag menu), rapps and ks.inf.

2 years ago[WIN32K:NTUSER] Handle IntGetSystemMenu failure cases. CORE-12180
Thomas Faber [Sat, 3 Mar 2018 10:10:37 +0000 (11:10 +0100)]
[WIN32K:NTUSER] Handle IntGetSystemMenu failure cases. CORE-12180

2 years ago[WIN32K:NTUSER] Correctly delete menus in failure cases in MENU_GetSystemMenu. CORE...
Thomas Faber [Sat, 3 Mar 2018 07:19:48 +0000 (08:19 +0100)]
[WIN32K:NTUSER] Correctly delete menus in failure cases in MENU_GetSystemMenu. CORE-12180

2 years ago[WIN32K:NTUSER] Handle IntCloneMenu failure in MENU_GetSystemMenu. CORE-12180
Thomas Faber [Sat, 3 Mar 2018 07:19:13 +0000 (08:19 +0100)]
[WIN32K:NTUSER] Handle IntCloneMenu failure in MENU_GetSystemMenu. CORE-12180

2 years ago[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809
Thomas Faber [Sat, 3 Mar 2018 07:18:34 +0000 (08:18 +0100)]
[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809

2 years ago[STORPORT][DDK] Add the StorPortExtendedFunction stub
Eric Kohl [Sat, 3 Mar 2018 13:19:33 +0000 (14:19 +0100)]
[STORPORT][DDK] Add the StorPortExtendedFunction stub
- Add the StorPortExtendedFunction stub to the storport driver.
- Add the declaration of StorPortExtendedFunction to the ddk.

CORE-12695

2 years ago[TRANSLATION] Some translations update
Sergey Stopkin [Fri, 2 Mar 2018 15:23:30 +0000 (21:23 +0600)]
[TRANSLATION] Some translations update

2 years ago[COM_APITEST] Add some interfaces.
Thomas Faber [Fri, 2 Mar 2018 13:15:08 +0000 (14:15 +0100)]
[COM_APITEST] Add some interfaces.

2 years ago[COM_APITEST] Fix test failures on Win2003.
Thomas Faber [Fri, 2 Mar 2018 13:14:53 +0000 (14:14 +0100)]
[COM_APITEST] Fix test failures on Win2003.

2 years ago[NTOS:KE] Don't loop indefinitely trying to figure out the CPU frequency. CORE-14419
Thomas Faber [Thu, 1 Mar 2018 09:36:27 +0000 (10:36 +0100)]
[NTOS:KE] Don't loop indefinitely trying to figure out the CPU frequency. CORE-14419

Previously, we would keep sampling the CPU frequency until two subsequent
samples differed by at most 1 MHz. This could take several seconds, and would
unnecessarily delay boot.
Instead, if sampling is too unreliable, just give up and calculate the average
frequency from 10 samples. This is no worse than picking the frequency that
just happened to be returned twice in a row.

The fact that this method of sampling fails could indicate that there's a
problem with our performance counter implementation or timer interrupt,
but that's a separate issue...

2 years ago[TELEPHON.CPL] Include winuser.h in the rc which is needed for manifest_hosted.rc
Giannis Adamopoulos [Thu, 1 Mar 2018 08:05:12 +0000 (10:05 +0200)]
[TELEPHON.CPL] Include winuser.h in the rc which is needed for manifest_hosted.rc
Add a check in manifest_hosted.rc to make sure that winuser.h is included

2 years ago[BEEPMIDI] Don't busy-wait when no notes are playing. CORE-12860
Thomas Faber [Tue, 27 Feb 2018 17:36:22 +0000 (18:36 +0100)]
[BEEPMIDI] Don't busy-wait when no notes are playing. CORE-12860

- Use a new work_available event to allow ProcessPlayingNotes to sleep when no
  notes are to be played.
- Get rid of the pointless thread_termination_complete event, wait on the
  thread handle instead.
- Don't leak thread_handle.

2 years ago[SHIMGVW] -Add the 123 manifest to load the v6 comctl32. CORE-14415
Giannis Adamopoulos [Thu, 1 Mar 2018 07:20:44 +0000 (09:20 +0200)]
[SHIMGVW] -Add the 123 manifest to load the v6 comctl32. CORE-14415
This shows that we may have problems in the future with applications using just comctl32 v5

2 years ago[DESK] Fix text truncation in fr-FR.rc
Joachim Henze [Wed, 28 Feb 2018 22:00:31 +0000 (23:00 +0100)]
[DESK] Fix text truncation in fr-FR.rc

CORE-13514

2 years ago[MMSYS] fix text truncation in fr-FR.rc
Joachim Henze [Wed, 28 Feb 2018 20:19:42 +0000 (21:19 +0100)]
[MMSYS] fix text truncation in fr-FR.rc

CORE-13508

2 years ago[NTOKSRNL] Don't blindly schedule read-ahead on CcCopyRead() call.
Pierre Schweitzer [Wed, 28 Feb 2018 19:54:53 +0000 (20:54 +0100)]
[NTOKSRNL] Don't blindly schedule read-ahead on CcCopyRead() call.

This avoids locking Cc for too long by trying to read-ahead data which
is already in cache.
We now will only schedule a read ahead if next read should bring us
to a new VACB (perhaps not in cache).

This notably fixes Inkscape setup which was slown down by read-ahead
due to continous 1 byte reads.

Thanks to Thomas for his help on this issue.

CORE-14395

2 years ago[STOBJECT] Use timers to distinguish between single and double clicks
Eric Kohl [Wed, 28 Feb 2018 19:29:29 +0000 (20:29 +0100)]
[STOBJECT] Use timers to distinguish between single and double clicks
- Volume, Power and Hotplug icon: Use timers to distinguish between single and double clicks.
- Volume icon: Show the tray volume dialog on a single click.

2 years ago[EXPLORER] CTrayWindow: Set the initial lock state in the band site
Giannis Adamopoulos [Wed, 28 Feb 2018 15:14:00 +0000 (17:14 +0200)]
[EXPLORER] CTrayWindow: Set the initial lock state in the band site
This alongside the previous commit, fix locking and unlocking the taskbar.

2 years ago[BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo
Giannis Adamopoulos [Wed, 28 Feb 2018 15:16:46 +0000 (17:16 +0200)]
[BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo
Only BSIS_LOCKED, BSIS_NOGRIPPER, BSIS_ALWAYSGRIPPER and BSIS_NOCAPTION supported so far.

2 years ago[BROWSEUI] CBandSite: Style fixes
Giannis Adamopoulos [Wed, 28 Feb 2018 14:22:37 +0000 (16:22 +0200)]
[BROWSEUI] CBandSite: Style fixes

2 years ago[TRANSLATION] Completed German translation in taskmgr
Simon Dräger [Mon, 26 Feb 2018 12:32:43 +0000 (13:32 +0100)]
[TRANSLATION] Completed German translation in taskmgr

2 years ago[USER32] Small fixes for messages carrying pointers
Giannis Adamopoulos [Sat, 24 Feb 2018 18:26:24 +0000 (20:26 +0200)]
[USER32] Small fixes for messages carrying pointers
SendNotifyMessageW: It doesn't support messages with pointers so there is no need to call MsgiUMToKMMessage
SendMessageTimeoutW, SendMessageTimeoutA: These two do support marshaling pointers so they need to use MsgiUMToKMMessage.
This is actually a bug that happens only in the rare case where we send a WM_COPYDATA with a timeout.

2 years ago[WINSRV] Implement sending the hard error balloon package to explorer
Giannis Adamopoulos [Thu, 22 Feb 2018 17:15:45 +0000 (19:15 +0200)]
[WINSRV] Implement sending the hard error balloon package to explorer
[EXPLORER] Implement showing the hard error balloon

2 years ago[SNDVOL32] Add the tray volume dialog
Eric Kohl [Sun, 25 Feb 2018 20:58:34 +0000 (21:58 +0100)]
[SNDVOL32] Add the tray volume dialog
- Add the tray volume dialog (run "sndvol32 /t").
- Add a simple command line parser.

2 years ago[ADVAPI32] Few improvements for Services.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 22:35:35 +0000 (23:35 +0100)]
[ADVAPI32] Few improvements for Services.

- Set some last errors.
- Fix error code returned by ScLookupServiceByServiceName().
- Check the validity of the handler proc in RegisterServiceCtrlHandler(Ex)W().
- Improve some traces; comment some code.

2 years ago[ADVAPI32] Code formatting + improve two traces.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 18:40:08 +0000 (19:40 +0100)]
[ADVAPI32] Code formatting + improve two traces.

2 years ago[ADVAPI32] ScStartService(): Just start the thread straight ahead, and return a suita...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 18:02:38 +0000 (19:02 +0100)]
[ADVAPI32] ScStartService(): Just start the thread straight ahead, and return a suitable error code if thread creation failed.

2 years ago[ADVAPI32] Take into account the service handler context when dispatching a control...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 17:53:05 +0000 (18:53 +0100)]
[ADVAPI32] Take into account the service handler context when dispatching a control notification to a service. (Used e.g. by tcpsvcs.)

2 years ago[ADVAPI32] Use RPC types where needed. Comments cleanup.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 15:31:00 +0000 (16:31 +0100)]
[ADVAPI32] Use RPC types where needed. Comments cleanup.

2 years ago[TRANSLATION] Completed German translation in stobject (#401)
Simon Dräger [Sun, 25 Feb 2018 22:36:05 +0000 (23:36 +0100)]
[TRANSLATION] Completed German translation in stobject (#401)

2 years ago[TRANSLATION] Minor German grammatical improvements
Simon Dräger [Sun, 25 Feb 2018 14:21:35 +0000 (15:21 +0100)]
[TRANSLATION] Minor German grammatical improvements

2 years ago[ADVAPI32_APITEST] Open services & SCM handles with correct access rights; improve...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 15:09:21 +0000 (16:09 +0100)]
[ADVAPI32_APITEST] Open services & SCM handles with correct access rights; improve a check order.

2 years ago[CONTRIBUTING] Update .gitmessage
Alexander Shaposhnikov [Sun, 25 Feb 2018 14:14:41 +0000 (16:14 +0200)]
[CONTRIBUTING] Update .gitmessage

The template is made more clear and specific.
Added non-mandatory width hints.

2 years ago[SC] Support the paramchange and netbind* control codes in the control command
Eric Kohl [Sun, 25 Feb 2018 13:08:16 +0000 (14:08 +0100)]
[SC] Support the paramchange and netbind* control codes in the control command

2 years ago[SC][SERVICES] Support SERVICE_CONTROL_PARAMCHANGE and SERVICE_CONTROL_NETBIND* contr...
Eric Kohl [Sun, 25 Feb 2018 10:07:14 +0000 (11:07 +0100)]
[SC][SERVICES] Support SERVICE_CONTROL_PARAMCHANGE and SERVICE_CONTROL_NETBIND* control codes

2 years ago[CDFS_NEW] Sync with HEAD.
Pierre Schweitzer [Sun, 25 Feb 2018 09:13:15 +0000 (10:13 +0100)]
[CDFS_NEW] Sync with HEAD.

CORE-14315

2 years ago[BOOTDATA] Do not include caroots.inf in registry.inf. CORE-12020
Thomas Faber [Sat, 24 Feb 2018 17:01:58 +0000 (18:01 +0100)]
[BOOTDATA] Do not include caroots.inf in registry.inf. CORE-12020

This splits registry.inf roughly in half, which massively reduces heap usage
in 1st stage. DPH and low-memory scenarios benefit from this.

2 years ago[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:48:43 +0000 (00:48 +0100)]
[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths.

2 years ago[SERVICES] Send services shutdown notifications only if they accept them.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:31:17 +0000 (00:31 +0100)]
[SERVICES] Send services shutdown notifications only if they accept them.

2 years ago[SERVICES] Add french translation.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:06:27 +0000 (00:06 +0100)]
[SERVICES] Add french translation.

2 years ago[TRANSLATION] German syntax fix. 399/head
Simon Dräger [Sat, 24 Feb 2018 16:13:53 +0000 (17:13 +0100)]
[TRANSLATION] German syntax fix.

It is rather unusual to put a "then" after "If..", so removed that.

2 years ago[BOOTDATA] Fix path to temp folder for the Swedish locale (#381)
Harteex [Sat, 24 Feb 2018 22:08:55 +0000 (23:08 +0100)]
[BOOTDATA] Fix path to temp folder for the Swedish locale (#381)

2 years ago[NTOSKRNL] Implement ThreadHideFromDebugger in NtSetInformationThread()
Pierre Schweitzer [Sat, 24 Feb 2018 21:06:18 +0000 (22:06 +0100)]
[NTOSKRNL] Implement ThreadHideFromDebugger in NtSetInformationThread()

2 years ago[ACLAYERS] Add WIN8 and WIN81 VersionLie shims
Mark Jansen [Sat, 10 Feb 2018 14:31:55 +0000 (15:31 +0100)]
[ACLAYERS] Add WIN8 and WIN81 VersionLie shims

2 years ago[APPSHIM_APITEST] Add Win8 and Win81 versionlie tests
Mark Jansen [Sat, 10 Feb 2018 14:31:06 +0000 (15:31 +0100)]
[APPSHIM_APITEST] Add Win8 and Win81 versionlie tests

2 years ago[ACPPAGE] Enable version lies until Win7 + some cleanup
Mark Jansen [Tue, 6 Feb 2018 18:32:51 +0000 (19:32 +0100)]
[ACPPAGE] Enable version lies until Win7 + some cleanup

2 years ago[APPHELP] Set debug level in case of parse failure
Mark Jansen [Tue, 6 Feb 2018 18:32:26 +0000 (19:32 +0100)]
[APPHELP] Set debug level in case of parse failure

2 years ago[SERVMAN] Add an accelerator for the F5 (refresh) key
Eric Kohl [Sat, 24 Feb 2018 17:38:08 +0000 (18:38 +0100)]
[SERVMAN] Add an accelerator for the F5 (refresh) key

CORE-14389

2 years ago[WIN32K] Get rid of some instances of the ugly RETURN() macro
Timo Kreuzer [Sat, 9 Sep 2017 12:42:53 +0000 (14:42 +0200)]
[WIN32K] Get rid of some instances of the ugly RETURN() macro

2 years ago[FORMATTING] Fix indentation, no functional changes.
Timo Kreuzer [Mon, 19 Feb 2018 14:04:38 +0000 (15:04 +0100)]
[FORMATTING] Fix indentation, no functional changes.

2 years ago[NTOSKRNL] Implement the support for reserve IRP in IO
Pierre Schweitzer [Sat, 24 Feb 2018 13:50:23 +0000 (14:50 +0100)]
[NTOSKRNL] Implement the support for reserve IRP in IO

The reserve IRP is an IRP which is allocated on system boot and kept during
the whole system life. Its purpose is to allow page reads in case of
low-memory situations where the system doesn't have enough memory left
to allocate an IRP to read from the page file (would be catastrophic situation).

2 years ago[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters
Pierre Schweitzer [Sat, 24 Feb 2018 13:02:33 +0000 (14:02 +0100)]
[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters

2 years ago[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:47:15 +0000 (13:47 +0100)]
[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters

2 years ago[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerNam...
Thomas Faber [Sat, 24 Feb 2018 13:15:48 +0000 (14:15 +0100)]
[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerName in PathUnExpandEnvStrings) by Katayama Hirofumi MZ. CORE-13816

2 years ago[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handl...
Thomas Faber [Sat, 24 Feb 2018 13:14:35 +0000 (14:14 +0100)]
[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handles) by Mark Jansen.

2 years ago[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.
Thomas Faber [Sat, 24 Feb 2018 11:05:12 +0000 (12:05 +0100)]
[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.

2 years ago[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation
Pierre Schweitzer [Sat, 24 Feb 2018 12:35:17 +0000 (13:35 +0100)]
[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation

2 years ago[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:28:45 +0000 (13:28 +0100)]
[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters

2 years ago[SERVICES][ADVAPI32] Fix the broken service stop sequence
Eric Kohl [Sat, 24 Feb 2018 10:14:05 +0000 (11:14 +0100)]
[SERVICES][ADVAPI32] Fix the broken service stop sequence

services\database.c:
- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

services\rpcserver.c:
- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

advapi32\service\sctrl.c:
- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).

CORE-12413

2 years ago[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)
Serge Gautherie [Fri, 23 Feb 2018 17:35:02 +0000 (18:35 +0100)]
[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)

2 years ago[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
Giannis Adamopoulos [Fri, 23 Feb 2018 10:27:48 +0000 (12:27 +0200)]
[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.

2 years ago[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.
Mark Jansen [Thu, 22 Feb 2018 22:25:34 +0000 (23:25 +0100)]
[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.
CORE-14376

2 years ago[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks
Serge Gautherie [Thu, 22 Feb 2018 15:03:42 +0000 (16:03 +0100)]
[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks

Addendum to 22037684e42e29abc99a9a280278b16305eaa2e2.

- Result: check "== FALSE" not "= TRUE".
- Report compared values, not different ones.

CORE-11819

2 years ago[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead. 390/head
Thomas Faber [Tue, 20 Feb 2018 12:49:54 +0000 (13:49 +0100)]
[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead.

2 years ago[NTOS:CC] Avoid some magic numbers.
Thomas Faber [Tue, 20 Feb 2018 12:18:34 +0000 (13:18 +0100)]
[NTOS:CC] Avoid some magic numbers.

2 years ago[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194
Thomas Faber [Thu, 22 Feb 2018 10:51:07 +0000 (11:51 +0100)]
[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194

2 years ago[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353
Thomas Faber [Thu, 22 Feb 2018 10:28:55 +0000 (11:28 +0100)]
[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353

2 years ago[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.
Pierre Schweitzer [Wed, 21 Feb 2018 21:50:23 +0000 (22:50 +0100)]
[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.

CORE-11819

2 years ago[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353
Thomas Faber [Wed, 21 Feb 2018 17:40:23 +0000 (18:40 +0100)]
[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353

2 years ago[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298
Thomas Faber [Wed, 21 Feb 2018 14:16:47 +0000 (15:16 +0100)]
[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298

2 years ago[VFATLIB] Fix FAT partitions formatting in a non clean fashion.
Pierre Schweitzer [Tue, 20 Feb 2018 23:16:36 +0000 (00:16 +0100)]
[VFATLIB] Fix FAT partitions formatting in a non clean fashion.

(So the fun begins)
In spite of what VFATLIB headers pretend, there's not magic in FAT boot sector.
The 3 first bytes are just the jump instruction (to the boot code). No jump, no boot.
Also, some (many?) FAT implementations rely on the jump code to help detecting that
a FAT volume is really a FAT volume. Like MS FastFAT. Or our own FAT recognizer in FS_REC.
The story is that, up to that commit, we zeroed the 3 first bytes; leading to broken
FAT volumes.
This got hidden in most cases by the fact that during setup, when we install boot
loader, we erase parts of the boot sector, including the jump instruction, making the
volume valid again. But that wouldn't fix secondary volumes where the boot loader isn't
installed.
And, also, imagine a scenario where you want to install ReactOS on a newly formatted volume
with MS FastFAT instead of our own implementation... That would simply not work to
the fact that the driver wouldn't recognize the fresh formatted volume!

(So the non fashion begins)
Fix this by putting a not that valid jump into the boot sector when formatting our
partitions. That way, our volume is always regarding a FAT view point. But, instead of
putting values that mean (nearly) nothing. We should also put a dummy bootloader
displaying the user and error message, as done by dosfstools.

(So the hope begins)
This opens the way for trying to install ReactOS with MS FastFAT (doesn't work yet).

CORE-11819
CORE-14362

2 years ago[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)
Serge Gautherie [Tue, 20 Feb 2018 18:45:55 +0000 (19:45 +0100)]
[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)

2 years ago[SHELL32] CShellItem: Fix GetDisplayName and Compare
Giannis Adamopoulos [Tue, 20 Feb 2018 14:59:00 +0000 (16:59 +0200)]
[SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.

2 years ago[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on...
Giannis Adamopoulos [Tue, 20 Feb 2018 14:31:28 +0000 (16:31 +0200)]
[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine
Fixes lots of tests.

2 years ago[SHELL32] CShellItem: Fix return value of Compare method
Giannis Adamopoulos [Tue, 20 Feb 2018 12:36:31 +0000 (14:36 +0200)]
[SHELL32] CShellItem: Fix return value of Compare method

2 years ago[SHELL32] CDefaultContextMenu: Implement GetCommandString
Giannis Adamopoulos [Tue, 20 Feb 2018 11:05:59 +0000 (13:05 +0200)]
[SHELL32] CDefaultContextMenu: Implement GetCommandString