reactos.git
11 months ago[WINSPOOL] GetPrinterDriverA(): Refactor failure handling (#2832)
Serge Gautherie [Tue, 26 May 2020 18:21:25 +0000 (20:21 +0200)]
[WINSPOOL] GetPrinterDriverA(): Refactor failure handling (#2832)

* [WINSPOOL] GetPrinterDriverA(): Refactor failure handling

Addendum to d90beaeed26863985486874aaa2a1c3422fd6d9f.

11 months ago[CSRSRV] CsrGetProcessLuid(): Check 1st NtQueryInformationToken() result too (#2857)
Serge Gautherie [Mon, 25 May 2020 21:52:35 +0000 (23:52 +0200)]
[CSRSRV] CsrGetProcessLuid(): Check 1st NtQueryInformationToken() result too (#2857)

Detected by Cppcheck: redundantAssignment.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
11 months ago[NTVDM] GetNextFreeVDDEntry(): Remove 'Entry' redundant initialization (#2859)
Serge Gautherie [Mon, 25 May 2020 21:49:47 +0000 (23:49 +0200)]
[NTVDM] GetNextFreeVDDEntry(): Remove 'Entry' redundant initialization (#2859)

Detected by Cppcheck: redundantInitialization.
Addendum to ed874b41 (r61283).

11 months ago[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)
Serge Gautherie [Mon, 25 May 2020 17:57:52 +0000 (19:57 +0200)]
[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)

CORE-17079

11 months ago[HAL:HALPPC] HalAllocateCrashDumpRegisters(): Remove redundant MapRegisterNumber...
Serge Gautherie [Mon, 25 May 2020 16:58:17 +0000 (18:58 +0200)]
[HAL:HALPPC] HalAllocateCrashDumpRegisters(): Remove redundant MapRegisterNumber assignment (#2854)

Detected by CppCheck: redundantAssignment.
Addendum to commit 81f09273 (r28793).

11 months ago[PROCESSR][INF] Fix "Intel Intel" duplication typos
Stanislav Motylkov [Sun, 24 May 2020 23:36:17 +0000 (02:36 +0300)]
[PROCESSR][INF] Fix "Intel Intel" duplication typos

Addendum to 3509318.

11 months ago[NTOS:PO] Report correct CPU frequency in CurrentMhz
Stanislav Motylkov [Sun, 24 May 2020 22:24:52 +0000 (01:24 +0300)]
[NTOS:PO] Report correct CPU frequency in CurrentMhz

Also add some relevant FIXME comments. CORE-13206

11 months ago[NTOS:INBV] Fix hardcoded values (#2840)
Yaroslav Kibysh [Sun, 24 May 2020 17:37:47 +0000 (20:37 +0300)]
[NTOS:INBV] Fix hardcoded values (#2840)

11 months ago[NTOS:EX] ExpInitializeExecutive(): Fix 'PerfMem' copypasta (#2841)
Serge Gautherie [Sun, 24 May 2020 17:37:16 +0000 (19:37 +0200)]
[NTOS:EX] ExpInitializeExecutive(): Fix 'PerfMem' copypasta (#2841)

Detected by Cppcheck: identicalInnerCondition.
Addendum to commit c307d73c (r25621).

11 months ago[ADVAPI32] Convert ordinals to @ in spec file
Timo Kreuzer [Sat, 29 Feb 2020 08:37:20 +0000 (09:37 +0100)]
[ADVAPI32] Convert ordinals to @ in spec file

11 months ago[TRANSLATION] Hungarian translation update for shell32 (#2828)
Tibor Lajos Füzi [Sat, 23 May 2020 17:20:16 +0000 (19:20 +0200)]
[TRANSLATION] Hungarian translation update for shell32 (#2828)

11 months ago[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)
Serge Gautherie [Sat, 23 May 2020 17:07:04 +0000 (19:07 +0200)]
[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)

Reported by contributor 'qarmin'.
CORE-17074

11 months ago[NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is
Timo Kreuzer [Thu, 29 Aug 2019 20:10:49 +0000 (22:10 +0200)]
[NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is

11 months ago[NTOSKRNL] Sync some INIT_FUNCTION (#2824)
Serge Gautherie [Sat, 23 May 2020 14:05:58 +0000 (16:05 +0200)]
[NTOSKRNL] Sync some INIT_FUNCTION (#2824)

- Sync some INIT_FUNCTION with how they are used and what is already
  specified in the headers.
Addendum to commit 85e5b5be (r49445).

- KdbpGetCommandLineSettings(): Remove INIT_FUNCTION.
Fix MSVC 2015 x86 custom build:
"...\ntoskrnl\kdbg\kdb.c(1699): error C2983: 'KdbpGetCommandLineSettings': all declarations must have an identical __declspec(code_seg(...))"

And may also fix obscure bugs when entering into the KDBG debugger.

11 months ago[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)
Serge Gautherie [Sat, 23 May 2020 13:56:10 +0000 (15:56 +0200)]
[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)

(but after 'static' or SAL 2 annotation.)
Follow-up to 71fefa32, which mentions that it's actually required by the compiler in some circumstances.

11 months ago[APPWIZ] Polish translation update (#2790)
Piotr Hetnarowicz [Sat, 23 May 2020 13:43:56 +0000 (15:43 +0200)]
[APPWIZ] Polish translation update (#2790)

FIXED: dialogs, button, description

11 months ago[MC] Update Polish translation of netmsgmsg.mc (#2691)
Piotr Hetnarowicz [Sat, 23 May 2020 13:42:11 +0000 (15:42 +0200)]
[MC] Update Polish translation of netmsgmsg.mc (#2691)

Co-authored-by: Adam Słaboń <asaillen456esx@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
11 months ago[RAPPS] Update Portuguese translation (#2820)
Jose Carlos Jesus [Sat, 23 May 2020 13:17:52 +0000 (14:17 +0100)]
[RAPPS] Update Portuguese translation (#2820)

Update translation following PR #2792.

11 months ago[USERENV] Implement DeleteProfileW()
Eric Kohl [Sat, 23 May 2020 10:37:16 +0000 (12:37 +0200)]
[USERENV] Implement DeleteProfileW()

11 months ago[SAMSRV] SampInitializeSAM: Fix indentation and add comments
Eric Kohl [Sat, 23 May 2020 09:27:35 +0000 (11:27 +0200)]
[SAMSRV] SampInitializeSAM: Fix indentation and add comments

11 months ago[WINSPOOL] GetPrinterA(): Refactor failure handling (#2830)
Serge Gautherie [Sat, 23 May 2020 07:08:00 +0000 (09:08 +0200)]
[WINSPOOL] GetPrinterA(): Refactor failure handling (#2830)

Addendum to ecde3768254664ca40a3f2fa49d1342d4bd92c02.

11 months ago[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French trans...
Kyle Katarn [Fri, 22 May 2020 13:53:17 +0000 (15:53 +0200)]
[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French translation update (#2807)

As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Similar to #2743 by @HBelusca

11 months ago[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810)
Kyle Katarn [Fri, 22 May 2020 13:49:27 +0000 (15:49 +0200)]
[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810)

- PS2 Mouse Advanced Properties : Static control (frame) added
- PS2 Mouse Advanced Properties : French translation added and control layout adapted accordingly
- Mouse CPL > Wheel > Sroll line text box ES_NUMBER style added
- ReactOS Setup : French translation added

11 months ago[BROWSER] Add the browser service
Eric Kohl [Thu, 21 May 2020 20:49:33 +0000 (22:49 +0200)]
[BROWSER] Add the browser service

11 months ago[UMPNPMGR] Start work on PNP_GetNextResDes()
Eric Kohl [Thu, 21 May 2020 19:49:46 +0000 (21:49 +0200)]
[UMPNPMGR] Start work on PNP_GetNextResDes()

11 months ago[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826)
Serge Gautherie [Thu, 21 May 2020 16:52:50 +0000 (18:52 +0200)]
[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826)

Addendum to 612729b09272aeb693e156de6b5991891951dbf2.

CORE-17069

11 months ago[ACCESS.CPL] Improvements to Portuguese translation (#2800)
Jose Carlos Jesus [Thu, 21 May 2020 13:36:33 +0000 (14:36 +0100)]
[ACCESS.CPL] Improvements to Portuguese translation (#2800)

11 months ago[NTOS:INBV] Fix screen flash and more (#2821)
Yaroslav Kibysh [Wed, 20 May 2020 22:23:17 +0000 (01:23 +0300)]
[NTOS:INBV] Fix screen flash and more (#2821)

- Fix screen flash (CORE-16786);
- Don't process rotating bar if not used.

11 months ago[RAPPS] Rapps trivial fixes (#2819)
He Yang [Wed, 20 May 2020 22:21:26 +0000 (06:21 +0800)]
[RAPPS] Rapps trivial fixes (#2819)

- Specify W explicitly for URL_COMPONENTS;
- Remove malloc/free for once used HostName in urlComponents;
- Use PathAppendW to operate on path string.

11 months ago[SDK][FREETYPE] Fix GCC8.4 -O2 build
Victor Perevertkin [Wed, 20 May 2020 22:07:26 +0000 (01:07 +0300)]
[SDK][FREETYPE] Fix GCC8.4 -O2 build

11 months ago[REACTOS] Remove executable bits on source files (#2822)
Serge Gautherie [Wed, 20 May 2020 21:09:44 +0000 (23:09 +0200)]
[REACTOS] Remove executable bits on source files (#2822)

11 months ago[UMPNPMGR] Improve some debug messages
Eric Kohl [Sun, 17 May 2020 18:35:41 +0000 (20:35 +0200)]
[UMPNPMGR] Improve some debug messages

11 months ago[RAPPS] French translation update following PR #2792 (#2815)
Kyle Katarn [Wed, 20 May 2020 14:05:12 +0000 (16:05 +0200)]
[RAPPS] French translation update following PR #2792 (#2815)

11 months ago[MAIN.CPL] Fix of Keyboard settings French translation (#2812)
Kyle Katarn [Wed, 20 May 2020 13:47:24 +0000 (15:47 +0200)]
[MAIN.CPL] Fix of Keyboard settings French translation (#2812)

11 months ago[TIMEDATE] French translation (#2811)
Kyle Katarn [Wed, 20 May 2020 13:45:47 +0000 (15:45 +0200)]
[TIMEDATE] French translation (#2811)

11 months ago[SHELL32] Allow creation of an empty CFileSysEnum
Mark Jansen [Tue, 19 May 2020 18:35:52 +0000 (20:35 +0200)]
[SHELL32] Allow creation of an empty CFileSysEnum
CORE-16908

11 months ago[SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028
Joachim Henze [Tue, 19 May 2020 18:32:21 +0000 (20:32 +0200)]
[SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028

The build broke due to a typo introduced by
0.4.15-dev-275-g
612729b09272aeb693e156de6b5991891951dbf2

../dll/win32/syssetup/wizard.c: In function 'ProductPageDlgProc':
../dll/win32/syssetup/wizard.c:527:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-
after-statement]
cc1.exe: all warnings being treated as errors

11 months ago[RAPPS] Move database source URL to settings dialog (#2792)
He Yang [Tue, 19 May 2020 17:06:10 +0000 (01:06 +0800)]
[RAPPS] Move database source URL to settings dialog (#2792)

- Add download source in settings dialog, and apply it when download .cab file
- Now user should specify full rappmgr.cab URL
- Check if URL is vaild in settings dialog
- Move source settings to the end of struct (will refactor settings to one value per option later)

11 months ago[JOY] Fix missing UI elements and French translation (#2808)
Kyle Katarn [Tue, 19 May 2020 10:09:05 +0000 (12:09 +0200)]
[JOY] Fix missing UI elements and French translation (#2808)

Missing GUI elements added.
Improve French translation.

11 months ago[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749)
Katayama Hirofumi MZ [Tue, 19 May 2020 06:41:26 +0000 (15:41 +0900)]
[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749)

- Make "ReactOS Server" the default product option again instead of "ReactOS Workstation".
- Write "Service Pack" info onto registry.
- Add ProductOption option to bootcd unattend.inf.
- Delete IDC_PRODUCT_SUITE and IDC_PRODUCT_TYPE controls.
CORE-17028

11 months ago[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2797)
Katayama Hirofumi MZ [Tue, 19 May 2020 00:29:42 +0000 (09:29 +0900)]
[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2797)

Investigate on nSources and fRecursive parameters. CORE-13950

11 months ago[SHELL32_APITEST] Disabled DragDrop test due to race condition
Victor Perevertkin [Mon, 18 May 2020 17:50:07 +0000 (20:50 +0300)]
[SHELL32_APITEST] Disabled DragDrop test due to race condition
To be enabled back when the bug is fixed
CORE-17057

11 months ago[CMD] Add a ExecuteCommandWithEcho() helper and use it in Batch() and as the implemen...
Hermès Bélusca-Maïto [Mon, 18 May 2020 00:03:15 +0000 (02:03 +0200)]
[CMD] Add a ExecuteCommandWithEcho() helper and use it in Batch() and as the implementation of RunInstance() FOR-loop helper.

11 months ago[CMD] Fix the stop-batch prompt appearance: do not display it more than once in a...
Hermès Bélusca-Maïto [Sun, 17 May 2020 18:13:32 +0000 (20:13 +0200)]
[CMD] Fix the stop-batch prompt appearance: do not display it more than once in a row.

11 months ago[CMD] Fix the ErrorMessage() function.
Hermès Bélusca-Maïto [Sun, 17 May 2020 18:08:41 +0000 (20:08 +0200)]
[CMD] Fix the ErrorMessage() function.

Specify its szFormat parameter optional, and correctly initialize the
szMessage buffer.

11 months ago[DESK][TIMEDATE] Update Portuguese translation (#2801)
Jose Carlos Jesus [Sun, 17 May 2020 21:53:54 +0000 (22:53 +0100)]
[DESK][TIMEDATE] Update Portuguese translation (#2801)

11 months ago[EVENTVWR] Update polish translation (#2804)
Adam Stachowicz [Sun, 17 May 2020 21:39:56 +0000 (23:39 +0200)]
[EVENTVWR] Update polish translation (#2804)

After commit 8756cec0.

11 months ago[FREELDR] Fix I/O range size of serial ports
Hervé Poussineau [Sun, 17 May 2020 20:49:47 +0000 (22:49 +0200)]
[FREELDR] Fix I/O range size of serial ports

11 months ago[NTOS:OB] Fix incorrect variable name in ObfDereferenceObject.
Thomas Faber [Fri, 8 May 2020 15:53:29 +0000 (17:53 +0200)]
[NTOS:OB] Fix incorrect variable name in ObfDereferenceObject.

11 months ago[NTOS] Prohibit use of MAX_PATH in the kernel. Use MAX_WIN32_PATH if you really mean...
Thomas Faber [Sun, 31 Mar 2019 07:18:16 +0000 (09:18 +0200)]
[NTOS] Prohibit use of MAX_PATH in the kernel. Use MAX_WIN32_PATH if you really mean it. CORE-15882

11 months ago[NTOS:PNP] Directly accept a UNICODE_STRING in LocateChildDevice. CORE-15882 2720/head
Thomas Faber [Sat, 2 May 2020 15:57:46 +0000 (17:57 +0200)]
[NTOS:PNP] Directly accept a UNICODE_STRING in LocateChildDevice. CORE-15882

11 months ago[NTOS:PNP] Avoid an unnecessary stack buffer in PnpRootCreateDevice. CORE-15882
Thomas Faber [Sat, 2 May 2020 15:42:40 +0000 (17:42 +0200)]
[NTOS:PNP] Avoid an unnecessary stack buffer in PnpRootCreateDevice. CORE-15882

11 months ago[NTOS:PNP] Avoid an unnecessary stack buffer in EnumerateDevices. CORE-15882
Thomas Faber [Sat, 2 May 2020 15:33:24 +0000 (17:33 +0200)]
[NTOS:PNP] Avoid an unnecessary stack buffer in EnumerateDevices. CORE-15882

11 months ago[NTOS:PNP] Move child device creation into its own function
Thomas Faber [Sat, 2 May 2020 15:08:12 +0000 (17:08 +0200)]
[NTOS:PNP] Move child device creation into its own function

Also fix some leaks and a DPRINT format string.

11 months ago[SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP)
Eric Kohl [Sun, 17 May 2020 17:37:49 +0000 (19:37 +0200)]
[SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP)

11 months ago[EVENTVWR] Implementation of Properties page functionnal code. (#2744)
Kyle Katarn [Sun, 17 May 2020 16:54:39 +0000 (18:54 +0200)]
[EVENTVWR] Implementation of Properties page functionnal code. (#2744)

Implementation of functional code for log properties page in order to allow user to :
- Make modification and have them taken into account when properties page is closed / apply is used;
- Set defaults (including correction of default max size);
- Delete content of log;
- Make "Apply" button functional based on user inputs;
- Correct default value during installation (duration, size).

- Improve InitPropertiesDlg() error;
- Fix SavePropertiesDlg(): When the event log key does not exist, it is not recreated by the event log viewer.
- GetDisplayNameFileAndID(): Show the error also when opening the event log key fails.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
11 months ago[CHARMAP_NEW] Remove non-existing entries. basque_translation
Hermès Bélusca-Maïto [Sun, 17 May 2020 16:46:14 +0000 (18:46 +0200)]
[CHARMAP_NEW] Remove non-existing entries.

11 months ago[TRANSLATION] Update Spanish, and add Basque translation (#2667)
Julen Urizar Compains [Sun, 26 Apr 2020 03:49:07 +0000 (05:49 +0200)]
[TRANSLATION] Update Spanish, and add Basque translation (#2667)

Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.

11 months ago[BOOTVID][HALXBOX] Implement boot video driver for Xbox (#2774) 2774/head
Stanislav Motylkov [Tue, 12 May 2020 14:32:37 +0000 (17:32 +0300)]
[BOOTVID][HALXBOX] Implement boot video driver for Xbox (#2774)

Also make HalpBiosDisplayReset() function always return FALSE,
because we don't have a BIOS on Xbox.

CORE-16216 CORE-16219

11 months ago[ACPPAGE] Add Portuguese translation (#2802)
Jose Carlos Jesus [Sun, 17 May 2020 16:12:11 +0000 (17:12 +0100)]
[ACPPAGE] Add Portuguese translation (#2802)

11 months ago[COMDLG32] Differentiate between real and virtual folders, 2746/head
Mark Jansen [Wed, 6 May 2020 20:04:11 +0000 (22:04 +0200)]
[COMDLG32] Differentiate between real and virtual folders,
do not allow traversal inside virtual folders when selecting a file
CORE-16908

11 months ago[SHELLUTILS] Fix Win32DbgPrint's result
Mark Jansen [Sun, 13 Oct 2019 16:05:34 +0000 (18:05 +0200)]
[SHELLUTILS] Fix Win32DbgPrint's result

11 months ago[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
Mark Jansen [Mon, 27 Apr 2020 18:43:16 +0000 (20:43 +0200)]
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
CORE-16908

11 months ago[SHELL32] Update CFileSysEnum to be maintaineable
Mark Jansen [Mon, 27 Apr 2020 14:11:21 +0000 (16:11 +0200)]
[SHELL32] Update CFileSysEnum to be maintaineable
CORE-16908

11 months ago[SHLWAPI] Fix SHRegGetCLSIDKeyW
Mark Jansen [Mon, 27 Apr 2020 10:53:47 +0000 (12:53 +0200)]
[SHLWAPI] Fix SHRegGetCLSIDKeyW

11 months ago[PSDK] Add argument names to SHRegGetValue functions
Mark Jansen [Mon, 27 Apr 2020 14:00:20 +0000 (16:00 +0200)]
[PSDK] Add argument names to SHRegGetValue functions

11 months ago[NTOS:SE] Implement job case in PsImpersonateClient. CORE-8787 2772/head
Thomas Faber [Mon, 11 May 2020 06:41:38 +0000 (08:41 +0200)]
[NTOS:SE] Implement job case in PsImpersonateClient. CORE-8787

11 months ago[GITHUB] Enable ccache for GCC builds on GitHub Actions
Victor Perevertkin [Sun, 17 May 2020 10:32:14 +0000 (13:32 +0300)]
[GITHUB] Enable ccache for GCC builds on GitHub Actions

11 months ago[SERVICES][DCOMLAUNCH] Don't hardcode C: drive (#2779)
Katayama Hirofumi MZ [Sun, 17 May 2020 08:45:56 +0000 (17:45 +0900)]
[SERVICES][DCOMLAUNCH] Don't hardcode C: drive (#2779)

CORE-13235

11 months ago[ISAPNP] Mark read data port as started, even if no ISAPNP card is present
Hervé Poussineau [Sat, 16 May 2020 21:17:19 +0000 (23:17 +0200)]
[ISAPNP] Mark read data port as started, even if no ISAPNP card is present

CORE-17056

11 months ago[HOST-TOOLS] Fix the build from IDE for visual studio 2019 CE 2799/head
Mark Jansen [Sat, 16 May 2020 16:19:31 +0000 (18:19 +0200)]
[HOST-TOOLS] Fix the build from IDE for visual studio 2019 CE
CORE-16904

11 months ago[REGEDIT] Fix and improvement in TreeView (Null handle check, incorrect display after...
Kyle Katarn [Sat, 16 May 2020 12:23:20 +0000 (14:23 +0200)]
[REGEDIT] Fix and improvement in TreeView (Null handle check, incorrect display after edit, WM_NOTIFY refactor) (#2733)

* - Fix of missing invalid handle check
- Fix of Address & status bar incorrect display after rename
- Refactoring of Treeview WM_NOTIFY code, for better consistency with WM_NOTIFY management for ListView

* Fix following review (space in #define)

* Cleanup following review

* fix following review

* Fix of round 3 of review comments

* UpdateAdress kept in its original location

* fix

* fix (extern missing)

* both extern removed

* Review comments
Error message being added in order to support CORE-17048

11 months ago[CPORTLIB] Fix MSVC build for PC-98 target
Dmitry Borisov [Fri, 15 May 2020 20:09:01 +0000 (02:09 +0600)]
[CPORTLIB] Fix MSVC build for PC-98 target

11 months ago[ISAPNP] Initialize uninitialized variable
Mark Jansen [Sat, 16 May 2020 12:03:04 +0000 (14:03 +0200)]
[ISAPNP] Initialize uninitialized variable
Return value was a suggestion from Thomas,
it still boots for me (tm)

11 months ago[HAL] Remove duplicated IRQL mask tables
Colin Finck [Fri, 15 May 2020 21:46:22 +0000 (23:46 +0200)]
[HAL] Remove duplicated IRQL mask tables

With the minimum Visual Studio version now being 2015, we no longer need to maintain two variants of the same code, and can stick to the commented and better understandable version.

11 months ago[BOOTVID] Add boot video driver for NEC PC-98 series (#2787) 2787/head
Dmitry Borisov [Thu, 14 May 2020 10:36:55 +0000 (16:36 +0600)]
[BOOTVID] Add boot video driver for NEC PC-98 series (#2787)

11 months ago[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)
Jose Carlos Jesus [Fri, 15 May 2020 16:12:02 +0000 (17:12 +0100)]
[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)

During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k.
Therefore their position needs to be recomputed so that they try to fit the best on screen.

CORE-9008, CORE-9602

11 months ago[WS2_32_APITEST:WSAASYNC] Fix and improve some tests. ROSTESTS-317 (#1132)
Serge Gautherie [Fri, 15 May 2020 13:45:35 +0000 (15:45 +0200)]
[WS2_32_APITEST:WSAASYNC] Fix and improve some tests. ROSTESTS-317 (#1132)

- Add getsockname() addr_con_loc looping case.
Fix intermittent failure on Windows (NT <= 6.0):
"WSAAsync.c:232: Test failed: ERROR: getsockname function wrong addr, expected 100007f returned 0"

ROSTESTS-317

- Improve select() ServerSocket looping case.
Visible on Windows (NT >= 6.1).

11 months ago[SHELL32] Don't hardcode C: drive again (#2777)
Katayama Hirofumi MZ [Fri, 15 May 2020 07:36:13 +0000 (16:36 +0900)]
[SHELL32] Don't hardcode C: drive again (#2777)

- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235

12 months ago[SHELL32] Implement SheShortenPathA (#2785)
Katayama Hirofumi MZ [Thu, 14 May 2020 13:52:22 +0000 (22:52 +0900)]
[SHELL32] Implement SheShortenPathA (#2785)

Implement shell32!SheShortenPathA function.

12 months ago[SHELL32] Implement MakeShellURLFromPathA (#2784)
Katayama Hirofumi MZ [Thu, 14 May 2020 13:51:53 +0000 (22:51 +0900)]
[SHELL32] Implement MakeShellURLFromPathA (#2784)

Implement shell32!MakeShellURLFromPathA function.

12 months ago[OPENGLCFG] Empty list boxes if registry key is missing (#2750)
Ricardo Hanke [Thu, 14 May 2020 12:47:48 +0000 (14:47 +0200)]
[OPENGLCFG] Empty list boxes if registry key is missing (#2750)

If the registry key that holds the names of installed opengl drivers is missing, all list boxes in openglcfg are empty. This is a minor code rearrangement to fix this behavior.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
12 months ago[SHELL32] PL-pl Dialogs fix (#2788)
Piotr Hetnarowicz [Thu, 14 May 2020 12:33:32 +0000 (14:33 +0200)]
[SHELL32] PL-pl Dialogs fix (#2788)

- Fixed invisible text in DIALOGS.

12 months ago[NTDLL_APITEST] Add initial NtQueryInformationThread() testcase (#2782)
George Bișoc [Thu, 14 May 2020 12:32:38 +0000 (14:32 +0200)]
[NTDLL_APITEST] Add initial NtQueryInformationThread() testcase (#2782)

12 months ago[NDK][XDK] Add 3 CM_RESOURCE_INTERRUPT_* defines (#2755)
Serge Gautherie [Thu, 14 May 2020 12:31:53 +0000 (14:31 +0200)]
[NDK][XDK] Add 3 CM_RESOURCE_INTERRUPT_* defines (#2755)

12 months ago[SNDREC32] Use the ShellAboutW API routine to display the about dialog (#2754)
Kyle Katarn [Thu, 14 May 2020 12:30:57 +0000 (14:30 +0200)]
[SNDREC32] Use the ShellAboutW API routine to display the about dialog (#2754)

12 months ago[SERVMAN] Use the ShellAboutW API routine to display the about dialog (#2752)
Kyle Katarn [Thu, 14 May 2020 12:30:35 +0000 (14:30 +0200)]
[SERVMAN] Use the ShellAboutW API routine to display the about dialog (#2752)

12 months ago[RAPPS] Use ShellAbout() to display the about dialog (#2751)
Kyle Katarn [Thu, 14 May 2020 12:28:57 +0000 (14:28 +0200)]
[RAPPS] Use ShellAbout() to display the about dialog (#2751)

As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.

12 months ago[SHORTCUTS] Addition of Wine IE Shortcuts in Start Menu (#2726)
Kyle Katarn [Thu, 14 May 2020 12:24:59 +0000 (14:24 +0200)]
[SHORTCUTS] Addition of Wine IE Shortcuts in Start Menu (#2726)

CORE-11257

12 months ago[SYSDM][USRMGR] French translation update (#2765)
Kyle Katarn [Thu, 14 May 2020 12:24:13 +0000 (14:24 +0200)]
[SYSDM][USRMGR] French translation update (#2765)

CORE-16596

12 months ago[TRANSLATIONS] Turkish translation updates (#2724)
Erdem Ersoy [Thu, 14 May 2020 12:23:05 +0000 (15:23 +0300)]
[TRANSLATIONS] Turkish translation updates (#2724)

* [TRANSLATIONS] Translate desk.cpl to Turkish

* Update file header

* [TRANSLATIONS]

* Update translations of syssteup
* Update translations of userenv
* Update translations of shell32 (partial)

* [TRANSLATION] Fix a translation

* [TRANSLATION] Translate Turkish strings to Turkish

for hivedef.inf

* Update Turkish translations of shell32 partially

* Update shell32 Turkish translations (partially)

* Update shell32 Turkish translations (partially)

* Fix translation for desk.cpl

12 months ago[REGAPI] Import regapi.dll from Wine Staging 5.7 CORE-16458 (#2723)
Oleg Dubinskiy [Thu, 14 May 2020 12:21:16 +0000 (15:21 +0300)]
[REGAPI] Import regapi.dll from Wine Staging 5.7 CORE-16458 (#2723)

- Comment some other missing exports Windows regapi.dll has them, but Wine's one doesn't.

Required by MS winlogon with Win32SS replaced. I double-rechecked: now it doesn't fail due to missing regapi.dll in system32 or separate missing functions in this dll, exactly the same as with MS regapi. In pair with my profmap.dll (which was merged recently), now it fails due to InitializeUserProfile() stub in our userenv.dll (if to replace msgina too).
Also I compared the exports of MS regapi.dll and Wine's one. Win2k3 version has all exports that Wine version has and some others (which looks like were dropped in NT6). But those exports which already exist, are enough to allow MS winlogon no longer fail.

CORE-16458

12 months ago[SHLWAPI] Implement SHIsLowMemoryMachine (#2783)
Katayama Hirofumi MZ [Thu, 14 May 2020 00:47:21 +0000 (09:47 +0900)]
[SHLWAPI] Implement SHIsLowMemoryMachine (#2783)

Implement shlwapi!SHIsLowMemoryMachine function.

12 months ago[SHELL32] Half-implement SHWinHelp
Katayama Hirofumi MZ [Thu, 14 May 2020 00:38:38 +0000 (09:38 +0900)]
[SHELL32] Half-implement SHWinHelp

12 months ago[NTOSKRNL] Restore section layout for NTOSKRNL to fix BSOD regression CORE-14683
Joachim Henze [Wed, 13 May 2020 15:08:25 +0000 (17:08 +0200)]
[NTOSKRNL] Restore section layout for NTOSKRNL to fix BSOD regression CORE-14683

This version (after .rsrc) works different than the
proper version I used for 0.4.12 (after .reloc).

Inserting after .rsrc is actually not correct, but Thomas believes it can
be used as a temporary trick to avoid random memory corruption upon
relocations of the kernel, caused by ROSBE-154.

I follow his advice, although when judging from practical tests only:
as long as we limit this script to NTOSKRNL like I do for releases
there have no negative consequences been observed in real life yet
even with the proper version of 0.4.12.
Up to now those problems have only been observed when used for drivers
MODULE TYPE sdk/cmake/gcc.cmake as well, like
it was tried for a moment in master 0.4.13-dev-609-g
c4d8e2a6e9660c1f0d0d24877219baca443bbce0

Using for drivers immediately did lead to BSODs like CORE-16183 and therefore was
mitigated in master by total disabling of the scripts for both,
kernel and drivers in
0.4.13-dev-621-g
36e9a6f8ddc70018b55b0cad0b13128b1cbb60c2

To allow installing DVDWritenow without BSOD,
we need the script at least for ntoskrnl!

I committed this patch (after .rsrc) already into 0.4.13RC and 0.4.14RC.

12 months ago[MPLAY32] Don't hardcode C: drive (#2778)
Katayama Hirofumi MZ [Wed, 13 May 2020 13:36:44 +0000 (22:36 +0900)]
[MPLAY32] Don't hardcode C: drive (#2778)

CORE-13235

12 months ago[ROSAPPS][MAN] Don't hardcode C: drive (#2780)
Katayama Hirofumi MZ [Wed, 13 May 2020 13:21:17 +0000 (22:21 +0900)]
[ROSAPPS][MAN] Don't hardcode C: drive (#2780)

CORE-13235

12 months ago[RAPPS] Corrections for Chinese Simplified dialog UI translation (#2781)
He Yang [Wed, 13 May 2020 12:26:29 +0000 (20:26 +0800)]
[RAPPS] Corrections for Chinese Simplified dialog UI translation (#2781)

12 months ago[NOTEPAD] Update Ukrainian translation (#2775)
Yaroslav Kibysh [Wed, 13 May 2020 12:12:22 +0000 (15:12 +0300)]
[NOTEPAD] Update Ukrainian translation (#2775)

12 months ago[SYSSETUP] Update Ukrainian translation (#2776)
Yaroslav Kibysh [Wed, 13 May 2020 12:11:48 +0000 (15:11 +0300)]
[SYSSETUP] Update Ukrainian translation (#2776)