2 years ago[WIN32SS] Move SwitchToThisWindow codes to win32k (#987)
Katayama Hirofumi MZ [Sat, 27 Oct 2018 17:56:16 +0000 (02:56 +0900)]
[WIN32SS] Move SwitchToThisWindow codes to win32k (#987)

- Implement user32!SwitchToThisWindow by NtUserCallTwoParam TWOPARAM_ROUTINE_SWITCHTOTHISWINDOW.
- Improve user32!CloseWindow with using SetActiveWindow and ShowWindow (synchronized).

2 years ago[NTOSKRNL] Properly handle "big" security descriptors in ObpCaptureObjectCreateInform...
Pierre Schweitzer [Sat, 27 Oct 2018 17:35:45 +0000 (19:35 +0200)]
[NTOSKRNL] Properly handle "big" security descriptors in ObpCaptureObjectCreateInformation()

2 years ago[NTOSKRNL] Implement SeComputeQuotaInformationSize()
Pierre Schweitzer [Sat, 27 Oct 2018 17:32:42 +0000 (19:32 +0200)]
[NTOSKRNL] Implement SeComputeQuotaInformationSize()

2 years ago[WKSSVC][IDL] Add names of unsupported functions
Eric Kohl [Sat, 27 Oct 2018 17:04:31 +0000 (19:04 +0200)]
[WKSSVC][IDL] Add names of unsupported functions

2 years ago[LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME.
Eric Kohl [Sat, 27 Oct 2018 15:02:02 +0000 (17:02 +0200)]
[LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME.

2 years ago[USETUP] Add an AddEntriesFromInfSection() helper that enumerates the entries of...
Hermès Bélusca-Maïto [Mon, 28 Aug 2017 14:01:30 +0000 (14:01 +0000)]
[USETUP] Add an AddEntriesFromInfSection() helper that enumerates the entries of a given INF section, and adds these into a (user-allocated) GENERIC_LIST after some pre-processing.

This helper is inspired by the reactos/reactos.c!LoadGenEntry() function.
Use this helper in the different Create*List() functions.

svn path=/branches/setup_improvements/; revision=75700

2 years ago[USETUP] Simplify code.
Hermès Bélusca-Maïto [Mon, 28 Aug 2017 13:51:25 +0000 (13:51 +0000)]
[USETUP] Simplify code.

svn path=/branches/setup_improvements/; revision=75698

2 years ago[USETUP] Formatting fixes only.
Hermès Bélusca-Maïto [Mon, 28 Aug 2017 13:50:40 +0000 (13:50 +0000)]
[USETUP] Formatting fixes only.

svn path=/branches/setup_improvements/; revision=75697
svn path=/branches/setup_improvements/; revision=75699

2 years ago[USETUP] Add few checks to forbid the user to attempt installing ReactOS in the insta...
Hermès Bélusca-Maïto [Fri, 25 Aug 2017 14:38:12 +0000 (14:38 +0000)]
[USETUP] Add few checks to forbid the user to attempt installing ReactOS in the installation source directory, or a subdirectory thereof, or to delete the partition containing the installation source.

This is needed because the ReactOS installer can also be present from within a HDD partition!

svn path=/branches/setup_improvements/; revision=75669

2 years ago[USETUP] Group constant strings together. In EventThread(), use RtlReAllocateHeap...
Hermès Bélusca-Maïto [Wed, 23 Aug 2017 13:40:43 +0000 (13:40 +0000)]
[USETUP] Group constant strings together. In EventThread(), use RtlReAllocateHeap() to resize the pnp-event buffer.

svn path=/branches/setup_improvements/; revision=75654

2 years ago[SETUPLIB] Diverse fixes (incl. initialization fixes).
Hermès Bélusca-Maïto [Fri, 25 Aug 2017 09:19:44 +0000 (09:19 +0000)]
[SETUPLIB] Diverse fixes (incl. initialization fixes).

- Compute the installation source paths based on the full path of the
  installer program that uses the setup library.
- Add INF_STYLE_OLDNT define in infsupp.h.
- Add some (silenced) diagnostic DPRINTs.

svn path=/branches/setup_improvements/; revision=75667

- Use correct inf style flags in SetupOpenInfFileEx() calls when opening
  txtsetup.sif and unattend.inf. Technically txtsetup.sif would be
  INF_STYLE_WIN4, but since we use "$ReactOS$" as its version signature,
  it would not work when opening it with setupapi.dll functions.
  Hence this flag is combined with INF_STYLE_OLDNT too.

- Don't fail if opening the \SystemRoot symbolic link doesn't work
  (usually due to incorrect access rights); in that case, just use the
  installer image file path as the installation source path.

svn path=/branches/setup_improvements/; revision=75676

2 years ago[SETUPLIB] Code formatting fix.
Hermès Bélusca-Maïto [Wed, 23 Aug 2017 17:47:39 +0000 (17:47 +0000)]
[SETUPLIB] Code formatting fix.

svn path=/branches/setup_improvements/; revision=75656

2 years ago[SETUPLIB] Introduce and use a UnMapAndCloseFile() macro that calls UnMapFile() and...
Hermès Bélusca-Maïto [Wed, 23 Aug 2017 12:20:15 +0000 (12:20 +0000)]
[SETUPLIB] Introduce and use a UnMapAndCloseFile() macro that calls UnMapFile() and NtClose() on handles returned by the OpenAndMapFile() function.

svn path=/branches/setup_improvements/; revision=75651
svn path=/branches/setup_improvements/; revision=75657

2 years ago[SETUPLIB][USETUP] Code refactoring: rename the old DoesPathExist() into DoesDirExist...
Hermès Bélusca-Maïto [Mon, 21 Aug 2017 19:41:40 +0000 (19:41 +0000)]
[SETUPLIB][USETUP] Code refactoring: rename the old DoesPathExist() into DoesDirExist(), and rename the new DoesPathExistEx() back into DoesPathExist().

svn path=/branches/setup_improvements/; revision=75636

2 years ago[SETUPLIB] Merge DoesPathExist() and DoesFileExist() into (temporarily called) DoesPa...
Hermès Bélusca-Maïto [Mon, 21 Aug 2017 19:14:33 +0000 (19:14 +0000)]
[SETUPLIB] Merge DoesPathExist() and DoesFileExist() into (temporarily called) DoesPathExistEx() function.

And turn the previous two functions into macros.

svn path=/branches/setup_improvements/; revision=75635
svn path=/branches/setup_improvements/; revision=75652

2 years ago[SETUPLIB] Factor out and introduce a ParseArcName() helper function that does its...
Hermès Bélusca-Maïto [Sun, 20 Aug 2017 21:30:13 +0000 (21:30 +0000)]
[SETUPLIB] Factor out and introduce a ParseArcName() helper function that does its job.

Used in exiting code and in later code in this file.

svn path=/branches/setup_improvements/; revision=75632
svn path=/branches/setup_improvements/; revision=75652

2 years ago[SETUPLIB] Code formatting.
Hermès Bélusca-Maïto [Sun, 20 Aug 2017 21:02:24 +0000 (21:02 +0000)]
[SETUPLIB] Code formatting.

svn path=/branches/setup_improvements/; revision=75631
svn path=/branches/setup_improvements/; revision=75652

2 years ago[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage...
Hermès Bélusca-Maïto [Thu, 10 Aug 2017 19:21:08 +0000 (19:21 +0000)]
[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage setup.

Following r75518, we use the $winnt$.inf file (created in System32
by the 1st-stage installer) as the setup information file for the
2nd-stage setup for:

- retrieving the installation source media path;
- retrieving the unattended information that was copied from the
  unattend.inf file from the installation source media.

The installation source media path is converted from NT format to
Win32 format for usage with Win32 functions and storage in the registry:
this is done by GetInstallSourceWin32(), which replaces the hackish
GetRosInstallCD() function.

The $winnt$.inf file is also updated, and the registry values "SourcePath"
and "ServicePackSourcePath" are created / updated in:
HKLM\Software\Microsoft\Windows\CurrentVersion\Setup .

svn path=/branches/setup_improvements/; revision=75524

2 years ago[USETUP][SETUPLIB] Code refactoring.
Hermès Bélusca-Maïto [Wed, 9 Aug 2017 20:39:45 +0000 (20:39 +0000)]
[USETUP][SETUPLIB] Code refactoring.

- Move several global setup variables into a structure "USETUP_DATA",
  similar to the syssetup structure "SETUPDATA" (or the WIP 1st-stage
  installer structure of the same name), so that these variables can be
  set easily by different helper setup functions;

- Move CheckUnattendedSetup() and GetSourcePaths() to setuplib and make
  CheckUnattendedSetup() use the USETUP_DATA structure;

- Add a LoadSetupInf() function that loads the txtsetup.sif file
  (factoring out the corresponding code in USETUP);

- Add a InstallSetupInfFile() function (that I'll probably rename later on)
  whose purpose is to create a valid "$winnt$.inf" setup installation file
  in the ReactOS\system32 directory, which should help the 2nd-stage installer
  to correctly retrieve the source installation media we used during 1st-stage,
  and contain the unattended setup lines copied from unattend.inf. This is
  done in a Windows-compatible way.

svn path=/branches/setup_improvements/; revision=75518

[USETUP] Close the txtsetup.sif file at the end of the operations.

svn path=/branches/setup_improvements/; revision=75539

2 years ago[IDL] Fix coding style and indentation
Eric Kohl [Sat, 27 Oct 2018 14:34:37 +0000 (16:34 +0200)]
[IDL] Fix coding style and indentation

2 years ago[IDL] Fix coding style and indentation
Eric Kohl [Sat, 27 Oct 2018 13:48:21 +0000 (15:48 +0200)]
[IDL] Fix coding style and indentation

2 years ago[WIN32SS][USER32] Simplify CloseWindow (#986)
Katayama Hirofumi MZ [Sat, 27 Oct 2018 12:16:02 +0000 (21:16 +0900)]
[WIN32SS][USER32] Simplify CloseWindow (#986)

2 years ago[BROWSEUI] CInternetToolbar: fix whitespace
Giannis Adamopoulos [Sat, 27 Oct 2018 12:01:54 +0000 (15:01 +0300)]
[BROWSEUI] CInternetToolbar: fix whitespace

2 years ago[BROWSEUI] Simplify toggling the search band
Giannis Adamopoulos [Sat, 27 Oct 2018 11:01:20 +0000 (14:01 +0300)]
[BROWSEUI] Simplify toggling the search band
In windows the toolbar itself creates the search shell extension. In ros we send a command to the CShellBrowser to let it handle it itself. Use the same command for showing and hiding it.

2 years ago[BROWSEUI] Implement toggling the folders and search band with the toolbar and make...
Giannis Adamopoulos [Sat, 27 Oct 2018 08:52:04 +0000 (11:52 +0300)]
[BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown.
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.

2 years ago[WIN32SS][USER32] Fix #984 (#985)
Katayama Hirofumi MZ [Sat, 27 Oct 2018 11:32:51 +0000 (20:32 +0900)]
[WIN32SS][USER32] Fix #984 (#985)

Sorry, I had to wait the build checks.

2 years ago[WIN32SS][USER32] CloseWindow does minimize, doesn't close (#984)
Katayama Hirofumi MZ [Sat, 27 Oct 2018 11:21:55 +0000 (20:21 +0900)]
[WIN32SS][USER32] CloseWindow does minimize, doesn't close (#984)

In Windows, user32!CloseWindow minimizes the window. It doesn't close the window actually. This is not a joke. This bad function naming is responsible to MS.

2 years ago[BOOTDATA] Define the ObUnsecureGlobalNames registry key on setup
Pierre Schweitzer [Sat, 27 Oct 2018 10:00:35 +0000 (12:00 +0200)]
[BOOTDATA] Define the ObUnsecureGlobalNames registry key on setup

It contains values that are present on W2K3 and required to avoid
regressions in .NET


2 years ago[NTOSKRNL] Add support for unsecure object names
Pierre Schweitzer [Sat, 27 Oct 2018 09:48:52 +0000 (11:48 +0200)]
[NTOSKRNL] Add support for unsecure object names

2 years ago[NTOSKRNL] Implement the ObpIsUnsecureName() helper function
Pierre Schweitzer [Sat, 27 Oct 2018 09:47:42 +0000 (11:47 +0200)]
[NTOSKRNL] Implement the ObpIsUnsecureName() helper function

2 years ago[NTOSKRNL] Add support for the ObUnsecureGlobalNames registry key
Pierre Schweitzer [Sat, 27 Oct 2018 09:44:19 +0000 (11:44 +0200)]
[NTOSKRNL] Add support for the ObUnsecureGlobalNames registry key

2 years ago[WIN32SS][NTUSER] Make offset only for menu bars (#983)
Stanislav Motylkov [Sat, 27 Oct 2018 09:45:21 +0000 (12:45 +0300)]
[WIN32SS][NTUSER] Make offset only for menu bars (#983)


2 years ago[NTOSKRNL] Reduce noise
Pierre Schweitzer [Sat, 27 Oct 2018 08:04:22 +0000 (10:04 +0200)]
[NTOSKRNL] Reduce noise

2 years ago[NTOSKRNL] Call internal helper to get VACB on mapping
Pierre Schweitzer [Sat, 27 Oct 2018 07:30:22 +0000 (09:30 +0200)]
[NTOSKRNL] Call internal helper to get VACB on mapping
We already properly round our offset

2 years ago[USETUP] Minor code formatting only.
Hermès Bélusca-Maïto [Wed, 9 Aug 2017 20:29:07 +0000 (20:29 +0000)]
[USETUP] Minor code formatting only.

svn path=/branches/setup_improvements/; revision=75517

2 years ago[USETUP] Sprinkle some INF_FreeData() calls to balance the INF_GetData() / INF_GetDat...
Hermès Bélusca-Maïto [Wed, 9 Aug 2017 20:24:24 +0000 (20:24 +0000)]
[USETUP] Sprinkle some INF_FreeData() calls to balance the INF_GetData() / INF_GetDataField() calls.

They currently do nothing, since the getter functions don't actually
capture (copy) the strings but merely return pointers to read-only strings.

But the calls are placed here for consistency, because if one day the
getters' implementation is changed so that strings are captured, it would
then be needed to free the allocated buffers.

In addition, fix a buggy call to INF_GetData() -- should be instead
INF_GetDataField() -- in AddSectionToCopyQueue().

svn path=/branches/setup_improvements/; revision=75516

2 years ago[USETUP] Comment out SetupQueueCopyWNew() declaration which is not used at all. Remov...
Hermès Bélusca-Maïto [Tue, 8 Aug 2017 14:07:17 +0000 (14:07 +0000)]
[USETUP] Comment out SetupQueueCopyWNew() declaration which is not used at all. Remove unnecessary casts in the INF_OpenBufferedFileA() call.

svn path=/branches/setup_improvements/; revision=75509

2 years ago[SETUPLIB] Introduce defines for size units.
Hermès Bélusca-Maïto [Tue, 8 Aug 2017 14:05:20 +0000 (14:05 +0000)]
[SETUPLIB] Introduce defines for size units.
[USETUP] Use them in the code.

svn path=/branches/setup_improvements/; revision=75508

2 years ago[SETUPLIB] IniCacheSave(): use the OBJ_CASE_INSENSITIVE flag.
Hermès Bélusca-Maïto [Tue, 8 Aug 2017 13:54:23 +0000 (13:54 +0000)]
[SETUPLIB] IniCacheSave(): use the OBJ_CASE_INSENSITIVE flag.

svn path=/branches/setup_improvements/; revision=75507

2 years ago[USETUP] Move SetDefaultPagefile() into settings.c and remove the now-empty registry...
Hermès Bélusca-Maïto [Fri, 30 Jun 2017 22:46:15 +0000 (22:46 +0000)]
[USETUP] Move SetDefaultPagefile() into settings.c and remove the now-empty registry.c/.h files.

svn path=/branches/setup_improvements/; revision=75250

2 years ago[USETUP] Move Setup[Delete|Copy|Move]File() from usetup code into the setuplib's...
Hermès Bélusca-Maïto [Fri, 30 Jun 2017 22:28:06 +0000 (22:28 +0000)]
[USETUP] Move Setup[Delete|Copy|Move]File() from usetup code into the setuplib's filesup.c .

Remove the commented-out IsValidPath() in that file, and remove
as well the temporary prototypes in regutil.c .

svn path=/branches/setup_improvements/; revision=75249

2 years ago[USETUP][SETUPLIB] Split the registry helper code.
Hermès Bélusca-Maïto [Fri, 30 Jun 2017 19:07:02 +0000 (19:07 +0000)]
[USETUP][SETUPLIB] Split the registry helper code.

Split the registry helper code into registry utility functions
(create/mount/unmount/verify hives) and registry creation code
(the rest: initializing the system hives) and move it in the
setup library.

svn path=/branches/setup_improvements/; revision=75247

[USETUP][SETUPLIB] Improve how the Setup* INF APIs are interfaced in the code.

Define prototypes compatible (including their calling convention)
with the ones defined by setupapi (.h/.dll) so that it can be possible
to either use an internal implementation of these functions (via the
INFLIB library) as currently being done, or using imported setupapi
functions, as would be done by the future 1st-stage GUI installer.

[SETUPLIB] Cleanup the registry.c file and use the infsupp.h header.

svn path=/branches/setup_improvements/; revision=75345
svn path=/branches/setup_improvements/; revision=75346

[USETUP][SETUPLIB] Move some INF-related code from usetup to the setuplib.

- Move the generic INF_GetDataField() and INF_GetData() helpers to
  setuplib, and rework them a bit so that they explicitly call setupapi
  functions (or implementations thereof when being used in usetup);

- Rework the headers in accordance;
- Fix compilation in lib/registry.c .

- Fix compilation when these headers are used withing usetup (who
  doesn't use setupapi.dll) and "reactos" (the 1st-stage GUI installer
  that uses setupapi.dll).

svn path=/branches/setup_improvements/; revision=75515
svn path=/branches/setup_improvements/; revision=75537
svn path=/branches/setup_improvements/; revision=75538

2 years ago[WIN32SS][NTUSER] Sunken menu item (#981)
Katayama Hirofumi MZ [Fri, 26 Oct 2018 19:20:09 +0000 (04:20 +0900)]
[WIN32SS][NTUSER] Sunken menu item (#981)


2 years ago[CMAKE] Use configured include files to define the __RELFILE__ hack (#979)
Jérôme Gardou [Fri, 26 Oct 2018 11:47:22 +0000 (13:47 +0200)]
[CMAKE] Use configured include files to define the __RELFILE__ hack (#979)

[CMAKE] Use configured include files to define the __RELFILE__ hack

It's easier on the command line and the eyes looking at it

2 years ago[APITESTS][USER32] Add testcase for SwitchToThisWindow (#980)
Katayama Hirofumi MZ [Fri, 26 Oct 2018 10:56:25 +0000 (19:56 +0900)]
[APITESTS][USER32] Add testcase for SwitchToThisWindow (#980)

Add an API test program for user32!SwitchToThisWindow function.
JIRA issue: CORE-15165

2 years ago[CMAKE] Set CMAKE_OBJCOPY unconditionnally
Jérôme Gardou [Fri, 26 Oct 2018 08:16:26 +0000 (10:16 +0200)]
[CMAKE] Set CMAKE_OBJCOPY unconditionnally

2 years agoAdd Eclipse files to .gitignore
Jérôme Gardou [Tue, 23 Oct 2018 17:18:47 +0000 (19:18 +0200)]
Add Eclipse files to .gitignore

2 years ago[USETUP] NT RTL thread functions use 'NULL' (instead of 'INVALID_HANDLE_VALUE' which...
Hermès Bélusca-Maïto [Wed, 9 Aug 2017 20:43:02 +0000 (20:43 +0000)]
[USETUP] NT RTL thread functions use 'NULL' (instead of 'INVALID_HANDLE_VALUE' which is a Win32 thing) for thread handles that are "invalid" / uninitialized.

svn path=/branches/setup_improvements/; revision=75519

2 years ago[USETUP] Moving around some code.
Hermès Bélusca-Maïto [Fri, 30 Jun 2017 19:02:35 +0000 (19:02 +0000)]
[USETUP] Moving around some code.

- As GetSourcePaths() is used once in USETUP to initialize global
  UNICODE_STRING path strings once, move it out of drivesup.c and
  put it in usetup.c. Then remove drivesup.c : 1 file less!

- Move some INF file prototype declarations out of usetup.h and
  inside inffile.h where they should better be, as inffile.h and .c
  is the glue code for the INF library, defining similar functions
  as the ones in setupapi.dll.

- I rename our local SetupOpenInfFileW() into SetupOpenInfFileExW()
  because the latter one takes an extra user-provided LCID parameter,
  and this is this one that we use in USETUP.

- Make 'UNICODE_STRING SourcePath;' visible only inside usetup.c
  (not used elsewhere).

- Implement installation path validity check in case we are either
  in repair/update, or unattended setup mode. If the path is detected
  as invalid, then we fall back into manual path specification
  (for now...; note that we could instead fail the installation too).

svn path=/branches/setup_improvements/; revision=75246

2 years ago[USETUP] Implement most of the "upgrade" page, where existing NTOS installations...
Hermès Bélusca-Maïto [Thu, 31 May 2018 14:38:06 +0000 (16:38 +0200)]
[USETUP] Implement most of the "upgrade" page, where existing NTOS installations are listed.

- Modify a bit the page flow so that the upgrade page is inserted before
  the Device-settings page, and after the Install-Intro page.

- Insert some extra 'RepairUpdateFlag' checks in SelectPartitionPage() and
  InstallDirectoryPage() to take specific actions in case the flag is TRUE.

svn path=/branches/setup_improvements/; revision=74576
svn path=/branches/setup_improvements/; revision=75525

2 years ago[USETUP] Add an upgrade/repair installation page.
Hermès Bélusca-Maïto [Mon, 15 May 2017 01:48:19 +0000 (01:48 +0000)]
[USETUP] Add an upgrade/repair installation page.

Translators, please update the associated translations!

svn path=/branches/setup_improvements/; revision=74548

2 years ago[USER32] Fix Task Switcher (#976)
Katayama Hirofumi MZ [Thu, 25 Oct 2018 13:59:44 +0000 (22:59 +0900)]
[USER32] Fix Task Switcher (#976)

This fix is needed for the Delphi GUI programs.
- Don't enumerate the windows whose owner window exists.
- Use PostMessage SC_RESTORE instead of ShowWindowAsync SW_RESTORE.

2 years ago[SDK] Update baseaddresses
Mark Jansen [Thu, 25 Oct 2018 04:59:15 +0000 (06:59 +0200)]
[SDK] Update baseaddresses

2 years ago[USETUP] Use UNICODE_NULL.
Hermès Bélusca-Maïto [Fri, 30 Jun 2017 22:17:18 +0000 (22:17 +0000)]

svn path=/branches/setup_improvements/; revision=75248

2 years ago[USETUP] More code for updating/repairing the registry. Fix the name of the txtsetup...
Hermès Bélusca-Maïto [Thu, 22 Jun 2017 00:38:32 +0000 (00:38 +0000)]
[USETUP] More code for updating/repairing the registry. Fix the name of the txtsetup.sif section to look for when performing a registry upgrade.

[BOOTDATA] Add needed entries in txtsetup.sif for registry upgrade.

svn path=/branches/setup_improvements/; revision=75162
svn path=/branches/setup_improvements/; revision=75226

2 years ago[USETUP] Mark some variables as 'static'.
Hermès Bélusca-Maïto [Thu, 22 Jun 2017 00:36:29 +0000 (00:36 +0000)]
[USETUP] Mark some variables as 'static'.

svn path=/branches/setup_improvements/; revision=75161

2 years ago[USETUP] Implement work-in-progress code that allows verifying whether registry hives...
Hermès Bélusca-Maïto [Mon, 12 Jun 2017 00:09:16 +0000 (00:09 +0000)]
[USETUP] Implement work-in-progress code that allows verifying whether registry hives validity.

Implement work-in-progress code that, when upgrading an existing
ReactOS installation, verifies whether the (existing) system registry
hives are valid (by loading & unloading them, this allows using the
built-in repair functionality if needed), or not.

If a given hive cannot be repaired successfully, it is backed up
(with a '.brk' extension, "brk" as "broken"), then is marked up for

When all hives have been checked, if there are any hive that needs
to be recreated, we recreate its hive file, mount it, but we do *NOT*
mount the other valid existing hives for update. We create instead
dummy registry hives so that we can actually use, as the update code,
the same one as the one used when fully creating the registry hives
for a clean installation (of course, this choice can be improved later on).

The update code (i.e. the same as the registry clean-install one) then
adds the registry keys & values, either putting them in the dummy
registry hives (the ones that we don't want to recreate) or in the
registry hive that is recreated.

At the end, the (re)created registry hives are flushed back to disk,
and a copy of them (under a '.sav' extension) are created, so that they
can be used for restoration purposes if 2nd-stage (and up) goes berserk.

Extra fixes:

- Use the correct structure member field when initializing the
  'InstallDir' variable, when performing an upgrade.

- CreateNestedKey() should be better analysed to see whether it correctly
  creates the full registry path compatible with volatile/non-volatile keys
  (under inspection).

svn path=/branches/setup_improvements/; revision=75010

2 years ago[USETUP] Introduce SetupDeleteFile() and SetupMoveFile() (in addition to the already...
Hermès Bélusca-Maïto [Sun, 11 Jun 2017 23:58:43 +0000 (23:58 +0000)]
[USETUP] Introduce SetupDeleteFile() and SetupMoveFile() (in addition to the already-existing SetupCopyFile()) in order to implement moving / renaming existing files.

Will be used soon to make backups of system files, like the registry hive files just freshly created.
- Make the SetupCopyFile() function closer to its win32 counterpart.
- Adjust the code that calls SetupCopyFile().

svn path=/branches/setup_improvements/; revision=75008
svn path=/branches/setup_improvements/; revision=75009

2 years ago[USETUP] Explicitly use the REG_OPTION_(NON_)VOLATILE flags in NtCreateKey calls.
Hermès Bélusca-Maïto [Sun, 11 Jun 2017 23:47:11 +0000 (23:47 +0000)]
[USETUP] Explicitly use the REG_OPTION_(NON_)VOLATILE flags in NtCreateKey calls.

svn path=/branches/setup_improvements/; revision=75007

2 years ago[USETUP] Implement offline ReactOS registry initialization in USetup (equivalent...
Hermès Bélusca-Maïto [Sat, 3 Jun 2017 16:22:42 +0000 (16:22 +0000)]
[USETUP] Implement offline ReactOS registry initialization in USetup (equivalent of mkhive, but using OS functionality).

The rationale is as follows.

We now have the 1st-stage ReactOS setup running with its own registry SYSTEM hive,
similarly to regular ROS running instances (livecd, regular installation...).

The ReactOS-specific SetInstallPathValue() hack, introduced in a76689e9 (r3794)
and 5f973ce0 (r3795), is removed. This hack told the kernel that, during the setup,
it had to "switch" the used registry hives and instead use the ones of the ROS
installation being prepared.

This was really hackish because this means, mixing between registry settings used only
for the setup running instance, that could use different registry settings
than the ones that should be set for the ROS installation being actually performed.

Also, note that in the case of a 1st-stage GUI setup, consisting in running the
LiveCD + the GUI setup program, this situation would be untenable. Note also that
for people willing to use the Setup*** functions exported by setupapi.dll to parse
the registry INF files to initialize the registry of the ROS installation being
prepared, this would be impossible either.

Hence the need to have offline registry modification functionality.

svn path=/branches/setup_improvements/; revision=74766

2 years ago[USETUP] Code formatting, making also the code closer to mkhive's one. Also, definite...
Hermès Bélusca-Maïto [Sat, 3 Jun 2017 15:20:09 +0000 (15:20 +0000)]
[USETUP] Code formatting, making also the code closer to mkhive's one. Also, definitely remove the SetInstallPathValue() hack.

svn path=/branches/setup_improvements/; revision=74763

2 years ago[CMAKE] Apply patch INF file for the SETUP SYSTEM registry hive that removes the... 561/head
Hermès Bélusca-Maïto [Wed, 24 Oct 2018 22:18:29 +0000 (00:18 +0200)]
[CMAKE] Apply patch INF file for the SETUP SYSTEM registry hive that removes the entries in the Critical Device Database that cause problems with PnP setup during 1st-stage setup.

2 years ago[FREELDR] Adjust WinLdrInitSystemHive() and its callers to load at startup either...
Hermès Bélusca-Maïto [Sat, 3 Jun 2017 14:55:18 +0000 (14:55 +0000)]
[FREELDR] Adjust WinLdrInitSystemHive() and its callers to load at startup either the regular SYSTEM hive, or the SETUPREG.HIV setup system hive.

We now run the 1st-stage setup with a regular system hive, similarly to
what's done for the LiveCD, or for a regular ROS installation.
The ExpInTextModeSetup hacks I previously removed are now completely unneeded.

svn path=/branches/setup_improvements/; revision=74762

2 years ago[FREELDR] Small code re-organization for the "ntldr" sub-module.
Hermès Bélusca-Maïto [Fri, 2 Jun 2017 00:52:36 +0000 (00:52 +0000)]
[FREELDR] Small code re-organization for the "ntldr" sub-module.

Split the "main" winldr.h header into the one containing global code
that actually doesn't really depend on the "windows" NT loader part,
and one that actually concerns code just for the NT Loader.
The latter goes into "ntldr".

svn path=/branches/setup_improvements/; revision=74743

2 years ago[NTOS] Drastically reduce the hackish function CmpGetRegistryPath() for the text...
Hermès Bélusca-Maïto [Thu, 22 Jun 2017 00:46:30 +0000 (00:46 +0000)]
[NTOS] Drastically reduce the hackish function CmpGetRegistryPath() for the text-mode setup case (it should ultimately completely disappear).

svn path=/branches/setup_improvements/; revision=75163

2 years ago[NTOS] Add some DPRINTs in IopLoadServiceModule() and IopOpenRegistryKeyEx() to inves...
Hermès Bélusca-Maïto [Fri, 2 Jun 2017 15:49:12 +0000 (15:49 +0000)]
[NTOS] Add some DPRINTs in IopLoadServiceModule() and IopOpenRegistryKeyEx() to investigate why these 1st-stage text-mode hacks may be, or are (respectively) still needed.

svn path=/branches/setup_improvements/; revision=74748

2 years ago[NTOS] Configuration Manager fixes.
Hermès Bélusca-Maïto [Fri, 2 Jun 2017 15:47:52 +0000 (15:47 +0000)]
[NTOS] Configuration Manager fixes.

- Rework CmpSetSystemValues() and remove its 1st-stage text-mode setup hack, since a real registry hive will be used for 1st-stage either.
- Lock, then unlock the registry in NtInitializeRegistry when initializing the hives & flusher.
- Call CmpInitializeHiveList() (i.e., initialize the other hives like \Software, \User, \.Default) only when we are not in setup-mode.

svn path=/branches/setup_improvements/; revision=74747

2 years ago[NTOS] Remove some hacks that are not needed anymore, since a real registry hive...
Hermès Bélusca-Maïto [Fri, 2 Jun 2017 15:37:56 +0000 (15:37 +0000)]
[NTOS] Remove some hacks that are not needed anymore, since a real registry hive will be used in 1st-stage as well.

This reverts a7c26408 (r53255) and ff75ae1b (r53694), and a hack from 6075ae9a (r46690).

svn path=/branches/setup_improvements/; revision=74745
svn path=/branches/setup_improvements/; revision=74746

2 years ago[SHIMGVW] Fix image flickering when rendering animations
Stanislav Motylkov [Wed, 24 Oct 2018 16:16:22 +0000 (19:16 +0300)]
[SHIMGVW] Fix image flickering when rendering animations

2 years ago[TASKMGR][TRANSLATION] Estonian localization
Joann Mõndresku [Wed, 24 Oct 2018 13:42:56 +0000 (16:42 +0300)]
[TASKMGR][TRANSLATION] Estonian localization

2 years ago[LPK][GDI32] Enable mirroring via version resource (#965)
Baruch Rutman [Wed, 24 Oct 2018 19:34:38 +0000 (22:34 +0300)]
[LPK][GDI32] Enable mirroring via version resource (#965)

Add a mechanism that detects via the version resource whether it's needed to mirror
the application layout or not. This is a "follow up" to commit 5b14b6f.

This code is taken from the GetProcessDefaultLayout() function from Wine
(called there "WIN_CreateWindowEx").

In Windows the version-resource mirroring happens when the GDI is loading the LPK.

- Implement mirroring via version resource. GDI linking on startup is required.

- GDI32: Add LPK loading on GDI startup.

To enable mirroring via version resource the lpk.dll must be loaded before any windows are created.
This is done through GdiInitializeLanguagePack() function which is called in GdiProcessSetup().

- LPK: Use Wine debug messaging.

2 years ago[TRANSLATION][MC] Add Romanian messages (#850)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 13:40:21 +0000 (22:40 +0900)]
[TRANSLATION][MC] Add Romanian messages (#850)


2 years ago[BOOTDATA][HIVECLS] Use shell image viewer for GIF files (#971)
Stanislav Motylkov [Wed, 24 Oct 2018 12:09:23 +0000 (15:09 +0300)]
[BOOTDATA][HIVECLS] Use shell image viewer for GIF files (#971)

Change GIF file type association to the shell image viewer. CORE-12680

2 years ago[FONT][WIN32SS] Fix the storage processing of IntGetOutlineTextMetrics (#942)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 11:23:24 +0000 (20:23 +0900)]
[FONT][WIN32SS] Fix the storage processing of IntGetOutlineTextMetrics (#942)

* Add IntStoreFontNames and IntStoreName functions and use them.
* SCALE_X and SCALE_Y macros
* Fix too long line
* Reduce type casts

2 years ago[WIN32SS][USER32] Fix SwitchToThisWindow (#929)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 11:02:27 +0000 (20:02 +0900)]
[WIN32SS][USER32] Fix SwitchToThisWindow (#929)

I'm not sure but it seems like no one can investigate it. I commit it.

2 years ago[FONT][WIN32SS] Improve readability of IntGdiGetFontResourceInfo (#945)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 10:58:03 +0000 (19:58 +0900)]
[FONT][WIN32SS] Improve readability of IntGdiGetFontResourceInfo (#945)

Make it human friendly code.

2 years ago[WIN32SS][MENU] Fix menu text Y positioning (#887)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 10:54:41 +0000 (19:54 +0900)]
[WIN32SS][MENU] Fix menu text Y positioning (#887)

Fix the vertical position of menu bar text. CORE-15094

2 years ago[SHIMGVW] Play gif animation (#934)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 10:51:30 +0000 (19:51 +0900)]
[SHIMGVW] Play gif animation (#934)

Make "Picture and Fax Viewer" able to play GIF animation.

2 years ago[REGEDIT] Improve the layout of controls (#967)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 09:19:48 +0000 (18:19 +0900)]
[REGEDIT] Improve the layout of controls (#967)

The horizontal scroll bar of the listview was wrongly hidden.

2 years ago[REGEDIT] Don't paint background in WM_PAINT (#970)
Katayama Hirofumi MZ [Wed, 24 Oct 2018 09:17:28 +0000 (18:17 +0900)]
[REGEDIT] Don't paint background in WM_PAINT (#970)

Use the background brush or WM_ERASEBKGND message instead. There was graphical glidge. CORE-15187

2 years ago[USETUP] Reshuffle a bit the main-function of USetup.
Hermès Bélusca-Maïto [Fri, 9 Jun 2017 16:37:53 +0000 (16:37 +0000)]
[USETUP] Reshuffle a bit the main-function of USetup.

svn path=/branches/setup_improvements/; revision=74975

2 years ago[USETUP] The 'DestinationDriveLetter' variable (that is just used for SetDefaultPagef...
Hermès Bélusca-Maïto [Thu, 8 Jun 2017 02:01:56 +0000 (02:01 +0000)]
[USETUP] The 'DestinationDriveLetter' variable (that is just used for SetDefaultPagefile()...) just needs to be initialized at one place only.

svn path=/branches/setup_improvements/; revision=74951

2 years ago[USETUP] Whitespace fixes only.
Hermès Bélusca-Maïto [Tue, 23 May 2017 21:01:10 +0000 (21:01 +0000)]
[USETUP] Whitespace fixes only.

svn path=/branches/setup_improvements/; revision=74636
svn path=/branches/setup_improvements/; revision=74639

2 years ago[USETUP] Small formatting changes + two functions turned into FORCEINLINE.
Hermès Bélusca-Maïto [Sun, 21 May 2017 23:34:03 +0000 (23:34 +0000)]
[USETUP] Small formatting changes + two functions turned into FORCEINLINE.

Based on:
svn path=/branches/setup_improvements/; revision=74616

2 years ago[USETUP] Rename some of the uninformative "STRING_HDDINFOUNKx" string labels into...
Hermès Bélusca-Maïto [Sun, 21 May 2017 23:17:24 +0000 (23:17 +0000)]
[USETUP] Rename some of the uninformative "STRING_HDDINFOUNKx" string labels into more informative ones.

- Also, reserve a new field to display whether the disk is MBR or GPT-initialized.
- Adjust the code that used the "STRING_HDDINFOUNKx" string labels.
  The extra slot added to some of the strings is to indicate whether the disk is MBR or GPT.

As attentive readers will notice, the code that "determines" whether the disk is either MBR or GPT
is of course just temporary: it's just a placeholder code that should currently just show "MBR".

Having the NoMbr flag mostly signifies that the disk is uninitialized. A GPT disk also has a MBR
but it's for "backcompatibility" / "protective" reasons (so that MBR-only tools would see the disk
as just a big 1-partitioned only disk with which they could barely do anything). A real involved test
for the nature of the disk should involve calling the correct IOCTLs in the disk detection code in partlist.c .
This is for the future (and when ReactOS will better support GPT disks).

svn path=/branches/setup_improvements/; revision=74614
svn path=/branches/setup_improvements/; revision=74615

2 years ago[USETUP] Massage the USETUP interface code.
Hermès Bélusca-Maïto [Mon, 15 May 2017 01:48:19 +0000 (01:48 +0000)]
[USETUP] Massage the USETUP interface code.

- The "intro" page is renamed into the "Welcome" page, because its corresponding resource indeed is the welcome screen;
- Because the "setup start" page can only be displayed once, move it out of the while-loop, and use its result as the initial value of the 'Page' variable.
- Remove unneeded _PAGE_NUMBER_DEFINED guards;
- Add a DPRINT in the RepairUpdateFlag case of RegistryPage() (because we don't implement yet a correct upgrading or repairing of the registry).
- In InstallIntroPage(), display the page itself only if needed (i.e. after all the validation checks & repair/update or unattended checks are done). Similar modifications are done also in DeviceSettingsPage(), SelectPartitionPage()
- Turn both CheckUnattendedSetup() and UpdateKBLayout() into static functions.
- Fix the code of ScsiControllerPage() so that it can be compiled if needed, and add a dummy OemDriverPage().

svn path=/branches/setup_improvements/; revision=74575

2 years ago[INETCPL] Add icon codes for trusted and restricted zones
Stanislav Motylkov [Tue, 23 Oct 2018 22:13:15 +0000 (01:13 +0300)]
[INETCPL] Add icon codes for trusted and restricted zones

2 years ago[SETUPAPI] SetupDiGetClassDevPropertySheetsW: Implement adding property pages from...
Eric Kohl [Tue, 23 Oct 2018 21:10:03 +0000 (23:10 +0200)]
[SETUPAPI] SetupDiGetClassDevPropertySheetsW: Implement adding property pages from an installer.

SetupDiGetClassInstallParamsW must be implemented before this will work.

2 years ago[NTOSKRNL] Translate pinning flags to mapping flags when first mapping a file
Pierre Schweitzer [Tue, 23 Oct 2018 19:48:01 +0000 (21:48 +0200)]
[NTOSKRNL] Translate pinning flags to mapping flags when first mapping a file

2 years ago[USETUP] Fix a broken character in Italian resource (#968)
Bișoc George [Tue, 23 Oct 2018 15:41:38 +0000 (17:41 +0200)]
[USETUP] Fix a broken character in Italian resource (#968)

Also add two spaces at the beginning of the "deleting cache" string.

2 years ago[NET] Fix an escape sequence in Polish translation (#966)
Katayama Hirofumi MZ [Tue, 23 Oct 2018 11:10:38 +0000 (20:10 +0900)]
[NET] Fix an escape sequence in Polish translation (#966)

2 years ago[rosctrls.h] CListView: Add Arrange method
Giannis Adamopoulos [Mon, 22 Oct 2018 20:51:37 +0000 (23:51 +0300)]
[rosctrls.h] CListView: Add Arrange method

[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.

2 years ago[SHELL32] CDefView: Disable auto arrange in list and details view mode.
Giannis Adamopoulos [Mon, 22 Oct 2018 16:18:28 +0000 (19:18 +0300)]
[SHELL32] CDefView: Disable auto arrange in list and details view mode.
This supersedes PR #927 and does it correctly.

2 years ago[BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars.
Giannis Adamopoulos [Mon, 22 Oct 2018 15:41:47 +0000 (18:41 +0300)]
[BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars.

2 years ago[NTOS:CM] CmpCmdHiveOpen(): Resolve FileAttributes->RootDirectory when a hive file...
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 22:39:50 +0000 (00:39 +0200)]
[NTOS:CM] CmpCmdHiveOpen(): Resolve FileAttributes->RootDirectory when a hive file name is provided relative to it.

Fixes registry hive loading. CORE-13448

2 years ago[NTDLL_APITEST] Re-enable the part of the NtLoad/UnloadKey test related to force... 964/head
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 21:09:32 +0000 (23:09 +0200)]
[NTDLL_APITEST] Re-enable the part of the NtLoad/UnloadKey test related to force-unload a hive with opened sub-key handles.

Effectively reverts b17ce9c8 (r75138).


2 years ago[NTOS:CM] Implement more support for force-unloading registry hives.
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 21:08:51 +0000 (23:08 +0200)]
[NTOS:CM] Implement more support for force-unloading registry hives.
CORE-13448 CORE-10705

2 years ago[NTOS:CM] Add extra validation for the information class parameter in NtEnumerateValu...
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 16:12:08 +0000 (18:12 +0200)]
[NTOS:CM] Add extra validation for the information class parameter in NtEnumerateValueKey().

2 years ago[NTOS:CM] Improve the capture of user-mode parameters. 960/head
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 13:42:13 +0000 (15:42 +0200)]
[NTOS:CM] Improve the capture of user-mode parameters.

- Improve the capture of OBJECT_ATTRIBUTES parameters that are passed
  (by pointer) to the Cm* helper functions, and the capture of

- Correctly differentiate user-mode vs. kernel-mode root directory handles
  (in OBJECT_ATTRIBUTES): note that most of the Cm* APIs expect their
  parameters to be kernel-mode (pointers, handles...).


2 years ago[SYSDM] Fix controls order and label height in IDD_SYSSETTINGS dialog
Stanislav Motylkov [Sat, 20 Oct 2018 23:15:01 +0000 (02:15 +0300)]
[SYSDM] Fix controls order and label height in IDD_SYSSETTINGS dialog

This fixes checkbox rendering issue in russian translation.
Dialogs in other translations are ok.