Eric Kohl [Fri, 25 May 2018 23:54:58 +0000 (01:54 +0200)]
[MSGINA] Clean-up the resource IDs and the dialog function names.
Pierre Schweitzer [Fri, 25 May 2018 19:40:39 +0000 (21:40 +0200)]
[NTOSKRNL] Implement KeQueryValuesProcess().
And make use of it.
Pierre Schweitzer [Fri, 25 May 2018 06:46:19 +0000 (08:46 +0200)]
[NTOSKRNL] Make NtSetInformationJobObject() success for JobObjectExtendedLimitInformation
This fixes pip from Python 2.7.9 starting in ReactOS.
Though it doesn't work due to TLS issues.
Pierre Schweitzer [Fri, 25 May 2018 06:14:44 +0000 (08:14 +0200)]
[NTOSKRNL] Define required sizes with structures sizes
Pierre Schweitzer [Fri, 25 May 2018 06:14:16 +0000 (08:14 +0200)]
[SDK] Add more types for job objects information
Pierre Schweitzer [Thu, 24 May 2018 22:18:20 +0000 (00:18 +0200)]
[NTOSKRNL] Implement NtQueryInformationJobObject().
This is required by some Python2 applications
such as pip.exe
Pierre Schweitzer [Thu, 24 May 2018 22:17:58 +0000 (00:17 +0200)]
[SDK] Add a few types for job objects information
Stanislav Motylkov [Thu, 24 May 2018 17:11:46 +0000 (20:11 +0300)]
[MSPAINT] Fix call sequence in OnRButtonUp
This fixes unexpected undo action when zooming out with right mouse
click.
The call sequence in OnLButtonUp is already correct.
CORE-14539
Eric Kohl [Thu, 24 May 2018 09:39:01 +0000 (11:39 +0200)]
[STORPORT] Enumerate attached devices
- Implement AcquireSpinlock, ReleaseSpinlock and GetExtendedFunctionTable notifications.
- Implement a bus scan routine, borrowed from scsiport.
Storport and storahci are now able to detect a disk device attached to a Virtual Box AHCI controller.
Stanislav Motylkov [Wed, 23 May 2018 21:31:20 +0000 (00:31 +0300)]
[MSPAINT] Fix divide by zero in drawZoomFrame
CORE-14539 #resolve
Katayama Hirofumi MZ [Wed, 23 May 2018 21:25:11 +0000 (06:25 +0900)]
[SHELL32] Add icons to the 'File Types' listview (#557)
This commit adds icons to the listview of the 'File Types' property sheet of Folder Options.
CORE-12906
Stanislav Motylkov [Wed, 23 May 2018 20:17:22 +0000 (23:17 +0300)]
[MSPAINT] Fix copy-pasta bug (#562)
This would fix setting image height via Attributes dialog and help fixing CORE-14539.
Eric Kohl [Wed, 23 May 2018 11:51:45 +0000 (13:51 +0200)]
[MSGINA] Implement the Welcome text feature
Pierre Schweitzer [Wed, 23 May 2018 06:44:43 +0000 (08:44 +0200)]
[NTOSKRNL] Addendum to
8a8cb4d: don't print uninit pointer.
Pierre Schweitzer [Wed, 23 May 2018 06:37:50 +0000 (08:37 +0200)]
[NTOSKRNL] Only consider SharedCacheMap value once ViewLock is acquired.
This avoids a really nasty race condition in our cache controler where
two concurrents could try to initialize cache on the same file.
This had two nasty effects: first shared map was purely leaked and erased
by the second one. And the private cache map, allocated on the first shared
cache map couldn't be freed and was leading to Mm BSOD (free in a middle of
a block).
This was often triggered while building ReactOS on ReactOS (with multi threads).
With that patch, I cannot crash anylonger while building ReactOS.
CORE-14634
Eric Kohl [Tue, 22 May 2018 22:27:11 +0000 (00:27 +0200)]
[MSGINA] Clear the password on logoff
Eric Kohl [Tue, 22 May 2018 22:24:01 +0000 (00:24 +0200)]
[MSGIINA] Make sure we do not leak bitmaps
Pierre Schweitzer [Tue, 22 May 2018 19:29:10 +0000 (21:29 +0200)]
[FASTFAT] Properly handle IRPs that can wait and these that cannot.
CORE-14634
Eric Kohl [Tue, 22 May 2018 19:19:58 +0000 (21:19 +0200)]
[MSGINA] Always stop the automatic login after the first try
Fixes CORE-14643
Eric Kohl [Tue, 22 May 2018 16:14:42 +0000 (18:14 +0200)]
[WINLOGON] Ignore the CTRL+SHIFT+ESC hotkey when the session is not in the logged-on state
Should fix CORE-13478
Eric Kohl [Tue, 22 May 2018 15:35:33 +0000 (17:35 +0200)]
[MSGINA] Do not try to impersonate the user on shutdown when we are already logged off
Eric Kohl [Tue, 22 May 2018 15:31:20 +0000 (17:31 +0200)]
[MSGINA] Close the LSA handle on shutdown
Eric Kohl [Tue, 22 May 2018 14:32:10 +0000 (16:32 +0200)]
[MSGINA] Close the user token in WlxLogoff
Eric Kohl [Tue, 22 May 2018 12:39:38 +0000 (14:39 +0200)]
[MSGINA] Rename context variable: Domain -> DomainName
Eric Kohl [Tue, 22 May 2018 12:36:55 +0000 (14:36 +0200)]
[WINLOGON] Prevent shell restart when the user is logged off
Eric Kohl [Tue, 22 May 2018 09:30:27 +0000 (11:30 +0200)]
[BOOTDATA][MSGINA][SYSSETUP] Rename the DefaultDomain registry value to DefaultDomainName
Eric Kohl [Tue, 22 May 2018 09:06:38 +0000 (11:06 +0200)]
[MSGINA] Add the IgnoreShiftOverride feature again
Eric Kohl [Mon, 21 May 2018 14:29:02 +0000 (16:29 +0200)]
[MSGINA] Simplify the auto logon code path
- Get rid of DoAutoLogon() and the AutoLogonState variable.
- Handle the auto logon in the normal logon code path instead.
- Set bAutoAdminLogon to FALSE on a successful login. This will prevent another automatic logon after a logoff.
- The IgnoreShiftOverride feature got lost by this change but I will add it again.
Pierre Schweitzer [Mon, 21 May 2018 09:33:02 +0000 (11:33 +0200)]
[WINLOGON] Fix build.
Eric Kohl [Mon, 21 May 2018 09:20:50 +0000 (11:20 +0200)]
[WINLOGON] Close all dialog boxes on SAS
CORE-13593
Pierre Schweitzer [Mon, 21 May 2018 08:41:59 +0000 (10:41 +0200)]
[FASTFAT] Properly queue pending write IRPs.
Addendum to
30b836b
Pierre Schweitzer [Mon, 21 May 2018 08:28:44 +0000 (10:28 +0200)]
[FASTFAT] When extending a file, also lock the DirResource.
This avoids race conditions under high IOs and thus corruption on
the FS, or assertions failures in the kernel.
Easily triggered by building ReactOS on ReactOS ;-).
Eric Kohl [Mon, 21 May 2018 00:30:35 +0000 (02:30 +0200)]
[SETUPAPI] Add stubs for CM_Detect_Resource_Conflict and CM_Detect_Resource_Conflict_Ex
Hermès Bélusca-Maïto [Sun, 20 May 2018 20:38:48 +0000 (22:38 +0200)]
[CONUTILS] Remove old code; modify an informative note.
Joachim Henze [Sun, 20 May 2018 18:35:12 +0000 (20:35 +0200)]
[SDK] "0.4.10-dev" Starts here.
tag will be added in next commit.
Hermès Bélusca-Maïto [Sun, 20 May 2018 17:57:43 +0000 (19:57 +0200)]
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana.
Hermès Bélusca-Maïto [Sun, 20 May 2018 17:27:57 +0000 (19:27 +0200)]
[USETUP] Remove now-unneeded file.
Hermès Bélusca-Maïto [Sun, 20 May 2018 16:32:59 +0000 (18:32 +0200)]
[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoChk to start when booting the LiveCD. CORE-14633
Add also a missing closing quote.
Hermès Bélusca-Maïto [Sun, 20 May 2018 13:31:45 +0000 (15:31 +0200)]
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions.
Pierre Schweitzer [Sun, 20 May 2018 11:53:11 +0000 (13:53 +0200)]
[FASTFAT] Fail if allocating the stream FO fails.
Eric Kohl [Sun, 20 May 2018 09:53:01 +0000 (11:53 +0200)]
[SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice
Eric Kohl [Sun, 20 May 2018 09:35:43 +0000 (11:35 +0200)]
[SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W
Pierre Schweitzer [Sun, 20 May 2018 09:35:21 +0000 (11:35 +0200)]
[EVENTMSG] Add French translation.
Joachim Henze [Sat, 19 May 2018 23:41:34 +0000 (01:41 +0200)]
[OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608
Hermès Bélusca-Maïto [Sat, 19 May 2018 20:04:20 +0000 (22:04 +0200)]
[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with cluster size == 1 in any case so far (other sizes are UNIMPLEMENTED!)
Eric Kohl [Sat, 19 May 2018 16:11:48 +0000 (18:11 +0200)]
[SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List()
Katayama Hirofumi MZ [Sat, 19 May 2018 14:12:11 +0000 (23:12 +0900)]
[SHELL32] Allow deleting a file type/extension (#553)
CORE-12906
Eric Kohl [Sat, 19 May 2018 13:11:17 +0000 (15:11 +0200)]
[SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs
Pierre Schweitzer [Sat, 19 May 2018 11:45:56 +0000 (13:45 +0200)]
[FASTFAT] Addendum to
d69f318
Eric Kohl [Sat, 19 May 2018 11:30:20 +0000 (13:30 +0200)]
[USETUP] Use _wcstoui64() instead of atoi() to convert the partition size in order to prevent unexpected misinterpretation of leading zeroes.
Adam Słaboń [Sat, 19 May 2018 11:17:49 +0000 (13:17 +0200)]
[TRANSLATION] Polish translation update (#554)
- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).
Eric Kohl [Sat, 19 May 2018 10:41:37 +0000 (12:41 +0200)]
[BOOTDATA] Add the (still disabled) faeroese keyboard layout
CORE-13127
Eric Kohl [Sat, 19 May 2018 10:09:12 +0000 (12:09 +0200)]
[USETUP] Improved entering of partition size
Patch by Эдуард.
CORE-13249
Pierre Schweitzer [Sat, 19 May 2018 08:07:14 +0000 (10:07 +0200)]
[FASTFAT] Misc. fixes spotted by Thomas.
Pierre Schweitzer [Fri, 18 May 2018 21:00:13 +0000 (23:00 +0200)]
[FASTFAT] Completely rewrite support for dirty volumes.
Until now, our support for dirty volumes was totally broken
to a point where, on FAT32 volume, the dirty couldn't even
be written nor read from the disk.
This commit totally rewrites its handling, for both FAT16 and FAT32
so that it's now fully functionnal. Furthermore, it also gets
totally compatible with our vfatlib, and thus, autochk.
Now, on mount, FastFAT will check if the volume is dirty or not, and
autochk will be able to ask for a repair if dirty. vfatlib will
repair the volume and remove the dirty bit. So that, on next
reboot, the volume will be mounted clean.
As a reminder, the dirty bit is set immediately after mounting
the volume, so that, if you crash or have a powercut, autochk
will always attempt to repair your volume (with more or less,
that's FAT!).
If you want to experience without breaking your FAT volume,
just boot, open a cmd prompt and type: fsutil dirty set c:
and reboot!
CORE-13758
CORE-13760
CORE-13759
Pierre Schweitzer [Fri, 18 May 2018 20:35:03 +0000 (22:35 +0200)]
[FASTFAT] Allow locking system volume on boot.
This is a hack, and totally not the default behavior.
But it will allow autochk locking the boot volume in
order to verify it on boot, in case it would have
been improperly dismounted.
CORE-13759
Katayama Hirofumi MZ [Fri, 18 May 2018 20:27:22 +0000 (05:27 +0900)]
[SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552)
Mark Jansen [Sun, 13 May 2018 21:22:56 +0000 (23:22 +0200)]
[DRWTSN32] Use GetCommandLineW for CommandLineToArgvW.
Spotted by Hermès
Pierre Schweitzer [Fri, 18 May 2018 12:51:24 +0000 (14:51 +0200)]
[FASTFAT] Uninit directory cache on last handle close.
CORE-14629
CORE-14557
Pierre Schweitzer [Fri, 18 May 2018 12:03:20 +0000 (14:03 +0200)]
[FASTFAT] Only initialize directory cache on use.
This avoids initializing cache directly on directory
open/create.
The advantage is we reduce the load on cache manager
and on memory manager by avoiding creating everytime
a stream file object, and initializing cache for it.
This will avoid initializing cache for started
applications 'current directory' which is just opened
for having a valid handle but no read/write is performed
in it, by default.
This is a step forward for autochk.
CORE-14629
Katayama Hirofumi MZ [Fri, 18 May 2018 10:47:52 +0000 (19:47 +0900)]
[SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)
A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.
CORE-12906
Pierre Schweitzer [Fri, 18 May 2018 08:29:45 +0000 (10:29 +0200)]
[FASTFAT] When attaching our FCB to a FO, also set the VPB.
Spotted by Alex.
Wexpo Lyu [Thu, 17 May 2018 17:57:57 +0000 (01:57 +0800)]
[TRANSLATION][DRWTSN32] Add zh-CN translation. (#549)
Wexpo Lyu [Wed, 16 May 2018 13:28:58 +0000 (21:28 +0800)]
[TRANSLATION][TASKMGR] Update Chinese Translation.
Serge Gautherie [Sat, 24 Feb 2018 15:16:26 +0000 (16:16 +0100)]
[IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
- Improve/Promote failures to ERR.
- Improve other TRACE calls.
Baruch Rutman [Thu, 17 May 2018 15:18:57 +0000 (18:18 +0300)]
[CHARMAP]Code improvements (#436)
* [CHARMAP][GETUNAME] Code improvements
Based on the code from nls2txt,
switches the linking from dynamic to static, also simplifies the code.
Serge Gautherie [Tue, 16 Jan 2018 04:47:34 +0000 (05:47 +0100)]
[KMTEST] Check/Wait for start/stop of services to complete
This is cleaner behavior and lets report failures.
- Create KmtEnsureServiceState(),
called at end of KmtStartService() and KmtStopService().
- Create KmtGetServiceStateAsString(),
called from KmtEnsureServiceState().
ROSTESTS-263
Peter Wathall [Mon, 30 Apr 2018 00:17:19 +0000 (00:17 +0000)]
Fixed typo
Peter Wathall [Mon, 30 Apr 2018 00:17:01 +0000 (00:17 +0000)]
Fixed typo
Peter Wathall [Mon, 30 Apr 2018 00:16:45 +0000 (00:16 +0000)]
Fixed typo
Pierre Schweitzer [Wed, 16 May 2018 19:44:47 +0000 (21:44 +0200)]
[FASTFAT] Deny dismounting system volume or a volume with a pagefile
Eric Kohl [Tue, 15 May 2018 21:35:17 +0000 (23:35 +0200)]
[USETUP] Remove the WIN32 support because usetup is a native-only application
Eric Kohl [Tue, 15 May 2018 20:58:34 +0000 (22:58 +0200)]
[USETUP] Disable install path test that may tests
Eric Kohl [Tue, 15 May 2018 18:02:04 +0000 (20:02 +0200)]
[USETUP] Remove unused VolumeLabel and FileSystemName from the PARTENTRY type
Eric Kohl [Tue, 15 May 2018 17:47:52 +0000 (19:47 +0200)]
[USETUP] Get rid of the interface directory because we support text-mode only
Eric Kohl [Tue, 15 May 2018 16:11:12 +0000 (18:11 +0200)]
[USETUP] Simplify the unattended code path in the install directory page and verify the unattended install path.
Eric Kohl [Tue, 15 May 2018 13:45:31 +0000 (15:45 +0200)]
[USETUP] Improve the install path checks
- Path must not contain whitespace characters.
- Path must be at least 2 characters long.
- Path must start with a backslash.
- Path must not end with a backslash.
- Path components must not end with a dot.
CORE-9529
Eric Kohl [Tue, 15 May 2018 09:28:33 +0000 (11:28 +0200)]
[USETUP] Add support for HOME, END, DEL, LEFT and RIGHT keys to partition size and install path edit fields.
CORE-13975
Eric Kohl [Mon, 14 May 2018 21:35:48 +0000 (23:35 +0200)]
[USETUP] Fix the name of the backspace key in the german translation
CORE-14006
Thomas Faber [Mon, 14 May 2018 16:16:02 +0000 (18:16 +0200)]
[NDIS] Fix parameter order when calling ResetHandler. CORE-14624
Hermès Bélusca-Maïto [Sun, 13 May 2018 20:15:41 +0000 (22:15 +0200)]
[CLIPBRD] Improvements for the Clipboard Viewer.
- Improve the scrolling support for bitmaps, DIBs and text formats.
This completes the work started in CORE-10679 by Ricardo Hanke.
Includes scrolling with the keyboard and the mouse wheel.
- Add support for the CF_DSP* clipboard formats, as well as CF_TEXT
and CF_OEMTEXT.
- Add support for owner-display clipboard format CF_OWNERDISPLAY.
- Realize any palette found in the clipboard (CF_PALETTE) before
displaying the clipboard data format we want.
- Remove dead code.
- Update the file headers.
Andrew Cook [Sun, 13 May 2018 04:56:44 +0000 (14:56 +1000)]
Add virtio drivers to reactos.dff.in
qxl has some visual glitches, viostor loads but it seems reactos
doesn't support scsi disks yet
Katayama Hirofumi MZ [Sat, 12 May 2018 14:33:01 +0000 (23:33 +0900)]
[SHELL32] In #543, I forgot sq-AL.rc and sv-SE.rc
Katayama Hirofumi MZ [Sat, 12 May 2018 12:06:13 +0000 (21:06 +0900)]
[shell32] add some control IDs for IDD_FOLDER_OPTIONS_FILETYPES
Mark Jansen [Fri, 27 Apr 2018 20:43:45 +0000 (22:43 +0200)]
[LDR] Initial verifier implementation
Mark Jansen [Thu, 26 Apr 2018 22:05:21 +0000 (00:05 +0200)]
[VERIFIER] Add skeleton provider.
Mark Jansen [Thu, 26 Apr 2018 22:05:06 +0000 (00:05 +0200)]
[SDK] Add initial verifier header.
Mark Jansen [Thu, 26 Apr 2018 20:54:23 +0000 (22:54 +0200)]
[SDK] Correct NtGlobalFlag names.
Eric Kohl [Sat, 12 May 2018 10:42:56 +0000 (12:42 +0200)]
[SETUPAPI] SetupDiCallClassInstaller: Use the class GUID enclosed in curly brackets as a sub key name to retrieve the class co-installer.
Eric Kohl [Sat, 12 May 2018 10:38:27 +0000 (12:38 +0200)]
[BOOTDATA] Register the CriticalDeviceCoInstaller for the keyboard device class
Pierre Schweitzer [Sat, 12 May 2018 10:00:09 +0000 (12:00 +0200)]
[FASTFAT] Implement support for stack overflow in read operations.
Before performing a read operation, FastFAT driver will
attempt to compute whether it would run out of stack
during the operation. If so, instead of attempting the
operation in the current thread, it will post the read
request to the overflow thread.
This should help with the regressions brought in by
94ead99e0c503faa40b33b813cce296ea5c0bc0c.
CORE-14601
Thomas Faber [Sat, 12 May 2018 07:42:52 +0000 (09:42 +0200)]
[USBPORT] Fix x64 build.
Bișoc George [Fri, 11 May 2018 18:28:44 +0000 (20:28 +0200)]
[INETCPL] Fix a typo in Romanian resource file
Vadim Galyant [Fri, 11 May 2018 13:34:49 +0000 (15:34 +0200)]
[USBPORT][USBOHCI_NEW] Avoid using pointers for physical addresses.
Thomas Faber [Fri, 11 May 2018 13:42:19 +0000 (15:42 +0200)]
[USBOHCI_NEW] Fix build.
Eric Kohl [Thu, 10 May 2018 15:13:04 +0000 (17:13 +0200)]
[BOOTDATA] Add settings for the Latvian (QUERTY) keyboard layout (disabled)
Eric Kohl [Thu, 10 May 2018 14:18:04 +0000 (16:18 +0200)]
[USETUP] Use an existing latvian keyboard layout
Use the existing Latvian keyboard layout instead of the Latvian (QUERTY) keyboard layout, which it not implemented yet.
CORE-14561
Eric Kohl [Thu, 10 May 2018 14:03:59 +0000 (16:03 +0200)]
[BOOTDATA] Remove superfluous quotation marks
Pierre Schweitzer [Thu, 10 May 2018 08:33:05 +0000 (10:33 +0200)]
[NTOSKRNL] Fix FsRtlStackOverflow work item free.
Oneliner of the day... This typo just prevented the
whole feature to work properly. Because any allocated
work item would miserably fail to be freed.
This will obviously help real world FSD relying on
StackOverflow worker from FsRtl to work better!
CORE-14611
Pierre Schweitzer [Fri, 4 May 2018 19:35:25 +0000 (21:35 +0200)]
[AUTOCHK] Statically link to FS libs.
This will help reducing the number of handles open.
CORE-13759