6 years ago[KMTESTS:CC]
Pierre Schweitzer [Sat, 28 May 2016 19:59:10 +0000 (19:59 +0000)]
Introduce tests for Cc :-)
Currently, we only test CcCopyRead for specific alignment matters. It shows that under certain conditions, our Cc doesn't align reads it does, leading to later failure in disk.sys.
This reproduces an error observed with MS FastFAT in ReactOS.


svn path=/trunk/; revision=71445

6 years ago[WIN32K]: Whitespace fix only.
Hermès Bélusca-Maïto [Sat, 28 May 2016 19:48:44 +0000 (19:48 +0000)]
[WIN32K]: Whitespace fix only.

svn path=/trunk/; revision=71444

6 years ago[DESK.CPL]
Hermès Bélusca-Maïto [Sat, 28 May 2016 19:12:14 +0000 (19:12 +0000)]
- Only use the minimum required registry rights needed in RegOpenKeyEx and RegCreateKeyEx calls.
- Fix SetDesktopBackColor function where we tried to save the selected desktop background color in the registry only in the case where opening the corresponding registry key actually failed... >_>
  Now we do the right thing!

svn path=/trunk/; revision=71443

6 years ago[APPHELP][APPHELP_APITEST] Implement various VersionLie shims. CORE-11299 #resolve
Mark Jansen [Sat, 28 May 2016 17:55:56 +0000 (17:55 +0000)]
[APPHELP][APPHELP_APITEST] Implement various VersionLie shims. CORE-11299 #resolve
- Implement VersionLie shims
- Add tests for the VersionLie shims
- update get_host_winver prototype (thanks to Thomas for pointing out my err)

We cannot apply this shim yet, since a required part of the infrastructure is missing.

svn path=/trunk/; revision=71442

6 years ago[SHELL32]: Always paint the desktop listview transparent. This allows explorer to...
Hermès Bélusca-Maïto [Sat, 28 May 2016 16:59:55 +0000 (16:59 +0000)]
[SHELL32]: Always paint the desktop listview transparent. This allows explorer to display the default desktop background color set by win32k as well as the ReactOS version on the desktop.
See also r66271 and r66752.

svn path=/trunk/; revision=71441

6 years ago[APPHELP] Register AppPatch directory with cmake, import SdbGetAppPatchDir implementa...
Mark Jansen [Sat, 28 May 2016 16:47:39 +0000 (16:47 +0000)]
[APPHELP] Register AppPatch directory with cmake, import SdbGetAppPatchDir implementation from Mislav Blažević CORE-10369

svn path=/trunk/; revision=71440

6 years ago[APPHELP] Begin shimlib implementation. CORE-11329
Mark Jansen [Sat, 28 May 2016 16:42:57 +0000 (16:42 +0000)]
[APPHELP] Begin shimlib implementation. CORE-11329
Implement some macro's and functions that help when registering shims.
These are all written in C, so that wine can use the shim libraries as well.

svn path=/trunk/; revision=71439

6 years ago[KDCOM]: Properly revert the commits.
Hermès Bélusca-Maïto [Sat, 28 May 2016 15:54:44 +0000 (15:54 +0000)]
[KDCOM]: Properly revert the commits.

svn path=/trunk/; revision=71438

6 years agoRevert a mistake commit...
Timo Kreuzer [Sat, 28 May 2016 15:51:44 +0000 (15:51 +0000)]
Revert a mistake commit...

svn path=/trunk/; revision=71437

6 years agoPatch "works": continue vs return stuff
Timo Kreuzer [Sat, 28 May 2016 15:46:49 +0000 (15:46 +0000)]
Patch "works": continue vs return stuff

svn path=/trunk/; revision=71436

6 years ago[TIMEDATE.CPL]: Do not hardcode some of the buffer lengths.
Hermès Bélusca-Maïto [Sat, 28 May 2016 15:23:00 +0000 (15:23 +0000)]
[TIMEDATE.CPL]: Do not hardcode some of the buffer lengths.

svn path=/trunk/; revision=71435

6 years ago[NETSHELL]
Eric Kohl [Sat, 28 May 2016 00:18:39 +0000 (00:18 +0000)]
German translation and fixed layout
Patch by reactosfanboy.
CORE-11278 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71434

6 years ago[TIMEDATE]
Eric Kohl [Sat, 28 May 2016 00:12:02 +0000 (00:12 +0000)]
Fixes and improvements to datetime CPL applet.
Patch by Carlo Bramini.
Replaced the original RegLocalQuery() by QueryTimezoneData() to simplify the error handling.
Modification by Eric Kohl.
CORE-11284 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71433

6 years ago[REISERFS]
Pierre Schweitzer [Fri, 27 May 2016 20:35:44 +0000 (20:35 +0000)]
r71430, repetita

svn path=/trunk/; revision=71432

6 years ago[DOC]
Pierre Schweitzer [Fri, 27 May 2016 20:32:45 +0000 (20:32 +0000)]
Add a file to track imported FSD and their release

svn path=/trunk/; revision=71431

6 years ago[FFS]
Pierre Schweitzer [Fri, 27 May 2016 17:52:03 +0000 (17:52 +0000)]
We don't need that file


svn path=/trunk/; revision=71430

6 years ago[FS_REC]
Pierre Schweitzer [Fri, 27 May 2016 12:18:47 +0000 (12:18 +0000)]
Add support for FFS volumes.
Patch by Peter Hater.

This is done for FFS support! Enjoy :-)

CORE-11040 #resolve

svn path=/trunk/; revision=71429

6 years ago[PSDK]
Pierre Schweitzer [Fri, 27 May 2016 12:13:49 +0000 (12:13 +0000)]
Now, ReactOS recognizes the FFS partition :-)


svn path=/trunk/; revision=71428

6 years ago[FFS]
Pierre Schweitzer [Fri, 27 May 2016 12:12:18 +0000 (12:12 +0000)]
Enable the FFS support.
Patch by Peter Hater.


svn path=/trunk/; revision=71427

6 years ago[AUTOCHK]
Pierre Schweitzer [Fri, 27 May 2016 12:11:15 +0000 (12:11 +0000)]
Add support for FFS


svn path=/trunk/; revision=71426

6 years ago[FFS]
Pierre Schweitzer [Fri, 27 May 2016 12:08:38 +0000 (12:08 +0000)]
Import the FFS driver by Jae-Hong Lee.
Patch by Peter Hater


svn path=/trunk/; revision=71425

6 years ago[UFFS]
Pierre Schweitzer [Fri, 27 May 2016 12:05:40 +0000 (12:05 +0000)]
Add the FFS DLL


svn path=/trunk/; revision=71424

6 years ago[FFSLIB]
Pierre Schweitzer [Fri, 27 May 2016 12:04:45 +0000 (12:04 +0000)]
Stub the FFS lib


svn path=/trunk/; revision=71423

6 years ago[REACTOS]: Add a desktop shortcut to the ReadMe file of ReactOS, on both the livecd...
Hermès Bélusca-Maïto [Fri, 27 May 2016 01:06:35 +0000 (01:06 +0000)]
[REACTOS]: Add a desktop shortcut to the ReadMe file of ReactOS, on both the livecd and installation. Useful for people discovering ReactOS for the first time.

svn path=/trunk/; revision=71422

6 years ago[INCLUDES] probe.h: use ExFreePoolWithTag for releasing unicode strings capture,...
Hermès Bélusca-Maïto [Thu, 26 May 2016 23:17:59 +0000 (23:17 +0000)]
[INCLUDES] probe.h: use ExFreePoolWithTag for releasing unicode strings capture, and fully clear up said strings.

svn path=/trunk/; revision=71421

6 years ago[WIN32K]: it can be useful to have a TAG_USTR for unicode strings.
Hermès Bélusca-Maïto [Thu, 26 May 2016 23:16:10 +0000 (23:16 +0000)]
[WIN32K]: it can be useful to have a TAG_USTR for unicode strings.

svn path=/trunk/; revision=71420

6 years ago[NETSHELL]: Fix french orthograph.
Hermès Bélusca-Maïto [Thu, 26 May 2016 22:36:57 +0000 (22:36 +0000)]
[NETSHELL]: Fix french orthograph.

svn path=/trunk/; revision=71419

6 years ago[USETUP]
Pierre Schweitzer [Thu, 26 May 2016 20:50:44 +0000 (20:50 +0000)]
Don't override the hidden sectors value set during format when seting up bootsector.
This allows installing ReactOS on a FAT partition that doesn't start on sector 63. Successfully tested with a partition starting on sector 2048, for instance.
Patch by Wim Hueskes

CORE-8825 #resolve #comment Committed in r71418. Thanks for the debugging and the patch!

svn path=/trunk/; revision=71418

6 years ago[FS_REC]
Pierre Schweitzer [Thu, 26 May 2016 18:17:19 +0000 (18:17 +0000)]
Add support for ReiserFS volumes.
Patch by Peter Hater.

This is done for ReiserFS support! Enjoy :-)

CORE-11005 #resolve

svn path=/trunk/; revision=71417

6 years ago[REISERFS]
Pierre Schweitzer [Thu, 26 May 2016 18:14:52 +0000 (18:14 +0000)]
Enable the ReiserFS support.
Patch by Peter Hater.


svn path=/trunk/; revision=71416

6 years ago[AUTOCHK]
Pierre Schweitzer [Thu, 26 May 2016 18:12:36 +0000 (18:12 +0000)]
Add support for ReiserFS


svn path=/trunk/; revision=71415

6 years ago[REISERFS]
Pierre Schweitzer [Thu, 26 May 2016 18:11:57 +0000 (18:11 +0000)]
Enable ReiserFS FSD build


svn path=/trunk/; revision=71414

6 years ago[UREISERFS]
Pierre Schweitzer [Thu, 26 May 2016 18:10:20 +0000 (18:10 +0000)]
Add the ReiserFS DLL


svn path=/trunk/; revision=71413

6 years ago[REISERFSLIB]
Pierre Schweitzer [Thu, 26 May 2016 18:08:42 +0000 (18:08 +0000)]
Stub the ReiserFS lib


svn path=/trunk/; revision=71412

6 years ago[EXT2]
Pierre Schweitzer [Thu, 26 May 2016 17:10:02 +0000 (17:10 +0000)]
Upgrade the driver to release 0.66.

CORE-11295 #resolve #comment Committed in r71411

svn path=/trunk/; revision=71411

6 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 26 May 2016 16:35:45 +0000 (16:35 +0000)]
Cherry pick r71407 by Trevor Thompson:
- Rewrote FsRtlGetNextBaseMcbEntry(), FsRtlLookupBaseMcbEntry(), and FsRtlNumberOfRunsInBaseMcb() using simpler logic.

This finally fixes broken MCB handling in ReactOS and allows FSDs relying on MCB to properly work in ReactOS!

CORE-11002 #resolve #comment Fixed in r71409

svn path=/trunk/; revision=71409

6 years ago[SERVMAN]
Eric Kohl [Thu, 26 May 2016 15:48:46 +0000 (15:48 +0000)]
GetServiceConfig: Use only the required access rights. Makes servman usable for non-admin users.

svn path=/trunk/; revision=71408

6 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 26 May 2016 12:09:05 +0000 (12:09 +0000)]
Rework a bit the way mapping and pinning is working in ReactOS Cc. This is still wrong regarding the way Windows does it, but at least, it offers us more features for a more compatible behavior exposed to FSDs.
First of all, reintroduce the mutex used to lock VACB. Moving there to a resource wasn't enough to work address the issue. This reverts r71387.
Introduce the resource in the BCB, as it should be. This resource will be unused until pinning occurs. In such case, the VACB mutex gets unused so that we can get the BCB released by another thread without deadlocking the associated VACB.
The VACB can be locked again after the last unpinning operation.
Basically, that fixes drivers than pin in a thread and unpin in another thread, after having changed BCB owner. Until now, it would just have deadlock or crashed ReactOS.
The implementation of this preserves hacks and stubplementations already in place in Cc (let's say it's another hack on top of hacks).
It was successfully tested with Ext2Fsd 0.66.

Short summary:
- Replace the VACB resource by a mutex
- Introduce a resource in the BCB
- Fixed CcPinRead() implementation so that it respects PIN_EXCLUSIVE flag
- Implement CcUnpinDataForThread() so that it can unpin data which ownership was changed
- Implement CcSetBcbOwnerPointer() so that it properly set BCB owner and allows unpinning with CcUnpinDataForThread()

CORE-11310 #resolve #comment Committed in r71406

svn path=/trunk/; revision=71406

6 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 26 May 2016 11:50:42 +0000 (11:50 +0000)]
On CcInitializeCacheMap() call, keep track of the PinAccess value so that we can later check it on pinning.
It shouldn't be set to FALSE when the user attempts to perform pinning


svn path=/trunk/; revision=71404

6 years ago[USER32]: Remove a leftover from r59868.
Hermès Bélusca-Maïto [Thu, 26 May 2016 00:53:54 +0000 (00:53 +0000)]
[USER32]: Remove a leftover from r59868.

svn path=/trunk/; revision=71403

6 years ago[KERNEL32]: Indentation fix only.
Hermès Bélusca-Maïto [Wed, 25 May 2016 20:49:40 +0000 (20:49 +0000)]
[KERNEL32]: Indentation fix only.

svn path=/trunk/; revision=71402

6 years ago[APPHELP_APITEST] Remove some code duplication.
Mark Jansen [Wed, 25 May 2016 17:22:47 +0000 (17:22 +0000)]
[APPHELP_APITEST] Remove some code duplication.

svn path=/trunk/; revision=71400

6 years ago[KERNEL32]
David Quintana [Wed, 25 May 2016 14:47:02 +0000 (14:47 +0000)]
* Return TRUE from SetThreadStackGuarantee. Allows .NET 2.0 setup to complete and consequently allows some .net apps to work in ReactOS. Patch by the self-proclaimed Master of The Universe, Samuel Serapión.

svn path=/trunk/; revision=71399

6 years ago[NTOS:EX]
Thomas Faber [Wed, 25 May 2016 10:27:17 +0000 (10:27 +0000)]
- Use the calling thread instead of the passed-in thread to validate APC status in ExReleaseResourceForThreadLite. The latter can be user-set and might not be a KTHREAD at all.
CORE-11315 #resolve

svn path=/trunk/; revision=71398

6 years ago[NTDLL]
Hermès Bélusca-Maïto [Tue, 24 May 2016 19:57:29 +0000 (19:57 +0000)]
Add exports for RtlOemStringToUnicodeSize, RtlUnicodeStringToAnsiSize and RtlUnicodeStringToOemSize as redirections to suitable Rtlx*** functions, as done in our ntoskrnl (and as on Windows either).
This should fix MSYS2 start on ReactOS.
CORE-10459 #comment Please retest!

svn path=/trunk/; revision=71397

6 years ago[CRT] Partially sync strtoi64 with Wine Staging 1.9.9. Patch by Samuel Serapión CORE...
Mark Jansen [Tue, 24 May 2016 19:27:57 +0000 (19:27 +0000)]
[CRT] Partially sync strtoi64 with Wine Staging 1.9.9. Patch by Samuel Serapión CORE-11174 #resolve #comment Thanks!

svn path=/trunk/; revision=71396

6 years ago[KMTESTS]
Pierre Schweitzer [Tue, 24 May 2016 08:13:17 +0000 (08:13 +0000)]
Add test for ExSetResourceOwnerPointer() and ExReleaseResourceForThreadLite()


svn path=/trunk/; revision=71395

6 years ago[SERVICES]
Eric Kohl [Mon, 23 May 2016 21:48:32 +0000 (21:48 +0000)]
- RChangeServiceConfigA/W: Modify or delete password secrets.
- ChangeServiceConfigA, CreateServiceA: Convert passwords to Unicode before passing them to the remote functions.

svn path=/trunk/; revision=71394

6 years ago[NTOSKRNL]
Pierre Schweitzer [Mon, 23 May 2016 21:14:49 +0000 (21:14 +0000)]
Fix misleading comment

svn path=/trunk/; revision=71393

6 years ago[NTOSKRNL]
Pierre Schweitzer [Mon, 23 May 2016 19:47:39 +0000 (19:47 +0000)]
In Cc, replace the Vacb mutex by a Bcb resource.
Note that the resource is still placed in the Vacb by it belongs to the Bcb.
This is required to really implement CcSetBcbOwnerPointer().


svn path=/trunk/; revision=71387

6 years ago[SERVICES]
Eric Kohl [Mon, 23 May 2016 15:02:37 +0000 (15:02 +0000)]
RCreateServiceW: Store a given password as a secret.

svn path=/trunk/; revision=71386

6 years ago[ADVAPI32]
Eric Kohl [Mon, 23 May 2016 13:53:24 +0000 (13:53 +0000)]
Implement LogonUserEx[A/W].

svn path=/trunk/; revision=71385

6 years ago[ADVAPI32]: Implement all the Elf*** event log APIs as wrappers around the correspond...
Hermès Bélusca-Maïto [Mon, 23 May 2016 02:03:49 +0000 (02:03 +0000)]
[ADVAPI32]: Implement all the Elf*** event log APIs as wrappers around the corresponding RPC calls, and the Win32 APIs just become calls to the Elf*** APIs.

svn path=/trunk/; revision=71384

6 years ago[IDL]: Whitespace fixes only.
Hermès Bélusca-Maïto [Sun, 22 May 2016 22:20:25 +0000 (22:20 +0000)]
[IDL]: Whitespace fixes only.

svn path=/trunk/; revision=71383

6 years ago[RTL]
Thomas Faber [Sun, 22 May 2016 22:11:54 +0000 (22:11 +0000)]
- Return the ACE pointer from RtlFirstFreeAce also if it is at the end of the ACL buffer.
CORE-11304 #resolve

svn path=/trunk/; revision=71382

6 years ago[APPHELP][APPHELP_APITEST] Add more db tests and implement SdbGetDatabaseVersion...
Mark Jansen [Sun, 22 May 2016 20:39:41 +0000 (20:39 +0000)]
[APPHELP][APPHELP_APITEST] Add more db tests and implement SdbGetDatabaseVersion. CORE-10367

svn path=/trunk/; revision=71381

6 years ago[APPHELP][APPHELP_APITEST] Implement most of sdbread and sdbwrite, mainly the work...
Mark Jansen [Sun, 22 May 2016 20:27:02 +0000 (20:27 +0000)]
[APPHELP][APPHELP_APITEST] Implement most of sdbread and sdbwrite, mainly the work of Mislav Blaževic, with some small additions from me. CORE-10367

svn path=/trunk/; revision=71380

6 years ago[SETUPAPI]
Thomas Faber [Sun, 22 May 2016 19:09:49 +0000 (19:09 +0000)]
- Fix Buffer overflow in FixupServiceBinaryPath

svn path=/trunk/; revision=71379

6 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 19:00:55 +0000 (19:00 +0000)]
- Fix the flags used in LoadLibraryEx calls for loading DLLs as resource files.
- Use a nice flag (FORMAT_MESSAGE_MAX_WIDTH_MASK) in FormatMessage calls so that no useless extra newlines are appended to the message strings that are recovered.
  This is especially useful when some strings as localized event log names are retrieved to be displayed in the menu (amongst other things)...
  This fixes CORE-8915 and fixes also the presentation of some event descriptions.
- Fix BuildLogList.

svn path=/trunk/; revision=71378

6 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 17:17:33 +0000 (17:17 +0000)]
- Set window parent for different MessageBox calls.
- Add a notice in ShowStatusMessageThread concerning a potential bug.
- Rename strings "Save Protocol" into "Save Event Log"; adjust translations in this regard.

svn path=/trunk/; revision=71377

6 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 16:19:55 +0000 (16:19 +0000)]
- Fix a typo in the "loading, wait" dialog.
- Use a RichEdit control for the detailed event description text, so that we can have for free clickable URLs.
- Use "Courier New" as the font for the event data text, so that we can have finer grained control over the font size...

svn path=/trunk/; revision=71376

6 years ago[PSDK]
Pierre Schweitzer [Sun, 22 May 2016 13:22:52 +0000 (13:22 +0000)]


svn path=/trunk/; revision=71375

6 years ago[EVENTVWR]
Eric Kohl [Sun, 22 May 2016 12:15:30 +0000 (12:15 +0000)]
Display event data properly.

svn path=/trunk/; revision=71374

6 years ago[SCHANNEL]
Thomas Faber [Sun, 22 May 2016 10:56:22 +0000 (10:56 +0000)]
- Set received length to zero when the receive result is MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY instead of pretending we got data
CORE-11285 #resolve

svn path=/trunk/; revision=71373

6 years ago[SCHANNEL]
Thomas Faber [Sun, 22 May 2016 10:53:23 +0000 (10:53 +0000)]
- Correctly check for ROS_SCHAN_IS_BLOCKING

svn path=/trunk/; revision=71372

6 years ago[UNIATA]
Thomas Faber [Sun, 22 May 2016 10:25:24 +0000 (10:25 +0000)]
- When handling CD READ_CAPACITY requests in AtapiInterrupt__, fully rewind the DataBuffer instead of relying on the last read length. Fixes crash on first stage boot in KVM.
CORE-11286 #resolve

svn path=/trunk/; revision=71371

6 years ago[VFATLIB]
Pierre Schweitzer [Sun, 22 May 2016 07:56:45 +0000 (07:56 +0000)]
Update the amount of FAT entries taking into account that the first two are reserved and thus not usable.

Patch by Wim Hueskes

CORE-11283 #resolve #comment Committed in r71370, thanks for your patch!

svn path=/trunk/; revision=71370

6 years ago[SYSSETUP]
Pierre Schweitzer [Sun, 22 May 2016 07:56:23 +0000 (07:56 +0000)]
Update acknowledgements regarding imported FSDs in ReactOS.

Thanks Matt Wu and Mark Harmstone for your great work!

svn path=/trunk/; revision=71369

6 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 00:34:40 +0000 (00:34 +0000)]
- Fix the window styles of the edit boxes in the event details dialog.
- Refactor some parts of the code to reduce the level of code indentation.
- Replace malloc/free by their Win32 counterparts HeapAlloc/HeapFree.
- When caching the full contents of a given event log, don't load at this point the event text/data. Only load those when opening the event details dialog.

svn path=/trunk/; revision=71368

6 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sat, 21 May 2016 21:44:14 +0000 (21:44 +0000)]
- Finish to convert the app to full unicode;
- Don't hardcode buffer lengths in function calls;
- Remove useless #pragma incantation;
- Whitespace fix.

svn path=/trunk/; revision=71367

6 years ago[FREELDR]: Increase again the number of BIOS memory descriptors to 80.
Hermès Bélusca-Maïto [Sat, 21 May 2016 16:12:31 +0000 (16:12 +0000)]
[FREELDR]: Increase again the number of BIOS memory descriptors to 80.
CORE-11247 #comment Please retest.

svn path=/trunk/; revision=71366

6 years ago[SAMSRV]
Eric Kohl [Sat, 21 May 2016 15:05:49 +0000 (15:05 +0000)]
Implement SamrGetDomainPasswordInformation.

svn path=/trunk/; revision=71365

6 years ago[SAMSRV]
Eric Kohl [Sat, 21 May 2016 13:12:53 +0000 (13:12 +0000)]
Add LM_OWF_PASSWORD and NT_OWF_PASSWORD types and use them.
See MS-NRPC sections to

svn path=/trunk/; revision=71364

6 years ago[NETSHELL]
Pierre Schweitzer [Sat, 21 May 2016 09:40:18 +0000 (09:40 +0000)]
Update French translation


svn path=/trunk/; revision=71363

6 years ago[MBEDTLS][SCHANNEL] Export mbedtls_ssl_config_free and use it. Patch by Peter Hater...
Mark Jansen [Fri, 20 May 2016 17:09:56 +0000 (17:09 +0000)]
[MBEDTLS][SCHANNEL] Export mbedtls_ssl_config_free and use it. Patch by Peter Hater. CORE-11270 #resolve #comment Thanks!

svn path=/trunk/; revision=71362

6 years ago[SDK][CMAKE] The CMake folder is part of our SDK. CORE-9111
Amine Khaldi [Fri, 20 May 2016 16:06:48 +0000 (16:06 +0000)]
[SDK][CMAKE] The CMake folder is part of our SDK. CORE-9111

svn path=/trunk/; revision=71361

6 years ago[TASKMGR] improvement german: too long string in statusbar - Patch by Joachim Henze.
Robert Naumann [Thu, 19 May 2016 22:41:08 +0000 (22:41 +0000)]
[TASKMGR] improvement german: too long string in statusbar - Patch by Joachim Henze.

svn path=/trunk/; revision=71360

6 years ago[SDK/INCLUDE]: Fix a typo in (Debuger --> Debugger).
Hermès Bélusca-Maïto [Thu, 19 May 2016 22:18:11 +0000 (22:18 +0000)]
[SDK/INCLUDE]: Fix a typo in (Debuger --> Debugger).

svn path=/trunk/; revision=71359

6 years ago[SDK/INCLUDE]: Fix extra end-line whitespace and erroneous newlines...
Hermès Bélusca-Maïto [Thu, 19 May 2016 21:22:41 +0000 (21:22 +0000)]
[SDK/INCLUDE]: Fix extra end-line whitespace and erroneous newlines at the end of the messages.

svn path=/trunk/; revision=71358

6 years ago[AFD]
Thomas Faber [Thu, 19 May 2016 21:17:18 +0000 (21:17 +0000)]
- Don't overwrite values in a completed IRP in ReceiveActivity
CORE-11276 #resolve

svn path=/trunk/; revision=71357

6 years ago[NETSHELL]
Eric Kohl [Thu, 19 May 2016 13:42:37 +0000 (13:42 +0000)]
- Provide a common struct for the network setup data.
- Remember the typical/custom setup decision in order to return to the proper previous page when we click the 'Back' button on the domain page.
- Rename network setup page functions in a consistent way.

svn path=/trunk/; revision=71356

6 years ago[SERVICES]
Thomas Faber [Thu, 19 May 2016 13:01:04 +0000 (13:01 +0000)]
- On service stop, set Service->lpImage to NULL after calling ScmDereferenceServiceImage, so the same image is not dereferenced again on service deletion
- Do not call ScmDereferenceServiceImage in CreateServiceListEntry, as the service should never have an image there
CORE-11273 #resolve

svn path=/trunk/; revision=71355

6 years ago[ACPI]
Thomas Faber [Thu, 19 May 2016 10:15:15 +0000 (10:15 +0000)]
- Correctly double-null-terminate hardware IDs
CORE-11271 #resolve

svn path=/trunk/; revision=71354

6 years ago[NETSHELL]
Hermès Bélusca-Maïto [Wed, 18 May 2016 21:49:31 +0000 (21:49 +0000)]
Addendum to r71348:
Fix MSVC build: "netshell\lang/de-DE.rc(87) : warning RC2182 : duplicate dialog control ID 3501" . Both IDC_NETWORK_TYPICAL and IDC_NETWORK_CUSTOM setup wizard pages had this same ID.
Obviously, GCC didn't catch this error. But the generated code would not have worked as expected.

CORE-10955 #comment [~milawynsrealm], please retest with r71353.

svn path=/trunk/; revision=71353

6 years agoTest commit to fix the nightmare caused by "previous" r71352.
Colin Finck [Wed, 18 May 2016 17:01:01 +0000 (17:01 +0000)]
Test commit to fix the nightmare caused by "previous" r71352.

svn path=/trunk/; revision=71352

6 years ago[SHELL32] Addendum to r71343: Remove some unneeded checks. The handles are initialize...
Robert Naumann [Wed, 18 May 2016 10:12:13 +0000 (10:12 +0000)]
[SHELL32] Addendum to r71343: Remove some unneeded checks. The handles are initialized as NULL so they will never be true

svn path=/trunk/; revision=71351

6 years ago[TASKMGR] Use the correct title string for create new task dialog. Spotted by Jared...
Robert Naumann [Wed, 18 May 2016 08:30:45 +0000 (08:30 +0000)]
[TASKMGR] Use the correct title string for create new task dialog. Spotted by Jared Smudde. CORE-11129

svn path=/trunk/; revision=71350

6 years ago[ROSAPPS/RDESKTOP]: Fix an heresy in the code.
Hermès Bélusca-Maïto [Tue, 17 May 2016 22:44:47 +0000 (22:44 +0000)]
[ROSAPPS/RDESKTOP]: Fix an heresy in the code.

svn path=/trunk/; revision=71349

Eric Kohl [Tue, 17 May 2016 22:38:58 +0000 (22:38 +0000)]
2nd Stage Network Setup
Patch by Lee Schroeder and Eric Kohl.
- Move Lees 2nd stage network setup wizard code to netshell. It gets called by syssetup via NetSetupRequestWizardPages().
- Add code to syssetup which calls NetSetupRequestWizardPages and inserts the retrieved wizard pages into the setup wizard.
- Prevent a font handle leak by storing the bold font handle in the SetuData.

CORE-10955 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71348

6 years ago[PSDK] now the ICurrentWorkingDirectory interface is actually an interface.
Mark Jansen [Mon, 16 May 2016 18:50:14 +0000 (18:50 +0000)]
[PSDK] now the ICurrentWorkingDirectory interface is actually an interface.

svn path=/trunk/; revision=71347

6 years ago[NETAPI32]
Eric Kohl [Mon, 16 May 2016 18:34:52 +0000 (18:34 +0000)]
Add NetGetAnyDCName stub.
CORE-11261 #comment Please test again!

svn path=/trunk/; revision=71346

6 years ago[BROWSEUI_APITEST] Add tests for ACListISF, a class used for autocompletion. CORE...
Mark Jansen [Mon, 16 May 2016 18:03:09 +0000 (18:03 +0000)]
[BROWSEUI_APITEST] Add tests for ACListISF, a class used for autocompletion. CORE-9281
- Add tests for ACListISF.
- Change the SHExplorerParseCmdLine test to use GetProcAddress instead of relying on the import (it's not there anymore in NT 6.0+)

svn path=/trunk/; revision=71345

6 years ago[PSDK] Add missing definitions for IACList2 Options. CORE-9281
Mark Jansen [Mon, 16 May 2016 17:59:10 +0000 (17:59 +0000)]
[PSDK] Add missing definitions for IACList2 Options. CORE-9281

svn path=/trunk/; revision=71344

6 years ago[SHELL32] - Implement a skeleton DlgProc for the folder options general dialog
Robert Naumann [Mon, 16 May 2016 11:58:31 +0000 (11:58 +0000)]
[SHELL32] - Implement a skeleton DlgProc for the folder options general dialog
- show icons depending on button states in folder options general dialog

svn path=/trunk/; revision=71343

6 years ago[BOOTDATA]
Daniel Reimer [Mon, 16 May 2016 11:11:22 +0000 (11:11 +0000)]
Fix autorun.inf on LiveCD and HybridCD linking to a non existent welcome.exe. HybridCD now links to the correct folder to welcome.exe and LiveCD just opens the readme.txt

svn path=/trunk/; revision=71342

6 years ago[REGSRV32] accept '-' as command line delimiter symbol as well
Christoph von Wittich [Mon, 16 May 2016 07:17:45 +0000 (07:17 +0000)]
[REGSRV32] accept '-' as command line delimiter symbol as well

svn path=/trunk/; revision=71340

6 years ago[NTOS][NDK][RTL]: Move the SEM_xxx flags and their corresponding RTL flags around...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:40:34 +0000 (22:40 +0000)]
[NTOS][NDK][RTL]: Move the SEM_xxx flags and their corresponding RTL flags around so that they can be accessed in kernel code. I'll need them soon.

svn path=/trunk/; revision=71339

6 years ago[NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCanc...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:32:17 +0000 (22:32 +0000)]
[NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCancelTryContinue" are valid!

svn path=/trunk/; revision=71338

6 years ago[USERSRV]: Code formatting.
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:29:23 +0000 (22:29 +0000)]
[USERSRV]: Code formatting.

svn path=/trunk/; revision=71337

6 years ago[NTOS]: Remove hardcoded constants; fix a comment; move some code around to reduce...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:23:14 +0000 (22:23 +0000)]
[NTOS]: Remove hardcoded constants; fix a comment; move some code around to reduce the level of code indentation.

svn path=/trunk/; revision=71336