Eric Kohl [Fri, 20 Sep 2019 07:24:49 +0000 (09:24 +0200)]
[IPCONFIG] Improve the 'Autoconfiguration Enabled' information
- Show 'Autoconfiguration Enabled' only if DHCP is enabled for the adapter.
- Retrieve and display the autoconfiguration state.
Joachim Henze [Thu, 19 Sep 2019 22:11:10 +0000 (00:11 +0200)]
[EXPLORER] Mitigate CORE-15760 'system menu may close unexpectedly'
Looks like a race condition of the async part of SetForegroundWindow().
KVM https://reactos.org/testman/compare.php?ids=69065,69069
VBOX https://reactos.org/testman/compare.php?ids=69064,69068
I intend to merge that back into 0.4.12RC as well.
Eric Kohl [Thu, 19 Sep 2019 21:24:43 +0000 (23:24 +0200)]
[FREELDR] Hack: Boot ReactOS even when a cdrom-drive does not report a proper geometry
We need to find a way to retrieve the LBA sector count of a drive, not only its CHS geometry.
Carlo Bramini [Thu, 19 Sep 2019 19:58:00 +0000 (21:58 +0200)]
[NETPLWIZ] Add Italian translation. (#1912)
Eric Kohl [Thu, 19 Sep 2019 13:36:18 +0000 (15:36 +0200)]
[CABMAN] Third addendum to
7afc888: Also use the the old code in the Trucate() method on Linux
Eric Kohl [Thu, 19 Sep 2019 13:25:23 +0000 (15:25 +0200)]
[CABMAN] Second addendum to
7afc888: Use the old code to make Linux happy.
Sorry for the noise, but I do not have a Linux machine to test the build. :-/
Eric Kohl [Thu, 19 Sep 2019 13:07:57 +0000 (15:07 +0200)]
[CABMAN] Addendum to
7afc8882: Use PATH_MAX instead of MAX_PATH
Eric Kohl [Thu, 19 Sep 2019 12:56:50 +0000 (14:56 +0200)]
[CABMAN] Do not use tmpfile() because it does not work well on Windows XP
- Use tempnam() and fopen() instead.
- Prevent the use of file names with a leading slash or backslash.
- Also prevent the use of file names with a trailing dot.
- Remove temporary files after use.
Hermès Bélusca-Maïto [Thu, 19 Sep 2019 00:47:29 +0000 (02:47 +0200)]
[FREELDR] Rename the PE loader functions 'PeLdr*' instead of 'WinLdr*'.
Hermès Bélusca-Maïto [Thu, 19 Sep 2019 00:38:34 +0000 (02:38 +0200)]
[SDK:NT] Remove Win32-isms.
Hermès Bélusca-Maïto [Wed, 18 Sep 2019 00:42:56 +0000 (02:42 +0200)]
[FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 23:06:15 +0000 (01:06 +0200)]
[FREELDR] Addendum / actual fix for
ef76709b
According to the Advanced RISC Computing Specification v1.2, for partitions,
StartingAddress and EndingAddress are the start and end positions of the
partition in terms of byte offsets from the start of the disk.
CurrentAddress is the current offset into (i.e. relative to) the partition.
Fix also the FAT filesystem in accordance.
- FIXME fix: Retrieve the size of the disk in number of sectors in DiskOpen().
- Add extra validity checks in the DiskSeek() functions.
- Explicitly call PcDisk* functions in machpc.c and pcdisk.c, and
XboxDisk* functions in machxbox.c (the code in these files is not
called cross-platform).
CORE-16216 CORE-16248
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 21:04:39 +0000 (23:04 +0200)]
[FREELDR] Other enhancements.
- Modify DiskReportError() to use an internal "display counter", so that
imbricated DiskReportError(FALSE) ... DiskReportError(TRUE) can behave
as expected.
- Merge LoadAndBootDrive(), LoadAndBootPartition(),
LoadAndBootBootSector() into one LoadAndBootDevice() function + its
helpers (in progress...).
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 20:24:47 +0000 (22:24 +0200)]
[FREELDR] Minor code improvements + 1 bug-fix.
- "FrldrBootPath" -> "FrLdrBootPath";
- Get rid of GetFreeLoaderVersionString() and use FrLdrVersionString
directly instead;
- Rephrase some comments;
- Use RTL_NUMBER_OF();
- Reduce indent level in LoadOperatingSystem() and EditOperatingSystemEntry().
Bug fix:
- Fix DissectArcPath() for "ramdisk(0)" case.
Pierre Schweitzer [Tue, 17 Sep 2019 21:06:34 +0000 (23:06 +0200)]
[BROWSEUI] Translate search function into French
CORE-9279
Eric Kohl [Tue, 17 Sep 2019 10:58:11 +0000 (12:58 +0200)]
[LSA][SECUR32] Check for untrusted clients
Calls to LsapCallAuthenticationPackage are routed to LsaApCallPackageUntrusted instead of LsaApCallPackage for untrusted clients.
Eric Kohl [Tue, 17 Sep 2019 10:46:49 +0000 (12:46 +0200)]
[MSV1_0] Implement LsaApCallPackageUntrusted()
An untrusted client is only allowed to change passwords
Eric Kohl [Mon, 16 Sep 2019 06:51:08 +0000 (08:51 +0200)]
[SYSDM] Store the profile path in the PROFILEDATA struct for deleting and copying the profiles
Brock Mammen [Thu, 12 Sep 2019 13:53:24 +0000 (08:53 -0500)]
[SHELLFIND] Use IS_INTRESOURCE()
Brock Mammen [Thu, 12 Sep 2019 13:52:26 +0000 (08:52 -0500)]
[COM_APITEST] Remove duplicate interface
Brock Mammen [Sat, 31 Aug 2019 00:54:50 +0000 (19:54 -0500)]
[SHELLFIND] Add missing dependency to CMakeLists.txt
Brock Mammen [Fri, 30 Aug 2019 23:10:33 +0000 (18:10 -0500)]
[COM_APITEST] Add CFindFolder test
Brock Mammen [Sun, 25 Aug 2019 22:58:59 +0000 (17:58 -0500)]
[BROWSEUI] Add search strings to all language resources
Brock Mammen [Sun, 25 Aug 2019 22:54:59 +0000 (17:54 -0500)]
[BROWSEUI] Add search dialog to all language resources
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Fix return values
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Remove unused COM interfaces
Brock Mammen [Tue, 27 Aug 2019 13:17:11 +0000 (08:17 -0500)]
[SHELLFIND] Remove unused functions
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Change parameter from array reference to pointer
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Remove unnecessary cast
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Remove redundant check
Brock Mammen [Tue, 27 Aug 2019 13:17:12 +0000 (08:17 -0500)]
[SHELLFIND] Fix unsafe cast
Brock Mammen [Tue, 27 Aug 2019 13:17:11 +0000 (08:17 -0500)]
[SHELLFIND] Use CoTaskMemAlloc instead of SHAlloc
Brock Mammen [Tue, 27 Aug 2019 13:17:11 +0000 (08:17 -0500)]
[SHELLFIND] Fix IImageList leak
Brock Mammen [Tue, 27 Aug 2019 12:46:07 +0000 (07:46 -0500)]
[SHELLFIND] Simplify PIDLs to paths
Brock Mammen [Sun, 25 Aug 2019 22:05:17 +0000 (17:05 -0500)]
[SHELLFIND] Remove search results folder from address edit box
Brock Mammen [Sun, 25 Aug 2019 22:03:44 +0000 (17:03 -0500)]
[SHELLFIND] Subscribe to folders that are already opened
Brock Mammen [Sun, 25 Aug 2019 20:44:42 +0000 (15:44 -0500)]
[SHELLFIND] Open search bar when search results folder is opened
Brock Mammen [Sat, 24 Aug 2019 16:02:18 +0000 (11:02 -0500)]
[SHELLFIND] Remove dependency on internal shell32 functions
Brock Mammen [Sat, 24 Aug 2019 17:32:45 +0000 (12:32 -0500)]
[SHELLFIND] Localize column names
Brock Mammen [Sat, 24 Aug 2019 14:40:43 +0000 (09:40 -0500)]
[SHELLFIND] Rename data members
Brock Mammen [Fri, 23 Aug 2019 22:24:41 +0000 (17:24 -0500)]
[SHELLFIND] Fix handle leak for stop event
Brock Mammen [Fri, 23 Aug 2019 21:36:56 +0000 (16:36 -0500)]
[SHELLFIND] Use DeferWindowPos for resizing child windows
Brock Mammen [Fri, 23 Aug 2019 21:13:23 +0000 (16:13 -0500)]
[SHELLFIND] Use assignment instead of memcpy
Brock Mammen [Fri, 23 Aug 2019 20:51:43 +0000 (15:51 -0500)]
[SHELLFIND] Fix copyright headers
Brock Mammen [Fri, 23 Aug 2019 20:35:37 +0000 (15:35 -0500)]
[SHELLFIND] Remove unused function
Brock Mammen [Fri, 23 Aug 2019 20:33:34 +0000 (15:33 -0500)]
[SHELLFIND] Remove unnecessary data member for focus
Brock Mammen [Wed, 21 Aug 2019 02:51:37 +0000 (21:51 -0500)]
[SHELLFIND] Use case-insensitive string comparison
Brock Mammen [Wed, 21 Aug 2019 02:17:01 +0000 (21:17 -0500)]
[SHELLFIND] Improve search bar UI
Brock Mammen [Tue, 20 Aug 2019 21:34:30 +0000 (16:34 -0500)]
[SHELLFIND] Update status bar text
Brock Mammen [Tue, 20 Aug 2019 21:26:38 +0000 (16:26 -0500)]
[SHELLFIND] Remove duplicate search code
Brock Mammen [Tue, 20 Aug 2019 21:14:12 +0000 (16:14 -0500)]
[SHELLFIND] Add stop search command
Brock Mammen [Sun, 18 Aug 2019 02:41:59 +0000 (21:41 -0500)]
[SHELLFIND] Add search command events
Brock Mammen [Sat, 3 Aug 2019 17:07:59 +0000 (12:07 -0500)]
[SHELLFIND] Add search functionality
Brock Mammen [Sat, 3 Aug 2019 17:04:50 +0000 (12:04 -0500)]
[SHELLFIND] Move window message constants to header file
Brock Mammen [Sat, 3 Aug 2019 16:58:49 +0000 (11:58 -0500)]
[SHELLFIND] Use smart pointers for PIDLs
Brock Mammen [Sat, 3 Aug 2019 16:54:22 +0000 (11:54 -0500)]
[SHELLFIND] Add edit box for search location
Brock Mammen [Sat, 20 Jul 2019 18:05:03 +0000 (13:05 -0500)]
[SHELLFIND] Set status bar text after opening search results folder
Brock Mammen [Sat, 20 Jul 2019 15:11:54 +0000 (10:11 -0500)]
[SHELLFIND] Message handler for updating status bar text
Brock Mammen [Sat, 20 Jul 2019 01:18:47 +0000 (20:18 -0500)]
[SHELLFIND] Add "Open Containing Folder" to right-click menu
Brock Mammen [Fri, 19 Jul 2019 22:08:38 +0000 (17:08 -0500)]
[SHELLFIND] Add search bar click handler for testing search results
Brock Mammen [Fri, 19 Jul 2019 22:06:16 +0000 (17:06 -0500)]
[SHELLFIND] Message handler for adding search results
Brock Mammen [Sat, 20 Jul 2019 00:27:31 +0000 (19:27 -0500)]
[SHELLFIND] Create PIDLs and add search results to folder
Brock Mammen [Sat, 20 Jul 2019 00:15:38 +0000 (19:15 -0500)]
[SHELLFIND] Set default folder view mode to details
Brock Mammen [Sat, 20 Jul 2019 00:02:06 +0000 (19:02 -0500)]
[SHELLFIND] Add default columns from CFSFolder
Brock Mammen [Fri, 19 Jul 2019 20:23:20 +0000 (15:23 -0500)]
[SHELLFIND] Add CFindFolder
Brock Mammen [Fri, 19 Jul 2019 02:28:11 +0000 (21:28 -0500)]
[SHELLFIND] Open search results folder with search button
Brock Mammen [Fri, 19 Jul 2019 02:15:01 +0000 (21:15 -0500)]
[SHELLFIND] Add CSearchBar
Brock Mammen [Fri, 5 Jul 2019 21:40:51 +0000 (16:40 -0500)]
[SHELL32] Implement CDefView::AddObject()
Brock Mammen [Wed, 21 Aug 2019 20:32:20 +0000 (15:32 -0500)]
[SHELL32] Make SHFindFiles open the search results folder
Brock Mammen [Mon, 15 Jul 2019 02:45:27 +0000 (21:45 -0500)]
[EXPLORER] Open search from start menu
Timo Kreuzer [Sun, 8 Sep 2019 09:34:00 +0000 (11:34 +0200)]
[KERNEL32_APITEST] Fix a test that fails on Server 2003 and Windows 10
Timo Kreuzer [Sun, 18 Aug 2019 13:32:22 +0000 (15:32 +0200)]
[SPEC2DEF] Refactor to avoid parsing multiple times
Timo Kreuzer [Thu, 29 Aug 2019 16:16:06 +0000 (18:16 +0200)]
[SPEC2DEF] Fix decorated exports on non-x86
Timo Kreuzer [Thu, 29 Aug 2019 16:15:14 +0000 (18:15 +0200)]
[SPEC2DEF] Handle auto-naming of "@()" functions during output
This allows to do the parsing and output separately, since the generated name is no longer stored on the stack during parsing.
Pierre Schweitzer [Sun, 15 Sep 2019 10:28:50 +0000 (12:28 +0200)]
[MOUNTMGR_APITEST] Add an extra test for query failure
Timo Kreuzer [Sun, 18 Aug 2019 11:00:42 +0000 (13:00 +0200)]
[SPEC2DEF] Use const properly
Timo Kreuzer [Sat, 17 Aug 2019 18:32:15 +0000 (20:32 +0200)]
[SPEC2DEF] Improve error output
Eric Kohl [Sat, 14 Sep 2019 10:21:56 +0000 (12:21 +0200)]
[SYSDM] Allow deleting and copying of user profiles only for profiles that are currently not in use
Pierre Schweitzer [Sat, 14 Sep 2019 08:48:19 +0000 (10:48 +0200)]
[FLOPPY] Implement IOCTL_MOUNTDEV_QUERY_DEVICE_NAME
Pierre Schweitzer [Sat, 14 Sep 2019 07:41:47 +0000 (09:41 +0200)]
[MOUNTMGR] Properly enumerate pending IRPs on cleanup
CORE-16370
Pierre Schweitzer [Fri, 13 Sep 2019 18:04:53 +0000 (20:04 +0200)]
[MOUNTMGR] Fix MountState usage in MountMgrTargetDeviceNotification
CORE-13882
Pierre Schweitzer [Fri, 13 Sep 2019 17:55:53 +0000 (19:55 +0200)]
[MOUNTMGR] Fix broken check
Only mark volume mounted if it's not waiting for unloading
CORE-13882
Pierre Schweitzer [Fri, 13 Sep 2019 17:55:06 +0000 (19:55 +0200)]
[SDK] Define DO_UNLOAD_PENDING
Based on: http://www.perisoft.net/engineer/wdmcard.htm
CORE-13882
Timo Kreuzer [Fri, 13 Sep 2019 15:25:20 +0000 (17:25 +0200)]
[GDI32_APITEST] Fix AddFontResource test (#1901)
This commit uses GetCurrentDirectoryA rather than GetWindowsDirectoryA for convenience.
Hermès Bélusca-Maïto [Fri, 13 Sep 2019 12:35:16 +0000 (14:35 +0200)]
[FREELDR] Minor code style - use RtlZeroMemory(); shorter member name; use different debug channel.
Hermès Bélusca-Maïto [Fri, 13 Sep 2019 12:02:44 +0000 (14:02 +0200)]
[FREELDR] Limit the usage of DiskStopFloppyMotor() in hardware/platform-specific code.
- Move DiskStopFloppyMotor() calls into the implementations of
Boot(New)LinuxKernel() and Reboot() HW functions, and the explanation
comments in ChainLoadBiosBootSectorCode().
- Remove unneeded DiskStopFloppyMotor() dummies in ARM and PPC code.
- Use more adequate bitmask value to be sent to floppy's Digital Output
Register for shutting down its motor (based on OSDev & our floppy
controller driver).
Hermès Bélusca-Maïto [Fri, 13 Sep 2019 00:14:22 +0000 (02:14 +0200)]
[FREELDR] Other enhancements.
- Add optional arguments BootDrive and BootPartition to
ChainLoadBiosBootSectorCode() so as not to modify explicitly the
FrldrBootDrive and FrldrBootPartition variables, that should remain
purely internal.
- Implement ChainLoadBiosBootSectorCode() for x64.
- Get rid of the machine-specific DiskGetBootPath(), and instead do its
job only once in the machine-specific InitializeBootDevices() (or in
MachInit() for PPC).
Cache the result of this operation into the globally-accessible
FrldrBootPath buffer. This avoids the unneeded calls to (Mach)DiskGetBootPath()
we used to do before.
Also remove the separate distinction between the PC and XBOX versions
of this functionality.
- Move the PC-specific DiskIsDriveRemovable() and DiskGetBootPath()
as well as the disk-IO-error functionality, back into the
corresponding PC-arch files.
- Simplify IniFileInitialize(), getting rid of IniOpenIniFile().
Stanislav Motylkov [Thu, 12 Sep 2019 13:53:29 +0000 (16:53 +0300)]
[WIN32SS][NTUSER] Fix debug print in winpos.c (#1893)
Eric Kohl [Thu, 12 Sep 2019 08:23:33 +0000 (10:23 +0200)]
[SYSDM] Show the profile type (local or roaming) in the type column, show the other profile states in the status column
Eric Kohl [Wed, 11 Sep 2019 13:12:26 +0000 (15:12 +0200)]
[SYSDM] Improvements to the user profile size format
Eric Kohl [Wed, 11 Sep 2019 08:14:02 +0000 (10:14 +0200)]
[SYSDM] Calculate and display the size of the user profiles
Eric Kohl [Tue, 10 Sep 2019 13:38:29 +0000 (15:38 +0200)]
[SYSDM] Remove unused variables
Thanks a lot Katayama Hirofumi for the hint!
Eric Kohl [Tue, 10 Sep 2019 11:39:20 +0000 (13:39 +0200)]
[SYSDM] Check the profile directory and hive file and display the last write date of the hive file.
Katayama Hirofumi MZ [Tue, 10 Sep 2019 11:39:52 +0000 (20:39 +0900)]
[WIN32SS][FONT] Fix registry-based management (#1879)
CORE-16269
- Fix and improve registry-based font entry management.
- Append style name to registry value name.
- Make some DPRINT DPRINT1 (noisy).
Timo Kreuzer [Wed, 28 Aug 2019 14:34:33 +0000 (16:34 +0200)]
[DLLEXPORT_TEST] Fix duplicated export on non-x86 architectures
Timo Kreuzer [Sun, 25 Aug 2019 09:44:43 +0000 (11:44 +0200)]
[IPHLPAPI] Simplify spec file
Also move the exports where they are on Windows. This was already handled correctly by MSVC and still doesn't fix the order on GCC builds, but that is a different story and shall be addressed at a different time.
Timo Kreuzer [Thu, 29 Aug 2019 15:59:26 +0000 (17:59 +0200)]
[IPHLPAPI] Improve function stubs
Timo Kreuzer [Thu, 29 Aug 2019 15:57:01 +0000 (17:57 +0200)]
[PSDK] Add fltdefs.h
Carlo Bramini [Sun, 8 Sep 2019 12:04:41 +0000 (14:04 +0200)]
Fix italian translation: "Cancella" -> "Annulla" (#1902)
Timo Kreuzer [Sat, 27 Jul 2019 07:56:37 +0000 (09:56 +0200)]
[SETUP] Add support for archtitcure specific inf sections and use it for x64 computer type