reactos.git
7 weeks ago[SETUPLIB][INPUT.CPL] Move zh-MO to ChineseTraditionalFonts group (#4010)
Chan Chilung [Mon, 11 Oct 2021 13:24:21 +0000 (21:24 +0800)]
[SETUPLIB][INPUT.CPL] Move zh-MO to ChineseTraditionalFonts group (#4010)

- The use of Traditional Chinese character is far more than Simplified one according to Wikipedia
- The code page used on zh-MO is 950, which is Traditional Chinese's one
- zh-MO is described as Traditional Chinese here: https://support.microsoft.com/en-us/windows/microsoft-traditional-chinese-ime-ef596ca5-aff7-4272-b34b-0ac7c2631a38#ID0EBBD=Microsoft_ChangJie/Quick

7 weeks ago[CMAKE] msvc.cmake: Add arm64 CMAKE_ASM_MASM_COMPILER option support
Serge Gautherie [Mon, 24 May 2021 06:56:17 +0000 (08:56 +0200)]
[CMAKE] msvc.cmake: Add arm64 CMAKE_ASM_MASM_COMPILER option support

CORE-17518

7 weeks ago[CMAKE] CMakeLists.txt: Add arm64 to ARCH allowed values
Serge Gautherie [Mon, 24 May 2021 06:56:17 +0000 (08:56 +0200)]
[CMAKE] CMakeLists.txt: Add arm64 to ARCH allowed values

CORE-17518

7 weeks ago[SHELL32] Don't smartass-renaming on LNK files (#4020)
Katayama Hirofumi MZ [Mon, 11 Oct 2021 04:33:43 +0000 (13:33 +0900)]
[SHELL32] Don't smartass-renaming on LNK files (#4020)

Renaming .LNK files had a bug that the selection won't include the extension-like filename part.
CORE-17807

7 weeks ago[SDK] config.cmake: Fix generic mtune flag (#4017)
Konrad Dybcio [Mon, 11 Oct 2021 00:46:12 +0000 (02:46 +0200)]
[SDK] config.cmake: Fix generic mtune flag (#4017)

7 weeks ago[IERNONCE] Add German translation
Robert Naumann [Sun, 3 Oct 2021 19:27:56 +0000 (21:27 +0200)]
[IERNONCE] Add German translation

7 weeks ago[INETCPL] Update German translation
Robert Naumann [Sun, 3 Oct 2021 20:08:52 +0000 (22:08 +0200)]
[INETCPL] Update German translation

7 weeks ago[NOTEPAD] Properly fix accelerator issue in es-ES.rc CORE-17809
Joachim Henze [Sun, 10 Oct 2021 19:23:47 +0000 (21:23 +0200)]
[NOTEPAD] Properly fix accelerator issue in es-ES.rc CORE-17809

In 0.4.14-dev-1321-g d6e0fe78e741fa8af9ec80b7ef70853fda14b8d6
we introduced the following compiler warning for MSVC2010 release build:

reactos/base/applications/notepad/lang/es-ES.rc(12) : warning RC4204 : ASCII character not equivalent to virtual key code

That warning was muted without investing too much love by
0.4.15-dev-2469-g d0bb7757747cb6d2c500e687df78eb8afea8edc8

Today we apply the proper fix that brings us back in sync with other languages.
I do intend to port the proper fix back to 0.4.14RC as well.

7 weeks ago[SHELL32] Add missing SS_NOPREFIX to labels in About dialog (#3969)
William Kent [Sun, 10 Oct 2021 18:50:18 +0000 (14:50 -0400)]
[SHELL32] Add missing SS_NOPREFIX to labels in About dialog (#3969)

Signed-off-by: William Kent <wjk011@gmail.com>
7 weeks ago[MODEMUI] Fix unrecognized escape sequence. Addendum to 05c39d8d.
Stanislav Motylkov [Sun, 10 Oct 2021 14:08:01 +0000 (17:08 +0300)]
[MODEMUI] Fix unrecognized escape sequence. Addendum to 05c39d8d.

7 weeks ago[TRANSLATION] Update Turkish (tr-TR) translations (#3958) 3958/head
Süleyman Poyraz [Sat, 9 Oct 2021 20:40:55 +0000 (23:40 +0300)]
[TRANSLATION] Update Turkish (tr-TR) translations (#3958)

Reviewed-by: Can Taşan <ctasan99@hotmail.com>
Signed-off-by: Süleyman Poyraz <zaryob.dev@gmail.com>
7 weeks ago[TRANSLATION] Chinese Traditional (zh-TW) translation update (#3954)
Chan Chilung [Sun, 10 Oct 2021 12:00:44 +0000 (20:00 +0800)]
[TRANSLATION] Chinese Traditional (zh-TW) translation update (#3954)

Also sync LOCALMON/UI translation with Wine.

7 weeks ago[RICHED20_WINETEST] Fix build about __thiscall redefinition
Katayama Hirofumi MZ [Sun, 10 Oct 2021 04:57:32 +0000 (13:57 +0900)]
[RICHED20_WINETEST] Fix build about __thiscall redefinition

See https://github.com/reactos/reactos/commit/5a9535e694b6baaa4b028523263a39357d6d589b

7 weeks ago[RICHED20_WINETEST] Restore Wine sync in txtsrv.c. ROSTESTS-355
Thomas Faber [Sun, 10 Oct 2021 00:18:43 +0000 (20:18 -0400)]
[RICHED20_WINETEST] Restore Wine sync in txtsrv.c. ROSTESTS-355

In particular, add the missed diff in ITextHostImpl_TxGetCharFormat.

8 weeks ago[BOOTDATA] readme.txt: Trivial correction (#4014)
Chan Chilung [Sat, 9 Oct 2021 12:44:09 +0000 (20:44 +0800)]
[BOOTDATA] readme.txt: Trivial correction (#4014)

Follow up of #3469 - replace "Seven" with "7" to keep Microsoft's official naming.

8 weeks ago[ZIPFLDR] Update de-DE.rc
Joachim Henze [Sat, 9 Oct 2021 12:40:48 +0000 (14:40 +0200)]
[ZIPFLDR] Update de-DE.rc

8 weeks ago[IMM32] Rewrite ImmRequestMessageA/W (#4002)
Katayama Hirofumi MZ [Fri, 8 Oct 2021 22:40:56 +0000 (07:40 +0900)]
[IMM32] Rewrite ImmRequestMessageA/W (#4002)

- Re-implement ImmRequestMessageA and ImmRequestMessageW functions.
- Add IchWideFromAnsi, IchAnsiFromWide, Imm32RequestError, Imm32ReconvertSize, Imm32ConvertReconvert, and Imm32ProcessRequest helper functions.
CORE-11700

8 weeks ago[ZIPFLDR] Update Polish (pl-PL) translation (#4007)
Adam Stachowicz [Fri, 8 Oct 2021 17:00:30 +0000 (17:00 +0000)]
[ZIPFLDR] Update Polish (pl-PL) translation (#4007)

8 weeks agoRevert "[DSOUND] Don't force status to failure by default in primarybuffer_SetFormat...
Oleg Dubinskiy [Mon, 27 Sep 2021 12:02:52 +0000 (15:02 +0300)]
Revert "[DSOUND] Don't force status to failure by default in primarybuffer_SetFormat (#3911)"

Revert my last dsound fix, because it does not fix the actual problem with audio formats support. It only makes the situation worse. It prevents the error when creating an audio stream, but the sound is not playing correctly, both in ReactOS and Windows (with our dsound.dll). Without this fix, it works perfectly on Windows, but does not in ROS.
In particular, the sound is not playing properly in AIMP 4.71 with other audio formats besides default (44100 Hz, 16 bit, stereo). And any other apps which request these audio formats may be also affected as well.
Force the status back to failure, because otherwise the badly required code is not executed at all.
I've made a more correct fix(es) in other audio component(s) instead and will submit them if further PRs.

This reverts commit 183566ee584efbe6377c79e68bfe24b2d1f940ae.

CORE-10907

8 weeks ago[TSCLIENT] Fix code F12 array index (#4006) 4006/head
Rafał Mikrut [Thu, 7 Oct 2021 18:12:53 +0000 (20:12 +0200)]
[TSCLIENT] Fix code F12 array index (#4006)

8 weeks ago[NTOS:KE] Fix copy paste bug in exception helper routine for ARM (#4005) 4005/head
Rafał Mikrut [Thu, 7 Oct 2021 17:45:21 +0000 (19:45 +0200)]
[NTOS:KE] Fix copy paste bug in exception helper routine for ARM (#4005)

8 weeks ago[ZIPFLDR] Show error when compression method is not supported 4001/head
Stanislav Motylkov [Tue, 5 Oct 2021 22:04:50 +0000 (01:04 +0300)]
[ZIPFLDR] Show error when compression method is not supported

CORE-17255

8 weeks ago[SHELL32] Don't smartass-renaming on folders (#3993)
Katayama Hirofumi MZ [Wed, 6 Oct 2021 23:16:35 +0000 (08:16 +0900)]
[SHELL32] Don't smartass-renaming on folders (#3993)

Selection on renaming folders shouldn't select the extension-like part of filename.
CORE-17793

8 weeks ago[ZIPFLDR] Update de-DE.rc in context of CORE-17796
Joachim Henze [Wed, 6 Oct 2021 18:17:13 +0000 (20:17 +0200)]
[ZIPFLDR] Update de-DE.rc in context of CORE-17796

8 weeks ago[ZIPFLDR] Improve error reporting 4000/head
Stanislav Motylkov [Tue, 5 Oct 2021 23:48:03 +0000 (02:48 +0300)]
[ZIPFLDR] Improve error reporting

- Restore status text on failure
- Show errors on folder and file creation failures
- Allow to retry extraction attempt

CORE-17796

8 weeks ago[ZIPFLDR] Refactor extraction function
Stanislav Motylkov [Tue, 5 Oct 2021 18:54:39 +0000 (21:54 +0300)]
[ZIPFLDR] Refactor extraction function

Add separate function for a single file extraction.

CORE-17796

8 weeks ago[IMM32] Implement ImmSystemHandler (#3998)
Katayama Hirofumi MZ [Tue, 5 Oct 2021 12:31:53 +0000 (21:31 +0900)]
[IMM32] Implement ImmSystemHandler (#3998)

- Implement ImmSystemHandler function.
- Add Imm32UnknownProcess1 and Imm32SendChange helper functions.
CORE-11700

8 weeks ago[IMM32] Add IMP stub functions (#3989)
Katayama Hirofumi MZ [Tue, 5 Oct 2021 05:07:58 +0000 (14:07 +0900)]
[IMM32] Add IMP stub functions (#3989)

- Add IMP (Input Method Profiler) stub functions (ImmIMPGetIMEA/W, ImmIMPQueryIMEA/W, ImmIMPSetIMEA/W).
- Add ImmSendIMEMessageExA/W stub functions.
- Rename nt3.c as win3.c.
The prototypes can be obtained from: https://doxygen.reactos.org/dc/d20/winnls32_8h.html .
The Japanese article of IMP is available: http://www7a.biglobe.ne.jp/~tsuneoka/win32tech/7.html
CORE-11700

2 months ago[IMM32] s/4/sizeof(DWORD)/
Katayama Hirofumi MZ [Mon, 4 Oct 2021 22:57:14 +0000 (07:57 +0900)]
[IMM32] s/4/sizeof(DWORD)/

CORE-11700

2 months ago[RAPPS] Update German translation
Robert Naumann [Sun, 3 Oct 2021 20:55:15 +0000 (22:55 +0200)]
[RAPPS] Update German translation

2 months ago[IMM32_APITEST] Add ImmGetImeInfoEx testcase (#3988)
Katayama Hirofumi MZ [Sun, 3 Oct 2021 22:35:00 +0000 (07:35 +0900)]
[IMM32_APITEST] Add ImmGetImeInfoEx testcase (#3988)

CORE-11700

2 months ago[IMM32] Implement ImmActivateLayout (#3987)
Katayama Hirofumi MZ [Sun, 3 Oct 2021 22:33:15 +0000 (07:33 +0900)]
[IMM32] Implement ImmActivateLayout (#3987)

- Add IME_STATE and IME_SUBSTATE structures.
- Modify INPUTCONTEXTDX structure.
- Implement ImmActivateLayout function.
- Improve ImmDestroyContext function by using newly-defined Imm32FreeImeStates.
- Add Imm32FetchImeState, Imm32FetchImeSubState, Imm32LoadImeStateSentence, Imm32SaveImeStateSentence, and Imm32SelectLayout helper functions.
- Modify NtUserSetThreadLayoutHandles prototype.
CORE-11700

2 months ago[UNIATA] Better split of model name between Vendor and Product
Hervé Poussineau [Sun, 3 Oct 2021 17:13:19 +0000 (19:13 +0200)]
[UNIATA] Better split of model name between Vendor and Product

UNIATA is converting IDE identify data into SCSI identify data.
However, IDE model is described with a unique field of 20 chars,
while SCSI model is described with 2 fields of 16 + 8 chars.
When displaying SCSI model, a space is added between vendor and product
fields.

Try to split model into vendor and product on a space if possible.

CORE-17400

2 months ago[RAPPS] Speed up app loading by caching the INI sections 3985/head
Mark Jansen [Thu, 30 Sep 2021 18:19:21 +0000 (20:19 +0200)]
[RAPPS] Speed up app loading by caching the INI sections

2 months ago[RAPPS] Cleanup
Mark Jansen [Thu, 30 Sep 2021 18:19:05 +0000 (20:19 +0200)]
[RAPPS] Cleanup

2 months ago[SHELL32] Fix uninitialized variable usage.
Mark Jansen [Thu, 30 Sep 2021 18:44:05 +0000 (20:44 +0200)]
[SHELL32] Fix uninitialized variable usage.
This fixes log spam about NM_CUSTOMDRAW not being handled

2 months ago[IMM32] GetKeyboardLayout's parameter is a thread id
Katayama Hirofumi MZ [Thu, 30 Sep 2021 18:13:52 +0000 (03:13 +0900)]
[IMM32] GetKeyboardLayout's parameter is a thread id

s/dwLayout/dwThreadId/
CORE-11700

2 months ago[IMM32] Move ImmFreeLayout from ime.c to imm.c
Katayama Hirofumi MZ [Thu, 30 Sep 2021 18:10:26 +0000 (03:10 +0900)]
[IMM32] Move ImmFreeLayout from ime.c to imm.c

CORE-11700

2 months ago[IMM32] Rewrite ImmGetImeMenuItemsA/W (#3983)
Katayama Hirofumi MZ [Thu, 30 Sep 2021 18:04:00 +0000 (03:04 +0900)]
[IMM32] Rewrite ImmGetImeMenuItemsA/W (#3983)

- Rewrite ImmGetImeMenuItemsA and ImmGetImeMenuItemsW functions.
- Add Imm32GetImeMenuItemsAW, Imm32IsImcAnsi, Imm32ImeMenuAnsiToWide and Imm32ImeMenuWideToAnsi helper functions.
- Make IME module's ImeGetImeMenuItems function optional.
CORE-11700

2 months ago[IMM32] Rewrite ImmSetActiveContext (#3982)
Katayama Hirofumi MZ [Thu, 30 Sep 2021 18:02:56 +0000 (03:02 +0900)]
[IMM32] Rewrite ImmSetActiveContext (#3982)

- Re-implement ImmSetActiveContext function.
- Modify NtUserNotifyIMEStatus prototype.
- Improve ImmSetConversionStatus and ImmSetOpenStatus functions.
CORE-11700

2 months agoRevert "Disable some C++ code, which doesn't compile for me"
Hervé Poussineau [Wed, 29 Sep 2021 20:58:31 +0000 (22:58 +0200)]
Revert "Disable some C++ code, which doesn't compile for me"

This reverts commit d8b1ff9056d869d512da88b9c9cc9301535f5a06.

2 months agoDisable some C++ code, which doesn't compile for me
Hervé Poussineau [Wed, 3 Jun 2020 19:46:52 +0000 (21:46 +0200)]
Disable some C++ code, which doesn't compile for me

2 months ago[VIDEOPRT] Create and setup new registry key only for non-legacy drivers
Hervé Poussineau [Wed, 18 Aug 2021 17:27:33 +0000 (19:27 +0200)]
[VIDEOPRT] Create and setup new registry key only for non-legacy drivers

CORE-17734

2 months ago[IERNONCE] [RUNONCEEX] Add RunOnceEx functionality for ReactOS (#3926)
He Yang [Wed, 29 Sep 2021 09:30:32 +0000 (17:30 +0800)]
[IERNONCE] [RUNONCEEX] Add RunOnceEx functionality for ReactOS (#3926)

* [IERNONCE] Implement the registry management code.

* [EXPLORER] handle RunOnceEx by invoking RunOnceEx in iernonce.dll

* [IERNONCE] Display a dialog to show progress, and execute entries.

* [IERNONCE] Add `InitCallback` function

2 months ago[NtGDI] Fix brush attribute transfer.
James Tabor [Wed, 29 Sep 2021 00:08:45 +0000 (19:08 -0500)]
[NtGDI] Fix brush attribute transfer.

2 months ago[IMM32] Rewrite ImmAssociateContext (#3979)
Katayama Hirofumi MZ [Tue, 28 Sep 2021 13:03:25 +0000 (22:03 +0900)]
[IMM32] Rewrite ImmAssociateContext (#3979)

CORE-11700

2 months ago[IMM32] Implement ImmFreeLayout (#3978)
Katayama Hirofumi MZ [Tue, 28 Sep 2021 13:02:30 +0000 (22:02 +0900)]
[IMM32] Implement ImmFreeLayout (#3978)

- Implement ImmFreeLayout function.
- Add Imm32ReleaseIME helper function.
CORE-11700

2 months ago[ApiTests|GDI] Add test for attribute changes to Bitmaps.
James Tabor [Tue, 28 Sep 2021 04:52:00 +0000 (23:52 -0500)]
[ApiTests|GDI] Add test for attribute changes to Bitmaps.

Only opporpate place to add this test.

2 months ago[NtGDI] Set owner after changing object type.
James Tabor [Tue, 28 Sep 2021 04:49:35 +0000 (23:49 -0500)]
[NtGDI] Set owner after changing object type.

2 months ago[NtGDI] Fix leaking of bitmaps while testing INFO DC's.
James Tabor [Tue, 28 Sep 2021 04:11:33 +0000 (23:11 -0500)]
[NtGDI] Fix leaking of bitmaps while testing INFO DC's.

Soon to be commit test for metafiles.

ret = MaskBlt(hdc, 0, 0, 3, 4, dib_hdc, 0, 0, mask_bitmap, 0, 0, SRCCOPY);

2 months ago[GDI32] Fix IV msvc build.
James Tabor [Tue, 28 Sep 2021 00:08:43 +0000 (19:08 -0500)]
[GDI32] Fix IV msvc build.

2 months ago[GDI32] Fix III msvc build.
James Tabor [Mon, 27 Sep 2021 23:19:49 +0000 (18:19 -0500)]
[GDI32] Fix III msvc build.

2 months ago[GDI32] Fix build errors~~
Hermès Bélusca-Maïto [Mon, 27 Sep 2021 22:45:46 +0000 (00:45 +0200)]
[GDI32] Fix build errors~~

2 months ago[GDI32] Fix msvc build errors.
James Tabor [Mon, 27 Sep 2021 22:30:40 +0000 (17:30 -0500)]
[GDI32] Fix msvc build errors.

2 months ago[GDI32] Update Wine Metafile Code
James Tabor [Mon, 27 Sep 2021 21:18:20 +0000 (16:18 -0500)]
[GDI32] Update Wine Metafile Code

Sync/Port: Metafile code from wine.

Patches by Jacek Caban, Daniel Lehman, Zhiyi Zhang. Gabriel Ivancescu, Michael Stefaniuc, Francois Gouget, Nikolay Sivov Dmitry Timoshkov, Andrew EiKum, Piotr Caban and Alexandre Julliard.

This commit is dedicated to George Bisoc!

2 months ago[NTOS:SE] Define a name macro for the threshold value 3977/head
George Bișoc [Sun, 26 Sep 2021 09:42:00 +0000 (11:42 +0200)]
[NTOS:SE] Define a name macro for the threshold value

Instead of having this magic value as is, describe it within a macro for readability purposes.

2 months ago[NTOS:SE] Check the privilege count against the maximum threshold
George Bișoc [Sun, 26 Sep 2021 09:38:45 +0000 (11:38 +0200)]
[NTOS:SE] Check the privilege count against the maximum threshold

In SeCaptureLuidAndAttributesArray we must ensure that we don't go onto a potential integer overflow scenario by checking against the maximum limit threshold the kernel states. In addition, write an explicit name macro for the value.

2 months ago[IMM32] Trivial tiny improvements
Katayama Hirofumi MZ [Mon, 27 Sep 2021 00:37:14 +0000 (09:37 +0900)]
[IMM32] Trivial tiny improvements

CORE-11700

2 months ago[IMM32] Rewrite ImmLockIMC (#3975)
Katayama Hirofumi MZ [Mon, 27 Sep 2021 00:32:24 +0000 (09:32 +0900)]
[IMM32] Rewrite ImmLockIMC (#3975)

- Add Imm32InitContext and Imm32LockIMCEx helper functions.
- Re-implement ImmLockIMC function.
- Modify CLIENTIMC and INPUTCONTEXTDX structures.
CORE-11700

2 months ago[IMM32] Improve Imm32CleanupContext and ImmLockClientImc (#3974)
Katayama Hirofumi MZ [Mon, 27 Sep 2021 00:31:16 +0000 (09:31 +0900)]
[IMM32] Improve Imm32CleanupContext and ImmLockClientImc (#3974)

- Improve Imm32CleanupContext and ImmLockClientImc functions.
- Add ValidateHandleNoErr and Imm32CheckImcProcess helper functions.
CORE-11700

2 months ago[USER32] GetUserObjectSecurity/SetUserObjectSecurity: Just use UserSetLastNTError...
Hermès Bélusca-Maïto [Sun, 26 Sep 2021 16:58:28 +0000 (18:58 +0200)]
[USER32] GetUserObjectSecurity/SetUserObjectSecurity: Just use UserSetLastNTError() in failure path.

2 months ago[IMAGESOFT] Fix build. Addendum to commit 516c8829.
Hermès Bélusca-Maïto [Sun, 26 Sep 2021 01:50:13 +0000 (03:50 +0200)]
[IMAGESOFT] Fix build. Addendum to commit 516c8829.

2 months ago[NTOS:RAWFS] LE JOKE! - Commit 7716bddd (r24564) claimed to "actually create the...
Hermès Bélusca-Maïto [Thu, 23 Sep 2021 22:45:56 +0000 (00:45 +0200)]
[NTOS:RAWFS] LE JOKE! - Commit 7716bddd (r24564) claimed to "actually create the \\Device names so that user-mode can even talk to it", yet didn't bother to do that!

Certainly due to copy-pasta error from the original code.

A consequence of this oversight, was that the IoGetDeviceObjectPointer()
calls on these device names, in fltmgr!DriverEntry() couldn't work.
(See drivers/filters/fltmgr/Interface.c, line 1880 and below.)

2 months ago[NTOS:RAWFS] Delete the previously-created devices in case the IoCreateDevice() calls...
Hermès Bélusca-Maïto [Thu, 23 Sep 2021 22:41:32 +0000 (00:41 +0200)]
[NTOS:RAWFS] Delete the previously-created devices in case the IoCreateDevice() calls fail.

2 months ago[FS_REC] Fix load-lock acquisition.
Hermès Bélusca-Maïto [Fri, 24 Sep 2021 15:51:40 +0000 (17:51 +0200)]
[FS_REC] Fix load-lock acquisition.

2 months ago[FS_REC] Register a recognizer for FAT filesystem on CD-ROMs.
Hermès Bélusca-Maïto [Thu, 23 Sep 2021 19:21:53 +0000 (21:21 +0200)]
[FS_REC] Register a recognizer for FAT filesystem on CD-ROMs.

This handles the \FatCdrom device, supported by MS fastfat.

2 months ago[IMAGESOFT] Reorganize the bitmap resource IDs.
Hermès Bélusca-Maïto [Sun, 26 Sep 2021 00:43:00 +0000 (02:43 +0200)]
[IMAGESOFT] Reorganize the bitmap resource IDs.

- Moving the IDB_* with their corresponding TBICON_* defines.
- Reordering the BITMAP resources in the same order the defines are defined.
- Fixing values for IDS_READY and IDS_TOOLBAR_TEXT.

2 months ago[IMAGESOFT] Use ARRAYSIZE / un-hardcode some sizeof(TYPE) where applicable.
Hermès Bélusca-Maïto [Sun, 26 Sep 2021 00:38:37 +0000 (02:38 +0200)]
[IMAGESOFT] Use ARRAYSIZE / un-hardcode some sizeof(TYPE) where applicable.

2 months ago[IMAGESOFT] Commit db416e39 made toolbar imagelists creating failing because we overc...
Hermès Bélusca-Maïto [Sun, 26 Sep 2021 00:26:42 +0000 (02:26 +0200)]
[IMAGESOFT] Commit db416e39 made toolbar imagelists creating failing because we overcounted the number of toolbar button bitmaps.

Indeed the count was based on the number of elements in TBBUTTON arrays;
however for some of the toolbars, extra entries corresponding to
separators are present, and thus the resulting number of elements is
always larger than the number of actual buttons for which an image is
associated. Passing this (larger) count to the InitImageList() function
therefore made image insertion fail after a certain point.

Now we pass an exact number of *images* instead.

2 months ago[Win32SS|GDI] Implement seldom used API and update types for local DC's.
James Tabor [Sat, 25 Sep 2021 16:57:26 +0000 (11:57 -0500)]
[Win32SS|GDI] Implement seldom used API and update types for local DC's.

Two working in house application require these API. Known as FolCOL and Reach.

2 months ago[NTUSER] Fix UserSendKeyboardInput() KEYEVENTF_SCANCODE use case (CORE-17144) 2974/head
Arjav Garg [Sat, 4 Sep 2021 20:34:38 +0000 (02:04 +0530)]
[NTUSER] Fix UserSendKeyboardInput() KEYEVENTF_SCANCODE use case (CORE-17144)

2 months ago[NTOS:OB] Minor refactoring.
Hermès Bélusca-Maïto [Fri, 24 Sep 2021 20:39:35 +0000 (22:39 +0200)]
[NTOS:OB] Minor refactoring.

- NtQuerySymbolicLinkObject(): Use an intermediate variable for the object header.
- Simplify code in ObpLookupEntryDirectory() by calling ObpReleaseLookupContextObject() instead.
- Use TAG_OBJECT_TYPE instead of hardcoded tag values.

2 months ago[NTOS:OB] Clarify and fix the usage of the Obp*DirectoryLock*() and ObpReleaseLookupC...
Hermès Bélusca-Maïto [Fri, 24 Sep 2021 22:03:56 +0000 (00:03 +0200)]
[NTOS:OB] Clarify and fix the usage of the Obp*DirectoryLock*() and ObpReleaseLookupContextObject() functions.

- Disentangle the usage of ObpAcquireDirectoryLockExclusive() when it's
  used only for accessing a directory structure, or as part of a lookup
  operation.

  The Obp*DirectoryLock*() -- both shared and exclusive -- functions
  are only for locking an OB directory, for reading or writing its
  structure members.

  When performing lookup operations (insertions/deletions of entries
  within a directory), use a ObpAcquireLookupContextLock() function that
  exclusively locks the directory and saves extra lock state, that can
  be used by ObpReleaseLookupContextObject() for cleanup.

- Add documentation for these functions.

2 months ago[NTOS:OB] Acquire the lock before setting directory's session ID 3972/head
George Bișoc [Thu, 23 Sep 2021 16:11:02 +0000 (18:11 +0200)]
[NTOS:OB] Acquire the lock before setting directory's session ID

2 months ago[NTOS:SE] Do not set SE_DACL_PRESENT flag that early
George Bișoc [Fri, 24 Sep 2021 17:39:30 +0000 (19:39 +0200)]
[NTOS:SE] Do not set SE_DACL_PRESENT flag that early

The function might assign the flag yet it could possibly fail on creating a DACL and insert an "access allowed" right to the access entry within the DACL. In this case, make sure we actually succeeded on all the tasks and THEN assign the flag that the DACL is truly present.

Also, make sure that the Current buffer size variable gets its new size so that we avoid overidding the memory of the DACL if the security descriptor wants both a DACL and SACL and so that happens that the DACL memory gets overwritten by the SACL.

2 months ago[NTOS:SE] Set the SACL to the World security descriptor 3968/head
George Bișoc [Tue, 21 Sep 2021 17:52:10 +0000 (19:52 +0200)]
[NTOS:SE] Set the SACL to the World security descriptor

Implement the portion chunk of code that is responsible for setting the system access control list (SACL) to the World security descriptor, based from SeWorldSid (World security identifier).

2 months ago[IMM32] Use Imm32IsImmMode and Imm32IsCiceroMode macros (#3971)
Katayama Hirofumi MZ [Fri, 24 Sep 2021 13:06:29 +0000 (22:06 +0900)]
[IMM32] Use Imm32IsImmMode and Imm32IsCiceroMode macros (#3971)

- Define Imm32IsImmMode, Imm32IsCiceroMode and Imm32Is16BitMode macros in "precomp.h".
- Improve Imm32InquireIme and Imm32CleanupContext functions.
- Add IME_SYSINFO_WINLOGON and IME_SYSINFO_WOW16 macros (from DDK) in psdk/imm.h.
- Modify CtfImeInquireExW and CtfImeSelectEx prototype.
CORE-11700

2 months ago[REACTOS] Remove PowerPC Open Firmware-related code
Victor Perevertkin [Fri, 24 Sep 2021 01:13:08 +0000 (04:13 +0300)]
[REACTOS] Remove PowerPC Open Firmware-related code

Was forgotten during the overall PowerPC support removal.
Addendum to 6ef6fabfc5271b9fb89cd9bdc2038588d55b3ea4

2 months ago[IPHLPAPI] GetAdaptersInfo(): Update Wine registry key name (#3556)
Serge Gautherie [Fri, 24 Sep 2021 00:49:05 +0000 (02:49 +0200)]
[IPHLPAPI] GetAdaptersInfo(): Update Wine registry key name (#3556)

2 months ago[PSDK] wincodec.idl: Add GUIDs which exist on WDK 7.1 (#3628)
Serge Gautherie [Fri, 24 Sep 2021 00:24:05 +0000 (02:24 +0200)]
[PSDK] wincodec.idl: Add GUIDs which exist on WDK 7.1 (#3628)

2 months ago[NTDLL_APITEST] Implement NtAdjustGroupsToken API tests 3963/head
George Bișoc [Sat, 18 Sep 2021 15:18:04 +0000 (17:18 +0200)]
[NTDLL_APITEST] Implement NtAdjustGroupsToken API tests

2 months ago[NTOS:SE] Implement token groups adjusting
George Bișoc [Sat, 18 Sep 2021 15:14:27 +0000 (17:14 +0200)]
[NTOS:SE] Implement token groups adjusting

2 months ago[IMM32_APITEST] himc: Use ok rather than ok_int (#3970)
Katayama Hirofumi MZ [Wed, 22 Sep 2021 10:07:07 +0000 (19:07 +0900)]
[IMM32_APITEST] himc: Use ok rather than ok_int (#3970)

Use ok macro rather than ok_int macro. CORE-11700

2 months ago[FONTEXT] Restore folder icon 3945/head
Mark Jansen [Sun, 5 Sep 2021 19:19:10 +0000 (21:19 +0200)]
[FONTEXT] Restore folder icon

2 months ago[SHELL32] CFSFolder: Add fallback for failing shell extension
Mark Jansen [Sun, 5 Sep 2021 19:07:30 +0000 (21:07 +0200)]
[SHELL32] CFSFolder: Add fallback for failing shell extension

CORE-17673

2 months ago[RAPPS] Move the CConfigParser to a new file 3967/head
Mark Jansen [Tue, 21 Sep 2021 17:00:21 +0000 (19:00 +0200)]
[RAPPS] Move the CConfigParser to a new file

2 months ago[NTOS:SE] Privileges adjusting private routine must be paged
George Bișoc [Tue, 21 Sep 2021 15:40:53 +0000 (17:40 +0200)]
[NTOS:SE] Privileges adjusting private routine must be paged

SepAdjustPrivileges is a private helper call that must be paged, alongside with its syscall -- NtAdjustPrivilegesToken.

2 months ago[IMM32_APITEST] Add himc testcase (#3965)
Katayama Hirofumi MZ [Tue, 21 Sep 2021 03:26:43 +0000 (12:26 +0900)]
[IMM32_APITEST] Add himc testcase (#3965)

Add himc testcase. CORE-11700

2 months ago[IMM32] Define ImeDpi_IsUnicode macro and use it (#3964)
Katayama Hirofumi MZ [Tue, 21 Sep 2021 03:20:10 +0000 (12:20 +0900)]
[IMM32] Define ImeDpi_IsUnicode macro and use it (#3964)

- Define ImeDpi_IsUnicode macro in precomp.h.
- Use it.
CORE-11700

2 months ago[NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo...
Joachim Henze [Mon, 20 Sep 2021 01:05:05 +0000 (03:05 +0200)]
[NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo() CORE-17777

This is an addendum to
0.4.15-dev-3174-g dda9c3979e87223b66e61f0f936f46920221e509 CORE-17769 and
0.4.15-dev-3147-g 3bf7e3ac13c5c9df373827c102b763b5b9822204 CORE-17754 CORE-17755

We have not seen this happening in real-life yet, but some code-fragments within co_IntSetScrollInfo()
e.g. line 628 if (nBar == SB_CTL) do clearly indicate that nBar can be 2 (SB_CTL).
Some lines below we definitely must not access those 4 static arrays out of bounds then via nBar as access index!

Ftr with a bit of grepping I also found some calls like NtUserSetScrollInfo(Wnd, SB_CTL, &Info, FALSE);
e.g: in win32ss/user/user32/controls/scrollbar.c so I am pretty sure nBar == 2 can happen in practice within co_IntSetScrollInfo().

I question whether any of those reads/writes to those static arrays (or the comparisons) would make any sense on index 2,
so we should aim to eliminate them altogether in the future.

2 months ago[NTUSER] Scrollbar.c, improve co_IntSetScrollInfo() CORE-17769
Joachim Henze [Sun, 19 Sep 2021 20:35:37 +0000 (22:35 +0200)]
[NTUSER] Scrollbar.c, improve co_IntSetScrollInfo() CORE-17769

Fixes CORE-17769 'Rapps Listview manual resize may erroneously not draw the triangles sometimes'
This could happen for both: themed and unthemed.

CORE-17769 was a regression introduced by 0.4.14-dev-1134-g 00adb1a3f967ac7f5cd56b4c39df72a7b3814603

We don't really like the added state in form of the static variables,
but the patch works good from a pure testing-perspective.

Many Thanks to the patches author: Doug Lyons

2 months ago[LIBXML2] Update to version 2.9.12. CORE-17766
Thomas Faber [Sun, 12 Sep 2021 17:24:24 +0000 (13:24 -0400)]
[LIBXML2] Update to version 2.9.12. CORE-17766

2 months ago[WIN32SS] Disable by default the dumping function. Addendum to 69f90508.
Hermès Bélusca-Maïto [Sat, 18 Sep 2021 22:46:56 +0000 (00:46 +0200)]
[WIN32SS] Disable by default the dumping function. Addendum to 69f90508.

2 months ago[WIN32SS:NTUSER] Move the keyboard layout debugging code to a separate dump function.
Hermès Bélusca-Maïto [Sat, 18 Sep 2021 22:08:24 +0000 (00:08 +0200)]
[WIN32SS:NTUSER] Move the keyboard layout debugging code to a separate dump function.

And fix its obvious bugs, e.g. not checking for possible NULL pointers
for the optional keyboard layout sub-tables...

2 months ago[BOOTDATA] Fix "DllName" casing.
Hermès Bélusca-Maïto [Fri, 17 Sep 2021 16:59:16 +0000 (18:59 +0200)]
[BOOTDATA] Fix "DllName" casing.

2 months ago[BROWSEUI] CAutoComplete::OnAutoCompStart(): Wait on the thread only when there is...
Hermès Bélusca-Maïto [Fri, 17 Sep 2021 17:16:02 +0000 (19:16 +0200)]
[BROWSEUI] CAutoComplete::OnAutoCompStart(): Wait on the thread only when there is a handle.

Avoids spamming
(ntoskrnl\ob\obwait.c:441) Failed to reference the handle with status 0xc0000008

CAutoComplete::FinishCompletion(): Remove two useless 'if (m_pThread || !m_hThread)'
tests: No need to check these after each code instruction...

2 months ago[BROWSEUI] Fix early error handling, to be taken only when ParseNow() is run (and...
Hermès Bélusca-Maïto [Fri, 17 Sep 2021 16:58:07 +0000 (18:58 +0200)]
[BROWSEUI] Fix early error handling, to be taken only when ParseNow() is run (and fixes "Use of uninitialized variable hr" RTC error).
Addendum to commit d8e47d61.

2 months ago[BROWSEUI] Minor formatting.
Hermès Bélusca-Maïto [Fri, 17 Sep 2021 17:15:31 +0000 (19:15 +0200)]
[BROWSEUI] Minor formatting.

2 months ago[IMM32] Define Imm32HeapFree macro and use it (#3962)
Katayama Hirofumi MZ [Sat, 18 Sep 2021 16:52:05 +0000 (01:52 +0900)]
[IMM32] Define Imm32HeapFree macro and use it (#3962)

- Define Imm32HeapFree macro in precomp.h and use it.
- Omit some NULL checks (for HeapFree).
CORE-11700

2 months ago[IMM32] Rewrite ImmAssociateContextEx (#3961)
Katayama Hirofumi MZ [Thu, 16 Sep 2021 10:29:49 +0000 (19:29 +0900)]
[IMM32] Rewrite ImmAssociateContextEx (#3961)

- Rewrite ImmAssociateContextEx function.
- Modify NtUserAssociateInputContext prototype.
CORE-11700