Amine Khaldi [Mon, 25 Dec 2017 21:11:57 +0000 (22:11 +0100)]
[USRMGR] Rename some functions. #179
Amine Khaldi [Mon, 25 Dec 2017 20:12:00 +0000 (21:12 +0100)]
[DESK] Rename DATA structures and some functions. #179
Amine Khaldi [Mon, 25 Dec 2017 19:57:04 +0000 (20:57 +0100)]
[RAPPS] Remove conversion helper that is now obsolete. #179
Amine Khaldi [Mon, 25 Dec 2017 19:31:27 +0000 (20:31 +0100)]
[MSCONFIG_NEW] Add missing header guard. Rename Update_Btn_States() and iSortedColumn. #179
Amine Khaldi [Mon, 25 Dec 2017 19:25:38 +0000 (20:25 +0100)]
[FTP] lostpeer() is declared and defined with a void return type. #179
Amine Khaldi [Mon, 25 Dec 2017 19:13:50 +0000 (20:13 +0100)]
[NTOS] Deduplicate MiSynchronizeSystemPde(). #179
Amine Khaldi [Mon, 25 Dec 2017 13:36:16 +0000 (14:36 +0100)]
[USER32] Fix RealUserDrawCaption() return type. Rename {HFONT,UISTATE}_GWL_OFFSET and pfPaint. #179
Colin Finck [Mon, 25 Dec 2017 13:30:47 +0000 (14:30 +0100)]
[LOCALSPL] Fix parameter handling in LocalSetJob and add tests for the few ways we can easily test this function.
Yes, it checks the input handle and doesn't fail if an invalid level is given, because someone may still send a Command.
This also fixes CORE-12794. Thanks for reporting!
Amine Khaldi [Mon, 25 Dec 2017 13:17:53 +0000 (14:17 +0100)]
[UNIATA] Update to v0.46e5. CORE-14117
Mark Jansen [Sun, 24 Dec 2017 00:28:16 +0000 (01:28 +0100)]
[ATL] Add CString.AllocSysString
Mark Jansen [Sun, 24 Dec 2017 00:27:06 +0000 (01:27 +0100)]
[ATL] Add CComBSTR.Attach
Mark Jansen [Sun, 24 Dec 2017 00:26:29 +0000 (01:26 +0100)]
[ATL_APITEST] Add a test for CComBSTR.Attach/Detach
Mark Jansen [Sun, 24 Dec 2017 00:25:54 +0000 (01:25 +0100)]
[ATL_APITEST] Add a test for CString.AllocSysString
Amine Khaldi [Mon, 25 Dec 2017 12:49:50 +0000 (13:49 +0100)]
[NET] Fix a style issue I caused by
3c8a3a6
Amine Khaldi [Mon, 25 Dec 2017 12:33:33 +0000 (13:33 +0100)]
[SHELL32_APITEST] Rename TestShellFolder, test_data and Tests. #179
Amine Khaldi [Mon, 25 Dec 2017 12:22:03 +0000 (13:22 +0100)]
[SHELL32] Deduplicate MAX_PROPERTY_SHEET_PAGE and AddPropSheetPageCallback(). #179
Amine Khaldi [Sun, 24 Dec 2017 11:59:12 +0000 (12:59 +0100)]
[INCLUDE/CRT] Add some throw() annotations. #179 #210
Markus Gothe [Mon, 25 Dec 2017 02:39:34 +0000 (03:39 +0100)]
Improve swedish translations and add new translations to swedish.
Pierre Schweitzer [Mon, 25 Dec 2017 10:22:00 +0000 (11:22 +0100)]
[FASTFAT] Revert
bd1e7bf: our VPB swapout implementation in FastFAT is buggy and
leaves volumes in half-(dis)mounted state and thus they get remounted while not
completely dismounted.
This can lead to major breakage and data corruption.
This requires deeper fixes (let's just drop that driver!).
CORE-14124
CORE-14126
CORE-14133
Pierre Schweitzer [Mon, 25 Dec 2017 10:20:15 +0000 (11:20 +0100)]
[NTOSKRNL] Revert
4ef0887: experiments show that our FastFAT is not ready yet to live on its own.
So, bring back the infamous IopParseDevice() hack. Dismounting is to be fixed in FastFAT.
Even though it might not be the last remaining bug...
CORE-14124
CORE-14126
CORE-14133
Giannis Adamopoulos [Sun, 24 Dec 2017 22:12:45 +0000 (00:12 +0200)]
[USER32] Implement the index -1 for GetWindowLong which returns a pointer to WW
We don't have this struct but WND already contains the same fields in the right
order so we can just return the pointer to the first one.
The meaning of the -1 index was found here: http://www.geoffchappell.com/studies/windows/win32/user32/structs/wnd/index.htm
Giannis Adamopoulos [Sun, 24 Dec 2017 21:52:10 +0000 (23:52 +0200)]
[UXTHEME] EnableThemeDialogTexture: Update window theme only when ETDT_USETABTEXTURE is used
Pierre Schweitzer [Sun, 24 Dec 2017 20:54:09 +0000 (21:54 +0100)]
[DISK] Properly implement querying partition information for partition 0.
In spite of what was implemented in our NT DDK sample, this is a legit operation.
This may have been turned legit starting NT5 (reminder, our implementation is
NT4 based...). So, in this situation, just return the information about the whole
disk (and not a random size) and also, mark everything with default values.
See disk_new for an example of how it works in NT5+.
CORE-14124
Giannis Adamopoulos [Sun, 24 Dec 2017 17:22:42 +0000 (19:22 +0200)]
[NTDLL_APITEST] -Add a hacky Microsoft.Windows.GdiPlus.manifest.
This is needed because ntdlltest.manifest has a dependency
on gdiplus and won't load because we don't have it in winsxs.
Eventually this must be removed.
Giannis Adamopoulos [Tue, 3 Oct 2017 19:28:12 +0000 (22:28 +0300)]
[COMCTL32] Install comctl32 v6 and its manifest in first stage
Giannis Adamopoulos [Wed, 4 Oct 2017 08:10:59 +0000 (11:10 +0300)]
[NTDLL_APITEST] Add several tests for RtlDosApplyFileIsolationRedirection_Ustr
Giannis Adamopoulos [Tue, 3 Oct 2017 19:11:47 +0000 (22:11 +0300)]
[LDR] Overhaul sxs support in ldr
* Remove the hacky find_actctx_dll form ldr that was taken from wine. LdrpResolveDllName and LdrpCheckForLoadedDll should get a parameter that is already redirected.
* Use RtlDosApplyFileIsolationRedirection_Ustr in LdrpLoadImportModule and LdrpUpdateLoadCount3 to redirerect the input parameter.
Giannis Adamopoulos [Tue, 3 Oct 2017 18:57:44 +0000 (21:57 +0300)]
[NTDLL] Implement RtlDosApplyFileIsolationRedirection_Ustr based on existing wine's code for ldr. .local redirection is not implemented yet.
Giannis Adamopoulos [Tue, 3 Oct 2017 18:51:46 +0000 (21:51 +0300)]
[RTL] find_string_index: name parameter may not be null terminated
Hermès Bélusca-Maïto [Sun, 24 Dec 2017 15:54:48 +0000 (16:54 +0100)]
Revert
57c0678 (PR #194) that has been erroneously committed too early.
Hermès Bélusca-Maïto [Sun, 24 Dec 2017 15:48:13 +0000 (16:48 +0100)]
[SDK] Fix copy-pasta, addendum to
7861960 by Mark Jansen.
Stanislav Motylkov [Thu, 14 Dec 2017 12:49:15 +0000 (15:49 +0300)]
[NTOS:INBV] Implement rotation bar for boot screen
Mark Jansen [Sat, 23 Dec 2017 21:39:26 +0000 (22:39 +0100)]
[SDK] Guard manifest_[dll|exe].rc against wrong usage.
Mark Jansen [Sat, 23 Dec 2017 21:38:42 +0000 (22:38 +0100)]
[DLL] Fix wrong manifest includes.
Amine Khaldi [Sat, 23 Dec 2017 23:15:58 +0000 (00:15 +0100)]
[NET] CompareInfo => CompareUserInfo. #179
Amine Khaldi [Sat, 23 Dec 2017 23:04:15 +0000 (00:04 +0100)]
[NTVDM] Move the def file out of the source files list. Rename some variables and functions. #179
Amine Khaldi [Sat, 23 Dec 2017 22:59:39 +0000 (23:59 +0100)]
[NTVDM] Missed this file.
Amine Khaldi [Sat, 23 Dec 2017 22:56:04 +0000 (23:56 +0100)]
[NTVDM] Deduplicate IsConsoleHandle() using the correct version pointed by Hermès. #179
Amine Khaldi [Sat, 23 Dec 2017 22:42:40 +0000 (23:42 +0100)]
[USER32] Add wine/debug.h to the PCH and remove an unneeded wine/unicode.h inclusion.
Amine Khaldi [Sat, 23 Dec 2017 13:15:02 +0000 (14:15 +0100)]
[REGEDIT] Rename NUM_ICONS and _CmdWndProc(). #179
Amine Khaldi [Sat, 23 Dec 2017 13:07:33 +0000 (14:07 +0100)]
[INTL] Rename some variables and functions. #179
Amine Khaldi [Sat, 23 Dec 2017 13:05:07 +0000 (14:05 +0100)]
[SYSDM] Rename some functions. #179
Amine Khaldi [Sat, 23 Dec 2017 13:00:08 +0000 (14:00 +0100)]
[SERVMAN] InitDialog => InitProgressDialog. #179
Amine Khaldi [Sat, 23 Dec 2017 12:57:01 +0000 (13:57 +0100)]
[DXDIAG] Rename WIDTH, HEIGHT, InitListViewColumns and SetDeviceDetails. Zap WindowProc. #179
Amine Khaldi [Sat, 23 Dec 2017 12:46:14 +0000 (13:46 +0100)]
[CHARMAP] Rename OnCreate functions. #179
Pierre Schweitzer [Sat, 23 Dec 2017 08:34:34 +0000 (09:34 +0100)]
[VFD] Add support for installing driver from System32\drivers.
Patch by Doug Lyons.
CORE-14090
Mark Jansen [Wed, 20 Dec 2017 21:06:44 +0000 (22:06 +0100)]
[ATL_APITEST] Show that CComObject's COM_MAP continues enumeration after a failing blind function.
Mark Jansen [Mon, 18 Dec 2017 22:15:46 +0000 (23:15 +0100)]
[ATL] Continue enumeration after a failing COM_INTERFACE_ENTRY_FUNC_BLIND
Amine Khaldi [Thu, 21 Dec 2017 12:57:22 +0000 (13:57 +0100)]
[WINDOWSCODECS_WINETEST] Add a PCH.
Amine Khaldi [Thu, 21 Dec 2017 12:55:57 +0000 (13:55 +0100)]
[MSXML3_WINETEST] Add a PCH.
Amine Khaldi [Thu, 21 Dec 2017 12:53:36 +0000 (13:53 +0100)]
[DSOUND_WINETEST] Add a PCH.
Amine Khaldi [Thu, 21 Dec 2017 12:45:22 +0000 (13:45 +0100)]
[DINPUT_WINETEST] Add a PCH.
Amine Khaldi [Thu, 21 Dec 2017 12:36:04 +0000 (13:36 +0100)]
[WS2_32_APITEST] Improve the existing PCH and make use of it.
Amine Khaldi [Thu, 21 Dec 2017 12:31:24 +0000 (13:31 +0100)]
[ATL_APITEST] Add a PCH.
Samuel Serapion [Wed, 20 Dec 2017 17:27:59 +0000 (12:27 -0500)]
[NTOS] Remove forgotten assert, see CORE-14128.
Stanislav Motylkov [Wed, 20 Dec 2017 18:16:27 +0000 (21:16 +0300)]
[TRANSLATION] [NETCFGX] Fix russian translation
Joachim Henze [Wed, 20 Dec 2017 16:38:36 +0000 (17:38 +0100)]
[WIN32K] avoid BSOD in Bochs 2.6.8 CORE-13629, patch by Mark Jansen
We applied this patch also last second in 0.4.7rls, now in master.
IntTrackPopupMenuEx() caused the BSOD when called while window is in the process of being destroyed.
Amine Khaldi [Wed, 20 Dec 2017 12:36:27 +0000 (13:36 +0100)]
[SHLWAPI_WINETEST] Add a PCH.
Amine Khaldi [Wed, 20 Dec 2017 12:29:32 +0000 (13:29 +0100)]
[SHELL32_WINETEST] Add a PCH.
Amine Khaldi [Wed, 20 Dec 2017 12:21:11 +0000 (13:21 +0100)]
[OLEAUT32_WINETEST] Add a PCH.
Amine Khaldi [Wed, 20 Dec 2017 12:13:26 +0000 (13:13 +0100)]
[OLE32_WINETEST] Add a PCH.
Amine Khaldi [Wed, 20 Dec 2017 12:07:06 +0000 (13:07 +0100)]
[NTDLL_WINETEST] Add a PCH.
Amine Khaldi [Wed, 20 Dec 2017 11:57:58 +0000 (12:57 +0100)]
[MSVCRT_WINETEST] Add a PCH.
Colin Finck [Wed, 20 Dec 2017 10:15:13 +0000 (11:15 +0100)]
Replace our dxtn.dll by a version based on the libtxc_dxtn source code (#203)
This is no official system DLL and WineD3D is its only user. But latest WineD3D prefers the libtxc_dxtn codebase instead of the alternative library we used.
This is also what Mesa uses and Fedora ships now that the patents have expired, so we should stick to the same.
I'm importing the libtxc_dxtn-1.0.1 codebase from https://people.freedesktop.org/~cbrill/libtxc_dxtn/
It compiles warning-free in our tree without modifying a single line!
I'm merging this Pull Request based on the positive response in CORE-12759.
I lack a proper test case myself, but my version at least shouldn't make things worse. In my opinion, the previous one was broken anyway due to using stdcall imports when WineD3D called cdecl ones.
This also removes the NSWPAT option from our buildsystem as dxtn was its latest user.
Timo Kreuzer [Tue, 19 Dec 2017 17:30:13 +0000 (18:30 +0100)]
[BOOT] Add VBox debug to livecd.ini
Timo Kreuzer [Tue, 19 Dec 2017 14:17:35 +0000 (15:17 +0100)]
[NTOS:MM] Fix a bug in MiBuildPfnDatabase
MxPfnAllocation is in pages, not in bytes!
Timo Kreuzer [Tue, 19 Dec 2017 14:16:54 +0000 (15:16 +0100)]
[NTOS:MM] Make debug code in MmArmInitSystem portable
Timo Kreuzer [Tue, 19 Dec 2017 14:16:04 +0000 (15:16 +0100)]
[NTOS:MM] Implement x64 version of MI_MAKE_SUBSECTION_PTE
Ivan Labutin [Mon, 18 Dec 2017 07:27:31 +0000 (08:27 +0100)]
[NTOS:PS] Skip backtrace on non-x86
Ivan Labutin [Mon, 13 Nov 2017 15:26:37 +0000 (18:26 +0300)]
[SAC] Fix wrong sized variable in SAC driver
Ivan Labutin [Mon, 13 Nov 2017 14:08:27 +0000 (15:08 +0100)]
[NTOS:FSRTL] Fixed incorrect comparison
Ivan Labutin [Mon, 13 Nov 2017 14:06:29 +0000 (15:06 +0100)]
[NTOS][NDK][RTL] A bunch of 'wrong size' fixes
Ivan Labutin [Fri, 10 Nov 2017 17:19:45 +0000 (20:19 +0300)]
[NTOS:MM] Quick fix: use SIZE_T instead of ULONG, because ULONG is 32-bit and on 64-bit truncates values
Ivan Labutin [Fri, 10 Nov 2017 16:44:30 +0000 (19:44 +0300)]
[NTOS:KE] Improve readability of CPU flag checks and fix error checking wrong register for HT support
Ivan Labutin [Thu, 9 Nov 2017 22:33:47 +0000 (23:33 +0100)]
[NTOS:KE] Remove duplicate NX enabling
Ivan Labutin [Thu, 9 Nov 2017 22:30:57 +0000 (01:30 +0300)]
[NTOS:MM] Comment out debug code for x86 that should not run on x64
Ivan Labutin [Thu, 9 Nov 2017 22:23:55 +0000 (01:23 +0300)]
[NTOS:KE] Move RtlpUse16ByteSLists initialization into KiInitializeKernel
Ivan Labutin [Thu, 9 Nov 2017 22:06:30 +0000 (01:06 +0300)]
[NTOS:KE] EFER constants fix
Timo Kreuzer [Wed, 11 Oct 2017 13:33:15 +0000 (15:33 +0200)]
[NTOSKRNL] Fix return of uninitialized variable in PspSetQuotaLimits
CID-
1322247
Mark Jansen [Sun, 17 Dec 2017 14:29:30 +0000 (15:29 +0100)]
[BROWSEUI] Implement ACLCustomMRU.
CORE-9281
Mark Jansen [Sat, 16 Dec 2017 16:22:48 +0000 (17:22 +0100)]
[BROWSEUI_APITEST] Add tests for IACLCustomMRU.
CORE-9281
Mark Jansen [Sat, 16 Dec 2017 13:50:49 +0000 (14:50 +0100)]
[COM_APITEST] Add IACLCustomMRU
Amine Khaldi [Mon, 18 Dec 2017 12:48:13 +0000 (13:48 +0100)]
[MSI_WINETEST] Add a PCH.
Amine Khaldi [Mon, 18 Dec 2017 12:43:24 +0000 (13:43 +0100)]
[MSHTML_WINETEST] Add a PCH.
Amine Khaldi [Mon, 18 Dec 2017 12:28:00 +0000 (13:28 +0100)]
[KERNEL32_WINETEST] Add a PCH.
Amine Khaldi [Mon, 18 Dec 2017 12:21:47 +0000 (13:21 +0100)]
[APITESTS][WINETESTS] Addendum to the recent PCH work.
Amine Khaldi [Mon, 18 Dec 2017 12:18:07 +0000 (13:18 +0100)]
[UUID] Add SID_SHTMLEditServices.
Pierre Schweitzer [Mon, 18 Dec 2017 07:44:24 +0000 (08:44 +0100)]
[FS] During 1st stage, disable any FS we don't support install to in order to let RawFS these volumes.
This avoids bloated setup and avoids potential bugs in 3rd party drivers.
This is following 806cd1.
Pierre Schweitzer [Sun, 17 Dec 2017 22:30:58 +0000 (23:30 +0100)]
[NTOSKRNL] Make again an attempt at killing the IopParseDevice() hack.
For the record, the only place it was remaining was 1st stage, notably because
FSD (FastAT <3) was missing a few features. As this features weren't triggered
in 3rd stage (unless forced), it was not needed there any longer.
Now that they are implemented, and seem working out of the box, this hack might
not be longer anymore.
This is my ... ?! pfff attempt at killing it. It might not be the last, so just
disabling the hack for now. If there are no regressions (who can really believe that?)
we'll be clear for dropping it once for all.
Pierre Schweitzer [Sun, 17 Dec 2017 22:29:33 +0000 (23:29 +0100)]
[FASFAT] Enable FAT volume dismount using VPB swapout
Pierre Schweitzer [Sun, 17 Dec 2017 22:26:38 +0000 (23:26 +0100)]
[USETUP] Our current FAT ChkDsk being a bit slow when using the right path make
it only perform a full check if dirty bit is set (which should never happen *cough*).
This is needed because otherwise, ReactOS installation takes forever when IopParseDevice is gone
due to slow ChkDsk.
Pierre Schweitzer [Sun, 17 Dec 2017 22:13:56 +0000 (23:13 +0100)]
[SETUP] Remove FSDs which have broken dismount implementation.
This avoids issues when these partitions are formatted to FAT for setup.
For now, this commit doesn't change anything, but once IopParseDevice hack
gets removed, this will make a difference!
CORE-6305
Timo Kreuzer [Sun, 17 Dec 2017 16:37:43 +0000 (17:37 +0100)]
[HAL] Use 64 bits for physical addresses.
Pierre Schweitzer [Sun, 17 Dec 2017 17:25:43 +0000 (18:25 +0100)]
[FASTFAT] Add a comment (and an ASSERT) in VfatCreateFile() that shows that my stats code is broken...
Pierre Schweitzer [Sun, 17 Dec 2017 17:21:51 +0000 (18:21 +0100)]
[FASTFAT] While closing FCBs on dismount, release from tail to head and not the contrary.
It fixes assertion failure in vfatDestroyFCB() where we would have release parent before child.
This is still not perfect, but less bug prone...
With this commits (and ENABLE_SWAPOUT defined), ReactOS seems to unmount FAT volumes quite nice! :-)
(Tried with fsutil volume dismount X:)
Pierre Schweitzer [Sun, 17 Dec 2017 17:20:04 +0000 (18:20 +0100)]
[FASTFAT] Fix a handle count leak on volume close. This can prevent locking a volume!
Pierre Schweitzer [Sun, 17 Dec 2017 17:19:03 +0000 (18:19 +0100)]
[FASTFAT] When not able to lock a volume due to open handles, print open handles
Alexander Shaposhnikov [Sun, 17 Dec 2017 14:09:55 +0000 (16:09 +0200)]
[RAPPS] Select 'Available' category by default.
Hermès Bélusca-Maïto [Sun, 17 Dec 2017 13:44:23 +0000 (14:44 +0100)]
[MSCONFIG_NEW] Temporarily "fix" the header of the SimpChinese resource file because this has nothing to do with Paint whatsoever. Proper headers will be used as soon as msconfig_new replaces the old one and such headers be used in all of its code.
Luo Yufan [Fri, 15 Dec 2017 11:11:24 +0000 (19:11 +0800)]
[TRANSLATION] Improve Simplified Chinese Translations.
* Fix Simplified Chinese Translation of EXPLORER.
* Fix Simplified Chinese Translation of MSCONFIG_NEW.
* Fix Simplified Chinese Translation of MSPAINT.
* Fix Simplified Chinese Translation of SHELL32.
* Fix Simplified Chinese Translation of SYSDM.
* Fix Simplified Chinese Translation of SETUP/REACTOS.