reactos.git
3 months ago[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub 2932/head
Oleg Dubinskiy [Thu, 18 Jun 2020 18:06:34 +0000 (21:06 +0300)]
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.

3 months ago[SDK][SVCHOST] Move all global svchost declarations to public header. 2931/head
Oleg Dubinskiy [Thu, 18 Jun 2020 12:03:01 +0000 (15:03 +0300)]
[SDK][SVCHOST] Move all global svchost declarations to public header.

Also update the includes.
It will allow to use those declarations globally where they are required (e. g. for SvchostPushServiceGlobals functions in some services).
No functional changes.

3 months ago[MSI] Remove obsolete '__ASM_DEFINE_FUNC()' 2918/head
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()'

MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}

Addendum to 476c99b and 9efafd6.

3 months ago[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'

Addendum to 0f5d91b.
CORE-16441

3 months ago[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type 2917/head
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type

MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''

Addendum to 3f15a0d.

3 months ago[POWRPROF_APITEST] Fix cppcheck warnings. 2891/head
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[POWRPROF_APITEST] Fix cppcheck warnings.

* test_CallNtPowerInformation(): Fix 2 'sizeof(sizeof())' copypastas
* test_ValidatePowerPolicies_Next(): Delete a duplicate line

3 months ago[CRT] _onexit(): Fix 'memcpy()' size 2892/head
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRT] _onexit(): Fix 'memcpy()' size

Cherry-pick
https://source.winehq.org/git/wine.git/commit/70bff7377dbe9bdaaac5e86c49ee45130e65e5d9

3 months ago[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.

* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning

3 months ago[SYSDM] Set the proper icon in title bar
Jared Smudde [Sat, 27 Jun 2020 00:51:22 +0000 (19:51 -0500)]
[SYSDM] Set the proper icon in title bar

3 months ago[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.
Thomas Faber [Sat, 27 Jun 2020 07:27:33 +0000 (09:27 +0200)]
[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.

* Check the entire version field
* Check the variant field
* Accept RPC_NT_UUID_LOCAL_ONLY, which is sometimes returned by Windows
* Repeat the test to show that these things happen every time

Based on a patch by Serge Gautherie.

3 months ago[FASTFAT_NEW] Sync to upstream 16022c5 (#2938)
Serge Gautherie [Fri, 26 Jun 2020 17:03:01 +0000 (19:03 +0200)]
[FASTFAT_NEW] Sync to upstream 16022c5 (#2938)

3 months ago[TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific

3 months ago[NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code
Serge Gautherie [Fri, 22 May 2020 18:24:31 +0000 (20:24 +0200)]
[NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code

No impact.

Detected by Cppcheck: unreachableCode.
Addendum to ddaf47dec3f096666757ff2cc9892adc01da887c (r34976).

3 months ago[USBSTOR] Correctly terminate a REG_MULTI_SZ string
Victor Perevertkin [Wed, 24 Jun 2020 18:14:36 +0000 (21:14 +0300)]
[USBSTOR] Correctly terminate a REG_MULTI_SZ string
returned by the IRP_MN_QUERY_ID handler

3 months ago[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory. 2937/head
Nguyen Trung Khanh [Sat, 20 Jun 2020 03:16:56 +0000 (10:16 +0700)]
[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.

This avoids disclosing pool contents to user mode when not all members
of the respective structure are initialized or when there is padding.

In co_IntCallWindowProc, also zero the stack buffer since this can
be passed to user mode as well, and contains padding.

3 months ago[NPFS] Fix querying FileAllInformation.
Thomas Faber [Tue, 23 Jun 2020 08:15:24 +0000 (10:15 +0200)]
[NPFS] Fix querying FileAllInformation.

3 months ago[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c 2940/head
Victor Perevertkin [Sun, 21 Jun 2020 14:54:44 +0000 (17:54 +0300)]
[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c
And rearrange them in more logical order.

This effectively splits the file, leaving public "Io" functions in
pnpmgr.c along with some things not related do device object management.
Functions which manipulate the device tree are left in devaction.c.
In future all these functions will only be accessed from
DeviceActionWorker.
While being public API, IoRequestDeviceEject and IoInvalidateDeviceState
have been moved to devaction.c as well. In next commits they will be
converted to DeviceActionWorker routines and their callers will be put
in pnpmgr.c

3 months ago[ROSAUTOTEST] Add /t parameter for repeating tests
Victor Perevertkin [Mon, 18 May 2020 02:42:53 +0000 (05:42 +0300)]
[ROSAUTOTEST] Add /t parameter for repeating tests

3 months ago[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136
Thomas Faber [Sun, 21 Jun 2020 08:18:19 +0000 (10:18 +0200)]
[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136

3 months ago[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136
Thomas Faber [Sun, 21 Jun 2020 07:57:17 +0000 (09:57 +0200)]
[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136

We neither want to handle IRPs we don't understand, nor do we want to
assert in case of unexpected IOCTLs.

3 months ago[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c 2934/head
Victor Perevertkin [Fri, 19 Jun 2020 20:55:40 +0000 (23:55 +0300)]
[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c
Add SAL2 annotations to functions while moving
Convert IopCreateDeviceNode description to a Doxygen format

3 months ago[FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds

3 months ago[FASTFAT_NEW] Remove obsolete compiler workarounds
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Remove obsolete compiler workarounds

following upgrade to GCC 8.4 and MSVC 2015.

3 months ago[FASTFAT_NEW] Fix GCC 8.4 build
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] Fix GCC 8.4 build

'.../strucsup.c:...:...: error: 'Ex*NPagedLookasideList' is static but used in inline function 'Fat*' which is not static [-Werror]'

3 months ago[FASTFAT_NEW] fatdata.h: Properly mark ReactOS own code
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] fatdata.h: Properly mark ReactOS own code

Addendum to 3013e15.

3 months ago[CMAKE] Remove work-arounds for old CMake versions. CORE-17109 2901/head
Thomas Faber [Sun, 7 Jun 2020 07:26:23 +0000 (09:26 +0200)]
[CMAKE] Remove work-arounds for old CMake versions. CORE-17109

3 months ago[CMAKE] Use CMake 3.17 default policies. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 21:00:02 +0000 (23:00 +0200)]
[CMAKE] Use CMake 3.17 default policies. CORE-17109

3 months ago[CMAKE] Bump minimum to 3.17, no longer require -ReactOS build. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:59:26 +0000 (22:59 +0200)]
[CMAKE] Bump minimum to 3.17, no longer require -ReactOS build. CORE-17109

3 months ago[CMAKE] Set CMAKE_MSVC_RUNTIME_LIBRARY to satisfy CMP0091. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 22:20:09 +0000 (00:20 +0200)]
[CMAKE] Set CMAKE_MSVC_RUNTIME_LIBRARY to satisfy CMP0091. CORE-17109

We use /NODEFAULTLIB, and consequently also don't want CMake to add
a default library for us.

3 months ago[CMAKE] Use NEW policy for CMP0058. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:57:30 +0000 (22:57 +0200)]
[CMAKE] Use NEW policy for CMP0058. CORE-17109

3 months ago[CMAKE] Mark host tools as byproducts. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:57:11 +0000 (22:57 +0200)]
[CMAKE] Mark host tools as byproducts. CORE-17109

3 months ago[BOOTDATA] Mark reactos.inf as a byproduct. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:56:49 +0000 (22:56 +0200)]
[BOOTDATA] Mark reactos.inf as a byproduct. CORE-17109

3 months ago[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)
Thomas Brogan [Sat, 20 Jun 2020 10:28:25 +0000 (13:28 +0300)]
[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)

Use QueryPerformanceCounter if a high-resolution timer is requested (<= 5ms) instead of the more inaccurate GetTickCount.

3 months ago[PCI] Fix PDO removal
Hervé Poussineau [Thu, 18 Jun 2020 16:18:13 +0000 (18:18 +0200)]
[PCI] Fix PDO removal

We must not do anything on PDO removal, especially not deleting it.
We are allowed to delete it, only once we successfully completed a IRP_MN_QUERY_DEVICE_RELATIONS without with PDO.

3 months ago[SETUPAPI] Add function names in traces
Hervé Poussineau [Thu, 18 Jun 2020 17:20:14 +0000 (19:20 +0200)]
[SETUPAPI] Add function names in traces

3 months ago[NtUser] Fix MSVC_x64 Build
James Tabor [Thu, 18 Jun 2020 16:55:13 +0000 (11:55 -0500)]
[NtUser] Fix MSVC_x64 Build

Attempt to fix.

3 months ago[NtUser] Fix Crash in Win32k
James Tabor [Thu, 18 Jun 2020 16:06:31 +0000 (11:06 -0500)]
[NtUser] Fix Crash in Win32k

Use strict thread and desktop verifying. See CORE-15092 and CORE-17133.

3 months ago[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling 2910/head
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling

Detected by Cppcheck: uselessAssignmentPtrArg.
Addendum to 794e7aa (r31523) and e647530 (r65893).

3 months ago[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes 2909/head
Serge Gautherie [Mon, 8 Jun 2020 20:45:45 +0000 (22:45 +0200)]
[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes

Detected by Cppcheck: funcArgOrderDifferent, redundantAssignment.

3 months ago[KMTESTS:OB] ObTypes: Support latest NT5.2 results 2153/head
Serge Gautherie [Mon, 16 Dec 2019 03:28:29 +0000 (04:28 +0100)]
[KMTESTS:OB] ObTypes: Support latest NT5.2 results

Update Port and WaitablePort values.

3 months ago[RAPPS] delete obsolete field GSoC_2020/Syzkaller
He Yang [Sun, 14 Jun 2020 18:34:43 +0000 (02:34 +0800)]
[RAPPS] delete obsolete field

3 months ago[DNSRSLVR] Define NDEBUG in cache.c
Joachim Henze [Sun, 14 Jun 2020 18:03:33 +0000 (20:03 +0200)]
[DNSRSLVR] Define NDEBUG in cache.c

To avoid leaking private data into logs by default.
Some testers may consider their DNS-suffix private data.
And DnsIntCacheAddEntry() logs that via Record->pName.

3 months agoRevert "[FONTS] Add Selawik as a substitution for Segoe UI" CORE-17122 (#2921)
Oleg Dubinskiy [Sun, 14 Jun 2020 10:09:41 +0000 (13:09 +0300)]
Revert "[FONTS] Add Selawik as a substitution for Segoe UI" CORE-17122 (#2921)

This reverts commit 97fb49a3d2bfdbbf5f03e193f922a80dd39ca9ba.

3 months ago[MPG123] Update to version 1.26.1. CORE-17098
Thomas Faber [Sat, 30 May 2020 19:43:44 +0000 (21:43 +0200)]
[MPG123] Update to version 1.26.1. CORE-17098

3 months ago[ACPICA] Update to version 20200528. CORE-17094
Thomas Faber [Sat, 30 May 2020 13:30:56 +0000 (15:30 +0200)]
[ACPICA] Update to version 20200528. CORE-17094

3 months ago[RTL] Use LastEntryInSegment to speed up RtlpFindAndCommitPages. CORE-14588 2319/head
Thomas Faber [Sun, 2 Feb 2020 11:54:19 +0000 (12:54 +0100)]
[RTL] Use LastEntryInSegment to speed up RtlpFindAndCommitPages. CORE-14588

3 months ago[RTL] Add and populate LastEntryInSegment. CORE-14588
Thomas Faber [Sun, 2 Feb 2020 11:53:57 +0000 (12:53 +0100)]
[RTL] Add and populate LastEntryInSegment. CORE-14588

3 months ago[RTL] Create a define for the common members of HEAP and HEAP_SEGMENT. CORE-14588
Thomas Faber [Sat, 1 Feb 2020 20:34:03 +0000 (21:34 +0100)]
[RTL] Create a define for the common members of HEAP and HEAP_SEGMENT. CORE-14588

The code relies on these members matching up, so it's confusing for them
to be duplicated.

3 months ago[USBSTOR] Fix unused variable introduced in 94e61c3
Victor Perevertkin [Sat, 13 Jun 2020 00:20:08 +0000 (03:20 +0300)]
[USBSTOR] Fix unused variable introduced in 94e61c3

3 months ago[USBSTOR] Fix wrong function name in a9b97ae
Victor Perevertkin [Sat, 13 Jun 2020 00:07:00 +0000 (03:07 +0300)]
[USBSTOR] Fix wrong function name in a9b97ae

3 months ago[USBSTOR] Move PDO's Inquiry data and FDO's SCSI context
Victor Perevertkin [Fri, 12 Jun 2020 13:51:42 +0000 (16:51 +0300)]
[USBSTOR] Move PDO's Inquiry data and FDO's SCSI context
to their Device Extensions.
This way the driver can better handle low memory situations

3 months ago[USBSTOR] General refactoring.
Victor Perevertkin [Sat, 9 Nov 2019 22:05:47 +0000 (01:05 +0300)]
[USBSTOR] General refactoring.
Remove unused structures and unused fields in device extensions.
Replaced magic numbers with constants

3 months ago[README.FSD] Add 'disk_new' entry
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[README.FSD] Add 'disk_new' entry

Follow-up to 022f4b2 (r55555).

3 months ago[README.FSD] Add 'nfs41 project' entries
Serge Gautherie [Sat, 6 Jun 2020 18:09:03 +0000 (20:09 +0200)]
[README.FSD] Add 'nfs41 project' entries

CORE-8204

3 months ago[README.FSD] Remove obsolete 'reactos/' directory
Serge Gautherie [Sat, 6 Jun 2020 18:04:15 +0000 (20:04 +0200)]
[README.FSD] Remove obsolete 'reactos/' directory

3 months ago[FREELDR] Add display controller detection for Xbox
Stanislav Motylkov [Tue, 9 Jun 2020 19:02:09 +0000 (22:02 +0300)]
[FREELDR] Add display controller detection for Xbox

Also add system identifier here.

[BOOTDATA] Fix some typos

CORE-16216

3 months ago[SECUR32_WINETEST] Update for new WineHQ certificate
Serge Gautherie [Mon, 8 Jun 2020 17:41:32 +0000 (19:41 +0200)]
[SECUR32_WINETEST] Update for new WineHQ certificate

Cherry-pick
https://source.winehq.org/git/wine.git/commit/16254af818095216e10aee4d9032a8def3ac3344

CORE-17088

3 months ago[WININET_WINETEST][URLMON_WINETEST][SHELL32_APITEST] Skip some tests
Victor Perevertkin [Mon, 8 Jun 2020 00:43:43 +0000 (03:43 +0300)]
[WININET_WINETEST][URLMON_WINETEST][SHELL32_APITEST] Skip some tests
Due to hangs on test machines
ROSTESTS-357 ROSTESTS-358 CORE-17057

3 months ago[VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupCompon...
Oleg Dubinskiy [Thu, 26 Mar 2020 14:47:16 +0000 (16:47 +0200)]
[VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z and _VSSAPI_CreateVssBackupComponents@4 in msvc.s, to fix MSVC compilation

3 months ago[VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBack...
Oleg Dubinskiy [Wed, 25 Mar 2020 19:23:37 +0000 (21:23 +0200)]
[VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z"
https://source.winehq.org/git/wine.git/commit/ce9b5a7e1782828f0a84d31eff73cf643ea4fe85
https://source.winehq.org/git/wine.git/commit/767c94bc5c0b9cdef0465b0fec555d846331fb03
CORE-9511.

3 months ago[PSDK] Import vsbackup.idl from Wine and enable it in CMakeLists.txt
Oleg Dubinskiy [Wed, 25 Mar 2020 19:09:17 +0000 (21:09 +0200)]
[PSDK] Import vsbackup.idl from Wine and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.

3 months ago[PSDK] Add some missing definitions from Wine in vss.idl
Oleg Dubinskiy [Wed, 25 Mar 2020 18:59:25 +0000 (20:59 +0200)]
[PSDK] Add some missing definitions from Wine in vss.idl
Required by vssapi stubs and Wine's vsbackup.idl CORE-9511.

3 months ago[PSDK] Replace our vswriter.h by Wine's vswriter.idl and enable it in CMakeLists.txt
Oleg Dubinskiy [Wed, 25 Mar 2020 18:33:28 +0000 (20:33 +0200)]
[PSDK] Replace our vswriter.h by Wine's vswriter.idl and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.
Our current vswriter.h has no some needed definitions, but simple adding them in the current header is not an option, since Wine's vsbackup.idl (which is required too) depends on it.
Then it will not need to add ROS-specific diff(s) in Wine's vsbackup.idl.

3 months ago[CHARMAP] Functionality Improvements and Bug Fixes (#2560)
Charles Ambrye [Sun, 7 Jun 2020 17:34:45 +0000 (10:34 -0700)]
[CHARMAP] Functionality Improvements and Bug Fixes (#2560)

- Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window.

- Skip over the non-printable characters by starting with character ' ' + 1.

- Instead of iterating over every cell, simply compute the cell x and y using the CellSize.

- Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.

- Simplify math for moving window to be on desktop.
Added FIXME to highlight this doesn't work well on multi-monitor setups.
Changed xPos and yPos to LONG since negative numbers are valid on multi-monitor setups.

- Do not draw invalid glyphs on the map (can happen when switching fonts or filtering existing font).
- Do not allow mouse-over of invalid glyphs.

- Fix bug that caused the Help button to remain enabled as it was being modified before it was even created.
- Do a better job at finding the correct glyph under the mouse.

- Ensure the active cell is cleared correctly.

- Invalidate the rect around the previously active cell to ensure it gets redrawn as inactive.

- Fix bug from CORE-10518 (initial active cell was not being invalidated on scroll).

- Do not try to copy a character to the output if there is no active cell selected.

- Populate the advanced portion of the screen with several built-in code pages (the list is hardcoded so that we don't enumerate everything).

- Add functionality to filter the character map by a code page (called a character set in this program).

- Some fonts list 0x0000 as drawable, even when it isn't, so ignore any valid glyphs that contain it.

3 months ago[RPCRT4] Export NdrCreateServerInterfaceFromStub as `stub` 2715/head
Oleg Dubinskiy [Sat, 2 May 2020 08:32:14 +0000 (11:32 +0300)]
[RPCRT4] Export NdrCreateServerInterfaceFromStub as `stub`
Required by MS ole32.dll CORE-15395, CORE-17004.

3 months ago[SHELLBARS] Add missing psdk dependency.
Thomas Faber [Sat, 6 Jun 2020 20:55:49 +0000 (22:55 +0200)]
[SHELLBARS] Add missing psdk dependency.

3 months ago[MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available.
Thomas Faber [Sat, 6 Jun 2020 20:55:23 +0000 (22:55 +0200)]
[MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available.

3 months ago[NTDLL_APITEST] Add ProcessWx86Information testcase for NtXxxInformationProcess ...
George Bișoc [Sat, 6 Jun 2020 19:38:37 +0000 (21:38 +0200)]
[NTDLL_APITEST] Add ProcessWx86Information testcase for NtXxxInformationProcess (#2852)

3 months ago[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2764/head
Amine Khaldi [Sat, 9 May 2020 21:37:40 +0000 (22:37 +0100)]
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905

3 months ago[HHPCOMP] Fix 2 MSVC C4101 warnings (#2392)
Serge Gautherie [Sat, 6 Jun 2020 16:42:47 +0000 (18:42 +0200)]
[HHPCOMP] Fix 2 MSVC C4101 warnings (#2392)

"...\chmc\chmc.c(671): warning C4101: 'code': unreferenced local variable"
"...\chmc\chmc.c(671): warning C4101: 'len': unreferenced local variable"

3 months ago[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816)
Serge Gautherie [Sat, 6 Jun 2020 16:25:43 +0000 (18:25 +0200)]
[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816)

3 months ago[NFSD] readdir_copy_shortname(): Add needed brackets to '*name_size_out' (#2856)
Serge Gautherie [Sat, 6 Jun 2020 16:21:05 +0000 (18:21 +0200)]
[NFSD] readdir_copy_shortname(): Add needed brackets to '*name_size_out' (#2856)

CORE-17078

3 months ago[APPHELP_APITEST] Properly handle a couple 'malloc()/free()' (#2898)
Serge Gautherie [Sat, 6 Jun 2020 15:58:34 +0000 (17:58 +0200)]
[APPHELP_APITEST] Properly handle a couple 'malloc()/free()' (#2898)

Detected by Cppcheck: memleak, redundantAssignment.
Addendum to 78280ad2 (r71226).

3 months ago[NTOSKRNL] Add 'DECLSPEC_NORETURN' to a few 'KeBugCheck*()' (#2896)
Serge Gautherie [Sat, 6 Jun 2020 15:50:14 +0000 (17:50 +0200)]
[NTOSKRNL] Add 'DECLSPEC_NORETURN' to a few 'KeBugCheck*()' (#2896)

3 months ago[NTDLL_APITEST] Add NtSetInformationThread testcase (#2793)
George Bișoc [Sat, 6 Jun 2020 15:48:39 +0000 (17:48 +0200)]
[NTDLL_APITEST] Add NtSetInformationThread testcase (#2793)

3 months ago[NTDLL_APITEST] Add ProcessBasePriority and ProcessRaisePriority classes unit tests...
George Bișoc [Sat, 6 Jun 2020 15:47:38 +0000 (17:47 +0200)]
[NTDLL_APITEST] Add ProcessBasePriority and ProcessRaisePriority classes unit tests (#2740)

ProcessRaisePriority expects a buffer input information argument of KPRIORITY type definition as shown in this documentation (see the PROCESS_INFORMATION_CLASS structure members list of classes).
https://undocumented.ntinternals.net/index.html?page=UserMode%2FUndocumented%20Functions%2FNT%20Objects%2FProcess%2FNtSetInformationProcess.html

3 months ago[NTOS:KE] Save ExceptionList in the assembly version of KiEnterTrap. CORE-15723 2836/head
Thomas Faber [Fri, 22 May 2020 20:34:56 +0000 (22:34 +0200)]
[NTOS:KE] Save ExceptionList in the assembly version of KiEnterTrap. CORE-15723

If SEH is used in a C trap handler, the exception frame will be
registered before the call to KiEnterTrap, which means we save
the wrong trap handler. We'll therefore also restore this wrong
frame for the excepting code, resulting in a stale SEH chain.

We avoid this problem by saving the handler in the assembly
trap entry code instead of from C. While SEH in a C trap handler
should now theoretically be safe, we still forbid it through
asserts in the C KiEnterTrap variants to make any potential
future problems more obvious. Should this functionality be
needed at some point and deemed safe, these asserts can then be
removed.

3 months ago[NTOS:KE] Split KiCheckForSListFault into its own function. CORE-15723
Thomas Faber [Fri, 22 May 2020 09:18:39 +0000 (11:18 +0200)]
[NTOS:KE] Split KiCheckForSListFault into its own function. CORE-15723

This avoids SEH in a trap handler.
See the following commit for more details.

3 months ago[RTL] Add FPO information to RtlpExecuteHandler. CORE-15723
Thomas Faber [Fri, 22 May 2020 07:22:39 +0000 (09:22 +0200)]
[RTL] Add FPO information to RtlpExecuteHandler. CORE-15723

3 months ago[CDMAKE] Add 'DECLSPEC_NORETURN' to 'error_exit()' (#2893)
Serge Gautherie [Fri, 5 Jun 2020 11:57:49 +0000 (13:57 +0200)]
[CDMAKE] Add 'DECLSPEC_NORETURN' to 'error_exit()' (#2893)

Detected by Cppcheck: doubleFree.

3 months ago[SDK:RTL] RtlValidAcl(): Improve ACL error messages (#2833)
Serge Gautherie [Thu, 4 Jun 2020 21:20:20 +0000 (23:20 +0200)]
[SDK:RTL] RtlValidAcl(): Improve ACL error messages (#2833)

CORE-11506

3 months ago[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)
Serge Gautherie [Thu, 4 Jun 2020 20:35:54 +0000 (22:35 +0200)]
[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)

Addendum to 21d2accad37825f47e3caa78ff36153751652238 (r71793).

3 months ago[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)
Serge Gautherie [Thu, 4 Jun 2020 20:26:28 +0000 (22:26 +0200)]
[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)

No impact.

Detected by Cppcheck: redundantCondition.
Addendum to 1fe3a2d6c307a1ec11d7728a9493360a5808e1ac (r9788).

3 months ago[HALXBOX] Fix clock drift (#2889)
Dmitry Borisov [Tue, 2 Jun 2020 23:14:16 +0000 (05:14 +0600)]
[HALXBOX] Fix clock drift (#2889)

Add a new rollover table for Original Xbox (base frequency is 1.125000 MHz).
This fixes potential time issues in kernel and drivers.

CORE-16216

3 months ago[FREELDR] Fix register offset
Stanislav Motylkov [Tue, 2 Jun 2020 23:04:07 +0000 (02:04 +0300)]
[FREELDR] Fix register offset

Addendum to 10e52f6.

3 months ago[SHELL32] Improve readability of filesystem notification (#2737)
Katayama Hirofumi MZ [Tue, 2 Jun 2020 09:42:07 +0000 (18:42 +0900)]
[SHELL32] Improve readability of filesystem notification (#2737)

Improve human readability of filesystem change notification.
- Rename the identifiers for human readabilities.
- Split the code into CFilePathList and CDirectoryWatcher classes.
- Encapsulation of code.
CORE-13950

3 months ago[TRANSLATION] Add/update Portuguese translation (#2850)
Jose Carlos Jesus [Mon, 1 Jun 2020 18:48:58 +0000 (19:48 +0100)]
[TRANSLATION] Add/update Portuguese translation (#2850)

- Add translation for: iernonce, modmui.
- Update translation for: jscript, msports, shell32.

3 months ago[TRANSLATION] Add/Update Portuguese translation for some shell extensions (#2845)
Jose Carlos Jesus [Mon, 1 Jun 2020 18:31:06 +0000 (19:31 +0100)]
[TRANSLATION]  Add/Update Portuguese translation for some shell extensions (#2845)

- Add translation for: devcpux, netplwiz, ntobjshex, stobject, zipfldr.
- Update translation for: sendmail.

3 months ago[CSRSRV] CsrUnhandledExceptionFilter: Check RtlAdjustPrivilege() result (#2864)
Serge Gautherie [Mon, 1 Jun 2020 18:20:31 +0000 (20:20 +0200)]
[CSRSRV] CsrUnhandledExceptionFilter: Check RtlAdjustPrivilege() result (#2864)

And remove unused NtRaiseHardError() Status assignment.

Detected by Cppcheck: redundantAssignment.
Related to commit d221bdfb (r55647).

3 months ago[APISETS] Fix some functions that are NT10(v1607)+ (#2738)
Serge Gautherie [Mon, 1 Jun 2020 17:04:32 +0000 (19:04 +0200)]
[APISETS] Fix some functions that are NT10(v1607)+ (#2738)

- *_onexit_*() are NT10(v1607)+
- *_seh_filter_*() are NT10(v1607)+ actually

CORE-16700

3 months ago[RAPPS] Update Chinese (Taiwan) translation (#2873)
He Yang [Mon, 1 Jun 2020 11:30:53 +0000 (19:30 +0800)]
[RAPPS] Update Chinese (Taiwan) translation (#2873)

3 months ago[CSRSRV] CsrSetProcessSecurity(): Check 1st NtQueryInformationToken() result (#2862)
Serge Gautherie [Mon, 1 Jun 2020 11:17:29 +0000 (13:17 +0200)]
[CSRSRV] CsrSetProcessSecurity(): Check 1st NtQueryInformationToken() result (#2862)

Also:
* Add 1 NtClose(hToken), in an error case.
* Do not call RtlFreeHeap(..., ..., NULL).

Follow-up to #2857.

3 months ago[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)
Serge Gautherie [Mon, 1 Jun 2020 09:26:53 +0000 (11:26 +0200)]
[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)

And let bar timer depend on the bar image only.

Addendum to 623dd26ccea5e79001aee769c230fb4f8e304fc8.

3 months ago[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)
Serge Gautherie [Mon, 1 Jun 2020 09:20:13 +0000 (11:20 +0200)]
[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)

* api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only

CORE-8880

3 months ago[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)
Serge Gautherie [Mon, 1 Jun 2020 09:17:29 +0000 (11:17 +0200)]
[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)

Addendum to 82e4efea77aa19d79a4a14c41ae2222c2994b829.

3 months ago[USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)
Serge Gautherie [Mon, 1 Jun 2020 09:14:38 +0000 (11:14 +0200)]
[USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)

No impact.

Missed part of
https://source.winehq.org/git/wine.git/commit/fb6304119a967ea13688ff9e34ed9d819bd50785

Detected by Cppcheck: identicalInnerCondition.
Addendum to 303ece24219da7ec0cac1016767092287abd7877 (r72520).

3 months ago[NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)
Serge Gautherie [Mon, 1 Jun 2020 09:10:11 +0000 (11:10 +0200)]
[NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)

No impact.

Detected by Cppcheck: unusedVariable.
Addendum to 2dade10d543589e1f5f762bbc1695f2917341171.

3 months ago[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)
Serge Gautherie [Mon, 1 Jun 2020 09:06:49 +0000 (11:06 +0200)]
[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)

Cherry-pick:
https://source.winehq.org/git/wine.git/commit/a359e026662251b7c3367fe2815dcb6cb371af50
https://source.winehq.org/git/wine.git/commit/0662da18b85634928905e72041961ffd3a6e8045
https://source.winehq.org/git/wine.git/commit/e4e5eda3d9afcb5360747ddd97e6bf4fdc0c1c0f

CORE-9665

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
3 months ago[INF] Add better device descriptions for Original Xbox
Stanislav Motylkov [Sun, 31 May 2020 21:30:51 +0000 (00:30 +0300)]
[INF] Add better device descriptions for Original Xbox

CORE-16216

3 months ago[SCHEDSVC] Implement the job start time calculation for given days of month
Eric Kohl [Sun, 31 May 2020 20:33:49 +0000 (22:33 +0200)]
[SCHEDSVC] Implement the job start time calculation for given days of month