reactos.git
4 years ago[TRANSLATION] Update Portuguese translation (#2115)
Jose Carlos Jesus [Sun, 1 Dec 2019 09:14:13 +0000 (09:14 +0000)]
[TRANSLATION] Update Portuguese translation (#2115)

4 years ago[SHELL32] Fix regression of DoCreateSendToFiles
Katayama Hirofumi MZ [Sun, 1 Dec 2019 04:55:43 +0000 (13:55 +0900)]
[SHELL32] Fix regression of DoCreateSendToFiles

CoInitializeEx/CoUninitialize added.
CORE-12562

4 years ago[SHELL32_APITEST] Improve DragDrop testcase 2
Katayama Hirofumi MZ [Sun, 1 Dec 2019 02:44:43 +0000 (11:44 +0900)]
[SHELL32_APITEST] Improve DragDrop testcase 2

CORE-11238

4 years ago[TRANSLATION][MC] Polish translation update for errcodes.mc (#2108)
Adam Słaboń [Sat, 30 Nov 2019 15:31:28 +0000 (16:31 +0100)]
[TRANSLATION][MC] Polish translation update for errcodes.mc (#2108)

4 years ago[SXS_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:58:10 +0000 (14:58 +0100)]
[SXS_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SXS] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:56:42 +0000 (14:56 +0100)]
[SXS] Sync with Wine Staging 4.18. CORE-16441

4 years ago[STI_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:56:15 +0000 (14:56 +0100)]
[STI_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[STI] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 17:21:33 +0000 (18:21 +0100)]
[STI] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SNMPAPI] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:51:23 +0000 (14:51 +0100)]
[SNMPAPI] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SLBCSP] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:50:58 +0000 (14:50 +0100)]
[SLBCSP] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SHLWAPI_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:50:34 +0000 (14:50 +0100)]
[SHLWAPI_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SHELL32_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:50:08 +0000 (14:50 +0100)]
[SHELL32_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SHDOCVW] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:49:41 +0000 (14:49 +0100)]
[SHDOCVW] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SENSAPI] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:49:13 +0000 (14:49 +0100)]
[SENSAPI] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SECUR32_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:48:48 +0000 (14:48 +0100)]
[SECUR32_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[PSDK] Add SECPKG_FLAG_APPLY_LOOPBACK. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:48:23 +0000 (14:48 +0100)]
[PSDK] Add SECPKG_FLAG_APPLY_LOOPBACK. CORE-16441

4 years ago[SCRRUN_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:47:55 +0000 (14:47 +0100)]
[SCRRUN_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SCRRUN] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:47:27 +0000 (14:47 +0100)]
[SCRRUN] Sync with Wine Staging 4.18. CORE-16441

4 years ago[SCCBASE] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 30 Nov 2019 13:46:59 +0000 (14:46 +0100)]
[SCCBASE] Sync with Wine Staging 4.18. CORE-16441

4 years ago[STORAGE] Storage driver cleanup part 5 (last part)
Eric Kohl [Sat, 30 Nov 2019 12:33:32 +0000 (13:33 +0100)]
[STORAGE] Storage driver cleanup part 5 (last part)

Move the fdc and flpydrv drivers into the floppy directory.

4 years ago[STORAGE] Storage driver cleanup part 4
Eric Kohl [Sat, 30 Nov 2019 12:13:59 +0000 (13:13 +0100)]
[STORAGE] Storage driver cleanup part 4

Move the floppy driver into the floppy/floppy directory.

4 years ago[STORAGE] Storage driver cleanup part 3
Eric Kohl [Sat, 30 Nov 2019 11:58:59 +0000 (12:58 +0100)]
[STORAGE] Storage driver cleanup part 3

Move the storahci driver into the port directory.

4 years ago[STORAGE] Storage driver cleanup part 2
Eric Kohl [Sat, 30 Nov 2019 11:19:03 +0000 (12:19 +0100)]
[STORAGE] Storage driver cleanup part 2

Move the scsiport driver into the port directory.

4 years ago[STORAGE] Storage driver cleanup part 1
Eric Kohl [Sat, 30 Nov 2019 10:41:39 +0000 (11:41 +0100)]
[STORAGE] Storage driver cleanup part 1

Move the classpnp driver into the class directory because it is a class driver, just like the class2 driver.

4 years ago[SHELL32] Validate file operation (#2085)
Katayama Hirofumi MZ [Sat, 30 Nov 2019 06:36:16 +0000 (15:36 +0900)]
[SHELL32] Validate file operation (#2085)

- Support FOF_RENAMEONCOLLISION flag of SHFileOperationW.
- Add validate_operation function and use it in SHFileOperationW.

CORE-10225

4 years ago[KERNEL32] Fix multibyte conversion in default char (#2111)
Katayama Hirofumi MZ [Sat, 30 Nov 2019 06:10:10 +0000 (15:10 +0900)]
[KERNEL32] Fix multibyte conversion in default char (#2111)

Fix kernel32!MultiByteToWideChar function. The default character was wrong. CORE-16468

4 years ago[USERENV] Fix Japanese profile info
Katayama Hirofumi MZ [Sat, 30 Nov 2019 05:55:45 +0000 (14:55 +0900)]
[USERENV] Fix Japanese profile info

Probably we shouldn't localize IDS_APPDATA and IDS_LOCALSETTINGS resource strings of userenv module until localization complete.
CORE-16539

4 years ago[MEDIA][NLS] Fix c_932.nls header (#2110)
Katayama Hirofumi MZ [Sat, 30 Nov 2019 03:57:29 +0000 (12:57 +0900)]
[MEDIA][NLS] Fix c_932.nls header (#2110)

Modify and fix file c_932.nls that is codepage 932 information of NLS (National Language Support). CORE-16468

4 years ago[WINSTA] Export WinStationRedirectErrorMessage (#2072)
Oleg Dubinskiy [Fri, 29 Nov 2019 13:51:04 +0000 (15:51 +0200)]
[WINSTA] Export WinStationRedirectErrorMessage (#2072)

Add export for WinStationRedirectErrorMessage() function in Winsta. We already have a stub for this function in dll/win32/winsta/logon.c, but for some reason it is not exported.
Required by MS Winlogon with Win32SS and some other needed dlls replaced. Now it fails due to missing WinStationCanLogonProceed, for which we currently haven't a stub.

This function has been introduced with Win2k3 SP1 (and exists in SP2 as well), see http://blog.airesoft.co.uk/apichanges/changes-Server2003%20SP0-To-Server2003%20SP1.xml#winsta.dll

JIRA issue: CORE-16458

4 years ago[RPCRT4] Stub RpcGetAuthorizationContextForClient (#2042)
Oleg Dubinskiy [Fri, 29 Nov 2019 13:19:56 +0000 (15:19 +0200)]
[RPCRT4] Stub RpcGetAuthorizationContextForClient (#2042)

## Purpose

Add a stub for RpcGetAuthorizationContextForClient function into rpcrt4, according to https://docs.microsoft.com/en-us/windows/win32/api/rpcasync/nf-rpcasync-rpcgetauthorizationcontextforclient (but with Wine-specific diffs in the syntax, according to the code guidelines: https://wiki.winehq.org/Submitting_Patches#Code_guidelines, since we're syncing rpcrt4 with Wine). Required by MS Winlogon with also Win32 subsystem and some other dlls replaced (aka ROS-Frankenstein), so after my changes it doesn't fail with our rpcrt4.dll at the system startup.
I think I also need to submit a patch in Wine, but it is a bit problematically to reproduce this error there, since Wine has no even winlogon.exe, and launching MS Winlogon in pair with profmap.dll, causes the crash due to unimplemented RtlSetProcessIsCritical function in ntdll (which is completely different than our). Ftr, our ntdll already has it implemented: https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/lib/rtl/process.c;hb=67c78d88c885ca92c72e2bcf59ddcf1d429096b1#l453 But with MS ntdll.dll, as far as I know, Wine will not work.

JIRA issue: CORE-16458

Although this PR doesn't fix that shutdown issue, it at least improves the situation with replaced system files and allows to investigate it more.

## Proposed changes

- Add a stub for the function in `dll/win32/rpcrt4/rpc_async.c`;
- Properly call it in `dll/win32/rpcrt4/rpcrt4.spec`.

4 years ago[BOOTDATA] Restore "CMD here" 'Extended' key, but commented out (#2093)
Serge Gautherie [Fri, 29 Nov 2019 13:13:59 +0000 (14:13 +0100)]
[BOOTDATA] Restore "CMD here" 'Extended' key, but commented out (#2093)

Addendum to db5a2fff
CORE-16519

4 years ago[DEVMGR] CClassNode::SetupNode(): Properly use Type (#2100)
Serge Gautherie [Fri, 29 Nov 2019 13:13:13 +0000 (14:13 +0100)]
[DEVMGR] CClassNode::SetupNode(): Properly use Type (#2100)

4 years ago[ATTRIB] Delete unused variable 'szText'
Katayama Hirofumi MZ [Fri, 29 Nov 2019 11:08:46 +0000 (20:08 +0900)]
[ATTRIB] Delete unused variable 'szText'

4 years ago[CMDUTILS][ATTRIB] Support folder attributes (#2103)
Katayama Hirofumi MZ [Fri, 29 Nov 2019 11:03:19 +0000 (20:03 +0900)]
[CMDUTILS][ATTRIB] Support folder attributes (#2103)

CORE-16538

4 years ago[KERNEL32] Stub GetSystemTimePreciseAsFileTime
Oleg Dubinskiy [Wed, 9 Oct 2019 15:40:22 +0000 (18:40 +0300)]
[KERNEL32] Stub GetSystemTimePreciseAsFileTime

4 years agoStub GetCurrentPackageId() (#1942)
William Kent [Fri, 29 Nov 2019 07:56:02 +0000 (02:56 -0500)]
Stub GetCurrentPackageId() (#1942)

* [KERNEL32] Add stub implementation for GetCurrentPackageId() function

This Windows 8+ function is called by WiX bundles (EXE-based installers) upon exit, if the export is present. If it is a stub in the spec, they will crash, even if they are coded to be compatible with Windows XP/ReactOS.
Also add GetCurrentPackageId() forwarder to apiset.

4 years ago[CHARMAP] LoadSettings(): Properly use RegQueryValueEx()
Serge Gautherie [Thu, 28 Nov 2019 16:11:27 +0000 (17:11 +0100)]
[CHARMAP] LoadSettings(): Properly use RegQueryValueEx()

4 years ago[OPENGLCFG] general.c: Fix overruns and warnings, improve code consistency (#1923)
Serge Gautherie [Fri, 29 Nov 2019 07:43:15 +0000 (08:43 +0100)]
[OPENGLCFG] general.c: Fix overruns and warnings, improve code consistency (#1923)

* [OPENGLCFG] dwNumDrivers: Fix related pOglDrivers[] overruns

Follow-up to e7b8f273094c9402ff1df3baa5841bf3518a3f02.

* [OPENGLCFG] dwNumDrivers: Sync related iKey to DWORD type

* [OPENGLCFG] Fix 2 MSVC-x64 'C4267' warnings about RegSetValueExW()

4 years ago[NETSTAT] Fix output formats and more (#1709)
Serge Gautherie [Fri, 29 Nov 2019 07:26:19 +0000 (08:26 +0100)]
[NETSTAT] Fix output formats and more (#1709)

* [NETSTAT] Restore expected output formats

"Revert" parts of bd3c852012943f7407f79edabea33f9ae4be9f49.

CORE-16119

* [NETSTAT] Improve default and ICMPv4 output formats

* [NETSTAT] Fix a few typos, in output strings

* [NETSTAT] Output usage to StdErr

* [NETSTAT] Be more explicit about unimplemented -b/-t/-v options

4 years ago[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files (#2102)
Katayama Hirofumi MZ [Fri, 29 Nov 2019 06:14:18 +0000 (15:14 +0900)]
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files (#2102)

PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045

4 years ago[SHELL32] Add desktop.ini more to some folders (#2101)
Katayama Hirofumi MZ [Fri, 29 Nov 2019 05:40:04 +0000 (14:40 +0900)]
[SHELL32] Add desktop.ini more to some folders (#2101)

Provides special icons for special folders by adding desktop.ini. CORE-10045

4 years ago[CMD_APITEST] Add attrib testcase (#2104)
Katayama Hirofumi MZ [Fri, 29 Nov 2019 02:13:17 +0000 (11:13 +0900)]
[CMD_APITEST] Add attrib testcase (#2104)

CORE-16284

4 years ago[URLMON] Delay-load advpack 2106/head
Mark Jansen [Thu, 28 Nov 2019 20:40:20 +0000 (21:40 +0100)]
[URLMON] Delay-load advpack
CORE-5007

4 years ago[USERENV] Improve Japanese translation (again)
Katayama Hirofumi MZ [Thu, 28 Nov 2019 09:50:45 +0000 (18:50 +0900)]
[USERENV] Improve Japanese translation (again)

4 years ago[USERENV] Improve Japanese translation
Katayama Hirofumi MZ [Thu, 28 Nov 2019 04:44:50 +0000 (13:44 +0900)]
[USERENV] Improve Japanese translation

4 years ago[SHELL32] Add SendTo DeskLink (Retry) (#2099)
Katayama Hirofumi MZ [Wed, 27 Nov 2019 11:09:19 +0000 (20:09 +0900)]
[SHELL32] Add SendTo DeskLink (Retry) (#2099)

CORE-12562

4 years ago[SENDMAIL][INCLUDE][INF] Add sendmail.dll for DeskLink (#2092)
Katayama Hirofumi MZ [Wed, 27 Nov 2019 10:26:49 +0000 (19:26 +0900)]
[SENDMAIL][INCLUDE][INF] Add sendmail.dll for DeskLink (#2092)

*.DeskLink file realizes SendTo Desktop (Create shortcut) in Windows. DeskLink is implemented in the sendmail.dll module. CORE-12562

4 years ago[SHELL32] Disable all controls during format and re-enable after format is complete...
Jared Smudde [Wed, 27 Nov 2019 08:18:50 +0000 (02:18 -0600)]
[SHELL32] Disable all controls during format and re-enable after format is complete. (#2098)

4 years ago[MEDIA][FONTS] Improve tahomabd.ttf (Latin and Punctuation) No.33
Katayama Hirofumi MZ [Wed, 27 Nov 2019 07:51:58 +0000 (16:51 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Latin and Punctuation) No.33

Tahoma Bold.
Version 0.019 khmz.
13px COMMERCIAL AT.
13px LATIN CAPITAL LETTER V.
13px LATIN CAPITAL LETTER W.
13px LATIN CAPITAL LETTER W WITH CIRCUMFLEX.
13px LATIN SMALL LETTER V.
13px LATIN SMALL LETTER W.
13px LATIN SMALL LETTER W WITH CIRCUMFLEX.
13px LATIN SMALL LETTER ETH.
CORE-8408

4 years ago[DEVMGR] m_DisplayName: Some functions need bytes, not chars
Serge Gautherie [Wed, 20 Nov 2019 21:13:48 +0000 (22:13 +0100)]
[DEVMGR] m_DisplayName: Some functions need bytes, not chars

Also:
Always use explicit _countof() and sizeof().
Add a missing 'Size' re-init.

4 years ago[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.32
Katayama Hirofumi MZ [Wed, 27 Nov 2019 07:15:09 +0000 (16:15 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.32

Tahoma Bold.
Version 0.018 khmz.
NUMBER SIGN.
CORE-8408

4 years ago[CABMAN] Fix 2 handle leaks, in case of error (#2044)
Serge Gautherie [Wed, 27 Nov 2019 00:49:08 +0000 (01:49 +0100)]
[CABMAN] Fix 2 handle leaks, in case of error (#2044)

CORE-11090

4 years ago[SETUPAPI] profile_items_callback(): Check LinkName (#2049)
Serge Gautherie [Wed, 27 Nov 2019 00:48:32 +0000 (01:48 +0100)]
[SETUPAPI] profile_items_callback(): Check LinkName (#2049)

CORE-11612

4 years ago[TRANSLATION] Update Indonesian translation (#2037)
Mas4hmad [Wed, 27 Nov 2019 00:40:51 +0000 (07:40 +0700)]
[TRANSLATION] Update Indonesian translation (#2037)

Update Indonesian translation for AVIFILE, CLIPBRD and USERENV.

4 years ago[BOOTLIB] Remove a useless 'FontDirectory' check as it becomes always valid (!= NULL...
Hermès Bélusca-Maïto [Wed, 27 Nov 2019 00:30:56 +0000 (01:30 +0100)]
[BOOTLIB] Remove a useless 'FontDirectory' check as it becomes always valid (!= NULL) through the function.
CORE-11590

Adapted from Victor Martinez patch & Serge Gautherie PR #2062

4 years ago[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.31
Katayama Hirofumi MZ [Wed, 27 Nov 2019 00:06:21 +0000 (09:06 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.31

Tahoma Bold.
Version 0.017 khmz.
GRAVE ACCENT.
CORE-8408

4 years ago[COMCTL32] Minimize Wine diff (#2035)
Serge Gautherie [Tue, 26 Nov 2019 22:27:21 +0000 (23:27 +0100)]
[COMCTL32] Minimize Wine diff (#2035)

Addendum to b931f643e35e6a23dbef99e785804039ea579b6a.

CORE-16466

4 years ago[MMC] DoSaveFileAs(): Respect szPath size (#2068)
Serge Gautherie [Tue, 26 Nov 2019 22:24:51 +0000 (23:24 +0100)]
[MMC] DoSaveFileAs(): Respect szPath size (#2068)

CORE-11688

4 years ago[SHELL32] Follow-up of #2076 (#2091)
Katayama Hirofumi MZ [Tue, 26 Nov 2019 12:45:58 +0000 (21:45 +0900)]
[SHELL32] Follow-up of #2076 (#2091)

Fix EXE and SCR file icons. CORE-16533

4 years ago[SHELL32] Make SHFormatDrive multi-thread (#2080)
Katayama Hirofumi MZ [Tue, 26 Nov 2019 09:26:25 +0000 (18:26 +0900)]
[SHELL32] Make SHFormatDrive multi-thread (#2080)

CORE-12756

4 years ago[SHELL32] Improve DragEnter of CFSDropTarget (#2073)
Katayama Hirofumi MZ [Tue, 26 Nov 2019 08:34:24 +0000 (17:34 +0900)]
[SHELL32] Improve DragEnter of CFSDropTarget (#2073)

Reduce failures of DragDrop testcase. CORE-11238

4 years ago[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.30
Katayama Hirofumi MZ [Tue, 26 Nov 2019 00:41:46 +0000 (09:41 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.30

Tahoma Bold.
Version 0.016 khmz.
PUNCTUATIONS.
CORE-8408

4 years ago[NTOS] Revert pool debugging code
Timo Kreuzer [Mon, 25 Nov 2019 18:32:06 +0000 (19:32 +0100)]
[NTOS] Revert pool debugging code

Revert "[NTOS] On DBG builds, fill pool allocations with 0xCD and freed pool with 0xDD"
This reverts commit 24f240be8a5f7b09a0c122f40384fc63576accfa.

Revert "[NTOS] Add compile time option to trace callers of pool allocations"
This reverts commit 8b20755040754506f3f12a30857f8edc5bf83f33.

Revert "WIP"
This reverts commit 8cfd5c601f354625a11ee097984cda0c90f93889.

4 years ago[SYSDM] IMGINFO: Fix 'iPLanes' typo (#2059)
Serge Gautherie [Mon, 25 Nov 2019 17:50:03 +0000 (18:50 +0100)]
[SYSDM] IMGINFO: Fix 'iPLanes' typo (#2059)

4 years ago[HALX86] Remove a now useless ASSERT() (#2089)
Serge Gautherie [Mon, 25 Nov 2019 17:29:03 +0000 (18:29 +0100)]
[HALX86] Remove a now useless ASSERT() (#2089)

By construction now the assertion will always be verified.
Addendum to 5887b170.

4 years ago[NDK][NTOS:INBV] Remove non-exported INBV functions from NDK; do some cleanup in...
Hermès Bélusca-Maïto [Mon, 25 Nov 2019 14:54:45 +0000 (15:54 +0100)]
[NDK][NTOS:INBV] Remove non-exported INBV functions from NDK; do some cleanup in INBV headers; label both InbvSetProgressBarSubset() and InbvSetProgressBarCoordinates() as INIT_FUNCTION since they are used only for the boot splash. And fix MSVC build.

4 years ago[NDK] Addendum to 592f01a5, fix build.
Hermès Bélusca-Maïto [Mon, 25 Nov 2019 01:26:51 +0000 (02:26 +0100)]
[NDK] Addendum to 592f01a5, fix build.

4 years ago[HALX86] Fix the "ASSERT(j < 32);" problem in HalpStoreAndClearIopm() encountered...
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 21:58:12 +0000 (22:58 +0100)]
[HALX86] Fix the "ASSERT(j < 32);" problem in HalpStoreAndClearIopm() encountered from time to time.
CORE-11921 CORE-13715

(Regression introduced by commit 2e1b82cf, r44841.)

In some cases the number of valid (!= 0xFFFF) entries in the IOPM can be
larger than the assumed size (32) of the entries cache. The maximum
possible number of entries is equal to IOPM_SIZE / sizeof(USHORT).

A way to reproduce the problem is as follows: start ReactOS in debugging
mode using '/DEBUG /DEBUGPORT=SCREEN' . Then manage to break into the
debugger exactly during the execution of Ke386CallBios() triggered by
display initialization (for example in my case, while a video driver was
being initialized via the HwInitialize() call done by videoport inside
IntVideoPortDispatchOpen() ).

When this happens, a "concurrent" execution between Ke386CallBios() and
the HAL function HalpStoreAndClearIopm() takes place. This is due to the
fact that when entering the debugger in SCREEN mode, the following
call-chain holds:
InbvResetDisplay() -> VidResetDisplay() -> HalResetDisplay() ->
HalpBiosDisplayReset() -> HalpSetupRealModeIoPermissionsAndTask() ->
HalpStoreAndClearIopm().

However, the code of Ke386CallBios() has reset the IOPM contents with
all zeroes instead of 0xFFFF, and this triggers the caching of all the
entries of the IOPM by HalpStoreAndClearIopm(), whose number is greater
than the wrongly assumed number of '32'.

As Thomas explained to me, "Windows supports [the maximum number of IOPM entries],
it just makes a full copy of the table instead of this indexed partial copy."

And I agree that this overengineered so-called "optimization" committed
in 2e1b82cf contributed in introducing an unnecessary bug and making the
code less clear. Also it makes the IOPM cache larger than the necessary
size by twice as much. Finally, Ke386CallBios() also caches IOPM entries
before doing a 16-bit call, and obviously uses the more straightforward
way of doing a direct copy of the IOPM table (using RtlCopyMemory()).

I wonder what kind of "optimization" this tried to achieve, knowing that
we are not doing like thousands of 32->16bit BIOS interrupt calls per second
in ReactOS...

4 years ago[HALX86] Trailing whitespace fixes only.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 21:05:37 +0000 (22:05 +0100)]
[HALX86] Trailing whitespace fixes only.

4 years ago[NTOS:KE] Explicitly use IOPM_SIZE for initializing the IO map, that is indeed also...
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 21:56:55 +0000 (22:56 +0100)]
[NTOS:KE] Explicitly use IOPM_SIZE for initializing the IO map, that is indeed also equal to PAGE_SIZE * 2 but is self-documented.

4 years ago[NTOS:KE] Minor formatting fixes.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 21:08:35 +0000 (22:08 +0100)]
[NTOS:KE] Minor formatting fixes.

4 years ago[NTOS:INBV] InbvEnableBootDriver() is an export, thus can be called at any time,...
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:59:30 +0000 (21:59 +0100)]
[NTOS:INBV] InbvEnableBootDriver() is an export, thus can be called at any time, therefore it must NOT be an INIT_FUNCTION.

4 years ago[VIDEOPRT] Implement VideoPortReadStateEvent().
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:26:26 +0000 (21:26 +0100)]
[VIDEOPRT] Implement VideoPortReadStateEvent().

4 years ago[VIDEOPRT] Use ExFreePoolWithTag() + Add some ASSERTs.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 23:32:28 +0000 (00:32 +0100)]
[VIDEOPRT] Use ExFreePoolWithTag() + Add some ASSERTs.

4 years ago[VIDEOPRT] Code formatting only.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 23:29:36 +0000 (00:29 +0100)]
[VIDEOPRT] Code formatting only.

4 years ago[WIN32K] Add some validity checks in PDEVOBJ_vReference() and use it instead of expli...
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:22:21 +0000 (21:22 +0100)]
[WIN32K] Add some validity checks in PDEVOBJ_vReference() and use it instead of explicitly manipulating ppdev->cPdevRefs.

4 years ago[WIN32K] Use RtlString* routines.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:51:22 +0000 (21:51 +0100)]
[WIN32K] Use RtlString* routines.

4 years ago[WIN32K] Code formatting.
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:19:14 +0000 (21:19 +0100)]
[WIN32K] Code formatting.

4 years ago[PCIX][BLUE] Don't hardcode values in KeDelayExecutionThread() call. Remove deprecate...
Hermès Bélusca-Maïto [Sun, 24 Nov 2019 20:13:35 +0000 (21:13 +0100)]
[PCIX][BLUE] Don't hardcode values in KeDelayExecutionThread() call. Remove deprecated code.

4 years ago[INF] Add the docking station device
Eric Kohl [Sun, 24 Nov 2019 18:08:20 +0000 (19:08 +0100)]
[INF] Add the docking station device

4 years agoWIP
Timo Kreuzer [Sat, 13 Jul 2019 13:28:44 +0000 (15:28 +0200)]
WIP

4 years ago[NTOS] Add compile time option to trace callers of pool allocations
Timo Kreuzer [Thu, 8 Mar 2018 11:25:19 +0000 (12:25 +0100)]
[NTOS] Add compile time option to trace callers of pool allocations

4 years ago[NTOS] On DBG builds, fill pool allocations with 0xCD and freed pool with 0xDD
Timo Kreuzer [Sat, 29 Jun 2019 10:06:04 +0000 (12:06 +0200)]
[NTOS] On DBG builds, fill pool allocations with 0xCD and freed pool with 0xDD

This matches what the MSVC runtime does with heap allocations on debug builds.

4 years ago[SHELL32_APITEST] DragDrop: Add NULL check of pDropTarget
Katayama Hirofumi MZ [Sun, 24 Nov 2019 13:48:06 +0000 (22:48 +0900)]
[SHELL32_APITEST] DragDrop: Add NULL check of pDropTarget

4 years ago[HNETCFG] CORE-16372 Jansen's hack
Katayama Hirofumi MZ [Sun, 24 Nov 2019 13:36:49 +0000 (22:36 +0900)]
[HNETCFG] CORE-16372 Jansen's hack

4 years ago[SHELL32] Set default exe icon (#2076)
Katayama Hirofumi MZ [Sun, 24 Nov 2019 10:26:32 +0000 (19:26 +0900)]
[SHELL32] Set default exe icon (#2076)

The default icon of an exe file was empty if no icon available from exe.
CORE-10480

4 years ago[SHELL32] Shift-Right-Click patch: Plan B (#2082)
Katayama Hirofumi MZ [Sun, 24 Nov 2019 10:22:23 +0000 (19:22 +0900)]
[SHELL32] Shift-Right-Click patch: Plan B (#2082)

Enable "CMD here" without Shift key. CORE-16519

4 years ago[MEDIA][FONTS] Improve tahoma.ttf (Punctuations) No.29
Katayama Hirofumi MZ [Sun, 24 Nov 2019 10:12:31 +0000 (19:12 +0900)]
[MEDIA][FONTS] Improve tahoma.ttf (Punctuations) No.29

Tahoma font.
Version 0.017 khmz.
PUNCTUATIONS.
CORE-8408

4 years ago[CMAKE] Turn printf format warnings (C4313 and C4477) into errors
Timo Kreuzer [Sat, 20 Jul 2019 15:34:24 +0000 (17:34 +0200)]
[CMAKE] Turn printf format warnings (C4313 and C4477) into errors

4 years ago[NETREG] Fix a 64bit printf format warning
Timo Kreuzer [Sat, 23 Nov 2019 16:48:16 +0000 (17:48 +0100)]
[NETREG] Fix a 64bit printf format warning

4 years ago[CMAKE] Disable EH4 for x64 and VS versions 16.3+
Timo Kreuzer [Sat, 23 Nov 2019 16:37:59 +0000 (17:37 +0100)]
[CMAKE] Disable EH4 for x64 and VS versions 16.3+

This fixes x64 build with latest VS 2019
See https://developercommunity.visualstudio.com/content/problem/746534/visual-c-163-runtime-uses-an-unsupported-api-for-u.html

4 years ago[MEDIA][FONTS] Improve tahomabd.ttf (Latin, Greek and Cyrillic) No.28
Katayama Hirofumi MZ [Sun, 24 Nov 2019 02:24:30 +0000 (11:24 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Latin, Greek and Cyrillic) No.28

Tahoma Bold.
Version 0.015 khmz.
13px bitmap glyphs are totally improved.
15px bitmap glyphs are deleted.
DIGITS.
CORE-8408

4 years ago[DNSAPI][DNSRSLVR] Parse the hosts file when the resolver is initializing
Eric Kohl [Sat, 23 Nov 2019 16:07:59 +0000 (17:07 +0100)]
[DNSAPI][DNSRSLVR] Parse the hosts file when the resolver is initializing

- Move the hosts file handling from dnsapi.dll to the resolver service. Now, the hosts file is no longer parsed on each query.
- Add support for DNS_QUERY_WIRE_ONLY and DNS_QUERY_NO_WIRE_QUERY flags to R_ResolverQuery.
- GetCurrentTimeInSeconds() should return DWORD instead of DNS_STATUS.

4 years ago[MOUNTMGR] Fix out of bounds write
Mark Jansen [Sat, 23 Nov 2019 15:23:28 +0000 (16:23 +0100)]
[MOUNTMGR] Fix out of bounds write
CORE-16530

4 years ago[RPCRT4_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:12:54 +0000 (12:12 +0100)]
[RPCRT4_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[RPCRT4] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:12:31 +0000 (12:12 +0100)]
[RPCRT4] Sync with Wine Staging 4.18. CORE-16441

4 years ago[PSDK] Update rpcndr.h. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:12:08 +0000 (12:12 +0100)]
[PSDK] Update rpcndr.h. CORE-16441

4 years ago[INCLUDE/WINE] Add __FINALLY_CTX in the context of our PSEH library. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:11:45 +0000 (12:11 +0100)]
[INCLUDE/WINE] Add __FINALLY_CTX in the context of our PSEH library. CORE-16441

4 years ago[RICHED20_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:11:20 +0000 (12:11 +0100)]
[RICHED20_WINETEST] Sync with Wine Staging 4.18. CORE-16441

4 years ago[RICHED20] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 23 Nov 2019 11:10:55 +0000 (12:10 +0100)]
[RICHED20] Sync with Wine Staging 4.18. CORE-16441