reactos.git
2 months ago[CSRSRV] CsrApiHandleConnectionRequest(): Remove ASSERT() redundant condition (#2858)
Serge Gautherie [Thu, 4 Mar 2021 21:54:00 +0000 (22:54 +0100)]
[CSRSRV] CsrApiHandleConnectionRequest(): Remove ASSERT() redundant condition (#2858)

Detected by Cppcheck: redundantCondition.
Addendum to 835f3ef1.

2 months ago[FREELDR] LoadAndBootWindowsCommon(): Use UNREACHABLE, on success
Serge Gautherie [Thu, 12 Nov 2020 00:22:46 +0000 (01:22 +0100)]
[FREELDR] LoadAndBootWindowsCommon(): Use UNREACHABLE, on success

KiSystemStartup() is DECLSPEC_NORETURN.

2 months ago[NTOS:KE] KiIdleLoop(): Propagate DECLSPEC_NORETURN to callers
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:KE] KiIdleLoop(): Propagate DECLSPEC_NORETURN to callers

2 months ago[NTOS:KE] KiIdleLoop(): Add DECLSPEC_NORETURN, Remove FASTCALL
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:KE] KiIdleLoop(): Add DECLSPEC_NORETURN, Remove FASTCALL

2 months ago[DBGHELP] Fix use of unix path
Jérôme Gardou [Thu, 4 Mar 2021 16:38:33 +0000 (17:38 +0100)]
[DBGHELP] Fix use of unix path

2 months ago[NTDLL_APITEST] Implement testcase for NtCompareTokens
George Bișoc [Sat, 6 Feb 2021 17:22:03 +0000 (18:22 +0100)]
[NTDLL_APITEST] Implement testcase for NtCompareTokens

2 months ago[NTOS:SE] Complete the SepCompareTokens implementation
George Bișoc [Sun, 17 Jan 2021 20:46:30 +0000 (21:46 +0100)]
[NTOS:SE] Complete the SepCompareTokens implementation

* Implement SepCompareSidAndAttributesFromTokens and SepComparePrivilegeAndAttributesFromTokens functions for array elements comparison
* Implement the token comparison code in SepCompareTokens function
* Add a missing PAGED_CODE() in SepCompareTokens as most of the token comparison code is paged
* Use SAL annotations for SepCompareTokens and NtCompareTokens

2 months ago[BROWSEUI_APITEST] Fix abnormal termination on fn2 == NULL
Katayama Hirofumi MZ [Thu, 4 Mar 2021 05:42:04 +0000 (14:42 +0900)]
[BROWSEUI_APITEST] Fix abnormal termination on fn2 == NULL

The DoWordBreakProc function crashed.
CORE-9281

2 months ago[NTOS:PS] Guard the quota in a spin lock (#3419)
George Bișoc [Thu, 4 Mar 2021 01:43:30 +0000 (02:43 +0100)]
[NTOS:PS] Guard the quota in a spin lock (#3419)

Prior to acquiring a quota from the process and do whatever it's needed to do (charge it or return it back), we must guard ourselves with a spinlock so that we may not get into potential race conditions. In Windows Server 2003, PspGivebackQuota and PspExpandQuota do the same thing and they're the equivalent to PspReturnProcessQuotaSpecifiedPool and PspChargeProcessQuotaSpecifiedPool in our codebase.

2 months ago[BROWSEUI_APITEST] Strengthen IAutoComplete on WM_KEYDOWN (#3500)
Katayama Hirofumi MZ [Thu, 4 Mar 2021 00:35:44 +0000 (09:35 +0900)]
[BROWSEUI_APITEST] Strengthen IAutoComplete on WM_KEYDOWN (#3500)

- Simplify the test mechanism.
- Add more tests for WM_KEYDOWN message.

CORE-9281

2 months ago[SDK:RTL] Statically initialize RtlCriticalSectionList
Jérôme Gardou [Wed, 3 Mar 2021 13:09:08 +0000 (14:09 +0100)]
[SDK:RTL] Statically initialize RtlCriticalSectionList

This might be used before RtlpInitDeferedCriticalSection gets called

2 months ago[NTOS:KD] KdpDebugLogInit(): Close the thread handle
Serge Gautherie [Thu, 12 Nov 2020 00:22:46 +0000 (01:22 +0100)]
[NTOS:KD] KdpDebugLogInit(): Close the thread handle

Addendum to 07dc415 (r43331).

2 months ago[NTOS:KD] KdpLoggerThread(): Assert being in kernel mode
Serge Gautherie [Thu, 12 Nov 2020 00:22:46 +0000 (01:22 +0100)]
[NTOS:KD] KdpLoggerThread(): Assert being in kernel mode

to be explicit that using Nt*() is safe.

Follow-up to 9537653.

2 months agothis seem to be the only combination which works on msbuild-msvc
Victor Perevertkin [Wed, 3 Mar 2021 02:00:33 +0000 (05:00 +0300)]
this seem to be the only combination which works on msbuild-msvc

2 months ago[FREELDR] Use target_link_options instead of add_target_link_flags
Jérôme Gardou [Wed, 3 Feb 2021 19:07:57 +0000 (20:07 +0100)]
[FREELDR] Use target_link_options instead of add_target_link_flags

CORE-17423

2 months ago[CMAKE] Define _SBCS when using VS generator
Jérôme Gardou [Wed, 3 Feb 2021 17:35:12 +0000 (18:35 +0100)]
[CMAKE] Define _SBCS when using VS generator

CORE-17423

2 months ago[FREELDR] Use decimal numbers for section & file alignment
Jérôme Gardou [Wed, 3 Feb 2021 16:20:41 +0000 (17:20 +0100)]
[FREELDR] Use decimal numbers for section & file alignment

CORE-17423

2 months ago[BOOTMGFW] Explicitly disable NX compatibility
Jérôme Gardou [Wed, 3 Feb 2021 16:16:05 +0000 (17:16 +0100)]
[BOOTMGFW] Explicitly disable NX compatibility

CORE-17423

2 months ago[CMAKE] Explicitly declare libcntpr as a static lib
Jérôme Gardou [Tue, 2 Feb 2021 18:21:06 +0000 (19:21 +0100)]
[CMAKE] Explicitly declare libcntpr as a static lib

2 months ago[CRT] Declare strlen & wcslen as _CRTIMP
Jérôme Gardou [Tue, 2 Feb 2021 16:59:42 +0000 (17:59 +0100)]
[CRT] Declare strlen & wcslen as _CRTIMP

2 months ago[CMAKE] Get rid of add_object_library
Jérôme Gardou [Tue, 2 Feb 2021 15:33:15 +0000 (16:33 +0100)]
[CMAKE] Get rid of add_object_library

It's not needed anymore

2 months ago[SHLWAPI] Use an object library to separate C & C++ compilation units
Jérôme Gardou [Tue, 2 Feb 2021 15:18:04 +0000 (16:18 +0100)]
[SHLWAPI] Use an object library to separate C & C++ compilation units

CORE-17423

2 months ago[BOOTMGFW] Explicitly disable dynamic base
Jérôme Gardou [Tue, 2 Feb 2021 15:04:13 +0000 (16:04 +0100)]
[BOOTMGFW] Explicitly disable dynamic base

CORE-17423

2 months ago[GITHUB] Add MSBUILD CI action
Jérôme Gardou [Wed, 27 Jan 2021 08:46:27 +0000 (09:46 +0100)]
[GITHUB] Add MSBUILD CI action

2 months ago[CMAKE] Disable policy CMP0091 and set /MT flag explicitly for Visual Studio generator
Jérôme Gardou [Fri, 22 Jan 2021 11:11:34 +0000 (12:11 +0100)]
[CMAKE] Disable policy CMP0091 and set /MT flag explicitly for Visual Studio generator

2 months ago[CMAKE] Preprocess the ASM files but let msbuild handle their actual compilation
Jérôme Gardou [Fri, 22 Jan 2021 10:28:11 +0000 (11:28 +0100)]
[CMAKE] Preprocess the ASM files but let msbuild handle their actual compilation

CORE-17423

2 months ago[CMAKE] Use ASM_MASM language when building with MSVC toolchain
Jérôme Gardou [Thu, 21 Jan 2021 09:20:21 +0000 (10:20 +0100)]
[CMAKE] Use ASM_MASM language when building with MSVC toolchain

CORE-17423

2 months ago[BOOTMGFW] Disable EFI bootloader compilation
Victor Perevertkin [Wed, 3 Mar 2021 01:59:12 +0000 (04:59 +0300)]
[BOOTMGFW] Disable EFI bootloader compilation

Don't pretend we are supporting UEFI, we are not

2 months ago[DEVMGR][NETID] Update PT translation (#3487)
Jose Carlos Jesus [Wed, 3 Mar 2021 03:18:15 +0000 (03:18 +0000)]
[DEVMGR][NETID] Update PT translation (#3487)

And readjust objects size to fit all text in Driver tab.

2 months ago[CMAKE] target_compile_definitions() calls: Remove (now) useless '-D' (#3490)
Serge Gautherie [Wed, 3 Mar 2021 03:16:02 +0000 (04:16 +0100)]
[CMAKE] target_compile_definitions() calls: Remove (now) useless '-D' (#3490)

Documented as automatically removed, since CMake 3.12.4 at least.
https://cmake.org/cmake/help/v3.12/command/target_compile_definitions.html

2 months ago[CMAKE] Use remove_target_compile_option when disabling manually enabled warnings
Victor Perevertkin [Wed, 3 Mar 2021 01:54:37 +0000 (04:54 +0300)]
[CMAKE] Use remove_target_compile_option when disabling manually enabled warnings

2 months ago[GITHUB] Choose LLVM version manually
Victor Perevertkin [Wed, 3 Mar 2021 02:08:12 +0000 (05:08 +0300)]
[GITHUB] Choose LLVM version manually

2 months ago[NTOS:PS] Implement PS_QUOTA_TYPE and let the quota code use it (#3389)
George Bișoc [Tue, 2 Mar 2021 19:09:58 +0000 (20:09 +0100)]
[NTOS:PS] Implement PS_QUOTA_TYPE and let the quota code use it (#3389)

This will replace the PoolIndex variable and as such we'll only be using the PS_QUOTA_TYPE enumeration, as Windows does. Both QuotaEntry, QuotaUsage and QuotaPeak depend explicitly or implicitly on this enumeration. Further details about this enum can be found in the following articles.
https://www.geoffchappell.com/studies/windows/km/ntoskrnl/api/ps/psquota/type.htm?tx=68,143
https://www.geoffchappell.com/studies/windows/km/ntoskrnl/api/ps/psquota/block.htm?tx=68,142,143
https://www.geoffchappell.com/studies/windows/km/ntoskrnl/inc/ps/eprocess/index.htm (see QuotaPeak and QuotaUsage)

2 months ago[SHELL32] Determine if the FS is of type FATX (#3398)
George Bișoc [Tue, 2 Mar 2021 18:37:31 +0000 (19:37 +0100)]
[SHELL32] Determine if the FS is of type FATX (#3398)

FATX is listed as a filesystem for format within the list but it's classed out from current proposed filesystems, thus spamming the debug output and not allowing to actually format a storage drive with this FS.
CORE-17272

2 months ago[NTDLL_APITEST] Ensure that some noticeable time has passed since process creation...
Colin Finck [Sat, 20 Feb 2021 16:39:23 +0000 (17:39 +0100)]
[NTDLL_APITEST] Ensure that some noticeable time has passed since process creation to fix a flaky test.

2 months ago[SOLITAIRE] Update Polish [pl-PL] translation (#3496)
Piotr Hetnarowicz [Tue, 2 Mar 2021 18:10:26 +0000 (19:10 +0100)]
[SOLITAIRE] Update Polish [pl-PL] translation (#3496)

2 months ago[SHELL32] Improve Polish [pl-PL] translation (#3494)
Piotr Hetnarowicz [Tue, 2 Mar 2021 18:09:53 +0000 (19:09 +0100)]
[SHELL32] Improve Polish [pl-PL] translation (#3494)

2 months ago[RTL_VISTA] CMakeLists.txt: Fix 'rtl' copypasta (#3489)
Serge Gautherie [Tue, 2 Mar 2021 18:06:17 +0000 (19:06 +0100)]
[RTL_VISTA] CMakeLists.txt: Fix 'rtl' copypasta (#3489)

Addendum to 6119239.

2 months ago[ADVAPI32] In RegSetValueExW, do not fail if we fault when checking for ending NUL...
Jérôme Gardou [Tue, 2 Mar 2021 14:39:25 +0000 (15:39 +0100)]
[ADVAPI32] In RegSetValueExW, do not fail if we fault when checking for ending NUL character

2 months ago[WS2_32] Fix error handling on non-existing registry keys
Jérôme Gardou [Tue, 2 Mar 2021 13:38:36 +0000 (14:38 +0100)]
[WS2_32] Fix error handling on non-existing registry keys

2 months ago[NTOS:KE] Generate proper frame info for trap handler in GCC builds
Jérôme Gardou [Tue, 2 Mar 2021 12:03:37 +0000 (13:03 +0100)]
[NTOS:KE] Generate proper frame info for trap handler in GCC builds

CORE-8531

2 months ago[SDK:INCLUDE] Define KTRAP_FRAME_CS
Jérôme Gardou [Tue, 2 Mar 2021 12:01:50 +0000 (13:01 +0100)]
[SDK:INCLUDE] Define KTRAP_FRAME_CS

2 months ago[SDK] Properly put assembly debug info into .debug_frame section
Jérôme Gardou [Tue, 2 Mar 2021 11:58:21 +0000 (12:58 +0100)]
[SDK] Properly put assembly debug info into .debug_frame section

For some reason, the default is to put it into .eh_frame where objcopy & al happily ignore them

2 months ago[BROWSEUI_APITEST] Strengthen IAutoComplete testcase on extended LV style (#3499)
Katayama Hirofumi MZ [Tue, 2 Mar 2021 09:05:32 +0000 (18:05 +0900)]
[BROWSEUI_APITEST] Strengthen IAutoComplete testcase on extended LV style (#3499)

Test the extended list-view style of the listview. CORE-9281

2 months ago[SDK][ATL] Fix CWindow::GetWindowText method of BSTR (#3498)
Katayama Hirofumi MZ [Tue, 2 Mar 2021 08:50:00 +0000 (17:50 +0900)]
[SDK][ATL] Fix CWindow::GetWindowText method of BSTR (#3498)

- Fix generic text mapping for GetWindowText and GetWindowTextLength functions.
- Fix the position.
- Fix the length.
- Fail elegantly if necessary.

CORE-9281

2 months ago[BROWSEUI_APITEST] Follow-up of #3493
Katayama Hirofumi MZ [Mon, 1 Mar 2021 22:36:55 +0000 (07:36 +0900)]
[BROWSEUI_APITEST] Follow-up of #3493

2 months ago[BROWSEUI_APITEST] Add IAutoComplete testcase (#3493)
Katayama Hirofumi MZ [Mon, 1 Mar 2021 22:25:31 +0000 (07:25 +0900)]
[BROWSEUI_APITEST] Add IAutoComplete testcase (#3493)

Add tests for IAutoComplete objects, especially on the drop-down window and related controls.
CORE-9281

2 months ago[SHIMGVW] Improve zooming feature and realize image edit (#3473)
Carlo Bramini [Mon, 1 Mar 2021 14:40:06 +0000 (15:40 +0100)]
[SHIMGVW] Improve zooming feature and realize image edit (#3473)

* [SHIMGVW] Add OLE32 for CoInitializeEx()
* Implemented support for effective image size (100%).
* Fix bug that could leave one of the zoom buttons if 100% size button is now pressed.
* Replace a CreateWindowEx() with CreateWindowExW().
* Added stub for image delete function.
* Implemented support for 'Modify' button.
* [SHIMGVW] Added CoUninitialize()
* [SHIMGVW] Pair CoUninitialize with CoInitializeEx

2 months ago[SOLITAIRE] Add undo feature & fix occasionally invisible cards (#3422)
Tibor Lajos Füzi [Sun, 28 Feb 2021 21:31:19 +0000 (22:31 +0100)]
[SOLITAIRE] Add undo feature & fix occasionally invisible cards (#3422)

Two issues are addressed:

CORE-2189: missing undo feature

Works the same way as solitaire in windows xp:
- only 1 action can be undone;
- the player gets -2 points in standard score mode;
- the undo action resets when the player clicks on a row stack to turn the top card.

CORE-11148: invisible cards

This happens in 3-card mode, when only 1 card left in the deck. The fix for this is to modify the pile stack to contain all the face-up cards. It was actually already in the code somewhere else, so I turned it into a separate function.

2 months ago[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI...
Arnav Bhatt [Sun, 28 Feb 2021 11:03:35 +0000 (11:03 +0000)]
[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI log off dialog box (#3399)

Implement the re-worked shut down dialog box as well as implementing fancy log off dialog box.
- Fancy shut down dialog box has been redesigned to be more comparable to of XP.
- Implement features that were missing earlier.
- Implement the fancy log off dialog which is more comparable to of XP.

2 months ago[LSASRV][SECUR32] Fix the naming mess
Eric Kohl [Sun, 28 Feb 2021 10:03:07 +0000 (11:03 +0100)]
[LSASRV][SECUR32] Fix the naming mess

Rename Untrusted to TrustredCaller in LSA_CONNECTION_INFO and LSAP_LOGON_CONTEXT in order to clarify the meaning of the variable.

2 months ago[ATL_APITEST] Fixup of #3492; fix SubclassWindow testcase
Katayama Hirofumi MZ [Sun, 28 Feb 2021 04:06:49 +0000 (13:06 +0900)]
[ATL_APITEST] Fixup of #3492; fix SubclassWindow testcase

Fix the tests at Line 359 and 403.
CORE-9281

2 months ago[SDK][ATL] Implement UnsubclassWindow methods (#3492)
Katayama Hirofumi MZ [Sun, 28 Feb 2021 03:45:16 +0000 (12:45 +0900)]
[SDK][ATL] Implement UnsubclassWindow methods (#3492)

I want UnsubclassWindow methods.
- Implement CWindowImpl::UnsubclassWindow method.
- Implement CContainedWindowT::UnsubclassWindow method.
- Add SubclassWindow testcase to atl_apitest test program.
- Fix generic text mapping of <atlwin.h>.
CORE-9281

2 months ago[LSASRV] Fix a typo in the trusted user identification
Eric Kohl [Sun, 28 Feb 2021 00:57:43 +0000 (01:57 +0100)]
[LSASRV] Fix a typo in the trusted user identification

2 months ago[WKSSVC] Get version info and authentication package on startup
Eric Kohl [Sat, 27 Feb 2021 18:07:47 +0000 (19:07 +0100)]
[WKSSVC] Get version info and authentication package on startup

2 months ago[SDK][INCLUDE] layout.h: Delete an assertion for window style
Katayama Hirofumi MZ [Sat, 27 Feb 2021 13:59:00 +0000 (22:59 +0900)]
[SDK][INCLUDE] layout.h: Delete an assertion for window style

WS_SIZEBOX or WS_THICKFRAME. CORE-9281

2 months ago[NTOS:KD] Use Zw* syscall variants
Jérôme Gardou [Fri, 26 Feb 2021 07:44:51 +0000 (08:44 +0100)]
[NTOS:KD] Use Zw* syscall variants

The log file can be (re-)initialized when previous mode is User-Mode,
thus the calls fail on probing input parameters

2 months ago[NTOS:MM] Do not chunk-read file when we are the modified-page-writer thread
Jérôme Gardou [Tue, 23 Feb 2021 10:07:35 +0000 (11:07 +0100)]
[NTOS:MM] Do not chunk-read file when we are the modified-page-writer thread

2 months ago[NTOS:MM] Do not chunk-read files marked with FO_RANDOM_ACCESS
Jérôme Gardou [Tue, 16 Feb 2021 10:27:19 +0000 (11:27 +0100)]
[NTOS:MM] Do not chunk-read files marked with FO_RANDOM_ACCESS

2 months ago[BROWSEUI] Fix and small improvement (#3486)
Katayama Hirofumi MZ [Thu, 25 Feb 2021 11:36:20 +0000 (20:36 +0900)]
[BROWSEUI] Fix and small improvement (#3486)

Fix a mistake in CAutoComplete PR #3472 (6bfb76b) and improve.
- Fix confusion between m_hwndEdit and hwndEdit.
- Delete extra this-> codes.
CORE-9281

2 months ago[SDK][INCLUDE] Erase files of incorrect commit
Katayama Hirofumi MZ [Thu, 25 Feb 2021 00:21:13 +0000 (09:21 +0900)]
[SDK][INCLUDE] Erase files of incorrect commit

Delete files at mistaken commit:
https://github.com/reactos/reactos/commit/0efd7b97643c0a6a60d322e902de29e6d851f2a2

rm sdk/include/host/cmake_install.cmake
rm sdk/include/reactos/buildno.h
rm sdk/include/reactos/version.h

2 months ago[SDK][INCLUDE] Strengthen and improve layout.h
Katayama Hirofumi MZ [Thu, 25 Feb 2021 00:12:47 +0000 (09:12 +0900)]
[SDK][INCLUDE] Strengthen and improve layout.h

- Refreshing STATIC controls.
- In LayoutInit function, if cLayouts parameter was negative, then don't use size grip.

2 months ago[TASKLIST] Implement tasklist command-line utility (#3440)
He Yang [Wed, 24 Feb 2021 10:05:15 +0000 (18:05 +0800)]
[TASKLIST] Implement tasklist command-line utility (#3440)

Add command-line program "tasklist" for ReactOS.
It works fine on Windows as well.

2 months ago[BROWSEUI]Update PT translation
Jose Carlos Jesus [Wed, 24 Feb 2021 00:38:48 +0000 (00:38 +0000)]
[BROWSEUI]Update PT translation

2 months ago[BROWSEUI] Refactoring CAutoComplete Part 1 (#3472)
Katayama Hirofumi MZ [Mon, 22 Feb 2021 21:07:09 +0000 (06:07 +0900)]
[BROWSEUI] Refactoring CAutoComplete Part 1 (#3472)

- Expand tabs to spaces in CAutoComplete.h.
- Add m_ prefix to every member variable.
CORE-9281

2 months ago[FREELDR] DetectPnpBios(): Add 'i' to ERR() debug print (#3465)
Serge Gautherie [Mon, 22 Feb 2021 18:10:27 +0000 (19:10 +0100)]
[FREELDR] DetectPnpBios(): Add 'i' to ERR() debug print (#3465)

Addendum to 17990b2 (r73617). CORE-12623

2 months ago[OPENGL32] Fix Red and Green Color Swap (#3478)
Doug Lyons [Mon, 22 Feb 2021 16:45:33 +0000 (10:45 -0600)]
[OPENGL32] Fix Red and Green Color Swap (#3478)

CORE-16221

2 months ago[USETUP] Display the "check the FS" section as a MUI page (#3474)
George Bișoc [Mon, 22 Feb 2021 15:48:03 +0000 (16:48 +0100)]
[USETUP] Display the "check the FS" section as a MUI page (#3474)

2 months agoReplace my E-mail with the ReactOS org one (#3475)
George Bișoc [Mon, 22 Feb 2021 15:26:55 +0000 (16:26 +0100)]
Replace my E-mail with the ReactOS org one (#3475)

From now on for ReactOS related contributions only the organization e-mail shall be used and also reverse the order of my real full name.

2 months ago[FREELDR/x64] Fix MSVC x64 boot
Hervé Poussineau [Mon, 22 Feb 2021 14:15:18 +0000 (15:15 +0100)]
[FREELDR/x64] Fix MSVC x64 boot

2 months ago[RSYM/x64] Allow binaries without symbol table
Hervé Poussineau [Mon, 22 Feb 2021 13:30:22 +0000 (14:30 +0100)]
[RSYM/x64] Allow binaries without symbol table

2 months ago[RSYM/x64] Make command line compatible with x86 version
Hervé Poussineau [Mon, 22 Feb 2021 13:17:32 +0000 (14:17 +0100)]
[RSYM/x64] Make command line compatible with x86 version

x86 version needs input and output file names as arguments, even if is called with
input file name = output file name.
x86 version also accepts a -s argument to the root path of ReactOS sources

Make x64 version take the same arguments.

2 months ago[FREELDR/x64] Partly revert 5367ae576083f18c0fbdf0c1e6954c0bb1b47845
Hervé Poussineau [Mon, 22 Feb 2021 09:30:51 +0000 (10:30 +0100)]
[FREELDR/x64] Partly revert 5367ae576083f18c0fbdf0c1e6954c0bb1b47845

Using RealModeEntryPoint uses IMAGE_REL_I386_REL16, now supported by obj2bin

2 months ago[OBJ2BIN] Add support for IMAGE_REL_I386_REL16
Hervé Poussineau [Mon, 22 Feb 2021 09:06:20 +0000 (10:06 +0100)]
[OBJ2BIN] Add support for IMAGE_REL_I386_REL16

Also return error in case of unknown relocation type.

2 months ago[FREELDR] Fix check, as FreeLoader x64 compiled with GCC only have 2 sections (.text...
Hervé Poussineau [Sun, 21 Feb 2021 23:04:40 +0000 (00:04 +0100)]
[FREELDR] Fix check, as FreeLoader x64 compiled with GCC only have 2 sections (.text and .bss)

2 months ago[FREELDR/x64] Change syntax to be compatible with GAS x64
Hervé Poussineau [Sun, 21 Feb 2021 23:04:11 +0000 (00:04 +0100)]
[FREELDR/x64] Change syntax to be compatible with GAS x64

2 months ago[LSASRV] Improve the policy change registration code and notify registered events
Eric Kohl [Sun, 21 Feb 2021 17:05:11 +0000 (18:05 +0100)]
[LSASRV] Improve the policy change registration code and notify registered events

2 months ago[README] Trivial correction: replace "Seven" with "7" (#3469)
pivotman319 [Sun, 21 Feb 2021 15:48:20 +0000 (16:48 +0100)]
[README] Trivial correction: replace "Seven" with "7" (#3469)

2 months ago[NTOS:CM] Report key creation to the notify code
Eric Kohl [Sun, 21 Feb 2021 14:49:06 +0000 (15:49 +0100)]
[NTOS:CM] Report key creation to the notify code

2 months ago[SHIMGVW] Use _countof instead of ARRAYSIZE and use UINT (#3471)
Katayama Hirofumi MZ [Sun, 21 Feb 2021 01:28:08 +0000 (10:28 +0900)]
[SHIMGVW] Use _countof instead of ARRAYSIZE and use UINT (#3471)

- Use _countof macro instead of non-standard ARRAYSIZE macro.
- Use UINT type for array index instead of INT type, to erase signed/unsigned comparison warning.
JIRA issue: N/A

2 months ago[WIN32K] Add StretchBlt function ability to flip images (#3458)
Doug Lyons [Sat, 20 Feb 2021 23:28:36 +0000 (17:28 -0600)]
[WIN32K] Add StretchBlt function ability to flip images (#3458)

Modify dib\dibxxbpp.c programs to understand flipped images. See Videos at CORE-16642

1. Mirroring Horizontally works.
2. Mirroring Vertically works.
3. Rotation 180° works.

CORE-16642, CORE-14408, CORE-16634

2 months ago[GDI32_APITEST] Add more StretchBlt Regression Tests (#3455)
Doug Lyons [Sat, 20 Feb 2021 23:21:51 +0000 (17:21 -0600)]
[GDI32_APITEST] Add more StretchBlt Regression Tests (#3455)

Added tests for many more StretchBlt options.
Created StretchBlt regression tests for verifying most flip options.
This is preparation for my Pull Request #3458 which will implement the flip functionality for StretchBlt.

CORE-16642

2 months ago[KERNEL32] Align the PROCESS_PRIORITY_CLASS variable in GetPriorityClass on a 4-byte...
Colin Finck [Sat, 20 Feb 2021 16:13:38 +0000 (17:13 +0100)]
[KERNEL32] Align the PROCESS_PRIORITY_CLASS variable in GetPriorityClass on a 4-byte boundary.

Fixes CORE-16757.
This is required for NtQueryInformationProcess as proven by my test application in the bug report.

2 months ago[LSASRV] Add start code for the netlogon service
Eric Kohl [Fri, 19 Feb 2021 20:53:00 +0000 (21:53 +0100)]
[LSASRV] Add start code for the netlogon service

2 months ago[NTOS:CC] Keep a reference on the shared cache map of the file when we are in lazy...
Jérôme Gardou [Fri, 19 Feb 2021 14:47:05 +0000 (15:47 +0100)]
[NTOS:CC] Keep a reference on the shared cache map of the file when we are in lazy write

This should fix "Leaking VACB" debug prints

2 months ago[NTOS:WMI] Be consistent about potential NULL pointer use
Jérôme Gardou [Thu, 18 Feb 2021 09:24:53 +0000 (10:24 +0100)]
[NTOS:WMI] Be consistent about potential NULL pointer use

2 months ago[NTOS:WMI] IoWMIWriteEvent(): Add WNODE_FLAG_TRACED_GUID case
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:WMI] IoWMIWriteEvent(): Add WNODE_FLAG_TRACED_GUID case

Addendum to d5f8964 (r23040).
CORE-17384

2 months ago[NTOS:WMI] IoWMIWriteEvent(): Fix annotation, Extend DPRINT1()
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:WMI] IoWMIWriteEvent(): Fix annotation, Extend DPRINT1()

CORE-17384

2 months ago[NTOS:MM] Handle demand zero PTEs with MM_EXECUTE_READWRITE and MM_READWRITE
Timo Kreuzer [Sun, 1 Nov 2020 14:13:36 +0000 (15:13 +0100)]
[NTOS:MM] Handle demand zero PTEs with MM_EXECUTE_READWRITE and MM_READWRITE

2 months ago[PSDK] winbase.h: Update LoadLibraryEx() dwFlags value defines (#3456)
Serge Gautherie [Tue, 16 Feb 2021 15:37:48 +0000 (16:37 +0100)]
[PSDK] winbase.h: Update LoadLibraryEx() dwFlags value defines (#3456)

Add another Vista check.
Addendum to 986cc5e.

3 months ago[SHIMGVW] Update Czech (cs-CZ) translation
Václav Zouzalík [Mon, 15 Feb 2021 21:07:41 +0000 (22:07 +0100)]
[SHIMGVW] Update Czech (cs-CZ) translation

3 months agoRevert "Disable some C++ code, which doesn't compile for me"
Hervé Poussineau [Mon, 15 Feb 2021 23:13:18 +0000 (00:13 +0100)]
Revert "Disable some C++ code, which doesn't compile for me"

This reverts commit 83d9920cb9a1ff0fb7dca07402b2aaba2f9cc644.

3 months agoDisable some C++ code, which doesn't compile for me
Hervé Poussineau [Wed, 3 Jun 2020 19:46:52 +0000 (21:46 +0200)]
Disable some C++ code, which doesn't compile for me

3 months ago[NTOS:KD] Merge initialization phases 1 and 2, and fix log file debugging
Hervé Poussineau [Mon, 15 Feb 2021 22:20:15 +0000 (23:20 +0100)]
[NTOS:KD] Merge initialization phases 1 and 2, and fix log file debugging

Phase 2 and 3 were not done anymore since 777a2d94da285f9ab612680ebb9f5d412b74fb68.

Fix that, by merging phases 1 and 2, and by calling phase 3 later
for log file debugging, when ExpInitializationPhase = 3

CORE-17470

3 months ago[SHIMGVW] Refactoring (#3461)
Katayama Hirofumi MZ [Mon, 15 Feb 2021 10:21:55 +0000 (19:21 +0900)]
[SHIMGVW] Refactoring (#3461)

- Make the calls of CallWindowProc and DefWindowProc Wide (Unicode).
- Delete needless type casts.
- Add const to function arguments.
- Improve ImageView_LoadSettings function.
- Insert OFN_EXPLORER flag.

3 months ago[MMSYS] Add the OFN_EXPLORER flag to the Browse for sound dialog. (#3460)
Jared Smudde [Sun, 14 Feb 2021 20:40:30 +0000 (14:40 -0600)]
[MMSYS] Add the OFN_EXPLORER flag to the Browse for sound dialog. (#3460)

3 months ago[SHIMGVW] Fix wrong text into the title bar. (#3459)
Carlo Bramini [Sun, 14 Feb 2021 17:38:36 +0000 (18:38 +0100)]
[SHIMGVW] Fix wrong text into the title bar. (#3459)

Unicode/ANSI conversion problem happened by some wrong ANSI function calls. This PR fixes them by modifying CMakeLists.txt.

3 months ago[NETAPI32] Use our implementation of NetWkstaUserEnum instead of the Wine stub
Eric Kohl [Sun, 14 Feb 2021 10:26:54 +0000 (11:26 +0100)]
[NETAPI32] Use our implementation of NetWkstaUserEnum instead of the Wine stub

3 months ago[WKSSVC][NETAPI32] Implement NetrWkstaGetInfo and get rid of the old NetWkstaGetInfo...
Eric Kohl [Sat, 13 Feb 2021 22:19:29 +0000 (23:19 +0100)]
[WKSSVC][NETAPI32] Implement NetrWkstaGetInfo and get rid of the old NetWkstaGetInfo implementation

3 months ago[SHIMGVW]Update German translation
Robert Naumann [Sat, 13 Feb 2021 19:59:38 +0000 (20:59 +0100)]
[SHIMGVW]Update German translation