Thomas Faber [Sun, 18 Jun 2017 12:19:52 +0000 (12:19 +0000)]
[LIBPNG]
- Update to version 1.6.29
CORE-13451
svn path=/trunk/; revision=75089
Thomas Faber [Sun, 18 Jun 2017 11:41:14 +0000 (11:41 +0000)]
[LIBSAMPLERATE]
- Update to version 1.0.9
CORE-13451
svn path=/trunk/; revision=75088
Thomas Faber [Sun, 18 Jun 2017 11:18:41 +0000 (11:18 +0000)]
[NTOS:MM]
- Implement MiMapLockedPagesInUserSpace and MiUnmapLockedPagesInUserSpace.
CORE-13444 #resolve
svn path=/trunk/; revision=75087
Pierre Schweitzer [Sun, 18 Jun 2017 08:48:12 +0000 (08:48 +0000)]
[DESK]
French translation for Eric's work on r75085.
CORE-8352
svn path=/trunk/; revision=75086
Eric Kohl [Sun, 18 Jun 2017 08:31:20 +0000 (08:31 +0000)]
[DESK]
Replace the screen resolution change confirmation message box by a proper dialog box with timeout.
CORE-8352
svn path=/trunk/; revision=75085
Thomas Faber [Sun, 18 Jun 2017 08:00:29 +0000 (08:00 +0000)]
[KMTESTS:MM]
- Test unaligned address and addresses close to MmHighestUserAddress in MmMapLockedPagesSpecifyCache test
CORE-13444
svn path=/trunk/; revision=75084
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 23:34:32 +0000 (23:34 +0000)]
[NTOS]: Use SEH inside CmQueryKey(), as it can be called with user-mode parameter KeyInformation. Remove unused code in CmLoadKey().
I've noticed that in cmapi.c / ntapi.c we do not correctly check the validity of some OBJECT_ATTRIBUTES variables and user-mode vs. kernel-mode registry handles.
svn path=/trunk/; revision=75083
Eric Kohl [Sat, 17 Jun 2017 23:21:16 +0000 (23:21 +0000)]
[DESK]
- Add a message box to ask the user to confirm the screen resolution change.
- The resolution change will be reverted if the user clicks 'No'.
A separate dialog box with a timer will be added next.
svn path=/trunk/; revision=75082
Thomas Faber [Sat, 17 Jun 2017 20:26:53 +0000 (20:26 +0000)]
[PSDK]
- Properly add NTSTATUS code
svn path=/trunk/; revision=75081
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 20:16:40 +0000 (20:16 +0000)]
[NTOS]: Improve a DPRINT.
svn path=/trunk/; revision=75080
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 20:13:17 +0000 (20:13 +0000)]
Just use REG_FORCE_UNLOAD since we're at it.
svn path=/trunk/; revision=75079
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 20:08:48 +0000 (20:08 +0000)]
[NTDLL_APITEST]: Add tests for NtLoadKey and NtUnloadKey.
CORE-13448
svn path=/trunk/; revision=75078
Pierre Schweitzer [Sat, 17 Jun 2017 20:02:51 +0000 (20:02 +0000)]
[GFLAGS]
Add some usage
svn path=/trunk/; revision=75077
Amine Khaldi [Sat, 17 Jun 2017 19:04:57 +0000 (19:04 +0000)]
[FREETYPE] Update to v2.8. By Katayama Hirofumi MZ, confirmed by me. CORE-13295
svn path=/trunk/; revision=75076
Pierre Schweitzer [Sat, 17 Jun 2017 18:00:18 +0000 (18:00 +0000)]
[BOOTDATA]
Use a gflag compatible way to enable Page Heap
svn path=/trunk/; revision=75075
Pierre Schweitzer [Sat, 17 Jun 2017 12:34:08 +0000 (12:34 +0000)]
[GFLAGS]
Add a quick'n'dirty implementation of gflags utility.
It only covers some page heap usage (enough to enable/disable DPH :-)).
It's syntax compatible with MS one, and with what's written down in ROS wiki.
See: https://www.reactos.org/wiki/Debugging#Debug_Page_Heap_.28DPH.29
svn path=/trunk/; revision=75073
Giannis Adamopoulos [Sat, 17 Jun 2017 07:43:52 +0000 (07:43 +0000)]
[SHELL32] -CMenuBand: forward WM_WININICHANGE to CMenuToolbarBase so that when themes get enabled, the menu bar in explorer becomes flat immediately.
svn path=/trunk/; revision=75072
Giannis Adamopoulos [Sat, 17 Jun 2017 07:28:35 +0000 (07:28 +0000)]
[BROWSEUI]
- CShellBrowser: Propagate WM_WININICHANGE to all immediate children.
- CInternetToolbar: Forward WM_WININICHANGE to the menu band to make aware that the flat menus option changed.
svn path=/trunk/; revision=75071
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 01:22:17 +0000 (01:22 +0000)]
[NTOS]: Employ the simple CMP_ASSERT_KCB_LOCK() macro to perform these asserts.
svn path=/trunk/; revision=75070
Hermès Bélusca-Maïto [Sat, 17 Jun 2017 01:21:21 +0000 (01:21 +0000)]
[NTOS]: Whitespace fixes only.
svn path=/trunk/; revision=75069
James Tabor [Fri, 16 Jun 2017 22:49:36 +0000 (22:49 +0000)]
[User32]
- Based on patch by Nikolay Sivov : Fix static control id. Fixes dialog tests, see CORE-13362.
svn path=/trunk/; revision=75068
James Tabor [Fri, 16 Jun 2017 22:44:21 +0000 (22:44 +0000)]
[User32]
- Skip desktop for positive index. See CORE-13362.
svn path=/trunk/; revision=75067
Hermès Bélusca-Maïto [Fri, 16 Jun 2017 21:06:04 +0000 (21:06 +0000)]
[NTOS]: Fix a bit the CmUnloadKey() function:
- When a hive is unloaded, we *must* set the HIVE_IS_UNLOADING flag before doing anything else (as other code in Cm depends on this);
- If we don't force a hive unload, we *must* check whether there are other opened handles to keys inside this hive, and if so, we must fail.
If this is a force-unload however, we *must* invalidate/close all the opened handles to keys inside this hive, BUT this is left UNIMPLEMENTED at the moment (and therefore expect the already existing problems linked to this to still happen).
- Move the HvFree(Hive); call at the very end, just before deleting the Cm hive, and as is done in CmpDestroyHive().
svn path=/trunk/; revision=75066
Hermès Bélusca-Maïto [Fri, 16 Jun 2017 21:02:27 +0000 (21:02 +0000)]
[NTOS]: Reorder the destruction code in CmpDestroyHive() to make it similar to the one in CmUnloadKey(). Same remark for a comment in NtUnloadKey2() too.
svn path=/trunk/; revision=75065
Hermès Bélusca-Maïto [Fri, 16 Jun 2017 20:59:15 +0000 (20:59 +0000)]
[NTOS]: Few improvements:
- Remove few unneeded PCMHIVE "backwards"-casts, and in particular the 1st parameter of CmpUnlinkHiveFromMaster().
- Improve the dprints in CmCountOpenSubKeys().
svn path=/trunk/; revision=75064
Hermès Bélusca-Maïto [Fri, 16 Jun 2017 20:44:51 +0000 (20:44 +0000)]
[NTOS]: Remove trailing whitespace ; Use a correct pool tag in the CmpFree() call in CmpFreeDelayItem().
svn path=/trunk/; revision=75063
Amine Khaldi [Fri, 16 Jun 2017 19:20:03 +0000 (19:20 +0000)]
[USBPORT] Bring-in the usbport driver created by Vadim Galyant. CR-111 GitHub PR #27. This is the first module out of many to come, so stay tuned! Many thanks to everyone involved in the code review. Very special thanks for Thomas as his help, insight and reviews helped tremendously.
svn path=/trunk/; revision=75062
Amine Khaldi [Fri, 16 Jun 2017 18:50:42 +0000 (18:50 +0000)]
[D3D8][D3D9][DDRAW][WINED3D] Sync with Wine Staging 2.9. This work couldn't have been committed without Sebastian Gasiorek's work on CORE-11331 so thanks again! Dedicated to Daniel. CORE-13362
svn path=/trunk/; revision=75061
Amine Khaldi [Fri, 16 Jun 2017 18:40:31 +0000 (18:40 +0000)]
[PSDK] Update D3DCOLOR_ARGB and D3DQUERYTYPE. [DXSDK] Add missing D3DDEVICEDESC1, D3DDEVICEDESC2, D3DFINDDEVICERESULT1 and D3DFINDDEVICERESULT2.
svn path=/trunk/; revision=75060
Amine Khaldi [Fri, 16 Jun 2017 18:38:08 +0000 (18:38 +0000)]
[WIN32SS] Implement D3DKMT{Create,Destroy}DCFromMemory. Brought to you by Sebastian Gasiorek. CORE-11331 CORE-13362
svn path=/trunk/; revision=75059
Giannis Adamopoulos [Fri, 16 Jun 2017 17:53:50 +0000 (17:53 +0000)]
[SHELL32] -CMenuBand: When the flat menus style is enabled, shell menu bars should not look like toolbars.
svn path=/trunk/; revision=75058
Thomas Faber [Fri, 16 Jun 2017 11:06:33 +0000 (11:06 +0000)]
[KMTESTS:MM]
- In the MmMapLockedPagesSpecifyCache test, try to allocate & free memory or unmap a section view in the mapped buffer space
CORE-13444
svn path=/trunk/; revision=75057
Eric Kohl [Thu, 15 Jun 2017 23:19:34 +0000 (23:19 +0000)]
[ADVAPI32]
ScmRpcStatusToWinError: Convert STATUS_ACCESS_VIOLATION to ERROR_INVALID_HANDLE.
UnlockServiceDatabase returns ERROR_INVALID_SERVICE_LOCK instead of ERROR_INVALID_HANDLE.
svn path=/trunk/; revision=75053
Eric Kohl [Thu, 15 Jun 2017 21:40:12 +0000 (21:40 +0000)]
[ADVAPI32]
CreateServiceA/W: Call SetLastError() in case of success too.
svn path=/trunk/; revision=75052
Thomas Faber [Thu, 15 Jun 2017 18:32:14 +0000 (18:32 +0000)]
[NTOS:IO]
- Pass the class key handle as a parameter to IopAttachFilterDrivers, since we already opened it in PipCallDriverAddDevice.
CORE-13336 #resolve
svn path=/trunk/; revision=75051
Thomas Faber [Thu, 15 Jun 2017 16:14:01 +0000 (16:14 +0000)]
[NTOS:IO]
- Consistently treat class filters as optional in IopAttachFilterDrivers
CORE-13336
svn path=/trunk/; revision=75049
Thomas Faber [Thu, 15 Jun 2017 13:51:09 +0000 (13:51 +0000)]
[NTOS:IO]
- Simplify logic in PipCallDriverAddDevice.
CORE-13336
svn path=/trunk/; revision=75048
Thomas Faber [Thu, 15 Jun 2017 13:33:55 +0000 (13:33 +0000)]
[NTOS:IO]
- Addendum to r75046: add missing header change.
CORE-13336
svn path=/trunk/; revision=75047
Thomas Faber [Thu, 15 Jun 2017 13:25:26 +0000 (13:25 +0000)]
[NTOS:IO]
- Pass Enum subkey handle to IopAttachFilterDrivers, since we've already opened it in PipCallDriverAddDevice.
CORE-13336
svn path=/trunk/; revision=75046
Thomas Faber [Thu, 15 Jun 2017 12:16:09 +0000 (12:16 +0000)]
[WIN32K:NTUSER]
- Fix clipboard lock check in UserSetClipboardData. Fixes 24 user32:clipboard tests.
CORE-13414 #resolve
svn path=/trunk/; revision=75045
Eric Kohl [Thu, 15 Jun 2017 09:29:22 +0000 (09:29 +0000)]
[ADVAPI32]
OpenServiceA/W: Call SetLastError() in case of success too.
svn path=/trunk/; revision=75044
Thomas Faber [Thu, 15 Jun 2017 06:47:42 +0000 (06:47 +0000)]
[RTL]
- Implement RtlIsCriticalSectionLocked and RtlIsCriticalSectionLockedByThread
CORE-13436 #resolve
svn path=/trunk/; revision=75043
Eric Kohl [Thu, 15 Jun 2017 00:21:07 +0000 (00:21 +0000)]
[NETAPI32]
Add obsolete NetRepl functions.
svn path=/trunk/; revision=75042
Mark Jansen [Wed, 14 Jun 2017 15:25:04 +0000 (15:25 +0000)]
[APITEST] Move RedirectIat into it's own header so that it can be used from multiple tests.
svn path=/trunk/; revision=75041
Mark Jansen [Wed, 14 Jun 2017 14:22:32 +0000 (14:22 +0000)]
[NOTEPAD] Fix default font settings. Patch by Katayama Hirofumi MZ. CORE-13037
svn path=/trunk/; revision=75040
Eric Kohl [Wed, 14 Jun 2017 13:44:11 +0000 (13:44 +0000)]
[NETAPI32]
- Add I_BrowserQueryEmulatedDomains and I_BrowserSetNetlogonState to the new computer browser inferface file.
- Get rid of the now obsolete browsr.c file.
svn path=/trunk/; revision=75039
Eric Kohl [Wed, 14 Jun 2017 13:10:36 +0000 (13:10 +0000)]
[NETAPI32]
- Add the computer browser service client interface.
- Add binding code for the computer browser service client interface.
svn path=/trunk/; revision=75038
Eric Kohl [Wed, 14 Jun 2017 13:06:41 +0000 (13:06 +0000)]
[NETAPI32]
Implement NetEnumerateComputerNames. This function calls its counterpart in the workstation service.
svn path=/trunk/; revision=75037
Eric Kohl [Wed, 14 Jun 2017 12:57:52 +0000 (12:57 +0000)]
[IDL]
Add computer browser service interface definition files.
svn path=/trunk/; revision=75035
Eric Kohl [Wed, 14 Jun 2017 12:17:08 +0000 (12:17 +0000)]
[NETAPI32]
Move the stubs NetServerEnum and NetServerEnumEx into a new file for the computer browser service interface code.
svn path=/trunk/; revision=75034
Eric Kohl [Wed, 14 Jun 2017 11:31:54 +0000 (11:31 +0000)]
[NETAPI32]
Implement NetGetJoinableOUs and NetValidateName. These functions call their counterparts in the workstation service.
svn path=/trunk/; revision=75033
Eric Kohl [Wed, 14 Jun 2017 09:50:54 +0000 (09:50 +0000)]
[NETAPI32]
Implement NetAddAlternateComputerName, NetJoinDomain, NetRemoveAlternateComputerName, NetRenameMachineInDomain, NetSetPrimaryComputerName and NetUnjoinDomain. These functions call their counterparts in the workstation service.
svn path=/trunk/; revision=75032
Thomas Faber [Wed, 14 Jun 2017 07:14:44 +0000 (07:14 +0000)]
[SETUPAPI]
- Properly stub SetupDiRemoveDeviceInterface. From Wine commit
cdb72f39 by Hans Leidekker. Fixes crash when running setupapi_winetest:devinst.
CORE-13362
svn path=/trunk/; revision=75031
Thomas Faber [Wed, 14 Jun 2017 06:44:39 +0000 (06:44 +0000)]
[DEVENUM_WINETEST]
- Fix return value check for IEnumMoniker_Next. Fixes crash when running the test without renderers installed (as is the case on ROS).
CORE-13421 #resolve
svn path=/trunk/; revision=75030
Robert Naumann [Tue, 13 Jun 2017 21:40:41 +0000 (21:40 +0000)]
[FONTS] Improve the font-substitution for Franklin Gothic Medium to better match the original font. This improves Luna's start button. CORE-12877
svn path=/trunk/; revision=75029
Eric Kohl [Tue, 13 Jun 2017 20:58:10 +0000 (20:58 +0000)]
[NTOSKRNL]
NtAccessCheck: Call SePrivilegePolicyCheck to get the list of required privileges and return it to the caller.
This fixes the ERROR_INSUFFICIENT_BUFFER failures in the advapi32 security winetest.
svn path=/trunk/; revision=75028
Thomas Faber [Tue, 13 Jun 2017 20:51:26 +0000 (20:51 +0000)]
[SCHANNEL]
- Apply Wine commit
81861ddd (secur32: Don't change input buffer in InitializeSecurityContext) by Jacek Caban. Fixes crash when running secur32_winetest:schannel
CORE-13425 #resolve
svn path=/trunk/; revision=75027
Giannis Adamopoulos [Tue, 13 Jun 2017 20:17:07 +0000 (20:17 +0000)]
[WIN32K] -Use RtlStringCchCopyW instead of RtlStringCbCopyW in SubstituteFontRecurse as LF_FACESIZE is the number of characters of the buffer. Patch by Katayama Hirofumi MZ. CORE-13419, CORE-13416
svn path=/trunk/; revision=75026
Thomas Faber [Tue, 13 Jun 2017 14:11:26 +0000 (14:11 +0000)]
[WIN32K:NTUSER]
- Fail UserSetClipboardData in case of 0 format, as shown by user32:clipboard test
svn path=/trunk/; revision=75024
Thomas Faber [Tue, 13 Jun 2017 13:40:55 +0000 (13:40 +0000)]
[USER32]
- Set last error on success in EnumClipboardFormats, as shown by user32:clipboard test
svn path=/trunk/; revision=75022
Thomas Faber [Tue, 13 Jun 2017 13:27:03 +0000 (13:27 +0000)]
[WIN32K:NTUSER]
- Close the clipboard when a thread is destroyed. Fixes 148 user32:clipboard tests
CORE-13414
svn path=/trunk/; revision=75021
Thomas Faber [Tue, 13 Jun 2017 13:12:55 +0000 (13:12 +0000)]
[WIN32K:NTUSER]
- Avoid crash on invalid format in UserEnumClipboardFormats. This is covered by user32_winetest but we currently fail that call before it can crash. The next commit will change that.
CORE-13414
svn path=/trunk/; revision=75020
Thomas Faber [Tue, 13 Jun 2017 10:10:57 +0000 (10:10 +0000)]
[NTMARTA]
- Add support for CURRENT_USER trustee in AccpGetTrusteeSid. Fixes crash in advapi32_winetest:security
CORE-13420 #resolve
svn path=/trunk/; revision=75019
Thomas Faber [Tue, 13 Jun 2017 06:45:39 +0000 (06:45 +0000)]
[BOOTDATA]
- Add Print context menu item for .rtf files. Patch by Nikolay Burshtyn.
CORE-13342 #resolve
svn path=/trunk/; revision=75018
Thomas Faber [Tue, 13 Jun 2017 05:48:28 +0000 (05:48 +0000)]
[KMTESTS]
- Add test for hidparse's descriptor parsing
CORE-11538
svn path=/trunk/; revision=75017
James Tabor [Mon, 12 Jun 2017 22:42:45 +0000 (22:42 +0000)]
[GDI32|Metafile]
- Instead of debug breaking, use wine code anyway. Should fix CORE-12911.
svn path=/trunk/; revision=75016
Thomas Faber [Mon, 12 Jun 2017 19:51:29 +0000 (19:51 +0000)]
[HDAUDBUS]
- Initialize the correct variable in HDA_FDOQueryBusRelations. Should fix random crashes due to uninitialized value use.
CORE-12707 #resolve
svn path=/trunk/; revision=75015
Thomas Faber [Mon, 12 Jun 2017 19:37:58 +0000 (19:37 +0000)]
[WIN32K:NTUSER]
- Add a hack to avoid doubly freeing a DCE in IntDestroyClass. Since we don't implement W32PF_OWNDCCLEANUP and always free DCEs unconditionally in DceFreeDCE, it is not safe to access the class DCE here (and probably other places) since it could have been deleted by a dying thread.
CORE-13415 #resolve
svn path=/trunk/; revision=75014
Giannis Adamopoulos [Mon, 12 Jun 2017 18:38:26 +0000 (18:38 +0000)]
[SHELL32] -Add Comments as the 2nd column in CDesktopFolder, CDrivesFolder and CRegFolder. Add Type as the 3rd column in CRegFolder. This is not entirely correct. Our columns support is rudimentary, however we now show the comments stuff in the right place and the reg folder items have a type.
svn path=/trunk/; revision=75013
Giannis Adamopoulos [Mon, 12 Jun 2017 10:11:39 +0000 (10:11 +0000)]
Fix build.
svn path=/trunk/; revision=75012
Giannis Adamopoulos [Mon, 12 Jun 2017 10:01:28 +0000 (10:01 +0000)]
[SHELL32]
- Rename the resource identifiers for column names to make sense. Get rid of one called File. This was renamed to Name but was the same in other languages, now it is replaced by Name for good. We also had two strings for a column called Comments and I think that in some languages one was singular and the other was plural. We only need the plural one.
Note to translators: Please make sure that everything I changed makes sense. I had to edit all language files and there can be mistakes and typos.
svn path=/trunk/; revision=75011
Pierre Schweitzer [Sun, 11 Jun 2017 17:32:56 +0000 (17:32 +0000)]
[NTOSKRNL]
Implement SystemExtendedHandleInformation based on SystemHandleInformation.
To be improved...
Passes ntdll_winetest:info.
CORE-13368
svn path=/trunk/; revision=75006
Giannis Adamopoulos [Sun, 11 Jun 2017 14:02:14 +0000 (14:02 +0000)]
[SHELL32] -CDrivesFolder: Implement returning the appropriate type string in GetDetailsOf. Simplify GetDetailsOf and CDrivesExtractIcon_CreateInstance.
svn path=/trunk/; revision=75005
Mark Jansen [Sun, 11 Jun 2017 13:09:43 +0000 (13:09 +0000)]
[APPHELP_APITEST] Addendum to r74986, make the test work on win7. CORE-13284
svn path=/trunk/; revision=75004
Thomas Faber [Sun, 11 Jun 2017 12:46:15 +0000 (12:46 +0000)]
[BUGCODES]
- Add DIRTY_NOWRITE_PAGES_CONGESTION and BUGCODE_USB_DRIVER
svn path=/trunk/; revision=75003
Thomas Faber [Sun, 11 Jun 2017 12:26:48 +0000 (12:26 +0000)]
[PSDK]
- Fix C++ version of BM_REQUEST_TYPE without breaking the C version
svn path=/trunk/; revision=75002
Mark Jansen [Sun, 11 Jun 2017 11:47:41 +0000 (11:47 +0000)]
[WIN32NT_APITEST] Do not assert on a driver without DirectX support.
svn path=/trunk/; revision=75001
Thomas Faber [Sun, 11 Jun 2017 11:28:00 +0000 (11:28 +0000)]
[NTOS:EX]
- Return STATUS_SUCCESS from the SystemExtendedHandleInformation stub to make Process Explorer happy. Fixes infinite loop on AHK bot.
svn path=/trunk/; revision=75000
Mark Jansen [Sun, 11 Jun 2017 11:18:57 +0000 (11:18 +0000)]
[WIN32K] Remove an unneeded check at GreGetDIBitsInternal. Patch by Victor Martinez Calvo. CORE-13413 CID
1411972
svn path=/trunk/; revision=74999
Mark Jansen [Sun, 11 Jun 2017 11:08:32 +0000 (11:08 +0000)]
[COMCTL32_IMAGELIST] Prevent dereferencing a null pointer.
svn path=/trunk/; revision=74998
Mark Jansen [Sun, 11 Jun 2017 10:39:55 +0000 (10:39 +0000)]
[SHELL32] Do not fail CFSFolder::GetDisplayNameOf with a NULL pidl, preventing another crash in shell32:CFSFolder
svn path=/trunk/; revision=74997
Mark Jansen [Sun, 11 Jun 2017 08:51:36 +0000 (08:51 +0000)]
[WIN32KNT_APITEST] Do not assert on the result of an unimplemented function.
svn path=/trunk/; revision=74996
Mark Jansen [Sun, 11 Jun 2017 08:38:16 +0000 (08:38 +0000)]
[SHELL32] Don't try to follow a null pointer inside CFSDropTarget, this fixes a crash in shell32:CFSFolder
svn path=/trunk/; revision=74995
Mark Jansen [Sun, 11 Jun 2017 08:37:03 +0000 (08:37 +0000)]
[SHELL32] Expose IID_CDefView in our CDefView implementation, this fixes a crash on shell32:shlview
svn path=/trunk/; revision=74994
Thomas Faber [Sun, 11 Jun 2017 08:33:36 +0000 (08:33 +0000)]
[WIN32K:NTUSER]
Fix pool use after free during user32:clipboard:
- Rename IntIsFormatAvailable to IntGetFormatElement to better reflect what it does
- Introduce a new IntIsFormatAvailable that actually returns BOOL as implied by the name
- In IntAddSynthesizedFormats, call IntGetFormatElement right before its data is actually used, since IntAddFormatedData will invalidate the element pointer.
Thanks to Kamil for the initial investigation on this.
CORE-13408 #resolve
svn path=/trunk/; revision=74993
Pierre Schweitzer [Sun, 11 Jun 2017 07:56:18 +0000 (07:56 +0000)]
[WS2_32]
Don't pass a null ptr at MSAFD to avoid dereference.
Fixes crash in ws2_32:sock
svn path=/trunk/; revision=74992
Thomas Faber [Sun, 11 Jun 2017 06:53:28 +0000 (06:53 +0000)]
[WIN32K:NTUSER]
- Initialize BITMAPINFOHEADER::biSize before calling GreGetDIBitsInternal in IntSynthesizeDib. Fixes use of uninitialized memory and subsequent stack buffer overflow.
CORE-13408
svn path=/trunk/; revision=74991
Thomas Faber [Sun, 11 Jun 2017 06:05:42 +0000 (06:05 +0000)]
[WIN32K:NTUSER]
- Include the CLIPBOARDDATA structure itself when calculating the size passed to UserCreateObject in IntSynthesizeDib. Fixes user heap corruption when running user32_winetest:clipboard.
CORE-13408
svn path=/trunk/; revision=74990
Pierre Schweitzer [Sat, 10 Jun 2017 20:58:22 +0000 (20:58 +0000)]
[RDBSS]
Cosmetic fix
CID
1411968,
1411969
svn path=/trunk/; revision=74989
Pierre Schweitzer [Sat, 10 Jun 2017 20:46:28 +0000 (20:46 +0000)]
[RDBSS]
Fix reading parameters from registry
CID
1411973
svn path=/trunk/; revision=74987
Mark Jansen [Sat, 10 Jun 2017 20:31:58 +0000 (20:31 +0000)]
[APPHELP_APITEST] Add tests for ApphelpCheckRunApp[Ex], SdbGetMatchingExe, Sdb[Un]PackAppCompatData. CORE-13284
svn path=/trunk/; revision=74986
Pierre Schweitzer [Sat, 10 Jun 2017 20:28:25 +0000 (20:28 +0000)]
[RXCE]
Misc. fixes.
CID
1411918,
1411929,
1411919
svn path=/trunk/; revision=74985
Mark Jansen [Sat, 10 Jun 2017 19:41:31 +0000 (19:41 +0000)]
[SHLWAPI_APITEST] Add PathFindOnPath tests. Patch by Katayama Hirofumi MZ. ROSTESTS-283 #comment Thanks!
svn path=/trunk/; revision=74984
Mark Jansen [Sat, 10 Jun 2017 17:47:56 +0000 (17:47 +0000)]
Addendum to r74982, remove some debugging code.
svn path=/trunk/; revision=74983
Mark Jansen [Sat, 10 Jun 2017 17:46:11 +0000 (17:46 +0000)]
[SHELL32_APITEST] Add tests for PathResolve. Patch by Katayama Hirofumi MZ. CORE-12665 #comment Thanks!
svn path=/trunk/; revision=74982
Eric Kohl [Sat, 10 Jun 2017 10:51:49 +0000 (10:51 +0000)]
[SCHEDSVC]
Add a loop at the end of SchedServiceMain that will run until a stop event is signaled. This loop will be used to run the schduled jobs.
svn path=/trunk/; revision=74981
Thomas Faber [Sat, 10 Jun 2017 07:59:50 +0000 (07:59 +0000)]
[NTOS:EX]
- Stub NtQuerySystemInformation:SystemExtendedHandleInformation. Avoids crashes in the upcoming ntdll_winetest sync.
CORE-13368 #resolve
svn path=/trunk/; revision=74980
Pierre Schweitzer [Sat, 10 Jun 2017 05:45:26 +0000 (05:45 +0000)]
[UDFS]
Fix UDFS volume size computation.
Note that side effect of this is that free space computation is broken;
due to larger bitmap walk. To be fixed...
CORE-4375
CORE-13366
svn path=/trunk/; revision=74979
Amine Khaldi [Fri, 9 Jun 2017 23:13:23 +0000 (23:13 +0000)]
[PSDK] Add some missing definitions.
svn path=/trunk/; revision=74978
Thomas Faber [Fri, 9 Jun 2017 21:36:15 +0000 (21:36 +0000)]
[WIN32K:NTUSER]
- Fix fmt range check in NtUserGetClipboardFormatName (see Wine commit
4bdcf512). Fixes new test failures (and resulting debug spam) in user32_winetest:clipboard
CORE-13402 #resolve
svn path=/trunk/; revision=74977