Amine Khaldi [Wed, 6 Jan 2016 15:43:24 +0000 (15:43 +0000)]
[BOOTVID] Use plan 9 8x13 font from Markus Kuhn. Patch by Roy Tam. CORE-10777
svn path=/trunk/; revision=70508
Colin Finck [Wed, 6 Jan 2016 09:31:53 +0000 (09:31 +0000)]
[BOOTVID]
Change the Blue Screen Font hardcoded into bootvid.dll to the Open Source "Anonymous Pro" font, which makes a nice 8x13 font.
Blue Screens now look like this: http://fs5.directupload.net/images/160106/ehv6245t.png
[BOOTVID_FONT_GENERATOR]
In case you find an even better font, you now have a nice little tool to test that font and generate the corresponding FontData array for bootvid.
svn path=/trunk/; revision=70507
Alex Ionescu [Wed, 6 Jan 2016 04:43:23 +0000 (04:43 +0000)]
[BOOTLIB]: Add very early work around font loading.
[BOOTLIB]: Add mostly full support for resource and locale management.
[BOOTLIB]: Stub out bootstat.dat (Boot Status Data Log) support.
[BOOTLIB]: Some refactoring.
[BOOTMGFW]: Add a message table with a few initial strings. Also add an empty bootmgr.xsl stylesheet. We'll have to see what we want/need to do here.
[BOOTMGFW]: Correctly loading HTML and message table resource data, and add a few other additional initialization calls.
Next steps are to re-visit graphics code to support re-initialization.
svn path=/trunk/; revision=70504
Colin Finck [Wed, 6 Jan 2016 02:19:53 +0000 (02:19 +0000)]
I think almost 10 years of participation suffice to get into this file :)
svn path=/trunk/; revision=70501
Pierre Schweitzer [Tue, 5 Jan 2016 22:56:20 +0000 (22:56 +0000)]
[ROSVBOXMGMT]
Add a new feature to the tool:
Let it auto start VBox Shared folders and to browse all the available shares in order to create shell links on desktop.
The purpose is to workaround the missing network shares discovery feature in ReactOS while keeping the VBox shared folders usage 'user-friendly'.
It has been designed specifically for the coming 0.4.0 release: just put it on autostart for the default user. If there are shares (even new ones), it will create links, if there are no shares, no guest additions, no VBox, it will just exit.
See it in action: https://twitter.com/HeisSpiter/status/
684506579555741696
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70500
Pierre Schweitzer [Tue, 5 Jan 2016 21:42:54 +0000 (21:42 +0000)]
[ROSVBOXMGMT]
When displaying active shares, also display their names
svn path=/trunk/; revision=70499
Hermès Bélusca-Maïto [Tue, 5 Jan 2016 19:53:07 +0000 (19:53 +0000)]
[NTOS:MM]: Don't hardcode Mm tags since we have a #define
svn path=/trunk/; revision=70498
Hermès Bélusca-Maïto [Tue, 5 Jan 2016 19:52:35 +0000 (19:52 +0000)]
[REACTOS]
Update the README files for 0.4.x releases.
svn path=/trunk/; revision=70497
Ged Murphy [Tue, 5 Jan 2016 18:58:32 +0000 (18:58 +0000)]
[NTOSKRNL]
- Use the LockQueueIoDatabaseLock spinlock to guard the device list instead of blindly raising the IRQL
- Add missing lock to IopEditDeviceList
svn path=/trunk/; revision=70496
Ged Murphy [Tue, 5 Jan 2016 18:43:26 +0000 (18:43 +0000)]
[FLTMGR]
- Fix a bug in FltpDetachFromFileSystemDevice so it correctly bails when we've walked the attached device list.
- FltpDispatch can come in at high IRQL. Thanks to Thomas for noticing that err.
- Add newlines to the end of DPRINTS (it's been a while...)
- The filter now loads and runs in the reactos FS stack.
svn path=/trunk/; revision=70495
Alex Ionescu [Tue, 5 Jan 2016 17:12:14 +0000 (17:12 +0000)]
[DDK]: Add IMAGE_RESOURCE_DIRECTORY_ENTRY to NTIMAGE.H. I shudder to think how our current code currently parses resource directories without this.
svn path=/trunk/; revision=70494
Ged Murphy [Tue, 5 Jan 2016 13:04:52 +0000 (13:04 +0000)]
[FLTMGR]
- Mark the Dispatch / FastIo functions as paged code
- Fix declarations and remove casts
svn path=/trunk/; revision=70493
Alex Ionescu [Tue, 5 Jan 2016 06:09:22 +0000 (06:09 +0000)]
[BOOTLIB]: Separate out bcd.c into bcdopt.c, bootreg.c and bcd.c
[BOOTLIB]: Implement routines to enumerate subkeys and to read a key value.
[BOOTLIB]: Implement routines to parse, enumerate, and convert registry data into BCD elements, and to convert BCD elements into boot library BCD options.
[BOOTLIB/BOOTMGFW]: Lots of cleanups, mainly around the fact we now use ntintsafe.h instead of the manually self-inlined code from before, and from documenting additional flag values, and from using our newfound BCD powers.
[BOOTMGFW]: Implement BmGetOptionList, BmpUpdateApplicationOptions.
[BOOTMGFW]: Prepare for post-BCD library reinitialization. We correctly read the 3 BCD options so far in the hive.
svn path=/trunk/; revision=70492
Alex Ionescu [Tue, 5 Jan 2016 05:12:01 +0000 (05:12 +0000)]
[BOOTMGFW]: Implement the rtlcompat functions, so that Rtl string functions will actually work.
[HIVEBCD]: Start filling out a minimalistic BCD Hive layout to try out the BCD parsing/conversion code in my WC.
svn path=/trunk/; revision=70491
Alex Ionescu [Tue, 5 Jan 2016 01:55:40 +0000 (01:55 +0000)]
[CMLIB]: Attempt fix for Linux hosts.
svn path=/trunk/; revision=70490
Alex Ionescu [Tue, 5 Jan 2016 01:51:54 +0000 (01:51 +0000)]
[CMLIB]: Move Value functions to CMLIB as well, so that they can be shared with the new boot code.
svn path=/trunk/; revision=70489
Ged Murphy [Mon, 4 Jan 2016 12:50:06 +0000 (12:50 +0000)]
[FLTMGR]
- Plug in the dispatch routines. These are just pass through methods for now to get the filter up and running.
- Implement the FastIo handlers. The majority of these call the FastIo routines of the attached device object.
- Make sure we detach from devices that are being deleted in FastIoDetachDevice.
- Move the FastIoDetachDevice routine to a deferred call as it's too expensive to tie up a FastIo request.
svn path=/trunk/; revision=70488
Timo Kreuzer [Sun, 3 Jan 2016 19:58:33 +0000 (19:58 +0000)]
[WIN32K]
This ASSERT was actually supposed to be removed and only accidentally brought back.
svn path=/trunk/; revision=70487
Timo Kreuzer [Sun, 3 Jan 2016 19:46:57 +0000 (19:46 +0000)]
[WIN32K]
Fix the fix from r70482: Our DIBs are actually 32 bit aligned, so pass even uncompressed bits to GreCreateBitmapEx instead of copying them later with wrong alignment.
svn path=/trunk/; revision=70486
Timo Kreuzer [Sun, 3 Jan 2016 18:10:31 +0000 (18:10 +0000)]
[WIN32K]
Disable broken code to update a device palette. Should fix testbot crashes.
svn path=/trunk/; revision=70485
Amine Khaldi [Sun, 3 Jan 2016 16:27:06 +0000 (16:27 +0000)]
[NTDLL] Fix a typo.
svn path=/trunk/; revision=70484
Alex Ionescu [Sun, 3 Jan 2016 16:23:38 +0000 (16:23 +0000)]
[NDK]: Document RtlPushFrame, RtlPopFrame, RtlGetFrame.
[NDK]: Add TEB_ACTIVE_FRAME_CONTEXT_FLAG_EXTENDED, TEB_ACTIVE_FRAME_EX, TEB_ACTIVE_FRAME_CONTEXT_EX from the CoreCLR sources (clrnt.h)
[RTL]: Implement RtlPushFrame, RtlPopFrame, RtlGetFrame.
[NTDLL]: Export the above.
[RTL]: Fix MSVC warning after someone's earlier WINE merge.
svn path=/trunk/; revision=70483
Timo Kreuzer [Sun, 3 Jan 2016 16:16:04 +0000 (16:16 +0000)]
[WIN32K]
NtGdiCreateDIBitmapInternal: clear CBM_INIT flag, if no bits are given.
IntSetDIBits: Always calculate the bitmap size for uncompressed bitmaps, do not pass uncompressed bits to GreCreateBitmapEx, since they don't have the required alignment (the width in bytes for DIB is 16 bit aligned, bitmaps 32).
Remove a broken ASSERT.
svn path=/trunk/; revision=70482
Eric Kohl [Sun, 3 Jan 2016 15:40:57 +0000 (15:40 +0000)]
Improve English strings in ReactOS.
Patch by Henry Tang Ih.
CORE-10729 #resolve #comment Committed in r70480. Thanks a lot!
svn path=/trunk/; revision=70480
Eric Kohl [Sun, 3 Jan 2016 09:22:14 +0000 (09:22 +0000)]
[LSASRV]
Implement LsarStorePrivateData and LsarRetrievePrivateData.
[ADVAPI32]
Implement LsaRetrievePrivateData and LsaStorePrivateData.
Encryption of secrets (aka private data) is NOT implemented yet!
svn path=/trunk/; revision=70479
Eric Kohl [Fri, 1 Jan 2016 14:16:04 +0000 (14:16 +0000)]
[ADVAPI32]
CreateProcessAsUserA/W: Make hToken optional.
svn path=/trunk/; revision=70478
Hermès Bélusca-Maïto [Thu, 31 Dec 2015 23:05:23 +0000 (23:05 +0000)]
Happy New Year 2016 !!
☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰
░░░░░░█░█ █▀█ █▀█ █▀█ █░█░░░░░░
░░░░░░█▀█ █▀█ █▀▀ █▀▀ ▀█▀░░░░░░
░░░░░░▀░▀ ▀░▀ ▀░░ ▀░░ ░▀░░░░░░░
█▄░█ █▀▀ █░█░█░░█░█ █▀▀ █▀█ █▀█
█░██ █▀▀ █░█░█░░▀█▀ █▀▀ █▀█ ██▀
▀░░▀ ▀▀▀ ░▀▀▀░░░░▀░ ▀▀▀ ▀░▀ ▀░▀
⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰
░░░▄████▄░▄███▄░░▄██░▄████▄░░░
░░░▀▀░▄██░██░██░████░██▄▄▄░░░░
░░░░▄██▀░░██░██░░░██░██░░██░░░
░░░██████░▀███▀░░░██░▀████▀░░░
☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
svn path=/trunk/; revision=70477
Eric Kohl [Thu, 31 Dec 2015 22:42:20 +0000 (22:42 +0000)]
[INCLUDE]
Fix a typo! :-/
svn path=/trunk/; revision=70476
Eric Kohl [Thu, 31 Dec 2015 22:39:12 +0000 (22:39 +0000)]
[INCLUDE]
Does this fix MSVC builds?
svn path=/trunk/; revision=70475
Eric Kohl [Thu, 31 Dec 2015 22:17:45 +0000 (22:17 +0000)]
[SYSETUP]
- Implement pSetupDebugPrint and modify the LogItem macro accordingly.
- Add some log messages to the setup wizard.
svn path=/trunk/; revision=70474
Eric Kohl [Thu, 31 Dec 2015 16:39:01 +0000 (16:39 +0000)]
[SYSSETUP]
Remove the NtUnloadKey hack.
svn path=/trunk/; revision=70473
Thomas Faber [Thu, 31 Dec 2015 14:25:35 +0000 (14:25 +0000)]
[ACPICA]
- Update to version
20151218
CORE-10765
svn path=/trunk/; revision=70472
Eric Kohl [Thu, 31 Dec 2015 12:58:18 +0000 (12:58 +0000)]
[SOLITAIRE]
solitaire: no action upon doubleclick
Patch by Carlo Bramini.
CORE-6514 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70470
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 20:23:18 +0000 (20:23 +0000)]
[USETUP]: Correctly check for existing "ReactOS" entries in FreeLdr in case ReactOS is reinstalled over an existing installation, and if no one does exist, then create a new one that actually works. Thanks tower for having reported the problem 8^)
svn path=/trunk/; revision=70469
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 18:52:07 +0000 (18:52 +0000)]
[USETUP]: Formatting fix & remove a redundant function.
svn path=/trunk/; revision=70468
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 18:26:42 +0000 (18:26 +0000)]
[USETUP]
Factorize the code that creates ReactOS freeldr.ini entries, and use it to create a freeldr.ini at a clean ReactOS installation, and when it is installed in the same partition as Win9x/DOS.
CORE-4870 #comment Should be fixed with revision 70467, please retest.
svn path=/trunk/; revision=70467
Timo Kreuzer [Tue, 29 Dec 2015 20:28:23 +0000 (20:28 +0000)]
[WIN32K]
Properly check the bitmap size in IntSetDIBits, taking into account that it might be set to 0, then we have to calculate it ourselves. Fixes a crash when invalid data is passed to NtGdiCreateDIBitmapInternal.
[GDI32]
Convert COREINFOHEADER to BITMAPINFOHEADER before passing it to NtGdiCreateDIBitmapInternal, which doesn't support it.
CORE-10583 #resolve
svn path=/trunk/; revision=70464
Timo Kreuzer [Mon, 28 Dec 2015 23:51:05 +0000 (23:51 +0000)]
[WIN32KDLL_2K3SP2]
Export NtUserGetClassInfoEx (as it's called in 2k3) both as NtUserGetClassInfo (as it's called on XP) and NtUserGetClassInfo. They have the same prototype.
svn path=/trunk/; revision=70463
Timo Kreuzer [Mon, 28 Dec 2015 23:03:04 +0000 (23:03 +0000)]
[WIN32KDLL_2K3SP2]
- "Fix" an export name: NtUserGetClassInfoEx on 2k3 is the same as NtUserGetClassInfo on XP (note that we currently use the default, aka ros specific, win32kdll on the WHS testbot, but it's mostly identical.
[WIN32KNT_APITEST]
- Fix a typo
- add missing tests to testlist.c
svn path=/trunk/; revision=70462
Timo Kreuzer [Mon, 28 Dec 2015 20:53:34 +0000 (20:53 +0000)]
[GDITOOLS]
3rd try to fix WHS rostests build
svn path=/trunk/; revision=70461
Timo Kreuzer [Mon, 28 Dec 2015 20:51:28 +0000 (20:51 +0000)]
[WIN32NT_APITEST]
2nd try to fix WHS rostests build
svn path=/trunk/; revision=70460
Timo Kreuzer [Mon, 28 Dec 2015 20:46:05 +0000 (20:46 +0000)]
[WIN32NT_APITEST]
Try to fix WHS rostests build
svn path=/trunk/; revision=70459
Timo Kreuzer [Mon, 28 Dec 2015 20:31:10 +0000 (20:31 +0000)]
[APOTESTS]
- Convert win32k native api test to actual wine style api-tests
- Hack around a bit with the win32k dlls, some renaming, etc.
- Delete old apitest stuff
svn path=/trunk/; revision=70458
Timo Kreuzer [Mon, 28 Dec 2015 20:24:57 +0000 (20:24 +0000)]
[GDITOOLS]
Add a library with some helper routines for GDI tests
svn path=/trunk/; revision=70457
Timo Kreuzer [Mon, 28 Dec 2015 15:49:29 +0000 (15:49 +0000)]
[CRT_APITEST]
Fix sprintf tests to succeed on W2K3
svn path=/trunk/; revision=70456
Timo Kreuzer [Mon, 28 Dec 2015 15:24:47 +0000 (15:24 +0000)]
[CRT_APITEST]
Add tests for _snprintf, _snwprintf, strtoul, wcstoul
Patch by Thomas Faber (slightly modified by me)
CORE-6510
svn path=/trunk/; revision=70455
Timo Kreuzer [Mon, 28 Dec 2015 14:42:41 +0000 (14:42 +0000)]
[SPEC2DEF]
Don't use DATA and PRIVATE together. DATA means no stub function is generated in the import lib, PRIVATE means nothing is generated in the export lib.
svn path=/trunk/; revision=70454
Timo Kreuzer [Mon, 28 Dec 2015 11:01:03 +0000 (11:01 +0000)]
[CRT_APITEST]
- Disable a check for crtdll
- Fix an MSVC warning
svn path=/trunk/; revision=70453
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 22:41:48 +0000 (22:41 +0000)]
[BOOTDATA]: ReactOS can install and run fine on volumes of at least 450 MB (for example, on a volume of 450 MB and after creation of the pagefile, it leaves you 60+ MB of free space, which should be enough for you if you're already happy using HDDs of such small sizes ^^).
svn path=/trunk/; revision=70451
Timo Kreuzer [Sun, 27 Dec 2015 20:24:04 +0000 (20:24 +0000)]
[CRT]
Fix a typo in a comment and make it clearer, what we do here.
CORE-10754 #resolve
svn path=/trunk/; revision=70450
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 20:01:24 +0000 (20:01 +0000)]
[VFATLIB]
Now, the fix: the FAT disk checker expected that the free cluster count member of the FAT32 FSInfo sector be really initialized (not to 0xFFFFFFFF), and it expected the presence of the backup of the FSInfo sector as well as the free sector following the FSInfo sector.
svn path=/trunk/; revision=70449
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:57:10 +0000 (19:57 +0000)]
Remove a forgotten DPRINT1.
svn path=/trunk/; revision=70448
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:55:47 +0000 (19:55 +0000)]
[VFATLIB]
- DPRINT messages printed via VfatPrint by the check-disk procedure.
- Addendum to r70434 and r70435 : The return value of fs_close is equal to the number of corrections made on the disk (0 corrections --> success; 1+ --> something was corrected).
That way, the old code "return fs_close(FixErrors) ? STATUS_SUCCESS : STATUS_UNSUCCESSFUL;" that we had since eons (which always happened to return STATUS_SUCCESS) was actually
indicating to us that our FAT32-formatted volumes were corrupted.
If you test this revision, you should see something happening if you try to install ReactOS now (something that should have happened since ages actually).
svn path=/trunk/; revision=70447
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:38:13 +0000 (19:38 +0000)]
[VFATLIB]
- Formatting + RtlZero/FillMemory modifications as addendum to r70445.
- Do not hardcode FSInfo signature values, use instead the same set of macros fastfat_new introduces.
svn path=/trunk/; revision=70446
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:30:53 +0000 (19:30 +0000)]
[VFATLIB]
- Formatting fixes.
- Use RtlZeroMemory/RtlFillMemory instead of memset.
svn path=/trunk/; revision=70445
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:06:16 +0000 (19:06 +0000)]
[TASKMGR]: Use taskmgr's icon for its run file dialog. Inspired by Wine.
svn path=/trunk/; revision=70444
Timo Kreuzer [Sun, 27 Dec 2015 18:22:13 +0000 (18:22 +0000)]
[CRT]
Fix handling of NULL buffer in streamout. Fixes a few msvcrt_crt_apitests, while it breaks a few for crtdll. crtdll is broken anyway and obsolete, nothing uses it, so it doesn't really matter.
CORE-9105 #resolve
svn path=/trunk/; revision=70443
Timo Kreuzer [Sun, 27 Dec 2015 17:55:14 +0000 (17:55 +0000)]
[SETUPAPI]
Fix invalid use of wcslen with NULL pointer. Should fix crash in setupapi_winetest:install.
svn path=/trunk/; revision=70441
Eric Kohl [Sun, 27 Dec 2015 16:36:32 +0000 (16:36 +0000)]
[MSGINA]
Improve msgina's text in ReactOS.
Patch by Henry Tang Ih.
CORE-10720 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70437
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 15:22:39 +0000 (15:22 +0000)]
[USETUP]: Fix some localization problems.
svn path=/trunk/; revision=70436
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 02:04:09 +0000 (02:04 +0000)]
Fix build.
svn path=/trunk/; revision=70435
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 02:01:52 +0000 (02:01 +0000)]
[VFATLIB]
It seems suspicious to directly return the value of fs_close as the NTSTATUS code of the check-disk operation (for FAT32 volumes it happens to return 1 whereas for FAT16 volumes it returns 0).
The documentation of this function says that it "returns a non-zero integer if the file system has been changed since the last fs_open, zero otherwise."
Maybe somebody has a more precise idea on that subject? In the meantime I also add some DPRINTs to attempt to diagnose the conditions where this problem occurs.
svn path=/trunk/; revision=70434
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 00:57:51 +0000 (00:57 +0000)]
[VFATLIB]
- Gather common code in one file instead of duplicating it everywhere.
- Implement full format for FAT12 and FAT16 (using the same function Fat1216WipeSectors), based on similar code for FAT32 implemented by Eric Kohl in revision 63693.
svn path=/trunk/; revision=70433
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 21:28:01 +0000 (21:28 +0000)]
[BOOTSECTORS]
- fat.asm: remove trailing whitespace.
- fat32.asm: backport the fixes from fat32.S introduced a long time ago.
- fat32.S/faty.S: use .space 12, 0 instead of the long .byte array (generates the same code, but is better readable).
- isoboot/btrt: whitespace fix only.
svn path=/trunk/; revision=70432
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 20:43:50 +0000 (20:43 +0000)]
[BOOTSECTORS]: Sync the .asm files with their .S counterparts (make easier for diff'ing).
svn path=/trunk/; revision=70431
Timo Kreuzer [Sat, 26 Dec 2015 20:34:15 +0000 (20:34 +0000)]
[CRT]
Fix x86 asm implementation of strlen / wcslen.
svn path=/trunk/; revision=70430
Timo Kreuzer [Sat, 26 Dec 2015 20:32:31 +0000 (20:32 +0000)]
[CRT_APITEST]
Add another test for strlen, that tests, whether the direction flag in ELFAGS has been modified. While clearing it is legitimate to do according to the ABI, the native implementation does not change it, so we don't want to do it either.
svn path=/trunk/; revision=70429
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 20:13:27 +0000 (20:13 +0000)]
[FATxxx BOOTSECTORS]: Whitespace changes mainly (makes easier for diffing). No code changes.
svn path=/trunk/; revision=70428
Timo Kreuzer [Sat, 26 Dec 2015 19:20:54 +0000 (19:20 +0000)]
[CRT_APITEST]
- disable GCC builtins
- Add simple tests for strlen, showing that a NULL pointer will cause an access violation, which is broken in our asm implementation
svn path=/trunk/; revision=70427
Pierre Schweitzer [Sat, 26 Dec 2015 17:44:07 +0000 (17:44 +0000)]
[BOOTSECT]
fatx.S isn't for the FATX filesystem, it's just a generic naming, so pick up the next variable
svn path=/trunk/; revision=70426
Timo Kreuzer [Sat, 26 Dec 2015 17:13:08 +0000 (17:13 +0000)]
[CRT] Add abs and labs to CRT lib
[MSVCRT] Explicitly pull in _vsnprintf, bsearch and strcspn from CRT, to prevent the MS linker from exporting stubs from libntdll instead.
See CORE-10753
svn path=/trunk/; revision=70425
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 17:08:13 +0000 (17:08 +0000)]
[NTVDM]: Cast all the number-of-sectors computations to DWORD/ULONG to prevent potential overflows. Should fix a strange floppy read/write corruption I noticed.
svn path=/trunk/; revision=70424
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 16:57:41 +0000 (16:57 +0000)]
[BOOTSECTORS]
- Use the old fat.S source for compiling the FAT12 boot sector, until FATX.S is completely implemented.
- Fix an assembly error in FATX.S
- In comments I added experimental FAT12/16/32 targets based on Timo's FATX.S.
svn path=/trunk/; revision=70423
Eric Kohl [Sat, 26 Dec 2015 01:34:49 +0000 (01:34 +0000)]
[MKHIVE]
Fix indentation. No code changes!
svn path=/trunk/; revision=70422
Eric Kohl [Sat, 26 Dec 2015 01:23:10 +0000 (01:23 +0000)]
[BOOTDATA]
Add missing service groups.
svn path=/trunk/; revision=70421
Eric Kohl [Sat, 26 Dec 2015 01:14:18 +0000 (01:14 +0000)]
[ADVAPI32]
- Implement AbortSystemShutdownW by a call to BaseAbortSystemShutdown.
- Implement InitiateSystemShutdownW by a call to BaseInitiateSystemShutdown.
- Implement InitiateSystemShutdownExW by a call to BaseInitiateSystemShutdownEx.
- Add RPC binding code for the winreg server (in winlogon.exe).
svn path=/trunk/; revision=70420
Eric Kohl [Sat, 26 Dec 2015 00:38:37 +0000 (00:38 +0000)]
[SHUTDOWN][WINLOGON]
SHUTDOWN: Fix the hack be calling InitiateSystemShutdownExW instead of ExitWindowsEx.
WINLOGON: Add a hack by calling ExitWindowsEx in BaseInitiateSystemShutdownEx.
svn path=/trunk/; revision=70419
Hermès Bélusca-Maïto [Sat, 26 Dec 2015 00:29:07 +0000 (00:29 +0000)]
[NTOS]
Disable again the DR7 check until we correctly understand why bit 10 of DR7 (reserved) is almost always set (this lead to MSVC-built ReactOS crashing when being starting in non-debugging mode). See also r69244.
CORE-10165 #comment DR7 check again disabled in r70418.
svn path=/trunk/; revision=70418
Hermès Bélusca-Maïto [Fri, 25 Dec 2015 18:43:16 +0000 (18:43 +0000)]
[KDCOM]
For MSVC builds (using KDCOM kd64 WinDbg protocol): Bail out for droppable packets after a given number of retries, if no debugger is attached (list of droppable packets can be found in http://articles.sysprogs.org/kdvmware/kdcom.shtml section "KDCOM protocol", subsection "Droppable packets").
CORE-10541 #resolve #comment Finally fixed in revision r70417!
CORE-7106
svn path=/trunk/; revision=70417
Timo Kreuzer [Wed, 23 Dec 2015 22:38:46 +0000 (22:38 +0000)]
[NTOS/KDBK]
Fix the value for EIP used by KDBG after an INT3 set by KDBG itself. The address is already fixed by KiDispatchException, but only in the context frame, not in the trap frame and KDBG insists to use the trap frame for a lot of things. Also, after a cont from such an int3, KDBG uses a single step to re-enable the breakpoint (it needs to disable it after it was hit to be able to execute the actual instruction), but it used to dismiss *any* single steps after that. So make sure, that an actual single step, as created by the debugger is not being dismissed, but the break point is still restored after the next single step entry. You might expect that a kernel debugger would at least support setting breakpoints, but this is KDBG.
svn path=/trunk/; revision=70416
Ged Murphy [Wed, 23 Dec 2015 16:29:33 +0000 (16:29 +0000)]
[FLTMGR]
- Change the start type to demand.
- Should stop free loader from throwing a tantrum because it can't load a non-existant boot driver
svn path=/trunk/; revision=70414
Hermès Bélusca-Maïto [Wed, 23 Dec 2015 16:15:08 +0000 (16:15 +0000)]
[XDK]
Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI aka. __stdcall. This is not explicitely mentioned in the W(D)DK, because MS supposes you compile all your kernel-mode code in stdcall convention, the WDK environment coming with preset default compiler switches enabling that. But if you try changing them, you'll run into big troubles. In our headers on the contrary we explicitely mention the calling conventions).
[FLTMGR]
Fix FltpFsNotification to adhere to the correct DRIVER_FS_NOTIFICATION definition.
Addendum to r70410.
svn path=/trunk/; revision=70413
Timo Kreuzer [Wed, 23 Dec 2015 14:55:34 +0000 (14:55 +0000)]
[WIN32K]
Pass cjMaxBits parameter from GreCreateDIBitmapInternal to IntCreateDIBitmap and check the image size before creating the bitmap.
Should fix crash when hitting about tab in Office2000 WinWord.
CORE-10583 #comment please retest
svn path=/trunk/; revision=70412
Ged Murphy [Wed, 23 Dec 2015 14:55:17 +0000 (14:55 +0000)]
[FLTMGR]
- Add the service key
svn path=/trunk/; revision=70411
Ged Murphy [Wed, 23 Dec 2015 14:45:15 +0000 (14:45 +0000)]
[XDK]
- hackfix just DRIVER_FS_NOTIFICATION until we decide how we want to declare them
- Should fix build
svn path=/trunk/; revision=70410
Ged Murphy [Wed, 23 Dec 2015 14:41:05 +0000 (14:41 +0000)]
[FLTMGR]
- Add the beginning of the fltmgr. It's called rosfltmgr for now so I can test in Windows.
- It's currently just base code which registers for file systems appearing (or disappearing), and attaches itself to them and all other mounted devices in their chain.
- Although it builds (touch wood), don't add it to a running system. The IRPs aren't plugged in yet and it'll just bugcheck lower down the stack.
svn path=/trunk/; revision=70409
Ged Murphy [Wed, 23 Dec 2015 11:26:28 +0000 (11:26 +0000)]
[NTOSKRNL]
- Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing
- Don't hardcode the pointer size when checking the buffer size
svn path=/trunk/; revision=70408
Timo Kreuzer [Mon, 21 Dec 2015 19:36:10 +0000 (19:36 +0000)]
[FREELDR/AMD64]
Save parameter registers (rcx, rdx) before calling CallRealMode. Patch by andy-123, applied to a secondary location by me.
CORE-10511 #resolve #comment Thanks. I added the same fix to PnpBiosGet below.
svn path=/trunk/; revision=70407
Eric Kohl [Sun, 20 Dec 2015 22:30:51 +0000 (22:30 +0000)]
[USERENV]
Hack, that fixes the "Volatile Environment" bug by deleting the "Volatile Environment" key before the user hive is unloaded.
CORE-10705
svn path=/trunk/; revision=70406
Hermès Bélusca-Maïto [Sun, 20 Dec 2015 16:21:59 +0000 (16:21 +0000)]
[KDCOM]
Do not use the "LoaderBlock->u.I386.CommonDataArea;" hack to use FreeLdr's DbgPrint function inside KDCOM, for the simple reason that while it works when KDCOM just initializes, the memory area where FreeLdr's DbgPrint function is, gets erased when ReactOS is running. As a result, all attempts to call the DbgPrint function when tracing something in KDCOM at the end of life of ReactOS, just fails lamentably (it hangs).
We therefore cannot rely on external code to provide us with DbgPrint. Instead, implement a very simple DbgPrint function inside KDCOM, as done by KDGDB.
The KD serial port serving for debugging KDCOM is chosen dynamically amongst the other free COM ports.
This needs to be also fixed in KDVM.
[KDGDB]
Instead of hardcoding the KD serial port number serving for debugging KDGDB, determine it dynamically amongst the other free COM ports.
svn path=/trunk/; revision=70405
Hermès Bélusca-Maïto [Sun, 20 Dec 2015 02:53:30 +0000 (02:53 +0000)]
[NTOS:KDBG]: Sync back the code that I copied in FreeLdr (r70403) for COM port selection.
svn path=/trunk/; revision=70404
Hermès Bélusca-Maïto [Sun, 20 Dec 2015 02:06:40 +0000 (02:06 +0000)]
[FREELDR]
- Allow to specify in freeldr.ini the debugging port parameters, similarly to what NTLDR allows to do: http://naesten.blogspot.fr/2010/07/undocumented-debug-section-in-bootini.html
- Update the FREELDR.INI example file to reflect these changes.
- Because some FreeLdr components, that need to be initialized before the debugging port parameters can be read from freeldr.ini, use debugging features, we still need to choose some default parameters. For serial ports, we select the possible port starting from COM4 down to COM1.
CORE-9023 #comment Revision 70403: Allow to specify a debugging port in freeldr.ini .
svn path=/trunk/; revision=70403
Eric Kohl [Sat, 19 Dec 2015 19:18:21 +0000 (19:18 +0000)]
[REGEDIT]
When the root item in the treeview is selected, remove all items from the listview and wipe the address bar and status bar.
svn path=/trunk/; revision=70402
Eric Kohl [Sat, 19 Dec 2015 08:57:56 +0000 (08:57 +0000)]
[BOOTDATA]
Remove obsolete default user locale values. They are now set by the 2nd stage installer.
#CORE-5989 #resolve
svn path=/trunk/; revision=70400
Hermès Bélusca-Maïto [Sat, 19 Dec 2015 01:08:11 +0000 (01:08 +0000)]
[SHELL32]: Tray ToolTips: use the correct buffer size for when calling MultiByteToWideChar. Addendum to r70360. CORE-10497
svn path=/trunk/; revision=70399
Eric Kohl [Fri, 18 Dec 2015 21:36:16 +0000 (21:36 +0000)]
[USETUP]
Set the default user locale after registry setup.
#CORE-5989 #comment Please retest!
svn path=/trunk/; revision=70398
Aleksey Bragin [Fri, 18 Dec 2015 14:58:32 +0000 (14:58 +0000)]
[RTL]
- Improve implementation of RtlActivateActivationContextUnsafeFast / RtlDeactivateActivationContextUnsafeFast by replace magic numbers by flag values, which are already defined in rtltypes.h, and adding various debugging checks. Two of them are triggered for yet unknown reason:
* Assert in RtlActivateActivationContextUnsafeFast
* "Trying to activate already activated activation context"
They are commented out in trunk not to annoy everyone.
svn path=/trunk/; revision=70396
Robert Naumann [Fri, 18 Dec 2015 12:31:57 +0000 (12:31 +0000)]
[MSPAINT] Fix some English strings, to match Windows behaviour. Patch by Henry Tang Ih CORE-10716
svn path=/trunk/; revision=70395
Robert Naumann [Fri, 18 Dec 2015 12:29:01 +0000 (12:29 +0000)]
[LOGON.SCR] - improve the bitmaps
- remove the enterprise part (we are ReactOS and only ReactOS)
- Add an Application icon
svn path=/trunk/; revision=70394
Hermès Bélusca-Maïto [Thu, 17 Dec 2015 23:10:56 +0000 (23:10 +0000)]
[DBGHELP][RTL]
Fix usage of VirtualSize wrt. SizeOfRawData.
CORE-10523
CORE-9548 #comment Please retest with revision >= 70390
svn path=/trunk/; revision=70390