14 years agoFix yet another invalid use of WriteFile.
Colin Finck [Sun, 15 Jun 2008 16:04:03 +0000 (16:04 +0000)]
Fix yet another invalid use of WriteFile.
This patch has already been submitted to Wine, but as they don't care currently, I applied it manually here and updated "wininet_ros.diff" accordingly.

svn path=/trunk/; revision=33984

14 years agoBug 3320: Czech translation update by Radek Liska (
Daniel Reimer [Sun, 15 Jun 2008 08:14:43 +0000 (08:14 +0000)]
Bug 3320: Czech translation update by Radek Liska (
Small Update for the German USETUP by me.

svn path=/trunk/; revision=33982

14 years ago- Continue cleanup, use new peripheral headers (And fix them)
ReactOS Portable Systems Group [Sun, 15 Jun 2008 07:54:18 +0000 (07:54 +0000)]
- Continue cleanup, use new peripheral headers (And fix them)
- Fix ARM HAL headers and use them

svn path=/trunk/; revision=33981

14 years ago- These are peripherals, not targets
ReactOS Portable Systems Group [Sun, 15 Jun 2008 06:15:13 +0000 (06:15 +0000)]
- These are peripherals, not targets

svn path=/trunk/; revision=33980

14 years ago- Start major ARM port cleanup:
ReactOS Portable Systems Group [Sun, 15 Jun 2008 06:14:02 +0000 (06:14 +0000)]
- Start major ARM port cleanup:
  - Make use of the SARCH rbuild parameter to define the target board (default to ARM VersatilePB for now)
  - Make official ARM include directory (include/reactos/arm) and move the ARM DDK there
  - Start creating header files for different target board components.
- Update halfuncs in NDK with one missing function, and temporarily, one ARM function.

svn path=/trunk/; revision=33979

14 years ago- Update Russian translation
Dmitry Chapyshev [Sun, 15 Jun 2008 06:01:53 +0000 (06:01 +0000)]
- Update Russian translation

svn path=/trunk/; revision=33978

14 years ago- Create cmhardwr.c for ARM, stub it out.
ReactOS Portable Systems Group [Sun, 15 Jun 2008 05:40:27 +0000 (05:40 +0000)]
- Create cmhardwr.c for ARM, stub it out.
- Implement KiInitMachineDependent -- this is only useful for x86 and has nothing relevant to ARM, so we just return.
- Implement HalAllProcessorsStarted (again, a no-op) and HalQueryRealTimeClock (uses the RTC on the board -- uboot must set it up first).
- Make sure we get the right Sp during a system call (this is still broken though).
- We need to fix our system call handler next.

svn path=/trunk/; revision=33977

14 years ago- Copy/pasted a bunch of code from the i386 bootvid for text output.
ReactOS Portable Systems Group [Sun, 15 Jun 2008 04:43:22 +0000 (04:43 +0000)]
- Copy/pasted a bunch of code from the i386 bootvid for text output.
- Don't implement BitBlt for now.
- Add the bootdata font file to the arm bootvid as well.
- Not sure how it's possible, but we are seeing text output on the console with this hacked-up code! The ReactOS version string appears...
- We are now getting much further in the boot cycle.

svn path=/trunk/; revision=33976

14 years ago- Implement VidSolidColorFill, VidSetScrollRegion and VidSetTextColor
ReactOS Portable Systems Group [Sun, 15 Jun 2008 04:11:21 +0000 (04:11 +0000)]
- Implement VidSolidColorFill, VidSetScrollRegion and VidSetTextColor
- Fix a bug in VidpBuildColor

svn path=/trunk/; revision=33975

14 years ago- Fix a bug in MmGetPhysicalAddress.
ReactOS Portable Systems Group [Sun, 15 Jun 2008 03:32:52 +0000 (03:32 +0000)]
- Fix a bug in MmGetPhysicalAddress.
- Don't hang in the clock interrupt anymore, for now we'll just ignore it (but it works! :D)
- Make all unimplemented bootvid functions hang the system, so we can better stop at progress-points.
- Implement VidInitialize:
  - We allocate a 640x480@16bpp framebuffer using contiguous physical memory (our MMU code survives!).
  - We setup the LCD controller timings and framebuffer address.
  - We enable the LCD
- For debugging, we're also drawing a nice little test pattern... and it works! We have GUI Code :)

svn path=/trunk/; revision=33974

14 years ago- Separate bootvid into bootvid/i386 and bootvid/arm (no code change to i386 version).
ReactOS Portable Systems Group [Sat, 14 Jun 2008 23:43:45 +0000 (23:43 +0000)]
- Separate bootvid into bootvid/i386 and bootvid/arm (no code change to i386 version).
- Stub out all the bootvid functions for ARM, and add an infinite loop so we stop there.
- Remove the infinite loop from the HAL -- Hal Initialization is complete.
- We must now implement the LCD graphics functions.

svn path=/trunk/; revision=33973

14 years agorevert r26384 - this is an old hack to make console output work. We don't need this...
Timo Kreuzer [Sat, 14 Jun 2008 23:20:22 +0000 (23:20 +0000)]
revert r26384 -  this is an old hack to make console output work. We don't need this any longer since freetype / text output is fixed.

svn path=/trunk/; revision=33972

14 years ago- Dude, we don't need to calibrate anything... we've got a 1MHz timer, which means...
ReactOS Portable Systems Group [Sat, 14 Jun 2008 23:19:03 +0000 (23:19 +0000)]
- Dude, we don't need to calibrate anything... we've got a 1MHz timer, which means 1us-precision. KeStallExecutionProcessor needs 1us-precision!
- Since we have two timers (ha x86!!!), set the second one as the stall timer. It's a one-shot periodic timer, set to the exact number of microseconds being waited on.
- To fully emulate stalling, we don't use a clock interrupt for it (it supports not sending one!) and just busy-loop until the value reaches 0.
- Tried it with a 10 second (10000000 us) wait and it worked -perfectly-.
- Re-implemented KeStallExecutionProcessor and got rid of the other code. Back in HalInitSystem(phase1) now...
- Also killed some DPRINT1s getting on my nerves.

svn path=/trunk/; revision=33971

14 years ago- We now implement the idle loop (thanks for fixing the interrupt code...).
ReactOS Portable Systems Group [Sat, 14 Jun 2008 22:48:30 +0000 (22:48 +0000)]
- We now implement the idle loop (thanks for fixing the interrupt code...).
- We are now back to HalInitSystem just like before the previous fixes.
- Now we'll implement stall calibration and switch to the clock interrupt.

svn path=/trunk/; revision=33970

14 years ago- Implement the basic stall interrupt to be used to calculate the factors for KeStall...
ReactOS Portable Systems Group [Sat, 14 Jun 2008 22:28:40 +0000 (22:28 +0000)]
- Implement the basic stall interrupt to be used to calculate the factors for KeStallExecution (using NT MIPS algorithm, hope this will work)
- Also written KeStallExecution.
- Now, we are back to where we hang before Phase 1 (so Phase 1 doesn't occur anymore).
- This hang is because we used to do a DPC here, which isn't good, since IRQL is already at dispatch.
- Instead, the correct course of action is to enter the idle loop, which will schedule the phase 1 thread.
- But, we don't have an idle loop yet ;-)

svn path=/trunk/; revision=33969

14 years ago- Give listbox in explorer searchprograms dialog i18n column heads (only done for...
Matthias Kupfer [Sat, 14 Jun 2008 22:21:44 +0000 (22:21 +0000)]
- Give listbox in explorer searchprograms dialog i18n column heads (only done for German and English, other language need to be done)

svn path=/trunk/; revision=33968

14 years ago- Fix stupid IRQL/Interrupt handling code that someone wrote ;):
ReactOS Portable Systems Group [Sat, 14 Jun 2008 22:02:50 +0000 (22:02 +0000)]
- Fix stupid  IRQL/Interrupt handling code that someone wrote ;):
  - Get rid of KeSwapIrql -- both lower and higher IRQL handling was treated the same!
  - We can now re-activate the assert in the IRQL code
  - Disable interrupts before changing the interrupt mask!!!
  - And re-enable them solely if they were enabled.
  - Clear interrupts mask before setting a new one -- raising isn't always additive!
  - Fix KiInterruptHandler to perform operations in the right order.
  - Finish implementing interrupt exit code.
- Code KeArmStatusRegisterGet to read CPSR and interrupt status.
- Make debug prints a lot more readable and dont trying to acquire the stack during pool allocations.
- Setup the clock interval timer!!!
- This code regresses progress but makes stuf fwork right. We'll get better after implementing the stall interrupt.

svn path=/trunk/; revision=33967

14 years ago- Implement the code for the "Run" and "Shutdown" menu items, create stubs for the...
Colin Finck [Sat, 14 Jun 2008 21:18:08 +0000 (21:18 +0000)]
- Implement the code for the "Run" and "Shutdown" menu items, create stubs for the other custom commands
- Replace the ROS-specific STDCALL by APIENTRY for the function prototypes

svn path=/trunk/; revision=33966

14 years agoPatch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong place.
James Tabor [Sat, 14 Jun 2008 17:10:55 +0000 (17:10 +0000)]
Patch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong place.

svn path=/trunk/; revision=33965

14 years agoVytis Girdzijauskas <cman AT cman DOT us>
Matthias Kupfer [Sat, 14 Jun 2008 11:49:55 +0000 (11:49 +0000)]
Vytis Girdzijauskas <cman AT cman DOT us>
- time zone update to sync with Windows tz data
- See issue #3084 for more details.

svn path=/trunk/; revision=33964

14 years agoniski_ (bjauy AT go2 DOT pl)
Matthias Kupfer [Sat, 14 Jun 2008 10:23:05 +0000 (10:23 +0000)]
niski_ (bjauy AT go2 DOT pl)
- polish language patch for shell32.
- See issue #3338 for more details.

svn path=/trunk/; revision=33963

14 years agofix/add some german translations
Matthias Kupfer [Sat, 14 Jun 2008 08:51:42 +0000 (08:51 +0000)]
fix/add some german translations

svn path=/trunk/; revision=33962

14 years ago- Release the acquired spinlock in IoUnregisterShutdownNotification(), spotted by...
Aleksey Bragin [Sat, 14 Jun 2008 08:16:22 +0000 (08:16 +0000)]
- Release the acquired spinlock in IoUnregisterShutdownNotification(), spotted by Cameron Gutman.

svn path=/trunk/; revision=33961

14 years agoPatch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), Registers ansi...
James Tabor [Sat, 14 Jun 2008 05:34:02 +0000 (05:34 +0000)]
Patch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), Registers ansi scroll bar proc.

svn path=/trunk/; revision=33960

14 years agoDon't use MenuCleanupRosMenuItemInfo for an array of Items allocated on the heap!
Colin Finck [Sat, 14 Jun 2008 00:00:20 +0000 (00:00 +0000)]
Don't use MenuCleanupRosMenuItemInfo for an array of Items allocated on the heap!
This function is meant to be used for a single menu item info and just frees the memory allocated for dwTypeInfo.

Replaced this with a simple HeapFree call to free the memory for the whole array allocated in MenuGetAllRosMenuItemInfo.
Fixes a heap corruption discovered by encoded.

See issue #3349 for more details.

svn path=/trunk/; revision=33959

14 years agoRevert parts of r33578:
Colin Finck [Fri, 13 Jun 2008 23:14:27 +0000 (23:14 +0000)]
Revert parts of r33578:
- First of all, MenuSetItemData is only called from InsertMenuA/W and ModifyMenuA/W.
  Therefore the passed MENUITEMINFO structure will always be empty, so it makes no sense to check for flags in this structure.
  This way, I could simplify the code block for MF_BITMAP.
- Also fType = MFT_BITMAP and fMask = MIIM_BITMAP at the same time passed to win32k don't work.
  Changing this back to only set fMask fixes bitmap menus.
- Furthermore the data for MF_OWNERDRAW is really stored in dwItemData and not in dwTypeData.
  The MSDN documentation for InsertMenu applies here, not the one for the MENUITEMINFO structure.
  This fixes owner-drawn menus like the one in Abiword.

See issue #3272 for more details.

svn path=/trunk/; revision=33958

14 years ago- german translation of explorer completed
Matthias Kupfer [Fri, 13 Jun 2008 20:33:42 +0000 (20:33 +0000)]
- german translation of explorer completed
- minor fix for label text size in german version of desk.cpl

svn path=/trunk/; revision=33957

14 years agoAdd notes, no code change.
James Tabor [Fri, 13 Jun 2008 18:19:28 +0000 (18:19 +0000)]
Add notes, no code change.

svn path=/trunk/; revision=33956

14 years agoMSDB KB 145994 ( yBaseUnit...
Timo Kreuzer [Fri, 13 Jun 2008 13:33:53 +0000 (13:33 +0000)]
MSDB KB 145994 ( yBaseUnit is textmetric->tmHeight not average text extent. Testing confirms that GdiGetCharDimension returns this as height. This makes dialog boxes less stretched in height. Still not identical to XP. calx.exe: On XP yBaseUnit == 13, on ROS == 14 (was 16 before)

svn path=/trunk/; revision=33955

14 years agoRevert 33953. This is completely wrong! WINE doesn't quite get the ordinals right...
Thomas Bluemel [Fri, 13 Jun 2008 13:14:08 +0000 (13:14 +0000)]
Revert 33953. This is completely wrong! WINE doesn't quite get the ordinals right. Ordinal 200 really should be SHCreateDesktop and ordinal 201 really should be SHDesktopMessageLoop. I am currently working on a patch for this. The fact that explorer-new was able to start with these changes is just pure coincidence.

svn path=/trunk/; revision=33954

14 years ago- Implement AddCommasW
Dmitry Chapyshev [Fri, 13 Jun 2008 07:58:34 +0000 (07:58 +0000)]
- Implement AddCommasW
- Implement SHLocalAlloc
- Implement SHLocalFree
- Implement SHLocalReAlloc
explorer-new starts in reactos now!

svn path=/trunk/; revision=33953

14 years agoAdd missing definitions
Thomas Bluemel [Thu, 12 Jun 2008 23:38:09 +0000 (23:38 +0000)]
Add missing definitions

svn path=/trunk/; revision=33952

14 years agoPatch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), modified by me:
Timo Kreuzer [Thu, 12 Jun 2008 20:50:12 +0000 (20:50 +0000)]
Patch by Jeffrey Morlan (mrnobo1024 at yahoo dot com, irc: Goplat), modified by me:
The freetype asm function FT_MulFix clobbers the edx register, but doesn't tell it to gcc explicitly, so when inlined versions were resulting in wrong results. Fix it by also marking edx as output register.
Also enable commented out code in win32k again that works correctly now.
By me:
I modified the patch to not alter any 3rd party code, but instead I copied the fuction to _ftmulfix_ros.c and also coplied the container file ftbase.c which now uses the fixed function from our private file.
This fixes a bunch of text output issues (underscore, text marking)
See issue #3346 for more details.

svn path=/trunk/; revision=33951

14 years agoLookup DrawCaptionTemp () only once during startup
Thomas Bluemel [Thu, 12 Jun 2008 16:50:57 +0000 (16:50 +0000)]
Lookup DrawCaptionTemp () only once during startup

svn path=/trunk/; revision=33950

14 years agoFix call to DrawCaptionTemp ()
Thomas Bluemel [Thu, 12 Jun 2008 15:45:09 +0000 (15:45 +0000)]
Fix call to DrawCaptionTemp ()

svn path=/trunk/; revision=33949

14 years ago- Fix a bug in timedate.cpl, where an incorrect color was passed.
Aleksey Bragin [Thu, 12 Jun 2008 09:50:12 +0000 (09:50 +0000)]
- Fix a bug in timedate.cpl, where an incorrect color was passed.
- Add bounds checking for GetSystemMetrics both in user32 and in kernel counterpart.
- Based on a patch from bug 3316.
See issue #3316 for more details.

svn path=/trunk/; revision=33947

14 years ago- Formatting cleanup for the previously patched functions.
Aleksey Bragin [Thu, 12 Jun 2008 09:40:33 +0000 (09:40 +0000)]
- Formatting cleanup for the previously patched functions.

svn path=/trunk/; revision=33946

14 years agoOriol Pique <>
Aleksey Bragin [Thu, 12 Jun 2008 09:35:24 +0000 (09:35 +0000)]
Oriol Pique <>
- Minor patch to HEAP_GetPtr to include magic value in debug output.
- Fixing the parameters checking in HEAP_InitSubHeap (it is currently not used - put between #if 0 / #endif ).
- Correcting HEAP_FindFreeBlock which was logging error message as warning (while still returning NULL to caller) by changing severity of logged message.
- Implementing RtlEnumProcessHeaps (previously stubbed out).
- Fixing sanity checks in and implementation of RtlGetProcessHeaps (previously
the function was not checking for the counter value, and also was not assigning anything to the returned value; now this seems to be corrected.
- Fixing RtlValidateProcessHeaps implementation (the function was stubbed out because (most probably, I wasn't able to find a bug mentioning this) it was previously using a global lock for all heaps (which probably could cause some problems in the kernel), now it only locks heaps belonging to the given process - and this is the correct behaviour.

Aleksey Bragin <>
- Fix typo in ntuser.c, and low severity of debug message.
See issue #2964 for more details.

svn path=/trunk/; revision=33945

14 years ago- Fix two bugs in MiDoMappedCopy: MI_MAPPED_PAGES is pages, not bytes; and a misuse...
Aleksey Bragin [Thu, 12 Jun 2008 09:18:11 +0000 (09:18 +0000)]
- Fix two bugs in MiDoMappedCopy: MI_MAPPED_PAGES is pages, not bytes; and a misuse of TotalSize / BufferSize.
- Fix similar mistake in MiDoPoolCopy.
- Patch from bug 3341.
See issue #3341 for more details.

svn path=/trunk/; revision=33944

14 years ago- Prevent a misunderstanding: kdHandleException means the debugger did NOT handle...
Aleksey Bragin [Thu, 12 Jun 2008 08:56:13 +0000 (08:56 +0000)]
- Prevent a misunderstanding: kdHandleException means the debugger did NOT handle the exception. Fix the logic, and thus fix vectored exception handling which led to 2nd stage hang in qemu.
- TODO: This ContinueType thing should be reworked into a better logic.
See issue #3344 for more details.

svn path=/trunk/; revision=33943

14 years agoUpdated Wordpad, XCopy, WInhlp32 to WIne 1.0rc4
Daniel Reimer [Thu, 12 Jun 2008 06:23:44 +0000 (06:23 +0000)]
Updated Wordpad, XCopy, WInhlp32 to WIne 1.0rc4
I skipped Collibri's Typo-Fix in the German Wordpad RC File. Collibri, plz send this to Wine.

svn path=/trunk/; revision=33942

14 years agoUpdated Winefile to Wine 1.0rc4.
Daniel Reimer [Thu, 12 Jun 2008 06:22:23 +0000 (06:22 +0000)]
Updated Winefile to Wine 1.0rc4.
Renamed it to Winfile, because this is the name it has under windows.

svn path=/trunk/; revision=33941

14 years ago- We now implement more proper context switching.
ReactOS Portable Systems Group [Thu, 12 Jun 2008 04:32:45 +0000 (04:32 +0000)]
- We now implement more proper context switching.
- This fixes an issue where code was using PCR->CurrentThread but x86/shared routines use PRCB->CurrentThread.
- Added a note to explain the difference, and we now set both.
- We currently stop at Phase 1 HAL Initialization.

svn path=/trunk/; revision=33940

14 years agoUse band styles provided by the IDeskBand interface
Thomas Bluemel [Thu, 12 Jun 2008 03:12:02 +0000 (03:12 +0000)]
Use band styles provided by the IDeskBand interface

svn path=/trunk/; revision=33939

14 years agoMore IBandSite support code
Thomas Bluemel [Thu, 12 Jun 2008 01:14:18 +0000 (01:14 +0000)]
More IBandSite support code

svn path=/trunk/; revision=33938

14 years ago- We now implement a super-basic (and probably broken) context switching mechanism.
ReactOS Portable Systems Group [Thu, 12 Jun 2008 00:40:53 +0000 (00:40 +0000)]
- We now implement a super-basic (and probably broken) context switching mechanism.
- We completely ignore setting the thread to the right scheduler state, and don't do any APC delivery checking, or any other work.
- We now implement a basic KiThreadStartup, which behaves properly (we believe). Doesn't handle user-mode threads yet, though.
- This gets us through PspSystemThreadStartup, and..
- We now reach Phase1InitializationDiscard! A major step has been reached, now it's time to cleanup what has been done until now and verify it to be correct.
- Then we move on... the next two things will be 1) Hal Initialization (setting up the timer) and 2) Displaying the boot logo.
- Graphics will require using the PL-110 LCD Controller.

svn path=/trunk/; revision=33937

14 years ago- We now implement a skeleton framework for context switching
ReactOS Portable Systems Group [Wed, 11 Jun 2008 19:13:25 +0000 (19:13 +0000)]
- We now implement a skeleton framework for context switching
- The only things we do are swap the stack and then display the old/new thread/stack.
- More work to be done to actually save the non-volatiles, prepare the thread state, and restore the volatiles for the new thread.
- Then we will return to the saved return address, and we should be in Phase 1 with working thread switching/scheduling.

svn path=/trunk/; revision=33935

14 years ago- We now make appropriate space on the stack to save the old IRQL in the trap frame.
ReactOS Portable Systems Group [Wed, 11 Jun 2008 18:39:44 +0000 (18:39 +0000)]
- We now make appropriate space on the stack to save the old IRQL in the trap frame.
- Save the old IRQL and assert it in the interrupt handler.
- Fix KTRAP_FRAME structure.

svn path=/trunk/; revision=33934

14 years ago- Fix build on ARM:
ReactOS Portable Systems Group [Wed, 11 Jun 2008 16:48:07 +0000 (16:48 +0000)]
- Fix build on ARM:
  - _iob is already defined as a dll_import
  - _rotl intrinsic is now implemented (should use rol instruction, but not sure on the syntax!)
  - Add a stub psctx.h for ARM
  - Added InterlockedEXchangePointers
  - Fix uninitialized variable warning in ex/resource.c
- Start to implement interrupt handling:
  - We now have a rudimentary interrupt handler that takes care of software interrupts
  - We now have a rudimentary DPC handler which takes care of switching to the next thread, if any
  - We now setup the HAL Interrupt Source -> IRQL Table (The IRQLMask Table).
  - Implemented HalGetInterruptSource, which allows us to get the interrupt # that cause the IRQ.
    Note: this wasn't needed on Alpha/PPC/MIPS NT ports, because that information is stored on the CPU,
    and the kernel could read it -- we must abstract it through the HAL.
  - Add the OldIrql to the TRAP_FRAME, we don't use it yet.
- We are now ready to context switch to the Phase 1 thread.

svn path=/trunk/; revision=33933

14 years ago- minor fix of german wordpad menu entry
Matthias Kupfer [Wed, 11 Jun 2008 12:31:23 +0000 (12:31 +0000)]
- minor fix of german wordpad menu entry
- german translation of dialog resource of keyboard layout switcher completed including start menu entry

svn path=/trunk/; revision=33932

14 years ago- Fix build.
Aleksey Bragin [Wed, 11 Jun 2008 12:00:09 +0000 (12:00 +0000)]
- Fix build.

svn path=/trunk/; revision=33931

14 years ago- Fix typos in NDK structures.
Aleksey Bragin [Wed, 11 Jun 2008 11:48:59 +0000 (11:48 +0000)]
- Fix typos in NDK structures.

svn path=/trunk/; revision=33930

14 years ago- Unregress KDBG: It has to increment EIP in case of STATUS_BREAKPOINT to skip over...
Aleksey Bragin [Wed, 11 Jun 2008 11:34:04 +0000 (11:34 +0000)]
- Unregress KDBG: It has to increment EIP in case of STATUS_BREAKPOINT to skip over the current instruction, but now do it inside KDBG's exception handler.
- In Kd and GDB exception handler wrappers, return FALSE if kdDoNotHandleException, and return TRUE otherwise (kdHandled / kdContinue). After my previous commit these functions were always returning FALSE / exception not handled.

svn path=/trunk/; revision=33929

14 years ago- Revert 33689 as breaking mIRC installation.
Aleksey Bragin [Wed, 11 Jun 2008 09:05:39 +0000 (09:05 +0000)]
- Revert 33689 as breaking mIRC installation.
See issue #3328 for more details.

svn path=/trunk/; revision=33928

14 years ago- Completely rewrite most of stdio functions by merging Wine's msvcrt code adapted...
Aleksey Bragin [Wed, 11 Jun 2008 08:54:46 +0000 (08:54 +0000)]
- Completely rewrite most of stdio functions by merging Wine's msvcrt code adapted for ReactOS.
- Leave and refactor existing underlying linux-code based sprintf implementation into lnx_ prefixed functions.
- Misc source code and headers cleanup.
- Fixes bugs 2910, 2803.
See issue #2803 for more details.

svn path=/trunk/; revision=33927

14 years agoFix warnings.
James Tabor [Wed, 11 Jun 2008 04:45:42 +0000 (04:45 +0000)]
Fix warnings.

svn path=/trunk/; revision=33926

14 years agoMore IDeskBar support
Thomas Bluemel [Wed, 11 Jun 2008 03:52:45 +0000 (03:52 +0000)]
More IDeskBar support

svn path=/trunk/; revision=33925

14 years agoImprove IBandSite support a bit
Thomas Bluemel [Wed, 11 Jun 2008 03:37:56 +0000 (03:37 +0000)]
Improve IBandSite support a bit

svn path=/trunk/; revision=33924

14 years agoFix a small bug
Thomas Bluemel [Wed, 11 Jun 2008 03:36:21 +0000 (03:36 +0000)]
Fix a small bug

svn path=/trunk/; revision=33923

14 years agoRetool SetSysColors and use SEH.
James Tabor [Tue, 10 Jun 2008 21:57:16 +0000 (21:57 +0000)]
Retool SetSysColors and use SEH.

svn path=/trunk/; revision=33922

14 years agoEnable the user to modify the profile information of a user account.
Eric Kohl [Tue, 10 Jun 2008 21:56:19 +0000 (21:56 +0000)]
Enable the user to modify the profile information of a user account.

svn path=/trunk/; revision=33921

14 years agoUse server information for GetSystemMetrics.
James Tabor [Tue, 10 Jun 2008 21:09:31 +0000 (21:09 +0000)]
Use server information for GetSystemMetrics.

svn path=/trunk/; revision=33920

14 years agoMatthias Kupfer (matthias DOT kupfer AT informatik DOT tu-chemnitz DOT de)
Colin Finck [Tue, 10 Jun 2008 19:19:59 +0000 (19:19 +0000)]
Matthias Kupfer (matthias DOT kupfer AT informatik DOT tu-chemnitz DOT de)
- Give the Run Dialog resources a default title (only done in German and English resources so far, others still need to be done)
- Add support for passing no title to RunFileDlg, so that it uses the default title
- Pass no hardcoded english title in Explorer and Task-Manager.
  I slightly modified the patch to also remove the other hardcoded text passed in Explorer.

See issue #3340 for more details.

svn path=/trunk/; revision=33919

14 years agoFix build, add float to long union for dword transfer.
James Tabor [Tue, 10 Jun 2008 05:48:18 +0000 (05:48 +0000)]
Fix build, add float to long union for dword transfer.

svn path=/trunk/; revision=33918

14 years agoMove NtGdiAngleArc to arc.c.
James Tabor [Tue, 10 Jun 2008 05:25:37 +0000 (05:25 +0000)]
Move NtGdiAngleArc to arc.c.

svn path=/trunk/; revision=33917

14 years agoMove AngleArc out of stubs.
James Tabor [Tue, 10 Jun 2008 05:14:35 +0000 (05:14 +0000)]
Move AngleArc out of stubs.

svn path=/trunk/; revision=33916

14 years agoshlwapi.dll is already loaded, no need to use LoadLibrary
Thomas Bluemel [Tue, 10 Jun 2008 03:13:12 +0000 (03:13 +0000)]
shlwapi.dll is already loaded, no need to use LoadLibrary

svn path=/trunk/; revision=33915

14 years ago- Don't lookup DrawCaptionTempA/W by ordinal but rather by name
Thomas Bluemel [Tue, 10 Jun 2008 02:58:13 +0000 (02:58 +0000)]
- Don't lookup DrawCaptionTempA/W by ordinal but rather by name
- Various minor fixes

svn path=/trunk/; revision=33914

14 years agoDo a more correct check in EDIT_IsInsideDialog ()
Thomas Bluemel [Tue, 10 Jun 2008 00:31:10 +0000 (00:31 +0000)]
Do a more correct check in EDIT_IsInsideDialog ()

svn path=/trunk/; revision=33913

14 years agofix an endless loop bug
Timo Kreuzer [Mon, 9 Jun 2008 20:57:30 +0000 (20:57 +0000)]
fix an endless loop bug
See issue #2142 for more details.

svn path=/trunk/; revision=33912

14 years agoFixed four more winetests, code taken from wine again
Gregor Brunmar [Mon, 9 Jun 2008 19:14:36 +0000 (19:14 +0000)]
Fixed four more winetests, code taken from wine again

svn path=/trunk/; revision=33910

14 years agoFixed 11 winetests for edit boxes based on code from wine but tweaked for ReactOS
Gregor Brunmar [Mon, 9 Jun 2008 19:07:54 +0000 (19:07 +0000)]
Fixed 11 winetests for edit boxes based on code from wine but tweaked for ReactOS

svn path=/trunk/; revision=33909

14 years agoadd simple TTF icon to fontview
Timo Kreuzer [Mon, 9 Jun 2008 18:10:02 +0000 (18:10 +0000)]
add simple TTF icon to fontview

svn path=/trunk/; revision=33908

14 years ago- Fix Ellipes, for Filip Navara, nice work!
James Tabor [Mon, 9 Jun 2008 16:46:52 +0000 (16:46 +0000)]
- Fix Ellipes, for Filip Navara, nice work!
- Ref:
- Test:

svn path=/trunk/; revision=33907

14 years agoMove old pie code into arc.
James Tabor [Sun, 8 Jun 2008 19:00:50 +0000 (19:00 +0000)]
Move old pie code into arc.

svn path=/trunk/; revision=33906

14 years ago- Update dciddi.h header based on Magnus's patch.
Aleksey Bragin [Sun, 8 Jun 2008 18:26:22 +0000 (18:26 +0000)]
- Update dciddi.h header based on Magnus's patch.
- Fix dciman32.dll compilation.

svn path=/trunk/; revision=33905

14 years agoSynced shlwapi_winetest.exe with Wine HEAD
Pierre Schweitzer [Sun, 8 Jun 2008 17:14:50 +0000 (17:14 +0000)]
Synced shlwapi_winetest.exe with Wine HEAD

svn path=/trunk/; revision=33904

14 years agoSySynced shlwapi.dll with Wine HEAD
Pierre Schweitzer [Sun, 8 Jun 2008 17:13:54 +0000 (17:13 +0000)]
SySynced shlwapi.dll with Wine HEAD

svn path=/trunk/; revision=33903

14 years ago- Remove duplicate code
Dmitry Chapyshev [Sun, 8 Jun 2008 15:04:00 +0000 (15:04 +0000)]
- Remove duplicate code
- Fix formatting
- Add checking parameters for more functions

svn path=/trunk/; revision=33902

14 years ago- User properties:
Eric Kohl [Sun, 8 Jun 2008 13:34:42 +0000 (13:34 +0000)]
- User properties:
  Fix a memory leak.
  Enable the Apply button when the users full name or description is changed.
- Group properties:
  The group description can be changed.
  Update the group list when the group description changes.

svn path=/trunk/; revision=33901

14 years agoFix debug message
Hervé Poussineau [Sun, 8 Jun 2008 09:52:56 +0000 (09:52 +0000)]
Fix debug message

svn path=/trunk/; revision=33899

14 years ago- Add gdiplus test to bootcd
Dmitry Chapyshev [Sun, 8 Jun 2008 09:49:48 +0000 (09:49 +0000)]
- Add gdiplus test to bootcd

svn path=/trunk/; revision=33898

14 years ago- Add wine test for gdiplus
Dmitry Chapyshev [Sun, 8 Jun 2008 09:47:47 +0000 (09:47 +0000)]
- Add wine test for gdiplus

svn path=/trunk/; revision=33897

14 years agoadd dummy test for dciman32 for now, real test will come later
Magnus Olsen [Sun, 8 Jun 2008 08:29:04 +0000 (08:29 +0000)]
add dummy test for dciman32 for now, real test will come later

svn path=/trunk/; revision=33896

14 years ago- Magnus: Reformat clip.c source code to better match overall coding style. No code...
Aleksey Bragin [Sun, 8 Jun 2008 07:31:10 +0000 (07:31 +0000)]
- Magnus: Reformat clip.c source code to better match overall coding style. No code logic change.

svn path=/trunk/; revision=33895

14 years agoUpdate NtUserInitializeClientPfnArrays add additional structures and types for future...
James Tabor [Sun, 8 Jun 2008 03:34:25 +0000 (03:34 +0000)]
Update NtUserInitializeClientPfnArrays add additional structures and types for future support.

svn path=/trunk/; revision=33894

14 years agoFix some region leaks: GdiSelectVisRgn copies the region, so the given one it must...
Timo Kreuzer [Sun, 8 Jun 2008 00:43:07 +0000 (00:43 +0000)]
Fix some region leaks: GdiSelectVisRgn copies the region, so the given one it must be deleted afterwards. This code is not perfect ~ as Jim already said, not completed. But it's at least working correctly now. Say welcome to a stable running Firefox 1.5.
Also added some DPRINTs on failures.

svn path=/trunk/; revision=33893

14 years agoReal fix for the broken netapi32.dll.
Eric Kohl [Sat, 7 Jun 2008 22:50:55 +0000 (22:50 +0000)]
Real fix for the broken netapi32.dll.

svn path=/trunk/; revision=33892

14 years agoFix for broken netapi32.dll.
Eric Kohl [Sat, 7 Jun 2008 22:44:15 +0000 (22:44 +0000)]
Fix for broken netapi32.dll.

svn path=/trunk/; revision=33891

14 years ago- Group properties: Display the SID of well-known members.
Eric Kohl [Sat, 7 Jun 2008 22:31:24 +0000 (22:31 +0000)]
- Group properties: Display the SID of well-known members.
- User properties: Store changes to the general settings.

svn path=/trunk/; revision=33890

14 years agoWrite the complete error message to debug log, instead of partial information
Hervé Poussineau [Sat, 7 Jun 2008 20:44:57 +0000 (20:44 +0000)]
Write the complete error message to debug log, instead of partial information

svn path=/trunk/; revision=33889

14 years ago- Cleanup leftovers and bugs from GreatLord's fix. I think this is my last "postfix...
Aleksey Bragin [Sat, 7 Jun 2008 12:58:48 +0000 (12:58 +0000)]
- Cleanup leftovers and bugs from GreatLord's fix. I think this is my last "postfix" of GreatLord's commits to trunk.

svn path=/trunk/; revision=33886

14 years agoBugFix : NtGdiStretchDIBitsInternal
Magnus Olsen [Sat, 7 Jun 2008 11:35:53 +0000 (11:35 +0000)]
BugFix : NtGdiStretchDIBitsInternal
it did not check after some NULL pointer and did crash in firefox.
and some reason  NtGdiCreateCompatibleBitmap fail in some case, that what happen in firefox 1.5.

svn path=/trunk/; revision=33885

14 years agofix one winetest for Bitmap and add note why some alpha blend test fails.
Magnus Olsen [Sat, 7 Jun 2008 10:15:38 +0000 (10:15 +0000)]
fix one winetest for Bitmap and add note why some alpha blend test fails.

svn path=/trunk/; revision=33884

14 years agoFixed Alphablend crash in win32k
Magnus Olsen [Sat, 7 Jun 2008 09:43:35 +0000 (09:43 +0000)]
Fixed Alphablend crash in win32k

svn path=/trunk/; revision=33883

14 years ago- Revert 33881, PatBlt may be buggy, but what was introduced in 33881 was a non-worki...
Aleksey Bragin [Sat, 7 Jun 2008 09:20:05 +0000 (09:20 +0000)]
- Revert 33881, PatBlt may be buggy, but what was introduced in 33881 was a non-working hack. Unregresses FF2.0 installer having a black rectangle in the bottom of its window.

svn path=/trunk/; revision=33882

14 years agodisable NtGdiPatBlt code, in some case it can cause random crash and have some graphi...
Magnus Olsen [Sat, 7 Jun 2008 07:58:39 +0000 (07:58 +0000)]
disable NtGdiPatBlt code, in some case it can cause random crash and have some graphic glichters it need be rewrite.

svn path=/trunk/; revision=33881

14 years agorevert some change I did in r33877 for buch.c object it cause to many regress
Magnus Olsen [Sat, 7 Jun 2008 07:22:09 +0000 (07:22 +0000)]
revert some change I did in r33877 for buch.c object it cause to many regress

svn path=/trunk/; revision=33880

14 years agoThis does fix bug 3237. I've run this patch for two months now, it is still in the...
James Tabor [Sat, 7 Jun 2008 02:58:15 +0000 (02:58 +0000)]
This does fix bug 3237. I've run this patch for two months now, it is still in the rough and needs cleaning up. Separates Owned and Class styles and gives them their own DCes.

svn path=/trunk/; revision=33879

14 years agosmall cleanup thx irc: aicom for notice this.
Magnus Olsen [Sat, 7 Jun 2008 01:18:55 +0000 (01:18 +0000)]
small cleanup thx irc: aicom for notice this.

svn path=/trunk/; revision=33878