reactos.git
3 years ago[REISERFS]
Pierre Schweitzer [Sat, 25 Feb 2017 10:16:33 +0000 (10:16 +0000)]
[REISERFS]
When compiling the driver with GCC, define __GCC__.
Fix defines accordingly.

CORE-12826

svn path=/trunk/; revision=73901

3 years ago[WIN32SS] Rewrite font selection code. Patch by Katayama Hirofumi MZ. CORE-6621
Mark Jansen [Sat, 25 Feb 2017 10:10:25 +0000 (10:10 +0000)]
[WIN32SS] Rewrite font selection code. Patch by Katayama Hirofumi MZ. CORE-6621
- Adding support for multiple font formats (including collections)
- Choosing a font based on weights as documented
- Adding support for loading fonts from memory
- Share font faces
- Emulation of Italic and Bold
- Support for Underline and Strike-out
- Localized font names
- Fix GetFontResourceInfoW
- Fix Registry settings
- Fix multiple font properties

svn path=/trunk/; revision=73900

3 years ago[COMCTL32] -Redraw the button when we get a WM_THEMECHANGED.
Giannis Adamopoulos [Sat, 25 Feb 2017 09:24:40 +0000 (09:24 +0000)]
[COMCTL32] -Redraw the button when we get a WM_THEMECHANGED.

svn path=/trunk/; revision=73899

3 years ago[UXTHEME] - When we set the desired app name and class name in SetWindowTheme we...
Giannis Adamopoulos [Sat, 25 Feb 2017 09:23:37 +0000 (09:23 +0000)]
[UXTHEME] - When we set the desired app name and class name in SetWindowTheme we need to support empty strings meaning no themes for this window. Sort of support empty strings by replacing them with a string containing a single "0". This works since there is no app name or class name with this name. Also add some error messages.

svn path=/trunk/; revision=73898

3 years ago[COMCTL32] -Draw button with classic style if BM_SETIMAGE was used.
Giannis Adamopoulos [Fri, 24 Feb 2017 22:47:59 +0000 (22:47 +0000)]
[COMCTL32] -Draw button with classic style if BM_SETIMAGE was used.

svn path=/trunk/; revision=73897

3 years ago[GDI32]: Don't break/crash (if no debugger attached) each time an unimplemented GDI...
Hermès Bélusca-Maïto [Fri, 24 Feb 2017 02:17:45 +0000 (02:17 +0000)]
[GDI32]: Don't break/crash (if no debugger attached) each time an unimplemented GDI function is called. This is hit a lot by Word 2010 (e.g. when using drawing features), PowerPoint, etc... i.e. all applications that perform "serious" GDI manipulations.
A nice addition would be to know exactly which unimplemented function was called.

svn path=/trunk/; revision=73896

3 years ago[NTGDI]: Few fixes & hacks for NtGdiGetGlyphIndicesW, see CORE-12825:
Hermès Bélusca-Maïto [Fri, 24 Feb 2017 01:52:25 +0000 (01:52 +0000)]
[NTGDI]: Few fixes & hacks for NtGdiGetGlyphIndicesW, see CORE-12825:
- (Fix) Check for integer count overflow (per Thomas suggestion),
- (Hack#1) Signal the particular calling case (where pwc == NULL == pgi and cwc == 0), as discovered by the testcase of r73894,
- (Hack#2) Return error when cwc == 0 alone (triggered by e.g. Word 2010).

svn path=/trunk/; revision=73895

3 years ago[GDI32_APITEST]: GetGlyphIndices: Have fun & make ReactOS BSoD from user-mode! More...
Hermès Bélusca-Maïto [Fri, 24 Feb 2017 01:02:26 +0000 (01:02 +0000)]
[GDI32_APITEST]: GetGlyphIndices: Have fun & make ReactOS BSoD from user-mode! More seriously, test extra cases of this API, and show that our current implementation certainly is incomplete & prone to bugs.
The particular case "GetGlyphIndicesW(hdc, NULL, 0, NULL, 0)" is used by Word 2010 (and other apps) when opening the font combolist, and seems to be undocumented.
CORE-12825
CORE-6621 CORE-12279

svn path=/trunk/; revision=73894

3 years ago* Addendum to r73870.
Amine Khaldi [Thu, 23 Feb 2017 19:09:35 +0000 (19:09 +0000)]
* Addendum to r73870.

svn path=/trunk/; revision=73893

3 years ago[USBSTOR]
Thomas Faber [Thu, 23 Feb 2017 09:28:20 +0000 (09:28 +0000)]
[USBSTOR]
- Fix error paths around SCSI_REQUEST_BLOCK::DataBuffer. Spotted by curiousone.
CORE-12816 #resolve

svn path=/trunk/; revision=73892

3 years ago[USBSTOR]
Thomas Faber [Thu, 23 Feb 2017 09:20:09 +0000 (09:20 +0000)]
[USBSTOR]
- Use pool tagging

svn path=/trunk/; revision=73891

3 years ago[WIN32K]
Kamil Hornicek [Wed, 22 Feb 2017 21:18:18 +0000 (21:18 +0000)]
[WIN32K]
- Clean up after myself. Thanks, Giannis and Thomas.

svn path=/trunk/; revision=73890

3 years ago[WIN32K]: Replace some checks against UserGetDesktopWindow() and UserGetMessageWindow...
Hermès Bélusca-Maïto [Wed, 22 Feb 2017 20:19:50 +0000 (20:19 +0000)]
[WIN32K]: Replace some checks against UserGetDesktopWindow() and UserGetMessageWindow() by checks against FNID_xxx flags.
Fixes some FIXMEs in the code encountered while investigating the origin of "err: NtUserSetWindowPos bad window handle!" messages.
Reviewed by James Tabor.
CORE-12819

svn path=/trunk/; revision=73889

3 years ago[Win32SS]
James Tabor [Wed, 22 Feb 2017 17:50:38 +0000 (17:50 +0000)]
[Win32SS]
- Implement Exclude Update Region, for testing. See CORE-12649.

svn path=/trunk/; revision=73888

3 years ago[Win32SS]
James Tabor [Wed, 22 Feb 2017 17:45:19 +0000 (17:45 +0000)]
[Win32SS]
- Implement Fill Window, for testing.

svn path=/trunk/; revision=73887

3 years ago[NtGDI]
James Tabor [Wed, 22 Feb 2017 17:20:43 +0000 (17:20 +0000)]
[NtGDI]
- Add function for NtUser.

svn path=/trunk/; revision=73886

3 years ago[COMCTL32] -Fix several tests for the v6 button when themes are enabled.
Giannis Adamopoulos [Wed, 22 Feb 2017 13:58:49 +0000 (13:58 +0000)]
[COMCTL32] -Fix several tests for the v6 button when themes are enabled.

svn path=/trunk/; revision=73885

3 years ago[COMCTL32] -Fix a couple more button tests.
Giannis Adamopoulos [Wed, 22 Feb 2017 13:24:17 +0000 (13:24 +0000)]
[COMCTL32] -Fix a couple more button tests.

svn path=/trunk/; revision=73884

3 years ago[COMCTL32_WINETEST] -Do not take into account the wine todos for the button tests.
Giannis Adamopoulos [Wed, 22 Feb 2017 12:31:40 +0000 (12:31 +0000)]
[COMCTL32_WINETEST] -Do not take into account the wine todos for the button tests.

svn path=/trunk/; revision=73883

3 years ago[WIN32k] -Remove overzealous assertion that prevents boot.
Giannis Adamopoulos [Wed, 22 Feb 2017 11:59:42 +0000 (11:59 +0000)]
[WIN32k] -Remove overzealous assertion that prevents boot.

svn path=/trunk/; revision=73882

3 years ago[NTGDI]
Kamil Hornicek [Wed, 22 Feb 2017 10:48:41 +0000 (10:48 +0000)]
[NTGDI]
- Check for zero rectangles in REGION_bXformRgn.
CORE-12204

svn path=/trunk/; revision=73881

3 years ago[COMCTL32]: Fix a few button tests.
Giannis Adamopoulos [Wed, 22 Feb 2017 10:46:26 +0000 (10:46 +0000)]
[COMCTL32]: Fix a few button tests.

svn path=/trunk/; revision=73880

3 years ago[NTUSER]
Kamil Hornicek [Wed, 22 Feb 2017 10:29:03 +0000 (10:29 +0000)]
[NTUSER]
- Prevent a null to be passed to UserDereferenceObject in UserSetCursorIconData. CID 1321971
- Make the status check in co_IntCallSentMessageCallback less useless. CID 1322014
- Prevent a null pointer dereference in a trace in IntCreateClass. CID 514617

svn path=/trunk/; revision=73879

3 years ago[NTGDI]
Kamil Hornicek [Wed, 22 Feb 2017 10:26:40 +0000 (10:26 +0000)]
[NTGDI]
- Consider the return value from IntFillArc in IntArc. CID 1237076
- Remove an useless check in ENTRY_ReferenceEntryByHandle CID 731587
- Prevent an unlikely memory leak in PATH_WidenPath. CID 716634
- Minor cleanup.

svn path=/trunk/; revision=73878

3 years ago[GDI32]
Kamil Hornicek [Wed, 22 Feb 2017 10:22:28 +0000 (10:22 +0000)]
[GDI32]
- Fix a possible null pointer dereference in GetGlyphOutlineA. CID 513747
- SetDIBits should not accept null bitmap info at all. CID 513425
- Don't set the pdwResult pointer itself to null in TADC_GetAndSetDCDWord. CID 1321970

svn path=/trunk/; revision=73877

3 years ago[NtUser]
James Tabor [Wed, 22 Feb 2017 00:25:13 +0000 (00:25 +0000)]
[NtUser]
- If an appication hangs other than suspended use Hung test to prevent locking the whole system. Quick fix for CORE-10078.

svn path=/trunk/; revision=73876

3 years ago[NtUser]
James Tabor [Wed, 22 Feb 2017 00:01:13 +0000 (00:01 +0000)]
[NtUser]
- Fix : Allow controls to receive non-client messages. See CORE-12771.
- See also https://bugs.winehq.org/show_bug.cgi?id=42503 .

svn path=/trunk/; revision=73875

3 years agoFix build.
Giannis Adamopoulos [Tue, 21 Feb 2017 21:53:34 +0000 (21:53 +0000)]
Fix build.

svn path=/trunk/; revision=73874

3 years ago[COMCTL32] -Rename BUTTON_Paint to BUTTON_PaintWithTheme and use it in the newly...
Giannis Adamopoulos [Tue, 21 Feb 2017 21:47:41 +0000 (21:47 +0000)]
[COMCTL32] -Rename BUTTON_Paint to BUTTON_PaintWithTheme and use it in the newly added code for the v6 button.

svn path=/trunk/; revision=73873

3 years ago[COMCTL32] -Add a comment to clarify that there is no need to backport the #ifdef...
Giannis Adamopoulos [Tue, 21 Feb 2017 21:07:06 +0000 (21:07 +0000)]
[COMCTL32] -Add a comment to clarify that there is no need to backport the #ifdef _USER32_ defines back to user32 (although they will work fine in user32).

svn path=/trunk/; revision=73872

3 years ago[COMCTL32]: Copy button.c from user32, make the needed changes to make it compile...
Giannis Adamopoulos [Tue, 21 Feb 2017 21:03:04 +0000 (21:03 +0000)]
[COMCTL32]: Copy button.c from user32, make the needed changes to make it compile and register it. This is the beginning of the v6 button. Remove the subclassing of the builtin button.

svn path=/trunk/; revision=73871

3 years ago* Revert r73869 because wmi was mentioned nowhere in CORE-9111, nor in our tree restr...
Amine Khaldi [Tue, 21 Feb 2017 09:04:05 +0000 (09:04 +0000)]
* Revert r73869 because wmi was mentioned nowhere in CORE-9111, nor in our tree restructure wiki, nor any developers discussions. This is the ReactOS trunk, not a branch.

svn path=/trunk/; revision=73870

3 years ago[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the...
Hermès Bélusca-Maïto [Mon, 20 Feb 2017 23:28:09 +0000 (23:28 +0000)]
[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the ReactOS source code tree restructure. This gives an idea how this can be done for other ReactOS components.
CORE-9111

svn path=/trunk/; revision=73869

3 years ago[SECUR32]: As an interim step towards a proper NTLM implementation that is done by...
Hermès Bélusca-Maïto [Mon, 20 Feb 2017 22:28:07 +0000 (22:28 +0000)]
[SECUR32]: As an interim step towards a proper NTLM implementation that is done by Samuel Serapion, I temporarily commit Wine's NTLM code layer around Samba's "ntlm_auth" utility. In addition I add the kerberos & negotiate stubs too.
This is not a problem on Wine, because they run on Linux distributions, most of which have Samba available. But this is not the case on Windows / ReactOS, so few adaptations were needed: in the dispatcher.c code, the fork_helper function was partially rewritten around CreateProcess to start the ntlm_auth utility (I try to use maximally the CRT to not have to rewrite other functions). This works great.
But then, to make this NTLM layer working on ReactOS, one has to find a Windows build of Samba. Here is one: http://smithii.com/samba . This is a Samba 3.0.23c build. You need to follow *exactly* the manual installation steps to make it work (actually, everything up to "Step 6" included, i.e. running smbsetup.cmd). This means in particular to copy Samba into C:\Program Files\samba, as this path is also hardcoded into the executables.
As the Wine's NTLM layer expects Samba 3.0.25+, I manually downgraded the expected version, which appears to still work nice for the needs of Office 2010 installation.

You can now play with it and try to install Office 2010.

CORE-12601 #comment Wine's NTLM layer committed in r73868 as an interim step towards a proper implementation.
CORE-12279

svn path=/trunk/; revision=73868

3 years ago[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last...
Hermès Bélusca-Maïto [Mon, 20 Feb 2017 20:47:42 +0000 (20:47 +0000)]
[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last step in the installation of Office 2010.
CORE-12811 #resolve
CORE-12279

svn path=/trunk/; revision=73867

3 years ago[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared...
Giannis Adamopoulos [Mon, 20 Feb 2017 20:18:10 +0000 (20:18 +0000)]
[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared Smudde. CORE-12805

svn path=/trunk/; revision=73866

3 years ago[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch...
Giannis Adamopoulos [Mon, 20 Feb 2017 20:13:22 +0000 (20:13 +0000)]
[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch by Victor Martinez Calvo. CORE-12799. CID 1401249

svn path=/trunk/; revision=73865

3 years ago[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805
Giannis Adamopoulos [Mon, 20 Feb 2017 19:51:12 +0000 (19:51 +0000)]
[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805

svn path=/trunk/; revision=73864

3 years ago[MSWSOCK]
Thomas Faber [Mon, 20 Feb 2017 19:32:12 +0000 (19:32 +0000)]
[MSWSOCK]
- Eliminate dead code in NSP_LookupServiceNextW. Patch by Víctor Martínez Calvo. CID 1400942
CORE-12806 #resolve

svn path=/trunk/; revision=73863

3 years ago[USER32][UXTHEME]
Thomas Faber [Mon, 20 Feb 2017 17:31:50 +0000 (17:31 +0000)]
[USER32][UXTHEME]
- Make API hooks type-safe. Fixes stack pointer corruption when calling ThemeGetScrollInfo. Powered by /RTC1

svn path=/trunk/; revision=73862

3 years ago[WS2_32]
Thomas Faber [Mon, 20 Feb 2017 16:33:44 +0000 (16:33 +0000)]
[WS2_32]
- Re-apply null termination fix in GetProtoGetNextEnt, which was lost in ws2_32_new work. CID 716700
CORE-11218

svn path=/trunk/; revision=73861

3 years ago[BROWSEUI]
Thomas Faber [Mon, 20 Feb 2017 16:07:05 +0000 (16:07 +0000)]
[BROWSEUI]
- Correctly pass the buffer size to RegQueryValueW in CAutoComplete::Init. Patch by Víctor Martínez Calvo. CID 1401255
CORE-12795 #resolve

svn path=/trunk/; revision=73860

3 years ago[FREELDR]: Update the FreeLdr's startup notes.
Hermès Bélusca-Maïto [Mon, 20 Feb 2017 15:45:01 +0000 (15:45 +0000)]
[FREELDR]: Update the FreeLdr's startup notes.

svn path=/trunk/; revision=73859

3 years ago[EVENTLOG]
Kamil Hornicek [Mon, 20 Feb 2017 14:45:03 +0000 (14:45 +0000)]
[EVENTLOG]
- Silence some debug prints. This commit bears the "Hermès' seal of approval".

svn path=/trunk/; revision=73858

3 years ago[WINPRINT]
Thomas Faber [Mon, 20 Feb 2017 12:00:13 +0000 (12:00 +0000)]
[WINPRINT]
- Avoid uninitialized hPrintMonitor in PrintRawJob failure case. Patch by Víctor Martínez Calvo
CORE-12792 #resolve

svn path=/trunk/; revision=73857

3 years ago[KS]
Thomas Faber [Mon, 20 Feb 2017 11:35:24 +0000 (11:35 +0000)]
[KS]
- Avoid leaking AllocatorFraming in KsCreateDefaultAllocatorEx. Patch by Sebastian Gasiorek
CORE-12797 #resolve

svn path=/trunk/; revision=73856

3 years ago[WIN32K]
Kamil Hornicek [Mon, 20 Feb 2017 10:10:37 +0000 (10:10 +0000)]
[WIN32K]
- Don't try to delete the pattern bitmap in UserInitialize.
- Set the correct owner before deleting the update region in co_UserFreeWindow.
- Fixes some "Trying to delete global object" debug prints.

svn path=/trunk/; revision=73855

3 years ago[blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana
Giannis Adamopoulos [Sun, 19 Feb 2017 20:40:45 +0000 (20:40 +0000)]
[blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana

svn path=/trunk/; revision=73854

3 years ago[COMCTL32]
Eric Kohl [Sun, 19 Feb 2017 20:39:11 +0000 (20:39 +0000)]
[COMCTL32]
Update a tool buttons tooltip rectangle when the button gets hidden.
Patch will be sent upstream!
CORE-12667 #resolve

svn path=/trunk/; revision=73853

3 years ago[DEVMGR]
Eric Kohl [Sun, 19 Feb 2017 19:40:04 +0000 (19:40 +0000)]
[DEVMGR]
- NEVER EVER use single line if statements!!!!
- Fix indentation and coding style.

svn path=/trunk/; revision=73852

3 years ago[DEVMGR]
Eric Kohl [Sun, 19 Feb 2017 19:13:41 +0000 (19:13 +0000)]
[DEVMGR]
Hide "HTREE\ROOT\0" from the device tree.
CORE-12670 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=73851

3 years ago[DEVMGR]
Eric Kohl [Sun, 19 Feb 2017 18:31:52 +0000 (18:31 +0000)]
[DEVMGR]
Select a treeview item on a right click.

svn path=/trunk/; revision=73850

3 years ago[MSAFD][WS2_32]
Thomas Faber [Sun, 19 Feb 2017 17:50:34 +0000 (17:50 +0000)]
[MSAFD][WS2_32]
- Properly return error codes from WSPConnect
CORE-12787 #resolve

svn path=/trunk/; revision=73849

3 years ago[EVENTVWR]
Pierre Schweitzer [Sun, 19 Feb 2017 17:24:13 +0000 (17:24 +0000)]
[EVENTVWR]
Don't attempt to free random address

CID 1401231

svn path=/trunk/; revision=73848

3 years ago[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric...
Giannis Adamopoulos [Sun, 19 Feb 2017 16:32:44 +0000 (16:32 +0000)]
[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric id to GetSysColor. CORE-11086

svn path=/trunk/; revision=73847

3 years ago[ACPI]
Eric Kohl [Sun, 19 Feb 2017 15:13:49 +0000 (15:13 +0000)]
[ACPI]
Generate a proper device id string for processor devices.

svn path=/trunk/; revision=73846

3 years ago[SHELL32]
Pierre Schweitzer [Sun, 19 Feb 2017 13:22:02 +0000 (13:22 +0000)]
[SHELL32]
For the input string, WideCharToMultiByte takes a char count and not a buffer size.

CID 14010961401088

svn path=/trunk/; revision=73845

3 years ago[SHELL32]
Pierre Schweitzer [Sun, 19 Feb 2017 13:00:12 +0000 (13:00 +0000)]
[SHELL32]
Don't attempt to dereference a pointer after having freed it

CID 1401297

svn path=/trunk/; revision=73844

3 years ago[WS2_32]
Pierre Schweitzer [Sun, 19 Feb 2017 12:52:14 +0000 (12:52 +0000)]
[WS2_32]
Remove duplicated if

CID 1400935

svn path=/trunk/; revision=73843

3 years ago[DNSAPI]
Pierre Schweitzer [Sun, 19 Feb 2017 12:42:08 +0000 (12:42 +0000)]
[DNSAPI]
Properly check for domain name being set

CID 1401070

svn path=/trunk/; revision=73842

3 years ago[WSHTCPIP]
Thomas Faber [Sun, 19 Feb 2017 12:21:06 +0000 (12:21 +0000)]
[WSHTCPIP]
- Fix incorrect sizeof in SHIoctl_GetInterfaceList. CID 1401188

svn path=/trunk/; revision=73841

3 years ago[WS2_32]
Thomas Faber [Sun, 19 Feb 2017 12:05:48 +0000 (12:05 +0000)]
[WS2_32]
- Fix ridiculous over-casting

svn path=/trunk/; revision=73840

3 years ago[WS2_32]
Thomas Faber [Sun, 19 Feb 2017 11:44:18 +0000 (11:44 +0000)]
[WS2_32]
- Fix wrong ServLength in getnameinfo, again, since it got lost in the ws2_32_new work. CID 716150
CORE-11214

svn path=/trunk/; revision=73839

3 years ago[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776
Giannis Adamopoulos [Sun, 19 Feb 2017 11:41:23 +0000 (11:41 +0000)]
[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776

svn path=/trunk/; revision=73838

3 years ago[DNSAPI]
Pierre Schweitzer [Sun, 19 Feb 2017 11:34:00 +0000 (11:34 +0000)]
[DNSAPI]
Properly check for domain name being set

CID 1401080

svn path=/trunk/; revision=73837

3 years ago[FASTFAT]
Pierre Schweitzer [Sun, 19 Feb 2017 11:22:21 +0000 (11:22 +0000)]
[FASTFAT]
Avoid uninit variable usage.

CID 14012571401259

svn path=/trunk/; revision=73836

3 years ago[LOCALMON]
Thomas Faber [Sun, 19 Feb 2017 10:31:37 +0000 (10:31 +0000)]
[LOCALMON]
- Avoid a potential double free in InitializePrintMonitor2. CID 1401299
- Avoid a use after free in LocalmonClosePort. CID 1401298

svn path=/trunk/; revision=73835

3 years ago[UXTHEME] -The code to draw the classic style borders was copied from win32k, so...
Giannis Adamopoulos [Sun, 19 Feb 2017 10:23:26 +0000 (10:23 +0000)]
[UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667

svn path=/trunk/; revision=73834

3 years ago[SHELL32] -Try to fix themes when opening the control panel applet from the control...
Giannis Adamopoulos [Sun, 19 Feb 2017 09:10:03 +0000 (09:10 +0000)]
[SHELL32] -Try to fix themes when opening the control panel applet from the control panel.

svn path=/trunk/; revision=73833

3 years ago[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek...
Mark Jansen [Sat, 18 Feb 2017 22:54:31 +0000 (22:54 +0000)]
[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!

svn path=/trunk/; revision=73832

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 21:37:56 +0000 (21:37 +0000)]
[FASTFAT]
Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.

svn path=/trunk/; revision=73831

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 21:24:31 +0000 (21:24 +0000)]
[FASTFAT]
Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.
This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.
A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.

This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.
The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.

svn path=/trunk/; revision=73830

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 18 Feb 2017 18:35:48 +0000 (18:35 +0000)]
[FASTFAT]
Move ReadVolumeLabel() to fsctl.c close to functions that need it

svn path=/trunk/; revision=73829

3 years ago[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case...
Giannis Adamopoulos [Sat, 18 Feb 2017 18:14:32 +0000 (18:14 +0000)]
[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.

svn path=/trunk/; revision=73828

3 years ago[KMTESTS:MM]
Thomas Faber [Sat, 18 Feb 2017 14:22:44 +0000 (14:22 +0000)]
[KMTESTS:MM]
- Add some stricter checks and improved error handling in NtCreateSection_user

svn path=/trunk/; revision=73827

3 years ago[USBSTOR]
Thomas Faber [Sat, 18 Feb 2017 11:47:40 +0000 (11:47 +0000)]
[USBSTOR]
- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077

svn path=/trunk/; revision=73826

3 years ago[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ...
Mark Jansen [Sat, 18 Feb 2017 11:25:31 +0000 (11:25 +0000)]
[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621

svn path=/trunk/; revision=73825

3 years ago[PSDK]
Thomas Faber [Sat, 18 Feb 2017 09:30:59 +0000 (09:30 +0000)]
[PSDK]
- Fix KsFilterFactoryGetDevice
CORE-11794

svn path=/trunk/; revision=73824

3 years ago[SHELL32]
Kamil Hornicek [Fri, 17 Feb 2017 23:39:39 +0000 (23:39 +0000)]
[SHELL32]
- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).

svn path=/trunk/; revision=73823

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 22:25:03 +0000 (22:25 +0000)]
[FASTFAT]
Generalize the usage of functions pointers for FatX vs Fat specific code (direntry).
This should also help speeding up FastFAT.

svn path=/trunk/; revision=73822

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 21:24:12 +0000 (21:24 +0000)]
[FASTFAT]
In the FCB, get rid of the FCB_IS_FATX_ENTRY flag. It makes no sense to have it on each and every file as the VCB already has such flag

svn path=/trunk/; revision=73821

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 18:06:38 +0000 (18:06 +0000)]
[FASTFAT]
Fix a typo brought in r73819

svn path=/trunk/; revision=73820

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 17:58:18 +0000 (17:58 +0000)]
[FASTFAT]
More FastFAT cleanup.
Except a light performances boost due to useless checks removal in read/write and to some functions inlining

More to follow...

svn path=/trunk/; revision=73819

3 years ago[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.
Giannis Adamopoulos [Fri, 17 Feb 2017 17:23:17 +0000 (17:23 +0000)]
[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.

svn path=/trunk/; revision=73818

3 years ago[DBGHELP] Add experimental rsym support. CORE-12773
Mark Jansen [Fri, 17 Feb 2017 16:18:15 +0000 (16:18 +0000)]
[DBGHELP] Add experimental rsym support. CORE-12773

svn path=/trunk/; revision=73817

3 years ago[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773
Mark Jansen [Fri, 17 Feb 2017 16:15:49 +0000 (16:15 +0000)]
[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773

svn path=/trunk/; revision=73816

3 years ago[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve
Mark Jansen [Fri, 17 Feb 2017 16:12:19 +0000 (16:12 +0000)]
[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve

svn path=/trunk/; revision=73815

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:58:26 +0000 (13:58 +0000)]
[LIBTIFF]
- Fix GCC non-PCH build
CORE-12775

svn path=/trunk/; revision=73814

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:43:05 +0000 (13:43 +0000)]
[LIBTIFF]
- Update to version 4.0.7
CORE-12775 #resolve

svn path=/trunk/; revision=73813

3 years ago[WIN32K]
Kamil Hornicek [Fri, 17 Feb 2017 13:13:36 +0000 (13:13 +0000)]
[WIN32K]
- The pattern bitmap can get deleted during the GDI cleanup for process before the brush itself.
- Gets rid of some of those pesky "GreDeleteObject: Trying to delete invalid object" debug prints.

svn path=/trunk/; revision=73812

3 years ago[LIBTIFF]
Thomas Faber [Fri, 17 Feb 2017 13:05:50 +0000 (13:05 +0000)]
[LIBTIFF]
- Use the official libtiff 4.0.3 def file to determine exported functions (instead of exporting everything in GCC builds, nothing in MSVC builds)
- Remove unused ROS-diffs
CORE-6898 CORE-12275

svn path=/trunk/; revision=73811

3 years ago[PING]
Kamil Hornicek [Fri, 17 Feb 2017 12:30:14 +0000 (12:30 +0000)]
[PING]
- Addendum to r73626. Convert the print specifiers too so that ping doesn't only output the old specifiers themselves.

svn path=/trunk/; revision=73810

3 years ago[WINDOWSCODECS]
Thomas Faber [Fri, 17 Feb 2017 12:17:20 +0000 (12:17 +0000)]
[WINDOWSCODECS]
- Fix some MSVC-specific definitions

svn path=/trunk/; revision=73809

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 11:38:05 +0000 (11:38 +0000)]
[FASTFAT]
Thomas->happiness++;

svn path=/trunk/; revision=73808

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 17 Feb 2017 11:08:38 +0000 (11:08 +0000)]
[FASTFAT]
Fix a few ugly things.
Both Thomas & cppcheck should be happier now!

svn path=/trunk/; revision=73807

3 years ago[WIN32k]
Giannis Adamopoulos [Fri, 17 Feb 2017 11:07:14 +0000 (11:07 +0000)]
[WIN32k]
 -Fix a couple of cases where we use the versioned class atom instead of the non versioned one.

[USER32]
- Add support for versioned classes in RegisterClassExWOWW, GetClassInfoExW, GetClassInfoExA, UnregisterClassA, UnregisterClassW, and User32CreateWindowEx
- Make ClassNameToVersion return the name of the versioned class and the library name that implements it while preserving a hack that lets user32 know which classes are registered by comctl32 (this is needed because the default activation context doesn't contain the non versioned classes yet).
- Make VersionRegisterClass to load the specified library and make it register its classes which is used when the class is not registered yet but its manifest is active.

svn path=/trunk/; revision=73806

3 years ago[LIBJPEG]
Thomas Faber [Fri, 17 Feb 2017 11:05:50 +0000 (11:05 +0000)]
[LIBJPEG]
- Update to version 9b
CORE-12775

svn path=/trunk/; revision=73805

3 years ago[LIBPNG]
Thomas Faber [Fri, 17 Feb 2017 10:42:03 +0000 (10:42 +0000)]
[LIBPNG]
- Update to version 1.6.28
CORE-12775

svn path=/trunk/; revision=73804

3 years ago[COMCTL32]
Giannis Adamopoulos [Fri, 17 Feb 2017 10:04:24 +0000 (10:04 +0000)]
[COMCTL32]
- Add and install a manifest for comctl32 version 5.82.
- Since our comctl32 tries to imitate both version 5 and version 6, register its classes twice, once while having the version 6 manifest active and once when having the version 5 active.
- Register the themed versions of the built in controls while having the version 6 manifest active (and register them as global classes). This breaks theming of built in controls until versioned classes get implemented.
- Do not try to subclass the dialog class. This is incorrect and can lead to problems like in CORE-8534, CORE-12727, CORE-8387. This removes the background texture of the themed tabs which will be implemented in the future in uxtheme using api hooks.
This breaks a great deal of theming but keep in mind that it is in the middle of a transition to have them implemented correctly without the terrible side effects (broken ansi conversion, not always  using themes for built in controls. However comctl32 is now ready for versioned classes to be enabled.
CORE-12285

svn path=/trunk/; revision=73803

3 years ago[SPIDER]
Kamil Hornicek [Wed, 15 Feb 2017 10:53:41 +0000 (10:53 +0000)]
[SPIDER]
- Make the formatting a bit more consistent.

[EVENTVWR]
- Remove an useless cast.

svn path=/trunk/; revision=73802