2 months ago[DOC] 3rd Party Files.txt: Add 'rdesktop' entry (#3333)
Serge Gautherie [Fri, 30 Oct 2020 12:35:49 +0000 (13:35 +0100)]
[DOC] 3rd Party Files.txt: Add 'rdesktop' entry (#3333)

2 months ago[BASESRV] Re-enable and actually fix the CsrValidateMessageBuffer() checks in BaseSrv... 3304/head
Hermès Bélusca-Maïto [Sat, 17 Oct 2020 14:40:50 +0000 (16:40 +0200)]
[BASESRV] Re-enable and actually fix the CsrValidateMessageBuffer() checks in BaseSrvDefineDosDevice(). (#3304)

Addendum to commit 0a392b18.

The actual problem that existed all along was that the buffers being
validated with CsrValidateMessageBuffer() were not the correct ones!

What had to be checked is the string buffer **INSIDE** the UNICODE_STRING
structures! Indeed, it is these buffers that we are allocating on client side,

Dedicated to Pierre Schweitzer.

2 months ago[CSRSRV] Clarify few comments, and use MAXULONG.
Hermès Bélusca-Maïto [Fri, 30 Oct 2020 00:08:23 +0000 (01:08 +0100)]
[CSRSRV] Clarify few comments, and use MAXULONG.

2 months ago[NTDLL_APITEST] Fix LdrEnumResources testdata initialization 3329/head
Mark Jansen [Wed, 28 Oct 2020 19:14:34 +0000 (20:14 +0100)]
[NTDLL_APITEST] Fix LdrEnumResources testdata initialization

2 months ago[PSDK] Import some SAL headers from MS
Timo Kreuzer [Sat, 24 Oct 2020 12:18:09 +0000 (14:18 +0200)]
[PSDK] Import some SAL headers from MS

Taken from

* Move _Check_return_opt_ and _Check_return_wat_ to crtdefs.h
* Update sal.h from
* Import no_sal2.h from MS and remove the one in NDK
* Import specstrings.h from MS
* Import specstrings_strict.h from MS
* Add specstrings_undef.h (based on defines in specstrings_strict.h)
* Remove __REACTOS__ hacks from cdfs

2 months ago[CMAKE] Make reactos_cab_inf really depend on reactos.inf
Jérôme Gardou [Wed, 28 Oct 2020 14:09:15 +0000 (15:09 +0100)]
[CMAKE] Make reactos_cab_inf really depend on reactos.inf

Instead of being always out of date & always trigger creation

2 months agoRevert "[CMAKE] Make unattended bootcd configurable via cmake"
Jérôme Gardou [Mon, 26 Oct 2020 17:11:55 +0000 (18:11 +0100)]
Revert "[CMAKE] Make unattended bootcd configurable via cmake"

This reverts commit cfd4ef9384eb1f2b55a5b195ee39475f015c8a7c.
This was way more controversial than I would have thought

2 months ago[RAPPS] Abort screenshot iteration on the first not found
Mark Jansen [Sun, 25 Oct 2020 19:30:03 +0000 (20:30 +0100)]
[RAPPS] Abort screenshot iteration on the first not found
This should decrease startup time / db parse time

2 months ago[RAPPS][RAPPS.COM] Introduce a rapps console shim 3252/head
Mark Jansen [Sun, 20 Sep 2020 20:18:08 +0000 (22:18 +0200)]
[RAPPS][RAPPS.COM] Introduce a rapps console shim will be launched when running 'rapps' from cmd or
from run, and since it is a console application, explorer/ cmd will
wait for it.
This passes the commandline to rapps.exe,
and wait for rapps.exe to exit before closing.


2 months ago[DBGHELP] Add missing support for AMD64. (#3083)
Carlo Bramini [Sun, 25 Oct 2020 11:30:37 +0000 (12:30 +0100)]
[DBGHELP] Add missing support for AMD64. (#3083)


2 months ago[WIN32SS] Repaint the whole window frame on some style bits set (#3199)
Doug Lyons [Sat, 24 Oct 2020 19:35:45 +0000 (14:35 -0500)]
[WIN32SS] Repaint the whole window frame on some style bits set (#3199)

This fixes the ReactOS Calculator buttons disappearing in CORE-16827

2 months ago[FASTFAT] Implement the overflow queue. CORE-17344 CORE-17328 3305/head
Thomas Faber [Sun, 18 Oct 2020 13:23:52 +0000 (15:23 +0200)]
[FASTFAT] Implement the overflow queue. CORE-17344 CORE-17328

This avoids blocking all Ex worker threads in fastfat, thereby making Cc
unable to issue the lazy writes that would unblock those workers.
This is more or less directly taken from fastfat_new.

2 months ago[SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337...
Oleg Dubinskiy [Sat, 24 Oct 2020 15:04:54 +0000 (18:04 +0300)]
[SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337 (#3295)

They are required by MS Picture and Fax Viewer (shimgvw.dll), together with MS browseui.dll.

2 months ago[BROWSEUI] CCommonBrowser class should support aggregation (#3308)
Oleg Dubinskiy [Sat, 24 Oct 2020 15:02:18 +0000 (18:02 +0300)]
[BROWSEUI] CCommonBrowser class should support aggregation (#3308)

It will remove the following error from the log when use MS shell32.dll in ReactOS:
`fixme:(dll/win32/ole32/compobj.c:3454) Class {af604efe-8897-11d1-b944-00a0c90312e1} does not support aggregation`.

2 months ago[DOC] Add more files to "3rd Party Files.txt"
Victor Perevertkin [Sat, 24 Oct 2020 14:07:13 +0000 (17:07 +0300)]
[DOC] Add more files to "3rd Party Files.txt"

2 months ago[COMPILER_APITEST] Add new compiler_apitest, using pseh tests
Timo Kreuzer [Tue, 10 Mar 2020 00:27:59 +0000 (01:27 +0100)]
[COMPILER_APITEST] Add new compiler_apitest, using pseh tests

2 months ago[PSEH2_TEST] Move it to apitests
Timo Kreuzer [Mon, 9 Mar 2020 21:42:51 +0000 (22:42 +0100)]
[PSEH2_TEST] Move it to apitests

The folder name is compiler, because it is going to be part of a new compiler_apitest.

2 months ago[PSEH2_TEST] Fix compilation with MSVC
Timo Kreuzer [Mon, 9 Mar 2020 21:17:22 +0000 (22:17 +0100)]
[PSEH2_TEST] Fix compilation with MSVC

2 months ago[SHELL32] PL-pl Dialogs fix v2
Piotr Hetnarowicz [Thu, 14 May 2020 15:47:44 +0000 (17:47 +0200)]
[SHELL32] PL-pl Dialogs fix v2

shell32.dll PL-pl
-FIXED: invisible icon,text & description

2 months ago[MLANG] Fix scripts values in fnIMLangFontLink2_GetScriptFontInfo()
Serge Gautherie [Wed, 24 Jun 2020 18:41:44 +0000 (20:41 +0200)]
[MLANG] Fix scripts values in fnIMLangFontLink2_GetScriptFontInfo()

'...\mlang.c(3568): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)'


2 months ago[DOC] Make "3rd Party Files.txt" a main source about 3rd party projects
Victor Perevertkin [Sat, 24 Oct 2020 03:34:55 +0000 (06:34 +0300)]
[DOC] Make "3rd Party Files.txt" a main source about 3rd party projects

- Add path and license information to "3rd Party Files.txt"
- Merge README.FSD with it

2 months ago[CMAKE] MSVC RUNTIME_CHECKS is a 'Debug'-only feature
Serge Gautherie [Tue, 2 Jun 2020 19:27:07 +0000 (21:27 +0200)]
[CMAKE] MSVC RUNTIME_CHECKS is a 'Debug'-only feature

"cl : Command line error D8016 : '/Ox' and '/RTC1' command-line options are incompatible"

Addendum to 92dfec219d8c53a84c68ca069abbc170fc8bdb49.

2 months ago[CMAKE] Make unattended bootcd configurable via cmake ad00bf49f5
Jérôme Gardou [Fri, 23 Oct 2020 07:24:18 +0000 (09:24 +0200)]
[CMAKE] Make unattended bootcd configurable via cmake

Instead of messing around with a file in the source tree and risk commiting it

use cmake -DUNATTENDED_BOOTCD=yes to enable it, and use the UNATTENDED_BOOTCD_* cache variables to configure

3 months ago[CMAKE] Use an INTERFACE library to perform the msvcrt <-> msvcrtex binding
Jérôme Gardou [Thu, 22 Oct 2020 14:29:40 +0000 (16:29 +0200)]
[CMAKE] Use an INTERFACE library to perform the msvcrt <-> msvcrtex binding

3 months ago[APISETS] Declare them as modules instead of win32dll
Jérôme Gardou [Thu, 22 Oct 2020 13:15:46 +0000 (15:15 +0200)]
[APISETS] Declare them as modules instead of win32dll

3 months ago[CMAKE] Only link msvcrtex to win32cui, win32gui, win32dll, win32ocx and cpl modules
Jérôme Gardou [Thu, 22 Oct 2020 13:12:49 +0000 (15:12 +0200)]
[CMAKE] Only link msvcrtex to win32cui, win32gui, win32dll, win32ocx and cpl modules

3 months ago[CMAKE] Introduce the REACTOS_MODULE_TYPE target property
Jérôme Gardou [Thu, 22 Oct 2020 13:12:02 +0000 (15:12 +0200)]
[CMAKE] Introduce the REACTOS_MODULE_TYPE target property

And set it in set_module_type function

3 months ago[CRTDLL] Make this a stand-alone CRT DLL
Jérôme Gardou [Thu, 22 Oct 2020 10:25:19 +0000 (12:25 +0200)]
[CRTDLL] Make this a stand-alone CRT DLL

Because CRTs must be isolated from each other.
This basically reverts commit f0c91ae

3 months ago[DEVMGR] Avoid buffer overflow when device reg key size is > 100 chars
Victor Perevertkin [Thu, 22 Oct 2020 11:38:55 +0000 (14:38 +0300)]
[DEVMGR] Avoid buffer overflow when device reg key size is > 100 chars

3 months ago|CMAKE] Use ExternalProject for host-tools build
Jérôme Gardou [Thu, 22 Oct 2020 06:47:06 +0000 (08:47 +0200)]
|CMAKE] Use ExternalProject for host-tools build

3 months ago[APISETS] Revert 'Try to fix build of both case of MSVC AND CLANG'
Katayama Hirofumi MZ [Thu, 22 Oct 2020 00:18:32 +0000 (09:18 +0900)]
[APISETS] Revert 'Try to fix build of both case of MSVC AND CLANG'

3 months ago[APISETS] Try to fix build of both case of MSVC AND CLANG
Katayama Hirofumi MZ [Thu, 22 Oct 2020 00:07:15 +0000 (09:07 +0900)]
[APISETS] Try to fix build of both case of MSVC AND CLANG

3 months ago[INCLUDE] Use HeapAlloc/HeapFree in layout.h
Katayama Hirofumi MZ [Wed, 21 Oct 2020 23:07:32 +0000 (08:07 +0900)]
[INCLUDE] Use HeapAlloc/HeapFree in layout.h


3 months ago[SHELL32] Resizable for SHBrowseForFolder (#3299)
Katayama Hirofumi MZ [Wed, 21 Oct 2020 13:25:16 +0000 (22:25 +0900)]
[SHELL32] Resizable for SHBrowseForFolder (#3299)

Make the dialog box of SHBrowseForFolder function resizable. CORE-17341

3 months ago[PARPORT] Fix I/O port length check
Victor Perevertkin [Wed, 21 Oct 2020 12:24:10 +0000 (15:24 +0300)]
[PARPORT] Fix I/O port length check
The Standard Parallel Port (SPP) has 3 registers, not 4: data, status, control
This fixes the driver on the Compaq N600c laptop

3 months ago[NTOSKRNL] Completely disable optimizations when using GDB
Jérôme Gardou [Wed, 21 Oct 2020 10:32:54 +0000 (12:32 +0200)]
[NTOSKRNL] Completely disable optimizations when using GDB

3 months agoApply suggestions from code review
Jérôme Gardou [Fri, 16 Oct 2020 13:57:20 +0000 (15:57 +0200)]
Apply suggestions from code review

Beautification and clarity

Co-authored-by: Victor Perevertkin <>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
3 months agoApply suggestions from code review
Jérôme Gardou [Fri, 16 Oct 2020 06:41:35 +0000 (08:41 +0200)]
Apply suggestions from code review

Style fixes

Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
Co-authored-by: Victor Perevertkin <>
3 months ago[CMAKE] Get rid of add_compile_flags
Jérôme Gardou [Mon, 21 Sep 2020 10:16:02 +0000 (12:16 +0200)]
[CMAKE] Get rid of add_compile_flags

Use add_compile_options and the like instead

3 months ago[CMAKE] Get rid of replace_compiler_option macro
Jérôme Gardou [Fri, 18 Sep 2020 14:54:21 +0000 (16:54 +0200)]
[CMAKE] Get rid of replace_compiler_option macro

This is not used anymore

3 months ago[CMAKE] Use -ffile-prefix-map for GCC builds
Jérôme Gardou [Fri, 18 Sep 2020 14:19:46 +0000 (16:19 +0200)]
[CMAKE] Use -ffile-prefix-map for GCC builds

And also simplify the __RELFILE__ macro definition for the other cases

3 months ago[CMAKE] Get rid of add_compile_flags_language macro
Jérôme Gardou [Fri, 18 Sep 2020 14:18:24 +0000 (16:18 +0200)]
[CMAKE] Get rid of add_compile_flags_language macro

in favor of add_compile_options and the like with generator expressions
Also take this as an opportunity to remove the C++11 standard hack, GCC 8 now defaults to C++14

3 months ago[CMAKE] Get rid of replace_compile_flags
Jérôme Gardou [Fri, 18 Sep 2020 09:49:18 +0000 (11:49 +0200)]
[CMAKE] Get rid of replace_compile_flags

Introduce a finer-grained remove_target_compile_option instead

3 months ago[CMAKE] Get rid of replace_compile_flags_language macro
Jérôme Gardou [Fri, 18 Sep 2020 09:12:49 +0000 (11:12 +0200)]
[CMAKE] Get rid of replace_compile_flags_language macro

It was only used in the set_cpp macro

3 months ago[CMAKE] Introduce the atl_classes interface library
Jérôme Gardou [Fri, 18 Sep 2020 09:08:58 +0000 (11:08 +0200)]
[CMAKE] Introduce the atl_classes interface library

This takes care of adding the relvant include directory and the _ATL_NO_EXCEPTIONS define, if needed

3 months ago[CMAKE] Allow INTERFACE libraries for MSVC IDEs
Jérôme Gardou [Thu, 15 Oct 2020 09:47:03 +0000 (11:47 +0200)]
[CMAKE] Allow INTERFACE libraries for MSVC IDEs

3 months ago[CMAKE] Get rid of the set_cpp macro
Jérôme Gardou [Fri, 18 Sep 2020 07:34:18 +0000 (09:34 +0200)]
[CMAKE] Get rid of the set_cpp macro

Instead of messing with global variables and the like, we introduce two target properties:
 - WITH_CXX_EXCEPTIONS: if you want to use C++ exceptions
 - WITH_CXX_RTTI: if you need RTTI in your module
You can use the newly introduced set_target_cpp_properties function, with WITH_EXCEPTIONS and WITH_RTTI arguments
We also introduce two libraries :
 - cpprt: for C++ runtime routines
 - cppstl: for the C++ standard template library

NB: On GCC, this requires to create imported libraries with the related built-in libraries:libsupc++, limingwex, libstdc++

Finally, we manage the relevant flags with the ad-hoc generator expressions

So, if you don't need exceptions, nor RTTI, nor use any runtime at all: you simply have nothing else to do than add your C++ file to your module

3 months ago[CMAKE] CMakeParseArguments is not needed anymore, cmake_parse_arguments is a builtin...
Jérôme Gardou [Thu, 17 Sep 2020 08:05:02 +0000 (10:05 +0200)]
[CMAKE] CMakeParseArguments is not needed anymore, cmake_parse_arguments is a builtin since CMake 3.5

3 months agoRevert "[NTOS/MM] Initialize process Working set and start implementing adding entrie...
Jérôme Gardou [Tue, 20 Oct 2020 13:56:53 +0000 (15:56 +0200)]
Revert "[NTOS/MM] Initialize process Working set and start implementing adding entries to it"

This reverts commit 5abc016401a59dfb60944ea1fc8ea5ed27f7f087.
Not ready for prime time

3 months agoRevert "[NTOS/MM]
Jérôme Gardou [Tue, 20 Oct 2020 13:56:21 +0000 (15:56 +0200)]
Revert "[NTOS/MM]
     - Fix PFNs tracing
     - Add private pages to the process working set"

This reverts commit 4c5351bf55527a35bce09446420dd7296eedbe99.
Not ready for prime time

3 months ago[CMAKE] Add target-level dependency between ntdll_apitest and load_notifications
Jérôme Gardou [Tue, 20 Oct 2020 07:32:00 +0000 (09:32 +0200)]
[CMAKE] Add target-level dependency between ntdll_apitest and load_notifications

3 months ago[CMAKE] Use explicit path for "custom.dll" dependency
Jérôme Gardou [Tue, 20 Oct 2020 07:06:26 +0000 (09:06 +0200)]
[CMAKE] Use explicit path for "custom.dll" dependency

3 months ago[CMAKE] Fix generation of UTF-16 inf file
Jérôme Gardou [Tue, 20 Oct 2020 07:05:47 +0000 (09:05 +0200)]
[CMAKE] Fix generation of UTF-16 inf file

3 months ago[NTOS/MM]
Jérôme Gardou [Fri, 16 Oct 2020 13:27:07 +0000 (15:27 +0200)]
 - Fix PFNs tracing
 - Add private pages to the process working set

3 months ago[NTOS/MM] Initialize process Working set and start implementing adding entries to it
Jérôme Gardou [Thu, 15 Oct 2020 11:09:39 +0000 (13:09 +0200)]
[NTOS/MM] Initialize process Working set and start implementing adding entries to it

3 months ago[USETUP] Work around GCC's complaints (will be fixed properly later on).
Hermès Bélusca-Maïto [Mon, 19 Oct 2020 23:26:49 +0000 (01:26 +0200)]
[USETUP] Work around GCC's complaints (will be fixed properly later on).

3 months ago[USETUP][SETUPLIB] Continue hiding the FAT32 format in the format list, but take...
Hermès Bélusca-Maïto [Mon, 19 Oct 2020 21:49:26 +0000 (23:49 +0200)]
[USETUP][SETUPLIB] Continue hiding the FAT32 format in the format list, but take it into account anyway later on.

The formatter will select it anyway as soon as the partition size
permits it. We make it available internally however so as to "emulate"
FMIFS functionality.

Now rely on the partition filesystem for InstallVBRToPartition() instead
of the unreliable and deprecated partition type.

3 months ago[SETUPLIB] Code re-organization in bootsup.c and fsutil.c.
Hermès Bélusca-Maïto [Sat, 17 Oct 2020 18:29:47 +0000 (20:29 +0200)]
[SETUPLIB] Code re-organization in bootsup.c and fsutil.c.

- Move the actual VBR bootcode installation helpers into fsutil.c
  (they depend on the selected filesystem).

- Introduce InstallBootCodeToDisk() and InstallBootCodeToFile()
  and bootcode.c helpers, in order to replace the several functions
  that were duplicating the same code.

3 months ago[SETUPLIB] Move the filesystem recognition helpers to their own file.
Hermès Bélusca-Maïto [Sun, 11 Oct 2020 21:42:02 +0000 (23:42 +0200)]
[SETUPLIB] Move the filesystem recognition helpers to their own file.

3 months ago[FREELDR] Add variable for default text color 3301/head
Stanislav Motylkov [Fri, 16 Oct 2020 21:46:06 +0000 (00:46 +0300)]
[FREELDR] Add variable for default text color

On PC/AT-compatible machines it's Gray, and on NEC PC-98 series it's White.

3 months ago[FREELDR] Use BIOS font and accelerated text drawing on NEC PC-98
Stanislav Motylkov [Fri, 16 Oct 2020 21:32:38 +0000 (00:32 +0300)]
[FREELDR] Use BIOS font and accelerated text drawing on NEC PC-98

Both features are switchable via global variables.

3 months ago[NTOSKRNL] include/config.h: Sync it to current code (#3263)
Serge Gautherie [Sat, 17 Oct 2020 16:09:11 +0000 (18:09 +0200)]
[NTOSKRNL] include/config.h: Sync it to current code (#3263)

* SERIALIZE_DBGPRINT: Removed on c15e04c (r18078).
* ENABLE_VALIDATE_POOL: Removed on 5899e14 (r42249).
* TAG_STATISTICS_TRACKING: Removed on 5899e14 (r42249).
* POOL_DEBUG_APIS: Removed on 5899e14 (r42249).
* R_RZ: Removed on 7d21cf7 (r48999).
* R_STACK: Removed on 7d21cf7 (r48999).
* WHOLE_PAGE_ALLOCATIONS: Removed on b431563 (r17306).

3 months ago[BASESRV] Use the correct value for the last parameter of a CsrValidateMessageBuffer...
Hermès Bélusca-Maïto [Sat, 17 Oct 2020 14:55:56 +0000 (16:55 +0200)]
[BASESRV] Use the correct value for the last parameter of a CsrValidateMessageBuffer() call.

3 months ago[NTOS:IO] Some fixes for IoRaiseHardError(). (#3302) 3302/head
Hermès Bélusca-Maïto [Sat, 10 Oct 2020 15:41:44 +0000 (17:41 +0200)]
[NTOS:IO] Some fixes for IoRaiseHardError(). (#3302)

- Fix buggy retrieval of the current calling Irp->Tail.Overlay.Thread.

- The 4th argument (KernelRoutine) to the KeInitializeApc() is **NOT**
  optional; however its 5th argument (RundownRoutine) is.
  So use the mandatory routine for freeing the allocated APC instead.
  We don't use the rundown routine yet.

- Check whether the ExAllocatePoolWithTag() call failed or not before
  queueing the allocated APC.

3 months ago[NTOS:EX] ExUuidCreate(): Correctly fill Uuid->Data4
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:EX] ExUuidCreate(): Correctly fill Uuid->Data4


Co-authored-by: Nguyen Trung Khanh <>
3 months ago[BROWSEUI] Implement CLSID_ACListISF (#3298)
Katayama Hirofumi MZ [Sat, 17 Oct 2020 08:49:24 +0000 (17:49 +0900)]
[BROWSEUI] Implement CLSID_ACListISF (#3298)

Implement enumeration of IShellFolder items of auto-completion. CORE-9281

3 months ago[SCSIPORT] Split scsiport.c file into several ones, prepare for the refactoring
Victor Perevertkin [Sat, 17 Oct 2020 01:06:36 +0000 (04:06 +0300)]
[SCSIPORT] Split scsiport.c file into several ones, prepare for the refactoring


3 months ago[SETUPLIB] Fix some copy-pasta comments, no code changes
Stanislav Motylkov [Fri, 16 Oct 2020 21:48:30 +0000 (00:48 +0300)]
[SETUPLIB] Fix some copy-pasta comments, no code changes

3 months ago[FASTFAT] Ensure that deferred write IRP contexts are not touched. CORE-17328 3292/head
Thomas Faber [Sun, 11 Oct 2020 13:02:26 +0000 (15:02 +0200)]
[FASTFAT] Ensure that deferred write IRP contexts are not touched. CORE-17328

Cc may decide to process deferred writes any time, so the context might
already be freed by the time we return from CcDeferWrite.
Also mark the IRP as pending, since we're going to return STATUS_PENDING.

3 months ago[NTOS] Consistently use MUTANT_INCREMENT.
Thomas Faber [Fri, 16 Oct 2020 14:09:08 +0000 (16:09 +0200)]
[NTOS] Consistently use MUTANT_INCREMENT.

Spotted by Hermès.

3 months ago[CDROM_NEW] Import Microsoft CDROM class driver from GitHub
Victor Perevertkin [Fri, 16 Oct 2020 01:37:10 +0000 (04:37 +0300)]
[CDROM_NEW] Import Microsoft CDROM class driver from GitHub

The source code is licensed under MS-PL license, taken from Windows Driver Samples
repository (microsoft/Windows-driver-samples@master/storage/class/cdrom/)
Synched with commit 96eb96dfb613e4c745db6bd1f53a92fe7e2290fc
The driver is written for Windows 10 and uses KMDF so we compile it with ntoskrnl_vista
and wdf01000 statically linked (for wdf01000 this will likely be changed in future)


3 months ago[ACPICA] Update to version 20200925. CORE-17170
Thomas Faber [Fri, 9 Oct 2020 07:19:55 +0000 (09:19 +0200)]
[ACPICA] Update to version 20200925. CORE-17170

3 months ago[ACPICA] Update to version 20200717. CORE-17170
Thomas Faber [Sun, 6 Sep 2020 10:29:37 +0000 (12:29 +0200)]
[ACPICA] Update to version 20200717. CORE-17170

3 months ago[RAPPS] Update Hebrew (he-IL) translation (#3297)
Omer I.S [Thu, 15 Oct 2020 14:12:50 +0000 (17:12 +0300)]
[RAPPS] Update Hebrew (he-IL) translation (#3297)

3 months ago[NTOS:MM] Acquire PsLoadedModuleResource when walking PsLoadedModuleList. CORE-16449
Thomas Faber [Thu, 15 Oct 2020 11:42:13 +0000 (13:42 +0200)]
[NTOS:MM] Acquire PsLoadedModuleResource when walking PsLoadedModuleList. CORE-16449

3 months ago[NTOS:MM] Acquire MmSystemLoadLock in MiFindInitializationCode. CORE-16449
Thomas Faber [Thu, 15 Oct 2020 11:40:42 +0000 (13:40 +0200)]
[NTOS:MM] Acquire MmSystemLoadLock in MiFindInitializationCode. CORE-16449

We might otherwise free the INIT section for an image that's in the
process of being loaded by Mm.

3 months ago[OLE32_WINETEST] Fix build with lower optimization level
Jérôme Gardou [Thu, 15 Oct 2020 09:53:11 +0000 (11:53 +0200)]
[OLE32_WINETEST] Fix build with lower optimization level

3 months ago[WINED3D] Fix build with lower optimization levels
Jérôme Gardou [Thu, 15 Oct 2020 09:36:01 +0000 (11:36 +0200)]
[WINED3D] Fix build with lower optimization levels

3 months ago[UDFS] Fix build with lower optimization level
Jérôme Gardou [Thu, 15 Oct 2020 09:29:09 +0000 (11:29 +0200)]
[UDFS] Fix build with lower optimization level

3 months ago[BOOTDATA] Update display names for the GMT+0 time zones.
Hermès Bélusca-Maïto [Tue, 13 Oct 2020 16:17:34 +0000 (18:17 +0200)]
[BOOTDATA] Update display names for the GMT+0 time zones.

Following advice from

3 months ago[BOOTDATA] Update some time zones for Russia.
Hermès Bélusca-Maïto [Tue, 13 Oct 2020 16:04:02 +0000 (18:04 +0200)]
[BOOTDATA] Update some time zones for Russia.

- Move Novosibirsk to GMT+07:00 (was GMT+06:00 previously).
- Move Magadan to GMT+11:00 (was GMT+10:00 previously).
- Add Omsk time zone GMT+06:00
- Add Tomsk time zone GMT+07:00

3 months ago[NTUSER] Fix Shell Hook HSHELL_WINDOWCREATED (#3294)
Katayama Hirofumi MZ [Tue, 13 Oct 2020 07:37:52 +0000 (16:37 +0900)]

Fix Shell Hook and reduce failures of shell32_apitest ShellHook testcase. Fix the condition of notifying shell hook HSHELL_WINDOWCREATED in ntuser/winpos.c. CORE-17330

3 months ago[FASTFAT] Fix create for DOT and DOT-DOT leaving bad directory entry (#3241) 3241/head
Doug Lyons [Sat, 26 Sep 2020 22:39:15 +0000 (17:39 -0500)]
[FASTFAT] Fix create for DOT and DOT-DOT leaving bad directory entry (#3241)

3 months ago[BOOTDATA] Comment out vgaoem.fon (#3291)
Adam Słaboń [Mon, 12 Oct 2020 11:48:49 +0000 (13:48 +0200)]
[BOOTDATA] Comment out vgaoem.fon (#3291)

This font has been added in 383ea7d and then disabled from builds in 4cd2a93 due to regressions it was causing.
Also disable it in registry to not break NTLDR boot again.

3 months ago[SHELL32_APITEST] Add ShellHook testcase (#3289)
Katayama Hirofumi MZ [Mon, 12 Oct 2020 00:52:21 +0000 (09:52 +0900)]
[SHELL32_APITEST] Add ShellHook testcase (#3289)

Add a testcase named ShellHook for shell hook. This testcase will test HSHELL_WINDOWCREATED especially. HSHELL_WINDOWCREATED affects display of task bar panes. CORE-17330

3 months ago[CMD] Fix a typo in filename completion (#3293)
chirsz [Sun, 11 Oct 2020 19:57:08 +0000 (03:57 +0800)]
[CMD] Fix a typo in filename completion (#3293)

Fix filename completion that could cause a incorrect result when the path
contains "dots". (See also HBelusca@d12169b.)
See CORE-8623 and CORE-1901 (bug introduced in r25896 / 54cf74f).

For example:

- The current directory is `C:\Documents and Settings\Administrator\`, and you
  input `".` and press TAB. The completion result would be `".Administrator"`,
  which even does not exist.

- You input "some(file).ext", and you remove the final quote (or the quote
  and "ext") and you attempt to complete the file name.

- Import two additional fixes from HBelusca@a826730: Fix the search ordering
  in the comparisons between szSearch1, szSearch2 and szSearch3.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
3 months ago[RAPPS] Re-add support for icons named after the ini file 3194/head
Mark Jansen [Wed, 30 Sep 2020 17:24:52 +0000 (19:24 +0200)]
[RAPPS] Re-add support for icons named after the ini file

3 months ago[RAPPS] Fix certificate pinning error displaying garbage
Mark Jansen [Wed, 30 Sep 2020 17:24:10 +0000 (19:24 +0200)]
[RAPPS] Fix certificate pinning error displaying garbage

3 months ago[RAPPS] Bump the rapps user agent version
Mark Jansen [Wed, 30 Sep 2020 17:23:55 +0000 (19:23 +0200)]
[RAPPS] Bump the rapps user agent version

3 months ago[RAPPS] Update rapps DB location to the new database
Mark Jansen [Sun, 20 Sep 2020 20:12:19 +0000 (22:12 +0200)]
[RAPPS] Update rapps DB location to the new database

3 months ago[RAPPS] Delete icons and temp screenshot when cleaning up the db
Mark Jansen [Sun, 6 Sep 2020 21:14:37 +0000 (23:14 +0200)]
[RAPPS] Delete icons and temp screenshot when cleaning up the db

3 months ago[RAPPS] Add directory extraction capabilities for the .cab file
Mark Jansen [Sun, 6 Sep 2020 21:14:11 +0000 (23:14 +0200)]
[RAPPS] Add directory extraction capabilities for the .cab file

3 months ago[RAPPS] Add support for a rapps db with the file:/// scheme
Mark Jansen [Sun, 6 Sep 2020 21:13:21 +0000 (23:13 +0200)]
[RAPPS] Add support for a rapps db with the file:/// scheme
This makes it easier to test locally

3 months ago[PSDK] Add some argument names
Mark Jansen [Sun, 6 Sep 2020 15:50:29 +0000 (17:50 +0200)]
[PSDK] Add some argument names

3 months ago[GDI32] Prevent double initialization in GdiProcessSetup
Mark Jansen [Fri, 9 Oct 2020 12:28:32 +0000 (14:28 +0200)]
[GDI32] Prevent double initialization in GdiProcessSetup
Found with Application Verifier :)

3 months ago[README] Improving the readability of the stability warning (#3287)
Alexander Rechitskiy [Sat, 10 Oct 2020 23:40:48 +0000 (02:40 +0300)]
[README] Improving the readability of the stability warning (#3287)

Now the warning looks and reads better than a huge chunk of text in bold and italics at once.

3 months ago[PSDK] dsrole.h: Define DSROLE_PRIMARY_DS_READONLY (#3288)
Serge Gautherie [Sat, 10 Oct 2020 20:27:07 +0000 (22:27 +0200)]
[PSDK] dsrole.h: Define DSROLE_PRIMARY_DS_READONLY (#3288)

3 months ago[SMSS] Use RTL string-safe functions in critical places. Add validity checks for... 2704/head
Hermès Bélusca-Maïto [Thu, 30 Apr 2020 16:42:16 +0000 (18:42 +0200)]
[SMSS] Use RTL string-safe functions in critical places. Add validity checks for returned NtQueryValueKey() data. (#2704)

- Not all the wcscpy() / swprintf() calls have been converted to their
  string-safe equivalents. Instead I used the string-safe functions only
  for places where strings of unknown length were copied into fixed-size
  internal buffers. On the contrary, for known-fixed-length strings being
  copied or numbers being converted to string representations in large
  enough buffers, I kept the original function calls.

- Verify the registry data that has been returned by NtQueryValueKey():
  * When expecting (not multi) strings, check whether the data type is
    either REG_SZ or REG_EXPAND_SZ.
  * When expecting DWORD values, check whether the data type is
    REG_DWORD and whether the data length is (greater or) equal to

3 months ago[FONTS] Improve vgaoem.fon compatibilities by Fony
Katayama Hirofumi MZ [Sat, 10 Oct 2020 13:54:39 +0000 (22:54 +0900)]
[FONTS] Improve vgaoem.fon compatibilities by Fony

I have edited the font file vgaoem.fon with Fony application.
I adjusted the bitmap and the metrics.
The font name was "XFreeVGA" but now I renamed it as "Terminal".

(C) AJCD 1995 (C) 2009 grischka (C) khmz.

3 months ago[FONTS] Add CORE-* comments into CMakeLists.txt
Katayama Hirofumi MZ [Sat, 10 Oct 2020 13:53:04 +0000 (22:53 +0900)]
[FONTS] Add CORE-* comments into CMakeLists.txt