reactos.git
2 years ago[SDK] Update gen_baseaddress.py for reserved base addresses.
Mark Jansen [Mon, 2 Jul 2018 20:32:03 +0000 (22:32 +0200)]
[SDK] Update gen_baseaddress.py for reserved base addresses.
CORE-11382

2 years ago[TRANSLATIONS][DISPLAY] Translate to spanish some strings on the display (#667)
Julio Carchi [Thu, 12 Jul 2018 15:48:57 +0000 (10:48 -0500)]
[TRANSLATIONS][DISPLAY] Translate to spanish some strings on the display (#667)

CORE-14767

2 years ago[SHELL32] lpDirectory must have priority in ShellExecuteEx (#681)
Katayama Hirofumi MZ [Thu, 12 Jul 2018 15:45:43 +0000 (00:45 +0900)]
[SHELL32] lpDirectory must have priority in ShellExecuteEx (#681)

Based on a patch by Mark Jansen.
CORE-14469

2 years ago[TRANSLATION][CLIP] Implement Italian translation (#682)
Bișoc George [Thu, 12 Jul 2018 15:41:20 +0000 (17:41 +0200)]
[TRANSLATION][CLIP] Implement Italian translation (#682)

2 years ago[USER32][WIN32SS] Improve CascadeWindows function (#677)
Katayama Hirofumi MZ [Mon, 9 Jul 2018 12:52:30 +0000 (21:52 +0900)]
[USER32][WIN32SS] Improve CascadeWindows function (#677)

If the window is too large, then shrink it if possible.
CORE-14807

2 years ago[NET] Revert useless changes
Eric Kohl [Sat, 7 Jul 2018 20:12:37 +0000 (22:12 +0200)]
[NET] Revert useless changes

2 years ago[NET] Implement the undocumented /RANDOM option to generate random passwords
Eric Kohl [Sat, 7 Jul 2018 20:06:08 +0000 (22:06 +0200)]
[NET] Implement the undocumented /RANDOM option to generate random passwords

2 years ago[USER32][WIN32SS] Implement CascadeWindows function (#676)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 23:51:14 +0000 (08:51 +0900)]
[USER32][WIN32SS] Implement CascadeWindows function (#676)

CORE-14807

2 years ago[SHELL32] Add 'Properties' menu item in My Computer (#647)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 15:01:12 +0000 (00:01 +0900)]
[SHELL32] Add 'Properties' menu item in My Computer (#647)

- Add a Shell_DefaultContextMenuCallBack() helper function.
- Implement the IContextMenuCB interface in CDrivesFolder.
CORE-12509

2 years ago[SHELL32] Improve CShellLink a little (#651)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 14:45:40 +0000 (23:45 +0900)]
[SHELL32] Improve CShellLink a little (#651)

Improve the display and UI in the shortcut dialog.
CORE-11407

2 years ago[APPWIZ] Add support for creating internet shortcuts (#664)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 14:40:14 +0000 (23:40 +0900)]
[APPWIZ] Add support for creating internet shortcuts (#664)

CORE-8737

2 years ago[EXPLORER] Fix TrackCtxMenu about NULL ppt (#666)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 14:36:28 +0000 (23:36 +0900)]
[EXPLORER] Fix TrackCtxMenu about NULL ppt (#666)

CORE-14772

2 years ago[SHELL32][EXPLORER] Update system-wide environment variables (#663)
Katayama Hirofumi MZ [Sun, 8 Jul 2018 14:32:42 +0000 (23:32 +0900)]
[SHELL32][EXPLORER] Update system-wide environment variables (#663)

- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.

CORE-1459, CORE-14397

2 years ago[WIN32K:NTUSER] Remove the hackish code that has been introduced in IntSendChildNCPai... 674/head
Hermès Bélusca-Maïto [Sun, 8 Jul 2018 00:24:30 +0000 (02:24 +0200)]
[WIN32K:NTUSER] Remove the hackish code that has been introduced in IntSendChildNCPaint() in r73532 (6d7fcc4b) to attempt to pseudo-fix CORE-12071 and CORE-12085 while breaking other stuff, amongst which CORE-14763 is one of the latest manifestations, and re-enable the correct original code.

This fixes painting hangs under diverse situations, while CORE-12071 and
CORE-12085 remain fixed.

2 years ago[WIN32K:NTUSER] Add diagnostic asserts in IntLinkWindow() and IntUnlinkWindow()....
Hermès Bélusca-Maïto [Sun, 8 Jul 2018 00:24:13 +0000 (02:24 +0200)]
[WIN32K:NTUSER] Add diagnostic asserts in IntLinkWindow() and IntUnlinkWindow(). Don't link a window to itself in IntLinkWindow()! Add diagnostic traces for this situation, as well as in IntLinkHwnd().

Helps in correctly fixing CORE-12071 and CORE-12085.

2 years ago[WIN32K:NTUSER] Formatting only!
Hermès Bélusca-Maïto [Sun, 8 Jul 2018 00:23:52 +0000 (02:23 +0200)]
[WIN32K:NTUSER] Formatting only!

2 years ago[ROSAPPS] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:11:41 +0000 (16:11 +0100)]
[ROSAPPS] Fix 64 bit issues

2 years ago[KERNEL32] Use NULL for pointers.
Hermès Bélusca-Maïto [Sat, 7 Jul 2018 16:56:40 +0000 (18:56 +0200)]
[KERNEL32] Use NULL for pointers.

2 years ago[BLUE] Use ByteOffset.QuadPrt instead of ByteOffset.LowPart
Timo Kreuzer [Sun, 1 Jul 2018 08:47:48 +0000 (10:47 +0200)]
[BLUE] Use ByteOffset.QuadPrt instead of ByteOffset.LowPart

2 years ago[BLUE] Reformat and add missing success checks + DPRINTs on failure
Timo Kreuzer [Sun, 1 Jul 2018 08:24:22 +0000 (10:24 +0200)]
[BLUE] Reformat and add missing success checks + DPRINTs on failure

2 years ago[BLUE] Formatting, no code change
Timo Kreuzer [Sun, 1 Jul 2018 08:13:18 +0000 (10:13 +0200)]
[BLUE] Formatting, no code change

2 years ago[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond.
Mark Jansen [Fri, 6 Jul 2018 19:43:57 +0000 (21:43 +0200)]
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond.
This should fix a timeout on the apitests.

2 years ago[TRANSLATION][TIMEOUT] Created Polish translation of timeout
Paweł Cholewa [Sun, 1 Jul 2018 21:05:48 +0000 (23:05 +0200)]
[TRANSLATION][TIMEOUT] Created Polish translation of timeout

2 years ago[TRANSLATION][WHOAMI] Add Polish translation (#653)
Paweł Cholewa [Sun, 1 Jul 2018 21:20:57 +0000 (23:20 +0200)]
[TRANSLATION][WHOAMI] Add Polish translation (#653)

2 years ago[SDK] Add gen_baseaddress.py
Mark Jansen [Sun, 1 Jul 2018 18:17:46 +0000 (20:17 +0200)]
[SDK] Add gen_baseaddress.py
This tool was already used to calculate the last baseaddress update.
It is based on baseaddress.sh that has been floating around.
CORE-11382

2 years ago[CMAKE] Change winspool.drv to winspool again.
Mark Jansen [Sun, 1 Jul 2018 17:21:59 +0000 (19:21 +0200)]
[CMAKE] Change winspool.drv to winspool again.
CORE-14781

2 years ago[CMAKE] Update baseaddress for gcc with dwarf.
Mark Jansen [Sun, 1 Jul 2018 14:44:16 +0000 (16:44 +0200)]
[CMAKE] Update baseaddress for gcc with dwarf.
CORE-14781

2 years ago[LICCPA] Fix translation and align dialog controls
Eric Kohl [Sun, 1 Jul 2018 09:07:02 +0000 (11:07 +0200)]
[LICCPA] Fix translation and align dialog controls

2 years ago[LICCPA] Make the License Manager GUI build and make it visible (again)
Eric Kohl [Sun, 1 Jul 2018 09:02:10 +0000 (11:02 +0200)]
[LICCPA] Make the License Manager GUI build and make it visible (again)

- Add the missing CMakeLists.txt file.
- Comment-out an unused variable.
- Make WM_INITDIALOG return TRUE, so that the dialog gets visible.

2 years ago[TRANSLATION][TREE] Polish translation of tree utility (#654)
Paweł Cholewa [Sun, 1 Jul 2018 14:04:14 +0000 (16:04 +0200)]
[TRANSLATION][TREE] Polish translation of tree utility (#654)

2 years ago[CMAKE] Update baseaddress for msvc & gcc with rossym.
Mark Jansen [Sun, 1 Jul 2018 13:34:53 +0000 (15:34 +0200)]
[CMAKE] Update baseaddress for msvc & gcc with rossym.
CORE-14781

2 years ago[SDK] Fix 64 bit issues
Timo Kreuzer [Mon, 23 Apr 2018 09:58:34 +0000 (11:58 +0200)]
[SDK] Fix 64 bit issues

2 years ago[NDK] Fix definition of MSR_DEBUG_CTL_LBR and MSR_DEBUG_CTL_BTF
Timo Kreuzer [Fri, 9 Mar 2018 21:16:40 +0000 (22:16 +0100)]
[NDK] Fix definition of MSR_DEBUG_CTL_LBR and MSR_DEBUG_CTL_BTF

2 years ago[NDK] Fix alignment macros and add missing ones
Timo Kreuzer [Thu, 15 Feb 2018 21:14:11 +0000 (22:14 +0100)]
[NDK] Fix alignment macros and add missing ones
Remove obsolete ALIGN_UP_BY macro definition

2 years ago[DRIVERS][NTOS][NDK] Use IO_STACK_LOCATION instead of EXTENDED_IO_STACK_LOCATION...
Timo Kreuzer [Tue, 3 Apr 2018 14:58:44 +0000 (16:58 +0200)]
[DRIVERS][NTOS][NDK] Use IO_STACK_LOCATION instead of EXTENDED_IO_STACK_LOCATION and remove the latter from NDK

2 years ago[XDK][NDK] Fix IO_STACK_LOCATION alignments
Timo Kreuzer [Fri, 16 Feb 2018 20:32:46 +0000 (21:32 +0100)]
[XDK][NDK] Fix IO_STACK_LOCATION alignments

* Also add missing DIRECTORY_NOTIFY_INFORMATION_CLASS

2 years ago[XDK] Stop randomly packing structures half throughout ntifs.h / wdm.h
Timo Kreuzer [Sun, 11 Feb 2018 20:48:36 +0000 (21:48 +0100)]
[XDK] Stop randomly packing structures half throughout ntifs.h / wdm.h
Nothing in there should be packed!

2 years ago[NDK] Fix the type of KPROCESS::ActiveProcessors
Timo Kreuzer [Sat, 10 Feb 2018 19:30:14 +0000 (20:30 +0100)]
[NDK] Fix the type of KPROCESS::ActiveProcessors
Also fix related logic in KiSwapProcess

2 years ago[NDK] Update x64 version of KEXCEPTION_FRAME
Timo Kreuzer [Fri, 9 Feb 2018 19:51:28 +0000 (20:51 +0100)]
[NDK] Update x64 version of KEXCEPTION_FRAME

2 years ago[LIBUSB] Add additional operator new/delete
Timo Kreuzer [Sat, 24 Feb 2018 10:20:27 +0000 (11:20 +0100)]
[LIBUSB] Add additional operator new/delete
This is required, since newer versions of MSVC demand that non-member operator new/delete are in the global namespace and neither static nor inline. See https://msdn.microsoft.com/en-us/library/mt723604.aspx ("Overloaded operator new and operator delete")

2 years ago[CMAKE] winspool.drv -> winspool in baseaddress_msvc.cmake
Timo Kreuzer [Wed, 7 Mar 2018 13:46:59 +0000 (14:46 +0100)]
[CMAKE] winspool.drv -> winspool in baseaddress_msvc.cmake

2 years ago[FREELDR] PcMemGetBiosMemoryMap(): Add a default handling of entry with "EA.ErrorLog...
Serge Gautherie [Fri, 12 Jan 2018 05:30:53 +0000 (06:30 +0100)]
[FREELDR] PcMemGetBiosMemoryMap(): Add a default handling of entry with "EA.ErrorLog = 1". CORE-14150

This FIXME is meant as a reminder/help to actually use this data.

2 years ago[FREELDR] pcmem.c: Improve output strings. No functional changes. CORE-13332
Serge Gautherie [Fri, 12 Jan 2018 05:19:14 +0000 (06:19 +0100)]
[FREELDR] pcmem.c: Improve output strings. No functional changes. CORE-13332

- Plus: Add missing email address in 74f92c3d867a2d827e00e70dcf6e0295c40465c0.
- Remove superfluous blank lines.
- Add 2 TRACE("FunctionName()\n").
- Use "0x%llx", not "%lu", for BaseAddress and Length. (Copypasta in my recent commits.)
- Add "0x" to 1 "%p" and 1 "%lx".

2 years ago[COMDLG32] Add the missing NEWFILEOPENV2ORD dialog resource, whose absence made all...
Hermès Bélusca-Maïto [Sat, 30 Jun 2018 22:39:37 +0000 (00:39 +0200)]
[COMDLG32] Add the missing NEWFILEOPENV2ORD dialog resource, whose absence made all of the Open/Save-file dialogs not displaying anymore.

This was a regression from last Wine (Staging) 3.9 sync (f68b0c51) that
introduced the usage of this new dialog.
To do: Properly generate the dialog localization.

CORE-14656, CORE-14674, CORE-14689, CORE-14769

2 years ago[MC] Fix build of message text files for latest VS version
Timo Kreuzer [Tue, 15 May 2018 13:48:27 +0000 (15:48 +0200)]
[MC] Fix build of message text files for latest VS version
* Latest VS does not like half translated files :/
* errcodes.mc is duplicated in kernel32
* It would probably be better to separate each language into it's own file, but we need a build mechanism for that

2 years ago[SHELL32] Shell Profile Folders fixes.
Hermès Bélusca-Maïto [Sat, 30 Jun 2018 15:43:08 +0000 (17:43 +0200)]
[SHELL32] Shell Profile Folders fixes.

- Fix a regression introduced in r65415 (1795a3bf) where the directory
  paths stored in "Windows\CurrentVersion\Explorer\User Shell Folders"
  were stored in expanded format instead of in unexpanded format:
  _SHGetDefaultValue() *MUST* return unexpanded paths by design!!

- Augment _SHExpandEnvironmentStrings() and _SHGetUserShellFolderPath()
  to take a user token handle to be able to correctly resolve/expand
  user-specific directory paths.

- Fix _SHExpandEnvironmentStrings() so that it always retrieve the
  correct current user / all-users directory paths by calling userenv
  functions, instead of hardcoding a broken logic. As a result this
  removes the "C:\Documents and Settings\SYSTEM" ghost directory we got
  during ReactOS installation.

- Delimit the changes with respect to Wine by #if(n)def __REACTOS__ .

2 years ago[WIN32SS] Fix NtUserGetClipboardData for text paste (#645)
Katayama Hirofumi MZ [Sat, 30 Jun 2018 15:12:23 +0000 (00:12 +0900)]
[WIN32SS] Fix NtUserGetClipboardData for text paste (#645)

Fix the NtUserGetClipboardData function for the synthesized text formats (CF_TEXT, CF_OEMTEXT and CF_UNICODETEXT).
CORE-11471

2 years ago[WIN32K] Implement RECTL_bClipRectBySize() and use it in IntEngBitBlt() to clip the...
Timo Kreuzer [Sun, 11 Mar 2018 22:03:38 +0000 (23:03 +0100)]
[WIN32K] Implement RECTL_bClipRectBySize() and use it in IntEngBitBlt() to clip the target rect against the bounds of the target surface. Also clip the source rect against the source surface. Fixes remaining part of CORE-14463

2 years ago[CMAKE] Zap builddir.h.cmake and instead define macros globally
Timo Kreuzer [Tue, 13 Feb 2018 19:36:08 +0000 (20:36 +0100)]
[CMAKE] Zap builddir.h.cmake and instead define macros globally
This changes __RELFILE__ to always be relative and not rely on a GCC extension, since __FILE__ is *always* relative to the root.

2 years ago[SHELL32] Update russian translation
Stanislav Motylkov [Fri, 29 Jun 2018 15:31:26 +0000 (18:31 +0300)]
[SHELL32] Update russian translation

CORE-11407

2 years ago[SHELL32] Fix some elements positions and styles
Stanislav Motylkov [Fri, 29 Jun 2018 15:01:03 +0000 (18:01 +0300)]
[SHELL32] Fix some elements positions and styles

Addendum to eb1912b. CORE-11407

2 years ago[NOTEPAD] Globals.encFile: explicitly cast to ENCODING
Serge Gautherie [Fri, 29 Jun 2018 21:44:39 +0000 (23:44 +0200)]
[NOTEPAD] Globals.encFile: explicitly cast to ENCODING

2 years ago[DEVENUM] Initialize rgpins.
Mark Jansen [Fri, 29 Jun 2018 20:28:57 +0000 (22:28 +0200)]
[DEVENUM] Initialize rgpins.

2 years ago[FREETYPE] Allow a NULL style_name.
Mark Jansen [Fri, 29 Jun 2018 19:55:54 +0000 (21:55 +0200)]
[FREETYPE] Allow a NULL style_name.
CORE-14775

2 years ago[NOTEPAD] Avoid a cast.
Thomas Faber [Fri, 29 Jun 2018 12:59:16 +0000 (14:59 +0200)]
[NOTEPAD] Avoid a cast.

2 years ago[NOTEPAD] Fix a MSVC warning about Globals.encFile (#648)
Serge Gautherie [Fri, 29 Jun 2018 12:17:29 +0000 (14:17 +0200)]
[NOTEPAD] Fix a MSVC warning about Globals.encFile (#648)

"...\dialog.c(365) : error C4133: 'function' : incompatible types - from 'ENCODING *' to 'int *'"
CORE-7538

2 years ago[SHELL32] Refresh 'General' tab if the folder icon is updated (#646)
Katayama Hirofumi MZ [Fri, 29 Jun 2018 12:13:37 +0000 (21:13 +0900)]
[SHELL32] Refresh 'General' tab if the folder icon is updated (#646)

CORE-11407

2 years ago[SERVICES] Minor additions.
Hermès Bélusca-Maïto [Thu, 28 Jun 2018 20:32:28 +0000 (22:32 +0200)]
[SERVICES] Minor additions.

- Remove a redundant ScmWaitForLsa() call.
- Remove the LSA_RPC_SERVER_ACTIVE macro (just use directly the string).
- Improve output of DPRINTs.

2 years ago[SERVICES] Remove the "Special service accounts initialization" hack, and enable...
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 23:36:22 +0000 (01:36 +0200)]
[SERVICES] Remove the "Special service accounts initialization" hack, and enable per-service account logging.

This effectively removes the temporary hacks introduced in r73486 (a35a785b)
and in r73487 (0ce031f7) for the LocalService and NetworkService accounts.

Now these accounts (and their corresponding user profiles) are created
on the fly, the first time a service that needs these is started.
The code introduced in r73501 (ade0d2cd) is now re-enabled: this has
been made possible thanks to commit f42b4bbe (thanks Eric!).

Dedicated to Joachim Henze ;-)

CORE-12541, CORE-12279

2 years ago[FONT][FREETYPE] Refactor global variable names and locking (#591)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 20:00:55 +0000 (05:00 +0900)]
[FONT][FREETYPE] Refactor global variable names and locking (#591)

Refactor the font engine code in "win32ss/gdi/ntgdi/freetype.c".
- Add "g_" prefix to global variables.
- Make the locking macros function-like.
CORE-13065

2 years ago[SHELL32] Initial implementation of Folder Customization (#642)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 19:51:37 +0000 (04:51 +0900)]
[SHELL32] Initial implementation of Folder Customization (#642)

- Add property sheet;
- Implement changing the folder icon.
CORE-11407

2 years ago[WIN32SS] Fix IntSynthesizeDib to synthesize CF_DIB with CF_BITMAP (#644)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 17:27:40 +0000 (02:27 +0900)]
[WIN32SS] Fix IntSynthesizeDib to synthesize CF_DIB with CF_BITMAP (#644)

CORE-14770

2 years ago[DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)
Serge Gautherie [Thu, 28 Jun 2018 15:44:49 +0000 (17:44 +0200)]
[DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)

- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538

2 years ago[NTOS:SE] Overhaul the token management code.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:50:53 +0000 (22:50 +0200)]
[NTOS:SE] Overhaul the token management code.

- Overhaul SepCreateToken() and SepDuplicateToken() so that they
  implement the "variable information area" of the token, where
  immutable lists of user & groups and privileges reside, and the
  "dynamic information area" (allocated separately in paged pool),
  where mutable data such as the token's default DACL is stored.
  Perform the necessary adaptations in SepDeleteToken() and in
  NtSetInformationToken().

- Actually dereference the token's logon session, when needed, in the
  'TokenSessionReference' case in NtSetInformationToken().

- Overhaul SepFindPrimaryGroupAndDefaultOwner() so that it returns
  the indices of candidate primary group and default owner within the
  token's user & groups array. This allows for fixing the 'TokenOwner'
  and 'TokenPrimaryGroup' cases of NtSetInformationToken(), since the
  owner or primary group being set *MUST* already exist in the token's
  user & groups array (as a by-product, memory corruptions that existed
  before due to the broken way of setting these properties disappear too).

- Lock tokens every time operations are performed on them (NOTE: we
  still use a global token lock!).

- Touch the ModifiedId LUID member of tokens everytime a write operation
  (property change, etc...) is made on them.

- Fix some group attributes in the SYSTEM process token, SepCreateSystemProcessToken().

- Make the SeCreateTokenPrivilege mandatory when calling NtCreateToken().

- Update the token pool tags.

- Explicitly use the Ex*ResourceLite() versions of the locking functions
  in the token locking macros.

2 years ago[NDK] Update NtCreateToken() prototype annotations.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:49:34 +0000 (22:49 +0200)]
[NDK] Update NtCreateToken() prototype annotations.

2 years ago[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to...
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:30:09 +0000 (22:30 +0200)]
[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to create access tokens -- NtCreateToken() requires this privilege.

2 years ago[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStar...
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:19:40 +0000 (22:19 +0200)]
[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStartRpcServer().

2 years ago[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:14:03 +0000 (22:14 +0200)]
[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner.

2 years ago[NTOS:SE] Add a documentation note about SeTokenIsWriteRestricted() and SeTokenIsAdmi...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 16:49:07 +0000 (18:49 +0200)]
[NTOS:SE] Add a documentation note about SeTokenIsWriteRestricted() and SeTokenIsAdmin(), and update the one for NtDuplicateToken().
[XDK] Move TOKEN_HAS_ADMIN_GROUP where appropriate.

2 years ago[NTOS:SE] Minor style changes.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 14:03:40 +0000 (16:03 +0200)]
[NTOS:SE] Minor style changes.

- Use TRUE/FALSE instead of 1/0 for booleans.
- Use NULL instead of 0 for null pointers.
- Print 0x prefix for hex values in DPRINTs.
- Use new annotations for SepCreateToken() and SepDuplicateToken().

2 years ago[NTOS:SE] In SepCreateClientSecurity(), fix the impersonation level value passed...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:32:06 +0000 (15:32 +0200)]
[NTOS:SE] In SepCreateClientSecurity(), fix the impersonation level value passed to the SeCopyClientToken() call.

Caught while debugging, in the case the ImpersonationLevel value was
uninitialized, due to the fact it was left untouched on purpose by
PsReferenceEffectiveToken().

2 years ago[FORMATTING] No code change; typo fix.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:31:15 +0000 (15:31 +0200)]
[FORMATTING] No code change; typo fix.

2 years ago[NTOS:SE] Finish SepCreateImpersonationTokenDacl() implementation.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:24:44 +0000 (15:24 +0200)]
[NTOS:SE] Finish SepCreateImpersonationTokenDacl() implementation.

- Re-enable a commented-out block;
- Return the allocated Dacl.
- Use the correct pool tag when freeing the allocated Dacl.

2 years ago[NTOS:PS] Adjust the PsReferenceEffectiveToken() prototype in the header; add a comme...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:21:33 +0000 (15:21 +0200)]
[NTOS:PS] Adjust the PsReferenceEffectiveToken() prototype in the header; add a comment about the fact that the ImpersonationLevel parameter can be left untouched on purpose in one special case.

2 years ago[PSDK] ntsecpkg.h: fix minor typos (make some structure names MS-PSDK-compatible...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 12:55:46 +0000 (14:55 +0200)]
[PSDK] ntsecpkg.h: fix minor typos (make some structure names MS-PSDK-compatible), and add LSA_TOKEN_INFORMATION_V2.

2 years ago[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status...
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:30:10 +0000 (03:30 +0200)]
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop.

This avoids this function returning failure while everything actually succeeded.

2 years ago[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid point...
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:25:21 +0000 (03:25 +0200)]
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer.

2 years ago[ADVAPI32] Additions for CreateProcessAsUserA/W().
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 22:17:05 +0000 (00:17 +0200)]
[ADVAPI32] Additions for CreateProcessAsUserA/W().

- Use a common helper function used by both the ANSI and UNICODE functions
  so that the large code block that deals with setting the new process token
  becomes automatically common to both these functions, while the ANSI vs.
  UNICODE conversions are handled directly via the CreateProcessA/W() calls.

- Duplicate the token and acquire the process primary token assignment
  privilege before calling NtSetInformationProcess().

2 years ago[SHELL32] Add missing desktop.ini files (#640)
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:11:31 +0000 (06:11 +0900)]
[SHELL32] Add missing desktop.ini files (#640)

Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045

2 years ago[TRANSLATION][AT] Implement the Italian resource file (#641)
Bișoc George [Wed, 27 Jun 2018 21:09:56 +0000 (23:09 +0200)]
[TRANSLATION][AT] Implement the Italian resource file (#641)

2 years ago[SHELL32] Enable custom CD/DVD icons (#639)
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:06:54 +0000 (06:06 +0900)]
[SHELL32] Enable custom CD/DVD icons (#639)

Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766

2 years ago[AUTOCHK] Improve autochk messages
David Knapp [Tue, 26 Jun 2018 07:13:49 +0000 (09:13 +0200)]
[AUTOCHK] Improve autochk messages

2 years ago[NEWDEV] Fix a truncated text
Bișoc George [Mon, 25 Jun 2018 08:35:14 +0000 (10:35 +0200)]
[NEWDEV] Fix a truncated text

2 years ago[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInform...
Russell Johnson [Sun, 24 Jun 2018 18:29:57 +0000 (11:29 -0700)]
[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635)

Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340

2 years ago[SHELL32] Implement Folder Options File Types 'Change' button (#629)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:04:25 +0000 (03:04 +0900)]
[SHELL32] Implement Folder Options File Types 'Change' button (#629)

CORE-12906

2 years ago[BROWSEUI] Re-enable the "Folder Options" menu item (#630)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:02:36 +0000 (03:02 +0900)]
[BROWSEUI] Re-enable the "Folder Options" menu item (#630)

It was originally disabled in r71192 (8b77c254).
CORE-11141

2 years ago[SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:59:03 +0000 (02:59 +0900)]
[SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)

#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196

2 years ago[TRANSLATION][WHOAMI] Add Italian resource (#626)
Bișoc George [Sun, 24 Jun 2018 17:49:47 +0000 (19:49 +0200)]
[TRANSLATION][WHOAMI] Add Italian resource (#626)

Note: Supersedes PR #627

2 years ago[SHELL32] Implement OpenAs_RunDLLA/W (#628)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:46:06 +0000 (02:46 +0900)]
[SHELL32] Implement OpenAs_RunDLLA/W (#628)

CORE-14751

2 years ago[TRANSLATION][SHELL32] Update Russian translation (#633)
Abdulganiev Rafael [Sun, 24 Jun 2018 17:42:34 +0000 (21:42 +0400)]
[TRANSLATION][SHELL32] Update Russian translation (#633)

2 years agoAdd a document on the rules we should follow while managing/reviewing PRs, 585/head
David Quintana [Thu, 31 May 2018 21:50:49 +0000 (23:50 +0200)]
Add a document on the rules we should follow while managing/reviewing PRs,
and link to it from CONTRIBUTING.md and CODE_OF_CONDUCT.md

2 years ago[CMAKE] Add support for VS 15.7.1 / CL 19.14.x
Timo Kreuzer [Tue, 15 May 2018 11:08:49 +0000 (13:08 +0200)]
[CMAKE] Add support for VS 15.7.1 / CL 19.14.x

2 years ago[SHELL32] Improve French Folder Options
Katayama Hirofumi MZ [Sat, 23 Jun 2018 02:00:11 +0000 (11:00 +0900)]
[SHELL32] Improve French Folder Options

2 years ago[REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)
Getequ [Fri, 22 Jun 2018 18:15:12 +0000 (01:15 +0700)]
[REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)

This bug was found when I tried to import *.reg with huge HEX value (about 500 and much more lines of hex text).

2 years ago[SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:44:58 +0000 (23:44 +0900)]
[SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)

ROSTESTS-308

2 years ago[SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:40:06 +0000 (23:40 +0900)]
[SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)

CORE-14678

2 years ago[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the...
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 14:34:16 +0000 (16:34 +0200)]
[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the auto-start programs, by using the existing code.

2 years ago[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:02:25 +0000 (23:02 +0900)]
[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)

- Remove code for Start-Menu auto-startup items from userinit and put it where it belongs: in explorer.

CORE-10839

2 years ago[SHELL32] Fix desktop.ini folder icon (#595)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 13:37:03 +0000 (22:37 +0900)]
[SHELL32] Fix desktop.ini folder icon (#595)

The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196

2 years ago[EXPLORER] 'Run' (Win+R) should set the proper current directory (#593)
Katayama Hirofumi MZ [Thu, 21 Jun 2018 16:18:57 +0000 (01:18 +0900)]
[EXPLORER] 'Run' (Win+R) should set the proper current directory (#593)