Eric Kohl [Fri, 21 Sep 2018 13:37:34 +0000 (15:37 +0200)]
[NTOSKRNL] Create the 'Device Parameters' subkey and add the 'FirmwareIdentified' value for all ACPI-enumerated devices.
Eric Kohl [Fri, 21 Sep 2018 13:08:43 +0000 (15:08 +0200)]
[NTOSKRNL] Fix the indentation of some pnp manager functions.
Pierre Schweitzer [Fri, 21 Sep 2018 06:35:38 +0000 (08:35 +0200)]
[KMTESTS:CC] Add tests for CcCopyRead that reproduce CORE-15067
CORE-15067
Pierre Schweitzer [Fri, 21 Sep 2018 06:31:05 +0000 (08:31 +0200)]
[NTOSKRNL] Avoid integer overflow when computing VACB read/write size
This could be triggered when attempting to read/write to really big
files. It was causing an attempt to read 0 bytes in Cc, leading to
asserts failure in the kernel (and corrupted file).
CORE-15067
Joachim Henze [Fri, 21 Sep 2018 01:04:31 +0000 (03:04 +0200)]
[WIN32K:NTUSER] Fix WIN32K BSOD mentioned in CORE-15027
Fixes accessing nullptr / invalid handle in Window->SystemMenu
I could trigger this occasionally when moving Opera 12.18 window
in front of Spotify 1.0.29.92 window.
Fix was:
authored by Thomas Faber (Thank you!)
tested by me
reviewed by James Tabor
Eric Kohl [Thu, 20 Sep 2018 15:53:08 +0000 (17:53 +0200)]
[BTHCI] Add a bluetooth class installer stub.
Now we really need a tango-compatible bluetooth icon!
Eric Kohl [Thu, 20 Sep 2018 11:52:03 +0000 (13:52 +0200)]
[INF] Add german translation to the bluetooth class inf file.
Robert Naumann [Thu, 20 Sep 2018 07:20:14 +0000 (09:20 +0200)]
[DWNL] forgot this file
Robert Naumann [Thu, 20 Sep 2018 07:16:22 +0000 (09:16 +0200)]
[DWNL] German translation
Joachim Henze [Wed, 19 Sep 2018 20:51:07 +0000 (22:51 +0200)]
[SCHEDSVC] Fix a typo in debug print that was introduced in 0.4.10-dev-544-g
0d13bb10151e226df996f6c1d5b509dbe000446d
Eric Kohl [Wed, 19 Sep 2018 14:35:12 +0000 (16:35 +0200)]
[WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.
Might fix CORE-14521.
Eric Kohl [Wed, 19 Sep 2018 10:28:58 +0000 (12:28 +0200)]
[ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords.
Stanislav Motylkov [Tue, 18 Sep 2018 21:21:09 +0000 (00:21 +0300)]
[DWNL] Improve print date
Stanislav Motylkov [Tue, 18 Sep 2018 21:19:22 +0000 (00:19 +0300)]
[DWNL] Add russian translation
Eric Kohl [Tue, 18 Sep 2018 21:57:54 +0000 (23:57 +0200)]
[ADVAPI32] Implement SystemFunction028 to always return the default session key.
Lee Schroeder [Tue, 18 Sep 2018 21:55:44 +0000 (15:55 -0600)]
[DWNL] Localize the File Download utility (#853)
Also, changed header string to include a start time stamp similar to the one in wget.
CORE-14498
Pierre Schweitzer [Tue, 18 Sep 2018 19:42:01 +0000 (21:42 +0200)]
[NTOSKRNL] Stub IoInitializeCrashDump()
Also call it from NtCreatePagingFile() when we have successfully created
a paging file on the system boot partition.
Eric Kohl [Tue, 18 Sep 2018 19:33:29 +0000 (21:33 +0200)]
[ADVAPI32][SERVICES] Pass encrypted passwords to the service manager.
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
Eric Kohl [Tue, 18 Sep 2018 13:55:18 +0000 (15:55 +0200)]
[IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly.
Eric Kohl [Mon, 17 Sep 2018 22:24:36 +0000 (00:24 +0200)]
[ADVAPI32_WINETEST] Fix the STATUS issues
Eric Kohl [Mon, 17 Sep 2018 21:19:02 +0000 (23:19 +0200)]
[ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small.
Eric Kohl [Mon, 17 Sep 2018 21:12:16 +0000 (23:12 +0200)]
[ADVAPI32_WINETEST] Add tests for SystemFunction004 and SystemFunction005.
These tests show that the required output buffer size it returned in out.Length field when STATUS_BUFFER_TOO_SMALL is returned.
This patch will be sent upstream.
Eric Kohl [Mon, 17 Sep 2018 14:34:48 +0000 (16:34 +0200)]
[ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:56:59 +0000 (23:56 +0200)]
[RPCSS] During the setup phase, the RPCSS service, initially running under the LocalSystem account, should re-configure itself to run under the NetworkService account.
This will also fix MS Office 2010 installation, where the installation
expects the NetworkService account profile to be already loaded (this
condition is always verified on Windows since RPCSS and other services
also run under this account).
CORE-14988, CORE-14989
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:22:04 +0000 (23:22 +0200)]
[SERVICES] Add basic support for setting lpServiceStartName via RChangeServiceConfigW().
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:16:17 +0000 (23:16 +0200)]
[SERVICES] Minor code style fixes; replace wcslen(xxx) ==/!= 0 and strcpy(string, 'empty-string') calls.
Eric Kohl [Sun, 16 Sep 2018 19:10:36 +0000 (21:10 +0200)]
[NETAPI32] Add more DFS stubs
Bișoc George [Sun, 16 Sep 2018 17:27:31 +0000 (19:27 +0200)]
[MSCONFIG_NEW] Small Romanian translation update
Bișoc George [Sun, 16 Sep 2018 17:23:15 +0000 (19:23 +0200)]
[CHARMAP_NEW] Update the E-mail header string
Extravert-ir [Sun, 16 Sep 2018 14:14:07 +0000 (17:14 +0300)]
[FREELDR] Fix MSVC warnings C4146 (#863)
BieHDC [Sun, 16 Sep 2018 14:05:15 +0000 (16:05 +0200)]
[GITIGNORE] Ignore [boot|live|hybrid]cd_extras (#866)
Exclude [boot|live|hybrid]cd_extras from git as well since they are not part of the source code itself.
Pierre Schweitzer [Sun, 16 Sep 2018 12:50:01 +0000 (14:50 +0200)]
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out
This fixes a few newly added winetests.
Pierre Schweitzer [Sun, 16 Sep 2018 12:42:43 +0000 (14:42 +0200)]
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out
This fixes a few newly added winetests.
Pierre Schweitzer [Sun, 16 Sep 2018 10:03:08 +0000 (12:03 +0200)]
[KERNEL32_WINETEST] Enable ConditionVariable and SRW lock tests
If we cannot find the functions in kernel32, try to get them from
kernel32_vista. This will allow testing our own implementation, while
still failing in W2K3 (no implementation available).
Bernhard Feichtinger [Sat, 15 Sep 2018 21:08:30 +0000 (23:08 +0200)]
[RAMDISK] Implement missing IOCTLs
Mark Jansen [Fri, 11 May 2018 20:23:52 +0000 (22:23 +0200)]
[KERNEL32] Ensure the PebLock is always released in FlsFree
Mark Jansen [Fri, 11 May 2018 20:22:47 +0000 (22:22 +0200)]
[KERNEL32_APITEST] Test FLS locking & exception behavior.
Mark Jansen [Thu, 10 May 2018 20:23:16 +0000 (22:23 +0200)]
[NTDLL][KERNEL32] Implement FLS callbacks.
Mark Jansen [Tue, 8 May 2018 20:09:04 +0000 (22:09 +0200)]
[KERNEL32_APITEST] Add test exposing FLS internals.
Eric Kohl [Sat, 15 Sep 2018 12:10:01 +0000 (14:10 +0200)]
[DESK] Add MonitorClassInstaller
Pierre Schweitzer [Sat, 15 Sep 2018 08:54:00 +0000 (10:54 +0200)]
[SHELLBTRFS] Fix GCC build
CORE-15048
Thomas Faber [Sat, 15 Sep 2018 07:43:09 +0000 (09:43 +0200)]
[SHELLBTRFS] Add exports according to upstream .def file. CORE-15048
Pierre Schweitzer [Fri, 14 Sep 2018 20:30:41 +0000 (22:30 +0200)]
[MPR] Import Wine commit:
93fb279f4f3e150eee329b02ca5fb0251d8a239d
Properly handle device-less connections.
CORE-15012
Stanislav Motylkov [Sun, 9 Sep 2018 13:50:27 +0000 (16:50 +0300)]
[USETUP] Make countdown progress bar smoother
Stanislav Motylkov [Sun, 9 Sep 2018 15:45:41 +0000 (18:45 +0300)]
[USETUP] Update Russian translation
Stanislav Motylkov [Wed, 12 Sep 2018 19:16:45 +0000 (22:16 +0300)]
[SYSDM.CPL] Fixup control positions after font metrics fix
Stanislav Motylkov [Wed, 12 Sep 2018 18:42:06 +0000 (21:42 +0300)]
[DESK.CPL] Settings: Fixup control positions
Stanislav Motylkov [Wed, 12 Sep 2018 18:31:48 +0000 (21:31 +0300)]
[DESK.CPL] Screensaver: Fixup control positions
Stanislav Motylkov [Wed, 12 Sep 2018 18:04:49 +0000 (21:04 +0300)]
[DESK.CPL] Background: Fixup control positions after font metrics fix
Stanislav Motylkov [Wed, 12 Sep 2018 17:49:26 +0000 (20:49 +0300)]
[DESK.CPL] Appearance: Fixup control positions after font metrics fix
CORE-14274
Katayama Hirofumi MZ [Fri, 14 Sep 2018 09:04:36 +0000 (18:04 +0900)]
[TRANSLATION] Update Romanian translation (#851)
Translation from Stefan Fulea.
CORE-15023
Pierre Schweitzer [Fri, 14 Sep 2018 06:15:08 +0000 (08:15 +0200)]
[WINLOGON] Fix build
Add a specific internal header for MPR and include it in WinLogon.
CORE-15012
Pierre Schweitzer [Fri, 14 Sep 2018 06:06:13 +0000 (08:06 +0200)]
[MPR] Import Wine commit:
0799550075654094a3bed080aac722b9bea01307
Implement WNetClearConnections().
CORE-15012
Stanislav Motylkov [Thu, 13 Sep 2018 11:37:20 +0000 (14:37 +0300)]
[FONT][WIN32SS] Check whether Win32Process is NULL
CORE-15031
Stanislav Motylkov [Thu, 13 Sep 2018 09:47:01 +0000 (12:47 +0300)]
[CMD] Do not overwrite input string on Ctrl+C (#852)
CORE-15029
Katayama Hirofumi MZ [Fri, 17 Aug 2018 01:31:45 +0000 (10:31 +0900)]
[FONT][WIN32SS] Add dumping functions for debugging
Mark Jansen [Sat, 1 Sep 2018 19:40:12 +0000 (21:40 +0200)]
[WIN32K] Realize PTEXTOBJ in FontGetObject if it was not initialized
Mark Jansen [Fri, 7 Sep 2018 23:47:14 +0000 (01:47 +0200)]
[FREETYPE] Mark an unhandled case as UNIMPLEMENTED
CORE-14948
Mark Jansen [Fri, 7 Sep 2018 23:46:26 +0000 (01:46 +0200)]
[KERNEL32] Do not embed binary data inside a string resource.
CORE-14948
Mark Jansen [Wed, 12 Sep 2018 19:30:49 +0000 (21:30 +0200)]
[DBGHELP] Prevent crashing on a malformed PE file.
CORE-15030
Eric Kohl [Wed, 12 Sep 2018 15:53:49 +0000 (17:53 +0200)]
[NETAPI32] Remove the obsolete file group.c
Eric Kohl [Wed, 12 Sep 2018 15:38:18 +0000 (17:38 +0200)]
[NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type
Eric Kohl [Wed, 12 Sep 2018 15:11:52 +0000 (17:11 +0200)]
[NETAPI32] Implement NetGroupSetUsers
Pierre Schweitzer [Mon, 10 Sep 2018 16:52:51 +0000 (18:52 +0200)]
[MAINTAINERS] Complete myself
Pierre Schweitzer [Mon, 10 Sep 2018 16:47:29 +0000 (18:47 +0200)]
[MAINTAINERS] Define who can be maintainer and how to be added to the file
Mark Jansen [Sat, 8 Sep 2018 11:49:20 +0000 (13:49 +0200)]
[MAINTAINERS] Add myself.
Also add Pierre to ntdll
Thomas Faber [Sat, 8 Sep 2018 10:10:53 +0000 (12:10 +0200)]
[MAINTAINERS] Add myself.
Also add Pierre to the kernel as a whole, at his request.
Also fix a typo in "Abandoned".
Pierre Schweitzer [Sat, 8 Sep 2018 09:14:56 +0000 (11:14 +0200)]
Add a maintainers file
Eric Kohl [Tue, 11 Sep 2018 13:02:19 +0000 (15:02 +0200)]
[NETAPI32] Implement NetLogonGetTimeServiceParentDomain
Pierre Schweitzer [Tue, 11 Sep 2018 06:15:37 +0000 (08:15 +0200)]
[WINLOGON] On logoff, also disconnect from any remote location
This avoids keeping connections open and reopening them as soon
as the user reopens their session.
This fixes network shared being duplicated each time session
is reopened.
CORE-15012
Pierre Schweitzer [Tue, 11 Sep 2018 06:14:50 +0000 (08:14 +0200)]
[SDK] Add WNetClearConnections() in the headers for undocumented stuff
CORE-15012
Pierre Schweitzer [Tue, 11 Sep 2018 06:08:56 +0000 (08:08 +0200)]
[MPR] Implement WNetClearConnections()
This has been submitted upstream.
CORE-15012
Eric Kohl [Mon, 10 Sep 2018 20:04:53 +0000 (22:04 +0200)]
[NETAPI32] Implement NetGroupGetUsers
Joachim Henze [Mon, 10 Sep 2018 15:51:59 +0000 (17:51 +0200)]
[FREETYPE] Fix Regression "Monospaced font in LibreOffice" CORE-15018
LibreOffice started to show GUI in a mono-spaced font after 0.4.10-dev-466-g
35f62fc5ba0b69e7335ff41400cb3b45660f4557
We can fix this by partial revert
as proposed by Katayama Hirofumi MZ, who was author of those changes as well.
We revert the changes in penalty system here.
Amine Khaldi [Mon, 10 Sep 2018 07:05:35 +0000 (08:05 +0100)]
[USBEHCI_NEW] Bring-in the USB EHCI miniport driver created by Vadim Galyant. (#301)
Hermès Bélusca-Maïto [Sun, 9 Sep 2018 20:20:38 +0000 (22:20 +0200)]
[SERVICES] Only services starting under the LocalSystem account can run interactively. Otherwise ignore the interactive flag.
Hermès Bélusca-Maïto [Sun, 9 Sep 2018 20:14:57 +0000 (22:14 +0200)]
[SERVICES] Re-implement RChangeServiceConfigA() around RChangeServiceConfigW(), much as what is done for RCreateServiceA().
Hermès Bélusca-Maïto [Sun, 9 Sep 2018 18:52:36 +0000 (20:52 +0200)]
[SERVICES] RChangeServiceConfigW: Check valid usage of lpdwTagId when lpLoadOrderGroup is not specified.
Stanislav Motylkov [Sun, 9 Sep 2018 21:11:11 +0000 (00:11 +0300)]
[NET] Update Russian translation (#849)
Paweł Cholewa [Sun, 9 Sep 2018 20:28:02 +0000 (22:28 +0200)]
[TRANSLATION] Updated Polish translation in USETUP (#848)
Bișoc George [Sun, 9 Sep 2018 17:37:10 +0000 (19:37 +0200)]
[USETUP] Italian translation update
Bișoc George [Sun, 9 Sep 2018 17:36:24 +0000 (19:36 +0200)]
[USETUP] Romanian translation update
Baruch Rutman [Fri, 7 Sep 2018 07:59:59 +0000 (10:59 +0300)]
[BIDITEXT] Add more demo code. (#842)
Add code that demonstrates the use of the lpOrder and lpCaretPos struct members of GCP_RESULTS w/ and w/o GCP_REORDER flag.
Changed demo string literals to arrays containing character unicode values.
Baruch Rutman [Fri, 7 Sep 2018 07:45:35 +0000 (10:45 +0300)]
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842)
- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.
Katayama Hirofumi MZ [Sun, 9 Sep 2018 15:37:37 +0000 (00:37 +0900)]
[WIN32SS][COMCTL32] Fix button text Y positioning (#766)
Fixes the vertical position of button text.
CORE-14906
Eric Kohl [Sun, 9 Sep 2018 15:33:03 +0000 (17:33 +0200)]
[NETAPI32] Implement NetGroupAddUser and NetGroupDelUser
Nguyễn Thanh Sơn [Sun, 9 Sep 2018 15:34:21 +0000 (22:34 +0700)]
[SETUP][REACTOS] Added Vietnamese translation. (#716)
Hermès Bélusca-Maïto [Sun, 9 Sep 2018 15:24:38 +0000 (17:24 +0200)]
[USETUP] Update French translation.
Bișoc George [Wed, 22 Aug 2018 09:10:18 +0000 (11:10 +0200)]
[USETUP] Implement the shutdown timeout progress bar. (#833)
- Add the MUI ID resource.
- Implement the shutdown timeout progress bar function and the TimeOut string handler.
- Add the resource string to other resource languages.
Pierre Schweitzer [Sun, 9 Sep 2018 09:14:42 +0000 (11:14 +0200)]
[NTOSKRNL] Move data mapping implementation to an internel helper
Eric Kohl [Sun, 9 Sep 2018 11:39:01 +0000 (13:39 +0200)]
[NETAPI32] Implement NetGroupSetInfo
Eric Kohl [Sun, 9 Sep 2018 09:52:08 +0000 (11:52 +0200)]
[NETAPI32] Implement NetGroupAdd and NetGroupDel
Vadim Galyant [Sat, 8 Sep 2018 18:52:06 +0000 (20:52 +0200)]
[USBHUB_NEW][USBPORT] Fix buffer size calculation for multi-sz values in IRP_MN_QUERY_ID.
Also fix some copypasta'd DPRINTs.
Eric Kohl [Sun, 9 Sep 2018 07:40:11 +0000 (09:40 +0200)]
[NETAPI] Implement NetGroupGetInfo
Eric Kohl [Sat, 8 Sep 2018 20:21:15 +0000 (22:21 +0200)]
[PSDK] Add missing struct _GROUP_INFO_3 to lmaccess.h
Eric Kohl [Sat, 8 Sep 2018 18:55:13 +0000 (20:55 +0200)]
[NETAPI] Implement NetGroupEnum
Eric Kohl [Sat, 8 Sep 2018 17:23:00 +0000 (19:23 +0200)]
[SAMSRV] Fix SamrQueryInformationGroup
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
Pierre Schweitzer [Sat, 8 Sep 2018 13:19:45 +0000 (15:19 +0200)]
[KMTESTS:CC] Fix two failing tests on WHS bot
Eric Kohl [Sat, 8 Sep 2018 12:14:13 +0000 (14:14 +0200)]
[NET] Implement the group command
Thomas Faber [Sat, 8 Sep 2018 09:10:51 +0000 (11:10 +0200)]
[SDK] Make gen_baseaddress.py compatible with Python 3.