James Tabor [Fri, 31 Jul 2020 17:45:18 +0000 (12:45 -0500)]
[WinSpool.idl] Add File Info Structure
This is for 2 RPC functions. Update at a later time.
James Tabor [Fri, 31 Jul 2020 17:12:59 +0000 (12:12 -0500)]
[WinSpool] Fix Header Order
Found another issue with the header.
Hervé Poussineau [Fri, 17 Apr 2020 21:54:14 +0000 (23:54 +0200)]
[HIDPARSER] Remove HIDPARSER specific error codes, and remplace them by HIDP_* NTSTATUS codes
Remove now useless TranslateHidParserStatus() function.
Hervé Poussineau [Fri, 3 May 2019 11:24:05 +0000 (13:24 +0200)]
[HIDPARSER] Remove HID_PARSER class, and directly use functions
Hervé Poussineau [Sun, 12 Jul 2020 13:37:20 +0000 (15:37 +0200)]
[ISAPNP] Properly stub IRP_MJ_POWER
James Tabor [Wed, 29 Jul 2020 18:06:07 +0000 (13:06 -0500)]
[WinSpool] Fix Header Order.
Found an issue with the header.
Dmitry Borisov [Mon, 27 Jul 2020 18:25:18 +0000 (00:25 +0600)]
[BOOTVID] More improvements for PC-98 (#2936)
- Fix failure handling
- Reduce memory mapping that's not needed
Dmitry Borisov [Mon, 27 Jul 2020 18:19:34 +0000 (00:19 +0600)]
[BOOTVID] Fix screen buffer copying code for PC-98 (#2936)
Dmitry Borisov [Mon, 27 Jul 2020 17:57:45 +0000 (23:57 +0600)]
[BOOTVID] Improve text scrolling performance for PC-98 (#2936)
Dmitry Borisov [Sun, 21 Jun 2020 13:21:46 +0000 (19:21 +0600)]
[BOOTVID] Fix BitBlt behavior (#2936)
Dmitry Borisov [Sat, 20 Jun 2020 16:12:56 +0000 (22:12 +0600)]
[BOOTVID] Annotate some functions to avoid confusing (#2936)
Also fix some magic constants.
Dmitry Borisov [Sat, 20 Jun 2020 11:21:42 +0000 (17:21 +0600)]
[BOOTVID] Fix drawing strings on top of the bitmap (#2936)
Also fix VGA pixel drawing.
CORE-15896
Nguyen Trung Khanh [Mon, 27 Jul 2020 00:39:48 +0000 (07:39 +0700)]
[NTOS:KE] Fix stack memory disclosure in KiInitializeUserApc (#2988)
James Tabor [Sun, 26 Jul 2020 20:42:28 +0000 (15:42 -0500)]
[WinddiUI] Fix Format
Format This ....
Victor Perevertkin [Sun, 26 Jul 2020 11:10:52 +0000 (14:10 +0300)]
[XDK] Introduce ExAllocate*Zero and ExAllocate*Uninitialized functions
These has been first added to DDK 10.0.19041.0 and made backwards-compatible
with all Windows versions since Windows 2000.
Our implementation does not use POOL_ZERO_ALLOCATION flag because it's not
supported by ReactOS yet, and thus erases the memory unconditionally.
James Tabor [Sat, 25 Jul 2020 16:39:04 +0000 (11:39 -0500)]
[WinddiUI] Add more types and structures.
Dmitry Borisov [Sat, 25 Jul 2020 13:31:02 +0000 (19:31 +0600)]
[HALPC98] Add Hardware Abstraction Layer for NEC PC-98 series (#3002)
Serge Gautherie [Wed, 22 Jul 2020 17:02:26 +0000 (19:02 +0200)]
[BOOTDATA] Enable 'REG_EXPAND_SZ' for 'kbswitch.exe' (#3004)
CORE-12973
Stanislav Motylkov [Wed, 22 Jul 2020 16:50:24 +0000 (19:50 +0300)]
[FASTFAT] Support 64 KiB cluster sizes
FAT16 filesystem was not recognized on some 4GB USB flash drives.
This change makes them just work.
References:
- https://chat.reactos.org/reactos/pl/h83pm5ngkffk7qiyrmqnaaopxh
- https://support.microsoft.com/en-us/help/140365/default-cluster-size-for-ntfs-fat-and-exfat
CORE-16511
Stanislav Motylkov [Tue, 21 Jul 2020 16:50:45 +0000 (19:50 +0300)]
[EXPLORER] Allocate the string for expanded command line from heap
Addendum to
6fe704b.
CORE-12973 CORE-17168
Stanislav Motylkov [Tue, 21 Jul 2020 14:04:17 +0000 (17:04 +0300)]
[EXPLORER] Fix auto startup behavior
Command line should be expanded only for REG_EXPAND_SZ values.
CORE-17168
Serge Gautherie [Tue, 21 Jul 2020 12:39:11 +0000 (14:39 +0200)]
[REACTOS] Fix GetTokenInformation() usage (#2997)
The first call to GetTokenInformation is used to determine the size of a TokenInformation buffer.
It should fail and return ERROR_INSUFFICIENT_BUFFER
Trevor Thompson [Mon, 20 Jul 2020 18:55:24 +0000 (14:55 -0400)]
[CLASS2]: Set DiskSize member of deviceExtension->DiskGeometry in ScsiClassReadDriveCapacity(). Consolidate code and comment for setting media capacity in bytes. CORE-17166
Serge Gautherie [Sat, 18 Jul 2020 17:42:30 +0000 (19:42 +0200)]
[NTOS:KD64] Fix 'MAX_KD_COMPONENT_TABLE_ENTRIES' value (#2992)
Addendum to
ceb58c8.
Hermès Bélusca-Maïto [Sat, 18 Jul 2020 16:16:21 +0000 (18:16 +0200)]
[NTOS:KDBG] Adapt the formatting of the debug filter table display output to suit longer component names.
Hermès Bélusca-Maïto [Sat, 18 Jul 2020 15:43:29 +0000 (17:43 +0200)]
[NTOS][KDBG] Use macros to simplify initializing the debug filter tables.
Hermès Bélusca-Maïto [Sat, 18 Jul 2020 14:25:45 +0000 (16:25 +0200)]
[NTOS][SDK] Add new kernel debug filters that have been added in Win8 and Win10; they can be useful for us.
Hermès Bélusca-Maïto [Sat, 18 Jul 2020 15:39:42 +0000 (17:39 +0200)]
[NTOS:KDBG] Minor code style fix.
Serge Gautherie [Sat, 18 Jul 2020 13:40:05 +0000 (15:40 +0200)]
[CRYPT32] CRYPT_ExportKeyTrans(): Check 'CRYPT_ConstructBitBlob()' return value (#2983)
Import https://source.winehq.org/git/wine.git/commit/
3e8b07309c293d00e6b71164373e52c0dd19f29f
CORE-8156
Co-authored-by: Victor Martinez Calvo <vmartinez@reactos.org>
Serge Gautherie [Sat, 18 Jul 2020 13:37:29 +0000 (15:37 +0200)]
[CMAKE] Remove obsolete 'CMAKE_CXX_COMPILER_VERSION' checks (#2981)
Following upgrade to RosBE 2.2.0 support and GCC 8.4.
Arjav Garg [Sat, 18 Jul 2020 13:33:43 +0000 (19:03 +0530)]
[OSK] Meta key modifier behaviour added (#2973)
Make the meta key in the OSK have modifier key behaviour.
Changed all the .rc files in the OSK so that the meta key doesn't release on it's own and needs a second click to release.
CORE-17161
Serge Gautherie [Sat, 18 Jul 2020 13:31:48 +0000 (15:31 +0200)]
[CDFS][FLOPPY_NEW] Simplify unsupported NT6.2+ workarounds (#2956)
Victor Perevertkin [Wed, 15 Jul 2020 00:20:13 +0000 (03:20 +0300)]
[NTOS:FSTUB] Simplify xHalIoReadPartitionTable function
Use single IOCTL (IOCTL_DISK_GET_DRIVE_GEOMETRY_EX) for retrieving
disk basic geometry information along with disk size.
Previous implementation used to issue two requests for that.
Thomas Faber [Sun, 12 Jul 2020 10:26:47 +0000 (12:26 +0200)]
[LIBMPG123] Update to version 1.26.2. CORE-17158
Serge Gautherie [Tue, 31 Mar 2020 07:39:16 +0000 (09:39 +0200)]
[MSGINA] gui: Improve 'DlgData_Destroy()'
Addendum to
623dd26ccea5e79001aee769c230fb4f8e304fc8.
Serge Gautherie [Fri, 10 Jul 2020 23:38:15 +0000 (01:38 +0200)]
Merge pull request #2900 from SergeGautherie/SergeGautherie/PRonly_3rdPartyFiles-txt_chmc-lzxcomp
[3rd Party Files.txt] Add 'chmc and lzxcomp' entry
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[TASKMGR] CachedGetUserFromSid(): Fix user name length on cache hit
Serge Gautherie [Sat, 18 Apr 2020 14:40:42 +0000 (16:40 +0200)]
[AUDIOSRV] logmsg(): Disable its file part
Mininal workaround for
CORE-16814
Serge Gautherie [Wed, 20 May 2020 21:42:59 +0000 (23:42 +0200)]
[APISETS] api-ms-win-core-localization-l1-2-1: Is NT6.3+ actually
CORE-17095
Serge Gautherie [Wed, 20 May 2020 21:42:59 +0000 (23:42 +0200)]
[APISETS] api-ms-win-core-localization-l1-2-0: Is NT6.2+ actually
CORE-17095
Serge Gautherie [Wed, 20 May 2020 21:42:59 +0000 (23:42 +0200)]
[APISETS] api-ms-win-core-localization-l1-1-0: Is NT6.1+ actually
CORE-17095
Mark Jansen [Sun, 5 Jul 2020 15:11:28 +0000 (17:11 +0200)]
[SDK] Fix host-tools build from visual studio ide in Release
Colin Finck [Wed, 8 Jul 2020 21:32:17 +0000 (23:32 +0200)]
[OSK] Fix some mistakes in the German translation I just spotted
Thomas Faber [Sat, 4 Jul 2020 12:43:45 +0000 (14:43 +0200)]
[MBEDTLS] Update to version 2.7.16. CORE-17155
Thomas Faber [Sat, 4 Jul 2020 12:47:41 +0000 (14:47 +0200)]
[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155
This is the default going forward, and separating it out into its own
commit removes the noise from the following sync commit.
Mark Jansen [Tue, 23 Jun 2020 21:46:35 +0000 (23:46 +0200)]
[ROSAPPS] Remove applications from test directory
CORE-17097
Mark Jansen [Tue, 23 Jun 2020 21:45:42 +0000 (23:45 +0200)]
[ROSAUTOTEST] Add option to list all testable modules
Mark Jansen [Thu, 2 Jul 2020 20:25:46 +0000 (22:25 +0200)]
[SVCHOST] Fix PSID initialization
CORE-17151
Nguyen Trung Khanh [Sat, 4 Jul 2020 13:41:18 +0000 (20:41 +0700)]
[NTOS:IO] Fix pool memory disclosure in IopQueueTargetDeviceEvent (#2966)
Nguyen Trung Khanh [Sat, 4 Jul 2020 13:39:16 +0000 (20:39 +0700)]
[WIN32SS][GDI] Fix pool memory disclosure in NtGdiGetOutlineTextMetricsInternalW (#2964)
Serge Gautherie [Sat, 4 Jul 2020 13:33:50 +0000 (15:33 +0200)]
[CMAKE] Remove obsolete 'GCC_VERSION' checks (#2962)
following upgrade to RosBE 2.2.0 support and GCC 8.4.
Serge Gautherie [Sat, 4 Jul 2020 13:24:46 +0000 (15:24 +0200)]
[ADVAPI32_WINETEST] test_create_delete_svc(): Fix 'account' size (#2960)
Cherry-pick
https://source.winehq.org/git/wine.git/commit/
56a83c585aeb071af29824399e22db5cdce0318a
Serge Gautherie [Sat, 4 Jul 2020 13:24:13 +0000 (15:24 +0200)]
[UTILDLL_APITEST] Create 'CachedGetUserFromSid()' test (#2954)
Serge Gautherie [Sat, 4 Jul 2020 13:18:22 +0000 (15:18 +0200)]
[ROSTESTS] sertest.c: Replace a busy loop with 'Sleep()' (#2886)
Detected by Cppcheck: uninitvar.
ROSTESTS-204
Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
FritzsHero [Sat, 4 Jul 2020 13:17:26 +0000 (15:17 +0200)]
[OSK] Updated German On-Screen Keyboard translation (#2882)
Serge Gautherie [Sat, 4 Jul 2020 13:16:22 +0000 (15:16 +0200)]
[NET] cmdAccounts(): Set ProductType default value (#2365)
Jose Carlos Jesus [Sat, 4 Jul 2020 13:11:10 +0000 (14:11 +0100)]
[USER32][NTUSER] Fix wrong return from LB_GETLISTBOXINFO (#2168)
And is now consistent with comctl32 and Wine too...
Victor Perevertkin [Sun, 28 Jun 2020 23:37:12 +0000 (02:37 +0300)]
[UDFS] Zero-initialize IO_STATUS_BLOCK data in UDFCommonCreate
Some places have been changed to return FILE_DOES_NOT_EXIST, everything
else just returns 0. FastFAT driver from MS does the same (tm),
so I'm not going to have a big research here.
CORE-16623
Co-authored-by: Suraj K Suresh <kssuraj15@gmail.com>
Oleg Dubinskiy [Thu, 18 Jun 2020 18:06:34 +0000 (21:06 +0300)]
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.
Oleg Dubinskiy [Thu, 18 Jun 2020 12:03:01 +0000 (15:03 +0300)]
[SDK][SVCHOST] Move all global svchost declarations to public header.
Also update the includes.
It will allow to use those declarations globally where they are required (e. g. for SvchostPushServiceGlobals functions in some services).
No functional changes.
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()'
MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}
Addendum to
476c99b and
9efafd6.
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'
Addendum to
0f5d91b.
CORE-16441
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type
MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''
Addendum to
3f15a0d.
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[POWRPROF_APITEST] Fix cppcheck warnings.
* test_CallNtPowerInformation(): Fix 2 'sizeof(sizeof())' copypastas
* test_ValidatePowerPolicies_Next(): Delete a duplicate line
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRT] _onexit(): Fix 'memcpy()' size
Cherry-pick
https://source.winehq.org/git/wine.git/commit/
70bff7377dbe9bdaaac5e86c49ee45130e65e5d9
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.
* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning
Jared Smudde [Sat, 27 Jun 2020 00:51:22 +0000 (19:51 -0500)]
[SYSDM] Set the proper icon in title bar
Thomas Faber [Sat, 27 Jun 2020 07:27:33 +0000 (09:27 +0200)]
[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.
* Check the entire version field
* Check the variant field
* Accept RPC_NT_UUID_LOCAL_ONLY, which is sometimes returned by Windows
* Repeat the test to show that these things happen every time
Based on a patch by Serge Gautherie.
Serge Gautherie [Fri, 26 Jun 2020 17:03:01 +0000 (19:03 +0200)]
[FASTFAT_NEW] Sync to upstream
16022c5 (#2938)
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific
Serge Gautherie [Fri, 22 May 2020 18:24:31 +0000 (20:24 +0200)]
[NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code
No impact.
Detected by Cppcheck: unreachableCode.
Addendum to
ddaf47dec3f096666757ff2cc9892adc01da887c (r34976).
Victor Perevertkin [Wed, 24 Jun 2020 18:14:36 +0000 (21:14 +0300)]
[USBSTOR] Correctly terminate a REG_MULTI_SZ string
returned by the IRP_MN_QUERY_ID handler
Nguyen Trung Khanh [Sat, 20 Jun 2020 03:16:56 +0000 (10:16 +0700)]
[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.
This avoids disclosing pool contents to user mode when not all members
of the respective structure are initialized or when there is padding.
In co_IntCallWindowProc, also zero the stack buffer since this can
be passed to user mode as well, and contains padding.
Thomas Faber [Tue, 23 Jun 2020 08:15:24 +0000 (10:15 +0200)]
[NPFS] Fix querying FileAllInformation.
Victor Perevertkin [Sun, 21 Jun 2020 14:54:44 +0000 (17:54 +0300)]
[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c
And rearrange them in more logical order.
This effectively splits the file, leaving public "Io" functions in
pnpmgr.c along with some things not related do device object management.
Functions which manipulate the device tree are left in devaction.c.
In future all these functions will only be accessed from
DeviceActionWorker.
While being public API, IoRequestDeviceEject and IoInvalidateDeviceState
have been moved to devaction.c as well. In next commits they will be
converted to DeviceActionWorker routines and their callers will be put
in pnpmgr.c
Victor Perevertkin [Mon, 18 May 2020 02:42:53 +0000 (05:42 +0300)]
[ROSAUTOTEST] Add /t parameter for repeating tests
Thomas Faber [Sun, 21 Jun 2020 08:18:19 +0000 (10:18 +0200)]
[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136
Thomas Faber [Sun, 21 Jun 2020 07:57:17 +0000 (09:57 +0200)]
[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136
We neither want to handle IRPs we don't understand, nor do we want to
assert in case of unexpected IOCTLs.
Victor Perevertkin [Fri, 19 Jun 2020 20:55:40 +0000 (23:55 +0300)]
[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c
Add SAL2 annotations to functions while moving
Convert IopCreateDeviceNode description to a Doxygen format
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Remove obsolete compiler workarounds
following upgrade to GCC 8.4 and MSVC 2015.
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] Fix GCC 8.4 build
'.../strucsup.c:...:...: error: 'Ex*NPagedLookasideList' is static but used in inline function 'Fat*' which is not static [-Werror]'
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] fatdata.h: Properly mark ReactOS own code
Addendum to
3013e15.
Thomas Faber [Sun, 7 Jun 2020 07:26:23 +0000 (09:26 +0200)]
[CMAKE] Remove work-arounds for old CMake versions. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 21:00:02 +0000 (23:00 +0200)]
[CMAKE] Use CMake 3.17 default policies. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:59:26 +0000 (22:59 +0200)]
[CMAKE] Bump minimum to 3.17, no longer require -ReactOS build. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 22:20:09 +0000 (00:20 +0200)]
[CMAKE] Set CMAKE_MSVC_RUNTIME_LIBRARY to satisfy CMP0091. CORE-17109
We use /NODEFAULTLIB, and consequently also don't want CMake to add
a default library for us.
Thomas Faber [Sat, 6 Jun 2020 20:57:30 +0000 (22:57 +0200)]
[CMAKE] Use NEW policy for CMP0058. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:57:11 +0000 (22:57 +0200)]
[CMAKE] Mark host tools as byproducts. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:56:49 +0000 (22:56 +0200)]
[BOOTDATA] Mark reactos.inf as a byproduct. CORE-17109
Thomas Brogan [Sat, 20 Jun 2020 10:28:25 +0000 (13:28 +0300)]
[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)
Use QueryPerformanceCounter if a high-resolution timer is requested (<= 5ms) instead of the more inaccurate GetTickCount.
Hervé Poussineau [Thu, 18 Jun 2020 16:18:13 +0000 (18:18 +0200)]
[PCI] Fix PDO removal
We must not do anything on PDO removal, especially not deleting it.
We are allowed to delete it, only once we successfully completed a IRP_MN_QUERY_DEVICE_RELATIONS without with PDO.
Hervé Poussineau [Thu, 18 Jun 2020 17:20:14 +0000 (19:20 +0200)]
[SETUPAPI] Add function names in traces
James Tabor [Thu, 18 Jun 2020 16:55:13 +0000 (11:55 -0500)]
[NtUser] Fix MSVC_x64 Build
Attempt to fix.
James Tabor [Thu, 18 Jun 2020 16:06:31 +0000 (11:06 -0500)]
[NtUser] Fix Crash in Win32k
Use strict thread and desktop verifying. See CORE-15092 and CORE-17133.
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling
Detected by Cppcheck: uselessAssignmentPtrArg.
Addendum to
794e7aa (r31523) and
e647530 (r65893).
Serge Gautherie [Mon, 8 Jun 2020 20:45:45 +0000 (22:45 +0200)]
[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes
Detected by Cppcheck: funcArgOrderDifferent, redundantAssignment.
Serge Gautherie [Mon, 16 Dec 2019 03:28:29 +0000 (04:28 +0100)]
[KMTESTS:OB] ObTypes: Support latest NT5.2 results
Update Port and WaitablePort values.
He Yang [Sun, 14 Jun 2020 18:34:43 +0000 (02:34 +0800)]
[RAPPS] delete obsolete field
Joachim Henze [Sun, 14 Jun 2020 18:03:33 +0000 (20:03 +0200)]
[DNSRSLVR] Define NDEBUG in cache.c
To avoid leaking private data into logs by default.
Some testers may consider their DNS-suffix private data.
And DnsIntCacheAddEntry() logs that via Record->pName.