reactos.git
2 years ago[KMTESTS:MM]
Thomas Faber [Sun, 23 Apr 2017 08:10:46 +0000 (08:10 +0000)]
[KMTESTS:MM]
- Show that NtMapViewOfSection validates section and process handles before checking base address alignment
CORE-13113

svn path=/trunk/; revision=74390

2 years ago[NTOS:MM]
Thomas Faber [Sun, 23 Apr 2017 07:24:44 +0000 (07:24 +0000)]
[NTOS:MM]
- Check for ROS section object before accessing the AllocationAttributes member in NtMapViewOfSection, since ARM3 sections use a different structure.
CORE-13113

svn path=/trunk/; revision=74389

2 years ago[ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375
Mark Jansen [Sat, 22 Apr 2017 17:11:52 +0000 (17:11 +0000)]
[ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375

svn path=/trunk/; revision=74388

2 years ago[ACPPAGE] Update translations based on slayer. CORE-10375
Mark Jansen [Sat, 22 Apr 2017 15:20:25 +0000 (15:20 +0000)]
[ACPPAGE] Update translations based on slayer. CORE-10375
Translators, please check your language, some text was changed!

svn path=/trunk/; revision=74387

2 years ago[KMTESTS:MM]
Thomas Faber [Fri, 21 Apr 2017 08:08:57 +0000 (08:08 +0000)]
[KMTESTS:MM]
- Enable MEM_RESERVED test in SimpleErrorChecks() since it no longer asserts. Patch by Serge Gautherie.
ROSTESTS-109 #resolve

svn path=/trunk/; revision=74386

2 years ago[INPUT.CPL]
Hermès Bélusca-Maïto [Fri, 21 Apr 2017 00:22:39 +0000 (00:22 +0000)]
[INPUT.CPL]
- Remove an unneeded header inclusion;
- Fix a sizeof invocation;
- RegEnumKeyExW and RegEnumValueW take their fourth parameter (size of key / value name, resp.) as a size in number of *characters* (and not in number of bytes);
- Add a missing RegCloseKey call in LocaleList_Create.

svn path=/trunk/; revision=74385

2 years ago[NTOS:KE]
Thomas Faber [Thu, 20 Apr 2017 17:36:40 +0000 (17:36 +0000)]
[NTOS:KE]
- Reset DebugDpcTime before calling timer DPC routines. Avoids spurious "DPC routine > 1 sec" break-ins.

svn path=/trunk/; revision=74384

2 years ago[NTOS:MM]
Thomas Faber [Thu, 20 Apr 2017 08:58:45 +0000 (08:58 +0000)]
[NTOS:MM]
- Avoid reference leaks in failure cases of MmCreateCacheSection
CORE-6931

svn path=/trunk/; revision=74383

2 years ago[VGADDI]
Thomas Faber [Thu, 20 Apr 2017 07:30:01 +0000 (07:30 +0000)]
[VGADDI]
- Fix buffer overflow in DIB_BltFromVGA. A byte fits two pixels.

svn path=/trunk/; revision=74382

2 years ago[TRANSLATION]
Eric Kohl [Wed, 19 Apr 2017 22:10:00 +0000 (22:10 +0000)]
[TRANSLATION]
Romanian resources maintenance
Patch by Ștefan Fulea.
CORE-13099

svn path=/trunk/; revision=74381

2 years ago[SHELL32] Fix for BuildPathsList, this solves some problems showing while copying...
Mark Jansen [Wed, 19 Apr 2017 18:45:33 +0000 (18:45 +0000)]
[SHELL32] Fix for BuildPathsList, this solves some problems showing while copying folders. Patch by 'Gleb'. CORE-8434

svn path=/trunk/; revision=74380

2 years ago[SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later...
Giannis Adamopoulos [Wed, 19 Apr 2017 16:24:59 +0000 (16:24 +0000)]
[SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later free it itself. This was masked by a hacky cast.

svn path=/trunk/; revision=74379

2 years ago[NTOS:MM]
Thomas Faber [Wed, 19 Apr 2017 14:40:53 +0000 (14:40 +0000)]
[NTOS:MM]
- Never use special pool for prototype PTEs. Avoids "(PointerPte >= (PMMPTE)MmPagedPoolStart) && (PointerPte <= (PMMPTE)MmPagedPoolEnd)" assertion failure in MiDecrementShareCount.
CORE-11474

svn path=/trunk/; revision=74378

2 years ago[KERNEL32_WINETEST]
Thomas Faber [Wed, 19 Apr 2017 14:08:51 +0000 (14:08 +0000)]
[KERNEL32_WINETEST]
- Improve the test_GetVolumePathNamesForVolumeNameW hack to avoid a stack buffer underrun.
CORE-11474

svn path=/trunk/; revision=74377

2 years ago[OPENGL32]
Thomas Faber [Wed, 19 Apr 2017 13:16:30 +0000 (13:16 +0000)]
[OPENGL32]
- Fix uninitialized variable use in IntGetIcdData
CORE-11474

svn path=/trunk/; revision=74376

2 years ago[KMTESTS:OB]
Thomas Faber [Wed, 19 Apr 2017 12:21:57 +0000 (12:21 +0000)]
[KMTESTS:OB]
- After ObCreateObject+ObInsertObject a handle close is enough to destroy the object, so do not dereference it in addition. Fixes use after free.
CORE-11474

svn path=/trunk/; revision=74375

2 years ago[KMTESTS:NPFS]
Thomas Faber [Wed, 19 Apr 2017 11:46:34 +0000 (11:46 +0000)]
[KMTESTS:NPFS]
- Remove tests that cause pool buffer overflows. NtQueryVolumeInformationFile does not validate buffer length for kernel mode callers, so passing an invalid length is not a good test.
CORE-11474

svn path=/trunk/; revision=74374

2 years ago[WS2_32][DNSAPI]
Thomas Faber [Wed, 19 Apr 2017 11:14:18 +0000 (11:14 +0000)]
[WS2_32][DNSAPI]
- Avoid stack buffer overflow in ParseV4Address
CORE-11474

svn path=/trunk/; revision=74373

2 years ago[GDI32]
Thomas Faber [Wed, 19 Apr 2017 10:33:58 +0000 (10:33 +0000)]
[GDI32]
- Use the number of WCHARs, not the number of ANSI chars in GetCharABCWidthsA. Fixes stack corruption when running gdi32_winetest:font
CORE-11474

svn path=/trunk/; revision=74372

2 years ago[VARIOUS]
Eric Kohl [Tue, 18 Apr 2017 17:47:08 +0000 (17:47 +0000)]
[VARIOUS]
Updating Turkish Translation
Patch by Erdem Ersoy.
CORE-12362

svn path=/trunk/; revision=74371

2 years ago[USER32]
Thomas Faber [Tue, 18 Apr 2017 14:31:33 +0000 (14:31 +0000)]
[USER32]
- In RealSystemParametersInfoA/SPI_GETDESKWALLPAPER, write the ansi wallpaper path directly into the user's buffer instead of using an allocation (and overrunning it). Fixes crash when running user32_winetest:sysparams with DPH.
Tangential to CORE-13097

svn path=/trunk/; revision=74370

2 years ago[USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages...
Giannis Adamopoulos [Tue, 18 Apr 2017 12:35:57 +0000 (12:35 +0000)]
[USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages if the message is not hooked for PreDefDlgProc and PostDefDlgProc.

svn path=/trunk/; revision=74369

2 years ago[CONCFG]: Addendum for r74366: Initialize the console settings information codepage...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:31:48 +0000 (23:31 +0000)]
[CONCFG]: Addendum for r74366: Initialize the console settings information codepage with the current OEM codepage, and read the optional console "CodePage" DWORD registry setting.
CORE-12451

svn path=/trunk/; revision=74368

2 years ago[CONCFG]: Use 'Success' boolean variable instead of an obscure 'RetVal'.
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:28:41 +0000 (23:28 +0000)]
[CONCFG]: Use 'Success' boolean variable instead of an obscure 'RetVal'.

svn path=/trunk/; revision=74367

2 years ago[CONSOLE.CPL]: Paint the text samples using the correct character set (derived from...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:26:07 +0000 (23:26 +0000)]
[CONSOLE.CPL]: Paint the text samples using the correct character set (derived from the current code page).
This e.g. fixes display for the backslash symbol in CJK languages (that should appear as the Chinese "yuan" / Japanese "yen" currency symbol ¥, or the Korean "won" currency symbol ₩).
CORE-12451

svn path=/trunk/; revision=74366

2 years ago[CONSOLE.CPL]: Add support for Asian fonts & CJK codepage in the console properties...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:21:13 +0000 (23:21 +0000)]
[CONSOLE.CPL]: Add support for Asian fonts & CJK codepage in the console properties dialog.
Based on a patch by Katayama Hirofumi MZ.
CORE-12451

svn path=/trunk/; revision=74365

2 years ago[AT]
Eric Kohl [Mon, 17 Apr 2017 22:28:42 +0000 (22:28 +0000)]
[AT]
Applied hotfix for russian translation.
Patch by Sergey Stopkin.
CORE-12961

svn path=/trunk/; revision=74364

2 years ago[NEWDEV]
Eric Kohl [Mon, 17 Apr 2017 22:20:44 +0000 (22:20 +0000)]
[NEWDEV]
When the driver installation fails, set the CONFIGFLAG_FAILEDINSTALL flag only if the user checked the 'Do not show this dialog anymore' checkbox.
CORE-13095

svn path=/trunk/; revision=74363

2 years ago[NETID]
Eric Kohl [Mon, 17 Apr 2017 21:05:02 +0000 (21:05 +0000)]
[NETID]
Load, display and store the computer description.
Patch by Grzegorz Araminowicz.
- Moved most of the code into separate functions and got rid of its deeply nested structure.
- Added some notification code, so that the Apply button gets enabled when the user changes the description.
CORE-12337

svn path=/trunk/; revision=74362

2 years ago[KMTESTS:MM]
Thomas Faber [Mon, 17 Apr 2017 20:37:26 +0000 (20:37 +0000)]
[KMTESTS:MM]
- Add some missing newlines and skip()s

svn path=/trunk/; revision=74361

2 years ago[WIN32K]
Thomas Faber [Mon, 17 Apr 2017 20:25:55 +0000 (20:25 +0000)]
[WIN32K]
Fix automatic resolution change when resizing the VirtualBox window. Based on a patch by Ismael Ferreras Morezuelas.
- Provide a function, PDEVOBJ_vRefreshModeList, to reload the list of display modes
- Call PDEVOBJ_vRefreshModeList from UserEnumDisplaySettings to get an updated list of modes each time
CORE-6742 #resolve

svn path=/trunk/; revision=74360

2 years ago[WIN32K:ENG]
Thomas Faber [Mon, 17 Apr 2017 19:44:32 +0000 (19:44 +0000)]
[WIN32K:ENG]
- Split populating the display mode list out from EngpRegisterGraphicsDevice, into its own function, EngpPopulateDeviceModeList. Based on a patch by Ismael Ferreras Morezuelas.
CORE-6742

svn path=/trunk/; revision=74359

2 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 18:37:12 +0000 (18:37 +0000)]
[NTOS:CC]
- Respect the TruncateSize parameter in CcUninitializeCacheMap. Avoids "freeing dirty VACB" messages for cache views beyond the end of the file.
CORE-12893 #resolve

svn path=/trunk/; revision=74358

2 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 18:13:17 +0000 (18:13 +0000)]
[NTOS:CC]
- Simplify CcSetFileSizes by using CcPurgeCacheSection
CORE-12893

svn path=/trunk/; revision=74357

2 years ago[CONSOLE.CPL]: Code formatting only (in preparation of a subsequent commit).
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 17:45:18 +0000 (17:45 +0000)]
[CONSOLE.CPL]: Code formatting only (in preparation of a subsequent commit).

svn path=/trunk/; revision=74356

2 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 17:29:10 +0000 (17:29 +0000)]
[NTOS:CC]
- Implement CcPurgeCacheSection
CORE-12893

svn path=/trunk/; revision=74355

2 years ago[FASTFAT]
Thomas Faber [Mon, 17 Apr 2017 16:54:28 +0000 (16:54 +0000)]
[FASTFAT]
- On rename/move, flush parent directory data from cache instead of purging it.
CORE-12893

svn path=/trunk/; revision=74354

2 years ago[WIN32SS] Add full name support in FontFamilyFillInfo. Patch by Katayama Hirofumi...
Mark Jansen [Mon, 17 Apr 2017 16:08:38 +0000 (16:08 +0000)]
[WIN32SS] Add full name support in FontFamilyFillInfo. Patch by Katayama Hirofumi MZ. CORE-10876

svn path=/trunk/; revision=74353

2 years ago[WIN32SS] Add extra logging to failed SURFACE_AllocSurface calls. CORE-13036
Mark Jansen [Mon, 17 Apr 2017 15:48:56 +0000 (15:48 +0000)]
[WIN32SS] Add extra logging to failed SURFACE_AllocSurface calls. CORE-13036

svn path=/trunk/; revision=74352

2 years ago[ISOHYBRID]
Colin Finck [Mon, 17 Apr 2017 13:49:46 +0000 (13:49 +0000)]
[ISOHYBRID]
Don't include inttypes.h, which isn't available on MSVC < 2013. Add the 4 needed typedefs to reactos_support_code.h instead.
Fixes CORE-13031

svn path=/trunk/; revision=74351

2 years ago[WINSPOOL]
Colin Finck [Mon, 17 Apr 2017 13:40:51 +0000 (13:40 +0000)]
[WINSPOOL]
Added tests for some more basic and newly discovered corner cases of EnumPrintersW.

svn path=/trunk/; revision=74350

2 years ago[SERVMAN]
Eric Kohl [Mon, 17 Apr 2017 12:48:51 +0000 (12:48 +0000)]
[SERVMAN]
Track changes to the general and and recovery pages.
CORE-12743

svn path=/trunk/; revision=74349

2 years agoAvoid attempts to reinstall a driver on reboot when a previous attempt has already...
Eric Kohl [Mon, 17 Apr 2017 11:34:08 +0000 (11:34 +0000)]
Avoid attempts to reinstall a driver on reboot when a previous attempt has already failed.

[NEWDEV]
Set the CONFIGFLAG_FAILEDINSTALL flag in the new hardware wizards welcome page and remove it only when the driver was successfully installed.

[UMPNPMGR]
Do not invoke the device installer if the devices CONFIGFLAG_FAILEDINSTALL flag is set.

svn path=/trunk/; revision=74348

2 years ago[BROWSEUI] Port some IAutoComplete changes from wine + fix a memory leak. This allows...
Mark Jansen [Mon, 17 Apr 2017 09:35:08 +0000 (09:35 +0000)]
[BROWSEUI] Port some IAutoComplete changes from wine + fix a memory leak. This allows the dropdown to show with ACO_AUTOSUGGEST and an empty input.

svn path=/trunk/; revision=74347

2 years ago[BROWSEUI] -Remove a couple of lines that shouldn't have been committed.
Giannis Adamopoulos [Mon, 17 Apr 2017 09:15:45 +0000 (09:15 +0000)]
[BROWSEUI] -Remove a couple of lines that shouldn't have been committed.

svn path=/trunk/; revision=74346

2 years ago[BROWSEUI] -CBandSiteMenu: Add preliminary support for adding and removing bands...
Giannis Adamopoulos [Mon, 17 Apr 2017 09:02:49 +0000 (09:02 +0000)]
[BROWSEUI] -CBandSiteMenu: Add preliminary support for adding and removing bands in the taskbar. If a class was registered in the CATID_DeskBand category it will be shown in the menu and selecting it can add it or remove it from the taskbar. Showing the two built in ones (quick launch and desktop) is not implemented yet.

svn path=/trunk/; revision=74345

2 years ago[WINMINE]
Eric Kohl [Sun, 16 Apr 2017 22:42:38 +0000 (22:42 +0000)]
[WINMINE]
Fix vertical aligment of the digits in mines.bmp.
Patch by Andre Semaki.
CORE-12777

svn path=/trunk/; revision=74344

2 years ago[SHELL]
Eric Kohl [Sun, 16 Apr 2017 22:00:46 +0000 (22:00 +0000)]
[SHELL]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74343

2 years ago[MEDIA/RAPPS]
Eric Kohl [Sun, 16 Apr 2017 21:57:41 +0000 (21:57 +0000)]
[MEDIA/RAPPS]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74342

2 years ago[OPENGLCFG]
Eric Kohl [Sun, 16 Apr 2017 21:53:37 +0000 (21:53 +0000)]
[OPENGLCFG]
Add russain translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74341

2 years ago[NET]
Eric Kohl [Sun, 16 Apr 2017 21:48:43 +0000 (21:48 +0000)]
[NET]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74340

2 years ago[LSASRV]
Eric Kohl [Sun, 16 Apr 2017 21:45:43 +0000 (21:45 +0000)]
[LSASRV]
Update the russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74339

2 years ago[AT]
Eric Kohl [Sun, 16 Apr 2017 21:42:09 +0000 (21:42 +0000)]
[AT]
Fix outdated russian translation.

svn path=/trunk/; revision=74338

2 years ago[HIVECLS]
Eric Kohl [Sun, 16 Apr 2017 21:33:56 +0000 (21:33 +0000)]
[HIVECLS]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74337

2 years ago[FONTVIEW]
Eric Kohl [Sun, 16 Apr 2017 21:30:29 +0000 (21:30 +0000)]
[FONTVIEW]
Update the russain translation.
CORE-12525

svn path=/trunk/; revision=74336

2 years ago[SHELL32]
Eric Kohl [Sun, 16 Apr 2017 21:26:05 +0000 (21:26 +0000)]
[SHELL32]
Translate folder options.
CORE-12525

svn path=/trunk/; revision=74335

2 years ago[NEWDEV]
Eric Kohl [Sun, 16 Apr 2017 21:21:36 +0000 (21:21 +0000)]
[NEWDEV]
Fix control sizes in russian dialogs.
CORE-12525

svn path=/trunk/; revision=74334

2 years ago[AT]
Eric Kohl [Sun, 16 Apr 2017 20:57:30 +0000 (20:57 +0000)]
[AT]
Added RU translation to the AT command.

[BLACKSHADE]
Added RU translation to the blackshade theme.
CORE-12961

svn path=/trunk/; revision=74333

2 years ago[DESK]
Eric Kohl [Sun, 16 Apr 2017 20:39:37 +0000 (20:39 +0000)]
[DESK]
Added en-GB to desk.cpl.
CORE-13014

svn path=/trunk/; revision=74332

2 years ago[USETUP]
Eric Kohl [Sun, 16 Apr 2017 20:22:03 +0000 (20:22 +0000)]
[USETUP]
base/setup/usetup/it-IT translation patch.
CORE-12999 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=74331

2 years ago[SHLWAPI_UNDOC.H] -Fix definition of IUnknown_SetOwner.
Giannis Adamopoulos [Sun, 16 Apr 2017 19:35:19 +0000 (19:35 +0000)]
[SHLWAPI_UNDOC.H] -Fix definition of IUnknown_SetOwner.

svn path=/trunk/; revision=74330

2 years ago[EXPLORER] -If rshell is present and CBandSiteMenu_CreateInstance or CBandSite_Create...
Giannis Adamopoulos [Sun, 16 Apr 2017 19:29:27 +0000 (19:29 +0000)]
[EXPLORER] -If rshell is present and CBandSiteMenu_CreateInstance or CBandSite_CreateInstance are exported, use them instead of using the one provided by the system. Now we can start developing CBandSite and CBandSiteMenu on windows to implement support for taskbar toolbars.

svn path=/trunk/; revision=74329

2 years agoFix GCC build, part 4/X (losing my optimism)
Colin Finck [Sun, 16 Apr 2017 15:51:44 +0000 (15:51 +0000)]
Fix GCC build, part 4/X (losing my optimism)

svn path=/trunk/; revision=74328

2 years agoFix GCC build (3/3) :)
Colin Finck [Sun, 16 Apr 2017 15:44:22 +0000 (15:44 +0000)]
Fix GCC build (3/3) :)

svn path=/trunk/; revision=74327

2 years agoFix GCC build (2/2)
Colin Finck [Sun, 16 Apr 2017 15:37:31 +0000 (15:37 +0000)]
Fix GCC build (2/2)

svn path=/trunk/; revision=74326

2 years agoFix GCC build
Colin Finck [Sun, 16 Apr 2017 14:30:07 +0000 (14:30 +0000)]
Fix GCC build

svn path=/trunk/; revision=74325

2 years ago[LOCALSPL]
Colin Finck [Sun, 16 Apr 2017 14:12:01 +0000 (14:12 +0000)]
[LOCALSPL]
- Refactor LocalEnumPrinters to make it ready for supporting additional levels.
- Correctly handle all passed flags for Level 1 queries to the Local Print Provider.
- Introduce strsafe functions to LocalEnumPrinters in a way that actually makes the code smaller. To be done in other parts too.
- Use PackStrings in LocalEnumPrinters to simplify the code.
- Return the correct 3 strings in the Description field of Level 1 queries. That also introduces the "Location" field.
- Remove debug spam in _OpenEnvironment.

[SPOOLSV]
- Make use of the newly implemented AlignRpcPtr/UndoAlignRpcPtr. Fixes a test.

[WINSPOOL]
- Dismiss invalid levels already in EnumPrintersW and zero the input buffer here (but not in localspl). Verified by a test.

EnumPrintersW for Level 1 should be fully supported now.

svn path=/trunk/; revision=74324

2 years ago[SPOOLSS]
Colin Finck [Sun, 16 Apr 2017 10:36:16 +0000 (10:36 +0000)]
[SPOOLSS]
Add ASSERTs, improve documentation and the variety of tests for AlignRpcPtr/UndoAlignRpcPtr.
Based on comments by Serge Gautherie.

svn path=/trunk/; revision=74323

2 years ago[NTOS:CC]
Thomas Faber [Sun, 16 Apr 2017 08:50:20 +0000 (08:50 +0000)]
[NTOS:CC]
- Rename ROS_SHARED_CACHE_MAP::RefCount to OpenCount. One step closer to the real SHARED_CACHE_MAP.
CORE-8065

svn path=/trunk/; revision=74322

2 years agoFix copypasta error, spotted by Thomas.
Mark Jansen [Sat, 15 Apr 2017 22:18:29 +0000 (22:18 +0000)]
Fix copypasta error, spotted by Thomas.

svn path=/trunk/; revision=74320

2 years ago[UNIATA]
Thomas Faber [Sat, 15 Apr 2017 20:24:43 +0000 (20:24 +0000)]
[UNIATA]
- Update to version 0.46e3 (and fix up the version numbers)
- Un-"fix" insignificant typo corrections that only serve to make syncing harder
CORE-13032 #resolve
CORE-11894 CORE-11277 CORE-12909

svn path=/trunk/; revision=74319

2 years ago[RTL]
Thomas Faber [Sat, 15 Apr 2017 17:39:49 +0000 (17:39 +0000)]
[RTL]
- In Wait_thread_proc, prioritize the cancel event over the wait object. This avoids executing the callback again after RtlDeregisterWait has been called.
Fixes ThemeStartCallback being called twice, causing a double free.
CORE-13074 #resolve

svn path=/trunk/; revision=74318

2 years ago[SCHEDSVC]
Eric Kohl [Sat, 15 Apr 2017 10:33:29 +0000 (10:33 +0000)]
[SCHEDSVC]
Insert a job into the start list when it is loaded or added. Remove it from the start list when it gets deleted. The start list is sorted by start time.

svn path=/trunk/; revision=74317

2 years ago[WIN32SS] Addendum to r74312 and r74309, fix some bad memory leaks. CORE-10876
Mark Jansen [Fri, 14 Apr 2017 21:22:18 +0000 (21:22 +0000)]
[WIN32SS] Addendum to r74312 and r74309, fix some bad memory leaks. CORE-10876
Thanks Giannis and Thomas :)

svn path=/trunk/; revision=74316

2 years ago[SCHEDSVC]
Eric Kohl [Fri, 14 Apr 2017 21:16:37 +0000 (21:16 +0000)]
[SCHEDSVC]
Calculate the next start time of a job and store it in the job object. DaysOfMonth and DaysOfWeek are not taken into account yet.

svn path=/trunk/; revision=74315

2 years ago[SHELLUTILS.H]
Giannis Adamopoulos [Fri, 14 Apr 2017 20:03:46 +0000 (20:03 +0000)]
[SHELLUTILS.H]
- Remove the ShellObjectCreator templates that allowed the caller to pass an arbitrary interface pointer. Leaving only the templates that take an void ** ppv parameter means that the callers are forced to use IID_PPV_ARG. This makes it less likely to have a pointer to an wrong interface.
- Fix the callers to always use IID_PPV_ARG.
- Rewrite the ShellObjectCreator templates to create the objects using the ATL CreateInstance thus allowing internal ATL methods to be called.

[BROWSEUI]
-Let CBandSite_CreateInstance take an additional parameter for the outer object since CBandSite is aggregatable. Create the object using the ATL creator class.

svn path=/trunk/; revision=74314

2 years ago[WIN32SS] Fix charset in font enumeration. Patch by Katayama Hirofumi MZ. CORE-10876
Mark Jansen [Fri, 14 Apr 2017 18:32:07 +0000 (18:32 +0000)]
[WIN32SS] Fix charset in font enumeration. Patch by Katayama Hirofumi MZ. CORE-10876

svn path=/trunk/; revision=74313

2 years ago[WIN32SS] Initial fixes for localized font enumeration. Patch by Katayama Hirofumi...
Mark Jansen [Fri, 14 Apr 2017 18:30:57 +0000 (18:30 +0000)]
[WIN32SS] Initial fixes for localized font enumeration. Patch by Katayama Hirofumi MZ. CORE-10876

svn path=/trunk/; revision=74312

2 years ago[EXPLORER] Addendum to r74307: Fix copypasta CORE-11498
Robert Naumann [Fri, 14 Apr 2017 18:25:05 +0000 (18:25 +0000)]
[EXPLORER] Addendum to r74307: Fix copypasta CORE-11498

svn path=/trunk/; revision=74311

2 years ago[WIN32SS] Count number of faces added instead of fonts in IntGdiLoadFontsFromMemory.
Mark Jansen [Fri, 14 Apr 2017 18:24:44 +0000 (18:24 +0000)]
[WIN32SS] Count number of faces added instead of fonts in IntGdiLoadFontsFromMemory.
This fixes displaying embedded fonts in firefox.
CORE-13046 CORE-13056

svn path=/trunk/; revision=74310

2 years ago[WIN32SS] Cleanup fonts at process destruction + implement font memory reference...
Mark Jansen [Fri, 14 Apr 2017 18:22:57 +0000 (18:22 +0000)]
[WIN32SS] Cleanup fonts at process destruction + implement font memory reference counting.
Thanks to everyone involved in reviewing this code! (See CR-112)
CORE-13056

svn path=/trunk/; revision=74309

2 years ago[WIN32SS] Add missing \n to DPRINT1 Spotted by Thomas Schneider.
Mark Jansen [Fri, 14 Apr 2017 18:20:13 +0000 (18:20 +0000)]
[WIN32SS] Add missing \n to DPRINT1 Spotted by Thomas Schneider.

svn path=/trunk/; revision=74308

2 years ago[EXPLORER] start reworking some code for loading/saving settings implementation CORE...
Robert Naumann [Fri, 14 Apr 2017 18:08:34 +0000 (18:08 +0000)]
[EXPLORER] start reworking some code for loading/saving settings implementation CORE-11498

- Rename the settings structure to something more meaningful for using it for all taskbar related settings
- define some default settings
- check checkboxes with settings values in the properties window
- move saving the settings to an own function which will be implemented later

svn path=/trunk/; revision=74307

2 years ago[AT]
Eric Kohl [Fri, 14 Apr 2017 15:54:08 +0000 (15:54 +0000)]
[AT]
Improve the time parser to handle 12-hour and 24-hour formats correctly.

svn path=/trunk/; revision=74306

2 years ago[NTOS:KE]
Thomas Faber [Fri, 14 Apr 2017 11:18:22 +0000 (11:18 +0000)]
[NTOS:KE]
- Gracefully handle page faults during V86 code execution. This is a bit of a hack because with our limited use of V86 code it is unclear how a page fault can even occur.
CORE-12993 #resolve

svn path=/trunk/; revision=74305

2 years ago[NTOS:KE]
Thomas Faber [Fri, 14 Apr 2017 10:39:07 +0000 (10:39 +0000)]
[NTOS:KE]
- Make decoding of the error code more obvious in KiTrap0EHandler
- Avoid or make explicit some signed/unsigned conversions

svn path=/trunk/; revision=74304

2 years ago[USBSTOR]
Thomas Faber [Fri, 14 Apr 2017 10:24:41 +0000 (10:24 +0000)]
[USBSTOR]
- Avoid MDL leak in USBSTOR_SendIrp. Patch by Lesan Ilie.
CORE-13061 #resolve

svn path=/trunk/; revision=74303

2 years ago[HIDCLASS]
Thomas Faber [Fri, 14 Apr 2017 09:55:17 +0000 (09:55 +0000)]
[HIDCLASS]
Patch by Lesan Ilie:
- Avoid over-allocating the DEVICE_RELATIONS structure in HidClassPDO_CreatePDO
- Allocate device relations from paged pool
CORE-13052 #resolve

svn path=/trunk/; revision=74302

2 years ago[CABMAN]
Thomas Faber [Fri, 14 Apr 2017 09:50:37 +0000 (09:50 +0000)]
[CABMAN]
- Fix leaks in ExtractFile and avoid double frees from failure cases of AddFile. Patch by Serge Gautherie.
CORE-7307 #resolve

svn path=/trunk/; revision=74301

2 years ago[ACPI]
Thomas Faber [Fri, 14 Apr 2017 09:32:47 +0000 (09:32 +0000)]
[ACPI]
- Ensure null termination of the method name passed to AcpiEvaluateObject in Bus_PDO_EvalMethod. Spotted by ReactCoder.
CORE-13068 #resolve

svn path=/trunk/; revision=74300

2 years ago[CRT] remove a self assignment. CORE-8215 #resolve
Robert Naumann [Thu, 13 Apr 2017 19:09:31 +0000 (19:09 +0000)]
[CRT] remove a self assignment. CORE-8215 #resolve

svn path=/trunk/; revision=74299

2 years ago[UXTHEME] DrawNCPreview(): Fix copypasta
Robert Naumann [Thu, 13 Apr 2017 17:41:27 +0000 (17:41 +0000)]
[UXTHEME] DrawNCPreview(): Fix copypasta

svn path=/trunk/; revision=74298

2 years ago[SPOOLSS]
Colin Finck [Thu, 13 Apr 2017 16:48:40 +0000 (16:48 +0000)]
[SPOOLSS]
Implement the undocumented AlignRpcPtr and UndoAlignRpcPtr functions used by many Rpc* functions in spoolsv according to traced callchains.
I could reverse engineer them entirely using rohitab.com's API Monitor and black-box testing.
I also add documented tests covering all cases I found out. We now pass 17/17 tests on Windows Server 2003 and ReactOS.

Also const-ify a parameter in PackStrings.

svn path=/trunk/; revision=74297

2 years ago[NTOS:OB]
Eric Kohl [Tue, 11 Apr 2017 19:58:05 +0000 (19:58 +0000)]
[NTOS:OB]
- Move device map code into a separate file.
- Create and inherit device maps instead of using a single global device map.

svn path=/trunk/; revision=74296

2 years ago[SETUPAPI]
Eric Kohl [Mon, 10 Apr 2017 19:17:17 +0000 (19:17 +0000)]
[SETUPAPI]
Implement CMP_GetServerSideDeviceInstallFlags().

svn path=/trunk/; revision=74295

2 years ago[UMPNPMGR]
Eric Kohl [Mon, 10 Apr 2017 19:12:17 +0000 (19:12 +0000)]
[UMPNPMGR]
Implement most of PNP_GetServerSideDeviceInstallFlags().

svn path=/trunk/; revision=74294

2 years ago[RSHELL] -Link to shellbars and export CBandSite_CreateInstance and CBandSiteMenu_Cre...
Giannis Adamopoulos [Sun, 9 Apr 2017 15:10:08 +0000 (15:10 +0000)]
[RSHELL] -Link to shellbars and export CBandSite_CreateInstance and CBandSiteMenu_CreateInstance.
[SHELLMENU] -Remove second copy of CBandSite. It was originally added here to be tested in windows but now it is hosted in a proper static link.

svn path=/trunk/; revision=74293

2 years ago[BROWSEUI] -Move the following classes to a new static lib called shellbars: CBandSit...
Giannis Adamopoulos [Sun, 9 Apr 2017 13:51:39 +0000 (13:51 +0000)]
[BROWSEUI] -Move the following classes to a new static lib called shellbars: CBandSite, CBandSiteMenu, CBaseBar, CSHEnumClassesOfCategories.
- This will be linked to rshell in order to implement support for additional toolbars in the taskbar as well as floating toolbars.
- In the future more classes will be added in this static lib including: CISFBand (which implements a dockable toolbar that shows the contents of a shell folder), CQuickLinks (a special CISFBand), CDeskBarApp (a special CBaseBar that implements the floating host for toolbars) and perhaps more.

svn path=/trunk/; revision=74292

2 years ago[NTOS:MM]
Sylvain Petreolle [Sun, 9 Apr 2017 12:26:16 +0000 (12:26 +0000)]
[NTOS:MM]
Addendum to r74263:
- Really only warn once in MmLockPageableDataSection/MmUnlockPageableImageSection, not on every 256th call

svn path=/trunk/; revision=74291

2 years ago[SCHEDSVC]
Eric Kohl [Sun, 9 Apr 2017 10:03:20 +0000 (10:03 +0000)]
[SCHEDSVC]
Add missing file. Sorry!

svn path=/trunk/; revision=74290