Hermès Bélusca-Maïto [Sat, 9 Jan 2016 11:39:56 +0000 (11:39 +0000)]
[USETUP]: Do not append an extra NULL-terminator when updating freeldr.ini
svn path=/trunk/; revision=70558
Hermès Bélusca-Maïto [Sat, 9 Jan 2016 11:22:20 +0000 (11:22 +0000)]
[USETUP]: Since calling RtlAllocateHeap with the HEAP_ZERO_MEMORY flag works as expected, just use it instead of manually zero-out the newly-created buffer just after.
svn path=/trunk/; revision=70557
Alex Ionescu [Sat, 9 Jan 2016 05:39:18 +0000 (05:39 +0000)]
[BOOTMGFW]: Implement the final boot selection & launch loop.
[BOOTMLIB]: Implement a few more BCD option functions.
Minus a PE loader (BmpLaunchBootEntry) and some more BCD parsing (BmpGetSelectedBootEntry) with some glue in between, the UEFI Boot Manager is nearly done. Once it is, it will be time to implement the actual loader -- Winload.efi. The good news is that we'll have all of bootlib already good to go (with all its hacks). The bad news is that Winload will turn on paging, so all those unimplemented paths and UEFI mode switches will have to be made to work.
svn path=/trunk/; revision=70556
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 21:14:13 +0000 (21:14 +0000)]
[DEVMGR]: Keep the computer name as it is, don't lower-case it.
svn path=/trunk/; revision=70555
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 20:27:55 +0000 (20:27 +0000)]
[CDMAKE]: Improve an error message.
svn path=/trunk/; revision=70554
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 20:25:30 +0000 (20:25 +0000)]
[CDMAKE]
- #if _WIN32 --> #ifdef _WIN32
- Define the "max" macro only if needed.
- Fix a comment.
- Plug a memory leak ('case_name' not freed in the "!*case_name" case of the dir_hash_create_dir function).
- Return a non-zero value (the file structure pointer) from dir_hash_add_file in case we succeed in creating the file in the ISO structure, and NULL otherwise (i.e. when the filename is empty). In that latter case we fail the hard way. No-named files are completely invalid in ISO archives. Now, the following testcase (e.g. to be added into bootcd.lst):
reactos/reactos.exe/=C:/test/reactos.exe
fails as expected (before, we were able to create a directory named "reactos/reactos.exe", and inside, a no-named file with the contents of C:/test/reactos.exe).
svn path=/trunk/; revision=70553
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 18:43:46 +0000 (18:43 +0000)]
[CDMAKE]
- Optimize splitting paths (merge chop_dirname and chop_filename functions).
- Make the code working as expected for the following testcases (you can test these by adding the following lines into e.g. bootcd.lst):
testdir1 --> create "testdir1" in the root directory.
testdir2/ --> create "testdir2" in the root directory. No no-named subdirectory is created.
testdir3// --> create "testdir3" in the root directory. No no-named subdirectory is created.
dir1//\/dir14///\//\// --> create "dir1" in the root directory, and "dir14" inside dir1. No no-named subdirectory is created.
EFI/ReactOS/Boot/Fonts//chs_boot.ttf=C:/somepath/chs_boot.ttf --> create the directories "EFI/ReactOS/Boot/Fonts", no no-named subdirectory is created, and create in the Fonts directory the file "chs_boot.ttf".
Before those changes, empty no-named (therefore, invalid) subdirectories were created in the second, third and fourth testcases, and an obscure error was returned in the fifth testcase.
svn path=/trunk/; revision=70552
Thomas Faber [Fri, 8 Jan 2016 16:41:39 +0000 (16:41 +0000)]
[ACPICA]
- Update to version
20160108
svn path=/trunk/; revision=70551
Thomas Faber [Fri, 8 Jan 2016 16:37:52 +0000 (16:37 +0000)]
[ACPICA]
- Actually use the BSD/GPL licensed version as we should be, instead of the Intel license
svn path=/trunk/; revision=70550
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 15:01:11 +0000 (15:01 +0000)]
[BOOTMGR]: Fix missing '\r' for EfiPrintf newlines, and few misspellings.
svn path=/trunk/; revision=70549
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 13:51:45 +0000 (13:51 +0000)]
[FATTEN]: Set the directory volume label in addition to the bootsector label.
[FATFS]: For FAT12 volumes, do not expand the FAT size.
svn path=/trunk/; revision=70548
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 13:22:23 +0000 (13:22 +0000)]
[FATFS]: When creating a directory (or setting the volume label), the create time should be set correctly.
svn path=/trunk/; revision=70547
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 12:59:19 +0000 (12:59 +0000)]
[FATTEN:FATFS]: Minor code reshuffling to make ease for syncing with future versions of the FatFS library (currently 0.11a).
svn path=/trunk/; revision=70546
Hermès Bélusca-Maïto [Fri, 8 Jan 2016 12:14:53 +0000 (12:14 +0000)]
[FATTEN]: FAT FS month is 1-based.
svn path=/trunk/; revision=70545
Alex Ionescu [Fri, 8 Jan 2016 06:19:14 +0000 (06:19 +0000)]
[BOOTMGFW]: Last few straggling initialization checks.
[BOOTMGFW]: Recover the boot sequence from the BCD and entire the boot selection stage. Now the fun begins.
svn path=/trunk/; revision=70544
Alex Ionescu [Fri, 8 Jan 2016 06:03:55 +0000 (06:03 +0000)]
[BOOTMGFW]: Implement additional startup logic
[BOOTLIB]: Implement initial SecureBoot support.
[BOOTLIB]: Implement UEFI Variable query support.
svn path=/trunk/; revision=70543
Alex Ionescu [Fri, 8 Jan 2016 01:18:08 +0000 (01:18 +0000)]
Three tiny squirmy subtle bugs combined themselves with the bug that was just fixed to make bootmgfw believe it was being booted from a raw removable disk (floppy). Because bootmgfw now correctly enumerates boot devices and detects the DVD/CDROM media, it could no longer 'find itself', believing it was on a floppy.
[BOOTLIB]: When failing to find a block device, keep going searching for more, instead of giving up (critical, because the CDROM FAT12 image is now device path #1, not #0).
[BOOTMGR]: Correctly use the right logical operator in EfiInitpGetDeviceNode to get the deepest-level media device node. We now get the CDROM node, not the raw node.
[CDMAKE]: Don't actually create an EFI/BOOT directory on the CDROM itself, but rather in the FAT12 image. Otherwise, this can confuse UEFI implementations to boot the boot manager off the raw CDROM, instead of the FAT12 image on the CDROM.
svn path=/trunk/; revision=70542
Alex Ionescu [Fri, 8 Jan 2016 00:15:00 +0000 (00:15 +0000)]
[BOOTLIB]: Fix a few subtle bugs which made us incorrectly believe that we were booting from a raw removable drive. We now correctly detect that we are booting off CDROM media. Of course, now everything else is hopelessly broken and we've regressed to die before we get anywhere. Progress.
svn path=/trunk/; revision=70540
Alex Ionescu [Thu, 7 Jan 2016 23:43:15 +0000 (23:43 +0000)]
[BOOTLIB]: ACPI support (RSDP, XSDT/RSDT and arbitrary table lookup + mapping)
[BOOTLIB]: Additional text and graphics console support. Among other things, we have now gained the ability to fill a buffer with a particular color.
[BOOTLIB]: OEM Bitmap (ACPI 5!) support.
[BOOTMGR]: Continue making a few more initialization calls now that bootlib supports more functionality.
svn path=/trunk/; revision=70539
Alex Ionescu [Thu, 7 Jan 2016 23:25:49 +0000 (23:25 +0000)]
[ACPI.H]: Fix broken definition of RSDP_SIGNATURE
[ACPI.H]: Add BGRT_TABLE definition.
svn path=/trunk/; revision=70538
Pierre Schweitzer [Thu, 7 Jan 2016 22:44:33 +0000 (22:44 +0000)]
[ROSVBOXMGMT]
Update the registry configuration to reflect the recent changes to rosvboxmgmt.
Just uncomment the line matching the behavior you prefer.
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70537
Pierre Schweitzer [Thu, 7 Jan 2016 22:43:00 +0000 (22:43 +0000)]
[ROSVBOXMGMT]
Introduce another automagic thing. Instead of creating shortlinks once shared folders have been enumerated, just assign them a drive letter!
See it in action: https://twitter.com/HeisSpiter/status/
685229912748371968
Choose the one you prefer for 0.4.0 :-)
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70536
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 20:00:05 +0000 (20:00 +0000)]
[NTOS:PO]: Whitespace fixes only!
svn path=/trunk/; revision=70535
Pierre Schweitzer [Thu, 7 Jan 2016 19:23:55 +0000 (19:23 +0000)]
[FDC]
Fix FdcPower() stub so that it doesn't leak IRP on shutdown
Dedicated to Thomas.
CORE-10117
svn path=/trunk/; revision=70531
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 19:03:35 +0000 (19:03 +0000)]
[SMSS]
- Reenable RTL_QUERY_REGISTRY_DELETE: the "PendingFileRenameOperations(2)" and "AllowProtectedRenames" registry values are deleted after being parsed: we don't retry at every reboot to remove/rename files that were already deleted/renamed.
- Remove superfluous parentheses.
- Warn a FIXME if SFC-protected file renames are allowed and we are processing file renames (the "protected file renames" stuff is unimplemented atm.)
svn path=/trunk/; revision=70530
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 16:57:05 +0000 (16:57 +0000)]
[SMSS]
- Use CRT string functions to loop through multi-strings.
- Do not fail the full KnownDll setup if one dll fails to load. Instead, just properly skip the file (and related to that, fix a bug when skipping excluded known dll files).
- Page files should be created only when we are not in WinPE mode (aka. MiniNTBoot = FALSE).
- Formatting fix in smloop.c, no code change.
svn path=/trunk/; revision=70529
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 15:14:40 +0000 (15:14 +0000)]
[BOOTDATA]
- Add support for opening ICO, EMF, TIF and WMF files with the shell image viewer since it already implements what is needed (via gdiplus).
- Add some missing "Content Type" (MIME type) and "PerceivedType" values for the image extensions.
[SHIMGVW]
- Enable the resource strings for EMF, TIF and WMF files since we actually support them.
Should be merged for 0.4 branch.
svn path=/trunk/; revision=70528
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 14:04:07 +0000 (14:04 +0000)]
[SHELL32]: Nicely handle network drives in property dialog (and their icon). By Jared Smudde. To be synced for 0.4.0. CORE-10779
svn path=/trunk/; revision=70527
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 13:44:20 +0000 (13:44 +0000)]
[USBEHCI]: Fix a wrong DPRINT string (caught by Thomas).
svn path=/trunk/; revision=70526
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 13:31:46 +0000 (13:31 +0000)]
[BOOTDATA]: Fix encoding and broken french translation caused by r70375.
svn path=/trunk/; revision=70523
Aleksey Bragin [Thu, 7 Jan 2016 12:09:03 +0000 (12:09 +0000)]
[LDR]
- Implement support for manifest prober routine in LdrpWalkImportDescriptor, in its simplest way
- Implement such routine in kernel32 (that's mostly a copy of Wine's create_module_activation_context which seems to nicely correspond to what Windows does).
- As create_module_activation_context is moved into kernel32, delete it from ntdll
- Improve debug output in RTL's Activation Context implementation to ease debugging
- Now, ReactOS indeed looks for and actually loads manifests when loading modules. Thanks to http://blog.tombowles.me.uk/2009/10/05/winsxs/ for a really good description of how activation contexts work
CORE-7313
svn path=/trunk/; revision=70522
Alex Ionescu [Thu, 7 Jan 2016 05:30:18 +0000 (05:30 +0000)]
[BOOTLIB]: More debug print cleanups
[BOOTLIB]: Fix incorrect use of flag introduced a few revisions ago. This fixes <1MB RAM descriptors.
[BOOTLIB]: Enable BmFwMemoryInitialize, since it works now.
All (known) bugs are fixed, bootmgr is back on track.
svn path=/trunk/; revision=70516
Alex Ionescu [Thu, 7 Jan 2016 05:14:26 +0000 (05:14 +0000)]
[BOOTLIB]: Cleanup some debug prints.
[BOOTLIB]: Fix two big device I/O bugs (it's a miracle it worked)
[BOOTLIB]: Use defined constants and comment some more device I/O code.
svn path=/trunk/; revision=70515
Alex Ionescu [Thu, 7 Jan 2016 04:28:13 +0000 (04:28 +0000)]
[BOOTLIB]: Add support for initializing the input console object.
[BOOTLIB]: Add a bunch more graphical console support functions.
[BOOTLIB]: Cleanup some older graphics-related code.
[BOOTLIB]: Support graphics re-initialization. We now correctly fallback to text mode since font loading is not implemented.
svn path=/trunk/; revision=70514
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 01:23:51 +0000 (01:23 +0000)]
[BOOTVID_FONGEN]
- Fix a comment;
- Less hardcoded values.
svn path=/trunk/; revision=70513
Hermès Bélusca-Maïto [Thu, 7 Jan 2016 00:29:41 +0000 (00:29 +0000)]
[BOOTVID_FONT_GEN]
Improve the bootvid font generator of Colin (see r70507) in many ways:
- Allow the user to specify the font name (optional), and optionally a font size and x- and y-offset so that (s)he doesn't have to recompile the generator each time (s)he wants to test a new font.
- The default settings (in case the user doesn't specify all or part of the font definition) are those of Windows' bootvid font (i.e. "Lucida Console", font size 10, x_offset = y_offset = 0).
- Create only once the DC and the font handle (to be used for all the generated characters) instead of each time a character is being generated. I still keep the recreation of the HBITMAP for each character (I don't know if we can also improve there by creating it once and zeroing it out before generating each character).
svn path=/trunk/; revision=70512
Hermès Bélusca-Maïto [Wed, 6 Jan 2016 23:43:38 +0000 (23:43 +0000)]
[USB(E|O|U)HCI]: Handle failure cases of BuildTransferDescriptorChain. By contributor 'vgal'. This is needed for gracefully handling failure cases hit during diagnosing CORE-8046.
CORE-10776
svn path=/trunk/; revision=70511
Pierre Schweitzer [Wed, 6 Jan 2016 19:47:03 +0000 (19:47 +0000)]
[ROSVBOXMGMT]
Add a commented out way to automatically start `rosvboxmgmt auto' on start so that shortcuts for VBox shared folders are properly created.
This is to be enabled on 0.4.0.
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70510
Hermès Bélusca-Maïto [Wed, 6 Jan 2016 17:39:08 +0000 (17:39 +0000)]
[BOOTVID]: CORE-10777 #comment Sync the Plan-9 font to ARM bootvid. Addendum to r70508.
svn path=/trunk/; revision=70509
Amine Khaldi [Wed, 6 Jan 2016 15:43:24 +0000 (15:43 +0000)]
[BOOTVID] Use plan 9 8x13 font from Markus Kuhn. Patch by Roy Tam. CORE-10777
svn path=/trunk/; revision=70508
Colin Finck [Wed, 6 Jan 2016 09:31:53 +0000 (09:31 +0000)]
[BOOTVID]
Change the Blue Screen Font hardcoded into bootvid.dll to the Open Source "Anonymous Pro" font, which makes a nice 8x13 font.
Blue Screens now look like this: http://fs5.directupload.net/images/160106/ehv6245t.png
[BOOTVID_FONT_GENERATOR]
In case you find an even better font, you now have a nice little tool to test that font and generate the corresponding FontData array for bootvid.
svn path=/trunk/; revision=70507
Alex Ionescu [Wed, 6 Jan 2016 04:43:23 +0000 (04:43 +0000)]
[BOOTLIB]: Add very early work around font loading.
[BOOTLIB]: Add mostly full support for resource and locale management.
[BOOTLIB]: Stub out bootstat.dat (Boot Status Data Log) support.
[BOOTLIB]: Some refactoring.
[BOOTMGFW]: Add a message table with a few initial strings. Also add an empty bootmgr.xsl stylesheet. We'll have to see what we want/need to do here.
[BOOTMGFW]: Correctly loading HTML and message table resource data, and add a few other additional initialization calls.
Next steps are to re-visit graphics code to support re-initialization.
svn path=/trunk/; revision=70504
Colin Finck [Wed, 6 Jan 2016 02:19:53 +0000 (02:19 +0000)]
I think almost 10 years of participation suffice to get into this file :)
svn path=/trunk/; revision=70501
Pierre Schweitzer [Tue, 5 Jan 2016 22:56:20 +0000 (22:56 +0000)]
[ROSVBOXMGMT]
Add a new feature to the tool:
Let it auto start VBox Shared folders and to browse all the available shares in order to create shell links on desktop.
The purpose is to workaround the missing network shares discovery feature in ReactOS while keeping the VBox shared folders usage 'user-friendly'.
It has been designed specifically for the coming 0.4.0 release: just put it on autostart for the default user. If there are shares (even new ones), it will create links, if there are no shares, no guest additions, no VBox, it will just exit.
See it in action: https://twitter.com/HeisSpiter/status/
684506579555741696
CORE-10032
ROSAPPS-303
svn path=/trunk/; revision=70500
Pierre Schweitzer [Tue, 5 Jan 2016 21:42:54 +0000 (21:42 +0000)]
[ROSVBOXMGMT]
When displaying active shares, also display their names
svn path=/trunk/; revision=70499
Hermès Bélusca-Maïto [Tue, 5 Jan 2016 19:53:07 +0000 (19:53 +0000)]
[NTOS:MM]: Don't hardcode Mm tags since we have a #define
svn path=/trunk/; revision=70498
Hermès Bélusca-Maïto [Tue, 5 Jan 2016 19:52:35 +0000 (19:52 +0000)]
[REACTOS]
Update the README files for 0.4.x releases.
svn path=/trunk/; revision=70497
Ged Murphy [Tue, 5 Jan 2016 18:58:32 +0000 (18:58 +0000)]
[NTOSKRNL]
- Use the LockQueueIoDatabaseLock spinlock to guard the device list instead of blindly raising the IRQL
- Add missing lock to IopEditDeviceList
svn path=/trunk/; revision=70496
Ged Murphy [Tue, 5 Jan 2016 18:43:26 +0000 (18:43 +0000)]
[FLTMGR]
- Fix a bug in FltpDetachFromFileSystemDevice so it correctly bails when we've walked the attached device list.
- FltpDispatch can come in at high IRQL. Thanks to Thomas for noticing that err.
- Add newlines to the end of DPRINTS (it's been a while...)
- The filter now loads and runs in the reactos FS stack.
svn path=/trunk/; revision=70495
Alex Ionescu [Tue, 5 Jan 2016 17:12:14 +0000 (17:12 +0000)]
[DDK]: Add IMAGE_RESOURCE_DIRECTORY_ENTRY to NTIMAGE.H. I shudder to think how our current code currently parses resource directories without this.
svn path=/trunk/; revision=70494
Ged Murphy [Tue, 5 Jan 2016 13:04:52 +0000 (13:04 +0000)]
[FLTMGR]
- Mark the Dispatch / FastIo functions as paged code
- Fix declarations and remove casts
svn path=/trunk/; revision=70493
Alex Ionescu [Tue, 5 Jan 2016 06:09:22 +0000 (06:09 +0000)]
[BOOTLIB]: Separate out bcd.c into bcdopt.c, bootreg.c and bcd.c
[BOOTLIB]: Implement routines to enumerate subkeys and to read a key value.
[BOOTLIB]: Implement routines to parse, enumerate, and convert registry data into BCD elements, and to convert BCD elements into boot library BCD options.
[BOOTLIB/BOOTMGFW]: Lots of cleanups, mainly around the fact we now use ntintsafe.h instead of the manually self-inlined code from before, and from documenting additional flag values, and from using our newfound BCD powers.
[BOOTMGFW]: Implement BmGetOptionList, BmpUpdateApplicationOptions.
[BOOTMGFW]: Prepare for post-BCD library reinitialization. We correctly read the 3 BCD options so far in the hive.
svn path=/trunk/; revision=70492
Alex Ionescu [Tue, 5 Jan 2016 05:12:01 +0000 (05:12 +0000)]
[BOOTMGFW]: Implement the rtlcompat functions, so that Rtl string functions will actually work.
[HIVEBCD]: Start filling out a minimalistic BCD Hive layout to try out the BCD parsing/conversion code in my WC.
svn path=/trunk/; revision=70491
Alex Ionescu [Tue, 5 Jan 2016 01:55:40 +0000 (01:55 +0000)]
[CMLIB]: Attempt fix for Linux hosts.
svn path=/trunk/; revision=70490
Alex Ionescu [Tue, 5 Jan 2016 01:51:54 +0000 (01:51 +0000)]
[CMLIB]: Move Value functions to CMLIB as well, so that they can be shared with the new boot code.
svn path=/trunk/; revision=70489
Ged Murphy [Mon, 4 Jan 2016 12:50:06 +0000 (12:50 +0000)]
[FLTMGR]
- Plug in the dispatch routines. These are just pass through methods for now to get the filter up and running.
- Implement the FastIo handlers. The majority of these call the FastIo routines of the attached device object.
- Make sure we detach from devices that are being deleted in FastIoDetachDevice.
- Move the FastIoDetachDevice routine to a deferred call as it's too expensive to tie up a FastIo request.
svn path=/trunk/; revision=70488
Timo Kreuzer [Sun, 3 Jan 2016 19:58:33 +0000 (19:58 +0000)]
[WIN32K]
This ASSERT was actually supposed to be removed and only accidentally brought back.
svn path=/trunk/; revision=70487
Timo Kreuzer [Sun, 3 Jan 2016 19:46:57 +0000 (19:46 +0000)]
[WIN32K]
Fix the fix from r70482: Our DIBs are actually 32 bit aligned, so pass even uncompressed bits to GreCreateBitmapEx instead of copying them later with wrong alignment.
svn path=/trunk/; revision=70486
Timo Kreuzer [Sun, 3 Jan 2016 18:10:31 +0000 (18:10 +0000)]
[WIN32K]
Disable broken code to update a device palette. Should fix testbot crashes.
svn path=/trunk/; revision=70485
Amine Khaldi [Sun, 3 Jan 2016 16:27:06 +0000 (16:27 +0000)]
[NTDLL] Fix a typo.
svn path=/trunk/; revision=70484
Alex Ionescu [Sun, 3 Jan 2016 16:23:38 +0000 (16:23 +0000)]
[NDK]: Document RtlPushFrame, RtlPopFrame, RtlGetFrame.
[NDK]: Add TEB_ACTIVE_FRAME_CONTEXT_FLAG_EXTENDED, TEB_ACTIVE_FRAME_EX, TEB_ACTIVE_FRAME_CONTEXT_EX from the CoreCLR sources (clrnt.h)
[RTL]: Implement RtlPushFrame, RtlPopFrame, RtlGetFrame.
[NTDLL]: Export the above.
[RTL]: Fix MSVC warning after someone's earlier WINE merge.
svn path=/trunk/; revision=70483
Timo Kreuzer [Sun, 3 Jan 2016 16:16:04 +0000 (16:16 +0000)]
[WIN32K]
NtGdiCreateDIBitmapInternal: clear CBM_INIT flag, if no bits are given.
IntSetDIBits: Always calculate the bitmap size for uncompressed bitmaps, do not pass uncompressed bits to GreCreateBitmapEx, since they don't have the required alignment (the width in bytes for DIB is 16 bit aligned, bitmaps 32).
Remove a broken ASSERT.
svn path=/trunk/; revision=70482
Eric Kohl [Sun, 3 Jan 2016 15:40:57 +0000 (15:40 +0000)]
Improve English strings in ReactOS.
Patch by Henry Tang Ih.
CORE-10729 #resolve #comment Committed in r70480. Thanks a lot!
svn path=/trunk/; revision=70480
Eric Kohl [Sun, 3 Jan 2016 09:22:14 +0000 (09:22 +0000)]
[LSASRV]
Implement LsarStorePrivateData and LsarRetrievePrivateData.
[ADVAPI32]
Implement LsaRetrievePrivateData and LsaStorePrivateData.
Encryption of secrets (aka private data) is NOT implemented yet!
svn path=/trunk/; revision=70479
Eric Kohl [Fri, 1 Jan 2016 14:16:04 +0000 (14:16 +0000)]
[ADVAPI32]
CreateProcessAsUserA/W: Make hToken optional.
svn path=/trunk/; revision=70478
Hermès Bélusca-Maïto [Thu, 31 Dec 2015 23:05:23 +0000 (23:05 +0000)]
Happy New Year 2016 !!
☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰
░░░░░░█░█ █▀█ █▀█ █▀█ █░█░░░░░░
░░░░░░█▀█ █▀█ █▀▀ █▀▀ ▀█▀░░░░░░
░░░░░░▀░▀ ▀░▀ ▀░░ ▀░░ ░▀░░░░░░░
█▄░█ █▀▀ █░█░█░░█░█ █▀▀ █▀█ █▀█
█░██ █▀▀ █░█░█░░▀█▀ █▀▀ █▀█ ██▀
▀░░▀ ▀▀▀ ░▀▀▀░░░░▀░ ▀▀▀ ▀░▀ ▀░▀
⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰
░░░▄████▄░▄███▄░░▄██░▄████▄░░░
░░░▀▀░▄██░██░██░████░██▄▄▄░░░░
░░░░▄██▀░░██░██░░░██░██░░██░░░
░░░██████░▀███▀░░░██░▀████▀░░░
☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
svn path=/trunk/; revision=70477
Eric Kohl [Thu, 31 Dec 2015 22:42:20 +0000 (22:42 +0000)]
[INCLUDE]
Fix a typo! :-/
svn path=/trunk/; revision=70476
Eric Kohl [Thu, 31 Dec 2015 22:39:12 +0000 (22:39 +0000)]
[INCLUDE]
Does this fix MSVC builds?
svn path=/trunk/; revision=70475
Eric Kohl [Thu, 31 Dec 2015 22:17:45 +0000 (22:17 +0000)]
[SYSETUP]
- Implement pSetupDebugPrint and modify the LogItem macro accordingly.
- Add some log messages to the setup wizard.
svn path=/trunk/; revision=70474
Eric Kohl [Thu, 31 Dec 2015 16:39:01 +0000 (16:39 +0000)]
[SYSSETUP]
Remove the NtUnloadKey hack.
svn path=/trunk/; revision=70473
Thomas Faber [Thu, 31 Dec 2015 14:25:35 +0000 (14:25 +0000)]
[ACPICA]
- Update to version
20151218
CORE-10765
svn path=/trunk/; revision=70472
Eric Kohl [Thu, 31 Dec 2015 12:58:18 +0000 (12:58 +0000)]
[SOLITAIRE]
solitaire: no action upon doubleclick
Patch by Carlo Bramini.
CORE-6514 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70470
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 20:23:18 +0000 (20:23 +0000)]
[USETUP]: Correctly check for existing "ReactOS" entries in FreeLdr in case ReactOS is reinstalled over an existing installation, and if no one does exist, then create a new one that actually works. Thanks tower for having reported the problem 8^)
svn path=/trunk/; revision=70469
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 18:52:07 +0000 (18:52 +0000)]
[USETUP]: Formatting fix & remove a redundant function.
svn path=/trunk/; revision=70468
Hermès Bélusca-Maïto [Wed, 30 Dec 2015 18:26:42 +0000 (18:26 +0000)]
[USETUP]
Factorize the code that creates ReactOS freeldr.ini entries, and use it to create a freeldr.ini at a clean ReactOS installation, and when it is installed in the same partition as Win9x/DOS.
CORE-4870 #comment Should be fixed with revision 70467, please retest.
svn path=/trunk/; revision=70467
Timo Kreuzer [Tue, 29 Dec 2015 20:28:23 +0000 (20:28 +0000)]
[WIN32K]
Properly check the bitmap size in IntSetDIBits, taking into account that it might be set to 0, then we have to calculate it ourselves. Fixes a crash when invalid data is passed to NtGdiCreateDIBitmapInternal.
[GDI32]
Convert COREINFOHEADER to BITMAPINFOHEADER before passing it to NtGdiCreateDIBitmapInternal, which doesn't support it.
CORE-10583 #resolve
svn path=/trunk/; revision=70464
Timo Kreuzer [Mon, 28 Dec 2015 23:51:05 +0000 (23:51 +0000)]
[WIN32KDLL_2K3SP2]
Export NtUserGetClassInfoEx (as it's called in 2k3) both as NtUserGetClassInfo (as it's called on XP) and NtUserGetClassInfo. They have the same prototype.
svn path=/trunk/; revision=70463
Timo Kreuzer [Mon, 28 Dec 2015 23:03:04 +0000 (23:03 +0000)]
[WIN32KDLL_2K3SP2]
- "Fix" an export name: NtUserGetClassInfoEx on 2k3 is the same as NtUserGetClassInfo on XP (note that we currently use the default, aka ros specific, win32kdll on the WHS testbot, but it's mostly identical.
[WIN32KNT_APITEST]
- Fix a typo
- add missing tests to testlist.c
svn path=/trunk/; revision=70462
Timo Kreuzer [Mon, 28 Dec 2015 20:53:34 +0000 (20:53 +0000)]
[GDITOOLS]
3rd try to fix WHS rostests build
svn path=/trunk/; revision=70461
Timo Kreuzer [Mon, 28 Dec 2015 20:51:28 +0000 (20:51 +0000)]
[WIN32NT_APITEST]
2nd try to fix WHS rostests build
svn path=/trunk/; revision=70460
Timo Kreuzer [Mon, 28 Dec 2015 20:46:05 +0000 (20:46 +0000)]
[WIN32NT_APITEST]
Try to fix WHS rostests build
svn path=/trunk/; revision=70459
Timo Kreuzer [Mon, 28 Dec 2015 20:31:10 +0000 (20:31 +0000)]
[APOTESTS]
- Convert win32k native api test to actual wine style api-tests
- Hack around a bit with the win32k dlls, some renaming, etc.
- Delete old apitest stuff
svn path=/trunk/; revision=70458
Timo Kreuzer [Mon, 28 Dec 2015 20:24:57 +0000 (20:24 +0000)]
[GDITOOLS]
Add a library with some helper routines for GDI tests
svn path=/trunk/; revision=70457
Timo Kreuzer [Mon, 28 Dec 2015 15:49:29 +0000 (15:49 +0000)]
[CRT_APITEST]
Fix sprintf tests to succeed on W2K3
svn path=/trunk/; revision=70456
Timo Kreuzer [Mon, 28 Dec 2015 15:24:47 +0000 (15:24 +0000)]
[CRT_APITEST]
Add tests for _snprintf, _snwprintf, strtoul, wcstoul
Patch by Thomas Faber (slightly modified by me)
CORE-6510
svn path=/trunk/; revision=70455
Timo Kreuzer [Mon, 28 Dec 2015 14:42:41 +0000 (14:42 +0000)]
[SPEC2DEF]
Don't use DATA and PRIVATE together. DATA means no stub function is generated in the import lib, PRIVATE means nothing is generated in the export lib.
svn path=/trunk/; revision=70454
Timo Kreuzer [Mon, 28 Dec 2015 11:01:03 +0000 (11:01 +0000)]
[CRT_APITEST]
- Disable a check for crtdll
- Fix an MSVC warning
svn path=/trunk/; revision=70453
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 22:41:48 +0000 (22:41 +0000)]
[BOOTDATA]: ReactOS can install and run fine on volumes of at least 450 MB (for example, on a volume of 450 MB and after creation of the pagefile, it leaves you 60+ MB of free space, which should be enough for you if you're already happy using HDDs of such small sizes ^^).
svn path=/trunk/; revision=70451
Timo Kreuzer [Sun, 27 Dec 2015 20:24:04 +0000 (20:24 +0000)]
[CRT]
Fix a typo in a comment and make it clearer, what we do here.
CORE-10754 #resolve
svn path=/trunk/; revision=70450
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 20:01:24 +0000 (20:01 +0000)]
[VFATLIB]
Now, the fix: the FAT disk checker expected that the free cluster count member of the FAT32 FSInfo sector be really initialized (not to 0xFFFFFFFF), and it expected the presence of the backup of the FSInfo sector as well as the free sector following the FSInfo sector.
svn path=/trunk/; revision=70449
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:57:10 +0000 (19:57 +0000)]
Remove a forgotten DPRINT1.
svn path=/trunk/; revision=70448
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:55:47 +0000 (19:55 +0000)]
[VFATLIB]
- DPRINT messages printed via VfatPrint by the check-disk procedure.
- Addendum to r70434 and r70435 : The return value of fs_close is equal to the number of corrections made on the disk (0 corrections --> success; 1+ --> something was corrected).
That way, the old code "return fs_close(FixErrors) ? STATUS_SUCCESS : STATUS_UNSUCCESSFUL;" that we had since eons (which always happened to return STATUS_SUCCESS) was actually
indicating to us that our FAT32-formatted volumes were corrupted.
If you test this revision, you should see something happening if you try to install ReactOS now (something that should have happened since ages actually).
svn path=/trunk/; revision=70447
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:38:13 +0000 (19:38 +0000)]
[VFATLIB]
- Formatting + RtlZero/FillMemory modifications as addendum to r70445.
- Do not hardcode FSInfo signature values, use instead the same set of macros fastfat_new introduces.
svn path=/trunk/; revision=70446
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:30:53 +0000 (19:30 +0000)]
[VFATLIB]
- Formatting fixes.
- Use RtlZeroMemory/RtlFillMemory instead of memset.
svn path=/trunk/; revision=70445
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 19:06:16 +0000 (19:06 +0000)]
[TASKMGR]: Use taskmgr's icon for its run file dialog. Inspired by Wine.
svn path=/trunk/; revision=70444
Timo Kreuzer [Sun, 27 Dec 2015 18:22:13 +0000 (18:22 +0000)]
[CRT]
Fix handling of NULL buffer in streamout. Fixes a few msvcrt_crt_apitests, while it breaks a few for crtdll. crtdll is broken anyway and obsolete, nothing uses it, so it doesn't really matter.
CORE-9105 #resolve
svn path=/trunk/; revision=70443
Timo Kreuzer [Sun, 27 Dec 2015 17:55:14 +0000 (17:55 +0000)]
[SETUPAPI]
Fix invalid use of wcslen with NULL pointer. Should fix crash in setupapi_winetest:install.
svn path=/trunk/; revision=70441
Eric Kohl [Sun, 27 Dec 2015 16:36:32 +0000 (16:36 +0000)]
[MSGINA]
Improve msgina's text in ReactOS.
Patch by Henry Tang Ih.
CORE-10720 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=70437
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 15:22:39 +0000 (15:22 +0000)]
[USETUP]: Fix some localization problems.
svn path=/trunk/; revision=70436
Hermès Bélusca-Maïto [Sun, 27 Dec 2015 02:04:09 +0000 (02:04 +0000)]
Fix build.
svn path=/trunk/; revision=70435