reactos.git
15 months ago[SHELL32] Fix some elements positions and styles
Stanislav Motylkov [Fri, 29 Jun 2018 15:01:03 +0000 (18:01 +0300)]
[SHELL32] Fix some elements positions and styles

Addendum to eb1912b. CORE-11407

15 months ago[NOTEPAD] Globals.encFile: explicitly cast to ENCODING
Serge Gautherie [Fri, 29 Jun 2018 21:44:39 +0000 (23:44 +0200)]
[NOTEPAD] Globals.encFile: explicitly cast to ENCODING

15 months ago[DEVENUM] Initialize rgpins.
Mark Jansen [Fri, 29 Jun 2018 20:28:57 +0000 (22:28 +0200)]
[DEVENUM] Initialize rgpins.

15 months ago[FREETYPE] Allow a NULL style_name.
Mark Jansen [Fri, 29 Jun 2018 19:55:54 +0000 (21:55 +0200)]
[FREETYPE] Allow a NULL style_name.
CORE-14775

15 months ago[NOTEPAD] Avoid a cast.
Thomas Faber [Fri, 29 Jun 2018 12:59:16 +0000 (14:59 +0200)]
[NOTEPAD] Avoid a cast.

15 months ago[NOTEPAD] Fix a MSVC warning about Globals.encFile (#648)
Serge Gautherie [Fri, 29 Jun 2018 12:17:29 +0000 (14:17 +0200)]
[NOTEPAD] Fix a MSVC warning about Globals.encFile (#648)

"...\dialog.c(365) : error C4133: 'function' : incompatible types - from 'ENCODING *' to 'int *'"
CORE-7538

15 months ago[SHELL32] Refresh 'General' tab if the folder icon is updated (#646)
Katayama Hirofumi MZ [Fri, 29 Jun 2018 12:13:37 +0000 (21:13 +0900)]
[SHELL32] Refresh 'General' tab if the folder icon is updated (#646)

CORE-11407

15 months ago[SERVICES] Minor additions.
Hermès Bélusca-Maïto [Thu, 28 Jun 2018 20:32:28 +0000 (22:32 +0200)]
[SERVICES] Minor additions.

- Remove a redundant ScmWaitForLsa() call.
- Remove the LSA_RPC_SERVER_ACTIVE macro (just use directly the string).
- Improve output of DPRINTs.

15 months ago[SERVICES] Remove the "Special service accounts initialization" hack, and enable...
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 23:36:22 +0000 (01:36 +0200)]
[SERVICES] Remove the "Special service accounts initialization" hack, and enable per-service account logging.

This effectively removes the temporary hacks introduced in r73486 (a35a785b)
and in r73487 (0ce031f7) for the LocalService and NetworkService accounts.

Now these accounts (and their corresponding user profiles) are created
on the fly, the first time a service that needs these is started.
The code introduced in r73501 (ade0d2cd) is now re-enabled: this has
been made possible thanks to commit f42b4bbe (thanks Eric!).

Dedicated to Joachim Henze ;-)

CORE-12541, CORE-12279

15 months ago[FONT][FREETYPE] Refactor global variable names and locking (#591)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 20:00:55 +0000 (05:00 +0900)]
[FONT][FREETYPE] Refactor global variable names and locking (#591)

Refactor the font engine code in "win32ss/gdi/ntgdi/freetype.c".
- Add "g_" prefix to global variables.
- Make the locking macros function-like.
CORE-13065

15 months ago[SHELL32] Initial implementation of Folder Customization (#642)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 19:51:37 +0000 (04:51 +0900)]
[SHELL32] Initial implementation of Folder Customization (#642)

- Add property sheet;
- Implement changing the folder icon.
CORE-11407

15 months ago[WIN32SS] Fix IntSynthesizeDib to synthesize CF_DIB with CF_BITMAP (#644)
Katayama Hirofumi MZ [Thu, 28 Jun 2018 17:27:40 +0000 (02:27 +0900)]
[WIN32SS] Fix IntSynthesizeDib to synthesize CF_DIB with CF_BITMAP (#644)

CORE-14770

15 months ago[DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)
Serge Gautherie [Thu, 28 Jun 2018 15:44:49 +0000 (17:44 +0200)]
[DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)

- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538

15 months ago[NTOS:SE] Overhaul the token management code.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:50:53 +0000 (22:50 +0200)]
[NTOS:SE] Overhaul the token management code.

- Overhaul SepCreateToken() and SepDuplicateToken() so that they
  implement the "variable information area" of the token, where
  immutable lists of user & groups and privileges reside, and the
  "dynamic information area" (allocated separately in paged pool),
  where mutable data such as the token's default DACL is stored.
  Perform the necessary adaptations in SepDeleteToken() and in
  NtSetInformationToken().

- Actually dereference the token's logon session, when needed, in the
  'TokenSessionReference' case in NtSetInformationToken().

- Overhaul SepFindPrimaryGroupAndDefaultOwner() so that it returns
  the indices of candidate primary group and default owner within the
  token's user & groups array. This allows for fixing the 'TokenOwner'
  and 'TokenPrimaryGroup' cases of NtSetInformationToken(), since the
  owner or primary group being set *MUST* already exist in the token's
  user & groups array (as a by-product, memory corruptions that existed
  before due to the broken way of setting these properties disappear too).

- Lock tokens every time operations are performed on them (NOTE: we
  still use a global token lock!).

- Touch the ModifiedId LUID member of tokens everytime a write operation
  (property change, etc...) is made on them.

- Fix some group attributes in the SYSTEM process token, SepCreateSystemProcessToken().

- Make the SeCreateTokenPrivilege mandatory when calling NtCreateToken().

- Update the token pool tags.

- Explicitly use the Ex*ResourceLite() versions of the locking functions
  in the token locking macros.

15 months ago[NDK] Update NtCreateToken() prototype annotations.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:49:34 +0000 (22:49 +0200)]
[NDK] Update NtCreateToken() prototype annotations.

15 months ago[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to...
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:30:09 +0000 (22:30 +0200)]
[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to create access tokens -- NtCreateToken() requires this privilege.

15 months ago[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStar...
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:19:40 +0000 (22:19 +0200)]
[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStartRpcServer().

15 months ago[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner.
Hermès Bélusca-Maïto [Tue, 26 Jun 2018 20:14:03 +0000 (22:14 +0200)]
[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner.

15 months ago[NTOS:SE] Add a documentation note about SeTokenIsWriteRestricted() and SeTokenIsAdmi...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 16:49:07 +0000 (18:49 +0200)]
[NTOS:SE] Add a documentation note about SeTokenIsWriteRestricted() and SeTokenIsAdmin(), and update the one for NtDuplicateToken().
[XDK] Move TOKEN_HAS_ADMIN_GROUP where appropriate.

15 months ago[NTOS:SE] Minor style changes.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 14:03:40 +0000 (16:03 +0200)]
[NTOS:SE] Minor style changes.

- Use TRUE/FALSE instead of 1/0 for booleans.
- Use NULL instead of 0 for null pointers.
- Print 0x prefix for hex values in DPRINTs.
- Use new annotations for SepCreateToken() and SepDuplicateToken().

15 months ago[NTOS:SE] In SepCreateClientSecurity(), fix the impersonation level value passed...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:32:06 +0000 (15:32 +0200)]
[NTOS:SE] In SepCreateClientSecurity(), fix the impersonation level value passed to the SeCopyClientToken() call.

Caught while debugging, in the case the ImpersonationLevel value was
uninitialized, due to the fact it was left untouched on purpose by
PsReferenceEffectiveToken().

15 months ago[FORMATTING] No code change; typo fix.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:31:15 +0000 (15:31 +0200)]
[FORMATTING] No code change; typo fix.

15 months ago[NTOS:SE] Finish SepCreateImpersonationTokenDacl() implementation.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:24:44 +0000 (15:24 +0200)]
[NTOS:SE] Finish SepCreateImpersonationTokenDacl() implementation.

- Re-enable a commented-out block;
- Return the allocated Dacl.
- Use the correct pool tag when freeing the allocated Dacl.

15 months ago[NTOS:PS] Adjust the PsReferenceEffectiveToken() prototype in the header; add a comme...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:21:33 +0000 (15:21 +0200)]
[NTOS:PS] Adjust the PsReferenceEffectiveToken() prototype in the header; add a comment about the fact that the ImpersonationLevel parameter can be left untouched on purpose in one special case.

15 months ago[PSDK] ntsecpkg.h: fix minor typos (make some structure names MS-PSDK-compatible...
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 12:55:46 +0000 (14:55 +0200)]
[PSDK] ntsecpkg.h: fix minor typos (make some structure names MS-PSDK-compatible), and add LSA_TOKEN_INFORMATION_V2.

15 months ago[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status...
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:30:10 +0000 (03:30 +0200)]
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop.

This avoids this function returning failure while everything actually succeeded.

15 months ago[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid point...
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:25:21 +0000 (03:25 +0200)]
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer.

15 months ago[ADVAPI32] Additions for CreateProcessAsUserA/W().
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 22:17:05 +0000 (00:17 +0200)]
[ADVAPI32] Additions for CreateProcessAsUserA/W().

- Use a common helper function used by both the ANSI and UNICODE functions
  so that the large code block that deals with setting the new process token
  becomes automatically common to both these functions, while the ANSI vs.
  UNICODE conversions are handled directly via the CreateProcessA/W() calls.

- Duplicate the token and acquire the process primary token assignment
  privilege before calling NtSetInformationProcess().

15 months ago[SHELL32] Add missing desktop.ini files (#640)
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:11:31 +0000 (06:11 +0900)]
[SHELL32] Add missing desktop.ini files (#640)

Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045

15 months ago[TRANSLATION][AT] Implement the Italian resource file (#641)
Bișoc George [Wed, 27 Jun 2018 21:09:56 +0000 (23:09 +0200)]
[TRANSLATION][AT] Implement the Italian resource file (#641)

15 months ago[SHELL32] Enable custom CD/DVD icons (#639)
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:06:54 +0000 (06:06 +0900)]
[SHELL32] Enable custom CD/DVD icons (#639)

Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766

15 months ago[AUTOCHK] Improve autochk messages
David Knapp [Tue, 26 Jun 2018 07:13:49 +0000 (09:13 +0200)]
[AUTOCHK] Improve autochk messages

15 months ago[NEWDEV] Fix a truncated text
Bișoc George [Mon, 25 Jun 2018 08:35:14 +0000 (10:35 +0200)]
[NEWDEV] Fix a truncated text

15 months ago[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInform...
Russell Johnson [Sun, 24 Jun 2018 18:29:57 +0000 (11:29 -0700)]
[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635)

Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340

15 months ago[SHELL32] Implement Folder Options File Types 'Change' button (#629)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:04:25 +0000 (03:04 +0900)]
[SHELL32] Implement Folder Options File Types 'Change' button (#629)

CORE-12906

15 months ago[BROWSEUI] Re-enable the "Folder Options" menu item (#630)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:02:36 +0000 (03:02 +0900)]
[BROWSEUI] Re-enable the "Folder Options" menu item (#630)

It was originally disabled in r71192 (8b77c254).
CORE-11141

15 months ago[SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:59:03 +0000 (02:59 +0900)]
[SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)

#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196

15 months ago[TRANSLATION][WHOAMI] Add Italian resource (#626)
Bișoc George [Sun, 24 Jun 2018 17:49:47 +0000 (19:49 +0200)]
[TRANSLATION][WHOAMI] Add Italian resource (#626)

Note: Supersedes PR #627

15 months ago[SHELL32] Implement OpenAs_RunDLLA/W (#628)
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:46:06 +0000 (02:46 +0900)]
[SHELL32] Implement OpenAs_RunDLLA/W (#628)

CORE-14751

15 months ago[TRANSLATION][SHELL32] Update Russian translation (#633)
Abdulganiev Rafael [Sun, 24 Jun 2018 17:42:34 +0000 (21:42 +0400)]
[TRANSLATION][SHELL32] Update Russian translation (#633)

15 months agoAdd a document on the rules we should follow while managing/reviewing PRs, 585/head
David Quintana [Thu, 31 May 2018 21:50:49 +0000 (23:50 +0200)]
Add a document on the rules we should follow while managing/reviewing PRs,
and link to it from CONTRIBUTING.md and CODE_OF_CONDUCT.md

15 months ago[CMAKE] Add support for VS 15.7.1 / CL 19.14.x
Timo Kreuzer [Tue, 15 May 2018 11:08:49 +0000 (13:08 +0200)]
[CMAKE] Add support for VS 15.7.1 / CL 19.14.x

16 months ago[SHELL32] Improve French Folder Options
Katayama Hirofumi MZ [Sat, 23 Jun 2018 02:00:11 +0000 (11:00 +0900)]
[SHELL32] Improve French Folder Options

16 months ago[REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)
Getequ [Fri, 22 Jun 2018 18:15:12 +0000 (01:15 +0700)]
[REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)

This bug was found when I tried to import *.reg with huge HEX value (about 500 and much more lines of hex text).

16 months ago[SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:44:58 +0000 (23:44 +0900)]
[SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)

ROSTESTS-308

16 months ago[SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:40:06 +0000 (23:40 +0900)]
[SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)

CORE-14678

16 months ago[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the...
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 14:34:16 +0000 (16:34 +0200)]
[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the auto-start programs, by using the existing code.

16 months ago[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:02:25 +0000 (23:02 +0900)]
[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)

- Remove code for Start-Menu auto-startup items from userinit and put it where it belongs: in explorer.

CORE-10839

16 months ago[SHELL32] Fix desktop.ini folder icon (#595)
Katayama Hirofumi MZ [Fri, 22 Jun 2018 13:37:03 +0000 (22:37 +0900)]
[SHELL32] Fix desktop.ini folder icon (#595)

The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196

16 months ago[EXPLORER] 'Run' (Win+R) should set the proper current directory (#593)
Katayama Hirofumi MZ [Thu, 21 Jun 2018 16:18:57 +0000 (01:18 +0900)]
[EXPLORER] 'Run' (Win+R) should set the proper current directory (#593)

16 months ago[WELCOME] Add Hindi translation (#620)
Arnav Bhatt [Thu, 21 Jun 2018 12:07:03 +0000 (17:37 +0530)]
[WELCOME] Add Hindi translation (#620)

16 months ago[LOG2LINES] translate_line(): Let 'offset' be an 'unsigned int', instead of a 'size_t...
Serge Gautherie [Thu, 21 Jun 2018 12:05:35 +0000 (14:05 +0200)]
[LOG2LINES] translate_line(): Let 'offset' be an 'unsigned int', instead of a 'size_t' (#624)

Avoids half-uninitialized value on, i.e., Linux 64-bit (with ReactOS 32-bit).
CORE-14737

16 months ago[TRANSLATION] Improving italian translation (#623)
Andrea Crescentini [Thu, 21 Jun 2018 12:03:35 +0000 (14:03 +0200)]
[TRANSLATION] Improving italian translation (#623)

- Improved Italian translation for USETUP, WELCOME, REACTOS, EXPLORER.
- Completed translation in SYSSETUP.
- Correct some characters encoding and text alignment in USETUP.

16 months ago[NETAPI32_APITEST] Fix a NULL dereference of pInfo
Serge Gautherie [Fri, 8 Jun 2018 14:24:05 +0000 (16:24 +0200)]
[NETAPI32_APITEST] Fix a NULL dereference of pInfo

With DPH enabled,
{{
Unhandled exception
ExceptionCode:    c0000005
Faulting Address:        0
...
modules/rostests/apitests/netapi32/DsRoleGetPrimaryDomainInformation.c:23 (func_DsRoleGetPrimaryDomainInformation)
...
}}

16 months ago[USETUP] Some changes to address the recent review
Bișoc George [Thu, 14 Jun 2018 08:05:36 +0000 (10:05 +0200)]
[USETUP] Some changes to address the recent review

16 months ago[USETUP] Italian translation update
Bișoc George [Wed, 13 Jun 2018 13:56:05 +0000 (15:56 +0200)]
[USETUP] Italian translation update

16 months agoSet minimum required version to 3.2.1 and set appropriate policies. 556/head
Thomas Faber [Fri, 30 Mar 2018 11:33:53 +0000 (13:33 +0200)]
Set minimum required version to 3.2.1 and set appropriate policies.
#556

16 months ago[APITESTS] Add ShellStateTest 588/head
Katayama Hirofumi MZ [Sat, 2 Jun 2018 02:05:52 +0000 (11:05 +0900)]
[APITESTS] Add ShellStateTest

16 months ago[SHELL32][APITESTS] Add tests of OpenAs_RunDLL 605/head
Katayama Hirofumi MZ [Thu, 7 Jun 2018 06:48:42 +0000 (15:48 +0900)]
[SHELL32][APITESTS] Add tests of OpenAs_RunDLL

16 months ago[DELAYIMP] Fix/Merge definitions of __pfnDliNotifyHook2 and __pfnDliFailureHook2
Serge Gautherie [Sun, 11 Feb 2018 22:37:34 +0000 (23:37 +0100)]
[DELAYIMP] Fix/Merge definitions of __pfnDliNotifyHook2 and __pfnDliFailureHook2

16 months ago[DELAYIMP] Fix 2 Clang-Cl warnings about __pfnDliNotifyHook2Default and __pfnDliFailu...
Serge Gautherie [Sun, 11 Feb 2018 22:33:16 +0000 (23:33 +0100)]
[DELAYIMP] Fix 2 Clang-Cl warnings about __pfnDliNotifyHook2Default and __pfnDliFailureHook2Default

"warning: 'extern' variable has an initializer [-Wextern-initializer]"

CORE-14306

16 months ago[SHELL32] Copy-paste files/folders into current place.
Denis Malikov [Tue, 5 Jun 2018 17:13:51 +0000 (00:13 +0700)]
[SHELL32] Copy-paste files/folders into current place.

Files are copied with trying to find new path by adding (%d) suffix before asking for overwrite existing item

CORE-13788

16 months ago[HALX86] Fix a Clang-Cl warning about KiUnexpectedInterrupt 551/head
Serge Gautherie [Fri, 18 May 2018 04:51:00 +0000 (06:51 +0200)]
[HALX86] Fix a Clang-Cl warning about KiUnexpectedInterrupt

"warning: cast between incompatible calling conventions 'cdecl' and 'fastcall'; calls through this pointer may abort at runtime [-Wcast-calling-convention]"

CORE-14306

16 months ago[SYSSETUP] Fix a DPH report about dwPageCount 606/head
Serge Gautherie [Fri, 8 Jun 2018 04:31:26 +0000 (06:31 +0200)]
[SYSSETUP] Fix a DPH report about dwPageCount

- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
  detected at
  "dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.

16 months ago[MODULES] Update README file, with instructions about how to include rostests and...
Yaroslav Veremenko [Tue, 12 Jun 2018 21:38:05 +0000 (15:38 -0600)]
[MODULES] Update README file, with instructions about how to include rostests and rosapps (#613)

16 months ago[TRANSLATION] Polish translation update (#611)
Adam Słaboń [Tue, 12 Jun 2018 13:51:37 +0000 (15:51 +0200)]
[TRANSLATION] Polish translation update (#611)

Polish translation update for MODE, USETUP and SHELL32.

16 months ago[USETUP] Display the ReactOS release status (#608)
Bișoc George [Mon, 11 Jun 2018 20:53:57 +0000 (22:53 +0200)]
[USETUP] Display the ReactOS release status (#608)

Update the introduction page with a more up-to-date exposition of the current status of ReactOS.

16 months ago[TRANSLATION][NOTEPAD] Update Turkish translation (#609)
Erdem Ersoy [Mon, 11 Jun 2018 12:56:59 +0000 (12:56 +0000)]
[TRANSLATION][NOTEPAD] Update Turkish translation (#609)

16 months ago[ADVAPI32] Fix crash when running advapi32:security with DPH.
Thomas Faber [Sun, 10 Jun 2018 13:45:57 +0000 (15:45 +0200)]
[ADVAPI32] Fix crash when running advapi32:security with DPH.

Import the following Wine commits:
79636bebbfa Michael Müller: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
1d03ba76116 Hans Leidekker: advapi32: Fix parsing empty DACL/SACL security descriptor strings.
5bc2e83c7ab Hans Leidekker: advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.

16 months ago[AFD] Respect the maximum receive buffer size for datagram sockets. CORE-14048 181/head
Thomas Faber [Mon, 4 Dec 2017 20:13:43 +0000 (21:13 +0100)]
[AFD] Respect the maximum receive buffer size for datagram sockets. CORE-14048

16 months ago[CONSRV] Don't show the newly-created console if the window station, on which the...
Hermès Bélusca-Maïto [Sun, 10 Jun 2018 01:59:22 +0000 (03:59 +0200)]
[CONSRV] Don't show the newly-created console if the window station, on which the console is created, is not interactive.

16 months ago[CONSRV] Use a similar parameter name as in other functions.
Hermès Bélusca-Maïto [Sun, 10 Jun 2018 01:23:01 +0000 (03:23 +0200)]
[CONSRV] Use a similar parameter name as in other functions.

16 months ago[WIN32K] Fix DBG_PRINT macro.
Hermès Bélusca-Maïto [Sat, 9 Jun 2018 22:48:45 +0000 (00:48 +0200)]
[WIN32K] Fix DBG_PRINT macro.

16 months ago[FASTFAT] Don't add an extra \, when renaming a file at root.
Pierre Schweitzer [Sat, 9 Jun 2018 20:17:17 +0000 (22:17 +0200)]
[FASTFAT] Don't add an extra \, when renaming a file at root.

This fixes failures to rename a file where destination is
the root of a FAT volume.

CORE-10503

16 months ago[FASTFAT] Use the FastFAT mechanism for counting clusters already implemented
Pierre Schweitzer [Sat, 9 Jun 2018 16:21:32 +0000 (18:21 +0200)]
[FASTFAT] Use the FastFAT mechanism for counting clusters already implemented

This allows us having more accurate statistics regarding available clusters
count. Even though FastFAT and chkdsk still don't agree!

CORE-3877

16 months ago[RAPPS] Fix command line handling 601/head
Mark Jansen [Tue, 5 Jun 2018 20:08:18 +0000 (22:08 +0200)]
[RAPPS] Fix command line handling

16 months ago[ATL] Add CString.CompareNoCase
Mark Jansen [Tue, 5 Jun 2018 22:21:06 +0000 (00:21 +0200)]
[ATL] Add CString.CompareNoCase

16 months ago[RAPPS] Select the search bar with ctrl+f
Mark Jansen [Tue, 5 Jun 2018 20:07:39 +0000 (22:07 +0200)]
[RAPPS] Select the search bar with ctrl+f

16 months ago[USERSRV] HardError: Free WindowTitleU buffer only if we really allocated it.
Hermès Bélusca-Maïto [Sat, 9 Jun 2018 13:37:54 +0000 (15:37 +0200)]
[USERSRV] HardError: Free WindowTitleU buffer only if we really allocated it.

16 months ago[FASTFAT] Start implementing FAT32 statistics support
Pierre Schweitzer [Sat, 9 Jun 2018 10:36:43 +0000 (12:36 +0200)]
[FASTFAT] Start implementing FAT32 statistics support

Not fully perfect yet, chkdsk still complains.

CORE-3877

16 months ago[FASTFAT] Save the FSINFO sector location
Pierre Schweitzer [Sat, 9 Jun 2018 10:11:43 +0000 (12:11 +0200)]
[FASTFAT] Save the FSINFO sector location

16 months ago[AUTOCHK] Let the timeout for disk repair to be configured
Pierre Schweitzer [Fri, 8 Jun 2018 22:18:21 +0000 (00:18 +0200)]
[AUTOCHK] Let the timeout for disk repair to be configured

16 months ago[TRANSLATION][DRWTSN32] Implement Romanian and Italian resource translations for...
Bișoc George [Fri, 8 Jun 2018 17:06:56 +0000 (19:06 +0200)]
[TRANSLATION][DRWTSN32] Implement Romanian and Italian resource translations for Dr.Watson (#607)

16 months ago[FASTFAT] Properly check for buffer size on dir enumeration.
Pierre Schweitzer [Thu, 7 Jun 2018 17:33:23 +0000 (19:33 +0200)]
[FASTFAT] Properly check for buffer size on dir enumeration.

This avoids improper returns when multiple entries are requested
and, in rare circumstances, entries not being seen by umode.

CORE-14699

16 months ago[MSI_WINETEST] Fix MSVC_IDE build. (#564)
Serge Gautherie [Thu, 7 Jun 2018 16:27:56 +0000 (18:27 +0200)]
[MSI_WINETEST] Fix MSVC_IDE build. (#564)

"reactos-cov\modules\rostests\winetests\msi\msi_winetest.rc(2): error RC2135: file not found: custom.dll [C:\ros_build\modules\rostests\winetests\msi\msi_winetest.vcxproj]".

Output files are written to Debug\ and Release\ subfolders in VSSolution mode, so the RC compiler will only find custom.dll if it knows to look in the right folder.

Thanks to Thomas Faber, who helped.

CORE-11836

16 months ago[SHELL32] Split dialogs/folder_options.cpp (#582)
Katayama Hirofumi MZ [Wed, 6 Jun 2018 12:04:50 +0000 (21:04 +0900)]
[SHELL32] Split dialogs/folder_options.cpp (#582)

The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906

16 months ago[CRT] Always initialize _[w]pgmptr with a *FULL* path to the current application.
Hermès Bélusca-Maïto [Tue, 5 Jun 2018 21:50:11 +0000 (23:50 +0200)]
[CRT] Always initialize _[w]pgmptr with a *FULL* path to the current application.

Otherwise fall back to the computed argv[0].
This is expected by some applications, for example Git.
Code is adapted from Wine.

Many thanks to Stanislav Motylkov for having investigated this bug!

CORE-12931 CORE-13892 CORE-13898 CORE-14066

16 months ago[USER32_APITEST] RedrawWindow: Add a DestroyWindow() call (#423)
Serge Gautherie [Tue, 5 Jun 2018 19:23:21 +0000 (21:23 +0200)]
[USER32_APITEST] RedrawWindow: Add a DestroyWindow() call (#423)

Addendum to 7905efdf357ad830d4abba23a428dcd9e6195247.

CORE-13734

16 months ago[RSHELL] Remove a duplicated add_custom_command() call (#570)
Serge Gautherie [Tue, 5 Jun 2018 18:17:34 +0000 (20:17 +0200)]
[RSHELL] Remove a duplicated add_custom_command() call (#570)

16 months ago[EXT2FS][REISERFS] VSSolution: Actually disable C4189 errors (#540)
Serge Gautherie [Tue, 5 Jun 2018 18:16:22 +0000 (20:16 +0200)]
[EXT2FS][REISERFS] VSSolution: Actually disable C4189 errors (#540)

Multiple "error C4189: '[...]': local variable is initialized but not referenced".

Thanks to Yuntian Zhang, who hinted at this in CORE-11836.

CORE-11280

16 months ago[BROWSEUI] Remove a duplicated add_custom_command() call
Serge Gautherie [Fri, 25 May 2018 10:25:55 +0000 (12:25 +0200)]
[BROWSEUI] Remove a duplicated add_custom_command() call

16 months ago[AUTOCHK] Allow users to skip disk checking if dirty
Pierre Schweitzer [Tue, 5 Jun 2018 17:33:36 +0000 (19:33 +0200)]
[AUTOCHK] Allow users to skip disk checking if dirty

CORE-14692

16 months ago[VFATLIB] Only check volume if full scan or if allowed to fix it
Pierre Schweitzer [Tue, 5 Jun 2018 17:30:11 +0000 (19:30 +0200)]
[VFATLIB] Only check volume if full scan or if allowed to fix it

This allows doing a quick probe about whether a volume needs to be
fixed by checking its dirty bit.

CORE-14692

16 months ago[CONFIGURE][CMAKE] Remove Visual Studio 9 (2008) support
Serge Gautherie [Fri, 25 May 2018 00:49:08 +0000 (02:49 +0200)]
[CONFIGURE][CMAKE] Remove Visual Studio 9 (2008) support

ReactOS does not compile anymore with it.
VS9 is already officially unsupported.

CORE-11836

16 months ago[CMAKE] Add "--always" parameter to "git describe" call
Serge Gautherie [Tue, 29 May 2018 14:02:26 +0000 (16:02 +0200)]
[CMAKE] Add "--always" parameter to "git describe" call

"fatal: No names found, cannot describe anything." message,
when called without enough history, i.e. appveyor.yml "clone_depth: 5".

16 months ago[MSHTA] Implement MSHTA.exe (#577) CORE-12813
Jared Smudde [Tue, 5 Jun 2018 15:17:00 +0000 (10:17 -0500)]
[MSHTA] Implement MSHTA.exe (#577) CORE-12813

Implement mshta.exe. It links directly to the function RunHTMLApplication in mshtml and passes the file name and other optional arguments along. While the function is unimplemented in mshtml, it's a start.

[MSHTML] Add ADD_IMPORTLIB to CMakeLists so mshta can link to mshtml.
[BOOTDATA] Add the association information for mshta.exe to the registry.

16 months ago[NTOS:CC] Access SectionObjectPointers without lock in CcRosInitializeFileCache.... 596/head
Thomas Faber [Mon, 4 Jun 2018 12:36:07 +0000 (14:36 +0200)]
[NTOS:CC] Access SectionObjectPointers without lock in CcRosInitializeFileCache. CORE-14691

kmtest:NtCreateSection calls CcInitializeCacheMap with a
NULL value for SectionObjectPointers. This will cause an exception when
trying to access it, which in Windows can be handled gracefully.
However accessing it while holding ViewLock means the lock will not be
released, leading to an APC_INDEX_MISMATCH bugcheck.

This solves the problem by allocating SharedCacheMap outside the lock,
then freeing it again under lock if another thread has updated SharedCacheMap
in the mean time. This is also What Windows Does(TM).

16 months ago[FONTS] Delete 16px bitmap from Tahoma Bold
Katayama Hirofumi MZ [Mon, 4 Jun 2018 23:20:25 +0000 (08:20 +0900)]
[FONTS] Delete 16px bitmap from Tahoma Bold

16 months ago[OLE32_WINETEST] Fix MSVC build.
Thomas Faber [Tue, 5 Jun 2018 09:36:30 +0000 (11:36 +0200)]
[OLE32_WINETEST] Fix MSVC build.

16 months ago[JSCRIPT] Fix MSVC build.
Thomas Faber [Mon, 4 Jun 2018 18:25:13 +0000 (20:25 +0200)]
[JSCRIPT] Fix MSVC build.