reactos.git
19 months ago[KERNEL32_APITEST] JapaneseCalendar must work even if not codepage 932"
Katayama Hirofumi MZ [Sun, 7 Apr 2019 03:18:54 +0000 (12:18 +0900)]
[KERNEL32_APITEST] JapaneseCalendar must work even if not codepage 932"

Delete (GetACP() != 932) check.

19 months ago[FONT] Fix FontSmoothing
Maxim Smirnov [Fri, 5 Apr 2019 10:16:07 +0000 (13:16 +0300)]
[FONT] Fix FontSmoothing

19 months ago[BOOTDATA] Improve error message of AHKAppTests.cmd (#1476)
Katayama Hirofumi MZ [Sat, 6 Apr 2019 23:05:35 +0000 (08:05 +0900)]
[BOOTDATA] Improve error message of AHKAppTests.cmd (#1476)

+    dbgprint "Insert ReactOS CD and try again."

19 months ago[NET][MC] Move STATISTICS SERVER strings from net.exe to netmsg.dll.
Eric Kohl [Sat, 6 Apr 2019 17:42:51 +0000 (19:42 +0200)]
[NET][MC] Move STATISTICS SERVER strings from net.exe to netmsg.dll.

Translators, please check the translations!

19 months ago[CMAKE] Clear CMAKE_<LANGUAGE>_IMPLICIT_LINK_LIBRARIES and
Jérôme Gardou [Sat, 6 Apr 2019 14:55:10 +0000 (16:55 +0200)]
[CMAKE] Clear CMAKE_<LANGUAGE>_IMPLICIT_LINK_LIBRARIES and
_IMPLICIT_LINK_DIRECTORIES

Othrewise, if you link a RC module with a static C library (as done for
fusion DLLs), you get the standard C libraries from GCC. This is not
what we want.

This might have to be done for MSVC builds. Check build.ninja to verify
this.

19 months ago[CMAKE] Also set blank DEFINE_SYMBOL property for freeldr helpers
Jérôme Gardou [Sat, 6 Apr 2019 14:50:56 +0000 (16:50 +0200)]
[CMAKE] Also set blank DEFINE_SYMBOL property for freeldr helpers

19 months ago[GDI32] Use correct dependenxy for the winegdi library
Jérôme Gardou [Sat, 6 Apr 2019 12:00:23 +0000 (14:00 +0200)]
[GDI32] Use correct dependenxy for the winegdi library

19 months ago[ZLIB] use correct dependency for minizip library
Jérôme Gardou [Sat, 6 Apr 2019 11:56:48 +0000 (13:56 +0200)]
[ZLIB] use correct dependency for minizip library

19 months ago[CMAKE] unset EXPORT_SYMBOL for modules and shared libraries
Jérôme Gardou [Sat, 6 Apr 2019 11:22:50 +0000 (13:22 +0200)]
[CMAKE] unset EXPORT_SYMBOL for modules and shared libraries

We don't use that

19 months ago[CMAKE] Use modules instead of shared libraries
Jérôme Gardou [Wed, 20 Mar 2019 13:19:48 +0000 (14:19 +0100)]
[CMAKE] Use modules instead of shared libraries

There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.

19 months ago[NET][MC] Move NET USER strings from net.exe to netmsg.dll.
Eric Kohl [Sat, 6 Apr 2019 13:32:00 +0000 (15:32 +0200)]
[NET][MC] Move NET USER strings from net.exe to netmsg.dll.

Translators, please check the translations!

19 months ago[KERNEL32_APITEST] s/48815/0xBEAF/ origin
Katayama Hirofumi MZ [Sat, 6 Apr 2019 12:59:35 +0000 (21:59 +0900)]
[KERNEL32_APITEST] s/48815/0xBEAF/

19 months ago[NET][MC] Move NET CONFIG strings from net.exe to netmsg.dll.
Eric Kohl [Sat, 6 Apr 2019 11:33:26 +0000 (13:33 +0200)]
[NET][MC] Move NET CONFIG strings from net.exe to netmsg.dll.

Translators, please check the translations!

19 months ago[KERNEL32] Improve MultiByteToWideChar (#1477)
Katayama Hirofumi MZ [Sat, 6 Apr 2019 11:11:07 +0000 (20:11 +0900)]
[KERNEL32] Improve MultiByteToWideChar (#1477)

Reduce MultiByteToWideChar failures. CORE-13349

19 months ago[KERNEL32_APITEST] Follow up of 89af984
Katayama Hirofumi MZ [Sat, 6 Apr 2019 09:20:04 +0000 (18:20 +0900)]
[KERNEL32_APITEST] Follow up of 89af984

19 months ago[KERNEL32_APITEST] 5-byte, 6-byte, ... UTF-8 sequences
Katayama Hirofumi MZ [Sat, 6 Apr 2019 08:48:15 +0000 (17:48 +0900)]
[KERNEL32_APITEST] 5-byte, 6-byte, ... UTF-8 sequences

19 months ago[MC] Add missing message translations by copying the english version
Timo Kreuzer [Fri, 5 Apr 2019 14:53:57 +0000 (16:53 +0200)]
[MC] Add missing message translations by copying the english version

Note: always translate the whole file! It's easier (use a script or simply a regex replace) and required by Visual Studio 2019.

19 months ago[KERNEL32_APITEST] Careless
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:55:03 +0000 (13:55 +0900)]
[KERNEL32_APITEST] Careless

19 months ago[KERNEL32_APITEST] Trivial
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:51:20 +0000 (13:51 +0900)]
[KERNEL32_APITEST] Trivial

19 months ago[KERNEL32_APITEST] Forgot FreeLibrary
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:48:05 +0000 (13:48 +0900)]
[KERNEL32_APITEST] Forgot FreeLibrary

19 months ago[KERNEL32_APITEST] Follow up of #1472
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:34:21 +0000 (13:34 +0900)]
[KERNEL32_APITEST] Follow up of #1472

19 months agoalso add modules/AHK_Tests to .gitignore
Katayama Hirofumi MZ [Sat, 6 Apr 2019 03:05:15 +0000 (12:05 +0900)]
also add modules/AHK_Tests to .gitignore

19 months agoadd modules/ahk_tests to .gitignore
Katayama Hirofumi MZ [Sat, 6 Apr 2019 02:47:25 +0000 (11:47 +0900)]
add modules/ahk_tests to .gitignore

19 months ago[SHELL32] pl-PL.rc escape sequence fix
Katayama Hirofumi MZ [Sat, 6 Apr 2019 02:41:08 +0000 (11:41 +0900)]
[SHELL32] pl-PL.rc escape sequence fix

19 months ago[SYSSETUP] Add Lunar theme option to 2nd setup stage
Adam Słaboń [Fri, 5 Apr 2019 23:00:46 +0000 (01:00 +0200)]
[SYSSETUP] Add Lunar theme option to 2nd setup stage

This adds Lunar theme option to the 2nd setup stage theme chooser page.

19 months ago[NET][MC] Replace strings for the ACCOUNTS, GROUP and LOCALGROUP commands by netmsg...
Eric Kohl [Fri, 5 Apr 2019 21:14:07 +0000 (23:14 +0200)]
[NET][MC] Replace strings for the ACCOUNTS, GROUP and LOCALGROUP commands by netmsg.dll messages.

19 months ago[SYSSETUP] Add a theme chooser that can handle multiple styles 1456/head
Mark Jansen [Tue, 2 Apr 2019 22:44:02 +0000 (00:44 +0200)]
[SYSSETUP] Add a theme chooser that can handle multiple styles

19 months ago[KERNEL32_APITEST] Improve MultiByteToWideChar testcase (#1472)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 13:04:04 +0000 (22:04 +0900)]
[KERNEL32_APITEST] Improve MultiByteToWideChar testcase (#1472)

Strengthen the testcase for kernel32!MultiByteToWideChar function. ROSTESTS-282

19 months ago[SDK][ATL] Independence day of ReactOS ATL (#1473)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 10:45:45 +0000 (19:45 +0900)]
[SDK][ATL] Independence day of ReactOS ATL (#1473)

Today is the Independence Day of ReactOS ATL (RATL). CORE-12935
https://github.com/katahiromz/RATL

19 months ago[FONTS] Update Libre Franklin to v1.501 (#1464)
Petr Akhlamov [Fri, 5 Apr 2019 09:15:47 +0000 (12:15 +0300)]
[FONTS] Update Libre Franklin to v1.501 (#1464)

Update Libre Franklin to release with cyrillic support.
https://github.com/alexeiva/Libre-Franklin/releases/tag/1.501

19 months ago[TRANSLATION] Polish translation update
Adam Słaboń [Thu, 4 Apr 2019 22:01:11 +0000 (00:01 +0200)]
[TRANSLATION] Polish translation update

Polish translation update for calc, fltmc, magnify, notepad, osk, sndvol32, usetup, fdebug, appwiz, mmsys, sysdm, acppage, ziplfdr, browseui, cryptui, jscript, shell32, themeui and inf. Added translation for cyrptext, vcdcontroltool, and (not yet complete) getuname.

19 months ago[SHIMGVW] Fix cursor (#1471)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 07:52:11 +0000 (16:52 +0900)]
[SHIMGVW] Fix cursor (#1471)

Fix the cursor of shimgvw.dll. CORE-15219

19 months ago[CRT][USER32] fix wsprintf additional argument (%*s) (#1470)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 07:33:18 +0000 (16:33 +0900)]
[CRT][USER32] fix wsprintf additional argument (%*s) (#1470)

Reduce wsprintf function failures ("%*s"). CORE-13955

19 months ago[KERNEL32_APITEST] Follow up of #1466 (#1469)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 04:04:15 +0000 (13:04 +0900)]
[KERNEL32_APITEST] Follow up of #1466 (#1469)

Skip tests if the current codepage is not Japanese. CORE-15920

19 months ago[KERNEL32_APITEST] Japanese calendar testcase (#1466)
Katayama Hirofumi MZ [Fri, 5 Apr 2019 00:06:41 +0000 (09:06 +0900)]
[KERNEL32_APITEST] Japanese calendar testcase (#1466)

Add Japanese calendar-related tests. CORE-15920

19 months ago[SHELL32] Implement Explorer background image (Retrial of #801) (#1463)
Katayama Hirofumi MZ [Thu, 4 Apr 2019 22:59:35 +0000 (07:59 +0900)]
[SHELL32] Implement Explorer background image (Retrial of #801) (#1463)

IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516

19 months ago[BOOTDATA] Japanese calendar-related registry info (#1468)
Katayama Hirofumi MZ [Thu, 4 Apr 2019 22:21:00 +0000 (07:21 +0900)]
[BOOTDATA] Japanese calendar-related registry info (#1468)

Add registry info about Japanese calendar. CORE-15920

19 months ago[MC] Add spanisch, polish, romanian, turkish, chinese and taiwanese messages to the...
Eric Kohl [Thu, 4 Apr 2019 21:53:35 +0000 (23:53 +0200)]
[MC] Add spanisch, polish, romanian, turkish, chinese and taiwanese messages to the file by duplicating the english ones and translate messages that will be used by the NET ACCOUNTS command.

Translators, please check the translations.

19 months ago[UDFS] Fix an integer overflow leading to a buffer overrun
Pierre Schweitzer [Thu, 4 Apr 2019 13:08:21 +0000 (15:08 +0200)]
[UDFS] Fix an integer overflow leading to a buffer overrun

Spotted by GCC7

19 months ago[GDI32_APITEST] Add LPtoDP testcase (#1462)
Katayama Hirofumi MZ [Thu, 4 Apr 2019 01:44:52 +0000 (10:44 +0900)]
[GDI32_APITEST] Add LPtoDP testcase (#1462)

ROSTESTS-320

19 months ago[ROSTESTS][GDI32_APITEST] Follow up of #1459 (#1460)
Katayama Hirofumi MZ [Wed, 3 Apr 2019 20:25:02 +0000 (05:25 +0900)]
[ROSTESTS][GDI32_APITEST] Follow up of #1459 (#1460)

ROSTESTS-319

19 months ago[SYSSETUP] Ask for common controls v6 when using v6 features 1454/head
Mark Jansen [Tue, 2 Apr 2019 19:25:19 +0000 (21:25 +0200)]
[SYSSETUP] Ask for common controls v6 when using v6 features

19 months ago[SYSSETUP] Add a missing break
Mark Jansen [Tue, 2 Apr 2019 19:23:58 +0000 (21:23 +0200)]
[SYSSETUP] Add a missing break

19 months ago[GDI32_APITEST] Improve DPtoLP testcase (#1459)
Katayama Hirofumi MZ [Wed, 3 Apr 2019 13:48:42 +0000 (22:48 +0900)]
[GDI32_APITEST] Improve DPtoLP testcase (#1459)

 ROSTESTS-319

19 months ago[ROSTESTS][GDI32_APITEST] Follow up of #1457 (#1458)
Katayama Hirofumi MZ [Wed, 3 Apr 2019 11:42:21 +0000 (20:42 +0900)]
[ROSTESTS][GDI32_APITEST] Follow up of #1457 (#1458)

Thanks, @SergeGautherie.

19 months ago[ROSTESTS][GDI32_APITEST] Refactor testcases (#1457)
Katayama Hirofumi MZ [Wed, 3 Apr 2019 08:22:21 +0000 (17:22 +0900)]
[ROSTESTS][GDI32_APITEST] Refactor testcases (#1457)

[ROSTESTS][GDI32_APITEST] Refactor testcases

19 months ago[SHELL32] Fix version info in the file dialog
Maxim Smirnov [Tue, 2 Apr 2019 21:03:19 +0000 (00:03 +0300)]
[SHELL32] Fix version info in the file dialog

19 months ago[UNIATA] Fix for uninitialized Lun pointer 1461/head
Alexandr A. Telyatnikov [Tue, 26 Mar 2019 13:56:53 +0000 (15:56 +0200)]
[UNIATA] Fix for uninitialized Lun pointer

This fixes crash on Intel AHCI init. CORE-15886

19 months ago[KERNEL32] Fix typo in kernel32.spec (#1453)
Julien Schueller [Tue, 2 Apr 2019 13:48:41 +0000 (15:48 +0200)]
[KERNEL32] Fix typo in kernel32.spec (#1453)

19 months ago[WIN32SS][FONT] Fix font coordinate conversion CORE-15907 (#1452)
Katayama Hirofumi MZ [Tue, 2 Apr 2019 13:39:26 +0000 (22:39 +0900)]
[WIN32SS][FONT] Fix font coordinate conversion CORE-15907 (#1452)

[WIN32SS][FONT] Fix font bounding box mapping for viewport CORE-15907

19 months ago[UDFS] Fix 64 bit issues
Timo Kreuzer [Mon, 20 Aug 2018 17:02:00 +0000 (19:02 +0200)]
[UDFS] Fix 64 bit issues

19 months ago[NETAPI32] Fix NetUserEnum to work on x64
Timo Kreuzer [Sun, 10 Mar 2019 21:19:12 +0000 (22:19 +0100)]
[NETAPI32] Fix NetUserEnum to work on x64

The previous implementation used the resume_handle parameter to return a pointer to the active enumeration context, but resume_handle is a DWORD. To support 64 bit pointers, the enumeration context is inserted into a global linked list and given a unique 32 bit value as identifier for later lookup.
The way the function is implemented, leaking a data structure while the MSDN description does not indicate that, seems a little questionable in general, but that is something that I leave to the original author to investigate.

19 months ago[SETUPAPI] Use ClassInstallReserved field instead of Reserved to store a pointer.
Timo Kreuzer [Wed, 28 Feb 2018 19:14:28 +0000 (20:14 +0100)]
[SETUPAPI] Use ClassInstallReserved field instead of Reserved to store a pointer.

The Reserved field is ULONG and we need ULONG_PTR. ClassInstallReserved was unused so far. I have no idea whether this is correct, but it cannot be more incorrect than what we had.

19 months agoRevert "[DXG] Define GUIDs only once", to fix MSVC build
Hervé Poussineau [Mon, 1 Apr 2019 16:00:59 +0000 (18:00 +0200)]
Revert "[DXG] Define GUIDs only once", to fix MSVC build

This reverts commit 3a78dd4b3158cd535d561e7a95fbb55863a1a669.

19 months ago[CMAKE] Enable -fno-aggressive-loop-optimizations only for GCC 4.8(+)
Hervé Poussineau [Mon, 1 Apr 2019 15:29:07 +0000 (17:29 +0200)]
[CMAKE] Enable -fno-aggressive-loop-optimizations only for GCC 4.8(+)

Previously, it was also enabled for GCC > 4.7, ie for example for GCC 4.7.1

19 months ago[RAPPS] Fix compilation
Hervé Poussineau [Sat, 30 Mar 2019 22:04:46 +0000 (23:04 +0100)]
[RAPPS] Fix compilation

DPA_Search() function requires 6 parameters, not 4!

19 months ago[SETUPAPI] SetupDiGetDeviceInfoListClass: fix buffer overflow (and return correct...
Hervé Poussineau [Sat, 30 Mar 2019 21:31:21 +0000 (22:31 +0100)]
[SETUPAPI] SetupDiGetDeviceInfoListClass: fix buffer overflow (and return correct results)

19 months ago[USERENV] Initialize variable before using it
Hervé Poussineau [Sat, 30 Mar 2019 21:32:41 +0000 (22:32 +0100)]
[USERENV] Initialize variable before using it

19 months ago[GLU32] Prevent a warning when comparing 'this' against 0
Hervé Poussineau [Sun, 31 Mar 2019 08:40:06 +0000 (10:40 +0200)]
[GLU32] Prevent a warning when comparing 'this' against 0

19 months ago[DXG] Define GUIDs only once
Hervé Poussineau [Sat, 30 Mar 2019 21:37:56 +0000 (22:37 +0100)]
[DXG] Define GUIDs only once

19 months ago[UDFS] Really use 'logical or' when meant to
Hervé Poussineau [Sun, 31 Mar 2019 06:39:22 +0000 (08:39 +0200)]
[UDFS] Really use 'logical or' when meant to

'binary or' was also working, but it is less clear.

19 months ago[EXT2] Correctly zero memory before using it
Hervé Poussineau [Sat, 30 Mar 2019 22:06:27 +0000 (23:06 +0100)]
[EXT2] Correctly zero memory before using it

19 months ago[CRT] Correctly share get_ioinfo()/release_ioinfo() functions between code units
Hervé Poussineau [Sat, 30 Mar 2019 21:33:33 +0000 (22:33 +0100)]
[CRT] Correctly share get_ioinfo()/release_ioinfo() functions between code units

This fixes the following compiler errors:

../sdk/lib/crt/stdio/stat64.c:7:13: error: inline function 'release_ioinfo' declared but never defined [-Werror]
 inline void release_ioinfo(ioinfo *info);
             ^~~~~~~~~~~~~~
../sdk/lib/crt/stdio/stat64.c:6:16: error: inline function 'get_ioinfo' declared but never defined [-Werror]
 inline ioinfo* get_ioinfo(int fd);
                ^~~~~~~~~~
../sdk/lib/crt/stdio/file.c:186:5: error: 'init_ioinfo_cs' is static but used in inline function 'get_ioinfo' which is not static [-Werror]
     init_ioinfo_cs(ret);
     ^~~~~~~~~~~~~~
../sdk/lib/crt/stdio/file.c:183:19: error: 'get_ioinfo_nolock' is static but used in inline function 'get_ioinfo' which is not static [-Werror]
     ioinfo *ret = get_ioinfo_nolock(fd);

19 months ago[SDK] Fix compilation error
Hervé Poussineau [Sat, 30 Mar 2019 21:49:16 +0000 (22:49 +0100)]
[SDK] Fix compilation error

../sdk/include/reactos/rosctrls.h:283:59: error: no matching function for call to 'CToolbar<TItemData>::SendMessageW(int, HWND__*&, int)'
         return SendMessageW(TB_SETTOOLTIPS, hWndTooltip, 0);
../sdk/include/psdk/winuser.h:5543:21: note: candidate: LRESULT ATL::CWindow::SendMessageW(UINT, WPARAM, LPARAM) <near match>
../sdk/include/psdk/winuser.h:5543:21: note:   conversion of argument 2 would be ill-formed

19 months ago[FREELDR] Prevent a warning in Xbox memory initialization
Hervé Poussineau [Sun, 31 Mar 2019 08:30:45 +0000 (10:30 +0200)]
[FREELDR] Prevent a warning in Xbox memory initialization

19 months ago[CMAKE] Add -fno-aggressive-loop-optimizations flag
Hervé Poussineau [Sun, 31 Mar 2019 06:40:36 +0000 (08:40 +0200)]
[CMAKE] Add -fno-aggressive-loop-optimizations flag

ReactOS/Windows headers contain lots of structures whose last field is
fieldName[ANYSIZE] or fieldName[1].
Starting with GCC 4.8, gcc considers that accessing items [2], [3], ...
are undefined operation, and may optimize those accesses by removing them!

Add flag -fno-aggressive-loop-optimizations to prevent this unwanted behaviour.

19 months ago[PSDK] Remove throw specifiers, deprecated in C++11
Hervé Poussineau [Sat, 30 Mar 2019 21:30:22 +0000 (22:30 +0100)]
[PSDK] Remove throw specifiers, deprecated in C++11

19 months ago[NTOSKRNL] Do not try to access OldBackTracking[-1]
Bartosz Brachaczek [Mon, 1 Apr 2019 00:09:23 +0000 (02:09 +0200)]
[NTOSKRNL] Do not try to access OldBackTracking[-1]

It can be triggered by the existing "F<", "FILE.TXT" case in the tests.

CORE-15902

19 months ago[NTOSKRNL] Unify buffer size calculation in FsRtlIs{Name,Dbcs}InExpression
Bartosz Brachaczek [Sun, 31 Mar 2019 23:58:21 +0000 (01:58 +0200)]
[NTOSKRNL] Unify buffer size calculation in FsRtlIs{Name,Dbcs}InExpression

It better captures the intent now in FsRtlIsNameInExpressionPrivate and
fixes a slight overallotion by 4 bytes in FsRtlIsDbcsInExpression.

While at it, use the ANSI_DOS_DOT macro in the Dbcs version.

CORE-15902

19 months ago[TRANSLATION][USERINIT] Update Bulgarian translation.
Hermès Bélusca-Maïto [Sun, 31 Mar 2019 21:18:29 +0000 (23:18 +0200)]
[TRANSLATION][USERINIT] Update Bulgarian translation.

Fixed the "installation failed" displayed error string.
Based on a patch by contributor 'WindowxDeveloper'.

19 months ago[TRANSLATION][RUNONCE] Add Bulgarian translation. 1196/head
WindowxDeveloper [Thu, 27 Dec 2018 08:12:45 +0000 (09:12 +0100)]
[TRANSLATION][RUNONCE] Add Bulgarian translation.

19 months ago[TRANSLATION][WINLOGON] Improve Bulgarian translation. 1194/head
WindowxDeveloper [Thu, 27 Dec 2018 08:06:44 +0000 (09:06 +0100)]
[TRANSLATION][WINLOGON] Improve Bulgarian translation.

19 months ago[TRANSLATION][SERVICES] Add Bulgarian translation. 1195/head
WindowxDeveloper [Thu, 27 Dec 2018 08:02:10 +0000 (09:02 +0100)]
[TRANSLATION][SERVICES] Add Bulgarian translation.

19 months ago[THEMES] Add artwork for Lunar. 1433/head
Joann Mõndresku [Wed, 20 Mar 2019 20:34:33 +0000 (22:34 +0200)]
[THEMES] Add artwork for Lunar.

Added original artwork for the new Lunar theme.

19 months ago[THEMES] Add new ReactOS theme - Lunar. By Adam Słaboń and Joann Mõndresku.
Adam Słaboń [Wed, 20 Mar 2019 20:23:29 +0000 (21:23 +0100)]
[THEMES] Add new ReactOS theme - Lunar. By Adam Słaboń and Joann Mõndresku.

Reuse some Lautus assets, adjust the theme configuration and include it in the build process.

19 months ago[NtGdi] Fix assert with Winamp
jimtabor [Sun, 31 Mar 2019 18:31:59 +0000 (13:31 -0500)]
[NtGdi] Fix assert with Winamp

Fixes CORE-10774.

Reference:
Alexandre Julliard : Ignore empty rectangles in ExtCreateRegion.
https://source.winehq.org/git/wine.git/commitdiff/8ac61c5a1e56d0933de8af69dbb2a1640d13e05d

19 months ago[COVERITY][SPOOLSS] Fix a resource leak
Bișoc George [Sat, 30 Mar 2019 13:48:44 +0000 (14:48 +0100)]
[COVERITY][SPOOLSS] Fix a resource leak

Unload the library pointed by hWinspool when the function fails.

CID 1401149

19 months ago[RAPPS] Add themes category
Baruch Rutman [Thu, 28 Mar 2019 21:06:46 +0000 (23:06 +0200)]
[RAPPS] Add themes category

Add category string to the rest of rc files

Update README

19 months ago[CONFIGURE] Add VS 16.0 support. 1373/head
Raul Tambre [Sun, 24 Feb 2019 10:59:14 +0000 (12:59 +0200)]
[CONFIGURE] Add VS 16.0 support.

19 months ago[CONFIGURE] Simplify Visual Studio generator selection.
Raul Tambre [Sun, 24 Feb 2019 10:58:22 +0000 (12:58 +0200)]
[CONFIGURE] Simplify Visual Studio generator selection.

CMake >3.2 supports specifying the architecture through the -A parameter,
allowing the logic to be simplified.
Specifying the architecture like this is also required since Visual Studio 2019.

19 months ago[NTOSKRNL] Addendum to 21d2c70: properly start DOS_START loop
Bartosz Brachaczek [Sun, 31 Mar 2019 17:33:53 +0000 (19:33 +0200)]
[NTOSKRNL] Addendum to 21d2c70: properly start DOS_START loop

Fixes last failing test.

CORE-15902

19 months ago[NTOSKRNL] In MmCreateImageSection, properly check whether cache was initialized
Maxim Smirnov [Sun, 31 Mar 2019 11:51:06 +0000 (14:51 +0300)]
[NTOSKRNL] In MmCreateImageSection, properly check whether cache was initialized

This fixes a crash that occurs if nul is typed in cmd.exe

19 months ago[NTOSKRNL] Properly copy backtracking buffer content on realloc
Bartosz Brachaczek [Sun, 31 Mar 2019 09:42:56 +0000 (11:42 +0200)]
[NTOSKRNL] Properly copy backtracking buffer content on realloc

CORE-15902

19 months ago[NTOSKRNL] Properly compare position to name length in FsRtlIsNameInExpressionPrivate
Bartosz Brachaczek [Sun, 31 Mar 2019 09:32:57 +0000 (11:32 +0200)]
[NTOSKRNL] Properly compare position to name length in FsRtlIsNameInExpressionPrivate

CORE-15902

19 months ago[NTOSKRNL] Don't overflow backtrack stack buffer
Bartosz Brachaczek [Sun, 31 Mar 2019 09:27:16 +0000 (11:27 +0200)]
[NTOSKRNL] Don't overflow backtrack stack buffer

CORE-15902

19 months ago[NTOSKRNL] Don't oversize buffer for backtracking in FsRtlIsNameInExpressionPrivate
Bartosz Brachaczek [Sun, 31 Mar 2019 09:15:38 +0000 (11:15 +0200)]
[NTOSKRNL] Don't oversize buffer for backtracking in FsRtlIsNameInExpressionPrivate

CORE-15902

19 months ago[KMTESTS:FSRTL] Add more tests for FsRtlIsNameInExpression
Pierre Schweitzer [Sun, 31 Mar 2019 09:09:43 +0000 (11:09 +0200)]
[KMTESTS:FSRTL] Add more tests for FsRtlIsNameInExpression

CORE-15902

19 months ago[MBEDTLS] Update to version 2.7.10. CORE-15895
Thomas Faber [Wed, 27 Mar 2019 14:40:37 +0000 (15:40 +0100)]
[MBEDTLS] Update to version 2.7.10. CORE-15895

19 months ago[ACPICA] Update to version 20190329. CORE-15900
Thomas Faber [Sat, 30 Mar 2019 10:18:50 +0000 (11:18 +0100)]
[ACPICA] Update to version 20190329. CORE-15900

19 months ago[NTOS:IO] Send IRPs to the correct device in IoVolumeDeviceToDosName. CORE-15415
Thomas Faber [Fri, 29 Mar 2019 08:08:36 +0000 (09:08 +0100)]
[NTOS:IO] Send IRPs to the correct device in IoVolumeDeviceToDosName. CORE-15415

19 months ago[MEH] Forgot that file :-(
Pierre Schweitzer [Fri, 29 Mar 2019 20:51:41 +0000 (21:51 +0100)]
[MEH] Forgot that file :-(

19 months ago[NTOSKRNL] We don't need an event if we don't issue an IRP
Pierre Schweitzer [Fri, 29 Mar 2019 20:47:34 +0000 (21:47 +0100)]
[NTOSKRNL] We don't need an event if we don't issue an IRP

19 months ago[NTOSKRNL] Implement support for FileFsDriverPathInformation in NtQueryVolumeInformat...
Pierre Schweitzer [Fri, 29 Mar 2019 20:42:42 +0000 (21:42 +0100)]
[NTOSKRNL] Implement support for FileFsDriverPathInformation in NtQueryVolumeInformationFile

19 months ago[NTOSKRNL] Do. Not. L. E. A. K.
Pierre Schweitzer [Fri, 29 Mar 2019 18:51:38 +0000 (19:51 +0100)]
[NTOSKRNL] Do. Not. L. E. A. K.

19 months ago[NULL] Use correct device characteristics value for the null device
Maxim Smirnov [Wed, 27 Mar 2019 01:23:21 +0000 (04:23 +0300)]
[NULL] Use correct device characteristics value for the null device

19 months ago[NTOSKRNL] Only allow direct device open for FileFsDeviceInformation
Pierre Schweitzer [Thu, 28 Mar 2019 21:39:15 +0000 (22:39 +0100)]
[NTOSKRNL] Only allow direct device open for FileFsDeviceInformation

19 months ago[NTOSKRNL] Add a quick path for FileFsDeviceInformation in NtQueryVolumeInformationFile
Pierre Schweitzer [Thu, 28 Mar 2019 21:29:22 +0000 (22:29 +0100)]
[NTOSKRNL] Add a quick path for FileFsDeviceInformation in NtQueryVolumeInformationFile

This allows querying volume information without issuing an IRP to the owner device.
The kernel is supposed to already have all the required information to return
to the caller.

Side effect: this allows querying volume information for devices not implementing
IRP_MJ_QUERY_VOLUME_INFORMATION such as null.sys
This fixes opening null device in Python.

Fix based on debugging by Maxim Smirnov in PR #1442

CORE-14551

19 months ago[OSK] Initialize the common controls
Bișoc George [Thu, 28 Mar 2019 15:09:16 +0000 (16:09 +0100)]
[OSK] Initialize the common controls

On-Screen Keyboard has a manifest which is used for visual styles. However, the common controls aren't initialized and as a general rule the controls have to be loaded in the application's handle instance.

19 months ago[NtUser] Fix maximizing to window edge
jimtabor [Wed, 27 Mar 2019 22:39:04 +0000 (17:39 -0500)]
[NtUser] Fix maximizing to window edge

Cover up the edge of the frame while maximizing the window to desktop.
Fixes CORE-15893.

19 months ago[OSK] Fix an instance race condition
Bișoc George [Sun, 24 Mar 2019 08:40:43 +0000 (09:40 +0100)]
[OSK] Fix an instance race condition

On-Screen Keyboard provides a mechanism to launch the application only once, to avoid multiple entry point instances. Such mechanism is based upon mutex objects, although it could happen that the program may end up creating two or more mutexes (a race condition).

CORE-15877