reactos.git
3 years ago[KMTESTS:FSRTL]
Pierre Schweitzer [Wed, 10 Aug 2016 20:50:36 +0000 (20:50 +0000)]
[KMTESTS:FSRTL]
Add a stress test for tunnel cache implementation, where we have fun adding duplicated entries.
It doesn't seem to go well.
These tests are also known as "Learn your English ordinals", or as "Learn how to count in English". My pleasure.

CORE-11819

svn path=/trunk/; revision=72192

3 years ago[ATL][ATL_APITEST] Partially implement CRegKey + add tests. CORE-11746
Mark Jansen [Wed, 10 Aug 2016 19:34:38 +0000 (19:34 +0000)]
[ATL][ATL_APITEST] Partially implement CRegKey + add tests. CORE-11746

svn path=/trunk/; revision=72191

3 years ago[SDK]
Dmitry Chapyshev [Wed, 10 Aug 2016 19:05:54 +0000 (19:05 +0000)]
[SDK]
- KLF_SHIFTLOCK is not equal 65535. Correct value is 0x00010000

svn path=/trunk/; revision=72190

3 years ago[INPUT]
Dmitry Chapyshev [Wed, 10 Aug 2016 19:04:11 +0000 (19:04 +0000)]
[INPUT]
- Draw 0x2022 unicode symbol instead 0x25CF (marking default input method)
- Fix incorrect logic in CapsLock parameters
- Notice system of change CapsLock mode parameters

svn path=/trunk/; revision=72189

3 years ago[SHELL32]
Giannis Adamopoulos [Wed, 10 Aug 2016 18:56:48 +0000 (18:56 +0000)]
[SHELL32]
- Add CRegFolder using the guid item specific functions. So far it is only partly implemented with stuff like enumerating still missing.
- Use CRegFolder in CDesktopFolder, CDrivesFolder and CControlPanelFolder and stop using guid item specific functions.

svn path=/trunk/; revision=72188

3 years ago[SHIMLIB] Improve header inclusions.
Amine Khaldi [Wed, 10 Aug 2016 13:37:22 +0000 (13:37 +0000)]
[SHIMLIB] Improve header inclusions.

svn path=/trunk/; revision=72187

3 years ago[NTOSKRNL]
Pierre Schweitzer [Wed, 10 Aug 2016 11:52:30 +0000 (11:52 +0000)]
[NTOSKRNL]
While attempting to read data from disk in CcReadVirtualAddress(), always align our read size by pages.
That means that even on boundaries, we will read a complete page.
This fixes FSD relying on Cc to properly align reads and thus poorly failing in disk.sys because of unaligned reads.
Notably, it helps MS FastFAT loading a bit farther in ReactOS (but it still fails :-().
This also fixes a few kmtests.

CORE-11003
CORE-11819

svn path=/trunk/; revision=72186

3 years ago[INPUT]
Hermès Bélusca-Maïto [Wed, 10 Aug 2016 11:42:21 +0000 (11:42 +0000)]
[INPUT]
- Fix misspelling "Dublicate" -> "Duplicate".
- Use ZeroMemory instead of memset(..., 0, ...).
- Don't hardcode most of the variable types for sizeof.

svn path=/trunk/; revision=72185

3 years ago[TCPIP]
Thomas Faber [Wed, 10 Aug 2016 11:19:59 +0000 (11:19 +0000)]
[TCPIP]
- Use pool tagging

svn path=/trunk/; revision=72184

3 years ago[IP]
Thomas Faber [Wed, 10 Aug 2016 10:28:28 +0000 (10:28 +0000)]
[IP]
- Only accept an incoming connection on one listening socket, not all. Fixes use after free when multiple connection endpoints are assigned the same PCB.
CORE-11649 #resolve

svn path=/trunk/; revision=72183

3 years ago[KMTESTS:CC]
Pierre Schweitzer [Wed, 10 Aug 2016 07:39:20 +0000 (07:39 +0000)]
[KMTESTS:CC]
New test case which is matching the MS FastFAT CcCopyRead (minus the offset) and shows clearly the issue in our Cc.
It also shows that my hack is utterly broken :-).

CORE-11003
CORE-11819

svn path=/trunk/; revision=72182

3 years ago[NtUser]
James Tabor [Wed, 10 Aug 2016 03:02:57 +0000 (03:02 +0000)]
[NtUser]
- Fix breakage due to WM_NCPAINT call. Duplicate check for draw caption bar Justin Case.

svn path=/trunk/; revision=72181

3 years ago[NtUser]
James Tabor [Wed, 10 Aug 2016 00:16:57 +0000 (00:16 +0000)]
[NtUser]
- Fix regression from r71846. See CORE-11479 for more details.

svn path=/trunk/; revision=72180

3 years ago[README.WINE]
Ged Murphy [Tue, 9 Aug 2016 22:23:16 +0000 (22:23 +0000)]
[README.WINE]
- Remove reference to fltlib. It was, and will likely only ever be a stubbed dll in Wine

svn path=/trunk/; revision=72179

3 years ago[FLTLIB]
Ged Murphy [Tue, 9 Aug 2016 22:10:05 +0000 (22:10 +0000)]
[FLTLIB]
- Stub out fltlib.dll.
- Add basic implementations for FilterLoad and FilterUnload
- Remove the wine code, this lib talks directly to fltmgr.sys and is therefore a reactos only dll from now on.

svn path=/trunk/; revision=72178

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 21:49:06 +0000 (21:49 +0000)]
[INPUT]
- Rename input_new to input

svn path=/trunk/; revision=72177

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 21:45:58 +0000 (21:45 +0000)]
[INPUT]
- Remove old input.dll

svn path=/trunk/; revision=72176

3 years ago[KBSWITCH]
Dmitry Chapyshev [Tue, 9 Aug 2016 21:41:05 +0000 (21:41 +0000)]
[KBSWITCH]
- Hackfix detecting keyboard layout switching

* Now when hotkeys switching layouts icon changes

svn path=/trunk/; revision=72175

3 years ago[FLTMC]
Ged Murphy [Tue, 9 Aug 2016 21:33:53 +0000 (21:33 +0000)]
[FLTMC]
- Start to implement fltMC
- It currently supports loading, unloading and listing loaded filter driver.

svn path=/trunk/; revision=72174

3 years ago[FLTLIB_APITEST]
Ged Murphy [Tue, 9 Aug 2016 21:23:40 +0000 (21:23 +0000)]
[FLTLIB_APITEST]
- Create a skeleton test project for fltlib.dll
- Not yet part of the build

svn path=/trunk/; revision=72173

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 21:09:07 +0000 (21:09 +0000)]
[INPUT]
- Small fix :-p

svn path=/trunk/; revision=72172

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 21:03:55 +0000 (21:03 +0000)]
[INPUT]
- Implement 'Key Settings' and 'Change Key Settings' dialogs

* Now you can add, delete and change the input method, change the hotkey switching input methods. The system correctly responds to changes. It works fine in Windows 10, but has not yet been tested on ReactOS

svn path=/trunk/; revision=72171

3 years ago[KMTESTS:CC]
Pierre Schweitzer [Tue, 9 Aug 2016 20:52:38 +0000 (20:52 +0000)]
[KMTESTS:CC]
It seems we're page-aligned.

CORE-11003

svn path=/trunk/; revision=72170

3 years ago[KMTESTS:CC]
Pierre Schweitzer [Tue, 9 Aug 2016 20:46:00 +0000 (20:46 +0000)]
[KMTESTS:CC]
Modify a bit the read test so that it actually fails in ReactOS. It instructs us that when it comes to file boundaries, our Cc fails to properly align read (whereas it should!).
This is the behavior exposed by the MS FastFAT.

CORE-11003
CORE-11819

svn path=/trunk/; revision=72169

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 18:26:43 +0000 (18:26 +0000)]
[INPUT]
- Implement editing input methods
- Marking default layout
- Other bugfixes

svn path=/trunk/; revision=72168

3 years ago[SHELL32]
Giannis Adamopoulos [Tue, 9 Aug 2016 18:05:50 +0000 (18:05 +0000)]
[SHELL32]
- Don't hardcode the path in the shell namespace in any folder appart for CDesktopFolder and CDrivesFolder.
- Make SHELL32_CoCreateInitSF slightly more generic and use it when we need to create and initialise a shell folder.
- Now SHELL32_BindToFS is used only by CFSFolder but SHELL32_CoCreateInitSF still uses the generic _ILSimpleGetTextW (it accesses the pidl).

svn path=/trunk/; revision=72167

3 years ago[INPUT]
Dmitry Chapyshev [Tue, 9 Aug 2016 14:01:52 +0000 (14:01 +0000)]
[INPUT]
- Implement 'Remove', 'Set Default' for input methods

svn path=/trunk/; revision=72166

3 years ago[KMTESTS:CC]
Pierre Schweitzer [Tue, 9 Aug 2016 12:43:18 +0000 (12:43 +0000)]
[KMTESTS:CC]
Complete the tests for Cc: not only check for alignment, but also check that expected data are returned.
Thanks to Thomas for his help on this :-).

CORE-11003

svn path=/trunk/; revision=72165

3 years ago[NTOS:CC]
Thomas Faber [Tue, 9 Aug 2016 07:59:07 +0000 (07:59 +0000)]
[NTOS:CC]
- Gracefully handle failure to obtain virtual memory when creating a VACB. We now no longer crash when running out of virtual memory during (large) file operations (but will still crash when running out of physical memory).
CORE-11533

svn path=/trunk/; revision=72164

3 years ago[NTOS:MM]
Thomas Faber [Tue, 9 Aug 2016 07:48:09 +0000 (07:48 +0000)]
[NTOS:MM]
- Correctly reserve the whole 4 MB of HAL address space instead of just 2 pages
CORE-11533

svn path=/trunk/; revision=72163

3 years ago[NTOS:MM]
Thomas Faber [Tue, 9 Aug 2016 07:43:51 +0000 (07:43 +0000)]
[NTOS:MM]
- Accept memory areas that end at 0xffffffff
CORE-11533

svn path=/trunk/; revision=72162

3 years ago[NTOS:MM]
Thomas Faber [Tue, 9 Aug 2016 07:28:02 +0000 (07:28 +0000)]
[NTOS:MM]
- In debug builds, invalidate the MEMORY_AREA's Magic on destroy to catch potential uses after free

svn path=/trunk/; revision=72161

3 years ago[INPUT]
Dmitry Chapyshev [Mon, 8 Aug 2016 20:30:36 +0000 (20:30 +0000)]
[INPUT]
- Implement add input methods
- Some improvents

svn path=/trunk/; revision=72160

3 years ago[MSPAINT] Handle settings from registry correctly. Patch by Carlo Bramini. CORE...
Benedikt Freisen [Mon, 8 Aug 2016 14:00:18 +0000 (14:00 +0000)]
[MSPAINT] Handle settings from registry correctly.  Patch by Carlo Bramini.  CORE-11400

svn path=/trunk/; revision=72158

3 years ago[FASTFAT]
Pierre Schweitzer [Mon, 8 Aug 2016 12:44:15 +0000 (12:44 +0000)]
[FASTFAT]
Fix a FIXME: update the last writing date in case of null-length write.

svn path=/trunk/; revision=72157

3 years ago[FASTFAT]
Pierre Schweitzer [Mon, 8 Aug 2016 07:28:14 +0000 (07:28 +0000)]
[FASTFAT]
Opening file by ID is not possible with FAT.

svn path=/trunk/; revision=72156

3 years ago[User32]
James Tabor [Sun, 7 Aug 2016 23:52:43 +0000 (23:52 +0000)]
[User32]
- Fix bug that was uncovered by r72143. See CORE-11810.
- Move System Commands to server side. Leaving Alt-Tab and Scrolls.

svn path=/trunk/; revision=72155

3 years ago[INPUT]
Dmitry Chapyshev [Sun, 7 Aug 2016 23:28:50 +0000 (23:28 +0000)]
[INPUT]
- Implement list of keyboard layouts on Settings Page

svn path=/trunk/; revision=72154

3 years ago[LSASRV]
Eric Kohl [Sun, 7 Aug 2016 22:36:07 +0000 (22:36 +0000)]
[LSASRV]
- Partital implementation of LsarRemoveAccountRights.
- Simplify LsapLookupAccountRightValue. Return ACCESS_MASK instead of NTSTATUS.
- LsarAddAccountRights: Check parameters before referncing the policy handle.

svn path=/trunk/; revision=72153

3 years ago[ADVAPI32]: Addendum to r72151: It's incorrect to compare the variable of BOOL type...
Hermès Bélusca-Maïto [Sun, 7 Aug 2016 19:11:08 +0000 (19:11 +0000)]
[ADVAPI32]: Addendum to r72151: It's incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true". Caught by Thomas.

svn path=/trunk/; revision=72152

3 years ago[ADVAPI32]: Don't directly redirect IsTextUnicode to RtlIsTextUnicode, but use a...
Hermès Bélusca-Maïto [Sun, 7 Aug 2016 19:02:07 +0000 (19:02 +0000)]
[ADVAPI32]: Don't directly redirect IsTextUnicode to RtlIsTextUnicode, but use a helper function, so that the return value is correctly set to TRUE or FALSE. Indeed the former function returns a BOOL (long) while the latter returns a BOOLEAN (byte), and the high bytes in the return value could not be correctly set otherwise.

Adapted from a patch by 'andy-123'.

CORE-11803 #resolve #comment Fixesd, thanks!

svn path=/trunk/; revision=72151

3 years ago[SDK][RTL][NDK]: Update RtlIsTextUnicode prototype.
Hermès Bélusca-Maïto [Sun, 7 Aug 2016 18:52:49 +0000 (18:52 +0000)]
[SDK][RTL][NDK]: Update RtlIsTextUnicode prototype.

svn path=/trunk/; revision=72150

3 years ago[ADVAPI32]: Cleanup file headers and whitespace.
Hermès Bélusca-Maïto [Sun, 7 Aug 2016 16:57:45 +0000 (16:57 +0000)]
[ADVAPI32]: Cleanup file headers and whitespace.

svn path=/trunk/; revision=72149

3 years ago[APITESTS]: Add a test for advapi32!IsTextUnicode.
Hermès Bélusca-Maïto [Sun, 7 Aug 2016 16:35:56 +0000 (16:35 +0000)]
[APITESTS]: Add a test for advapi32!IsTextUnicode.
CORE-11803

svn path=/trunk/; revision=72148

3 years ago[FASTFAT]
Thomas Faber [Sun, 7 Aug 2016 14:24:45 +0000 (14:24 +0000)]
[FASTFAT]
- Update FCB hashes after changing the path name
CORE-11377

svn path=/trunk/; revision=72147

3 years ago[INPUT]
Dmitry Chapyshev [Sun, 7 Aug 2016 13:07:23 +0000 (13:07 +0000)]
[INPUT]
- Create an empty project for re-working keyboard layouts management

svn path=/trunk/; revision=72146

3 years ago[FASTFAT]
Pierre Schweitzer [Sun, 7 Aug 2016 12:29:48 +0000 (12:29 +0000)]
[FASTFAT]
After renaming a directory, rename any children FCB that would still exist in the FSD. This will allow next directory opening to properly work and open correct data.
This defeats corruption on directory renaming.
Unfortunately, this solution is not ideal and our driver should be reworked so that it quits using a hash table and it quits storing the whole path in the FCBs.

Deep thanks to Wim Hueskes and Thomas Faber for their help debugging the issue!

CORE-11377

svn path=/trunk/; revision=72145

3 years ago[NTOS:CC]
Thomas Faber [Sun, 7 Aug 2016 07:00:56 +0000 (07:00 +0000)]
[NTOS:CC]
- Define CcPfEnablePrefetcher
CORE-11799

svn path=/trunk/; revision=72144

3 years ago[KBSWITCH]
Dmitry Chapyshev [Sat, 6 Aug 2016 20:48:33 +0000 (20:48 +0000)]
[KBSWITCH]
- Use strsafe functions
- Use Shell Hooks in dll for detecting keyboard layout switching
- Fix bug in loading kbsdll

* Detection switch keyboard layout is now working in Windovs, but does not work in ReactOS (WH_SHELL not work in win32k)

svn path=/trunk/; revision=72143

3 years ago[WIN32K]
Dmitry Chapyshev [Sat, 6 Aug 2016 17:43:57 +0000 (17:43 +0000)]
[WIN32K]
- Detect Alt+Shift hotkeys and send input language change request message to window

* Switching the keyboard layout works now. The code needs to be improved

svn path=/trunk/; revision=72142

3 years ago[LSASRV]
Eric Kohl [Sat, 6 Aug 2016 17:07:59 +0000 (17:07 +0000)]
[LSASRV]
Move ServiceInit() into a separate file.

svn path=/trunk/; revision=72141

3 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sat, 6 Aug 2016 16:21:02 +0000 (16:21 +0000)]
[EVENTVWR]
Don't hardcode a fixed size for the memory buffer holding the event details data to be copied into the clipboard, but instead compute it using the real lengths of the different strings. Use also StringCbPrintfW instead.

svn path=/trunk/; revision=72140

3 years ago[LSASRV]
Eric Kohl [Sat, 6 Aug 2016 15:07:41 +0000 (15:07 +0000)]
[LSASRV]
Implement LsarAddAccountRigths and fix some bugs along the way:
- LsarGetSystemAccessAccount: Fix an uninitialized varable.
- LsarOpenAccount, LsarCreateAccount: Make these functions wrappers around the real implementation in LsarpCreateAccount and LsarpOpenAccount.
- LsarEnumerateAccountRights: Fix the use of the wrong array index.
- LsarAddAccountRights: Implement it.
- LsarpLookupPrivilegeValue: Return a pointer to an LUID instead of an NTSTATUS. It is much earier to use it this way.
- LsapLookupAccountRightValue: Implement it.

svn path=/trunk/; revision=72139

3 years ago[NTOS:MM][USER32]
Thomas Faber [Sat, 6 Aug 2016 15:04:08 +0000 (15:04 +0000)]
[NTOS:MM][USER32]
- Correctly handle/avoid C99-style inline semantics
CORE-11794

svn path=/trunk/; revision=72138

3 years ago[WS2_32_NEW]
Thomas Faber [Sat, 6 Aug 2016 12:58:32 +0000 (12:58 +0000)]
[WS2_32_NEW]
- Fix always true conditions in ComputeQuerySetSize
CORE-11799

svn path=/trunk/; revision=72137

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 6 Aug 2016 12:25:47 +0000 (12:25 +0000)]
[FASTFAT]
Properly check for opened handles in subdirectories when we're about to rename a directory.
This helps reducing corruption where some renaming operations were allowed whereas they shouldn't have been.

CORE-11377
CORE-11426

svn path=/trunk/; revision=72136

3 years ago[SYSDM]
Thomas Faber [Sat, 6 Aug 2016 12:15:16 +0000 (12:15 +0000)]
[SYSDM]
- Less ambiguously check the return value of DialogBoxParam
CORE-11794

svn path=/trunk/; revision=72135

3 years ago[WIN32K:NTUSER]
Thomas Faber [Sat, 6 Aug 2016 12:07:54 +0000 (12:07 +0000)]
[WIN32K:NTUSER]
- Add some missing VOIDs
CORE-11799

svn path=/trunk/; revision=72134

3 years ago[INCLUDE/CRT] Correct _wctime and _wctime_s when _USE_32BIT_TIME_T is defined. CORE...
Amine Khaldi [Sat, 6 Aug 2016 10:35:53 +0000 (10:35 +0000)]
[INCLUDE/CRT] Correct _wctime and _wctime_s when _USE_32BIT_TIME_T is defined. CORE-11799

svn path=/trunk/; revision=72133

3 years ago[CRT] Correct some types. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 10:18:08 +0000 (10:18 +0000)]
[CRT] Correct some types. CORE-11799

svn path=/trunk/; revision=72132

3 years ago[WIN32DLLS] We don't need mingwex for these modules anymore. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 09:53:47 +0000 (09:53 +0000)]
[WIN32DLLS] We don't need mingwex for these modules anymore. CORE-11799

svn path=/trunk/; revision=72131

3 years ago[NTOS:MM] Add some missing VOIDs. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 09:34:39 +0000 (09:34 +0000)]
[NTOS:MM] Add some missing VOIDs. CORE-11799

svn path=/trunk/; revision=72130

3 years ago[DIRECTX/WINE] We don't need mingwex for these anymore. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 09:32:45 +0000 (09:32 +0000)]
[DIRECTX/WINE] We don't need mingwex for these anymore. CORE-11799

svn path=/trunk/; revision=72129

3 years ago[NTOS:PNPMGR] Mark IopReportTargetDeviceChangeAsyncWorker as stdcall and remove the...
Amine Khaldi [Sat, 6 Aug 2016 09:11:08 +0000 (09:11 +0000)]
[NTOS:PNPMGR] Mark IopReportTargetDeviceChangeAsyncWorker as stdcall and remove the PWORKER_THREAD_ROUTINE cast. CORE-11799

svn path=/trunk/; revision=72128

3 years ago[NTOS:MM]
Thomas Faber [Sat, 6 Aug 2016 09:07:03 +0000 (09:07 +0000)]
[NTOS:MM]
- Correctly check for overflow in PeFmtCreateSection
CORE-11794

svn path=/trunk/; revision=72127

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 6 Aug 2016 08:57:47 +0000 (08:57 +0000)]
[FASTFAT]
Don't mess with parentless FCB.
Dedicated to Thomas :-).

CORE-11377
CORE-11426

svn path=/trunk/; revision=72126

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 6 Aug 2016 08:32:17 +0000 (08:32 +0000)]
[FASTFAT]
Addendum to r72124

svn path=/trunk/; revision=72125

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 6 Aug 2016 08:30:30 +0000 (08:30 +0000)]
[FASTFAT]
Track child FCB in parent FCB to allow browsing them in case it's needed.
This allows fixing a FIXME and offering better performances when renaming a directory.

CORE-11377
CORE-11426

svn path=/trunk/; revision=72124

3 years ago[CALC] We don't need mingwex anymore. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 08:26:54 +0000 (08:26 +0000)]
[CALC] We don't need mingwex anymore. CORE-11799

svn path=/trunk/; revision=72123

3 years ago[NTDLL] Add missing VOID. CORE-11799
Amine Khaldi [Sat, 6 Aug 2016 08:18:11 +0000 (08:18 +0000)]
[NTDLL] Add missing VOID. CORE-11799

svn path=/trunk/; revision=72122

3 years ago[ARP]
Thomas Faber [Sat, 6 Aug 2016 07:57:51 +0000 (07:57 +0000)]
[ARP]
- Do not return failure after successful operations
CORE-11794

svn path=/trunk/; revision=72121

3 years ago[CMD][UXTHEME]
Thomas Faber [Sat, 6 Aug 2016 07:08:52 +0000 (07:08 +0000)]
[CMD][UXTHEME]
- Clarify misleading indentation
CORE-11794

svn path=/trunk/; revision=72120

3 years ago[CRT]
Thomas Faber [Sat, 6 Aug 2016 06:52:41 +0000 (06:52 +0000)]
[CRT]
- Apply Wine commit b7f6362d (msvcrt: Use the correct object type for __non_rtti_object exceptions.) by Alexandre Julliard
CORE-11794

svn path=/trunk/; revision=72119

3 years ago[CRT]
Thomas Faber [Fri, 5 Aug 2016 21:33:54 +0000 (21:33 +0000)]
[CRT]
- Remove pointless inline
CORE-11794

svn path=/trunk/; revision=72118

3 years ago[COMCTL32]: Addendum to r72116: Add the __REACTOS__ ifdefs to ease wine syncing,...
Hermès Bélusca-Maïto [Fri, 5 Aug 2016 17:45:34 +0000 (17:45 +0000)]
[COMCTL32]: Addendum to r72116: Add the __REACTOS__ ifdefs to ease wine syncing, and update the patch in accordance.
CORE-11532

svn path=/trunk/; revision=72117

3 years ago[COMCTL32]
Giannis Adamopoulos [Fri, 5 Aug 2016 17:16:22 +0000 (17:16 +0000)]
[COMCTL32]
- rebar: actually pass the hittest flag to the NM_NCHITTEST notification.
CORE-11532

svn path=/trunk/; revision=72116

3 years ago[FASTFAT_NEW]: Fix add_pch command usage.
Hermès Bélusca-Maïto [Fri, 5 Aug 2016 11:54:48 +0000 (11:54 +0000)]
[FASTFAT_NEW]: Fix add_pch command usage.

svn path=/trunk/; revision=72115

3 years ago[NET/USE]
Pierre Schweitzer [Fri, 5 Aug 2016 10:58:09 +0000 (10:58 +0000)]
[NET/USE]
Always delete remembered connections on /delete

ROSAPPS-303

svn path=/trunk/; revision=72114

3 years ago[FASTFAT]
Pierre Schweitzer [Fri, 5 Aug 2016 10:48:01 +0000 (10:48 +0000)]
[FASTFAT]
Refactor vfatMakeFCBFromDirEntry() and vfatUpdateFCB() so that they share code. It will help avoiding wild FCB modifications on renaming.

CORE-11377

svn path=/trunk/; revision=72113

3 years ago[EXPLORER]
Giannis Adamopoulos [Fri, 5 Aug 2016 09:06:30 +0000 (09:06 +0000)]
[EXPLORER]
- Fix subclassing the tasks toolbar which was broken in r65274.
CORE-11532

svn path=/trunk/; revision=72111

3 years ago[ATL][ATL_APITEST] Add implementation + tests for most functions from CPoint, CSize...
Mark Jansen [Thu, 4 Aug 2016 19:15:21 +0000 (19:15 +0000)]
[ATL][ATL_APITEST] Add implementation + tests for most functions from CPoint, CSize, CRect. CORE-11747 #resolve
Not all functions are implemented, the ones that are not implemented are left in a comment in the header.

svn path=/trunk/; revision=72110

3 years ago[INCLUDE/WINE] Update test.h with debug functions for POINT and SIZE.
Mark Jansen [Thu, 4 Aug 2016 19:11:50 +0000 (19:11 +0000)]
[INCLUDE/WINE] Update test.h with debug functions for POINT and SIZE.

svn path=/trunk/; revision=72109

3 years ago[MPR]
Pierre Schweitzer [Thu, 4 Aug 2016 12:27:59 +0000 (12:27 +0000)]
[MPR]
Check for the right capability.
Already sent upstream.

CORE-11757

svn path=/trunk/; revision=72108

3 years ago[MPR]
Pierre Schweitzer [Thu, 4 Aug 2016 12:25:51 +0000 (12:25 +0000)]
[MPR]
Add a missing break

svn path=/trunk/; revision=72107

3 years ago[SHELL32]: Fix copypasta bug.
Hermès Bélusca-Maïto [Wed, 3 Aug 2016 20:02:28 +0000 (20:02 +0000)]
[SHELL32]: Fix copypasta bug.

svn path=/trunk/; revision=72105

3 years ago[BROWSEUI] set min width for addressband to 100. patch by Katayama Hirofumi MZ CORE...
Christoph von Wittich [Wed, 3 Aug 2016 17:59:53 +0000 (17:59 +0000)]
[BROWSEUI] set min width for addressband to 100. patch by Katayama Hirofumi MZ CORE-11766

svn path=/trunk/; revision=72103

3 years ago[NtUser]
James Tabor [Wed, 3 Aug 2016 17:41:22 +0000 (17:41 +0000)]
[NtUser]
- Fix regression from r66350. See CORE-11324 for more details.

svn path=/trunk/; revision=72102

3 years ago[NTOS:SE]
Thomas Faber [Wed, 3 Aug 2016 17:10:59 +0000 (17:10 +0000)]
[NTOS:SE]
- Remove unnecessary null checks & fix up cleanup in SepCreateToken and SepDuplicateToken. Based on a patch by Víctor Martínez Calvo
CORE-11768 #resolve

svn path=/trunk/; revision=72101

3 years agoFix gcc build
Giannis Adamopoulos [Wed, 3 Aug 2016 15:55:58 +0000 (15:55 +0000)]
Fix gcc build

svn path=/trunk/; revision=72100

3 years ago[SHELL32]
Giannis Adamopoulos [Wed, 3 Aug 2016 15:52:27 +0000 (15:52 +0000)]
[SHELL32]
- CDesktopBrowser: Convert to an ATL CWindow class, remove unused fields and cleanup.

svn path=/trunk/; revision=72099

3 years ago[NET/USE]
Pierre Schweitzer [Wed, 3 Aug 2016 14:42:49 +0000 (14:42 +0000)]
[NET/USE]
In case an automatic drive letter assignment was asked (net use * REMOTE), print the mapping that was performed on success.

ROSAPPS-303

svn path=/trunk/; revision=72098

3 years ago[MPR]
Pierre Schweitzer [Wed, 3 Aug 2016 14:41:23 +0000 (14:41 +0000)]
[MPR]
Return the correct local name in case of automatic redirection.
Alreaedy sent upstream.

CORE-11757

svn path=/trunk/; revision=72097

3 years ago[FASTFAT]
Pierre Schweitzer [Wed, 3 Aug 2016 12:54:46 +0000 (12:54 +0000)]
[FASTFAT]
Fixes suggested by Thomas:
- Don't dereference cached data after unpinning
- Pin big enough data to read direntries

CORE-11377

svn path=/trunk/; revision=72096

3 years ago[WIN32K]
Hermès Bélusca-Maïto [Tue, 2 Aug 2016 16:02:54 +0000 (16:02 +0000)]
[WIN32K]
- Deduplicate NtUserScrollWindowEx / IntScrollWindowEx by making NtUserScrollWindowEx properly call IntScrollWindowEx instead.
- Fix potential memory leaks in failure paths in IntScrollWindowEx.

svn path=/trunk/; revision=72093

3 years ago[BROWSEUI] pass a full pidl to ILGetDisplayNameEx CORE-11458
Christoph von Wittich [Tue, 2 Aug 2016 14:52:08 +0000 (14:52 +0000)]
[BROWSEUI] pass a full pidl to ILGetDisplayNameEx CORE-11458

svn path=/trunk/; revision=72092

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 11:46:31 +0000 (11:46 +0000)]
[MPR]
Properly set local name in case of redirection for *A function calls.
Alreaedy sent upstream.

CORE-11757

svn path=/trunk/; revision=72091

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 10:21:24 +0000 (10:21 +0000)]
[MPR]
Misc fixes.
Already sent upstream (d'oh!)

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72090

3 years ago[HACKSSIGN]
Pierre Schweitzer [Tue, 2 Aug 2016 10:12:37 +0000 (10:12 +0000)]
[HACKSSIGN]
Drop hackssign app. It's now obsolete.
You served us well :-).

ROSAPPS-303

svn path=/trunk/; revision=72089

3 years ago[NET]
Pierre Schweitzer [Tue, 2 Aug 2016 10:10:25 +0000 (10:10 +0000)]
[NET]
Implement the "net use" usage of the net command.
This allows connecting remote resources to local system with assigning them a local name, to enumerate such connected resources and to delete them.

This obsoletes the hackssign application.

The implementation is a bit... raw. It is mainly here to demonstrate what's doable in ReactOS now. And to help using features we were lacking up to now.
For instance, you can make use of 'net use * \\vmware-host\Shared Folders\{YOURSHARE}' to assign a local letter to your VMware shared folders.

ROSAPPS-303

svn path=/trunk/; revision=72088

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 10:04:19 +0000 (10:04 +0000)]
[MPR]
Implement connected resources enumeration
To be sent upstream.

Patch 6/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72087