Mark Jansen [Thu, 27 Jul 2017 20:36:51 +0000 (20:36 +0000)]
[APPHELP] Use DbgPrint instead of OutputDebugString + fix SDBAPI_DEBUG_ALLOC
svn path=/trunk/; revision=75429
Hermès Bélusca-Maïto [Thu, 27 Jul 2017 19:08:55 +0000 (19:08 +0000)]
[ATL]: - Both the CAtlList class and its helper class CNode do not support copy construction. - Remove a redundant call to GetFreeNode().
CORE-13597
svn path=/trunk/; revision=75427
Thomas Faber [Thu, 27 Jul 2017 18:48:19 +0000 (18:48 +0000)]
[DLLS]
- Fix import order
- Remove unnecessary imports
svn path=/trunk/; revision=75426
Pierre Schweitzer [Thu, 27 Jul 2017 10:22:57 +0000 (10:22 +0000)]
[EXT2]
Import commits by Kaho Ng <ngkaho1234@gmail.com> from upstream:
-
b7657e5 Ext3Fsd: Introduce VCB_RO_COMPAT_READ_ONLY flag for struct VCB
-
e7c1142 Ext3Fsd: EXT4_FEATURE_INCOMPAT_64BIT is not supported
-
785943f Ext3Fsd: fix issue #6
Refuse mounting filesystems with incompatible flags. This avoids corrupting 64bits filesystems.
Patch by Lubomir Rintel
CORE-13589
svn path=/trunk/; revision=75422
Pierre Schweitzer [Thu, 27 Jul 2017 09:43:56 +0000 (09:43 +0000)]
[KERNEL32_VISTA]
Delay load NTDLL_vista, in order to save *380KB* at boot.
CORE-13361
svn path=/trunk/; revision=75421
Pierre Schweitzer [Thu, 27 Jul 2017 09:37:10 +0000 (09:37 +0000)]
[RDBSS]
- Misc fixes with DPRINTS
[RXCE]
- In RxFinalizeSrvOpen, always dereference the FCB, it's always referenced on SRV_OPEN creation
- Misc fixes with DPRINTS
With that revision and r75419, I'm now able to mount a NFS share, browse it, read a file from it, and unmount it.
We're OK regarding references counting!
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75420
Pierre Schweitzer [Thu, 27 Jul 2017 09:33:11 +0000 (09:33 +0000)]
[SHELL32]
Revert r75348.
Because of r75349, this revision was made useless, and even worse, it was leaking a handle to the directory where the FSD doesn't support notifications.
Also made some debug traces more useful
svn path=/trunk/; revision=75419
Benedikt Freisen [Thu, 27 Jul 2017 09:29:42 +0000 (09:29 +0000)]
[MSPAINT]
- Enable drag cancellation -- patch by Katayama Hirofumi MZ
CORE-13395 #resolve
svn path=/trunk/; revision=75418
Pierre Schweitzer [Wed, 26 Jul 2017 20:00:30 +0000 (20:00 +0000)]
[NFS]
Huge "hack" for ReactOS.
In case we're asked to unmount a NFS share, and there are still active FCBs, browse the prefix table for active NET_ROOT, and then, dump their associated FCBs (prefix + refcount).
It seems we only leak the root FCB.
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75415
Pierre Schweitzer [Wed, 26 Jul 2017 19:57:50 +0000 (19:57 +0000)]
[DDK]
Define RxIsFcbTableLockAcquired
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75414
Thomas Faber [Wed, 26 Jul 2017 14:49:35 +0000 (14:49 +0000)]
[ACPICA]
- Update to version
20170629
CORE-13538 #resolve
svn path=/trunk/; revision=75412
Pierre Schweitzer [Wed, 26 Jul 2017 09:55:30 +0000 (09:55 +0000)]
[COPYSUP]
Remove leftovers from some attempted ugly things.
Should fix MSVC build
svn path=/trunk/; revision=75410
Pierre Schweitzer [Wed, 26 Jul 2017 09:28:41 +0000 (09:28 +0000)]
[RDBSS]
- Implement RxFastIoWrite()
- Finish implementation of RxFastIoCheckIfPossible()
[COPYSUP]
- Implement FsRtlCopyWrite2()
This brings (in link with r75398 fast IO writes to RDBSS, and thus NFS!
CORE-8204
CORE-11327
svn path=/trunk/; revision=75409
James Tabor [Wed, 26 Jul 2017 02:52:00 +0000 (02:52 +0000)]
[NtUser]
- Broadcast the appropriate messages to notify a change in display parameters and color. This should fix rollback issues from setting display modes. See CORE-12571 and CORE-13212.
svn path=/trunk/; revision=75407
Giannis Adamopoulos [Tue, 25 Jul 2017 22:41:26 +0000 (22:41 +0000)]
[COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button will be implemented in a later commit as it caused me some problems.
svn path=/trunk/; revision=75406
David Quintana [Tue, 25 Jul 2017 18:12:33 +0000 (18:12 +0000)]
[FREELDR]
Fix compilation on ARM.
svn path=/trunk/; revision=75404
David Quintana [Tue, 25 Jul 2017 17:30:21 +0000 (17:30 +0000)]
[BOOTLIB]
[BOOTMGR]
Disabled x86-specific code when building ARM.
[LIBSUPP]
Use a hack to replace inline asm which is not supported by MSVC ARM.
[DBGHELP]
Fix ARM register access from context struct.
[MSVCRT]
Fix typo in spec file.
[NTOSKRNL]
[WIN32SS]
Add asm dependency to *sys modules.
[CPPRT]
Add one of the missing constructor aliases. There's more, but my brain is fried at this point.
[BTRFS]
Define-away an include for x86-specific intrinsics.
This is the first batch of fixes for building reactos using the MSVC ARM toolchain. A lot more work is needed to get a full build including rostests and rosapps.
svn path=/trunk/; revision=75403
Pierre Schweitzer [Tue, 25 Jul 2017 12:09:11 +0000 (12:09 +0000)]
[RDBSS]
- Implement RxCommonSetInformation(), RxpSetInfoMiniRdr(), RxSetBasicInfo()
- Stub RxSetAllocationInfo(), RxSetDispositionInfo(), RxSetEndOfFileInfo(), RxSetPipeInfo(), RxSetPositionInfo(), RxSetRenameInfo(), RxSetSimpleInfo()
CORE-8204
CORE-11327
svn path=/trunk/; revision=75402
Pierre Schweitzer [Tue, 25 Jul 2017 11:34:36 +0000 (11:34 +0000)]
[XDK]
Define FILE_ATTRIBUTE_INTEGRITY_STREAM
svn path=/trunk/; revision=75401
James Tabor [Mon, 24 Jul 2017 23:48:08 +0000 (23:48 +0000)]
[NtUser]
- Initialize rectangle to all zero's. See CORE-13582.
svn path=/trunk/; revision=75400
David Quintana [Mon, 24 Jul 2017 18:37:25 +0000 (18:37 +0000)]
[CABMAN]
Fix pointer math ('unsigned long' will truncate the pointer).
[MKISOFS/SCHILY TOOLS]
Fix the invalid assumption that a 'long' variable can hold pointers. Will be sent upstream.
With this the whole of reactos and rostests builds on x64. Rosapps still has issues.
svn path=/trunk/; revision=75399
Pierre Schweitzer [Mon, 24 Jul 2017 17:05:05 +0000 (17:05 +0000)]
[RDBSS]
- Implement __RxWriteReleaseResources(), RxCommonWrite(), RxCompleteMdl(), RxGetTopIrpIfRdbssIrp(), RxLowIoWriteShell(), RxLowIoWriteShellCompletion()
- Finish implementation of RxCommonCleanup() so that it handles setting EOF on a file
- Finish implementation of RxCommonCreate() so that it handles sharing violations and attempts to scavenge open files
[RXCE]
- Implement RxpScavengeFobxs(), RxpTrackDereference(), RxpTrackReference(), RxPurgeFobx(), RxPurgeRelatedFobxs(), RxReinitializeContext(), RxSetFileSizeWithLock(), RxScavengeFobxsForNetRoot()
- Fix a bug in RxPrefixTableLookupName() where it was badly handling nodes in scavenger
This commits brings several improvments to the NFS driver.
First of all, now, the driver handles creating, extending and writing to files!
It also handles purging dormant opened files when a file opening fails because of a sharing violation
Finally, it also brings something to look at our references issues in RDBSS to help finding out why our FCB are never (or nearly) dereferenced
CORE-8204
CORE-11327
CORE-13581
svn path=/trunk/; revision=75398
David Quintana [Mon, 24 Jul 2017 15:09:22 +0000 (15:09 +0000)]
[APITESTS]
MSVCRT_CRT_APITEST: Remove getmainargs tests from X64 build.
DELAYIMP: Fix callback prototype.
CComHeapPtr: Fix implementation of IMallocSpy to match the actual interface.
[WINETESTS]
ntdll: Disable 'generated' tests when not i386 platform, since they were generated for x86 and not x64 or ARM.
Fixes x64 compilation for tests.
svn path=/trunk/; revision=75397
David Quintana [Mon, 24 Jul 2017 15:08:16 +0000 (15:08 +0000)]
[BOOTLIB]
Stub out some arch-specific functions (fixes x64 build).
[USBPORT]
Actually fix x64 build. The old code was not working at all, but the bootlib errors cancelled the build earlier than I thought.
The X64 compilation now succeeds, but cabman crashes trying to generate the bootcd.
svn path=/trunk/; revision=75396
David Quintana [Mon, 24 Jul 2017 10:40:55 +0000 (10:40 +0000)]
[EXPLORER]
[RSHELL]
[NTOBJSHEX]
[BROWSEUI]
[SHELL32]
Get rid of the unused "placement new" operators.
svn path=/trunk/; revision=75394
David Quintana [Mon, 24 Jul 2017 10:37:53 +0000 (10:37 +0000)]
[USBPORT]
Oops, brainfart (Fixes 32bit build).
svn path=/trunk/; revision=75393
David Quintana [Mon, 24 Jul 2017 10:34:06 +0000 (10:34 +0000)]
[MSPAINT]
Correct callback return type (Fixes X64 build).
[USETUP]
Correct definition of the struct (fixes X64 build).
[USBPORT]
Improve struct size checks so they are X64-compatible (fixes X64 build).
The build as a whole still fails due to bootlib, but implementing those is beyond my expertise.
svn path=/trunk/; revision=75392
Mark Jansen [Sat, 22 Jul 2017 20:23:33 +0000 (20:23 +0000)]
[SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)
CORE-13426 #resolve #comment Thanks!
svn path=/trunk/; revision=75391
Mark Jansen [Sat, 22 Jul 2017 18:27:32 +0000 (18:27 +0000)]
[WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.
CORE-13567 #resolve #comment Thanks!
svn path=/trunk/; revision=75390
Giannis Adamopoulos [Sat, 22 Jul 2017 17:13:06 +0000 (17:13 +0000)]
[EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size and position of the taskbar but I add it back since it updates the cached rects for all four positions.
svn path=/trunk/; revision=75389
Mark Jansen [Sat, 22 Jul 2017 16:55:08 +0000 (16:55 +0000)]
[SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.
CORE-13428 #resolve #comment Thanks!
svn path=/trunk/; revision=75388
Hermès Bélusca-Maïto [Sat, 22 Jul 2017 15:54:40 +0000 (15:54 +0000)]
[UNATTEND]: Move a comment sign ';' to a better place.
svn path=/trunk/; revision=75387
Giannis Adamopoulos [Sat, 22 Jul 2017 09:13:33 +0000 (09:13 +0000)]
[EXPLORER] -Implement the minimum taskbar size for the vertical position.
svn path=/trunk/; revision=75386
Giannis Adamopoulos [Fri, 21 Jul 2017 14:32:15 +0000 (14:32 +0000)]
[BROWSEUI]
-CBandSite: Remove CCS_NORESIZE style. This is a hack probably needed because our rebar control is buggy.
[EXPLORER]
-CTaskBand::GetBandInfo: Use the toolbar button size as the minimum and integral size for the band.
-CTaskSwitchWnd: Use the system small icon size for the size of the icon. Recreate the image list if this size changes. This together with the size of the font are the only factors for the size of the toolbar and consequently for the size of the band and if it is the only band, the size of the taskbar. Don't use TB_SETBUTTONSIZE. Now the size of the image list and the font dictate the size.
-CTrayWindow: In the classic theme make the start button have the same height with the tasks toolbar button height. Improve the calculation of the size of the taskbar in FitToRebar.
These changes should make the taskbar and the toolbar have a proper size. On top of that the taskbar is finally resizable (however our rebar is too buggy and still fills only the first line in the taskbar). While testing this I noticed that moving the taskbar in the sides of the screen is buggy now. I'm not sure if this was uncovered by these changes, if this was broken before or this was caused by these changes (looks unlikely to me) but will be fixed in subsequent commits).
svn path=/trunk/; revision=75385
Sylvain Petreolle [Thu, 20 Jul 2017 21:32:16 +0000 (21:32 +0000)]
Revert r70669, it was a change in an unused 3rd party file.
CORE-10629
svn path=/trunk/; revision=75383
James Tabor [Thu, 20 Jul 2017 20:26:14 +0000 (20:26 +0000)]
[NtUser]
- Patch by Huw Davies : Explicitly set last error to ERROR_SUCCESS.
- Remove hack and added a note.
svn path=/trunk/; revision=75382
James Tabor [Thu, 20 Jul 2017 19:57:25 +0000 (19:57 +0000)]
[NtUser]
- Patch by Fabian Maurer : Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests.
svn path=/trunk/; revision=75381
James Tabor [Thu, 20 Jul 2017 19:46:17 +0000 (19:46 +0000)]
[NtUser]
- Patch by Alex Henrie : Tell MENU_SuspendPopup which message to remove.
svn path=/trunk/; revision=75380
James Tabor [Thu, 20 Jul 2017 19:40:17 +0000 (19:40 +0000)]
[NtUser]
- Remove unused code and reintegrate wine code.
svn path=/trunk/; revision=75379
Sylvain Petreolle [Wed, 19 Jul 2017 20:33:58 +0000 (20:33 +0000)]
Patch by Mike Swanson :
This adds support for Esperanto as a language and a keyboard layout based on the one from X.Org.
CORE-11021
svn path=/trunk/; revision=75378
Daniel Reimer [Wed, 19 Jul 2017 19:23:47 +0000 (19:23 +0000)]
[CAROOT]
Updates root CAs to recent ones.
svn path=/trunk/; revision=75377
Hervé Poussineau [Wed, 19 Jul 2017 09:19:11 +0000 (09:19 +0000)]
[SETUPAPI] Do not crash when encountering a device with HardwareIDs
svn path=/trunk/; revision=75374
Sylvain Petreolle [Tue, 18 Jul 2017 22:48:18 +0000 (22:48 +0000)]
[BDASUP]
Add digital TV tuning device driver to build.
svn path=/trunk/; revision=75372
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 21:30:20 +0000 (21:30 +0000)]
[REACTOS]: Russian translation update part 2/2 by amber: time-zones.
svn path=/trunk/; revision=75370
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 21:26:25 +0000 (21:26 +0000)]
[REACTOS]: Russian translation update part 1/2 by amber.
CORE-13248
svn path=/trunk/; revision=75369
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 20:55:34 +0000 (20:55 +0000)]
[CRT]: Add a missing _munlock call, caught by Serge Gautherie.
CORE-11568
svn path=/trunk/; revision=75368
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 17:17:22 +0000 (17:17 +0000)]
[CMD]: Update the description of the START command, with the commutators that are known to work.
Translators, please update the translations based on en-US!
svn path=/trunk/; revision=75366
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 16:11:18 +0000 (16:11 +0000)]
[MSVCRT][CRT]: Improvements/fixes over popen(), from Wine code and ported by Andreas Maier: the popen_handles array, which is used in _pclose, was never filled. _popen correctly fills it now.
Should fix returned codes by popen() and pclose(), which are functions that are called by windres, and this latter expects them to succeed. This was not the case before, in ROS, and therefore
trying to e.g. compile ROS within ROS failed from time to time with windres throwing the error that "preprocessing failed".
CORE-11568 #resolve
svn path=/trunk/; revision=75365
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 15:27:40 +0000 (15:27 +0000)]
[MSVCRT_APITEST]: Commit a simple test for popen(), by Andreas Maier.
CORE-11568
svn path=/trunk/; revision=75364
Hermès Bélusca-Maïto [Mon, 17 Jul 2017 12:47:18 +0000 (12:47 +0000)]
[RXCE]: Fix bug, thanks MSVC! (warning C4553)
svn path=/trunk/; revision=75363
Eric Kohl [Sun, 16 Jul 2017 21:48:30 +0000 (21:48 +0000)]
[NETAPI32]
DsAddressToSiteNamesExW: Remove dead code.
This bug was found by Christian Bosch. Thanks a lot!
svn path=/trunk/; revision=75362
Giannis Adamopoulos [Sun, 16 Jul 2017 15:13:02 +0000 (15:13 +0000)]
[SHELL32]
-CRegFolder: Implement CRegFolder::EnumObjects. Change its constructor to receive an extra parameter for the name of the key that should be enumerated.
-CEnumIDListBase: Add a new method called AppendItemsFromEnumerator to facilitate merging the contents from one IEnumIDList to another.
-Use the above in the enumerators of CControlPanelFolder, CDesktopFolder and CDrivesFolder to make them significantly simpler.
svn path=/trunk/; revision=75360
Mark Jansen [Sun, 16 Jul 2017 13:56:08 +0000 (13:56 +0000)]
[SHIMENG] Pass shim commandline to shims. CORE-11329
svn path=/trunk/; revision=75359
Mark Jansen [Sun, 16 Jul 2017 13:50:23 +0000 (13:50 +0000)]
[SHIMLIB] Add debug print functionality for shims. CORE-11329
svn path=/trunk/; revision=75358
Mark Jansen [Sun, 16 Jul 2017 13:47:16 +0000 (13:47 +0000)]
[ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
svn path=/trunk/; revision=75357
Mark Jansen [Sun, 16 Jul 2017 13:44:18 +0000 (13:44 +0000)]
[SHELL32] Do not dereference a nullpointer for logging. CORE-13552
svn path=/trunk/; revision=75356
Sylvain Petreolle [Sun, 16 Jul 2017 13:37:29 +0000 (13:37 +0000)]
Patch by Serge Gautherie:
[BOOTDATA]
hivesys.inf: Put 'Mup' service back in 'File System' group. (Fix r72450)
Fixes installation of Vmware Tools which was always hanging.
CORE-12107 #resolve
svn path=/trunk/; revision=75355
Pierre Schweitzer [Sat, 15 Jul 2017 11:41:24 +0000 (11:41 +0000)]
[RDBSS]
Complementary to r75353: implement RxCancelNotifyChangeDirectoryRequestsForFobx()
CORE-11327
svn path=/trunk/; revision=75354
Pierre Schweitzer [Sat, 15 Jul 2017 10:05:32 +0000 (10:05 +0000)]
[RDBSS]
Implement RxNotifyChangeDirectory(), RxLowIoNotifyChangeDirectoryCompletion(), RxCancelNotifyChangeDirectoryRequestsForVNetRoot()
This means the first parts of the directory watch are here. Though, NFS driver doesn't support these, but at least, it reduces the UNIMPLEMENTED spam!
CORE-11327
svn path=/trunk/; revision=75353
Giannis Adamopoulos [Sat, 15 Jul 2017 09:38:45 +0000 (09:38 +0000)]
[SHELL32] -Move CFSExtractIcon_CreateInstance to CFSFolder.cpp
svn path=/trunk/; revision=75352
Mark Jansen [Sat, 15 Jul 2017 09:24:30 +0000 (09:24 +0000)]
[USBPORT] Fix incorrect transfer direction for URBs. Patch by Vadim Galyant. CORE-13546
svn path=/trunk/; revision=75351
Giannis Adamopoulos [Sat, 15 Jul 2017 09:18:06 +0000 (09:18 +0000)]
[SHELL32]
- CDesktopFolder: Create the enumerators of the internal fs folders and add their items in its own list instead of calling CreateFolderEnumList which enumerates ... files.
- Remove CEnumIDListBase::CreateFolderEnumList and move its code to CFileSysEnum::Initialize.
svn path=/trunk/; revision=75350
Pierre Schweitzer [Sat, 15 Jul 2017 07:48:47 +0000 (07:48 +0000)]
[SHELL32]
In case a FSD doesn't support directory changes notifications, don't try to requeue a notification each time it returns 0 data.
Just quit instead.
CORE-13549
svn path=/trunk/; revision=75349
Pierre Schweitzer [Sat, 15 Jul 2017 07:45:28 +0000 (07:45 +0000)]
[SHELL32]
Avoid double-free and use-after-free in case the FSD fails to register the change directory notification
CORE-13549
svn path=/trunk/; revision=75348
James Tabor [Sat, 15 Jul 2017 03:58:42 +0000 (03:58 +0000)]
[ENG]
- Patch by Katayama Hirofumi MZ : Add counts to path data. See CORE-13536.
svn path=/trunk/; revision=75347
Hermès Bélusca-Maïto [Fri, 14 Jul 2017 22:17:12 +0000 (22:17 +0000)]
[USETUP]: Also adapt the INFCONTEXT structure here.
svn path=/trunk/; revision=75344
Hermès Bélusca-Maïto [Fri, 14 Jul 2017 22:15:48 +0000 (22:15 +0000)]
[INFLIB][FREELDR]: Introduce a (non-used) "CurrentInf" field in the INFCONTEXT structure, to make it compatible with the "standard" one defined in setupapi.h, so that it can be possible to either use our inflib or setupapi.dll in our code.
This will break build inside usetup, and this will be fixed in the next commit.
svn path=/trunk/; revision=75343
Mark Jansen [Fri, 14 Jul 2017 20:35:11 +0000 (20:35 +0000)]
[APPHELP_APITEST] Convert test_match_ex to a data driven test + fix a bug in the apitest.
svn path=/trunk/; revision=75342
Mark Jansen [Fri, 14 Jul 2017 20:05:27 +0000 (20:05 +0000)]
[SPOOLSS] Stub BuildOtherNamesFromMachineName as seen in wine commit
cdb5f35. This fixes a crash in spoolss:spoolss
svn path=/trunk/; revision=75341
Mark Jansen [Fri, 14 Jul 2017 19:29:34 +0000 (19:29 +0000)]
[APPCOMPAT] Various fixes.
- Simplify shimdbg output as suggested by Thomas
- Simplify media/sdb/sysmain.xml
- Fix some warnings + a debug print
svn path=/trunk/; revision=75340
Peter Hater [Fri, 14 Jul 2017 16:05:31 +0000 (16:05 +0000)]
[ADNS] Add function to return number of DNS servers available for query.
[DNSAPI] Use newly added function to return without search if no DNS servers are available.
CORE-13441 #resolve
svn path=/trunk/; revision=75339
Hermès Bélusca-Maïto [Fri, 14 Jul 2017 01:37:06 +0000 (01:37 +0000)]
[WIN32K]: Addendum to r75332 : fix variable usage without initialization error C4700 (certainly due to a copy-paste error), caught by MSVC compiler...
CORE-13536
svn path=/trunk/; revision=75337
Hermès Bélusca-Maïto [Fri, 14 Jul 2017 00:40:31 +0000 (00:40 +0000)]
[GETUNAME]: Translation update by Sergey Stopkin.
CORE-13222 #resolve
svn path=/trunk/; revision=75335
Hermès Bélusca-Maïto [Thu, 13 Jul 2017 20:50:49 +0000 (20:50 +0000)]
[CMAKE]: Correctly set valid PE image version numbers for the OS subsystem (GCC builds), and image and OS version numbers from the NT OS version ReactOS is based on.
svn path=/trunk/; revision=75333
James Tabor [Thu, 13 Jul 2017 19:34:49 +0000 (19:34 +0000)]
[Eng]
- Implement PATHOBJ_Xxx service routines, see CORE-13536.
svn path=/trunk/; revision=75332
James Tabor [Thu, 13 Jul 2017 17:30:15 +0000 (17:30 +0000)]
[NtGDI]
- Update path structure for future use.
svn path=/trunk/; revision=75329
James Tabor [Thu, 13 Jul 2017 01:59:41 +0000 (01:59 +0000)]
[Win32SS]
- Remove old GDI structure and use the new one.
svn path=/trunk/; revision=75326
Hermès Bélusca-Maïto [Thu, 13 Jul 2017 00:21:32 +0000 (00:21 +0000)]
[SHELL32]: Enable showing the sorting arrows in the sorting header column of shell folder listviews.
CORE-11776 #resolve
svn path=/trunk/; revision=75325
Hermès Bélusca-Maïto [Wed, 12 Jul 2017 22:16:50 +0000 (22:16 +0000)]
[WELCOME]: Diverse improvements:
- Compute once, when loading the list of topics with their associated commands, their special arguments or starting paths. The computed values can then be used each time a topic command is invoked.
- Distinguish between runnable commands (aka. external executables or files to be started), and internal actions like <msg> and <exit>.
- I have recently discovered that Windows' welcome.exe could also use a custom (OEM) "welcome.ini" file, much like what we already supported: see http://i.imgur.com/Se3IoQN.png .
To make ours backwards-compatible with Windows' one, rename the "Button" keyword into "MenuText", and introduce two new keywords "ConfigCommand" and "ConfigArgs" that specify respectively the command to be started
and its associated arguments. We continue to support our "Action" keyword for specifying internal actions.
- Improve the loading of the localized resources from the INI files.
- Correctly print the ReactOS version text, at a correct position depending on whether the checked box is display or not.
- Simplify some StringCchCopy + StringCchCat calls into StringCchPrintf.
- Simplify the code that creates the different fonts to be used within the program.
- Use more readable resource ID names.
svn path=/trunk/; revision=75322
Mark Jansen [Wed, 12 Jul 2017 18:40:49 +0000 (18:40 +0000)]
[WIN32SS] Fix EqualFamilyInfo function logic. Patch by Victor Martinez Calvo, modified by Katayama Hirofumi MZ.
CORE-13411 #resolve, CID
1411971
svn path=/trunk/; revision=75321
Giannis Adamopoulos [Wed, 12 Jul 2017 12:17:05 +0000 (12:17 +0000)]
[COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive.
svn path=/trunk/; revision=75320
Thomas Faber [Sun, 9 Jul 2017 21:05:58 +0000 (21:05 +0000)]
[USBPORT]
Patch by Vadim Galyant:
- Improve variable naming
- Make more consistent use of constants
svn path=/trunk/; revision=75314
Giannis Adamopoulos [Sun, 9 Jul 2017 20:57:01 +0000 (20:57 +0000)]
[EXPLORER]
- CTrayWindow: Implement the IContextMenu interface. This will be used by the CBandSite to query the context menu of its site (the CTrayWindow) and add it in its context menu.
- CTrayWindowCtxMenu: Use Shell_MergeMenus in QueryContextMenu and respect its parameters.
svn path=/trunk/; revision=75313
James Tabor [Sun, 9 Jul 2017 18:06:24 +0000 (18:06 +0000)]
[ENG]
- Turn on GradientFill apply small hack fix to keep it out of a loop.
- Turning code off does not fix the code, 8 years later!
svn path=/trunk/; revision=75312
Hermès Bélusca-Maïto [Sun, 9 Jul 2017 16:06:07 +0000 (16:06 +0000)]
[old_WORDPAD]: Fix typo (caught by user_trisquel).
svn path=/trunk/; revision=75311
Mark Jansen [Sun, 9 Jul 2017 15:06:49 +0000 (15:06 +0000)]
[FONTS] Add substitutes for the System font, and remove a hack for the System font. Patch by Katayama Hirofumi MZ. CORE-9222
svn path=/trunk/; revision=75310
Pierre Schweitzer [Sat, 8 Jul 2017 21:22:55 +0000 (21:22 +0000)]
[RDBSS]
Fix broken assignment.
Spotted by cppcheck.
svn path=/trunk/; revision=75309
Eric Kohl [Sat, 8 Jul 2017 21:07:29 +0000 (21:07 +0000)]
[NETAPI32]
- Add DsAddressToSiteNamesExA stub.
- Implement DsAddressToSiteNamesExW.
svn path=/trunk/; revision=75308
Pierre Schweitzer [Sat, 8 Jul 2017 17:12:33 +0000 (17:12 +0000)]
[RXCE]
- Define RxShouldPostCompletion() and use it
- Define RxIsResourceOwnershipStateExclusive() and use it
- Define some magic values
[RDBSS]
- Implement CheckForLoudOperations(), RxAdjustFileTimesAndSize(), RxIsOkToPurgeFcb()
- Continue implementation of RxCommonCleanup()
- Fix bugs in the RxCommonCleanup() implementation and make it more explicit when in the delete on close path
- Stub RxCleanupPipeQueues(), RxLowIoLockControlShell()
- Silent a few DPRINTs
CORE-8204
CORE-11327
svn path=/trunk/; revision=75307
Eric Kohl [Sat, 8 Jul 2017 12:00:44 +0000 (12:00 +0000)]
[NETAPI32]
- Add DsValidateSubnetNameA/W stubs.
- Move DsRoleFreeMemory to a better location.
[SDK/INCLUDE]
Add DsValidateSubnetNameA/W prototypes to dsgetdc.h.
svn path=/trunk/; revision=75306
Eric Kohl [Sat, 8 Jul 2017 09:11:22 +0000 (09:11 +0000)]
[NETAPI32]
- Add DsDeregisterDnsHostRecordsA stub.
- Implement DsDeregisterDnsHostRecordsW.
[SDK/INCLUDE]
Add DsDeregisterDnsHostRecordsA/W prototypes to dsgetdc.h.
svn path=/trunk/; revision=75305
Hermès Bélusca-Maïto [Sat, 8 Jul 2017 00:23:33 +0000 (00:23 +0000)]
Integrate the USERINIT changes r75295, r75302 and r75303 from the setup_improvements branch back to trunk.
svn path=/trunk/; revision=75304
Giannis Adamopoulos [Fri, 7 Jul 2017 20:34:27 +0000 (20:34 +0000)]
[SHELL32]
- Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks the logic that pidls should be read only by their shell folder. Also add an overload for SHELL32_CoCreateInitSF that makes it simpler to create a shell folder with a csidl.
- Add a SHELL32_BindToSF helper to share some logic that was duplicated in several shell folders.
- Move SHELL32_GetCustomFolderAttributeFromPath, SHELL32_GetCLSIDForDirectory and SHELL32_GetFSItemAttributes, SHELL32_BindToFS to CFSFolder.cpp as these were fs specific.
- These changes give finer control to shell folders for how the bind will be done and shares more logic that can be shared.
svn path=/trunk/; revision=75301
Eric Kohl [Fri, 7 Jul 2017 17:59:14 +0000 (17:59 +0000)]
[NETAPI32]
- Add DsMergeForestTrustInformationW stub.
- Implement DsGetForestTrustInformationW.
[SDK/INCLUDE]
Add DsGetSiteNameA/W, DsGetForestTrustInformationW and DsMergeForestTrustInformationW prototypes to dsgetdc.h.
svn path=/trunk/; revision=75300
James Tabor [Thu, 6 Jul 2017 19:13:49 +0000 (19:13 +0000)]
[NtGDI]
- Return Set if managed, part of CORE-12888.
svn path=/trunk/; revision=75294
James Tabor [Thu, 6 Jul 2017 19:06:29 +0000 (19:06 +0000)]
[NtUser]
- Part of CORE-13110. Set DC window rectangle and pointer.
svn path=/trunk/; revision=75293
James Tabor [Thu, 6 Jul 2017 18:52:22 +0000 (18:52 +0000)]
[Gdi32]
- Sync/Port Wine Enhanced/Metafile code. This is a fix for CORE-12888.
- Wine made this difficult to port and keep the whole file unchanged for syncing.
svn path=/trunk/; revision=75292
Giannis Adamopoulos [Wed, 5 Jul 2017 21:36:20 +0000 (21:36 +0000)]
[SHELL32] -Remove IShellView_Constructor and CDefView_Constructor. Use SHCreateShellFolderView and SHCreateShellFolderViewEx instead.
svn path=/trunk/; revision=75289
Colin Finck [Wed, 5 Jul 2017 15:29:13 +0000 (15:29 +0000)]
[PRINTING]
Apply a consistent style to all similar functions:
- Spoolss functions don't necessarily set ERROR_SUCCESS. Check the boolean return value instead and only query the error code on failure.
- Use AlignRpcPtr and UndoAlignRpcPtr wherever feasible.
- Use one static function per level that can be called from both Get* and Enum* APIs.
- Use PackStrings in all functions that return structures with strings.
- Add TRACEs to all non-static functions in localspl.
- Pass a double pointer to all Marshalling functions and advance to the next structure there.
- Perform sanity checks and return the right error codes in a Windows-compatible way.
- Return TRUE when an Enum* API has no elements to enumerate.
Also fixes CORE-12793
svn path=/trunk/; revision=75287
Pierre Schweitzer [Wed, 5 Jul 2017 06:11:10 +0000 (06:11 +0000)]
[RXCE]
- Implement RxFinalizeConnection(), RxOrphanSrvOpens()
- Stub RxOrphanSrvOpensForThisFcb()
[RDBSS]
- Fix a bug in RxCommonDevFCBClose() where prefix table wasn't acquire exclusively; this was problematic due to potential prefix table removal on dereference
- Stub RxCancelNotifyChangeDirectoryRequestsForVNetRoot()
This commit basically allows you to delete a NFS share you would have made use of in ReactOS.
Like net use z: \\share\path can be deleted through net use /delete z:
Note that if you access the share using cmd tools (dir, copy, more, and so on), dismount will work.
If you attempt to access with Explorer, then, handles will be kept open and dismount will fail.
CORE-8204
CORE-11327
svn path=/trunk/; revision=75286