Pierre Schweitzer [Tue, 4 Dec 2018 18:12:06 +0000 (19:12 +0100)]
[NTOSKRNL] Use the appropriated security descriptor when creating a device
CORE-9176
Pierre Schweitzer [Tue, 4 Dec 2018 18:10:40 +0000 (19:10 +0100)]
[NTOSKRNL] Implement IopCreateDefaultDeviceSecurityDescriptor() and IopCreateSecurityDescriptorPerType()
CORE-9176
Luo Yufan [Tue, 4 Dec 2018 16:13:39 +0000 (00:13 +0800)]
[TRANSLATION] Update Simplified Chinese translation. (#1094)
Eric Kohl [Sun, 2 Dec 2018 14:53:22 +0000 (15:53 +0100)]
[SETUPAPI] GetDeviceInstanceKeyPath: Trying to open the hardware key opens the software key and vice versa. Fix it by swapping the code paths.
Mark Jansen [Mon, 3 Dec 2018 19:46:31 +0000 (20:46 +0100)]
[KERNEL32] Revert
d897e27, which would re-initialized a list.
Spotted by Andrew Boyarshin.
Luo Yufan [Mon, 3 Dec 2018 05:01:56 +0000 (13:01 +0800)]
[MSGINA] Update Simplified Chinese translation.
Luo Yufan [Mon, 3 Dec 2018 04:56:01 +0000 (12:56 +0800)]
[IEFRAME] Update Simplified Chinese translation.
Luo Yufan [Mon, 3 Dec 2018 04:52:10 +0000 (12:52 +0800)]
[SHELL32] Update Simplified Chinese translation.
Katayama Hirofumi MZ [Mon, 3 Dec 2018 04:38:09 +0000 (13:38 +0900)]
[SHELL32] Don't show taskbar button of Folder Options (#1091)
CORE-10481
Katayama Hirofumi MZ [Sun, 2 Dec 2018 20:43:21 +0000 (05:43 +0900)]
careless s/E_FAIL/FALSE/ (#1089)
Katayama Hirofumi MZ [Sun, 2 Dec 2018 20:38:36 +0000 (05:38 +0900)]
[SHELL32] Follow up of #1085 (#1088)
CORE-10481
Katayama Hirofumi MZ [Sun, 2 Dec 2018 19:26:15 +0000 (04:26 +0900)]
[USER32] Fix Task Switcher (#1086)
CORE-10481
Katayama Hirofumi MZ [Sun, 2 Dec 2018 19:25:46 +0000 (04:25 +0900)]
[SHELL32] Don't show taskbar button of file property sheet (#1085)
CORE-10481
Eric Kohl [Sun, 2 Dec 2018 13:10:25 +0000 (14:10 +0100)]
[SETUPAPI] Implement SetupGetNonInteractiveMode() and SetupSetNonInteractiveMode().
Katayama Hirofumi MZ [Sun, 2 Dec 2018 09:51:44 +0000 (18:51 +0900)]
[USER32] Add Ghost window class (#1082)
CORE-11944
Eric Kohl [Sat, 1 Dec 2018 21:03:17 +0000 (22:03 +0100)]
[NET] NET HLPMSG: Fill inserts with '***' and print a proper error message if the desired message could not be found.
Pierre Schweitzer [Sat, 1 Dec 2018 20:50:54 +0000 (21:50 +0100)]
[NTFS] Don't perform overzealous checks on bitmap while reading a directory
This avoids partial direactory reads where we believe they are corrupted
while they are not.
Eric Kohl [Sat, 1 Dec 2018 16:11:51 +0000 (17:11 +0100)]
[NET] NET HELPMSG: Add support for network message from netmsg.dll.
Eric Kohl [Sat, 1 Dec 2018 14:14:27 +0000 (15:14 +0100)]
[MC] Add messages 5770-5809 to netmsg.dll.
Netmsg.dll is complete! Translations welcome!
Pierre Schweitzer [Sat, 1 Dec 2018 13:49:00 +0000 (14:49 +0100)]
[IPHLPAPI] Implement GetOwnerModuleFromUdpEntry()
Eric Kohl [Sat, 1 Dec 2018 12:35:47 +0000 (13:35 +0100)]
[MC] Add messages 5150-5296 to netmsg.dll.
Joachim Henze [Sat, 1 Dec 2018 13:26:33 +0000 (14:26 +0100)]
[BROWSEUI] Properly fix CORE-13003 "Explorer address bar display problem"
The patches author is Doug Lyons. Thank you very much!
The patch is an addendum to 0.4.9-dev-732-g
ea0cc1c7831dbe7dec31f4f495befb5dfa90ab5c
Eric Kohl [Sat, 1 Dec 2018 11:55:26 +0000 (12:55 +0100)]
[MC] Add messages 5000-5104 to netmsg.dll.
Katayama Hirofumi MZ [Sat, 1 Dec 2018 11:59:07 +0000 (20:59 +0900)]
[WIN32SS] Add IntGoGhost function (stub) (#1081)
CORE-11944
Pierre Schweitzer [Sat, 1 Dec 2018 11:15:31 +0000 (12:15 +0100)]
[LIBTIRPC] Fix CVE-2018-14621 by backporting its fix
CORE-15407
Eric Kohl [Sat, 1 Dec 2018 10:35:03 +0000 (11:35 +0100)]
[MC] Add messages 4930-4999 to netmsg.dll.
Katayama Hirofumi MZ [Sat, 1 Dec 2018 09:58:43 +0000 (18:58 +0900)]
[INCLUDE] Update winxx.h and msgdump.h (#1083)
Eric Kohl [Fri, 30 Nov 2018 22:58:21 +0000 (23:58 +0100)]
[MC] Add messages 4800-4862 to netmsg.dll.
Hermès Bélusca-Maïto [Fri, 30 Nov 2018 20:45:36 +0000 (21:45 +0100)]
[XOLEHLP] Import xolehlp.dll from Wine(-Staging) 3.21.
Should help improving the situation of the Microsoft SQL Server 2005
Express Edition installer. CORE-15399
Hermès Bélusca-Maïto [Fri, 30 Nov 2018 20:44:21 +0000 (21:44 +0100)]
[SDK] Add transact.idl, txcoord.idl and txdtc.idl, and introduce MS-PSDK-compatible adsiid library that defines GUIDs used by ADS interfaces.
Pierre Schweitzer [Fri, 30 Nov 2018 19:05:11 +0000 (20:05 +0100)]
[IPHLPAPI] Don't assume first member of MIB tables is always DWORD-big
This fixes last bits of heap corruption when using UDP/TCP enumeration
functions.
Pierre Schweitzer [Fri, 30 Nov 2018 18:42:38 +0000 (19:42 +0100)]
[IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations
Furthermore, memory was improperly allocated before (alignment issues) leading to heap
corruption under certain circumstances
Stanislav Motylkov [Fri, 30 Nov 2018 13:55:29 +0000 (16:55 +0300)]
[SYSDM] Explicitly check DMI strings for NULL pointers
...to make CRT string comparison functions happy. CORE-15403
Andrew Boyarshin [Sun, 25 Nov 2018 07:45:16 +0000 (14:45 +0700)]
[SDK] Allow use of SYSTEM_MEMORY_LIST_INFORMATION in kernel code
Eric Kohl [Thu, 29 Nov 2018 20:26:44 +0000 (21:26 +0100)]
[MC] Add messages 4700-4778 to netmsg.dll.
Pierre Schweitzer [Thu, 29 Nov 2018 19:28:06 +0000 (20:28 +0100)]
[IPHLPAPI] Implement GetOwnerModuleFromTcpEntry()
CORE-4792
Pierre Schweitzer [Thu, 29 Nov 2018 18:58:36 +0000 (19:58 +0100)]
[IPHLPAPI_APITEST] Add tests for GetOwnerModuleFromTcpEntry()
Pierre Schweitzer [Thu, 29 Nov 2018 18:31:07 +0000 (19:31 +0100)]
[SDK] Move TCPIP_OWNER_MODULE_BASIC_INFO definition to the right file
Pierre Schweitzer [Thu, 29 Nov 2018 07:42:13 +0000 (08:42 +0100)]
[IPHLPAPI_APITEST] Test GetExtendedTcpTable rather than AllocateAndGetTcpExTable2FromStack
Pierre Schweitzer [Thu, 29 Nov 2018 07:16:46 +0000 (08:16 +0100)]
[SDK] Define TCPIP_OWNER_MODULE_BASIC_INFO
Eric Kohl [Wed, 28 Nov 2018 22:11:20 +0000 (23:11 +0100)]
[MC] Add messages 4600-4699 to netmsg.dll.
Giannis Adamopoulos [Wed, 28 Nov 2018 06:41:09 +0000 (08:41 +0200)]
[REGTEST.CMD] Start tests with the correct current dir
Pierre Schweitzer [Wed, 28 Nov 2018 07:26:55 +0000 (08:26 +0100)]
[IPHLPAPI_APITEST] CurrPorts seems to confirm that timestamp is really a timestamp
Pierre Schweitzer [Tue, 27 Nov 2018 22:11:06 +0000 (23:11 +0100)]
[IPHLPAPI] Implement the *_TABLE_OWNER_MODULE_* in GetExtendedTcp/UdpTable() functions
This fixes CurrPorts in ReactOS. It now properly displays current connections along
with their creation time.
CORE-10134
Pierre Schweitzer [Tue, 27 Nov 2018 21:57:30 +0000 (22:57 +0100)]
[IPHLPAPI] Fix broken size computation leading to buffer overrun
Pierre Schweitzer [Tue, 27 Nov 2018 21:38:21 +0000 (22:38 +0100)]
[IPHLPAPI] Implement getOwnerModUdpTable() and getOwnerModTcpTable()
These allow to enumerate UDP and TCP connections with module information
Pierre Schweitzer [Tue, 27 Nov 2018 21:27:45 +0000 (22:27 +0100)]
[TCPIP] Stubplement returning module information for TCP and UDP connections
Eric Kohl [Tue, 27 Nov 2018 21:55:22 +0000 (22:55 +0100)]
[MC] Add messages 4450-4580 to netmsg.dll.
Pierre Schweitzer [Tue, 27 Nov 2018 20:25:23 +0000 (21:25 +0100)]
[IPHLPAPI_APITEST] Add tests for AllocateAndGetTcpExTable2FromStack()
Pierre Schweitzer [Tue, 27 Nov 2018 19:31:38 +0000 (20:31 +0100)]
[SDK] Add AllocateAndGetTcp/UdpEx/2TableFromStack() functions family
Pierre Schweitzer [Tue, 27 Nov 2018 19:15:34 +0000 (20:15 +0100)]
[SDK] Add a non documenter TOIID used to query modules information
Pierre Schweitzer [Tue, 27 Nov 2018 07:35:49 +0000 (08:35 +0100)]
[TCPIP] Save the date when an ADDRESS_FILE is created
Pierre Schweitzer [Tue, 27 Nov 2018 07:27:00 +0000 (08:27 +0100)]
[TCPIP] Define a enum to select which information to return
Giannis Adamopoulos [Sat, 27 Oct 2018 08:53:56 +0000 (11:53 +0300)]
[SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240
Giannis Adamopoulos [Sat, 24 Nov 2018 17:41:42 +0000 (19:41 +0200)]
[BROWSEUI] CShellBrowser: Don't pass any parameters to Initialize. Let users use the BrowseObject method instead.
Giannis Adamopoulos [Sat, 24 Nov 2018 17:26:14 +0000 (19:26 +0200)]
[FILEBROWSER]
In the struct passed to SHCreateFromDesktop the fourth field is the parameter that later on will be passed to ShowWindow. Initialize it properly so that when we run filrbrowser.exe in win2k3 the main window won't be hidden.
Giannis Adamopoulos [Fri, 23 Nov 2018 17:50:42 +0000 (19:50 +0200)]
[EXPLORER]
-Rename StartMenuBtnCtxMenuCreator to CStartMenuBtnCtxMenu_CreateInstance.
-Rename CreateStartMenuSite to CStartMenuSite_CreateInstance.
-Remove a couple of definitions that were not used.
Giannis Adamopoulos [Sun, 25 Nov 2018 18:13:56 +0000 (20:13 +0200)]
[WINSRV] Wait for the process to exit after calling NtTerminateProcess
NtTerminateProcess just queues an apc in every thread of the target process which in turn kills each thread. We need to wait so that all processes have enough time to exit before shutting down.
Pierre Schweitzer [Mon, 26 Nov 2018 21:41:25 +0000 (22:41 +0100)]
[IPHLPAPI] Start handling certain flags in GetAdaptersAddresses()
For now, we only support the most useful ones: IP_ADAPTER_DDNS_ENABLED,
IP_ADAPTER_REGISTER_ADAPTER_SUFFIX, IP_ADAPTER_DHCP_ENABLED
Eric Kohl [Mon, 26 Nov 2018 20:07:34 +0000 (21:07 +0100)]
[MC] Add messages 4400-4440 to netmsg.dll.
Luo Yufan [Mon, 26 Nov 2018 14:55:57 +0000 (22:55 +0800)]
[INETCFG] Update Simplified Chinese translation. (#1076)
Eric Kohl [Sun, 25 Nov 2018 21:39:47 +0000 (22:39 +0100)]
[NETAPI32] Implement DsGetDcNameA/W --> DsGetDcNameWithAccountA/W --> DsrGetDcNameEx2.
Eric Kohl [Sun, 25 Nov 2018 21:18:39 +0000 (22:18 +0100)]
[MC] Add messages 4350-4399 to netmsg.dll.
Mark Jansen [Sun, 18 Nov 2018 17:17:16 +0000 (18:17 +0100)]
Mark Jansen [Tue, 20 Nov 2018 21:34:05 +0000 (22:34 +0100)]
[APISETS] Teach update.py how to generate a manifest
Mark Jansen [Sun, 18 Nov 2018 17:16:19 +0000 (18:16 +0100)]
[APISETS] Stubplement versioned forwarders
Pierre Schweitzer [Sun, 25 Nov 2018 17:03:34 +0000 (18:03 +0100)]
[IPHLPAPI] In GetAdaptersAddresses(), return friendly name if asked for
Hermès Bélusca-Maïto [Sun, 25 Nov 2018 16:21:00 +0000 (17:21 +0100)]
[HAL] Update the PCI hardware IDs database.
Extracted from the pci.ids database at https://pci-ids.ucw.cz/ from 2018-11-21 03:15:02 .
Maintained by Albert Pool, Martin Mares, Michal Vaner, and other volunteers from the PCI ID Project.
Hermès Bélusca-Maïto [Sun, 25 Nov 2018 16:01:54 +0000 (17:01 +0100)]
[FREELDR] Check for any user keypress in menu even when the timeout is zero.
Before taking any default action if there is no timeout, check whether
the supplied key filter callback function may handle a specific user
keypress. If it does, the menu timeout is cancelled.
This allows e.g. handling F8 press for displaying boot options even when
the timeout is zero.
CORE-14046
Eric Kohl [Sun, 25 Nov 2018 14:41:04 +0000 (15:41 +0100)]
[MC] Add messages 4300-4349 to netmsg.dll.
Hermès Bélusca-Maïto [Mon, 12 Nov 2018 23:13:45 +0000 (00:13 +0100)]
[SETUPLIB] Re-enable the filesystem detection code based on recognition by FSDs.
Hermès Bélusca-Maïto [Fri, 16 Nov 2018 02:02:28 +0000 (03:02 +0100)]
[SETUPLIB] Dismount a disk partition before deleting it.
Andrew Boyarshin [Sun, 25 Nov 2018 13:31:23 +0000 (20:31 +0700)]
[WIN32K][NTUSER] Specify constant name explicitly (#1067)
Reduce confusion by specifying the omitted constant HWND_TOP == 0.
Andrew Boyarshin [Sun, 25 Nov 2018 13:31:04 +0000 (20:31 +0700)]
[WIN32K][NTUSER] Tiny codestyle fix to NtUserLockWindowUpdate (#1066)
Fix indentation (inconsistent with the rest of the file) and return actual BOOL.
Andrew Boyarshin [Sun, 25 Nov 2018 13:28:45 +0000 (20:28 +0700)]
Add .vscode folder to .gitignore file (#1060)
Matching the existence of Eclipse CDT ignore rules, .vscode should also be added to .gitignore
Visual Studio Code is always eager to create settings.json file there.
Pierre Schweitzer [Sun, 25 Nov 2018 12:32:52 +0000 (13:32 +0100)]
[IPHLPAPI] Implement AllocateAndGetUdpExTable2FromStack()
CORE-14391
Pierre Schweitzer [Sun, 25 Nov 2018 12:29:26 +0000 (13:29 +0100)]
[IPHLPAPI] Implement AllocateAndGetTcpExTable2FromStack()
CORE-14391
Pierre Schweitzer [Sun, 25 Nov 2018 11:23:27 +0000 (12:23 +0100)]
[IPHLPAPI] Implement AllocateAndGetUdpExTableFromStack()
Pierre Schweitzer [Sun, 25 Nov 2018 11:19:44 +0000 (12:19 +0100)]
[IPHLPAPI] Implement AllocateAndGetTcpExTableFromStack()
Andrew Boyarshin [Sun, 25 Nov 2018 10:31:12 +0000 (17:31 +0700)]
[NTOS:IO] Tiny improvement to debug message
Add quotes around string, since it is often empty, thus confusing in log.
Bernhard Feichtinger [Tue, 13 Nov 2018 19:52:30 +0000 (20:52 +0100)]
[OPENGL32] Fix wglDescribePixelFormat
Bernhard Feichtinger [Tue, 13 Nov 2018 19:45:27 +0000 (20:45 +0100)]
[NTOS:MM] Handle unimplemeted case for MiCheckForUserStackOverflow
Pierre Schweitzer [Sun, 25 Nov 2018 09:40:53 +0000 (10:40 +0100)]
[VFATLIB] Drop a hack no longer needed after
f87d9ca
Eric Kohl [Sat, 24 Nov 2018 23:27:44 +0000 (00:27 +0100)]
[MC] Add messages 5730-5769 to netmsg.dll.
Pierre Schweitzer [Sun, 25 Nov 2018 08:32:30 +0000 (09:32 +0100)]
[TCPIP] In InfoTdiQueryGetConnectionTcpTable(), only return if there's a connection
Hermès Bélusca-Maïto [Sat, 24 Nov 2018 21:36:32 +0000 (22:36 +0100)]
[NTOS:IO] Finally remove the dreadful IopParseDevice() hack! \o/
Hermès Bélusca-Maïto [Sun, 11 Nov 2018 16:17:48 +0000 (17:17 +0100)]
[FASTFAT] Improvements for volume dismount + minor bugfixing.
- Cache the RootFcb so that its cleanup can be handled separately
during dismounting.
- Force volume dismount at cleanup if the VCB_DISMOUNT_PENDING flag
is set.
- Actually dismount a volume if its VCB has been flagged as not good,
or if we force dismounting.
NOTE: In their *CheckForDismount() function, our 3rd-party FS drivers
as well as MS' fastfat, perform a comparison check of the current VCB's
VPB ReferenceCount with some sort of "dangling"/"residual" open count.
It seems to be related to the fact that the volume root directory as
well as auxiliary data stream(s) are still opened, and only these are
allowed to be opened at that moment. After analysis it appears that for
the ReactOS' fastfat, this number is equal to "3".
- On dismounting, cleanup and destroy the RootFcb, VolumeFcb and the
FATFileObject. Then cleanup the SpareVPB or the IoVPB members, and
finish by removing the dismounted volume from the VolumeListEntry
and cleaning up the notify synchronization object and the resources.
- During dismounting, and on shutdown, flush the volume before
resetting its dirty bit.
- On shutdown, after volume flushing, try to unmount it without forcing.
- Release the VCB resources only when we actually dismount the volume
in VfatCheckForDismount().
- Initialize first the notify list and the synchronization object,
before sending the FSRTL_VOLUME_MOUNT notification.
- If we failed at mounting a volume but its VCB's FATFileObject was
already initialized, first call CcUninitializeCacheMap() on it
before dereferencing it.
- Send FSRTL_VOLUME_LOCK, FSRTL_VOLUME_LOCK_FAILED and
FSRTL_VOLUME_UNLOCK notifications during volume locking (and failure)
and volume unlocking.
- Flush the volume before locking it, and clean its dirty bit if needed.
NOTE: In addition to checking for VCB_CLEAR_DIRTY, we also check for the
presence of the VCB_IS_DIRTY flag before cleaning up the dirty bit: this
allows us to not re-clean the bit if it has been previously cleaned.
This is needed for instance in this scenario:
- The volume is locked (it gets flushed and the dirty bit is possibly cleared);
- The volume then gets formatted with a completely different FS, that
possibly clears up the first sector (e.g. BTRFS ignores 1st sector);
- The volume is then dismounted: if we didn't check whether VCB_IS_DIRTY
was set prior to resetting it, we could attempt clearing it again! But
now that the volume's filesystem has been completely changed, we would
then try to modify the dirty bit on an erroneous position on disk!
That's why it should not be touched in this case during dismounting.
- The volume is unlocked (same comment as above), and later can be
detected as being BTRFS.
Eric Kohl [Sat, 24 Nov 2018 21:21:04 +0000 (22:21 +0100)]
[PSDK] Add missing NELOG_ error codes to lmerrlog.h.
Pierre Schweitzer [Sat, 24 Nov 2018 21:25:32 +0000 (22:25 +0100)]
[TCPIP] Properly display local information for established connections
Eric Kohl [Sat, 24 Nov 2018 14:12:09 +0000 (15:12 +0100)]
[MC] Add message 5300-5381 to netmsg.dll.
Pierre Schweitzer [Sat, 24 Nov 2018 21:00:09 +0000 (22:00 +0100)]
[RDBSS] Fix a typo
Spotted by Hermès
Pierre Schweitzer [Sat, 24 Nov 2018 20:36:00 +0000 (21:36 +0100)]
[NETSTAT] Add support for displaying UDP connections owning process
Our netstat can basically look like this now:
https://twitter.com/HeisSpiter/status/
1066430887208919040
Pierre Schweitzer [Sat, 24 Nov 2018 20:30:28 +0000 (21:30 +0100)]
[SDK] Add GetExtendedUdpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 20:25:59 +0000 (21:25 +0100)]
[IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 20:22:42 +0000 (21:22 +0100)]
[IPHLPAPI] Implement GetExtendedUdpTable()
We only support IPv4 and UDP_TABLE_BASIC, UDP_TABLE_OWNER_PID
for now
CORE-5126
Pierre Schweitzer [Sat, 24 Nov 2018 20:12:44 +0000 (21:12 +0100)]
[IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 20:09:17 +0000 (21:09 +0100)]
[TCPIP] Implement enumerating UDP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 20:04:20 +0000 (21:04 +0100)]
[NETSTAT] Add support for displaying TCP connections owning process
Pierre Schweitzer [Sat, 24 Nov 2018 19:41:16 +0000 (20:41 +0100)]
[IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 19:34:20 +0000 (20:34 +0100)]
[IPHLPAPI] Don't leak memory