Thomas Faber [Thu, 18 Apr 2019 05:41:50 +0000 (07:41 +0200)]
[NTOS:PNP] Reduce the size of the pool buffer in IopGetParentIdPrefix. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:31:34 +0000 (10:31 +0200)]
[NTOS:CM] Reduce the size of some unnecessarily large stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:25:52 +0000 (10:25 +0200)]
[NTOS:CM] Simplify CmpGetRegistryPath to avoid unnecessary stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 07:37:37 +0000 (09:37 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpCmdHiveOpen. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 10:10:23 +0000 (12:10 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpAddToHiveFileList. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 06:25:23 +0000 (08:25 +0200)]
[NTOS] Use correct buffer size when calling MiResolveImageReferences. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 14:04:37 +0000 (15:04 +0100)]
[NTOS:PNP] Avoid a fixed-length stack buffer in IopActionConfigureChildServices. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 13:47:59 +0000 (14:47 +0100)]
[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 09:44:46 +0000 (10:44 +0100)]
[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882
Pierre Schweitzer [Sun, 5 May 2019 08:12:59 +0000 (10:12 +0200)]
[KERNEL32] Reduce QueryDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
Pierre Schweitzer [Sun, 5 May 2019 07:25:34 +0000 (09:25 +0200)]
[KERNEL32] Reduce DefineDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
Hermès Bélusca-Maïto [Sat, 4 May 2019 23:10:39 +0000 (01:10 +0200)]
[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
CORE-13182 CORE-13196
- Use the correct character height & width.
- Additions: use StringCch*() when initializing the dialog title.
[CONSRV:CONCFG] Minor fixes.
- When retrieving font characteristics in ConCfgReadUserSettings(),
check for NULL/zero values that indicate that we should use default
ones instead.
- Rename 'dwNumSubKeys' into 'dwNumValues'.
Eric Kohl [Sat, 4 May 2019 21:13:28 +0000 (23:13 +0200)]
[MC] Add message tranlations. Supplement to
3acec58f.
Eric Kohl [Sat, 4 May 2019 19:08:27 +0000 (21:08 +0200)]
[NET] Replace remaining strings of the NET ACCOUNTS command by messages
Pierre Schweitzer [Fri, 3 May 2019 10:13:51 +0000 (12:13 +0200)]
[ROSAUTOTEST] Don't disallow buffering for journal file
This fixes back journal in ReactOS "at low costs". Indeed,
because write are improperly aligned right now, journaling
just fails.
With that patch, Cc will take care of aligning writes and
journal will be written again. Because flush operations
happen at each and every write to the journal, we expect
changes to land on disk quickly (not as quickly as if
they were directly written). But that's a good trade off
between over engineering and fixing a broken feature.
CORE-15973
Pierre Schweitzer [Sat, 4 May 2019 08:57:33 +0000 (10:57 +0200)]
[AUTOCHK] Don't check any volume on boot
This will avoid triggering a FAT repair on
unclean FAT volumes.
If dosfstools.fsck works fine in Linux, its
usage on ReactOS triggers worse corruption
than unclean shutdown.
Given I've no time for debugging this, I
kill it off.
CORE-14638
Katayama Hirofumi MZ [Sat, 4 May 2019 01:07:24 +0000 (10:07 +0900)]
[WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP
Katayama Hirofumi MZ [Sat, 4 May 2019 00:56:09 +0000 (09:56 +0900)]
[WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0)
Mark Jansen [Wed, 1 May 2019 20:48:08 +0000 (22:48 +0200)]
[APPSHIM_APITEST] Fix 2k3 test failures
jimtabor [Thu, 2 May 2019 19:33:07 +0000 (14:33 -0500)]
[HIDParser] Fix MSVC build
Attempt to fix build for MSVC.
This effected local build GCC system with newer Ninja version. Not sure
if this has an effect.
Eric Kohl [Thu, 2 May 2019 18:21:32 +0000 (20:21 +0200)]
[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState.
Hervé Poussineau [Sat, 27 Apr 2019 12:17:10 +0000 (14:17 +0200)]
[HID] Use hidparser static library for HidP_* functions
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys
At the same time, this permis implementation of some HidP_* functions.
Hervé Poussineau [Sat, 27 Apr 2019 09:19:46 +0000 (11:19 +0200)]
[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library
Interface between both is not anymore the HidParser_* functions, but
the HidP_* functions and the AllocFunction/FreeFunction/DebugFunctions/
ZeroFunction/CopyFunction.
Hervé Poussineau [Thu, 2 May 2019 11:26:46 +0000 (13:26 +0200)]
[SERIAL] Immediately complete read IRP if all requested bytes have been found in circular buffer
Previously, we had to wait to receive another byte to finish the first IRP.
Hervé Poussineau [Sat, 27 Apr 2019 21:07:39 +0000 (23:07 +0200)]
[I8042PRT] Do not assert on unknown IOCTL
jimtabor [Thu, 2 May 2019 16:56:55 +0000 (11:56 -0500)]
[NtGDI] Set Xform flags if a changed
Missed more flags changes.
jimtabor [Thu, 2 May 2019 15:16:50 +0000 (10:16 -0500)]
[NtGDI] Set Xform flags if a changed
Missed flags changes.
jimtabor [Thu, 2 May 2019 15:11:11 +0000 (10:11 -0500)]
[NtGDI] Adding Support for Viewport TextOut
Add Viewport changes to Text Out Batch.
Katayama Hirofumi MZ [Thu, 2 May 2019 13:48:01 +0000 (22:48 +0900)]
[COMDLG32] Fix treatment of wrong filename extension (#1545)
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
Pierre Schweitzer [Thu, 2 May 2019 11:59:47 +0000 (13:59 +0200)]
[NTDLL_APITEST] Query sector size for NtWriteFile tests
Pierre Schweitzer [Thu, 2 May 2019 10:07:46 +0000 (12:07 +0200)]
[NTDLL_APITEST] Add tests for alignment for NtWriteFile
This mimics the usage of WriteFile which is done in rosautotest.
CORE-15973
James Tabor [Thu, 2 May 2019 04:24:53 +0000 (23:24 -0500)]
[GDI32] Add batch flag for Text Out
Set batch flag for Text Out with font and attributes change sets.
James Tabor [Thu, 2 May 2019 01:53:06 +0000 (20:53 -0500)]
[GDI32] Fix MS build
Fix old uncovered code.
James Tabor [Thu, 2 May 2019 01:33:09 +0000 (20:33 -0500)]
[GDI32] Update signal flags for batch.
Add removed flags for batch signaling. This will allow syncing of
changed Xfroms after batched drawing. Disable calls to kernel mode since
the code is closely identical. Kernel calls are for init time when
PDCATTR is normally zero. ReactOS seems to work better keeping this from
NULL.
While making code changes add Xform state flags from:
https://www.reactos.org/archives/public/ros-diffs/2019-May/070693.html
Test BOT results:
https://reactos.org/testman/compare.php?ids=67251,67254
https://reactos.org/testman/compare.php?ids=67253,67255
Bișoc George [Wed, 1 May 2019 08:33:13 +0000 (10:33 +0200)]
[OSK] Hotfix for PR #1536 (#1549)
CORE-15965
Mark Jansen [Tue, 30 Apr 2019 20:51:28 +0000 (22:51 +0200)]
[ACGENRAL] Add a test shim
Mark Jansen [Tue, 30 Apr 2019 20:50:21 +0000 (22:50 +0200)]
[ROSAPPS] Add a test application for shims
Mark Jansen [Sun, 11 Feb 2018 21:40:51 +0000 (22:40 +0100)]
[APPHELP] Add ordinal import support
Eric Kohl [Wed, 1 May 2019 11:16:00 +0000 (13:16 +0200)]
[POWERCFG] Fix indentation. No code changes!
Katayama Hirofumi MZ [Wed, 1 May 2019 09:28:18 +0000 (18:28 +0900)]
[GDI32_APITEST] Improve SetMapMode testcase (#1547)
Check the relation of mode change and viewport change. CORE-14994
Katayama Hirofumi MZ [Wed, 1 May 2019 07:51:00 +0000 (16:51 +0900)]
[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)
Add WORLD_XFORM_CHANGED flag to some positioning functions.
Fix IntExtTextOutW function for TA_UPDATECP alignment, so that it can correctly update the current position. CORE-14994
Katayama Hirofumi MZ [Wed, 1 May 2019 07:15:23 +0000 (16:15 +0900)]
[KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come!
Mark Jansen [Sat, 27 Apr 2019 21:58:01 +0000 (23:58 +0200)]
[NTOS/MM] Ensure ImageBase is not used uninitialized
Hermès Bélusca-Maïto [Mon, 29 Apr 2019 20:51:35 +0000 (22:51 +0200)]
[KERNEL32] Addendum to
0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989
Bișoc George [Mon, 22 Apr 2019 13:01:18 +0000 (15:01 +0200)]
[OSK] Make the buttons themed
Our On-Screen Keyboard has a manifest and the buttons (the ones with BS_ICON styles) aren't rendered with the specific theme as it should be but instead it takes the classic theme.
The code relies on NM_CUSTOMDRAW notification, which is more intuitive and efficient than doing owner-drawn operations as NM_CUSTOMDRAW allows the controls to use styles whereas you cannot do it on owner-drawn controls.
CORE-15965
Katayama Hirofumi MZ [Mon, 29 Apr 2019 10:42:04 +0000 (19:42 +0900)]
[WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt
Katayama Hirofumi MZ [Mon, 29 Apr 2019 05:45:44 +0000 (14:45 +0900)]
[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)
Fix NtGdiTransformPoints, gdi32!DPtoLP, gdi32!LPtoDP and gdi32!SetMapMode functions. Fix CORE-15983. CORE-15983
Katayama Hirofumi MZ [Mon, 29 Apr 2019 03:49:54 +0000 (12:49 +0900)]
[APITESTS] set_module_type(win32u module)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 00:13:22 +0000 (09:13 +0900)]
[APITESTS] Add NtGdiTransformPoints testcase (#1542)
Add a testcase for NtGdiTransformPoints function. set_module_type(win32u... win32dll) CORE-15983
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 20:47:14 +0000 (22:47 +0200)]
[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-function as well, in order to reflect the actual name of the corresponding test.
Colin Finck [Sat, 27 Apr 2019 14:19:26 +0000 (16:19 +0200)]
Add a shared "port" directory for POSIX functions needed by multiple host tools (getopt/mkstemps) and import the one and only getopt from glibc.
This finally fixes our duplicated getopt functions from different sources and gives us an up to date and the most compatible implementation.
isohybrid actually relies on a glibc-specific getopt behavior that we previously hacked into the reactos_support_code.c implementation derived from BSD/mingw-w64.
widl also needs getopt and previously used an even older BSD-derived code.
Colin Finck [Sat, 27 Apr 2019 09:35:04 +0000 (11:35 +0200)]
[ISOHYBRID] Fix the remaining warnings properly.
I will send these changes upstream (minus the REACTOS_ISOHYBRID_EFI_MAC_SUPPORT ifdefs).
Timo Kreuzer [Mon, 15 Apr 2019 11:29:33 +0000 (13:29 +0200)]
[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 19:47:55 +0000 (21:47 +0200)]
[CONSRV] Cache the console window system menu handle; simplify its initialization code.
Serge Gautherie [Sun, 28 Apr 2019 19:19:42 +0000 (21:19 +0200)]
[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
No functional change otherwise.
Bișoc George [Sun, 28 Apr 2019 18:21:38 +0000 (20:21 +0200)]
[ACCESS] Reposition the "ToggleKeys" group box control (#1541)
CORE-15383
Andrew Boyarshin [Mon, 26 Nov 2018 12:49:15 +0000 (19:49 +0700)]
[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. (#1065)
- The 2nd parameter is already passed in user-mode by GetThreadDesktop().
It is then used by NtUserGetThreadDesktop() as a fallback for console
threads.
- Lookup and validate the thread by using the IntTID2PTI() helper.
- Don't reference the desktop with too many access rights.
- Get rid of the old-school DECLARE_RETURN() & co. macros.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Katayama Hirofumi MZ [Sun, 28 Apr 2019 15:24:57 +0000 (00:24 +0900)]
[WIN32SS][NTGDI] Fix wrong IN/OUT (#1539)
Eric Kohl [Sun, 28 Apr 2019 11:18:12 +0000 (13:18 +0200)]
[POWERCFG] Fix minor power scheme issues
- Really fix the exception that occurs on closing the property sheet.
- Use the correct scheme ID when the current power scheme is set.
Serge Gautherie [Sun, 28 Apr 2019 10:20:37 +0000 (12:20 +0200)]
[ROSAUTOTEST] "Enforce" ending '\n' on C___Exception messages (#1533)
Serge Gautherie [Sun, 28 Apr 2019 01:23:27 +0000 (03:23 +0200)]
[FORMATTING] appveyor.yml: Remove an extra space (#1538)
Addendum to
48f98e88.
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 00:40:20 +0000 (02:40 +0200)]
[WINSRV] Implement SrvGetThreadConsoleDesktop(). CORE-13470
It retrieves the handle to the desktop assigned to the specified
thread belonging to a console application, which is going to be
where the input thread of this console is.
Katayama Hirofumi MZ [Sat, 27 Apr 2019 23:43:24 +0000 (08:43 +0900)]
[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 23:40:09 +0000 (01:40 +0200)]
[NFS] Fix a typo in the precompiled header.
Eric Kohl [Sat, 27 Apr 2019 17:00:33 +0000 (19:00 +0200)]
[POWERCFG] Fix an exception that occurs when the control panel is closed.
Hermès Bélusca-Maïto [Thu, 23 Aug 2018 19:30:56 +0000 (21:30 +0200)]
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803)
This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 15:01:47 +0000 (17:01 +0200)]
[MODERN.MSSTYLES] Remove trailing whitespace.
Jake Collins [Tue, 23 Apr 2019 20:46:42 +0000 (21:46 +0100)]
[THEMES] Reorganize files for future compatability.
Moved current theme assets into their own dedicated
files in preparation for .theme support.
CORE-15970
Katayama Hirofumi MZ [Sat, 27 Apr 2019 14:02:34 +0000 (23:02 +0900)]
[COMDLG32] Save open/save location by extension (#1514)
Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114
Katayama Hirofumi MZ [Sat, 27 Apr 2019 13:06:37 +0000 (22:06 +0900)]
[SDK][INCLUDE] Use FALSE for BOOL in msgdump.h
Timo Kreuzer [Sat, 27 Apr 2019 09:26:03 +0000 (11:26 +0200)]
[CMAKE] Fix LINK_DEPENDS usage
Up to CMake 3.3 LINK_DEPENDS was ignored in non-Makefile generators. See also http://www.cmake.org/pipermail/cmake/2010-May/037206.html. Since CMake 3.4 it is no longer ignored, but requires CMP0005 policy to be set to NEW and it requires a full path which was already correctly used on GCC, but not on MSVC builds.
Andrew Cook [Sat, 27 Apr 2019 09:33:37 +0000 (19:33 +1000)]
[CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)
* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables
* LINK_DEPENDS is semicolon separated
* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header
Katayama Hirofumi MZ [Sat, 27 Apr 2019 09:30:29 +0000 (18:30 +0900)]
[SDK][INCLUDE] small fix for msgdump.h
Katayama Hirofumi MZ [Sat, 27 Apr 2019 07:17:37 +0000 (16:17 +0900)]
[WIN32SS][NTGDI] Use UNICODE_NULL for consistency
Katayama Hirofumi MZ [Sat, 27 Apr 2019 00:38:01 +0000 (09:38 +0900)]
[WIN32SS][NTGDI] FireFox checkmark fix CORE-15303 (#1535)
The font size was a bit larger than expected. FireFox will show checkmarks correctly in View menu. CORE-15303
Eric Kohl [Fri, 26 Apr 2019 21:12:36 +0000 (23:12 +0200)]
[POWERCFG] Show the name of the power scheme in the delete confirmation message box
Eric Kohl [Fri, 26 Apr 2019 19:51:48 +0000 (21:51 +0200)]
[POWERCFG] Some small cleanup
- Rename IDC_HYBERNATE... to IDC_HIBERNATE...
- Rename IDS_PORCENT to IDS_PERCENT
- Replace %1 by %s in IDS_CONFIG1 and IDS_CONFIG2
Katayama Hirofumi MZ [Fri, 26 Apr 2019 12:56:36 +0000 (21:56 +0900)]
[WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)
Fix CORE-15785. When LOGFONT.lfFaceName[0] == 0, then enumeration of font substitutes had failed. CORE-15785
Colin Finck [Fri, 26 Apr 2019 08:30:24 +0000 (10:30 +0200)]
[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so increase it to 170 seconds.
This is still below the 180 seconds before sysreg2 kills the entire VM.
I've added a comment to clarify that.
Timo Kreuzer [Sun, 21 Apr 2019 10:59:23 +0000 (12:59 +0200)]
[PSDK] Improve lmrepl.h
Added public domain header. This file was originally imported in r8283 from w32api where is has no copyright.
Colin Finck [Wed, 24 Apr 2019 08:48:15 +0000 (10:48 +0200)]
[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.
unattend.inf only allows to add RunOnce entries, which are in theory only executed on the first boot after installation.
For almost a decade, this worked anyway to start regtest.cmd again after a ReactOS crash, because the registry and thus the deletion of the RunOnce entry wasn't stored on disk in case of a crash.
Thanks to Sylvain for the hint!
As Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot, exit the script just after adding the Run key.
Otherwise, rosautotest.exe would be started twice, with catastrophic results.
Colin Finck [Tue, 23 Apr 2019 09:37:58 +0000 (11:37 +0200)]
[ROSAUTOTEST] Cache the result of GetLastError().
Colin Finck [Tue, 23 Apr 2019 07:17:05 +0000 (09:17 +0200)]
[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log output within 2 minutes, the test process is killed, and we continue with the next test.
This is a rather graceful approach compared to sysreg2's 3 minute timeout before killing and restarting the entire VM.
Since we added autochk for FAT filesystems, the filesystem is often "fixed" after a reset with the consequence that ReactOS doesn't boot up anymore.
The sysreg2 restart code still remains for handling tests causing BSODs.
Eric Kohl [Thu, 25 Apr 2019 22:03:27 +0000 (00:03 +0200)]
[POWERCFG] Fix the initialization of the power schemes page
CORE-4995
Oleg Dubinskiy [Sun, 14 Apr 2019 18:00:12 +0000 (21:00 +0300)]
[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5
Jared Smudde [Tue, 23 Apr 2019 05:47:02 +0000 (00:47 -0500)]
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)
CORE-13516, CORE-13518
Jared Smudde [Tue, 23 Apr 2019 05:46:28 +0000 (00:46 -0500)]
[MPR] Implement the function WNetDisconnectDialog(). (#1522)
CORE-13516, CORE-13518
Jared Smudde [Tue, 23 Apr 2019 05:45:49 +0000 (00:45 -0500)]
[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)
CORE-13516, CORE-13518
Katayama Hirofumi MZ [Wed, 24 Apr 2019 01:44:44 +0000 (10:44 +0900)]
[APPWIZ.CPL] Set a default shortcut-link description (#1520)
CORE-15511
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:41:41 +0000 (03:41 +0200)]
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:36:27 +0000 (03:36 +0200)]
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().
Katayama Hirofumi MZ [Tue, 23 Apr 2019 01:48:34 +0000 (10:48 +0900)]
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518)
Correctly create cache about ".lnk" and handling in the member functions.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Katayama Hirofumi MZ [Tue, 23 Apr 2019 05:25:18 +0000 (14:25 +0900)]
[MSPAINT] Set default extension .bmp (#1515)
Set the default extension of mspaint to .bmp. CORE-7114
Eric Kohl [Mon, 22 Apr 2019 22:12:23 +0000 (00:12 +0200)]
[STOBJECT] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.
CORE-12365
CORE-12972
CORE-15234
Eric Kohl [Mon, 22 Apr 2019 22:09:10 +0000 (00:09 +0200)]
[POWERCFG] Fix indentation and coding style. No code changes!
Eric Kohl [Mon, 22 Apr 2019 22:04:01 +0000 (00:04 +0200)]
[STOBJECT][MMSYS][POWERCFG] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.
CORE-12365
CORE-12972
CORE-15234
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:25:41 +0000 (21:25 +0200)]
[EXPLORER] Minor cleanup/comment fixes.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:09:10 +0000 (21:09 +0200)]
[NTOS:CM] In CmpParseKey(), do not assert but instead correctly return failure if CmpHandleExitNode() doesn't return a valid node, or CmpCreateKeyControlBlock() fails.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:41:19 +0000 (19:41 +0200)]
[NTOS] Fix typos.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:33:20 +0000 (19:33 +0200)]
[FREELDR] Add some missing UiDrawBackdrop() calls.