14 years ago- Implement KiRecalculateDueTime to handle cases where a timeout wait has been interu...
Alex Ionescu [Sat, 22 Jul 2006 17:19:09 +0000 (17:19 +0000)]
- Implement KiRecalculateDueTime to handle cases where a timeout wait has been interupted by an APC or alerted, and it needs to be recalculated in the relative case. (This fixes the "contact alex" bugcheck).

svn path=/trunk/; revision=23229

14 years agoFix typo.
Brandon Turner [Sat, 22 Jul 2006 17:03:00 +0000 (17:03 +0000)]
Fix typo.

svn path=/trunk/; revision=23228

14 years agoPartially implement:
Brandon Turner [Sat, 22 Jul 2006 16:50:23 +0000 (16:50 +0000)]
Partially implement:
This is (kinda)part of bug 1668

svn path=/trunk/; revision=23227

14 years ago- Give winlogon SE_ASSIGNPRIMARYTOKEN_PRIVILEGE because it was lacking it and would...
Alex Ionescu [Sat, 22 Jul 2006 16:03:12 +0000 (16:03 +0000)]
- Give winlogon SE_ASSIGNPRIMARYTOKEN_PRIVILEGE because it was lacking it and would fail under this kernel patch.
- PspAssignPrimaryToken was good enough for actually *assigning* the token, but when NtSetInfoProcess is called with ProcessPrimaryToken, we want to do a lot more then just randomly assigning it. Added PspSetPrimaryToken which first verifies if the token being assigned is a child token and if not, checks for SeAssignPrimaryTokenPrivilege. Also added a fixme for more code that's needed, to actually re-calculate the process's granted access towards itself. Also added thread-safety.

svn path=/trunk/; revision=23226

14 years agoImplement CM_Get_Next_Log_Conf[_Ex] and add PNP_GetNextLogConf stub.
Eric Kohl [Sat, 22 Jul 2006 14:45:14 +0000 (14:45 +0000)]
Implement CM_Get_Next_Log_Conf[_Ex] and add PNP_GetNextLogConf stub.

svn path=/trunk/; revision=23225

14 years agoFix for TrackMouseEvent by Dmitry Timoshkov, wine port.
James Tabor [Sat, 22 Jul 2006 07:04:44 +0000 (07:04 +0000)]
Fix for TrackMouseEvent by Dmitry Timoshkov, wine port.

svn path=/trunk/; revision=23224

14 years agoyou can thank me later jim ;)
Brandon Turner [Sat, 22 Jul 2006 05:50:06 +0000 (05:50 +0000)]
you can thank me later jim ;)

svn path=/trunk/; revision=23223

14 years agoPut back revision 23192
James Tabor [Sat, 22 Jul 2006 05:37:33 +0000 (05:37 +0000)]
Put back revision 23192

svn path=/trunk/; revision=23222

14 years ago-Part 1
James Tabor [Sat, 22 Jul 2006 05:28:44 +0000 (05:28 +0000)]
-Part 1
-Win32k and User32
  - Menu.c: Made set menu items selective masking. Setting masks fixed the garbage going into the item structure. Now right justify menu bar works. There are some more cosmetic issues left to do. I have those ready next week or so. Running wine menu test fail due to exception in kernel32 IsBadStringPtrA&W isbad.c. Funny? Does PSEH work in user mode? The string test is needed. Misc fixed, some restructuring and Wine ports. Please let me know if it breaks something.

svn path=/trunk/; revision=23221

14 years agoRevert my backspace patch from before. I found a better way to handle backspaces...
Brandon Turner [Sat, 22 Jul 2006 05:16:26 +0000 (05:16 +0000)]
Revert my backspace patch from before. I found a better way to handle backspaces which doesnt break backspacing in ftp.exe(and some of apps) while still fixing ncftp.exe.

svn path=/trunk/; revision=23220

14 years agoGet rid of TCHAR variables. Use WCHAR instead.
Hervé Poussineau [Fri, 21 Jul 2006 22:15:21 +0000 (22:15 +0000)]
Get rid of TCHAR variables. Use WCHAR instead.

svn path=/trunk/; revision=23219

14 years agoFix the horribly broken SetProgramWindow implementation
Brandon Turner [Fri, 21 Jul 2006 21:11:46 +0000 (21:11 +0000)]
Fix the horribly broken SetProgramWindow implementation

svn path=/trunk/; revision=23218

14 years ago- Add bugcheck CRITICAL_OBJECT_TERMINATED
Alex Ionescu [Fri, 21 Jul 2006 19:59:16 +0000 (19:59 +0000)]
- Implement PspCatchCriticalBreak and fix the 5 or so FIXMEs that depended on it.

svn path=/trunk/; revision=23216

14 years agoAdd a hack to be able to use serial mice again (IRP_MJ_CLOSE is not set after IoGetDe...
Hervé Poussineau [Fri, 21 Jul 2006 19:49:32 +0000 (19:49 +0000)]
Add a hack to be able to use serial mice again (IRP_MJ_CLOSE is not set after IoGetDeviceObjectPointer() + ObDereferenceObject())

svn path=/trunk/; revision=23215

14 years ago- Implement Kernel, Memory Manager and Process Manager APIs for the following concept...
Alex Ionescu [Fri, 21 Jul 2006 19:28:38 +0000 (19:28 +0000)]
- Implement Kernel, Memory Manager and Process Manager APIs for the following concepts (not yet used):
  - Process Quantum.
  - Fixed and Variable Quantum Tables.
  - Long and Short Quantum Variability.
  - Priority Separation and Separation Masks.
  - Foreground Quantum Table.
  - Process Priority, Priority Modes and Priority Classes.
  - Virtual Memory Priority
  - Job Scheduling Classes
- Implement PsSetProcessPriorityByClass.

svn path=/trunk/; revision=23214

14 years agoFix regression introduced in r23174, which prevented autochk to work
Hervé Poussineau [Fri, 21 Jul 2006 19:00:28 +0000 (19:00 +0000)]
Fix regression introduced in r23174, which prevented autochk to work

svn path=/trunk/; revision=23212

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:07:57 +0000 (13:07 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23211

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:07:51 +0000 (13:07 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23210

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:05:13 +0000 (13:05 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23209

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:05:07 +0000 (13:05 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23208

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:05:00 +0000 (13:05 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23207

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:04:55 +0000 (13:04 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23206

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 13:04:49 +0000 (13:04 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23205

14 years agoUpdate autosyncing status of Wine-shared DLLs
Aleksey Bragin [Fri, 21 Jul 2006 12:49:46 +0000 (12:49 +0000)]
Update autosyncing status of Wine-shared DLLs

svn path=/trunk/; revision=23204

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 11:30:20 +0000 (11:30 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23203

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 11:20:23 +0000 (11:20 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23202

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Fri, 21 Jul 2006 11:13:18 +0000 (11:13 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=23201

14 years agopatch from LMH1 : Bug#: 1675 : Norwegian translation
Magnus Olsen [Fri, 21 Jul 2006 10:23:55 +0000 (10:23 +0000)]
patch from LMH1  : Bug#:  1675   :  Norwegian translation

svn path=/trunk/; revision=23200

14 years ago- Use safe referencing.
Alex Ionescu [Thu, 20 Jul 2006 18:47:35 +0000 (18:47 +0000)]
- Use safe referencing.
- Fix a bug in PsGetNextProcess(Thread) since we now use safe referencing and the lookup loop can continue.

svn path=/trunk/; revision=23199

14 years ago- Refactor NtSuspend/ResumeThread into PsSuspend/ResumeThread.
Alex Ionescu [Thu, 20 Jul 2006 18:29:54 +0000 (18:29 +0000)]
- Refactor NtSuspend/ResumeThread into PsSuspend/ResumeThread.
- Implement NtSuspend/ResumeProcess with PsSuspend/ResumeProcess.
- Improve the previous code to use rundown protection and be thread-safe.

svn path=/trunk/; revision=23198

14 years ago- Add Pushlock support for GCC (Thanks Thomas!)
Alex Ionescu [Thu, 20 Jul 2006 17:44:30 +0000 (17:44 +0000)]
- Add Pushlock support for GCC (Thanks Thomas!)
- Remove a bunch of deprecated crap from ps.h
- Get rid of PsLockProcess, PsUnlockProcess. Use the process pushlock instead.
- When assigning the job, only acquiring rundown protection is enough.
- Use interlocked intrinsics for setting the ExceptionPort instead of locking the entire process object.
- Disable locking in ProcessSessionInformation for NtSetInformationProcess. The whole API seems wrong anyway, on my XP machine calling it does not change the session or change any token data. To verify later...

svn path=/trunk/; revision=23197

14 years agoToo many changes to list here! just see screenshot:
Michele Cicciotti [Thu, 20 Jul 2006 17:11:00 +0000 (17:11 +0000)]
Too many changes to list here! just see screenshot: (not pictured: artifacts due to sometimes-broken handling of window region refreshing)

The graphics, mouse and keyboard are virtually done. Mouse wheel works. Still some bugs in the handling of binary raster operation codes, but less than before. Fixed polyline. Fixed all cursor issues. Fully supports text output. Fixed a resource leak where all clipping region were slowly leaked. Now closes cleanly on server disconnect

Moving on to more fun things!

Many thanks to filip & WaxDragon for the code of the previous Win32 port, it was misleading at times but very useful overall!

svn path=/trunk/; revision=23196

14 years ago- Add some final missing annotations to kill.c
Alex Ionescu [Thu, 20 Jul 2006 16:30:07 +0000 (16:30 +0000)]
- Add some final missing annotations to kill.c
 - Most of the functions are documented at length in Windows Internals II and at a more high-level fashion in Windows Internals 4 and were based on that information. Undocumented routines were based of the operations done in the documented ones (for example, freeing buffers that we know were allocated, etc).

svn path=/trunk/; revision=23195

14 years ago- Move a bunch of externs to ps.h and delete many dupped/tripped ones.
Alex Ionescu [Thu, 20 Jul 2006 16:26:10 +0000 (16:26 +0000)]
- Move a bunch of externs to ps.h and delete many dupped/tripped ones.
- Change FAST_MUTEX PsActiveProcessMutex to KGUARDED_MUTEX.
- Define PS Flags and use them, isntead of magic numbers. (For magic mushrooms, you'll have to wait a while, these aren't implemented yet).

svn path=/trunk/; revision=23194

14 years ago- Fix Win32K thread rundown bug, fixes shutdown crash and other bugchecks where some...
Alex Ionescu [Thu, 20 Jul 2006 15:46:10 +0000 (15:46 +0000)]
- Fix Win32K thread rundown bug, fixes shutdown crash and other bugchecks where some ASSERT(Class->windows) wasn't 0.
- Close the right debug handle instead of some random value.
- Some generic formatting cleanup.

svn path=/trunk/; revision=23193

14 years ago- Simplify PsGetNextProcess so it works like PsGetNextProcessThread.
Alex Ionescu [Thu, 20 Jul 2006 14:53:47 +0000 (14:53 +0000)]
- Simplify PsGetNextProcess so it works like PsGetNextProcessThread.
- Reformat and annotate parts of process.c
- Remove PsGetWin32Process, PsGetWin32Thread and implement/export the real functions PsGetCurrentProcessWin32Process, PsGetCurrentThreadWin32Thread, change win32k to use them.
- Initailize and use process rundown.
- Set corrent GrantedAccess.
- Remove an extra incorrect reference we were adding to processes.
- Implement PsIsProcessBeingDebugged.
- Make the same changes to NtOpenProcess that we did previously to NtOpenThread.

svn path=/trunk/; revision=23192

14 years agoSpaces -> TABs, no contents change
Aleksey Bragin [Thu, 20 Jul 2006 09:32:50 +0000 (09:32 +0000)]
Spaces -> TABs, no contents change

svn path=/trunk/; revision=23191

14 years agostart spliting up my code. I been writing
Magnus Olsen [Thu, 20 Jul 2006 07:23:21 +0000 (07:23 +0000)]
start spliting up my code. I been writing

1. DD_CALLBACKS code writen by me have been move to dd.c

2. follow DD_CALLBACKS api is working as they should
   NtGdiDdWaitForVerticalBlank, NtGdiDdCanCreateSurface, NtGdiDdGetScanLine

3. follow api does not working as it should, is it gdi32 problem or win32k problem for it ?

4. Start rewriten surf callback and cleanup some code
   alot wrong with them.

5. start moving surface callback to ddsurf.c

svn path=/trunk/; revision=23189

14 years agoRename twain32.rbuild to twain_32.rbuild
Hervé Poussineau [Thu, 20 Jul 2006 07:09:20 +0000 (07:09 +0000)]
Rename twain32.rbuild to twain_32.rbuild

svn path=/trunk/; revision=23188

14 years agoDelete now useless twain directory
Hervé Poussineau [Thu, 20 Jul 2006 06:38:33 +0000 (06:38 +0000)]
Delete now useless twain directory

svn path=/trunk/; revision=23186

14 years agoForgot to commit this file with previous commit ;)
Hervé Poussineau [Thu, 20 Jul 2006 06:27:35 +0000 (06:27 +0000)]
Forgot to commit this file with previous commit ;)

svn path=/trunk/; revision=23185

14 years agoCopy twain directory to twain_32
Hervé Poussineau [Thu, 20 Jul 2006 06:26:09 +0000 (06:26 +0000)]
Copy twain directory to twain_32

svn path=/trunk/; revision=23184

14 years agoFix a bug in RtlMultiByteToUnicodeSize. Credits belong to whoever debugged it.
Filip Navara [Thu, 20 Jul 2006 06:25:51 +0000 (06:25 +0000)]
Fix a bug in RtlMultiByteToUnicodeSize. Credits belong to whoever debugged it.

svn path=/trunk/; revision=23183

14 years agoRename twain32.rbuild to twain_32.rbuild
Hervé Poussineau [Thu, 20 Jul 2006 06:15:24 +0000 (06:15 +0000)]
Rename twain32.rbuild to twain_32.rbuild

svn path=/trunk/; revision=23182

14 years ago- Fix for bug 1703. reported by gkrupa.
Alex Ionescu [Thu, 20 Jul 2006 05:39:40 +0000 (05:39 +0000)]
- Fix for bug 1703. reported by gkrupa.

svn path=/trunk/; revision=23181

14 years ago[AUDIT]
Alex Ionescu [Thu, 20 Jul 2006 05:37:12 +0000 (05:37 +0000)]
 - 90% of the functions in this file are 1 line functions which set or get a value from ETHREAD.
 - The other 4 functions are related to User and System Thread Startup APCs, which are documented in gruesome detail and pseudo-code in Windows Internals 4 and Windows Internals II, as well as the main Thread Creation routine (PspCreateThread) which is one of the most well documented internal routines of NT. Code was developped in conjuction with WI4 and WI II.

svn path=/trunk/; revision=23180

14 years ago- Move ExGetPreviousMode to \ex, it's not a Ps function
Alex Ionescu [Thu, 20 Jul 2006 05:33:03 +0000 (05:33 +0000)]
- Move ExGetPreviousMode to \ex, it's not a Ps function
- Organize thread.c into private/public functions properly.
- Do another pass of formatting fixes and function annotation.
- Fix a bug in PspSystemStartup.
- Properly hold object references towards a thread that's being created.
- Set the Thread->GrantedAccess value.
- Update NtOpenThread to use an Access State since these work now and Ob respects them, and also add a special hack present on NT: If the SeDEbugPrivilege is present, then the caller will get full thread access regardless of his rights.

svn path=/trunk/; revision=23179

14 years ago- More kernel fun.
Alex Ionescu [Thu, 20 Jul 2006 03:10:32 +0000 (03:10 +0000)]
- More kernel fun.

svn path=/trunk/; revision=23178

14 years ago[AUDIT]
Alex Ionescu [Thu, 20 Jul 2006 03:09:40 +0000 (03:09 +0000)]
 - PspGetImagePath: internal to ROS and reads the image path pretty differently from how NT does it.
 - NtQuery/Set functions: although huge in size, they are just a set of 2-10 line sub-functions which only transfer data from EPROCESS into a usermode structure or vice-versa. Fully documented in Nebett's book, and we have many test cases in the tree which show their clean implementation.
 - Also, our nice automatgic buffer validation and size checks are 100% Thomas's genius and not used in NT at all.
 - Thus, file is clean.

svn path=/trunk/; revision=23177

14 years ago- Formatting cleanup and optimizations to NtSetInformationProcess.
Alex Ionescu [Thu, 20 Jul 2006 03:05:46 +0000 (03:05 +0000)]
- Formatting cleanup and optimizations to NtSetInformationProcess.

svn path=/trunk/; revision=23176

14 years ago- Major formatting cleanup and optimizations to NtQueryInformationProcess so that...
Alex Ionescu [Thu, 20 Jul 2006 00:13:09 +0000 (00:13 +0000)]
- Major formatting cleanup and optimizations to NtQueryInformationProcess so that it does not burn the eyes of anyone that might attempt to read it.

svn path=/trunk/; revision=23175

14 years ago- Cleanup the mess in query.c by reformatting the code to remove tab/space confusion...
Alex Ionescu [Wed, 19 Jul 2006 23:21:19 +0000 (23:21 +0000)]
- Cleanup the mess in query.c by reformatting the code to remove tab/space confusion and 2-space identation.
- Removed the InfoClass tables and got rid of the thread semi-infoclass table. Created a real InfoClass stub table for thread information
- Moved info class tables to a new header, ps_i.h
- Simplified syntax of info class macros so that sizeof() is done automatically for the type/alignment.
- Reformatted the tables completely to present them in a plesing, ordered, readable fashion.
- Added some missing info classes.
- Added ARRAYSIZE, RTL_NUMBER_OF(V1/V2) and used them in the info code.
- *TEMPORARILY* disable NtQuery/SetThreadInformation until next patch when it can be made to work.

svn path=/trunk/; revision=23174

14 years agoRevert 23170, since these registry keys should not be mandatory (simple test case...
Aleksey Bragin [Wed, 19 Jul 2006 19:43:55 +0000 (19:43 +0000)]
Revert 23170, since these registry keys should not be mandatory (simple test case: delete this registry entry in Windows XP using regedit, open desk.cpl, choose your params, click apply - all registry entries will be re-created).
Fix for reactos desk.cpl will follow.

svn path=/trunk/; revision=23173

14 years ago- Use clipper so we can use a normal instead of a popup window
Maarten Bosma [Wed, 19 Jul 2006 10:30:30 +0000 (10:30 +0000)]
- Use clipper so we can use a normal instead of a popup window
- Fix my old coding style and get rid of main.h
- Change he color to pink for alternation

svn path=/trunk/; revision=23172

14 years agoAlexey Minnekhanov (
Aleksey Bragin [Wed, 19 Jul 2006 08:45:21 +0000 (08:45 +0000)]
Alexey Minnekhanov (
- Implement setting of desktop background color. This feature is tested to work in Windows XP, however in ReactOS the setting currently does no effect.
- Improve russian translation, also check and fix layout/placement (so that russian words actually fit)

svn path=/trunk/; revision=23171

14 years agoAdd HKCU\Control Panel\Colors\Background key for storing desktop background color...
Aleksey Bragin [Wed, 19 Jul 2006 08:40:38 +0000 (08:40 +0000)]
Add HKCU\Control Panel\Colors\Background key for storing desktop background color (Windows XP stores it in this key)

svn path=/trunk/; revision=23170

14 years agoUser32 Implement MenuTrackKbdMenuBar, it does work but, alt f works but hit alt again...
James Tabor [Wed, 19 Jul 2006 07:10:56 +0000 (07:10 +0000)]
User32 Implement MenuTrackKbdMenuBar, it does work but, alt f works but hit alt again goes into a message loop. So hit alt f than esc esc. If hit alt f than alt v or something else the popup menu stays displayed until the program has terminated.

svn path=/trunk/; revision=23169

14 years agohacking NtGdiDdResetVisrgn so it lest say clip have not change. for now
Magnus Olsen [Wed, 19 Jul 2006 02:14:26 +0000 (02:14 +0000)]
hacking NtGdiDdResetVisrgn so it lest say clip have not change. for now

svn path=/trunk/; revision=23168

14 years agomore source cleanup
Magnus Olsen [Wed, 19 Jul 2006 02:03:22 +0000 (02:03 +0000)]
more source cleanup

svn path=/trunk/; revision=23167

14 years agosmall cleanup of the code in this file.
Magnus Olsen [Wed, 19 Jul 2006 01:49:55 +0000 (01:49 +0000)]
small cleanup of the code in this file.
and alot of callbacks working as they should if a drv support it.

svn path=/trunk/; revision=23166

14 years agoComplete NtGdiDdQueryDirectDrawObject now we support all 3d callbacks.
Magnus Olsen [Wed, 19 Jul 2006 01:40:06 +0000 (01:40 +0000)]
Complete NtGdiDdQueryDirectDrawObject now we support all 3d callbacks.

svn path=/trunk/; revision=23165

14 years agocleanup NtGdiDdCreateSurface
Magnus Olsen [Wed, 19 Jul 2006 00:41:18 +0000 (00:41 +0000)]
cleanup NtGdiDdCreateSurface
we can now create a surface from DdCreateSurface.

svn path=/trunk/; revision=23164

14 years agoFixing small bug in DdCreateSurface
Magnus Olsen [Wed, 19 Jul 2006 00:39:03 +0000 (00:39 +0000)]
Fixing small bug in DdCreateSurface

svn path=/trunk/; revision=23163

14 years agoframebuf
Magnus Olsen [Tue, 18 Jul 2006 23:56:48 +0000 (23:56 +0000)]
Implement DdCreateSurface not tested.
Bugfix the prototyped.

svn path=/trunk/; revision=23162

14 years agoAdd traceprints, and temporarily comment out NDEBUG
Aleksey Bragin [Tue, 18 Jul 2006 19:06:30 +0000 (19:06 +0000)]
Add traceprints, and temporarily comment out NDEBUG

svn path=/trunk/; revision=23161

14 years agorewrote NtGdiDdQueryDirectDrawObject for I must have been drunk when I wrote it frist...
Magnus Olsen [Tue, 18 Jul 2006 19:04:41 +0000 (19:04 +0000)]
rewrote NtGdiDdQueryDirectDrawObject for I must have been drunk when I wrote it frist time.
Now we manger getting gdientry2 working more or less here is a log how far I have come
I have not implement create surface for the drv yet. But it showing lest how far dxhaltest
comes. as u all can see it is not far before we getting dx hal working out of the box from
win32k and gdi32. I will thank all people that have been invlove in this, DrFred to helping debug betwin ddraw.dll gdi32.dll
with his sniffer apps, Alex for GdiEntry2, and some other help, W3seek, Filip, GvG help me to understand how our win32k how it works
and some other info. to make so far posible, it is now posible to load a graphic driver directx hal support in ros. But I do not known how well it works yet, after it is the frist public version that working so far.

ddraw.c:60) NtGdiDdCreateDirectDrawObject
ddraw.c:140) DirectDraw return handler 0x3b6001e4
ddraw.c:170) NtGdiDdQueryDirectDrawObject
ddraw.c:247) Found DirectDraw CallBack for 2D and 3D Hal
ddraw.c:170) NtGdiDdQueryDirectDrawObject
ddraw.c:247) Found DirectDraw CallBack for 2D and 3D Hal
ddraw.c:432) NtGdiDdCanCreateSurface
ddraw.c:348) NtGdiDdCreateSurface

svn path=/trunk/; revision=23160

14 years agoDrvGetDirectDrawInfo
Magnus Olsen [Tue, 18 Jul 2006 18:55:11 +0000 (18:55 +0000)]
fixing a bug I did set halinfo to wrong size

svn path=/trunk/; revision=23159

14 years agoLittle patch, help distinguish between Bitmap and Text drawing or do both. dwTypeData...
James Tabor [Tue, 18 Jul 2006 17:29:34 +0000 (17:29 +0000)]
Little patch, help distinguish between Bitmap and Text drawing or do both. dwTypeData is a pointer going to the user not the true text pointer of the menu item and should not be used for checking if menu item has text.

svn path=/trunk/; revision=23158

14 years agoAdd two more test cases into ex timer testing
Aleksey Bragin [Tue, 18 Jul 2006 16:49:11 +0000 (16:49 +0000)]
Add two more test cases into ex timer testing

svn path=/trunk/; revision=23157

14 years agopathc from w3seek : bug 1702 : Fix BitScanReverse()
Magnus Olsen [Tue, 18 Jul 2006 16:36:54 +0000 (16:36 +0000)]
pathc from w3seek : bug   1702  : Fix BitScanReverse()

svn path=/trunk/; revision=23156

14 years agosetup almost all info it need in DrvGetDirectDrawInfo, left todo is the rop table.
Magnus Olsen [Tue, 18 Jul 2006 15:57:42 +0000 (15:57 +0000)]
setup almost all info it need in DrvGetDirectDrawInfo, left todo is the rop table.
and debugging see if everything went right. it is eunght for me continue on next
step in debugging

svn path=/trunk/; revision=23155

14 years agoDisable a few more warnings when using pshpackX.h/poppack.h
Hervé Poussineau [Tue, 18 Jul 2006 15:50:13 +0000 (15:50 +0000)]
Disable a few more warnings when using pshpackX.h/poppack.h

svn path=/trunk/; revision=23154

14 years agoFix headers, so MSVC can use them
Hervé Poussineau [Tue, 18 Jul 2006 15:30:22 +0000 (15:30 +0000)]
Fix headers, so MSVC can use them

svn path=/trunk/; revision=23153

14 years ago[AUDIT] security.c is mostly composed of trivial implementations of APIs that transfe...
Alex Ionescu [Tue, 18 Jul 2006 15:13:55 +0000 (15:13 +0000)]
[AUDIT] security.c is mostly composed of trivial implementations of APIs that transfer one set of data from another, or simply wrap around complex Se* functions which do the actual work. There are one or two slightly more complex APIs (~15-20 lines), but they were written by Eric/Thomas, which are well-known for always writing clean code.
[FORMATTING] Re-formatted file properly, ordered functions and annotated them, added proper programmer credits, etc.
- Pushlocks need to be acquired in a -critical-, not -guarded- region.
- PsDisableImpersonation should return FALSE if it was already disbled.
- Don't forget to reference the token in PsReferenceEffectiveToken.
- PsImpersonateClient should still return success if it was given no token.
- PsImperstonateClient should de-reference the token if there is already active impersonation info.

svn path=/trunk/; revision=23152

14 years agoadd mouse properties registry keys
Johannes Anderwald [Tue, 18 Jul 2006 14:48:53 +0000 (14:48 +0000)]
add mouse properties registry keys

svn path=/trunk/; revision=23151

14 years agoFix warnings detected by MSVC
Hervé Poussineau [Tue, 18 Jul 2006 14:41:55 +0000 (14:41 +0000)]
Fix warnings detected by MSVC

svn path=/trunk/; revision=23150

14 years agoFix some 'unreferenced variable' warnings
Hervé Poussineau [Tue, 18 Jul 2006 14:40:55 +0000 (14:40 +0000)]
Fix some 'unreferenced variable' warnings

svn path=/trunk/; revision=23149

14 years agoFix some 'unreferenced variable' warnings
Hervé Poussineau [Tue, 18 Jul 2006 14:39:37 +0000 (14:39 +0000)]
Fix some 'unreferenced variable' warnings

svn path=/trunk/; revision=23148

14 years agoFix wrong library names in export files
Hervé Poussineau [Tue, 18 Jul 2006 14:38:35 +0000 (14:38 +0000)]
Fix wrong library names in export files

svn path=/trunk/; revision=23147

14 years ago[AUDIT] - State.c is clean, it is merely a collection of trivial ~10 line wrappers...
Alex Ionescu [Tue, 18 Jul 2006 14:34:06 +0000 (14:34 +0000)]
[AUDIT] - State.c is clean, it is merely a collection of trivial ~10 line wrappers around the actual kernel (Ke) functions which do the work.
- Rename suspend.c to state.c (since it also had resume APIs) and add alert APIs from kthread to it too.
- Fix a bug in one of the alert APIs which was probing for a valid pointer even if the caller had given NULL (which is valid if the caller doesn't want the previous state returned).

svn path=/trunk/; revision=23146

14 years agoFix some 'unreferenced variable' warnings
Hervé Poussineau [Tue, 18 Jul 2006 13:56:00 +0000 (13:56 +0000)]
Fix some 'unreferenced variable' warnings

svn path=/trunk/; revision=23145

14 years agoFix a warning (unused variable)
Hervé Poussineau [Tue, 18 Jul 2006 13:55:22 +0000 (13:55 +0000)]
Fix a warning (unused variable)

svn path=/trunk/; revision=23144

14 years ago* check parameters
Johannes Anderwald [Tue, 18 Jul 2006 13:45:37 +0000 (13:45 +0000)]
* check parameters

svn path=/trunk/; revision=23143

14 years ago* check parameters in CreateAcceleratorTableA/W and DestroyAcceleratorTable
Johannes Anderwald [Tue, 18 Jul 2006 13:44:39 +0000 (13:44 +0000)]
* check parameters in CreateAcceleratorTableA/W and DestroyAcceleratorTable

svn path=/trunk/; revision=23142

14 years agofill the DDHALINFO almost to 100% now, we are mising the rops table.
Magnus Olsen [Tue, 18 Jul 2006 13:23:38 +0000 (13:23 +0000)]
fill the DDHALINFO almost to 100% now, we are mising the rops table.
Almost all info that need be send back for frist call is done,

svn path=/trunk/; revision=23141

14 years agoRevert 21223 (was not good idea...)
Saveliy Tretiakov [Tue, 18 Jul 2006 13:14:12 +0000 (13:14 +0000)]
Revert 21223 (was not good idea...)

svn path=/trunk/; revision=23140

14 years agoAdd Andrew Munger (waxdragon) to credits.
Saveliy Tretiakov [Tue, 18 Jul 2006 12:33:30 +0000 (12:33 +0000)]
Add Andrew Munger (waxdragon) to credits.

svn path=/trunk/; revision=23139

14 years agoAdd missing return value checks. Finally fix bug #1526
Saveliy Tretiakov [Tue, 18 Jul 2006 12:19:07 +0000 (12:19 +0000)]
Add missing return value checks. Finally fix bug #1526

svn path=/trunk/; revision=23138

14 years agoTestapps for NtUserDrawCaption. (I sent the patch to ros-dev for review)
Saveliy Tretiakov [Tue, 18 Jul 2006 11:59:22 +0000 (11:59 +0000)]
Testapps for NtUserDrawCaption. (I sent the patch to ros-dev for review)

svn path=/trunk/; revision=23137

14 years agoCorrectly return information to caller
Hervé Poussineau [Tue, 18 Jul 2006 11:55:40 +0000 (11:55 +0000)]
Correctly return information to caller

svn path=/trunk/; revision=23136

14 years agoMake guiconsole window movable and respond to minimize and close buttons (regression...
Saveliy Tretiakov [Tue, 18 Jul 2006 11:45:28 +0000 (11:45 +0000)]
Make guiconsole window movable and respond to minimize and close buttons (regression caused by r22822)

svn path=/trunk/; revision=23135

14 years agoadding NULL pointer check for ppdev, pHalInfo, pdwNumHeaps, pdwNumFourCCCodes
Magnus Olsen [Tue, 18 Jul 2006 08:54:32 +0000 (08:54 +0000)]
adding NULL pointer check for ppdev, pHalInfo, pdwNumHeaps, pdwNumFourCCCodes
fill in more info for DDHALINFO it is not complete yet.

svn path=/trunk/; revision=23134

14 years ago- Move ps/locale.c to ex/locale.c, since it has nothing to do with Process/Thread...
Alex Ionescu [Tue, 18 Jul 2006 01:58:10 +0000 (01:58 +0000)]
- Move ps/locale.c to ex/locale.c, since it has nothing to do with Process/Thread management (locale settings are part of the executive).
- Cleanup formatting in the file and add proper credits (Thomas and Eric).
- Create internal Exp* functions for Setting/Getting the user langid, since they need to be called 2, 3 times by other code and thus shared.
- Remove some deprecated code, make the functions themselves initialize the default ID when called for the first time (which should be done by winlogon --> it seems this isn't done yet?).
- Set default locale to 0x409 instead of 0x0.

svn path=/trunk/; revision=23133

14 years ago- Kernel Fun
Alex Ionescu [Tue, 18 Jul 2006 00:51:09 +0000 (00:51 +0000)]
- Kernel Fun

svn path=/trunk/; revision=23132

14 years ago[AUDIT] - notify.c contains trivial (3 or 4 lines of code) implementations of adding...
Alex Ionescu [Mon, 17 Jul 2006 22:18:44 +0000 (22:18 +0000)]
[AUDIT] - notify.c contains trivial (3 or 4 lines of code) implementations of adding a pointer to an array, and then looping said array and calling a pointer. Your grandmother could code this.
- Cleanup notify.c and fix the return value of PsSetCreateProcessNotifyRoutine.
- Create ps_x.h for inlined Ps routines and put the internal routines which call the registered callbacks in it.

svn path=/trunk/; revision=23131

14 years agostart implement DrvGetDirectDrawInfo it is not complete only around 1/3 is done
Magnus Olsen [Mon, 17 Jul 2006 22:14:58 +0000 (22:14 +0000)]
start implement DrvGetDirectDrawInfo it is not complete only around  1/3 is done

svn path=/trunk/; revision=23130

14 years ago- kbdclass/mouclass should be able to return more than one keystroke/mouse move durin...
Hervé Poussineau [Mon, 17 Jul 2006 22:13:40 +0000 (22:13 +0000)]
- kbdclass/mouclass should be able to return more than one keystroke/mouse move during a IRP_MJ_READ.
- Better cleanup in case of error in ClassAddDevice
- Registering the interface is optional. Don't fail in case of error.

svn path=/trunk/; revision=23129

14 years ago* unlink menu object from window object on destroy
Johannes Anderwald [Mon, 17 Jul 2006 19:16:30 +0000 (19:16 +0000)]
* unlink menu object from window object on destroy

svn path=/trunk/; revision=23128

14 years ago[FORMATTING] - Cleanup win32.c
Alex Ionescu [Mon, 17 Jul 2006 17:32:58 +0000 (17:32 +0000)]
[FORMATTING] - Cleanup win32.c
[AUDIT] - Only function of interest is PsConverToGuiThread, heavily documented at:

svn path=/trunk/; revision=23127

14 years agomore code, from alex patch I got over one year ago, thanks alex for all help and...
Magnus Olsen [Mon, 17 Jul 2006 16:27:13 +0000 (16:27 +0000)]
more code, from  alex  patch I got over one year ago, thanks alex for all help and for all code he wrote.
and sorry for the mess at moment in the file. it will be pretty large update to this file, for the patch have been lying on my
harddisk for some time.

svn path=/trunk/; revision=23126