Mark Jansen [Sun, 4 Aug 2019 21:47:02 +0000 (23:47 +0200)]
[WIN32SS] Iteratively mutate menu flags until we find a 'best fit'
CORE-15863
Mark Jansen [Sat, 15 Jun 2019 19:14:41 +0000 (21:14 +0200)]
[WIN32SS] Rewrite MENU_ShowPopup to take the exclude rectangle into account
CORE-15863
Joachim Henze [Tue, 6 Aug 2019 18:24:55 +0000 (20:24 +0200)]
[SHELL32] Improve ShellExecute
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.
Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.
Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697
I intend to merge this back into 0.4.12RC.
Katayama Hirofumi MZ [Tue, 6 Aug 2019 02:09:56 +0000 (11:09 +0900)]
[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy (#1806)
The caption text of 2nd stage ReactOS Setup was too bold. CORE-16295
Benjamin Aerni [Mon, 5 Aug 2019 19:18:23 +0000 (12:18 -0700)]
[INF] Added BTRFS inf to remove unknown device
CORE-15928
Eric Kohl [Mon, 5 Aug 2019 18:18:17 +0000 (20:18 +0200)]
[SERVICES] Enable the backup and restore privileges before loading or unloading a user profile and then disable them again.
Katayama Hirofumi MZ [Mon, 5 Aug 2019 14:16:01 +0000 (23:16 +0900)]
[WIN32SS][NTUSER] Fix default menu item font weight (#1804)
CORE-16294
We had added "Arial Black" font, so a request for heavy weight font will be realized as it is. This PR will fix font weight (FW_*) calculation of default menu items.
Katayama Hirofumi MZ [Mon, 5 Aug 2019 10:55:00 +0000 (19:55 +0900)]
[SETUP][INF] Helvetica must be substitute to Arial font (#1803)
Helvetica must be font substitute to Arial font.
- Change some Helvetica substitutes to "Arial" from "Liberation Sans". Not all Helvetica. Some languages are lacking support.
Katayama Hirofumi MZ [Mon, 5 Aug 2019 09:11:09 +0000 (18:11 +0900)]
[MEDIA][FONTS] Replace Georgia fonts (#1802)
Replace "Georgia" fonts with renamed "Gelasio". CORE-16293
- Replace "Georgia" fonts with renamed "Gelasio" fonts.
- Replace LICENSE file.
I made these font files by using FontForge. Their family name is "Georgia". Their display names are "Georgia", "Georgia Bold", "Georgia Bold Italic" and "Georgia Italic". Their font filenames are georgia.ttf, georgiab.ttf, georgiaz.ttf and georgiai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Gelasio is available at: https://github.com/SorkinType/Gelasio
Katayama Hirofumi MZ [Mon, 5 Aug 2019 05:36:06 +0000 (14:36 +0900)]
[MEDIA][FONTS] Replace 'Palatino Linotype' fonts (#1800)
Add 'Palatino Linotype' fonts with renamed 'TeXGyrePagella'. CORE-16292
- Replace 'Palatino Linotype' fonts with renamed "TeXGyrePagella".
- Replace LICENSE file.
I made these font files by using FontForge. Their family name is "Palatino Linotype". Their display names are "Palatino Linotype", "Palatino Linotype Bold", "Palatino Linotype Bold Italic" and "Palatino Linotype Italic". Their font filenames are pala.ttf, palab.ttf, palabi.ttf and palai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Mon, 5 Aug 2019 00:44:25 +0000 (09:44 +0900)]
[SYSSETUP] Fix bold font (#1799)
The font of radio buttons at ReactOS 2nd setup was wrong and too heavy. CORE-16291
Katayama Hirofumi MZ [Mon, 5 Aug 2019 00:42:24 +0000 (09:42 +0900)]
[MEDIA][FONTS] Fix Arial Black metadata (#1797)
Fix "Arial Black" font metadata. CORE-16291
- Its weight must be Black.
- It must be San Serif.
Eric Kohl [Sun, 4 Aug 2019 20:43:46 +0000 (22:43 +0200)]
[SERVICES] Fix indentation and remove an unused variable
Eric Kohl [Sun, 4 Aug 2019 20:30:40 +0000 (22:30 +0200)]
[SERVICES] Use a proper security descriptor for the control pipes
Eric Kohl [Sun, 4 Aug 2019 18:58:12 +0000 (20:58 +0200)]
[SERVICES] Do not try to start lsass.exe as a service.
Starting the security services (samss, netlogon, etc) requires special code in services.exe and lsasrv.dll.
Eric Kohl [Sun, 4 Aug 2019 17:58:50 +0000 (19:58 +0200)]
[RPCSS] Prevent the RPCSS service from getting stopped
CORE-13500
Hermès Bélusca-Maïto [Sun, 4 Aug 2019 15:35:46 +0000 (17:35 +0200)]
[FREELDR] Some initialization fixes.
- Initialize BootPath and BootOptions buffers when fallback behaviour is not taken.
- Correctly skip all the understood whitespace (space & tabs) and the
quotes before reading the boot options when using the alternative syntax:
[Operating Systems]
section_name = "ReactOS" /bootoptions
Fixes the minor regression introduced in
370e8564 (r43875).
Hermès Bélusca-Maïto [Sun, 4 Aug 2019 15:29:07 +0000 (17:29 +0200)]
[FREELDR] Whitespace, minor code styles and comments fixes only.
Hermès Bélusca-Maïto [Tue, 30 Jul 2019 00:11:26 +0000 (02:11 +0200)]
[FREELDR] Unload freeldr.ini file before booting.
Hermès Bélusca-Maïto [Mon, 29 Jul 2019 23:49:23 +0000 (01:49 +0200)]
[FREELDR] Use NOGUIBOOT when booting in Safe-Mode.
Eric Kohl [Sun, 4 Aug 2019 11:59:39 +0000 (13:59 +0200)]
[NTOSKRNL] Implement SeRegisterLogonSessionTerminatedRoutine() and SeUnregisterLogonSessionTerminatedRoutine().
Thomas Faber [Sun, 4 Aug 2019 10:55:45 +0000 (12:55 +0200)]
[CODEOWNERS] Remove 'CMakeLists.txt' rule, which is too noisy.
Eric Kohl [Sun, 4 Aug 2019 09:18:42 +0000 (11:18 +0200)]
[DEVMGR] Add the code to uninstall a device from the property page
Katayama Hirofumi MZ [Sun, 4 Aug 2019 07:10:15 +0000 (16:10 +0900)]
[SETUP][INF] Fix font substitutes (#1794)
Fix font substitutes. CORE-16264
- Modify muifonts.h.
- Modify font.inf.
Katayama Hirofumi MZ [Sun, 4 Aug 2019 06:38:45 +0000 (15:38 +0900)]
[FONTS][SETUP][BOOTDATA] Add Lucida Console font (#1793)
Add "Lucida Console" fonts. CORE-16264
- Add "Lucida Console" font by duplicating "DejaVu Sans Mono" font and renaming it.
- Delete some "Lucida Console" font substitutes.
- Add LICENSE file.
I used FontForge to rename it. Its family name is "Lucida Console". Its display name is "Lucida Console". Its font filename is lucon.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Sun, 4 Aug 2019 06:37:34 +0000 (15:37 +0900)]
[MEDIA][FONTS] Add Arial Black font (#1792)
Add "Arial Black" font. CORE-16264
- Add "Arial Black" font that is based on "Archivo Black" font of Omnibus-Type.
- Add LICENSE file.
"Archivo Black" is similar to MS "Arial Black" in its metrics. I used FontForge to rename the font. The font filename is ariblk.ttf. The family name is "Arial Black". The display name is "Arial Black". The Underline Position is hacked for workaround of FontForge's bug.
Katayama Hirofumi MZ [Sun, 4 Aug 2019 06:15:52 +0000 (15:15 +0900)]
[WIN32SS][NTGDI] Fix condition of bold emulation (#1787)
- Define EMUBOLD_NEEDED macro to determine the condition of bold emuration necessity.
- Use this macro.
- Loose the condition.
Katayama Hirofumi MZ [Sun, 4 Aug 2019 03:11:55 +0000 (12:11 +0900)]
[FONTS][SETUP] Add Trebuchet MS fonts (#1791)
Add "Trebuchet MS" fonts. CORE-16272
- Add "Trebuchet MS", "Trebuchet MS Bold", "Trebuchet MS Bold Italic" and "Trebuchet MS Italic" fonts by duplicating "Open Sans" fonts and renaming them.
- Delete some "Trebuchet MS" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Trebuchet MS". Their display names are "Trebuchet MS", "Trebuchet MS Bold", "Trebuchet MS Bold Italic" and "Trebuchet MS Italic". Their font filenames are trebuc.ttf, trebucbd.ttf, trebucbi.ttf and trebucit.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Sun, 4 Aug 2019 02:22:51 +0000 (11:22 +0900)]
[FONTS][SETUP][BOOTDATA] Add Times New Roman fonts (#1790)
Add "Times New Roman" fonts. CORE-16272
- Add "Times New Roman" and "Times New Roman Italic" fonts by duplicating "Liberation Serif" fonts and renaming them.
- Delete some "Times New Roman" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Times New Roman". Their display names are "Times New Roman", "Times New Roman Bold", "Times New Roman Bold Italic" and "Times New Roman Italic". Their font filenames are times.ttf, timesbd.ttf, timesbi.ttf and timesi.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Mark Jansen [Sat, 3 Aug 2019 23:55:18 +0000 (01:55 +0200)]
[WIN32SS] Improve font loading failure logging
Mark Jansen [Sat, 3 Aug 2019 22:12:34 +0000 (00:12 +0200)]
[WIN32SS] Only access a font face if it was actually loaded
Shy Zedaka [Sat, 3 Aug 2019 21:34:20 +0000 (00:34 +0300)]
[SYSDM] Fix Re-sizing License Prompt (#1789)
CORE-16278
Pierre Schweitzer [Sat, 3 Aug 2019 19:55:28 +0000 (21:55 +0200)]
[SMSS] Use the appropriate security descriptor when creating the LPC port
Eric Kohl [Sat, 3 Aug 2019 19:52:00 +0000 (21:52 +0200)]
[DEVMGR] Change the menu id prefix from IDC_ to IDM_.
Eric Kohl [Sat, 3 Aug 2019 14:37:54 +0000 (16:37 +0200)]
[DEVMGR] Fix the indentation of the menu resources. No code changes!
Eric Kohl [Sat, 3 Aug 2019 13:04:50 +0000 (15:04 +0200)]
[WINLOGON] Load the notification dlls on demand
Do not keep the notifications loaded until shutdown. Load and unload them when a notification routine must be called.
Oleg Dubinskiy [Thu, 1 Aug 2019 20:37:35 +0000 (23:37 +0300)]
[USBAUDIO] Fix compilation issues
Eric Kohl [Sat, 3 Aug 2019 12:53:00 +0000 (14:53 +0200)]
[DEVMGR] Fix wonky action menu
Patch by Pi_User5.
CORE-10364
Katayama Hirofumi MZ [Sat, 3 Aug 2019 10:03:27 +0000 (19:03 +0900)]
[FONTS][SETUP] Add Franklin Gothic Medium fonts (#1786)
Add "Franklin Gothic Medium" fonts. CORE-16272
- Add "Franklin Gothic Medium" and "Franklin Gothic Medium Italic" fonts by duplicating Alexei Vanyashin's "Libre Franklin" fonts and renaming them.
- Delete some "Franklin Gothic Medium" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Franklin Gothic Medium". Their display names are "Franklin Gothic Medium" and "Franklin Gothic Medium Italic". Their font filenames are framd.ttf and framdit.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Alexei Vanyashin's "Libre Franklin" fonts are available at https://github.com/alexeiva/Libre-Franklin .
Katayama Hirofumi MZ [Sat, 3 Aug 2019 07:24:32 +0000 (16:24 +0900)]
[FONTS][SETUP] Add Palatino Linotype fonts (#1785)
Add "Palatino Linotype" fonts. CORE-16272
- Add "Palatino Linotype", "Palatino Linotype Bold", "Palatino Linotype Bold Italic" and "Palatino Linotype Italic" fonts by duplicating "DejaVu Serif" fonts and renaming them.
- Delete some "Palatino Linotype" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Palatino Linotype". Their display names are "Palatino Linotype", "Palatino Linotype Bold", "Palatino Linotype Bold Italic" and "Palatino Linotype Italic". Their font filenames are pala.ttf, palab.ttf, palabi.ttf and palai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Sat, 3 Aug 2019 02:28:10 +0000 (11:28 +0900)]
[FONTS] s/Geogia/Georgia/
Katayama Hirofumi MZ [Sat, 3 Aug 2019 01:43:09 +0000 (10:43 +0900)]
[FONTS][SETUP] Add Geogia fonts (#1784)
Add "Geogia" fonts. CORE-16272
- Add "Geogia", "Geogia Bold", "Geogia Bold Italic" and "Geogia Italic" fonts by duplicating FreeSerif fonts and renaming them.
- Delete some "Geogia" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Geogia". Their display names are "Geogia", "Geogia Bold", "Geogia Bold Italic" and "Geogia Italic". Their font filenames are georgia.ttf, georgiab.ttf, georgiaz.ttf and georgiai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Sat, 3 Aug 2019 00:05:14 +0000 (09:05 +0900)]
[FONTS][BOOTDATA][SETUP] Add Courier New fonts (#1783)
Add "Courier New" fonts. CORE-16272
- Add "Courier New", "Courier New Bold", "Courier New Bold Italic" and "Courier New Italic" fonts by duplicating FreeMono fonts and renaming them.
- Delete some "Courier New" font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Courier New". Their display names are "Courier New", "Courier New Bold", "Courier New Bold Italic" and "Courier New Italic". Their font filenames are cour.ttf, courbd.ttf, courbi.ttf and couri.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Fri, 2 Aug 2019 11:37:53 +0000 (20:37 +0900)]
[FONTS][SETUP][BOOTDATA] Add Arial fonts (#1781)
Add Arial fonts. CORE-16272
- Add "Arial", "Arial Bold", "Arial Bold Italic" and "Arial Italic" fonts by duplicating Liberation Sans fonts and renaming them.
- Disable some Arial font substitutes.
- Add LICENSE file.
I made these font files by using FontForge. Their family name is "Arial". Their display names are "Arial", "Arial Bold", "Arial Bold Italic" and "Arial Italic". Their font filenames are arial.ttf, arialbd.ttf, arialbi.ttf and ariali.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.
Katayama Hirofumi MZ [Fri, 2 Aug 2019 11:28:30 +0000 (20:28 +0900)]
[WIN32SS][NTGDI] Improve IntGetOutlineTextMetrics (#1760)
Improve size checking of IntGetOutlineTextMetrics function.
Hermès Bélusca-Maïto [Thu, 23 Aug 2018 19:44:53 +0000 (21:44 +0200)]
[KERNEL32] Minor enhancements for CreateRemoteThread(). (#804)
- Add some cleanup code in failure code paths, instead of asserting.
- Move BasepNotifyCsrOfThread() helper to the only file where it is used.
- Don't use ERROR_DBGBREAK in failure paths but just DPRINT the error
message: we handle the failures properly.
- When creating the remote thread, sync its service tag with the parent
thread's one.
Hermès Bélusca-Maïto [Thu, 26 May 2016 02:44:25 +0000 (04:44 +0200)]
[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. (#802)
- kernel32!BaseCreateStack() is compatible with ntdll!RtlpCreateUserStack().
- When checking whether a stack guard page can be added, its size has to
be accounted for in the checking logic.
- We have to satisfy the PEB::MinimumStackCommit constraint.
- We cannot use PEB::GuaranteedStackBytes in BaseCreateStack() since it is
nowhere initialized (default is 0). It gets initialized to a non-zero
value when the user manually calls SetThreadStackGuarantee().
https://www.installsetupconfig.com/win32programming/windowsthreadsprocessapis7_6.html
- RtlpCreateUserStack(): Fix memory leak in failure case.
- RtlpFreeUserStack() doesn't need to return anything.
See also commit
1bc59379 (r59868).
CORE-11319
Katayama Hirofumi MZ [Thu, 1 Aug 2019 03:29:43 +0000 (12:29 +0900)]
[MEDIA][FONTS] Add Hebrew MS Sans Serif (ssee1255.fon)
Katayama Hirofumi MZ [Wed, 31 Jul 2019 13:24:01 +0000 (22:24 +0900)]
[WIN32SS][NTGDI][NTUSER] Make gusLanguageID USHORT (#1776)
Every language ID is an unsigned integer.
- Make gusLanguageID unsigned.
- Make the return value type of UserGetLanguageID unsigned.
Katayama Hirofumi MZ [Wed, 31 Jul 2019 12:57:42 +0000 (21:57 +0900)]
[FREETYPE] Improve font rendering with font hinting workaround (#1771)
CORE-15762, CORE-16232
It seems some fonts are blurry or in bad rendering because of FreeType Font Hinting implementation.
This PR is subpixel2.patch from CORE-16232, based on the following comment:
https://bugs.launchpad.net/ubuntu/+source/freetype/+bug/
1722508/comments/29
Katayama Hirofumi MZ [Wed, 31 Jul 2019 08:43:08 +0000 (17:43 +0900)]
[SETUP] Add codepage-specific font substitutes (#1772)
Add codepage-specific font substitutes for i18n. CORE-16266
Joachim Henze [Tue, 30 Jul 2019 23:58:42 +0000 (01:58 +0200)]
[INTL] Addendum to CORE-16252
That change was not intended.in
commit 0.4.13-dev-740-g
8b67edd8fa2b51d7d5a710e8867123246b72f524
Thx to Stas'M for noticing the windres warning.
Joachim Henze [Tue, 30 Jul 2019 21:12:24 +0000 (23:12 +0200)]
[INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaafbccb0e9b52926d41626d5a4dc38cd
Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
Eric Kohl [Tue, 30 Jul 2019 21:09:32 +0000 (23:09 +0200)]
[LSASRV] Improvements to LsapLogonUser()
- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.
Stanislav Motylkov [Tue, 30 Jul 2019 21:01:23 +0000 (00:01 +0300)]
[CONFIGURE] Add MSVC compiler 19.22.27905 (VS Community 2019) (#1774)
Katayama Hirofumi MZ [Tue, 30 Jul 2019 13:05:11 +0000 (22:05 +0900)]
[SETUP] Sort font substitutes (#1770)
Sort the font substitute setting lists in base/setup/lib/muifonts.h .
Katayama Hirofumi MZ [Tue, 30 Jul 2019 10:09:23 +0000 (19:09 +0900)]
[SETUP] Delete 'Comic Sans MS' font substitutes (#1769)
Enable real 'Comic Sans MS' font by deleting the 'Comic Sans MS' font substitutes. CORE-16251
Katayama Hirofumi MZ [Tue, 30 Jul 2019 09:15:56 +0000 (18:15 +0900)]
[WIN32SS][NTGDI] Fix and improve font dumping (#1768)
Fix and improve font dumping. CORE-16245
- FontGDI->FontObj is not a pointer.
- "%s" does null check, so we remove redundant null checks.
- Add FaceName and StyleName dumping.
Hermès Bélusca-Maïto [Mon, 29 Jul 2019 22:57:22 +0000 (00:57 +0200)]
[FREELDR] Improve some *GetFileInformation() traces.
Stanislav Motylkov [Mon, 29 Jul 2019 22:27:36 +0000 (01:27 +0300)]
[FREELDR] Fix remaining hwdisk and FATX bugs (#1766)
- DiskGetFileInformation() should return relative addresses -- relative to the beginning of the "device" (partition, or disk) in question.
- FatXSearchDirectoryBufferForFile() should assign file attributes.
- Minor code style improvements in FatOpenVolume().
CORE-16216 CORE-16248
Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
Tibor Lajos Füzi [Mon, 29 Jul 2019 19:55:24 +0000 (21:55 +0200)]
[KBDHU] Fix Hungarian keyboard layout. (#1765)
CORE-15567
jimtabor [Mon, 29 Jul 2019 18:02:07 +0000 (13:02 -0500)]
[NtGDI] Fix one size region test.
See CORE-16246, the clip region may be the same size but more complex
than the callers simple region.
Stanislav Motylkov [Mon, 29 Jul 2019 12:25:54 +0000 (15:25 +0300)]
[FREELDR] Implement proper partition type detection and handling (#1762)
- This allows to detect and dynamically handle different partitioning schemes.
- Implemented detection of MBR, GPT, Xbox-BRFR, and partitionless disks.
- Currently only MBR and Xbox-BRFR partitions are handled and tested.
CORE-9841 CORE-15768 CORE-16216 CORE-16248
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 23:38:10 +0000 (01:38 +0200)]
[USER32] Fix build after
51d031cc ; addendum to
f21871fb (r69249) and
cf98f01e (r72650). CORE-10194
Eric Kohl [Sun, 28 Jul 2019 22:10:26 +0000 (00:10 +0200)]
[MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:32:14 +0000 (00:32 +0200)]
[USER32] Use the correct __REACTOS__ define.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:31:56 +0000 (00:31 +0200)]
[NDK] Use the correct __REACTOS__ define.
Jose Carlos Jesus [Sun, 28 Jul 2019 22:20:40 +0000 (23:20 +0100)]
[NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761)
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:20:07 +0000 (00:20 +0200)]
[PSDK] ks.h : Fix some IOCTL values, caught by Ben Nottelling.
Eric Kohl [Sun, 28 Jul 2019 20:37:17 +0000 (22:37 +0200)]
[W32TIME] Use an event to stop the service
CORE-16180
Stanislav Motylkov [Sun, 28 Jul 2019 16:20:53 +0000 (19:20 +0300)]
[FREELDR] Trivial improvements (#1757)
* [FREELDR] Fix uninitialized string in DiskGetBootPath()
CORE-16216 CORE-16248
* [FREELDR] xboxdisk: Add comment and fix code style
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:23:02 +0000 (00:23 +0200)]
[DLLs] Fix .spec files regarding OLE-specific exports.
- Do not use hardcoded ordinals, add missing '-private'.
Except for MSXML3, OLE32 and RSAENH, see commit
bff824b2 for more details.
- SHSVCS: The 6 first exports are nonamed with ordinals. Replace exported
commented stubs by actual exported stubs instead.
Co-Authored-By: Timo Kreuzer <timo.kreuzer@reactos.org>
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:11:18 +0000 (00:11 +0200)]
[SPEC2DEF] Check whether OLE-specific exports do not have assigned ordinals, as they should be.
The check is done at the same time as when we check also that these
exports are marked PRIVATE or not.
This permits us to check for the same conditions as MS' LINK.EXE, but
here on GCC builds as well.
See the following pages for more details:
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4104
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4222
In this last page (LNK4222), the specified list of exports is incomplete.
Manual tests showed that the very same list as for LNK4104 is checked.
Eric Kohl [Sun, 28 Jul 2019 12:57:46 +0000 (14:57 +0200)]
[MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete.
jimtabor [Sat, 27 Jul 2019 19:15:42 +0000 (14:15 -0500)]
[GDI32] Allow functions to access printing support.
Reapplying lost committed code.
jimtabor [Sat, 27 Jul 2019 19:13:14 +0000 (14:13 -0500)]
[GDI32] Add more to Local DC structure.
Make the two structures identical. These are used for printing and
enhanced metafile support.
Eric Kohl [Sat, 27 Jul 2019 17:59:32 +0000 (19:59 +0200)]
[PSDK] Add missing UnregisterDeviceNotification() to winuser.h.
Eric Kohl [Sat, 27 Jul 2019 14:54:15 +0000 (16:54 +0200)]
[AUDIOSVC] Fix the coding style. No code changes!
Oleg Dubinskiy [Fri, 28 Jun 2019 13:45:32 +0000 (16:45 +0300)]
[USETUP] Use "L" key instead of "D" for deleting partitions at 1st setup stage
Timo Kreuzer [Sun, 26 May 2019 11:37:31 +0000 (13:37 +0200)]
[REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result still unsigned
Joachim Henze [Sat, 27 Jul 2019 08:00:42 +0000 (10:00 +0200)]
[WIN32SS] Addendum to font alignment CORE-16133
addendum to 0.4.13-dev-707-g
0e4db883e5727569b5c3a35da3a6f8c5e921bbf3
Jim Tabor intended to structurally use flTextAlign over
lTextAlign internally within IntExtTextOutW().
He initially committed these changes in 0.4.12-dev-805-g
3377fe184efa77e7c4971c2ac70ed33ab12f0724
But we unintentionally lost these changes via 0.4.13-dev-370-g
8f482af0a876d269cca64288f114eb1fe1180ef0
Many thanks to Doug Lyons who helped a lot with fixing CORE-16133.
Katayama Hirofumi MZ [Sat, 27 Jul 2019 05:53:06 +0000 (14:53 +0900)]
[MEDIA][FONTS] Add Comic Sans MS fonts (comic.ttf, comicbd.ttf) (#1754)
Add Comic Sans MS font files. CORE-16237
Add "Comic Relief" fonts by Jeff Davis under SIL Open Font License in the name of "Comic Sans MS". We cannot choose Comic Sans MS currently but it's font engine's bug.
Hermès Bélusca-Maïto [Fri, 26 Jul 2019 12:53:03 +0000 (14:53 +0200)]
[WINHLP32] All the lang resource files are in UTF-8.
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:45:11 +0000 (21:45 +0900)]
[USER32_APITEST] Add #include 'precomp.h' in MessageStateAnalyzer
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:30:36 +0000 (21:30 +0900)]
[USER32_APITEST] Move <strsafe.h> #inclusion
Katayama Hirofumi MZ [Fri, 26 Jul 2019 10:13:00 +0000 (19:13 +0900)]
[WIN32SS][NTGDI] text/font vertical alignment patch CORE-16133
Based on Doug Lyons' patch. It partially fix CORE-16246 and CORE-16133.
Selection area is not fixed yet.
Serge Gautherie [Wed, 24 Jul 2019 17:59:07 +0000 (19:59 +0200)]
[CODEOWNERS] Add UniATA (#1689)
Shy Zedaka [Wed, 24 Jul 2019 17:56:48 +0000 (20:56 +0300)]
[TRANSLATION] Hebrew Translations For Setup (#1750)
Oleg Dubinskiy [Wed, 24 Jul 2019 17:56:33 +0000 (20:56 +0300)]
[DSOUND_NEW] Remove unused dsound_convert.c file (#1748)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:45:55 +0000 (01:45 +0900)]
[USER32_APITEST][INCLUDE] Add MessageStateAnalyzer testcase (#1732)
I want to visualize the message stream and verify the states of each message. ROSTESTS-328
- Add a testcase named MessageStateAnalyzer into user32_apitest.
- Also fix type casts in <windowsx.h>.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:40:33 +0000 (01:40 +0900)]
[USER32][NTUSER] Fix menu arrow drawing (of DrawFrameControl) (#1752)
CORE-13211
user32!DrawFrameControl drawed invalid menu arrow when the width is shorter than the height.
- Use the squared rectangle.
- Draw it in the transparent background mode.
- Save the old background mode of HDC.
This PR will fix UltraISO's bug.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 06:39:10 +0000 (15:39 +0900)]
[MEDIA][FONTS] RAPPS checkmark fix (#1751)
The checkmarks of RAPPS were strange. This PR will fix the checkmark ("b") of 12px bitmap glyph of Marlett.ttf font file. CORE-14872
Katayama Hirofumi MZ [Tue, 23 Jul 2019 12:55:38 +0000 (21:55 +0900)]
[MEDIA][FONTS] Add copyright notice of TransGaming Technologies
With some font error fixed. CORE-16226
Katayama Hirofumi MZ [Tue, 23 Jul 2019 07:03:30 +0000 (16:03 +0900)]
[MEDIA][FONTS] Renewal of Marlett.ttf (#1749)
Renewal of Marlett.ttf font file. CORE-16226, CORE-14872
- Based on Ged Murphy's Marlett.ttf (See https://github.com/reactos/reactos/blob/
527f2f90577662e8eba1b1b62f958c39b3cd4358/media/fonts/Marlett.ttf).
- Erase the centered triangles.
- Adjustment of glyphs.
- Clarify the copyright ownership.
- Tested with 3 test programs (RadioAndCheck, PixelPerfectGlyph and MarlettCompare).
Doug-Lyons [Sat, 22 Jun 2019 16:23:11 +0000 (11:23 -0500)]
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684)
CORE-16123
- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
their non-volatile counterparts.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Bișoc George [Wed, 19 Jun 2019 15:51:11 +0000 (17:51 +0200)]
[UMPNPMGR] Implement registry functions for SuppressUI and SuppressNewHWUI handling. (#1683)
CORE-15897
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Eric Kohl [Sun, 21 Jul 2019 16:56:02 +0000 (18:56 +0200)]
[SRVSVC][WKSSVC] Set the stop pending status before stopping the services and stop the RPC listener on shutdown as well.
Eric Kohl [Sun, 21 Jul 2019 16:51:33 +0000 (18:51 +0200)]
[WMISERV][WUAUSERV] Stop the service if the stop event creation fails.
Erdem Ersoy [Sun, 21 Jul 2019 15:49:12 +0000 (18:49 +0300)]
[TRANSLATIONS] Update Turkish translations (#1650)
Translations for Solitaire, Spider, WinMine, Notepad, Wordpad & Write, MSPaint, MPlay32, SndRec32, WinHlp32, SndVol32, TaskMgr and Calc.
Benjamin Aerni [Sat, 13 Jul 2019 06:42:10 +0000 (23:42 -0700)]
[W32TIME] Use a reasonable fallback of 9 hours. (#1724)
CORE-16181
This allows preventing spamming the time servers if the registry entry
becomes corrupted or missing. Also, disallow a setting of less than
2 minutes for the same reasons, and instead use the fallback of 9 hours.