reactos.git
5 weeks ago[FREELDR] Cache INT13h drive data in pcdisk.c (#2097)
disean [Tue, 14 Jan 2020 03:08:53 +0000 (09:08 +0600)]
[FREELDR] Cache INT13h drive data in pcdisk.c (#2097)

* [FREELDR] Cache the drive geometry in the PcDiskReadLogicalSectorsCHS()

Speed up the loading time a bit.

* [FREELDR] Generalize the cache to all the geometry data + INT 13h extensions-supported status.

The data structure used is "PC_DISK_DRIVE".

- Adapt the associated functions;
- Make DiskGetExtendedDriveParameters() private to pcdisk.c

- Introduce PcDiskDriveNumberToDrive(), that is similar to the XBOX
  function XboxDiskDriveNumberToDeviceUnit(), that retrieves a valid
  pointer to the cached disk corresponding to the given BIOS DriveNumber.
  If needed the cached data gets initialized.

- Make XboxDiskDriveNumberToDeviceUnit() simpler by just returning the
  pointer to the corresponding drive, of NULL if there is none.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
5 weeks ago[MSGINA] Improve Japanese status dialog (#2248)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 14:01:39 +0000 (23:01 +0900)]
[MSGINA] Improve Japanese status dialog (#2248)

Improve Japanese translation (IDD_STATUS).

5 weeks ago[SHELL32] Improve Japanese folder property sheet (#2247)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 13:47:26 +0000 (22:47 +0900)]
[SHELL32] Improve Japanese folder property sheet (#2247)

Improve Japanese translation.

5 weeks ago[SHELL32][SHLWAPI] Improve Japanese file property sheet (#2246)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 13:33:50 +0000 (22:33 +0900)]
[SHELL32][SHLWAPI] Improve Japanese file property sheet (#2246)

- Improve file property dialog (IDD_FILE_PROPERTIES).
- Translate shlwapi resource into Japanese.

6 weeks ago[FREELDR] Add ATA/ATAPI driver. (#2167) 2167/head
Dmitry Borisov [Sun, 22 Dec 2019 21:52:40 +0000 (03:52 +0600)]
[FREELDR] Add ATA/ATAPI driver. (#2167)
CORE-16220 CORE-16216

* Create a new driver.
* Use the functions from the library in xboxdisk.c

Driver now supports PC, Xbox and NEC PC-98.

Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
6 weeks ago[DNSAPI] Answer queries for ip addresses before they are passed to the resolver cache.
Eric Kohl [Sun, 12 Jan 2020 14:15:06 +0000 (15:15 +0100)]
[DNSAPI] Answer queries for ip addresses before they are passed to the resolver cache.

6 weeks ago[NETCFGX] Notify the installer of changes to the properties
Eric Kohl [Sat, 11 Jan 2020 15:25:37 +0000 (16:25 +0100)]
[NETCFGX] Notify the installer of changes to the properties

6 weeks ago[WIN32SS][WINSRV] Fullwidth character handling Part 2 (#2240)
Katayama Hirofumi MZ [Sun, 12 Jan 2020 13:04:57 +0000 (22:04 +0900)]
[WIN32SS][WINSRV] Fullwidth character handling Part 2 (#2240)

Follow-up of #2231. Also fix FillConsoleOutputAttribute, WriteConsoleOutputCharacterW and WriteConsoleOutputAttribute functions.
CORE-12451

6 weeks ago[CMD_APITEST] Add more regression tests for attrib 2141/head
Doug Lyons [Sun, 8 Dec 2019 14:23:22 +0000 (08:23 -0600)]
[CMD_APITEST] Add more regression tests for attrib

6 weeks ago[NTFS] Fix use after free in failure case of NtfsMountVolume.
Thomas Faber [Sat, 11 Jan 2020 13:08:20 +0000 (14:08 +0100)]
[NTFS] Fix use after free in failure case of NtfsMountVolume.

NtfsGetVolumeData frees FileRecLookasideList in case of failure, so don't
free it again.
Dereferencing NewDeviceObject invalidates Vcb.

6 weeks ago[UDFS] Fix uninitialized var use in UDFCommonCreate, return the right error code
Suraj K Suresh [Fri, 10 Jan 2020 10:09:14 +0000 (15:39 +0530)]
[UDFS] Fix uninitialized var use in UDFCommonCreate, return the right error code
CORE-16174

6 weeks ago[APISETS] Forwarders don't need parameter specifications (#2225)
Serge Gautherie [Fri, 10 Jan 2020 13:20:53 +0000 (14:20 +0100)]
[APISETS] Forwarders don't need parameter specifications (#2225)

Addendum to 192926ee.

6 weeks ago[TRANSLATION] [SHELL32] Improvements to Portuguese translation (#2228)
Jose Carlos Jesus [Fri, 10 Jan 2020 12:44:55 +0000 (12:44 +0000)]
[TRANSLATION] [SHELL32] Improvements to Portuguese translation (#2228)

And minor adjustments because of text lenght.

6 weeks ago[KERNEL32_APITEST] Strengthen ConsoleCP for Writing functions (#2235)
Katayama Hirofumi MZ [Wed, 8 Jan 2020 12:20:24 +0000 (21:20 +0900)]
[KERNEL32_APITEST] Strengthen ConsoleCP for Writing functions (#2235)

Add some tests for WriteConsoleOutputCharacterW and WriteConsoleOutputAttribute etc. into ConsoleCP testcase. CORE-12451

6 weeks ago[SERVICES] Use the local system account to run all services on a LiveCD
Eric Kohl [Tue, 7 Jan 2020 23:14:50 +0000 (00:14 +0100)]
[SERVICES] Use the local system account to run all services on a LiveCD

This fixes CORE-16589.

6 weeks ago[KS] KsQueryInformationFile(): Fix 'FastIoQueryBasicInfo' copypasta (#2236)
Serge Gautherie [Tue, 7 Jan 2020 14:13:40 +0000 (15:13 +0100)]
[KS] KsQueryInformationFile(): Fix 'FastIoQueryBasicInfo' copypasta (#2236)

Addendum to commit 4725a4fd (r42117).

6 weeks ago[WIN32SS][WINSRV] Fullwidth character handling for Asian console (#2231)
Katayama Hirofumi MZ [Tue, 7 Jan 2020 06:26:58 +0000 (15:26 +0900)]
[WIN32SS][WINSRV] Fullwidth character handling for Asian console (#2231)

Far-East Asian language (Chinese, Japanese and Korean; CJK) needs special handling in console.
Especially a fullwidth character (mk_wcwidth_cjk(ch) == 2) needs a double width space. A fullwidth character on the console window is treated as a pair of a leading byte and a trailing byte (COMMON_LVB_LEADING_BYTE and COMMON_LVB_TRAILING_BYTE). CORE-12451

6 weeks ago[DESK] The DisplayClassInstaller must create a new DeviceX subkey for each new displa...
Eric Kohl [Mon, 6 Jan 2020 21:38:53 +0000 (22:38 +0100)]
[DESK] The DisplayClassInstaller must create a new DeviceX subkey for each new display devices

This should fix CORE-16615

6 weeks ago[USB] Update the names of new USB drivers
Oleg Dubinskiy [Thu, 2 Jan 2020 13:05:51 +0000 (15:05 +0200)]
[USB] Update the names of new USB drivers

6 weeks ago[SDK][USB] Delete old USB drivers and libusb
Oleg Dubinskiy [Thu, 2 Jan 2020 13:01:32 +0000 (15:01 +0200)]
[SDK][USB] Delete old USB drivers and libusb

7 weeks ago[WINHTTP_WINETEST] Skip several tests from execution in order to prevent
Victor Perevertkin [Mon, 6 Jan 2020 02:36:39 +0000 (05:36 +0300)]
[WINHTTP_WINETEST] Skip several tests from execution in order to prevent
testbot hangs.
ROSTESTS-350

7 weeks ago[DNSRSLVR] R_ResolverFlushCache should only flush cached records which were not read...
Eric Kohl [Sun, 5 Jan 2020 23:45:41 +0000 (00:45 +0100)]
[DNSRSLVR] R_ResolverFlushCache should only flush cached records which were not read from the hosts file

7 weeks ago[WININET_WINETEST] http: Remove ROSTESTS_73_FIXED workaround
Serge Gautherie [Thu, 2 Jan 2020 02:42:07 +0000 (03:42 +0100)]
[WININET_WINETEST] http: Remove ROSTESTS_73_FIXED workaround

ROSTESTS-73

7 weeks ago[TIMEDATE] Update the clock on WM_TIMECHANGE
Eric Kohl [Sun, 5 Jan 2020 11:21:53 +0000 (12:21 +0100)]
[TIMEDATE] Update the clock on WM_TIMECHANGE

7 weeks ago[SYSDM] Improve the user profile dialog
Eric Kohl [Sat, 4 Jan 2020 13:54:30 +0000 (14:54 +0100)]
[SYSDM] Improve the user profile dialog

- Currently used profiles cannot be copied or deleted.
- Unknown profiles cannot be copied.
- A double click on a profile opens the change profile type dialog.

7 weeks ago[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385 2161/head
Suraj K Suresh [Tue, 24 Dec 2019 18:54:51 +0000 (00:24 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385

7 weeks ago[PSDK] Support STRICT_TYPED_ITEMIDS in shlwapi.h. CORE-16385
Suraj K Suresh [Tue, 24 Dec 2019 15:48:43 +0000 (21:18 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shlwapi.h. CORE-16385

7 weeks ago[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385
Suraj K Suresh [Mon, 23 Dec 2019 08:51:51 +0000 (14:21 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385

7 weeks ago[CRT] Define _INTEGRAL_MAX_BITS only if it isn't already defined by the compiler...
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 18:33:21 +0000 (19:33 +0100)]
[CRT] Define _INTEGRAL_MAX_BITS only if it isn't already defined by the compiler. CORE-16555

7 weeks ago[NTDLL_APITEST] Addendum to ae8c9a1f: really test the "zero Length, non-zero MaximumL...
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 16:41:14 +0000 (17:41 +0100)]
[NTDLL_APITEST] Addendum to ae8c9a1f: really test the "zero Length, non-zero MaximumLength" case. + add few simplifications.

7 weeks ago[BLUE] Add IOCTL buffers validation. Addendum to commit bfd8a848. 2172/head
Hermès Bélusca-Maïto [Tue, 24 Dec 2019 12:27:15 +0000 (13:27 +0100)]
[BLUE] Add IOCTL buffers validation. Addendum to commit bfd8a848.

Also convert all sizes and positions of CONSOLE_DRAW to USHORT since
this is the standard type for all console buffer positions & sizes
(minimum value 0, maximum value 0xFFFF == 65535).

7 weeks ago[NTDLL] Architecture specific spec file improvements
Timo Kreuzer [Sat, 21 Sep 2019 17:37:03 +0000 (19:37 +0200)]
[NTDLL] Architecture specific spec file improvements

7 weeks ago[NTDLL] Remove redundant Zw* -> Nt* forwarders
Timo Kreuzer [Sat, 21 Sep 2019 15:45:01 +0000 (17:45 +0200)]
[NTDLL] Remove redundant Zw* -> Nt* forwarders

7 weeks ago[NTDLL] Add some more stub exports
Timo Kreuzer [Sat, 21 Sep 2019 13:48:59 +0000 (15:48 +0200)]
[NTDLL] Add some more stub exports

7 weeks ago[RTL][NTDLL] Add some function stubs
Timo Kreuzer [Sat, 21 Sep 2019 10:46:01 +0000 (12:46 +0200)]
[RTL][NTDLL] Add some function stubs

- LdrSetAppCompatDllRedirectionCallback
- RtlCancelTimer
- RtlCreateServiceSid
- RtlQueryProcessHeapInformation
- RtlQueueApcWow64Thread
- RtlSetTimer
- RtlUnhandledExceptionFilter2
- RtlpNotOwnerCriticalSection

7 weeks ago[NTDLL] Export some more existing functions
Timo Kreuzer [Sat, 21 Sep 2019 11:26:54 +0000 (13:26 +0200)]
[NTDLL] Export some more existing functions

7 weeks ago[NTDLL] Ordinals -> @
Timo Kreuzer [Thu, 19 Sep 2019 13:56:29 +0000 (15:56 +0200)]
[NTDLL] Ordinals -> @

7 weeks ago[SPEC2DEF] Set ordinals explicitly in export def file
Timo Kreuzer [Sun, 22 Sep 2019 12:59:09 +0000 (14:59 +0200)]
[SPEC2DEF] Set ordinals explicitly in export def file

The reason is that dlltool orders the exports differently than MSVC builds (MSVC orders the exports by symbol name, rather than by export name), so we rely on sorting in the spec file, which was only respected, when ordinals were put into the def file.
On MSVC builds it is left to the linker to determine the correct order, which helps to get the differences between architectures right (different symbol decoration, difference between order for functions like NtLoadKey vs NtLoadKey2, which results from the stdcall decoration on x86, which is missing on other architectures.

TODO: To correctly handle non-x86 architectures with GCC builds, spec2def would need to reorder the export list based on symbol names, which would work for C functions, by taking the calling convention into account, but would require an extra c++-stdcall calling convention to be added to know the corresponding symbol starts with "?".

7 weeks ago[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64
Timo Kreuzer [Mon, 23 Sep 2019 11:57:32 +0000 (13:57 +0200)]
[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64

7 weeks ago[SETUP] Don't free a DLL that is still in use by a different thread
Timo Kreuzer [Tue, 13 Mar 2018 19:04:34 +0000 (20:04 +0100)]
[SETUP] Don't free a DLL that is still in use by a different thread

7 weeks ago[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531 2123/head
Thomas Faber [Sun, 1 Dec 2019 19:36:13 +0000 (20:36 +0100)]
[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531

The trap frame is in a random location on the stack, and setting Esp0 there
wastes significant amounts of space and may lead to unexpected stack overflows.

Also use a more descriptive expression for the V86 members of the KTRAP_FRAME.

7 weeks ago[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.
Thomas Faber [Tue, 31 Dec 2019 20:07:39 +0000 (21:07 +0100)]
[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.

7 weeks ago[WIN32K:NTGDI] Avoid breakpoints in syscalls.
Thomas Faber [Tue, 31 Dec 2019 20:06:43 +0000 (21:06 +0100)]
[WIN32K:NTGDI] Avoid breakpoints in syscalls.

7 weeks ago[NTOS:IO] Fix indentation. No code changes!
Eric Kohl [Thu, 2 Jan 2020 22:13:18 +0000 (23:13 +0100)]
[NTOS:IO] Fix indentation. No code changes!

7 weeks ago[LSASRV] Add parameter validation in LsapSetLogonSessionData().
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:47 +0000 (02:27 +0200)]
[LSASRV] Add parameter validation in LsapSetLogonSessionData().

7 weeks ago[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword...
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:08 +0000 (02:27 +0200)]
[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword(); fix crash in LsaApLogonUserEx2() when LogonDomainName points to a NULL string.

7 weeks ago[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:10:42 +0000 (21:10 +0100)]
[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.

7 weeks ago[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:09:32 +0000 (21:09 +0100)]
[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().

7 weeks ago[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.
Thomas Faber [Thu, 2 Jan 2020 15:26:50 +0000 (16:26 +0100)]
[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.

7 weeks ago[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607
Thomas Faber [Thu, 2 Jan 2020 12:27:19 +0000 (13:27 +0100)]
[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607

7 weeks ago[SHELL32] Fix extra fixme (#1975)
Maxim Smirnov [Thu, 2 Jan 2020 12:35:32 +0000 (15:35 +0300)]
[SHELL32] Fix extra fixme (#1975)

This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`

7 weeks ago[BOOTDATA] Add AppliedDPI registry value (#1966)
Oleg Dubinskiy [Thu, 2 Jan 2020 09:06:18 +0000 (11:06 +0200)]
[BOOTDATA] Add AppliedDPI registry value (#1966)

Add AppliedDPI DWORD registry value 0x00000060 (96 DPI) into HKCU\Control Panel\Desktop\WindowMetrics registry key. For now it does nothing, since saving DPI registry settings is not implemented yet. It's required only for ViStart 8 to be started successfully (with MS VB6 Runtime installed and wshom.ocx replaced). CORE-13877

7 weeks ago[FREELDR] Update ACPI Extended Attributes support to 6.3 (#1782) 1782/head
Serge Gautherie [Fri, 2 Aug 2019 15:39:50 +0000 (17:39 +0200)]
[FREELDR] Update ACPI Extended Attributes support to 6.3 (#1782)

Update BIOS_MEMORY_MAP and PcMemGetBiosMemoryMap() from ACPI 6.2-A to ACPI 6.3.

Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
7 weeks ago[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using... 1777/head
Hermès Bélusca-Maïto [Wed, 1 Jan 2020 20:08:37 +0000 (21:08 +0100)]
[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using a new PrintTextV() helper.

7 weeks ago[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268
Serge Gautherie [Wed, 31 Jul 2019 13:48:46 +0000 (15:48 +0200)]
[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268

Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
7 weeks ago[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.
Serge Gautherie [Wed, 31 Jul 2019 13:39:59 +0000 (15:39 +0200)]
[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
7 weeks ago[WS2_32_APITEST] Add some tests for GetAddrInfoW
Stanislav Motylkov [Sat, 28 Dec 2019 20:52:18 +0000 (23:52 +0300)]
[WS2_32_APITEST] Add some tests for GetAddrInfoW

Test results proves WSAStartup call should precede GetAddrInfoW calls.

7 weeks ago[SDK][INCLUDE] Total refinement of Gdiplus headers (#2223)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 11:28:42 +0000 (20:28 +0900)]
[SDK][INCLUDE] Total refinement of Gdiplus headers (#2223)

Missing functions added. CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdiplusgraphics.h (#2222)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 10:10:47 +0000 (19:10 +0900)]
[SDK][INCLUDE] Improve gdiplusgraphics.h (#2222)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdiplusmetafile.h (#2221)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 08:06:34 +0000 (17:06 +0900)]
[SDK][INCLUDE] Improve gdiplusmetafile.h (#2221)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdiplusmatrix.h (#2220)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 07:48:52 +0000 (16:48 +0900)]
[SDK][INCLUDE] Improve gdiplusmatrix.h (#2220)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdiplusstringformat.h (#2219)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:46 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdiplusstringformat.h (#2219)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdipluspath.h (#2218)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:05 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdipluspath.h (#2218)

CORE-16585

7 weeks ago[SDK][INCLUDE] Refinement of Gdiplus headers (#2217)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 04:53:30 +0000 (13:53 +0900)]
[SDK][INCLUDE] Refinement of Gdiplus headers (#2217)

Define getNat helper functions in gdiplusbase.h and use them. CORE-16585

7 weeks agoHappy New Year 2020 to everyone!!
Hermès Bélusca-Maïto [Tue, 31 Dec 2019 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2020 to everyone!!

🎊 🎆 🍾 🥳

.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
   __,  ,__)            __,  ,__)       __, ,__)        ░░▄████▄░▄███▄░▄████▄░▄███▄░░
  (--|__| _ ,_ ,_      (--|\ | _       (--\ | _  _ ,_   ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
    _|  |(_||_)|_)(_|    _| \|(/_(_|_)     \|(/_(_||    ░░░▄██▀░░██░██░░▄██▀░░██░██░░
   (        |  |  ,_|   (                (__|           ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.

   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
   ███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
   █████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
   ███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
   ██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
   █████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
   █████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
   █████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
   ██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
   ██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
   ███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
   ████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
   █████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
   ██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
   ██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
   ██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
   ███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
   ██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
   █████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
   ████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
   ███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
   ███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
   ██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
   ██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
   ██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
   ██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
   ██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
   ███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
   ██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
   ███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
   ████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
   ███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
   ███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
   ███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
   ███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
   ███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
   ███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
   ███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
   ███████████████████████████████████████████████████████████████████████████████

7 weeks ago[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success
Eric Kohl [Tue, 31 Dec 2019 22:23:23 +0000 (23:23 +0100)]
[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success

This fixes a failure in the QueryServiceConfig2 api test.

7 weeks ago[LSASRV] LsarLookupSids: Return proper domain information for nameless domains
Eric Kohl [Tue, 31 Dec 2019 16:59:10 +0000 (17:59 +0100)]
[LSASRV] LsarLookupSids: Return proper domain information for nameless domains

7 weeks ago[FREELDR] Obtain Xbox memory map via multiboot spec (#1971)
Stanislav Motylkov [Tue, 31 Dec 2019 15:10:34 +0000 (18:10 +0300)]
[FREELDR] Obtain Xbox memory map via multiboot spec (#1971)

- Also obtain framebuffer memory size the same way.

References:
https://wiki.osdev.org/Detecting_Memory_(x86)#Memory_Map_Via_GRUB
https://www.gnu.org/software/grub/manual/multiboot/multiboot.html#Boot-information-format

CORE-16216 CORE-16300

7 weeks ago[NTOS:KE] Rename some locking functions to reflect the IRQL level changes
Timo Kreuzer [Mon, 30 Dec 2019 14:34:38 +0000 (15:34 +0100)]
[NTOS:KE] Rename some locking functions to reflect the IRQL level changes

* KiAcquireApcLock -> KiAcquireApcLockRaiseToSynch
* KiAcquireApcLockAtDpcLevel -> KiAcquireApcLockAtSynchLevel
* KiReleaseApcLockFromDpcLevel -> KiReleaseApcLockFromSynchLevel
* KiAcquireApcLockAtApcLevel -> KiAcquireApcLockRaiseToDpc
* KiAcquireProcessLock -> KiAcquireProcessLockRaiseToSynch
* KiReleaseProcessLockFromDpcLevel -> KiReleaseProcessLockFromSynchLevel
* KiAcquireDispatcherLockAtDpcLevel -> KiAcquireDispatcherLockAtSynchLevel
* KiReleaseDispatcherLockFromDpcLevel -> KiReleaseDispatcherLockFromSynchLevel
* Add some ASSERTs

7 weeks ago[NTDLL_APITEST] Add a test for NtUnloadDriver. 2194/head
Thomas Faber [Sun, 29 Dec 2019 12:49:18 +0000 (13:49 +0100)]
[NTDLL_APITEST] Add a test for NtUnloadDriver.

7 weeks ago[APITESTS] Centrally define AllocateGuarded/FreeGuarded instead of duplicating them.
Thomas Faber [Wed, 10 Jul 2019 10:25:36 +0000 (12:25 +0200)]
[APITESTS] Centrally define AllocateGuarded/FreeGuarded instead of duplicating them.

7 weeks ago[NTOS:IO] Use UNICODE_STRING operations in IopUnloadDriver.
Thomas Faber [Sun, 29 Dec 2019 12:47:40 +0000 (13:47 +0100)]
[NTOS:IO] Use UNICODE_STRING operations in IopUnloadDriver.

Fixes several overflow vulnerabilities.

7 weeks ago[NTOS] Make RtlFindCharInUnicodeString available in the kernel.
Thomas Faber [Sun, 29 Dec 2019 12:46:15 +0000 (13:46 +0100)]
[NTOS] Make RtlFindCharInUnicodeString available in the kernel.

7 weeks ago[NDK] RtlFindCharInUnicodeString is only available in user mode.
Thomas Faber [Sun, 29 Dec 2019 12:44:59 +0000 (13:44 +0100)]
[NDK] RtlFindCharInUnicodeString is only available in user mode.

7 weeks ago[SDK][INCLUDE] Rename Gdiplus::Region::region as nativeRegion (#2212)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 14:14:52 +0000 (23:14 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Region::region as nativeRegion (#2212)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve Gdiplus::Graphics (#2211)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 11:40:16 +0000 (20:40 +0900)]
[SDK][INCLUDE] Improve Gdiplus::Graphics (#2211)

CORE-16585

7 weeks ago[SDK][INCLUDE] Rename Gdiplus::Graphics::graphics as nativeGraphics (#2210)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 10:24:59 +0000 (19:24 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Graphics::graphics as nativeGraphics (#2210)

Make it w32api-compatible. CORE-16585

7 weeks ago[SDK][INCLUDE] Move Gdiplus::TextureBrush codes (#2208)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 08:53:35 +0000 (17:53 +0900)]
[SDK][INCLUDE] Move Gdiplus::TextureBrush codes (#2208)

Move the code into the place it should be in. CORE-16585

7 weeks ago[NTOS] In KeWaitFor*Object(s) assert that the current IRQL is SYNCH_LEVEL. not DISPAT...
Timo Kreuzer [Thu, 30 May 2019 13:44:56 +0000 (15:44 +0200)]
[NTOS] In KeWaitFor*Object(s) assert that the current IRQL is SYNCH_LEVEL. not DISPATCH_LEVEL, since acquiring the dispatcher lock raises to SYNCH_LEVEL, which is != DISPATCH_LEVEL on x64 and SMP builds.

7 weeks ago[SDK][INCLUDE] Implement Gdiplus::Pen (#2207)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 08:11:38 +0000 (17:11 +0900)]
[SDK][INCLUDE] Implement Gdiplus::Pen (#2207)

CORE-16585

7 weeks ago[SDK][INCLUDE] Rename Gdiplus::Pen::pen as nativePen (#2206)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 06:45:57 +0000 (15:45 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Pen::pen as nativePen (#2206)

CORE-16585

7 weeks ago[SDK][INCLUDE] Implement Gdiplus::Brush (#2205)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 05:54:41 +0000 (14:54 +0900)]
[SDK][INCLUDE] Implement Gdiplus::Brush (#2205)

CORE-16585

7 weeks ago[SDK][INCLUDE] Rename Gdiplus::Brush::brush as nativeBrush (#2204)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 03:36:08 +0000 (12:36 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Brush::brush as nativeBrush (#2204)

Make it w32api-compatible. CORE-16585

7 weeks ago[SDK][INCLUDE] Improve Gdiplus::FontCollection (#2203)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:37:46 +0000 (11:37 +0900)]
[SDK][INCLUDE] Improve Gdiplus::FontCollection (#2203)

CORE-16585

7 weeks ago[SDK][INCLUDE] Implement Gdiplus::ImageAttributes (#2202)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:34:28 +0000 (11:34 +0900)]
[SDK][INCLUDE] Implement Gdiplus::ImageAttributes (#2202)

CORE-16585

7 weeks ago[SDK][INCLUDE] Implement Gdiplus::CustomLineCap (#2201)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:30:12 +0000 (11:30 +0900)]
[SDK][INCLUDE] Implement Gdiplus::CustomLineCap (#2201)

Implement Gdiplus::CustomLineCap and Gdiplus::AdjustableArrowCap. CORE-16585

7 weeks ago[SDK][TOOLS] Add do_code_format.sh to sdk/tools (#2191)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:28:56 +0000 (11:28 +0900)]
[SDK][TOOLS] Add do_code_format.sh to sdk/tools (#2191)

do_code_format.sh --- A command line tool using clang-format

7 weeks ago[SDK][INCLUDE] Implementing Gdiplus::GraphicsPath (#2200)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 00:23:45 +0000 (09:23 +0900)]
[SDK][INCLUDE] Implementing Gdiplus::GraphicsPath (#2200)

Point, PointF, Size, SizeF, Rect and RectF are also implemented. CORE-16585

7 weeks ago[WIN32SS][WINSRV] Add CSR API_NUMBER info comments (#2192)
Katayama Hirofumi MZ [Tue, 31 Dec 2019 00:21:42 +0000 (09:21 +0900)]
[WIN32SS][WINSRV] Add CSR API_NUMBER info comments (#2192)

Add comments to improve human-readability and referencing of CSR API. CORE-12451

7 weeks ago[NTOS:IO] Fix list enumeration in IopShutdownBaseFileSystems
Timo Kreuzer [Tue, 24 Dec 2019 17:31:59 +0000 (18:31 +0100)]
[NTOS:IO] Fix list enumeration in IopShutdownBaseFileSystems

7 weeks ago[WINHTTP_WINETEST] Restore test_persistent_connection execution
Victor Perevertkin [Thu, 19 Dec 2019 23:52:30 +0000 (02:52 +0300)]
[WINHTTP_WINETEST] Restore test_persistent_connection execution
This reverts commit a22031d
ROSTESTS-295

7 weeks ago[WINHTTP] Initialize winsock upon WinHttpOpen
Victor Perevertkin [Thu, 19 Dec 2019 22:43:07 +0000 (01:43 +0300)]
[WINHTTP] Initialize winsock upon WinHttpOpen
As it was done before syncing with wine-staging 4.18 (5bd6580)
ROSTESTS-348

7 weeks ago[SDK][INCLUDE] Improve gdiplusheader.h (#2197)
Katayama Hirofumi MZ [Mon, 30 Dec 2019 10:59:09 +0000 (19:59 +0900)]
[SDK][INCLUDE] Improve gdiplusheader.h (#2197)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdipluseffects.h (#2196)
Katayama Hirofumi MZ [Mon, 30 Dec 2019 10:57:55 +0000 (19:57 +0900)]
[SDK][INCLUDE] Improve gdipluseffects.h (#2196)

CORE-16585

7 weeks ago[SDK][INCLUDE] Improve gdipluscolor.h (#2195)
Katayama Hirofumi MZ [Mon, 30 Dec 2019 09:07:13 +0000 (18:07 +0900)]
[SDK][INCLUDE] Improve gdipluscolor.h (#2195)

CORE-16585

7 weeks ago[SDK][INCLUDE] Rename Gdiplus::Image::image as nativeImage (Retry) (#2189)
Katayama Hirofumi MZ [Mon, 30 Dec 2019 05:45:26 +0000 (14:45 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Image::image as nativeImage (Retry) (#2189)

CORE-16585

7 weeks ago[NTOS:KD] Fix wrong debug level checking logic in KdpPrint.
Victor Perevertkin [Thu, 19 Dec 2019 18:01:30 +0000 (21:01 +0300)]
[NTOS:KD] Fix wrong debug level checking logic in KdpPrint.
Use NtQueryDebugFilterState in that function for consistency.
Thanks Hermès Bélusca-Maïto for help

8 weeks ago[WIN32K:NTUSER] Avoid user memory access outside of SEH in NtUserEnumDisplaySettings.
Thomas Faber [Sun, 29 Dec 2019 17:51:05 +0000 (18:51 +0100)]
[WIN32K:NTUSER] Avoid user memory access outside of SEH in NtUserEnumDisplaySettings.

8 weeks ago[WIN32K:NTUSER] Correctly capture UNICODE_STRING in NtUserEnumDisplaySettings.
Thomas Faber [Sun, 29 Dec 2019 15:14:58 +0000 (16:14 +0100)]
[WIN32K:NTUSER] Correctly capture UNICODE_STRING in NtUserEnumDisplaySettings.

8 weeks ago[WIN32K:NTUSER] Add missing probe in NtUserGetClassName.
Thomas Faber [Sun, 29 Dec 2019 15:14:17 +0000 (16:14 +0100)]
[WIN32K:NTUSER] Add missing probe in NtUserGetClassName.