reactos.git
4 years ago[SDK] Fix dummy SEH to always reference the parameter in _SEH2_EXCEPT
Hervé Poussineau [Thu, 26 Mar 2020 15:24:59 +0000 (16:24 +0100)]
[SDK] Fix dummy SEH to always reference the parameter in _SEH2_EXCEPT

Otherwise, we may have compilation errors if this parameter is the name of a static function.

4 years ago[CMAKE] Add some -D__ROS_LONG64__ to please gcc x64
Hervé Poussineau [Thu, 26 Mar 2020 13:40:39 +0000 (14:40 +0100)]
[CMAKE] Add some -D__ROS_LONG64__ to please gcc x64

We can now pass a UINT* to a function wanting a DWORD*

4 years ago[ISAPNP] Report DMA channels
Hervé Poussineau [Sun, 22 Mar 2020 22:23:04 +0000 (23:23 +0100)]
[ISAPNP] Report DMA channels

4 years ago[ISAPNP] Fix reporting of devices with hexadecimal productId
Hervé Poussineau [Sun, 22 Mar 2020 22:22:48 +0000 (23:22 +0100)]
[ISAPNP] Fix reporting of devices with hexadecimal productId

4 years ago[USERENV] sq-AL: Fix '%SistemDrive%' typo (#2469)
Serge Gautherie [Thu, 26 Mar 2020 06:28:09 +0000 (07:28 +0100)]
[USERENV] sq-AL: Fix '%SistemDrive%' typo (#2469)

Not to translate!

CORE-16762

4 years ago[BOOTDATA] Add 0845 (bn-bd) language (#2467)
Serge Gautherie [Thu, 26 Mar 2020 01:05:05 +0000 (02:05 +0100)]
[BOOTDATA] Add 0845 (bn-bd) language (#2467)

In accordance with the NLS value specified in base/setup/lib/lang/bn-BD.h
CORE-16766

4 years ago[PING] Do not abort (as OoM) when request size = 0
Serge Gautherie [Sat, 7 Mar 2020 12:20:28 +0000 (13:20 +0100)]
[PING] Do not abort (as OoM) when request size = 0

4 years ago[WIN32K] Fix bounds calculation when drawing with a pen
Jérôme Gardou [Tue, 24 Mar 2020 11:20:58 +0000 (11:20 +0000)]
[WIN32K] Fix bounds calculation when drawing with a pen

4 years ago[STORPROP] Add storprop.dll and implement the DiskClassInstaller stub
Eric Kohl [Sun, 22 Mar 2020 15:37:48 +0000 (16:37 +0100)]
[STORPROP] Add storprop.dll and implement the DiskClassInstaller stub

4 years ago[ISAPNP] Create requirements and resource lists when detecting a device
Hervé Poussineau [Sun, 22 Mar 2020 13:20:52 +0000 (14:20 +0100)]
[ISAPNP] Create requirements and resource lists when detecting a device

4 years ago[ISAPNP] Read all tags when detecting devices, and keep interesting ones
Hervé Poussineau [Sat, 21 Mar 2020 22:08:00 +0000 (23:08 +0100)]
[ISAPNP] Read all tags when detecting devices, and keep interesting ones

Currently, we only keep device identification, IO ports and IRQs.

4 years ago[ISAPNP] Create resource list ahead of IRP_MN_QUERY_RESOURCES
Hervé Poussineau [Sat, 21 Mar 2020 16:37:45 +0000 (17:37 +0100)]
[ISAPNP] Create resource list ahead of IRP_MN_QUERY_RESOURCES

4 years ago[ISAPNP] Create resource requirements ahead of IRP_MN_QUERY_RESOURCE_REQUIREMENTS
Hervé Poussineau [Sat, 21 Mar 2020 15:58:21 +0000 (16:58 +0100)]
[ISAPNP] Create resource requirements ahead of IRP_MN_QUERY_RESOURCE_REQUIREMENTS

4 years ago[ISAPNP] Fix capabilities for devices
Hervé Poussineau [Sat, 21 Mar 2020 13:59:02 +0000 (14:59 +0100)]
[ISAPNP] Fix capabilities for devices

4 years ago[ISAPNP] Return a compatibleIDs only if defined
Hervé Poussineau [Sat, 21 Mar 2020 13:58:36 +0000 (14:58 +0100)]
[ISAPNP] Return a compatibleIDs only if defined

4 years ago[ISAPNP] Fix some indentation
Hervé Poussineau [Sat, 21 Mar 2020 12:39:20 +0000 (13:39 +0100)]
[ISAPNP] Fix some indentation

4 years ago[WINSRV] Use DIB section for frame buffer bitmap
Timo Kreuzer [Sat, 14 Mar 2020 17:45:51 +0000 (18:45 +0100)]
[WINSRV] Use DIB section for frame buffer bitmap

4 years ago[STOBJECT] Remove obsolete code and use string resources instead of hard-coded strings
Eric Kohl [Sun, 22 Mar 2020 10:31:56 +0000 (11:31 +0100)]
[STOBJECT] Remove obsolete code and use string resources instead of hard-coded strings

4 years ago[Explorer|Shell32] Fix Build
jimtabor [Sun, 22 Mar 2020 00:18:15 +0000 (19:18 -0500)]
[Explorer|Shell32] Fix Build

Missed a file. See CORE-14439.

4 years ago[Explorer|Shell32]
jimtabor [Sun, 22 Mar 2020 00:13:55 +0000 (19:13 -0500)]
[Explorer|Shell32]

Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.

4 years ago[STDOBJECT] Show the hotplug icon when a USB-Stick is inserted
Eric Kohl [Sat, 21 Mar 2020 22:46:24 +0000 (23:46 +0100)]
[STDOBJECT] Show the hotplug icon when a USB-Stick is inserted

- Enable the hotplug service by default
- Start a timer on WM_DEVICECHANGE:DBT_DEVNODES_CHANGED to trigger the removable device detection.

4 years ago[NTOS:IO] Fix indentation. No code changes!
Eric Kohl [Sat, 21 Mar 2020 13:32:18 +0000 (14:32 +0100)]
[NTOS:IO] Fix indentation. No code changes!

4 years ago[NTOS:PNP] Fix indentation. No code changes!
Eric Kohl [Sat, 21 Mar 2020 12:22:09 +0000 (13:22 +0100)]
[NTOS:PNP] Fix indentation. No code changes!

4 years ago[NTOS:PNP] Map device capabilities to capability flags
Eric Kohl [Sat, 21 Mar 2020 12:20:36 +0000 (13:20 +0100)]
[NTOS:PNP] Map device capabilities to capability flags

This fixes a devices Capabilities value in the registry.

4 years ago[USBHUB] Set the Removable flag for all ports of a USB hub
Eric Kohl [Sat, 21 Mar 2020 12:12:53 +0000 (13:12 +0100)]
[USBHUB] Set the Removable flag for all ports of a USB hub

4 years ago[ISAPNP] Fix some warnings
Hervé Poussineau [Sat, 21 Mar 2020 07:29:15 +0000 (08:29 +0100)]
[ISAPNP] Fix some warnings

4 years ago[INF] Do not require a device for the ISAPNP read data port
Hervé Poussineau [Fri, 20 Mar 2020 21:42:36 +0000 (22:42 +0100)]
[INF] Do not require a device for the ISAPNP read data port

4 years ago[ISAPNP] Implement some more IRP_MJ_PNP/IRP_MN_* requests
Hervé Poussineau [Tue, 17 Mar 2020 22:51:53 +0000 (23:51 +0100)]
[ISAPNP] Implement some more IRP_MJ_PNP/IRP_MN_* requests

We either succeed them, or we pass them down to the ISAPNP FDO.

4 years ago[ISAPNP] Implement IRP_MN_QUERY_PNP_DEVICE_STATE for ReadDataPort
Hervé Poussineau [Tue, 17 Mar 2020 22:50:39 +0000 (23:50 +0100)]
[ISAPNP] Implement IRP_MN_QUERY_PNP_DEVICE_STATE for ReadDataPort

4 years ago[ISAPNP] Detect devices only once ReadDataPort is started
Hervé Poussineau [Mon, 16 Mar 2020 19:58:53 +0000 (20:58 +0100)]
[ISAPNP] Detect devices only once ReadDataPort is started

Also let kernel choose the read data port address, by using the resources given in IRP_MN_START_DEVICE.

4 years ago[ISAPNP] Implement IRP_MN_QUERY_RESOURCES/IRP_MN_QUERY_RESOURCE_REQUIREMENTS for...
Hervé Poussineau [Mon, 16 Mar 2020 19:50:29 +0000 (20:50 +0100)]
[ISAPNP] Implement IRP_MN_QUERY_RESOURCES/IRP_MN_QUERY_RESOURCE_REQUIREMENTS for ReadDataPort

4 years ago[ISAPNP] Report removal relations on ReadDataPort
Hervé Poussineau [Mon, 16 Mar 2020 18:43:37 +0000 (19:43 +0100)]
[ISAPNP] Report removal relations on ReadDataPort

4 years ago[ISAPNP] Report a ReadDataPort PDO
Hervé Poussineau [Mon, 16 Mar 2020 18:24:07 +0000 (19:24 +0100)]
[ISAPNP] Report a ReadDataPort PDO

This PDO will later request resources required for ISAPNP bus.

4 years ago[ISAPNP] Create PDO identifiers ahead of IRP_MN_QUERY_ID
Hervé Poussineau [Mon, 16 Mar 2020 18:00:00 +0000 (19:00 +0100)]
[ISAPNP] Create PDO identifiers ahead of IRP_MN_QUERY_ID

4 years ago[ISAPNP] Extract function to create DOs
Hervé Poussineau [Mon, 16 Mar 2020 17:07:24 +0000 (18:07 +0100)]
[ISAPNP] Extract function to create DOs

4 years ago[ISAPNP] Fix some return codes
Hervé Poussineau [Fri, 20 Mar 2020 18:41:55 +0000 (19:41 +0100)]
[ISAPNP] Fix some return codes

4 years ago[ISAPNP] Reformat files. No code change.
Hervé Poussineau [Fri, 20 Mar 2020 18:19:30 +0000 (19:19 +0100)]
[ISAPNP] Reformat files. No code change.

4 years ago[GDI32_WINETEST][USER32_WINETEST] Remove forced WINVER defines (#2455)
Serge Gautherie [Fri, 20 Mar 2020 18:20:52 +0000 (19:20 +0100)]
[GDI32_WINETEST][USER32_WINETEST] Remove forced WINVER defines (#2455)

No impact, as already deactivated.

Import
https://source.winehq.org/git/wine.git/commit/d0fd12b90946865a92f3fd016ccac13e5c4fdf54

4 years ago[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell...
Tibor Lajos Füzi [Fri, 20 Mar 2020 16:52:46 +0000 (17:52 +0100)]
[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell, userenv, shortcuts (#2442)

4 years ago[TRANSLATION] Update portuguese translation (#2447)
Jose Carlos Jesus [Fri, 20 Mar 2020 16:34:43 +0000 (16:34 +0000)]
[TRANSLATION] Update portuguese translation (#2447)

Update translation for main.cpl and add new translation for powercfg.cpl.

4 years ago[USER32] Relax conditions for creating MDI windows (#2454)
Katayama Hirofumi MZ [Thu, 19 Mar 2020 22:38:33 +0000 (07:38 +0900)]
[USER32] Relax conditions for creating MDI windows (#2454)

The creation conditions of MDI window was too strict. CORE-15633

4 years agoSync brsfolder.c with keyboard shortcut code from wine (#2290)
Robert Naumann [Wed, 18 Mar 2020 20:57:10 +0000 (21:57 +0100)]
Sync brsfolder.c with keyboard shortcut code from wine (#2290)

* [SHELL32] Add shortcut to rename folders with the F2 key.

Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer

* [SHELL32] Add shortcut to delete folders with the delete key.

Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer

* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine

4 years ago[USER32_APITEST] Strengthen DrawText testcase (#2450)
Katayama Hirofumi MZ [Tue, 17 Mar 2020 14:24:11 +0000 (23:24 +0900)]
[USER32_APITEST] Strengthen DrawText testcase (#2450)

Add uFormat and pszText parameters into user32_apitest DrawText testcase. CORE-16753

4 years ago[JOY] Use APPLET_PROC instead of a custom CPLAPPLET_PROC and simpify the code
Eric Kohl [Sun, 15 Mar 2020 17:12:54 +0000 (18:12 +0100)]
[JOY] Use APPLET_PROC instead of a custom CPLAPPLET_PROC and simpify the code

4 years ago[POWERCFG] Add hints on missing property pages and remove an obsolete declaration
Eric Kohl [Sun, 15 Mar 2020 15:06:49 +0000 (16:06 +0100)]
[POWERCFG] Add hints on missing property pages and remove an obsolete declaration

4 years ago[INPUT] Use APPLET_PROC instead of a custom CPLAPPLET_PROC and simpify the code
Eric Kohl [Sun, 15 Mar 2020 14:10:14 +0000 (15:10 +0100)]
[INPUT] Use APPLET_PROC instead of a custom CPLAPPLET_PROC and simpify the code

4 years ago[POWERCFG] Disable the "Enable hibernation" checkbox if the system does not support...
Eric Kohl [Sun, 15 Mar 2020 13:19:42 +0000 (14:19 +0100)]
[POWERCFG] Disable the "Enable hibernation" checkbox if the system does not support hibernation

4 years ago[MSVCRT] Add _snwscanf 2441/head
Mark Jansen [Sun, 15 Mar 2020 00:03:14 +0000 (01:03 +0100)]
[MSVCRT] Add _snwscanf

4 years ago[WINTRUST] Add WTHelperGetFileHash stub
Mark Jansen [Sun, 15 Mar 2020 00:02:44 +0000 (01:02 +0100)]
[WINTRUST] Add WTHelperGetFileHash stub

4 years ago[DESK][CONTROL] Select property pages by command line, for example 'control desk...
Eric Kohl [Sun, 15 Mar 2020 10:46:31 +0000 (11:46 +0100)]
[DESK][CONTROL] Select property pages by command line, for example 'control desk.cpl,,1' and fix 'control color'

4 years ago[ISAPNP] Rewrite device reporting method
Hervé Poussineau [Thu, 12 Mar 2020 10:53:09 +0000 (11:53 +0100)]
[ISAPNP] Rewrite device reporting method

IoCreateDevice() was called too early, when a spinlock was acquired.
Create ISAPNP_LOGICAL_DEVICE structure when a device is detected, and call IoCreateDevice() later, when required.

4 years ago[ISAPNP] Fix reading of serial number
Hervé Poussineau [Sat, 14 Mar 2020 22:28:52 +0000 (23:28 +0100)]
[ISAPNP] Fix reading of serial number

4 years ago[CMD] Fix another NtReadVirtualMemory parameter.
Thomas Faber [Fri, 13 Mar 2020 21:15:56 +0000 (22:15 +0100)]
[CMD] Fix another NtReadVirtualMemory parameter.

Spotted by Hermès.

4 years ago[FREELDR] Move built-in VGA font to better location (#2429)
Stanislav Motylkov [Sat, 14 Mar 2020 17:13:49 +0000 (20:13 +0300)]
[FREELDR] Move built-in VGA font to better location (#2429)

Addendum to 97eacb9.

4 years ago[MAIN] Select property pages by command line, for example 'control main.cpl,@0,2'
Eric Kohl [Sat, 14 Mar 2020 17:03:52 +0000 (18:03 +0100)]
[MAIN] Select property pages by command line, for example 'control main.cpl,@0,2'

4 years ago[HOST] Do not pack structures
Timo Kreuzer [Sat, 22 Feb 2020 16:27:31 +0000 (17:27 +0100)]
[HOST] Do not pack structures

Most of them are unaffected by packing, the ones that are affected have pointers, and packing them will only misalign them, but not making the structures 32 bit compatible.

4 years ago[SNDVOL32] Restore the previous placement data of the window (#2420)
Bișoc George [Fri, 13 Mar 2020 22:33:36 +0000 (23:33 +0100)]
[SNDVOL32] Restore the previous placement data of the window (#2420)

Save the current coordinate data of the window to the Registry when the user closes the Sound Volume applet.

4 years ago[NTOS:IO][GDI32][CMD] Fix some under-sized variables. CORE-14922
Thomas Faber [Fri, 13 Mar 2020 19:45:06 +0000 (20:45 +0100)]
[NTOS:IO][GDI32][CMD] Fix some under-sized variables. CORE-14922

Fixes x64 boot with RTC.

4 years ago[APITESTS] Tested function must be called before GetLastError() log (#2433)
Serge Gautherie [Fri, 13 Mar 2020 17:15:21 +0000 (18:15 +0100)]
[APITESTS] Tested function must be called before GetLastError() log (#2433)

So as to get the relevant LastError value.
Fixes for apphelp_apitest, kernel32_apitest and ws2_32_apitest.

4 years ago[PSDK] SYSTEM_POWER_STATUS: Rename Reserved1 to SystemStatusFlag (#2419)
Serge Gautherie [Fri, 13 Mar 2020 17:14:16 +0000 (18:14 +0100)]
[PSDK] SYSTEM_POWER_STATUS: Rename Reserved1 to SystemStatusFlag (#2419)

As on Win10.

Cherry pick
https://source.winehq.org/git/wine.git/commit/7c5ea436af8a6b5a3d2b095bd4697f10b6f78acc

4 years ago[BOOTDATA] Update caroots.inf. CORE-16743
Thomas Faber [Fri, 13 Mar 2020 10:34:05 +0000 (11:34 +0100)]
[BOOTDATA] Update caroots.inf. CORE-16743

* Add "Entrust Root Certification Authority - G4" (https://bugzilla.mozilla.org/show_bug.cgi?id=1591178)
* Add "Hongkong Post Root CA 3" (https://bugzilla.mozilla.org/show_bug.cgi?id=1532753)
* Add "emSign ECC Root CA - C3", "emSign Root CA - C1", "emSign ECC Root CA - G3", "emSign Root CA - G1" (https://bugzilla.mozilla.org/show_bug.cgi?id=1515457)
* Add "Certigna Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1505614)
* Add "UCA Extended Validation Root", "UCA Global G2 Root" (https://bugzilla.mozilla.org/show_bug.cgi?id=1496214)
* Add "GTS Root R4", "GTS Root R3", "GTS Root R2", "GTS Root R1" (https://bugzilla.mozilla.org/show_bug.cgi?id=1325532)
* Add "OISTE WISeKey Global Root GC CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1483924)
* Add "GlobalSign Root CA - R6" (https://bugzilla.mozilla.org/show_bug.cgi?id=1390803)

* Remove "OpenTrust Root CA G3", "OpenTrust Root CA G2", "OpenTrust Root CA G1"
* Remove "Certplus Root CA G2", "Certplus Root CA G1"
* Remove "Certinomis - Root CA"
* Remove "TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H5"
* Remove "Deutsche Telekom Root CA 2", "Certplus Class 2 Primary CA" (expired, https://bugzilla.mozilla.org/show_bug.cgi?id=1574670)
* Remove "Visa eCommerce Root"

4 years ago[WIN32SS] Fix regression CORE-16721
Joachim Henze [Tue, 10 Mar 2020 23:01:46 +0000 (00:01 +0100)]
[WIN32SS] Fix regression CORE-16721

"Scrolling by pressing the scrollbar arrows does not draw the arrows as pressed"
Fixed by a patch of JIRA-user 'I_kill_bugs'. Thank you very much!

The regression was introduced by 0.4.11-dev-586-g
929a2c6637b18cc14e259fe2f2d3d9635a10b2e9
(which itself aimed to fix CORE-13986,
but not CORE-13918 as erroneously stated in commit comment)

I intend to port this back into 0.4.13-RC later.

4 years ago[SHLWAPI] Sorry, I updated wrong function at 5a440b2 (#2430)
Katayama Hirofumi MZ [Wed, 11 Mar 2020 01:41:39 +0000 (10:41 +0900)]
[SHLWAPI] Sorry, I updated wrong function at 5a440b2 (#2430)

CORE-13950

4 years ago[SHLWAPI] Follow-up of #2430
Katayama Hirofumi MZ [Tue, 10 Mar 2020 22:36:07 +0000 (07:36 +0900)]
[SHLWAPI] Follow-up of #2430

Add a NULL check in SHLockSharedEx function. CORE-13950

4 years ago[USBHUB] Demote a DbgBreakPoint CORE-16394
Joachim Henze [Tue, 10 Mar 2020 21:48:02 +0000 (22:48 +0100)]
[USBHUB] Demote a DbgBreakPoint CORE-16394

The DbgBreakPoint() was reported to be continuable without
obvious side-effects by Doug Lyons.
Thank you for your tests Doug.

To prevent what end-users may otherwise perceive as a
freeze-regression caused by enabling the new driver in
0.4.13-dev-1048-g
6392c5a78c06ad8460deae47e90406fba0412bb5

4 years ago[SHLWAPI] Implement SHLockSharedEx function (#2430)
Katayama Hirofumi MZ [Tue, 10 Mar 2020 15:03:45 +0000 (00:03 +0900)]
[SHLWAPI] Implement SHLockSharedEx function (#2430)

- Implement shlwapi!SHLockSharedEx function.
- Modify shlwapi.spec file (some argument conversions from long to ptr).
CORE-13950

4 years ago[PING][TRACERT] Fully support Win64 ICMP_ECHO_REPLY32 (#2427)
Serge Gautherie [Mon, 9 Mar 2020 18:41:39 +0000 (19:41 +0100)]
[PING][TRACERT] Fully support Win64 ICMP_ECHO_REPLY32 (#2427)

4 years ago[UMPNPMGR] rpcserver.c: Fix debug message copypastas (#2426)
Serge Gautherie [Mon, 9 Mar 2020 15:00:53 +0000 (16:00 +0100)]
[UMPNPMGR] rpcserver.c: Fix debug message copypastas (#2426)

Addendum to db02f87d.

4 years ago[PRINTING] Add x64 print environment keys and folders
Timo Kreuzer [Thu, 8 Mar 2018 02:02:56 +0000 (03:02 +0100)]
[PRINTING] Add x64 print environment keys and folders

4 years ago[TRACERT] Fix undefined behavior by fixing ReplyBuffer size. (#2422)
Erdem Ersoy [Sun, 8 Mar 2020 18:36:07 +0000 (21:36 +0300)]
[TRACERT] Fix undefined behavior by fixing ReplyBuffer size. (#2422)

CORE-16620

4 years ago[CMAKE] gcc.cmake: '-Wno-unused-const-variable' applies to GCC 6.1+
Serge Gautherie [Fri, 16 Aug 2019 23:14:36 +0000 (01:14 +0200)]
[CMAKE] gcc.cmake: '-Wno-unused-const-variable' applies to GCC 6.1+

GCC 4.7.2 logs
'cc1: error: unrecognized command line option "-Wno-unused-const-variable" [-Werror]'

Addendum to 8eb7a1a2f4a9cce5a70a9c48efb30cdfa59bf56f.

4 years ago[UMPNPMGR] Implement PNP_DisableDevInst()
Eric Kohl [Sun, 8 Mar 2020 09:36:02 +0000 (10:36 +0100)]
[UMPNPMGR] Implement PNP_DisableDevInst()

4 years ago[UMPNPMGR] Fix indentation and improve debug messages
Eric Kohl [Sun, 8 Mar 2020 09:30:25 +0000 (10:30 +0100)]
[UMPNPMGR] Fix indentation and improve debug messages

4 years ago[SETUPAPI] Improve CM_Disable_DevNode_Ex
Eric Kohl [Sat, 7 Mar 2020 12:26:53 +0000 (13:26 +0100)]
[SETUPAPI] Improve CM_Disable_DevNode_Ex

Replace the call to PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) by a call to PNP_DisableDevInst() because PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) is a no-op.

4 years ago[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2417)
Katayama Hirofumi MZ [Sat, 7 Mar 2020 02:36:55 +0000 (11:36 +0900)]
[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2417)

Add pathname checks. CORE-13950

4 years ago[FREELDR] Minor code improvements
Dmitry Borisov [Thu, 5 Mar 2020 19:48:00 +0000 (01:48 +0600)]
[FREELDR] Minor code improvements

- Add missing allocation check in DetectApmBios()
- Check 'PM' signature in FindApmBios()
- Properly set machine type in hardware detection
- Set Component->Key value for hard drives
- Get rid of the unused XboxBeep()
- Cast Xbox LPC I/O ports to PUCHAR
- Improve shadow rendering with VGA font
- Include ntoskrnl.h in the proper order

4 years ago[FREELDR] Add ARC-emulation support for NEC PC-98 series
Dmitry Borisov [Sun, 10 Nov 2019 16:47:39 +0000 (22:47 +0600)]
[FREELDR] Add ARC-emulation support for NEC PC-98 series

- Add ARC-emulation support for NEC PC-98 series
- Add global definition for PC-98 port into CMakeLists.txt
- Add floppy verison of freeldr.ini for PC-98 CD boot

4 years ago[RASDLG] Fix remaining '\n\n\n\n\n\n\n' typo (#2416)
Serge Gautherie [Fri, 6 Mar 2020 23:51:32 +0000 (00:51 +0100)]
[RASDLG] Fix remaining '\n\n\n\n\n\n\n' typo (#2416)

Addendum to commit 92aabb07.

4 years ago[USETUP] Fix ' \n' typos, in *.h (#2415)
Serge Gautherie [Fri, 6 Mar 2020 23:51:13 +0000 (00:51 +0100)]
[USETUP] Fix ' \n' typos, in *.h (#2415)

Addendum to PR #2387.

4 years ago[CMAKE][FREELDR] Take the global defines into account when compiling ASM files.
Hermès Bélusca-Maïto [Fri, 6 Mar 2020 21:55:12 +0000 (22:55 +0100)]
[CMAKE][FREELDR] Take the global defines into account when compiling ASM files.

Now the SARCH_xxx can be used in ASM files too.
Dedicated to Dmitry Borisov ;)

4 years ago[USER32] Fix crash in Edit control. CORE-16727
Hermès Bélusca-Maïto [Fri, 6 Mar 2020 19:02:03 +0000 (20:02 +0100)]
[USER32] Fix crash in Edit control. CORE-16727

The #ifdef prevents setting the variable, es, to NULL, which lead to an illegal access.
This didn't match dll/comctl32/edit.c .

Patch by 'I_Kill_Bugs' contributor.

4 years ago[HALX86] Move PC/AT hardware definitions to a separate file (#2406)
Dmitry Borisov [Fri, 6 Mar 2020 18:54:16 +0000 (00:54 +0600)]
[HALX86] Move PC/AT hardware definitions to a separate file (#2406)

This makes it easier for other ports.

4 years ago[CPORTLIB][NTOS:INBV][KDCOM][FREELDR] Add ComPort library for NEC PC-98 series (...
Dmitry Borisov [Fri, 6 Mar 2020 18:50:31 +0000 (00:50 +0600)]
[CPORTLIB][NTOS:INBV][KDCOM][FREELDR] Add ComPort library for NEC PC-98 series (#2407)

There are 2 known serial ports:
    COM1 - based on Intel 8251A
    COM2 - National Semiconductor 16550

4 years ago[TRANSLATION] Update PT translation (#2342)
Jose Carlos Jesus [Fri, 6 Mar 2020 18:40:03 +0000 (18:40 +0000)]
[TRANSLATION] Update PT translation (#2342)

Update Portuguese translation for cryptui, ieframe and mpr DLLs.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago[TRANSLATION] Add Hungarian translation for explorer, msgina (#2341)
Tibor Lajos Füzi [Fri, 6 Mar 2020 18:15:58 +0000 (19:15 +0100)]
[TRANSLATION] Add Hungarian translation for explorer, msgina (#2341)

4 years ago[DSOUND_NEW][DDRAW] CMake fixes (#2389)
Adam Słaboń [Fri, 6 Mar 2020 18:09:28 +0000 (19:09 +0100)]
[DSOUND_NEW][DDRAW] CMake fixes (#2389)

* Create export tables for native ddraw and dsound_new.
* Include native ddraw version resource in build process.
CORE-16228

4 years ago[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Serge Gautherie [Fri, 6 Mar 2020 18:08:25 +0000 (19:08 +0100)]
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)

Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago[PSDK][XDK] Move 2 aliases to psdk/winbase.h from xdk/winnt_old.h
Serge Gautherie [Fri, 28 Feb 2020 12:14:36 +0000 (13:14 +0100)]
[PSDK][XDK] Move 2 aliases to psdk/winbase.h from xdk/winnt_old.h

4 years ago[PSDK] winbase.h: Add missing LPEXCEPTION_RECORD
Serge Gautherie [Fri, 28 Feb 2020 12:14:36 +0000 (13:14 +0100)]
[PSDK] winbase.h: Add missing LPEXCEPTION_RECORD

ROSTESTS-251

4 years ago[KERNEL32_WINETEST] Fix COMMCONFIG.wcProviderData values (#2410)
Serge Gautherie [Fri, 6 Mar 2020 17:24:22 +0000 (18:24 +0100)]
[KERNEL32_WINETEST] Fix COMMCONFIG.wcProviderData values (#2410)

Import test part of
https://source.winehq.org/git/wine.git/commit/a59d6387b6734cf0acb187e9c178d7c540751cae

ROSTESTS-251

4 years ago[SETUPAPI] Implement StopDevice()
Hervé Poussineau [Wed, 4 Mar 2020 22:43:30 +0000 (23:43 +0100)]
[SETUPAPI] Implement StopDevice()

4 years ago[NTUSER] Fix ShellHook notifications when creating/activating windows (#2396)
JoachimHenze [Thu, 5 Mar 2020 14:39:23 +0000 (15:39 +0100)]
[NTUSER] Fix ShellHook notifications when creating/activating windows (#2396)

4 years ago[CPL][TIMEDATE] Romanian & Italian translation update (#2404)
Hermès BÉLUSCA - MAÏTO [Wed, 4 Mar 2020 23:21:31 +0000 (00:21 +0100)]
[CPL][TIMEDATE] Romanian & Italian translation update (#2404)

4 years ago[PSDK] Extend struct _SECPKG_DLL_FUNCTIONS, fix definitions. 2254/head
Andreas Maier [Tue, 7 Jan 2020 18:06:37 +0000 (19:06 +0100)]
[PSDK] Extend struct _SECPKG_DLL_FUNCTIONS, fix definitions.

* Add missing enums to MSV1_0_PROTOCOL_MESSAGE_TYPE and SECPKG_EXTENDED_INFORMATION_CLASS
* Add missing function entries to LSA_SECPKG_FUNCTION_TABLE and add needed definitions.
* Fix params of PLSA_AP_CALL_PACKAGE
* Fix SpInitializeFn (+ NTAPI)

4 years ago[WIN32SS] Improve Drawing Scrollbars
Joachim Henze [Wed, 4 Mar 2020 01:12:06 +0000 (02:12 +0100)]
[WIN32SS] Improve Drawing Scrollbars

A very nice patch of JIRA user "I_kill_Bugs". Many many Thanks!

It addresses:
- CORE-14755 fixed, flashing scrollbar triangles (we know 131 affected apps just from rapps!)
- CORE-13931 fixed, FamiTracker invisible about-dlg
- CORE-14685 improves a bit, but is not entirely fixed
- CORE-11561 improves a bit, but is not entirely fixed
- The patch avoids unnecessary redraws, speeds up GUI interaction and NSIS install times

Jim Tabor had no complains about it, I just did some white-space-tweaks on EOL and indentation.

FTR A testbot run (not on master but on 0.4.13-RC-48-g818e5bc)
https://reactos.org/testman/compare.php?ids=71645,71666 VBox LGTM
https://reactos.org/testman/compare.php?ids=71646,71667 KVM LGTM

I felt tempted to port back, but decided to play safe and commit to master just.

4 years ago[NTOS:MM] Assert PFN lock ownership in MiInsertPageInFreeList. 2371/head
Thomas Faber [Wed, 12 Feb 2020 20:09:49 +0000 (21:09 +0100)]
[NTOS:MM] Assert PFN lock ownership in MiInsertPageInFreeList.

AMD64 initialization previously only raised the IRQL.
It now acquires the lock where needed, as i386 does.

4 years ago[USBHUB] Partially implement USBH_ProcessHubStateChange. CORE-16704 2370/head
Thomas Faber [Sat, 22 Feb 2020 09:32:11 +0000 (10:32 +0100)]
[USBHUB] Partially implement USBH_ProcessHubStateChange. CORE-16704

4 years ago[USBHUB] Fix recipient in USBH_SyncClearPortStatus. CORE-16704
Thomas Faber [Sat, 22 Feb 2020 09:31:40 +0000 (10:31 +0100)]
[USBHUB] Fix recipient in USBH_SyncClearPortStatus. CORE-16704

4 years ago[CONSRV] Fix a corruption of the CONSRV memory when converting read input events...
Hermès Bélusca-Maïto [Sun, 1 Mar 2020 23:56:33 +0000 (00:56 +0100)]
[CONSRV] Fix a corruption of the CONSRV memory when converting read input events back to ANSI.

This fixes a 6-year old copy-paste bug introduced by commit b47d51c6 (r64004).

4 years ago[CONSRV] Some code simplification and tidy up.
Hermès Bélusca-Maïto [Sun, 1 Mar 2020 16:22:05 +0000 (17:22 +0100)]
[CONSRV] Some code simplification and tidy up.