Serge Gautherie [Wed, 5 Jun 2019 23:53:53 +0000 (01:53 +0200)]
[BOOTLIB] Check DBG with #if, not #ifdef (#1621)
Serge Gautherie [Wed, 5 Jun 2019 23:51:46 +0000 (01:51 +0200)]
[LWIP] Fix src/core/init.c a bit (#1620)
Cherry-pick
http://git.savannah.nongnu.org/cgit/lwip.git/commit/src/core/init.c?id=
c0b534e5318baf870e2152c70d4d11a3a86181f3
Serge Gautherie [Wed, 5 Jun 2019 23:50:55 +0000 (01:50 +0200)]
[MBEDTLS] Use '#ifndef __REACTOS__', instead of '#if DBG & 0' (#1619)
- Don't use '|' on a '#if'
- Remove a personal comment.
Serge Gautherie [Wed, 5 Jun 2019 23:50:24 +0000 (01:50 +0200)]
[DXSDK] Improve dxerr?.h a bit (#1617)
*Use '||', instead of '|', on a '#if'.
*Synchronize some white spaces and blank lines.
Serge Gautherie [Wed, 5 Jun 2019 23:49:52 +0000 (01:49 +0200)]
[NCFTP] Check _DEBUG with #ifdef, not #if (#1616)
Serge Gautherie [Wed, 5 Jun 2019 23:49:18 +0000 (01:49 +0200)]
[NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615)
Serge Gautherie [Wed, 5 Jun 2019 16:37:07 +0000 (18:37 +0200)]
[ADVAPI32:REG] Remove some useless casts (#1614)
Serge Gautherie [Wed, 5 Jun 2019 16:15:02 +0000 (18:15 +0200)]
[USER32] RegisterClipboardFormatA(): Enable a SetLastError() (#1612)
Eric Kohl [Wed, 5 Jun 2019 08:23:55 +0000 (10:23 +0200)]
[MC] Add syntax and help texts for the NET SHARE command.
Serge Gautherie [Fri, 31 May 2019 14:29:16 +0000 (16:29 +0200)]
[LOCALSPL] Check DBG with #if, not #ifdef
Addendum to r74433.
Serge Gautherie [Wed, 15 May 2019 23:26:32 +0000 (01:26 +0200)]
[NTOS:MM] PeFmtCreateSection(): Improve AMD64 image failure case
Addendum to
98638cc2dfdde460ae49941c76dd51f1b796a001.
CORE-15981
Serge Gautherie [Tue, 4 Jun 2019 14:56:33 +0000 (16:56 +0200)]
Misc addendum to CORE-14271 (#1529)
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.
Also, add a FIXME.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RegisterClipboardFormatA/W() a bit
No functional change.
* [UDFS] Simplify SeSinglePrivilegeCheck() return value check
No functional change.
Addendum to
CORE-14271
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:55:07 +0000 (18:55 +0700)]
[RAPPS] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:54:12 +0000 (18:54 +0700)]
[EXPLORER] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:28:40 +0000 (05:28 +0700)]
[FORMAT] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:19:59 +0000 (05:19 +0700)]
[RUNDLL32] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:18:11 +0000 (05:18 +0700)]
[SUBST] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:08:13 +0000 (05:08 +0700)]
[SERVICES] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:03:51 +0000 (05:03 +0700)]
[RUNONCE] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 20:01:26 +0000 (03:01 +0700)]
[FONTVIEW] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 19:50:12 +0000 (02:50 +0700)]
[MSPAINT] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 14:21:21 +0000 (21:21 +0700)]
[OSK] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 12:28:34 +0000 (19:28 +0700)]
[REGEDIT] Update Indonesian translation. (#1598)
Eric Kohl [Tue, 4 Jun 2019 08:05:20 +0000 (10:05 +0200)]
[NET] Implement adding and deleting of network shares.
Serge Gautherie [Tue, 4 Jun 2019 02:48:04 +0000 (04:48 +0200)]
[WIN32KNT_APITEST] Replace remaining TESTX() (#1609)
Addendum to
b7794e8112e31a58829bac63d44de53677318c3d.
James Tabor [Mon, 3 Jun 2019 20:49:14 +0000 (15:49 -0500)]
[GDI32] Meta File Fix Ups
Remove pointer hack. Safer since using wines Enhanced Meta headers with
unknown wine magic information.
Katayama Hirofumi MZ [Sun, 2 Jun 2019 23:47:43 +0000 (08:47 +0900)]
Revert "[USER32] Make App Switcher use the owner window's icon (#1299)" (#1605)
This reverts commit
484943d04f0dc3f84b7c8e754d1d2505f0a41df3.
Eric Kohl [Sun, 2 Jun 2019 21:30:02 +0000 (23:30 +0200)]
[STORPORT] Detect attached devices
Pierre Schweitzer [Sun, 2 Jun 2019 19:44:45 +0000 (21:44 +0200)]
[NTOSKRNL] Add support for global DOS directory in ObpLookupEntryDirectory
If any exists, we'll loop over in that directory, trying to find the object
Serge Gautherie [Thu, 20 Sep 2018 22:58:14 +0000 (00:58 +0200)]
[WIN32KNT_APITEST:NTDD] Improve failure handling
And remove comments about ReactX.
ROSTESTS-315
Serge Gautherie [Fri, 21 Sep 2018 15:28:51 +0000 (17:28 +0200)]
[FORMATTING] Add/Remove a few spaces
Serge Gautherie [Mon, 24 Sep 2018 14:46:46 +0000 (16:46 +0200)]
[USER32_APITEST:WNDPROC] Improve failure handling
ROSTESTS-316
Serge Gautherie [Mon, 24 Sep 2018 14:45:41 +0000 (16:45 +0200)]
[USER32_APITEST:WNDPROC] 0 to NULL
Serge Gautherie [Mon, 24 Sep 2018 14:42:30 +0000 (16:42 +0200)]
[FORMATTING] 3-spaces to 4-spaces
And a few additional formatting improvements.
Eric Kohl [Sun, 2 Jun 2019 12:23:59 +0000 (14:23 +0200)]
[STORPORT] Fix resource list size calculation
Katayama Hirofumi MZ [Sun, 2 Jun 2019 10:17:50 +0000 (19:17 +0900)]
[WIN32SS][USER32] Fix Task Switcher more (#1602)
This PR will fix task switcher (Alt+Tab) as Win2k3. It became more reliable. CORE-15653
c.f. Raymond Chen's article: http://blogs.msdn.com/b/oldnewthing/archive/2007/10/08/
5351207.aspx
Pierre Schweitzer [Sun, 2 Jun 2019 08:48:35 +0000 (10:48 +0200)]
[NTOSKRNL] In case IopMountVolume call is a success, return its VPB
This fixes an extra (erroneous) reference being set on the VPB.
Based on a patch by Vadim Galyant
CORE-16080
Pierre Schweitzer [Sun, 2 Jun 2019 07:50:05 +0000 (09:50 +0200)]
[NTOSKRNL] On process primary token change, dereference device map
Katayama Hirofumi MZ [Sun, 2 Jun 2019 01:09:34 +0000 (10:09 +0900)]
[SDK][INCLUDE] Update msgdump.h
woachk [Sat, 1 Jun 2019 22:39:57 +0000 (00:39 +0200)]
[NDK/TESTS] The world isn't only amd64 or i386 (#1596)
woachk [Sat, 1 Jun 2019 22:38:56 +0000 (00:38 +0200)]
Update toolchain-msvc.cmake (#1593)
Adding armasm64 as the assembler. This on its own isn't too useful right now.
woachk [Sat, 1 Jun 2019 22:38:30 +0000 (00:38 +0200)]
[CONFIGURE] Add support for VS16.1 (#1594)
Joachim Henze [Sat, 1 Jun 2019 20:53:16 +0000 (22:53 +0200)]
[MSHTML] Fake Success in HTMLDocument_put_bgColor()
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error
8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
Pierre Schweitzer [Sat, 1 Jun 2019 19:22:30 +0000 (21:22 +0200)]
[NTOSKRNL] Implement ObSetDirectoryDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 19:05:14 +0000 (21:05 +0200)]
[NTOSKRNL] Implement SeGetLogonIdDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 16:58:36 +0000 (18:58 +0200)]
[NTOSKRNL] Implement ObpSetCurrentProcessDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 16:43:38 +0000 (18:43 +0200)]
[NTOSKRNL] Implement ObpReferenceDeviceMap()
Pierre Schweitzer [Sat, 1 Jun 2019 16:37:47 +0000 (18:37 +0200)]
[NTOSKRNL] Stub SeGetLogonIdDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 15:39:29 +0000 (17:39 +0200)]
[NTOSKRNL] Simplify NtQueryInformationProcess:ProcessDeviceMap implementation
Pierre Schweitzer [Sat, 1 Jun 2019 15:28:11 +0000 (17:28 +0200)]
[NTOSKRNL] Add support for LUID mappings in ObQueryDeviceMapInformation
Pierre Schweitzer [Sat, 1 Jun 2019 13:18:52 +0000 (15:18 +0200)]
[NTOSKRNL] Implement support for PROCESS_DEVICEMAP_INFORMATION_EX in NtQueryInformationProcess
Pierre Schweitzer [Sat, 1 Jun 2019 12:56:28 +0000 (14:56 +0200)]
[NTOSKRNL] Implement ObIsLUIDDeviceMapsEnabled and call it in NtQueryInformationProcess
Pierre Schweitzer [Sat, 1 Jun 2019 12:40:24 +0000 (14:40 +0200)]
[NTOSKRNL] Disable LUID mapping until it's properly implemented
James Tabor [Sat, 1 Jun 2019 12:23:58 +0000 (07:23 -0500)]
[NtUser] Fix Clipboard Synthesized Returns
Add supported for Meta file synthesized renderings.
See CORE-12143.
Pierre Schweitzer [Sat, 1 Jun 2019 11:59:13 +0000 (13:59 +0200)]
[NTOSKRNL] On device map freeing, make directory object temporary again
Pierre Schweitzer [Sat, 1 Jun 2019 11:54:15 +0000 (13:54 +0200)]
[NTOSKRNL] De-duplicate code between Ob(f)DereferenceDeviceMap functions
Pierre Schweitzer [Sat, 1 Jun 2019 11:51:40 +0000 (13:51 +0200)]
[NTOSKRNL] Add a few ASSERTs to ObpGetDosDevicesProtection for DBG builds
Pierre Schweitzer [Sat, 1 Jun 2019 11:44:55 +0000 (13:44 +0200)]
[NTOSKRNL] Implement ObpFreeDosDevicesProtection to free DACL
Pierre Schweitzer [Sat, 1 Jun 2019 11:35:41 +0000 (13:35 +0200)]
[NTOSKRNL] Modify ObpCreateDeviceMap so that it can handle any process
It is now able to set the newly created device map to any
process and will default to current process if none is provided.
It also sets system device map if no process is specified.
It also deferences existing device map in the process if needed.
Finaly, it will make the directory object permanant.
Katayama Hirofumi MZ [Sat, 1 Jun 2019 07:21:33 +0000 (16:21 +0900)]
[SDK][INCLUDE] msgdump.h registered message support
jimtabor [Sat, 1 Jun 2019 03:59:29 +0000 (22:59 -0500)]
[User32] Fix Clipboard Meta Test Results
Fix meta data handle returns.
jimtabor [Sat, 1 Jun 2019 02:44:17 +0000 (21:44 -0500)]
[Win32SS] Support Clipboard Metafile
Major fix ups and plugging in missing code changes. Handle code is from
another project currently being developed for ReactOS.
See CORE-12143
Joachim Henze [Fri, 31 May 2019 22:05:06 +0000 (00:05 +0200)]
[ROSTESTS][GLOBAL_MEM] GlobalAllocNFree might return SUCCESS even in failure case due to unintended semicolon ROSTESTS-323
Eric Kohl [Fri, 31 May 2019 20:46:04 +0000 (22:46 +0200)]
[NET] Start work on the SHARE command. List shares and display their properties.
Katayama Hirofumi MZ [Fri, 31 May 2019 11:23:30 +0000 (20:23 +0900)]
[KERNEL32_APITEST] dynamic linked RtlIsCriticalSectionLockedByThread (#1592)
Statically linked ntdll.RtlIsCriticalSectionLockedByThread had made kernel32_apitest unable to run in XP. CORE-16077
Katayama Hirofumi MZ [Fri, 31 May 2019 08:02:47 +0000 (17:02 +0900)]
[USER32] Fix behavior of Task Switcher (Alt+Tab) (#1591)
Task Switcher didn't correctly behave on the windows with WS_EX_APPWINDOW extended style. CORE-15653
Katayama Hirofumi MZ [Fri, 31 May 2019 07:28:07 +0000 (16:28 +0900)]
[KERNEL32_APITEST] Check CJK codepage before tests
jimtabor [Thu, 30 May 2019 21:36:33 +0000 (16:36 -0500)]
[NtGDI] Support Clipboard Metafile
Fuctions that help transfer meta file data from one process to the next.
See CORE-12143.
jimtabor [Thu, 30 May 2019 21:33:23 +0000 (16:33 -0500)]
[GDI32] Support Clipboard Metafile
Metafile patch from Katayama Hirofumi MZ. See CORE-12143.
Joachim Henze [Thu, 30 May 2019 10:40:54 +0000 (12:40 +0200)]
[ROSAPPS][PICE] Fix a glitch at two places where code intends to replace invalid chars with spaces ROSAPPS-353
Found by some static code analysis tool reporting 'Condition always false'.
The fix is a selective back-port from the more recent version of pICE hardware.c
Revision: 1.6, Date: 2004/02/17 23:07:36
The most recent source of pICE atm can be found at
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/
Thanks to DougLyons and JIRA user 'maddin200'.
Eric Kohl [Thu, 30 May 2019 09:48:29 +0000 (11:48 +0200)]
[UMPNPMGR] Split the monolithic monster: service, rpc and installer.
Eric Kohl [Wed, 29 May 2019 23:02:09 +0000 (01:02 +0200)]
[UMPNPMGR] PNP_QueryArbitratorFreeData and PNP_QueryArbitratorFreeSize don't do anything useful today.
Joachim Henze [Wed, 29 May 2019 19:19:02 +0000 (21:19 +0200)]
[ROSAPPS][GETTYPE] Fix a copy-paste-issue when checking for Win2000 CORE-16073
Eric Kohl [Wed, 29 May 2019 13:35:55 +0000 (15:35 +0200)]
[NETAPI32] Implement parts of NetGetDCName and declare some parameters optional.
Eric Kohl [Wed, 29 May 2019 11:27:49 +0000 (13:27 +0200)]
[NETLOGON] Add the netlogon service.
Katayama Hirofumi MZ [Wed, 29 May 2019 11:32:32 +0000 (20:32 +0900)]
[WIN32KNT_APITEST] Split win32knt_apitest to 3 modules (#1588)
Split win32knt_apitest to 3 modules (win32knt_apitest, win32knt_xpsp2_apitest and win32knt_2k3sp2_apitest) for usability. These 3 modules are different in linking (win32u.dll, win32u_xpsp2.dll and win32u_2k3sp2.dll). I think it's better to separate for clarity.
Eric Kohl [Wed, 29 May 2019 10:56:43 +0000 (12:56 +0200)]
[NETAPI32] Implement NetpAllocWStrFromStr(), NetpAllocWStrFromAnsiStr() (not public, but useful) and NetpAllocWStrFromWStr().
Katayama Hirofumi MZ [Wed, 29 May 2019 10:59:40 +0000 (19:59 +0900)]
[SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
Based on @Doug-Lyons's patch. CORE-16067
Eric Kohl [Tue, 28 May 2019 15:23:43 +0000 (17:23 +0200)]
[NET] Fix remaining issues with logon hours.
Eric Kohl [Tue, 28 May 2019 06:27:23 +0000 (08:27 +0200)]
[NET] Load the names of the days of week for the 'times' parser routine from the netmsg.dll.
Eric Kohl [Mon, 27 May 2019 15:00:56 +0000 (17:00 +0200)]
[NET] Fix the timezone issue in the logon hours parser and display code of the USER command.
Timo Kreuzer [Sun, 28 Apr 2019 15:22:34 +0000 (17:22 +0200)]
[TELNET] Add missing curly braces to for-statement
Fixes GCC 8 warning:
base/applications/network/telnet/src/tnmain.cpp:171:8: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
for (j = cursor; j >= 0; j--)
^~~
base/applications/network/telnet/src/tnmain.cpp:174:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
for (k = --j; k >= 0; k--)
^~~
Timo Kreuzer [Sun, 28 Apr 2019 15:20:02 +0000 (17:20 +0200)]
[TELNET] Add missing curly braces to while-statement
Fixes GCC 8 warning:
base/applications/network/telnet/src/tmapldr.cpp:70:3: error: this 'while' clause does not guard... [-Werror=misleading-indentation]
while (buf[len])
^~~~~
base/applications/network/telnet/src/tmapldr.cpp:74:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while'
if (len && (buf[len-1] == ' ')) {
^~
Timo Kreuzer [Sun, 28 Apr 2019 15:05:33 +0000 (17:05 +0200)]
[TELNET] Add missing curly braces to if-statelent
Fixes GCC 8 warning:
base/applications/network/telnet/src/tnmain.cpp:171:8: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
for (j = cursor; j >= 0; j--)
^~~
base/applications/network/telnet/src/tnmain.cpp:174:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
for (k = --j; k >= 0; k--)
^~~
Timo Kreuzer [Sun, 28 Apr 2019 14:22:34 +0000 (16:22 +0200)]
[TELNET] disable restrict warnings
Fixes GCC 8 warning:
base/applications/network/telnet/src/tnmain.cpp:190:13: error: 'char* strcpy(char*, const char*)' accessing 1 byte at offsets [0,
2147483647] and [0,
2147483647] may overlap 1 byte at offset 0 [-Werror=restrict]
strcpy(&buf[cursor],&buf[cursor+1]);
~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hervé Poussineau [Mon, 27 May 2019 10:17:16 +0000 (12:17 +0200)]
[LDR] Silence some debug logs when images overlap
Timo Kreuzer [Sun, 28 Apr 2019 18:30:18 +0000 (20:30 +0200)]
[BROWSEUI] Fix indentation
Fixes GCC 8 warning:
dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (!SUCCEEDED(hr) || !pParent.p)
^~
dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
hr = pParent->SetNameOf(0, pidlChild, dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
^~
Timo Kreuzer [Sun, 28 Apr 2019 18:56:40 +0000 (20:56 +0200)]
[GLU32] Fix indentation
Fixes GCC 8 warnings:
dll/opengl/glu32/src/libnurbs/internals/subdivider.cc:852:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if( jarc->pwlArc ) jarc->pwlArc->deleteMe( pwlarcpool ); jarc->pwlArc = 0;
^~
dll/opengl/glu32/src/libnurbs/internals/subdivider.cc:852:59: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if( jarc->pwlArc ) jarc->pwlArc->deleteMe( pwlarcpool ); jarc->pwlArc = 0;
^~~~
Timo Kreuzer [Sun, 28 Apr 2019 18:27:21 +0000 (20:27 +0200)]
[MSHTML] Convert tabs to spaces
Fixes GCC 8 warning:
dll/win32/mshtml/script.c:844:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if(!new_buf)
^~
dll/win32/mshtml/script.c:846:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
This->size <<= 1;
^~~~
Timo Kreuzer [Sun, 28 Apr 2019 16:18:23 +0000 (18:18 +0200)]
[REISERFS] Convert a tab to spaces
Fixes GCC 8 warning:
drivers/filesystems/reiserfs/src/memory.c:874:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (Mcb->RfsdFcb)
^~
drivers/filesystems/reiserfs/src/memory.c:877:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if (RfsdLoadInode(Vcb, &(Mcb->Key), &RfsdIno)) {
^~
Timo Kreuzer [Sun, 28 Apr 2019 17:29:45 +0000 (19:29 +0200)]
[TFTPD] Disable format-overflow warnings
Timo Kreuzer [Sun, 28 Apr 2019 16:46:40 +0000 (18:46 +0200)]
[MINIZIP] Add curly braces to if-statement and fix indentation
Fixes GCC 8 warning:
sdk/lib/3rdparty/zlib/contrib/minizip/zip.c:521:5: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
for (i=(int)uReadSize-3; (i--)>0;)
^~~
sdk/lib/3rdparty/zlib/contrib/minizip/zip.c:529:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
if (uPosFound!=0)
^~
Timo Kreuzer [Sun, 28 Apr 2019 19:35:13 +0000 (21:35 +0200)]
[LIBXSLT] Disable misleading-indentation warnings
Fixes GCC 8 warning:
dll/3rdparty/libxslt/security.c:358:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
else
^~~~
dll/3rdparty/libxslt/security.c:365:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
if (ret <= 0) {
^~
Timo Kreuzer [Sun, 28 Apr 2019 16:01:11 +0000 (18:01 +0200)]
[RSAENH] Use StringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
dll/win32/rsaenh/rsaenh.c:161:23: error: '%s' directive writing up to 259 bytes into a region of size 235 [-Werror=format-overflow=]
#define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:161:23: note: in definition of macro 'RSAENH_REGKEY'
#define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:1107:5: note: 'sprintf' output between 26 and 285 bytes into a destination of size 260
sprintf(szRSABase, RSAENH_REGKEY, pKeyContainer->szName);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 19:03:35 +0000 (21:03 +0200)]
[USETUP] Use RtlStringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
base/setup/usetup/usetup.c:3407:78: error: '%S' directive writing up to 521 bytes into a region of size 200 [-Werror=format-overflow=]
"Setup is currently unable to check a partition formatted in %S.\n"
^~
base/setup/usetup/usetup.c:3406:9: note: 'sprintf' output between 128 and 649 bytes into a destination of size 260
sprintf(Buffer,
^~~~~~~~~~~~~~~
"Setup is currently unable to check a partition formatted in %S.\n"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"\n"
~~~~
" \x07 Press ENTER to continue Setup.\n"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
" \x07 Press F3 to quit Setup.",
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
PartEntry->FileSystem);
~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 21:31:03 +0000 (23:31 +0200)]
[MINGW32] Add some definitions to fix building with GLIBCXX
Timo Kreuzer [Sun, 28 Apr 2019 09:28:24 +0000 (11:28 +0200)]
[CRT] Add missing posix error codes
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
Hervé Poussineau [Mon, 27 May 2019 10:54:01 +0000 (12:54 +0200)]
[CMAKE] Disable unused-const-variable warning
This prevents some errors like this one:
In file included from ../dll/win32/wldap32/ber.c:27:0:
../sdk/include/reactos/wine/debug.h:378:48: error: '__wine_dbch___default' defined but not used [-Werror=unused-const-variable=]
static struct __wine_debug_channel * const __wine_dbch___default = &__wine_dbch_##ch
^
../dll/win32/wldap32/ber.c:29:1: note: in expansion of macro 'WINE_DEFAULT_DEBUG_CHANNEL'
WINE_DEFAULT_DEBUG_CHANNEL(wldap32);
^~~~~~~~~~~~~~~~~~~~~~~~~~
Hervé Poussineau [Mon, 27 May 2019 10:20:47 +0000 (12:20 +0200)]
[CMAKE] Disable --compress-debug-sections on GCC >= 7.0
This leads to 'bad reloc address in section .zdebug_info'
Katayama Hirofumi MZ [Mon, 27 May 2019 09:35:43 +0000 (18:35 +0900)]
[WIN32SS][NTGDI] Don't use FLOAT in ftGdiGetGlyphOutline (#1576)
Don't use FLOAT variable in ftGdiGetGlyphOutline function. CORE-15838