reactos.git
14 months ago[TRANSLATION] Add/Update Portuguese translation for some shell extensions (#2845)
Jose Carlos Jesus [Mon, 1 Jun 2020 18:31:06 +0000 (19:31 +0100)]
[TRANSLATION]  Add/Update Portuguese translation for some shell extensions (#2845)

- Add translation for: devcpux, netplwiz, ntobjshex, stobject, zipfldr.
- Update translation for: sendmail.

14 months ago[CSRSRV] CsrUnhandledExceptionFilter: Check RtlAdjustPrivilege() result (#2864)
Serge Gautherie [Mon, 1 Jun 2020 18:20:31 +0000 (20:20 +0200)]
[CSRSRV] CsrUnhandledExceptionFilter: Check RtlAdjustPrivilege() result (#2864)

And remove unused NtRaiseHardError() Status assignment.

Detected by Cppcheck: redundantAssignment.
Related to commit d221bdfb (r55647).

14 months ago[APISETS] Fix some functions that are NT10(v1607)+ (#2738)
Serge Gautherie [Mon, 1 Jun 2020 17:04:32 +0000 (19:04 +0200)]
[APISETS] Fix some functions that are NT10(v1607)+ (#2738)

- *_onexit_*() are NT10(v1607)+
- *_seh_filter_*() are NT10(v1607)+ actually

CORE-16700

14 months ago[RAPPS] Update Chinese (Taiwan) translation (#2873)
He Yang [Mon, 1 Jun 2020 11:30:53 +0000 (19:30 +0800)]
[RAPPS] Update Chinese (Taiwan) translation (#2873)

14 months ago[CSRSRV] CsrSetProcessSecurity(): Check 1st NtQueryInformationToken() result (#2862)
Serge Gautherie [Mon, 1 Jun 2020 11:17:29 +0000 (13:17 +0200)]
[CSRSRV] CsrSetProcessSecurity(): Check 1st NtQueryInformationToken() result (#2862)

Also:
* Add 1 NtClose(hToken), in an error case.
* Do not call RtlFreeHeap(..., ..., NULL).

Follow-up to #2857.

14 months ago[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)
Serge Gautherie [Mon, 1 Jun 2020 09:26:53 +0000 (11:26 +0200)]
[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)

And let bar timer depend on the bar image only.

Addendum to 623dd26ccea5e79001aee769c230fb4f8e304fc8.

14 months ago[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)
Serge Gautherie [Mon, 1 Jun 2020 09:20:13 +0000 (11:20 +0200)]
[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)

* api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only

CORE-8880

14 months ago[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)
Serge Gautherie [Mon, 1 Jun 2020 09:17:29 +0000 (11:17 +0200)]
[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)

Addendum to 82e4efea77aa19d79a4a14c41ae2222c2994b829.

14 months ago[USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)
Serge Gautherie [Mon, 1 Jun 2020 09:14:38 +0000 (11:14 +0200)]
[USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)

No impact.

Missed part of
https://source.winehq.org/git/wine.git/commit/fb6304119a967ea13688ff9e34ed9d819bd50785

Detected by Cppcheck: identicalInnerCondition.
Addendum to 303ece24219da7ec0cac1016767092287abd7877 (r72520).

14 months ago[NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)
Serge Gautherie [Mon, 1 Jun 2020 09:10:11 +0000 (11:10 +0200)]
[NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)

No impact.

Detected by Cppcheck: unusedVariable.
Addendum to 2dade10d543589e1f5f762bbc1695f2917341171.

14 months ago[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)
Serge Gautherie [Mon, 1 Jun 2020 09:06:49 +0000 (11:06 +0200)]
[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)

Cherry-pick:
https://source.winehq.org/git/wine.git/commit/a359e026662251b7c3367fe2815dcb6cb371af50
https://source.winehq.org/git/wine.git/commit/0662da18b85634928905e72041961ffd3a6e8045
https://source.winehq.org/git/wine.git/commit/e4e5eda3d9afcb5360747ddd97e6bf4fdc0c1c0f

CORE-9665

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
14 months ago[INF] Add better device descriptions for Original Xbox
Stanislav Motylkov [Sun, 31 May 2020 21:30:51 +0000 (00:30 +0300)]
[INF] Add better device descriptions for Original Xbox

CORE-16216

14 months ago[SCHEDSVC] Implement the job start time calculation for given days of month
Eric Kohl [Sun, 31 May 2020 20:33:49 +0000 (22:33 +0200)]
[SCHEDSVC] Implement the job start time calculation for given days of month

14 months ago[SCHEDSVC] Fix the job start time calculation for given days of week.
Eric Kohl [Sun, 31 May 2020 13:48:07 +0000 (15:48 +0200)]
[SCHEDSVC] Fix the job start time calculation for given days of week.

14 months ago[NTDLL] Use lowest OS version GUID in the application manifest, instead of highest
Timo Kreuzer [Sun, 1 Mar 2020 22:40:57 +0000 (23:40 +0100)]
[NTDLL] Use lowest OS version GUID in the application manifest, instead of highest

14 months ago[MSTASK] Add C stubs and comment out decorated exports
Timo Kreuzer [Fri, 28 Feb 2020 13:09:57 +0000 (14:09 +0100)]
[MSTASK] Add C stubs and comment out decorated exports

MSVC's LINK is not able to export both the undecorated and decorated symbol from the same dll. This results in an incoherence between the spec file entries and the actual exports, breaking the dll export versioning.

14 months ago[NTOSKRNL] Group files in the project file based on directory layout
Mark Jansen [Wed, 27 May 2020 20:28:00 +0000 (22:28 +0200)]
[NTOSKRNL] Group files in the project file based on directory layout

14 months ago[GITHUB] Set up necessary environment variables for Flex and Bison
Victor Perevertkin [Thu, 28 May 2020 20:11:53 +0000 (23:11 +0300)]
[GITHUB] Set up necessary environment variables for Flex and Bison
Decrease ccache size, based on observations
Print ccache statistics in the end of build

14 months ago[CPPRT][CRT] Avoid extern assembly declarations with no type. CORE-17088
Thomas Faber [Thu, 28 May 2020 12:25:31 +0000 (14:25 +0200)]
[CPPRT][CRT] Avoid extern assembly declarations with no type. CORE-17088

Fixes build with ML 14.26.

14 months ago[SHELL32][INCLUDE] Improve CheckEscapesA/W (#2795)
Katayama Hirofumi MZ [Thu, 28 May 2020 01:58:26 +0000 (10:58 +0900)]
[SHELL32][INCLUDE] Improve CheckEscapesA/W (#2795)

Fix and improve shell32!CheckEscapesA/W functions.
Add a testcase for shell32!CheckEscapesA/W to shell32_apitest.

14 months ago[LABEL] wmain(): Initialize 'szBuffer' (#2867)
Serge Gautherie [Wed, 27 May 2020 15:05:33 +0000 (17:05 +0200)]
[LABEL] wmain(): Initialize 'szBuffer' (#2867)

Detected by Cppcheck: uninitvar.

14 months ago[WIN32K:NTUSER] NC_IconForWindow(): Remove redundant if() (#2842)
Serge Gautherie [Tue, 26 May 2020 18:25:39 +0000 (20:25 +0200)]
[WIN32K:NTUSER] NC_IconForWindow(): Remove redundant if() (#2842)

No impact.

Detected by Cppcheck: identicalInnerCondition.
Addendum to 98060c28c8b051bc4cfd460bd008a2eff125658e (r60622).

14 months ago[FORMATTING] [CMAKE] Remove space in 'if (' (#2847)
Serge Gautherie [Tue, 26 May 2020 18:24:02 +0000 (20:24 +0200)]
[FORMATTING] [CMAKE] Remove space in 'if (' (#2847)

14 months ago[WINSPOOL] GetPrinterDriverA(): Refactor failure handling (#2832)
Serge Gautherie [Tue, 26 May 2020 18:21:25 +0000 (20:21 +0200)]
[WINSPOOL] GetPrinterDriverA(): Refactor failure handling (#2832)

* [WINSPOOL] GetPrinterDriverA(): Refactor failure handling

Addendum to d90beaeed26863985486874aaa2a1c3422fd6d9f.

14 months ago[CSRSRV] CsrGetProcessLuid(): Check 1st NtQueryInformationToken() result too (#2857)
Serge Gautherie [Mon, 25 May 2020 21:52:35 +0000 (23:52 +0200)]
[CSRSRV] CsrGetProcessLuid(): Check 1st NtQueryInformationToken() result too (#2857)

Detected by Cppcheck: redundantAssignment.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
14 months ago[NTVDM] GetNextFreeVDDEntry(): Remove 'Entry' redundant initialization (#2859)
Serge Gautherie [Mon, 25 May 2020 21:49:47 +0000 (23:49 +0200)]
[NTVDM] GetNextFreeVDDEntry(): Remove 'Entry' redundant initialization (#2859)

Detected by Cppcheck: redundantInitialization.
Addendum to ed874b41 (r61283).

14 months ago[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)
Serge Gautherie [Mon, 25 May 2020 17:57:52 +0000 (19:57 +0200)]
[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)

CORE-17079

14 months ago[HAL:HALPPC] HalAllocateCrashDumpRegisters(): Remove redundant MapRegisterNumber...
Serge Gautherie [Mon, 25 May 2020 16:58:17 +0000 (18:58 +0200)]
[HAL:HALPPC] HalAllocateCrashDumpRegisters(): Remove redundant MapRegisterNumber assignment (#2854)

Detected by CppCheck: redundantAssignment.
Addendum to commit 81f09273 (r28793).

14 months ago[PROCESSR][INF] Fix "Intel Intel" duplication typos
Stanislav Motylkov [Sun, 24 May 2020 23:36:17 +0000 (02:36 +0300)]
[PROCESSR][INF] Fix "Intel Intel" duplication typos

Addendum to 3509318.

14 months ago[NTOS:PO] Report correct CPU frequency in CurrentMhz
Stanislav Motylkov [Sun, 24 May 2020 22:24:52 +0000 (01:24 +0300)]
[NTOS:PO] Report correct CPU frequency in CurrentMhz

Also add some relevant FIXME comments. CORE-13206

14 months ago[NTOS:INBV] Fix hardcoded values (#2840)
Yaroslav Kibysh [Sun, 24 May 2020 17:37:47 +0000 (20:37 +0300)]
[NTOS:INBV] Fix hardcoded values (#2840)

14 months ago[NTOS:EX] ExpInitializeExecutive(): Fix 'PerfMem' copypasta (#2841)
Serge Gautherie [Sun, 24 May 2020 17:37:16 +0000 (19:37 +0200)]
[NTOS:EX] ExpInitializeExecutive(): Fix 'PerfMem' copypasta (#2841)

Detected by Cppcheck: identicalInnerCondition.
Addendum to commit c307d73c (r25621).

14 months ago[ADVAPI32] Convert ordinals to @ in spec file
Timo Kreuzer [Sat, 29 Feb 2020 08:37:20 +0000 (09:37 +0100)]
[ADVAPI32] Convert ordinals to @ in spec file

14 months ago[TRANSLATION] Hungarian translation update for shell32 (#2828)
Tibor Lajos Füzi [Sat, 23 May 2020 17:20:16 +0000 (19:20 +0200)]
[TRANSLATION] Hungarian translation update for shell32 (#2828)

14 months ago[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)
Serge Gautherie [Sat, 23 May 2020 17:07:04 +0000 (19:07 +0200)]
[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)

Reported by contributor 'qarmin'.
CORE-17074

14 months ago[NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is
Timo Kreuzer [Thu, 29 Aug 2019 20:10:49 +0000 (22:10 +0200)]
[NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is

14 months ago[NTOSKRNL] Sync some INIT_FUNCTION (#2824)
Serge Gautherie [Sat, 23 May 2020 14:05:58 +0000 (16:05 +0200)]
[NTOSKRNL] Sync some INIT_FUNCTION (#2824)

- Sync some INIT_FUNCTION with how they are used and what is already
  specified in the headers.
Addendum to commit 85e5b5be (r49445).

- KdbpGetCommandLineSettings(): Remove INIT_FUNCTION.
Fix MSVC 2015 x86 custom build:
"...\ntoskrnl\kdbg\kdb.c(1699): error C2983: 'KdbpGetCommandLineSettings': all declarations must have an identical __declspec(code_seg(...))"

And may also fix obscure bugs when entering into the KDBG debugger.

14 months ago[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)
Serge Gautherie [Sat, 23 May 2020 13:56:10 +0000 (15:56 +0200)]
[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)

(but after 'static' or SAL 2 annotation.)
Follow-up to 71fefa32, which mentions that it's actually required by the compiler in some circumstances.

14 months ago[APPWIZ] Polish translation update (#2790)
Piotr Hetnarowicz [Sat, 23 May 2020 13:43:56 +0000 (15:43 +0200)]
[APPWIZ] Polish translation update (#2790)

FIXED: dialogs, button, description

14 months ago[MC] Update Polish translation of netmsgmsg.mc (#2691)
Piotr Hetnarowicz [Sat, 23 May 2020 13:42:11 +0000 (15:42 +0200)]
[MC] Update Polish translation of netmsgmsg.mc (#2691)

Co-authored-by: Adam Słaboń <asaillen456esx@gmail.com>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
14 months ago[RAPPS] Update Portuguese translation (#2820)
Jose Carlos Jesus [Sat, 23 May 2020 13:17:52 +0000 (14:17 +0100)]
[RAPPS] Update Portuguese translation (#2820)

Update translation following PR #2792.

14 months ago[USERENV] Implement DeleteProfileW()
Eric Kohl [Sat, 23 May 2020 10:37:16 +0000 (12:37 +0200)]
[USERENV] Implement DeleteProfileW()

14 months ago[SAMSRV] SampInitializeSAM: Fix indentation and add comments
Eric Kohl [Sat, 23 May 2020 09:27:35 +0000 (11:27 +0200)]
[SAMSRV] SampInitializeSAM: Fix indentation and add comments

14 months ago[WINSPOOL] GetPrinterA(): Refactor failure handling (#2830)
Serge Gautherie [Sat, 23 May 2020 07:08:00 +0000 (09:08 +0200)]
[WINSPOOL] GetPrinterA(): Refactor failure handling (#2830)

Addendum to ecde3768254664ca40a3f2fa49d1342d4bd92c02.

14 months ago[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French trans...
Kyle Katarn [Fri, 22 May 2020 13:53:17 +0000 (15:53 +0200)]
[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French translation update (#2807)

As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Similar to #2743 by @HBelusca

14 months ago[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810)
Kyle Katarn [Fri, 22 May 2020 13:49:27 +0000 (15:49 +0200)]
[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810)

- PS2 Mouse Advanced Properties : Static control (frame) added
- PS2 Mouse Advanced Properties : French translation added and control layout adapted accordingly
- Mouse CPL > Wheel > Sroll line text box ES_NUMBER style added
- ReactOS Setup : French translation added

14 months ago[BROWSER] Add the browser service
Eric Kohl [Thu, 21 May 2020 20:49:33 +0000 (22:49 +0200)]
[BROWSER] Add the browser service

14 months ago[UMPNPMGR] Start work on PNP_GetNextResDes()
Eric Kohl [Thu, 21 May 2020 19:49:46 +0000 (21:49 +0200)]
[UMPNPMGR] Start work on PNP_GetNextResDes()

14 months ago[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826)
Serge Gautherie [Thu, 21 May 2020 16:52:50 +0000 (18:52 +0200)]
[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826)

Addendum to 612729b09272aeb693e156de6b5991891951dbf2.

CORE-17069

14 months ago[ACCESS.CPL] Improvements to Portuguese translation (#2800)
Jose Carlos Jesus [Thu, 21 May 2020 13:36:33 +0000 (14:36 +0100)]
[ACCESS.CPL] Improvements to Portuguese translation (#2800)

14 months ago[NTOS:INBV] Fix screen flash and more (#2821)
Yaroslav Kibysh [Wed, 20 May 2020 22:23:17 +0000 (01:23 +0300)]
[NTOS:INBV] Fix screen flash and more (#2821)

- Fix screen flash (CORE-16786);
- Don't process rotating bar if not used.

14 months ago[RAPPS] Rapps trivial fixes (#2819)
He Yang [Wed, 20 May 2020 22:21:26 +0000 (06:21 +0800)]
[RAPPS] Rapps trivial fixes (#2819)

- Specify W explicitly for URL_COMPONENTS;
- Remove malloc/free for once used HostName in urlComponents;
- Use PathAppendW to operate on path string.

14 months ago[SDK][FREETYPE] Fix GCC8.4 -O2 build
Victor Perevertkin [Wed, 20 May 2020 22:07:26 +0000 (01:07 +0300)]
[SDK][FREETYPE] Fix GCC8.4 -O2 build

14 months ago[REACTOS] Remove executable bits on source files (#2822)
Serge Gautherie [Wed, 20 May 2020 21:09:44 +0000 (23:09 +0200)]
[REACTOS] Remove executable bits on source files (#2822)

14 months ago[UMPNPMGR] Improve some debug messages
Eric Kohl [Sun, 17 May 2020 18:35:41 +0000 (20:35 +0200)]
[UMPNPMGR] Improve some debug messages

14 months ago[RAPPS] French translation update following PR #2792 (#2815)
Kyle Katarn [Wed, 20 May 2020 14:05:12 +0000 (16:05 +0200)]
[RAPPS] French translation update following PR #2792 (#2815)

14 months ago[MAIN.CPL] Fix of Keyboard settings French translation (#2812)
Kyle Katarn [Wed, 20 May 2020 13:47:24 +0000 (15:47 +0200)]
[MAIN.CPL] Fix of Keyboard settings French translation (#2812)

14 months ago[TIMEDATE] French translation (#2811)
Kyle Katarn [Wed, 20 May 2020 13:45:47 +0000 (15:45 +0200)]
[TIMEDATE] French translation (#2811)

14 months ago[SHELL32] Allow creation of an empty CFileSysEnum
Mark Jansen [Tue, 19 May 2020 18:35:52 +0000 (20:35 +0200)]
[SHELL32] Allow creation of an empty CFileSysEnum
CORE-16908

14 months ago[SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028
Joachim Henze [Tue, 19 May 2020 18:32:21 +0000 (20:32 +0200)]
[SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028

The build broke due to a typo introduced by
0.4.15-dev-275-g
612729b09272aeb693e156de6b5991891951dbf2

../dll/win32/syssetup/wizard.c: In function 'ProductPageDlgProc':
../dll/win32/syssetup/wizard.c:527:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-
after-statement]
cc1.exe: all warnings being treated as errors

14 months ago[RAPPS] Move database source URL to settings dialog (#2792)
He Yang [Tue, 19 May 2020 17:06:10 +0000 (01:06 +0800)]
[RAPPS] Move database source URL to settings dialog (#2792)

- Add download source in settings dialog, and apply it when download .cab file
- Now user should specify full rappmgr.cab URL
- Check if URL is vaild in settings dialog
- Move source settings to the end of struct (will refactor settings to one value per option later)

14 months ago[JOY] Fix missing UI elements and French translation (#2808)
Kyle Katarn [Tue, 19 May 2020 10:09:05 +0000 (12:09 +0200)]
[JOY] Fix missing UI elements and French translation (#2808)

Missing GUI elements added.
Improve French translation.

14 months ago[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749)
Katayama Hirofumi MZ [Tue, 19 May 2020 06:41:26 +0000 (15:41 +0900)]
[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749)

- Make "ReactOS Server" the default product option again instead of "ReactOS Workstation".
- Write "Service Pack" info onto registry.
- Add ProductOption option to bootcd unattend.inf.
- Delete IDC_PRODUCT_SUITE and IDC_PRODUCT_TYPE controls.
CORE-17028

14 months ago[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2797)
Katayama Hirofumi MZ [Tue, 19 May 2020 00:29:42 +0000 (09:29 +0900)]
[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2797)

Investigate on nSources and fRecursive parameters. CORE-13950

14 months ago[SHELL32_APITEST] Disabled DragDrop test due to race condition
Victor Perevertkin [Mon, 18 May 2020 17:50:07 +0000 (20:50 +0300)]
[SHELL32_APITEST] Disabled DragDrop test due to race condition
To be enabled back when the bug is fixed
CORE-17057

14 months ago[CMD] Add a ExecuteCommandWithEcho() helper and use it in Batch() and as the implemen...
Hermès Bélusca-Maïto [Mon, 18 May 2020 00:03:15 +0000 (02:03 +0200)]
[CMD] Add a ExecuteCommandWithEcho() helper and use it in Batch() and as the implementation of RunInstance() FOR-loop helper.

14 months ago[CMD] Fix the stop-batch prompt appearance: do not display it more than once in a...
Hermès Bélusca-Maïto [Sun, 17 May 2020 18:13:32 +0000 (20:13 +0200)]
[CMD] Fix the stop-batch prompt appearance: do not display it more than once in a row.

14 months ago[CMD] Fix the ErrorMessage() function.
Hermès Bélusca-Maïto [Sun, 17 May 2020 18:08:41 +0000 (20:08 +0200)]
[CMD] Fix the ErrorMessage() function.

Specify its szFormat parameter optional, and correctly initialize the
szMessage buffer.

14 months ago[DESK][TIMEDATE] Update Portuguese translation (#2801)
Jose Carlos Jesus [Sun, 17 May 2020 21:53:54 +0000 (22:53 +0100)]
[DESK][TIMEDATE] Update Portuguese translation (#2801)

14 months ago[EVENTVWR] Update polish translation (#2804)
Adam Stachowicz [Sun, 17 May 2020 21:39:56 +0000 (23:39 +0200)]
[EVENTVWR] Update polish translation (#2804)

After commit 8756cec0.

14 months ago[FREELDR] Fix I/O range size of serial ports
Hervé Poussineau [Sun, 17 May 2020 20:49:47 +0000 (22:49 +0200)]
[FREELDR] Fix I/O range size of serial ports

14 months ago[NTOS:OB] Fix incorrect variable name in ObfDereferenceObject.
Thomas Faber [Fri, 8 May 2020 15:53:29 +0000 (17:53 +0200)]
[NTOS:OB] Fix incorrect variable name in ObfDereferenceObject.

14 months ago[NTOS] Prohibit use of MAX_PATH in the kernel. Use MAX_WIN32_PATH if you really mean...
Thomas Faber [Sun, 31 Mar 2019 07:18:16 +0000 (09:18 +0200)]
[NTOS] Prohibit use of MAX_PATH in the kernel. Use MAX_WIN32_PATH if you really mean it. CORE-15882

14 months ago[NTOS:PNP] Directly accept a UNICODE_STRING in LocateChildDevice. CORE-15882 2720/head
Thomas Faber [Sat, 2 May 2020 15:57:46 +0000 (17:57 +0200)]
[NTOS:PNP] Directly accept a UNICODE_STRING in LocateChildDevice. CORE-15882

14 months ago[NTOS:PNP] Avoid an unnecessary stack buffer in PnpRootCreateDevice. CORE-15882
Thomas Faber [Sat, 2 May 2020 15:42:40 +0000 (17:42 +0200)]
[NTOS:PNP] Avoid an unnecessary stack buffer in PnpRootCreateDevice. CORE-15882

14 months ago[NTOS:PNP] Avoid an unnecessary stack buffer in EnumerateDevices. CORE-15882
Thomas Faber [Sat, 2 May 2020 15:33:24 +0000 (17:33 +0200)]
[NTOS:PNP] Avoid an unnecessary stack buffer in EnumerateDevices. CORE-15882

14 months ago[NTOS:PNP] Move child device creation into its own function
Thomas Faber [Sat, 2 May 2020 15:08:12 +0000 (17:08 +0200)]
[NTOS:PNP] Move child device creation into its own function

Also fix some leaks and a DPRINT format string.

14 months ago[SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP)
Eric Kohl [Sun, 17 May 2020 17:37:49 +0000 (19:37 +0200)]
[SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP)

14 months ago[EVENTVWR] Implementation of Properties page functionnal code. (#2744)
Kyle Katarn [Sun, 17 May 2020 16:54:39 +0000 (18:54 +0200)]
[EVENTVWR] Implementation of Properties page functionnal code. (#2744)

Implementation of functional code for log properties page in order to allow user to :
- Make modification and have them taken into account when properties page is closed / apply is used;
- Set defaults (including correction of default max size);
- Delete content of log;
- Make "Apply" button functional based on user inputs;
- Correct default value during installation (duration, size).

- Improve InitPropertiesDlg() error;
- Fix SavePropertiesDlg(): When the event log key does not exist, it is not recreated by the event log viewer.
- GetDisplayNameFileAndID(): Show the error also when opening the event log key fails.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
14 months ago[CHARMAP_NEW] Remove non-existing entries. basque_translation
Hermès Bélusca-Maïto [Sun, 17 May 2020 16:46:14 +0000 (18:46 +0200)]
[CHARMAP_NEW] Remove non-existing entries.

14 months ago[TRANSLATION] Update Spanish, and add Basque translation (#2667)
Julen Urizar Compains [Sun, 26 Apr 2020 03:49:07 +0000 (05:49 +0200)]
[TRANSLATION] Update Spanish, and add Basque translation (#2667)

Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.

14 months ago[BOOTVID][HALXBOX] Implement boot video driver for Xbox (#2774) 2774/head
Stanislav Motylkov [Tue, 12 May 2020 14:32:37 +0000 (17:32 +0300)]
[BOOTVID][HALXBOX] Implement boot video driver for Xbox (#2774)

Also make HalpBiosDisplayReset() function always return FALSE,
because we don't have a BIOS on Xbox.

CORE-16216 CORE-16219

14 months ago[ACPPAGE] Add Portuguese translation (#2802)
Jose Carlos Jesus [Sun, 17 May 2020 16:12:11 +0000 (17:12 +0100)]
[ACPPAGE] Add Portuguese translation (#2802)

14 months ago[COMDLG32] Differentiate between real and virtual folders, 2746/head
Mark Jansen [Wed, 6 May 2020 20:04:11 +0000 (22:04 +0200)]
[COMDLG32] Differentiate between real and virtual folders,
do not allow traversal inside virtual folders when selecting a file
CORE-16908

14 months ago[SHELLUTILS] Fix Win32DbgPrint's result
Mark Jansen [Sun, 13 Oct 2019 16:05:34 +0000 (18:05 +0200)]
[SHELLUTILS] Fix Win32DbgPrint's result

14 months ago[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
Mark Jansen [Mon, 27 Apr 2020 18:43:16 +0000 (20:43 +0200)]
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
CORE-16908

14 months ago[SHELL32] Update CFileSysEnum to be maintaineable
Mark Jansen [Mon, 27 Apr 2020 14:11:21 +0000 (16:11 +0200)]
[SHELL32] Update CFileSysEnum to be maintaineable
CORE-16908

14 months ago[SHLWAPI] Fix SHRegGetCLSIDKeyW
Mark Jansen [Mon, 27 Apr 2020 10:53:47 +0000 (12:53 +0200)]
[SHLWAPI] Fix SHRegGetCLSIDKeyW

14 months ago[PSDK] Add argument names to SHRegGetValue functions
Mark Jansen [Mon, 27 Apr 2020 14:00:20 +0000 (16:00 +0200)]
[PSDK] Add argument names to SHRegGetValue functions

14 months ago[NTOS:SE] Implement job case in PsImpersonateClient. CORE-8787 2772/head
Thomas Faber [Mon, 11 May 2020 06:41:38 +0000 (08:41 +0200)]
[NTOS:SE] Implement job case in PsImpersonateClient. CORE-8787

14 months ago[GITHUB] Enable ccache for GCC builds on GitHub Actions
Victor Perevertkin [Sun, 17 May 2020 10:32:14 +0000 (13:32 +0300)]
[GITHUB] Enable ccache for GCC builds on GitHub Actions

14 months ago[SERVICES][DCOMLAUNCH] Don't hardcode C: drive (#2779)
Katayama Hirofumi MZ [Sun, 17 May 2020 08:45:56 +0000 (17:45 +0900)]
[SERVICES][DCOMLAUNCH] Don't hardcode C: drive (#2779)

CORE-13235

14 months ago[ISAPNP] Mark read data port as started, even if no ISAPNP card is present
Hervé Poussineau [Sat, 16 May 2020 21:17:19 +0000 (23:17 +0200)]
[ISAPNP] Mark read data port as started, even if no ISAPNP card is present

CORE-17056

14 months ago[HOST-TOOLS] Fix the build from IDE for visual studio 2019 CE 2799/head
Mark Jansen [Sat, 16 May 2020 16:19:31 +0000 (18:19 +0200)]
[HOST-TOOLS] Fix the build from IDE for visual studio 2019 CE
CORE-16904

14 months ago[REGEDIT] Fix and improvement in TreeView (Null handle check, incorrect display after...
Kyle Katarn [Sat, 16 May 2020 12:23:20 +0000 (14:23 +0200)]
[REGEDIT] Fix and improvement in TreeView (Null handle check, incorrect display after edit, WM_NOTIFY refactor) (#2733)

* - Fix of missing invalid handle check
- Fix of Address & status bar incorrect display after rename
- Refactoring of Treeview WM_NOTIFY code, for better consistency with WM_NOTIFY management for ListView

* Fix following review (space in #define)

* Cleanup following review

* fix following review

* Fix of round 3 of review comments

* UpdateAdress kept in its original location

* fix

* fix (extern missing)

* both extern removed

* Review comments
Error message being added in order to support CORE-17048

14 months ago[CPORTLIB] Fix MSVC build for PC-98 target
Dmitry Borisov [Fri, 15 May 2020 20:09:01 +0000 (02:09 +0600)]
[CPORTLIB] Fix MSVC build for PC-98 target

14 months ago[ISAPNP] Initialize uninitialized variable
Mark Jansen [Sat, 16 May 2020 12:03:04 +0000 (14:03 +0200)]
[ISAPNP] Initialize uninitialized variable
Return value was a suggestion from Thomas,
it still boots for me (tm)

14 months ago[HAL] Remove duplicated IRQL mask tables
Colin Finck [Fri, 15 May 2020 21:46:22 +0000 (23:46 +0200)]
[HAL] Remove duplicated IRQL mask tables

With the minimum Visual Studio version now being 2015, we no longer need to maintain two variants of the same code, and can stick to the commented and better understandable version.

14 months ago[BOOTVID] Add boot video driver for NEC PC-98 series (#2787) 2787/head
Dmitry Borisov [Thu, 14 May 2020 10:36:55 +0000 (16:36 +0600)]
[BOOTVID] Add boot video driver for NEC PC-98 series (#2787)

14 months ago[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)
Jose Carlos Jesus [Fri, 15 May 2020 16:12:02 +0000 (17:12 +0100)]
[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)

During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k.
Therefore their position needs to be recomputed so that they try to fit the best on screen.

CORE-9008, CORE-9602