Jérôme Gardou [Wed, 7 Apr 2021 21:26:44 +0000 (23:26 +0200)]
Revert "[NTOS:MM] Allow MiMapPageInHyperSpace to be called from DISPATCH_LEVEL"
This reverts commit
8404d1a6ff897f5210860ba52d70c3a6e86f3fbb.
Not ready for prime time, sorry.
Jérôme Gardou [Wed, 7 Apr 2021 21:05:51 +0000 (23:05 +0200)]
[NTOS:MM] Allow MiMapPageInHyperSpace to be called from DISPATCH_LEVEL
Also annotate it to show its behaviour.
Eric Kohl [Wed, 7 Apr 2021 20:39:47 +0000 (22:39 +0200)]
[INF] Disable the AddInterface directive temporarily, in order to install volume devices.
CORE-17530
Eric Kohl [Wed, 7 Apr 2021 19:39:55 +0000 (21:39 +0200)]
[SETUPAPI] SetupDiInstallDevice: Do not fail if the .inf file does not have a .Services section
CORE-17530
Hervé Poussineau [Wed, 7 Apr 2021 17:26:06 +0000 (19:26 +0200)]
[SYSSETUP] Manually start PlugPlay service, and wait for it before continuing
That way, class installers are already registered before installing devices.
CORE-17538
Oleg Dubinskiy [Mon, 5 Apr 2021 18:49:50 +0000 (21:49 +0300)]
[NTOS:MM][NTOS:SE] Mute some noisy stubs
Mute debug prints of MmDoesFileHaveUserWritableReferences and SeAuditingFileEventsWithContext stubs.
These stubs are very noisy and create a lot of spam in the log when using Microsoft NTFS driver in ReactOS (with some other improvements applied).
Implementing those functions isn't badly required for the proper work of this driver, so better way for now is just mute these stubs a bit.
After my changes, they will be displayed only once, and the log will be more clear, so it will seem to be enough to understand that the driver calls these routines.
CORE-17409
George Bișoc [Wed, 7 Apr 2021 08:11:07 +0000 (10:11 +0200)]
[USETUP] Display some contents in the page whilst installing the bootloader (#3559)
CORE-17523
Katayama Hirofumi MZ [Wed, 7 Apr 2021 08:08:23 +0000 (17:08 +0900)]
Revert '[FONTEXT_APITEST] Follow-up of #3585'
Katayama Hirofumi MZ [Wed, 7 Apr 2021 04:38:22 +0000 (13:38 +0900)]
[BROWSEUI] Reduce IAutoComplete failures (#3590)
- Delete OnEditUpdate method.
- Improve the expand condition.
CORE-9281
Katayama Hirofumi MZ [Wed, 7 Apr 2021 03:39:28 +0000 (12:39 +0900)]
[BROWSEUI_APITEST] Strengthen IAutoComplete testcase
Jérôme Gardou [Tue, 6 Apr 2021 17:28:47 +0000 (19:28 +0200)]
[CMAKE] Make cmake use static libraries for testing the compiler
Jérôme Gardou [Tue, 6 Apr 2021 17:23:31 +0000 (19:23 +0200)]
[CMAKE] Honor CMAKE_EXE_LINKER_FLAGS_INIT in GCC build
Jérôme Gardou [Tue, 6 Apr 2021 08:53:35 +0000 (10:53 +0200)]
[NTOS:KE] Rewrite KiSystemCallTrampoline in assembly
Instead of making assumptions about what the compiler does with forced-inline functions
Katayama Hirofumi MZ [Tue, 6 Apr 2021 12:56:40 +0000 (21:56 +0900)]
[BROWSEUI] auto-completion: Reduce failures in ACListISF (#3589)
Reduce failures in ACListISF testcase. Skip left space in auto-completion. Accept the pair of drive letter and colon. CORE-9281
Katayama Hirofumi MZ [Tue, 6 Apr 2021 00:02:53 +0000 (09:02 +0900)]
[FONTEXT_APITEST] Follow-up of #3585 (
deb928c)
Strengthen GetDisplayNameOf testcase. CORE-9281, CORE-16444
Mark Jansen [Mon, 5 Apr 2021 22:54:58 +0000 (00:54 +0200)]
[FONTEXT_APITEST] Show that fontext returns absolute paths with SHGDN_FORPARSING (#3585)
Add GetDisplayNameOf testcase. CORE-9281, CORE-16444
Eric Kohl [Mon, 5 Apr 2021 13:34:55 +0000 (15:34 +0200)]
[PARTMGR] Volume devices do not have compatible IDs and their instance IDs are not unique
Katayama Hirofumi MZ [Mon, 5 Apr 2021 13:20:01 +0000 (22:20 +0900)]
[BROWSEUI] Accept environment variables in ACLO_FILESYSDIRS
Properly handle ACLO_FILESYSDIRS. CORE-9281
Eric Kohl [Mon, 5 Apr 2021 12:33:09 +0000 (14:33 +0200)]
[NTOS:PNP] PiSetDevNodeText: Do not overwrite existing DeviceDesc values
CORE-17513
Katayama Hirofumi MZ [Mon, 5 Apr 2021 08:20:35 +0000 (17:20 +0900)]
[BROWSEUI] Accept environment variables on auto-completion
Expand %WINDIR%, %SystemRoot% etc. at CACListISF::Expand. CORE-9281
Katayama Hirofumi MZ [Sun, 4 Apr 2021 22:43:40 +0000 (07:43 +0900)]
[BROWSEUI] Follow-up of #3582
Also fixes VK_HOME and VK_END. CORE-9281
Katayama Hirofumi MZ [Sun, 4 Apr 2021 19:20:18 +0000 (04:20 +0900)]
[BROWSEUI][BROWSEUI_APITEST] Add CLSID_ACLHistory stubs (#3582)
- Initial implement CLSID_ACLHistory as stub.
- Add IACLHistory testcase into browseui_apitest.
CORE-9281
Eric Kohl [Sun, 4 Apr 2021 09:44:38 +0000 (11:44 +0200)]
[DEVMGR] Display hexadecimal values of Capabilities, ConfigFlags, DevnodeFlags and CsFlags
Serge Gautherie [Wed, 1 May 2019 15:14:49 +0000 (17:14 +0200)]
[CMAKE] Properly generate all Bison and Flex files at build time
This fully reverts
09c4d0a.
Addendum to
5375e33.
CORE-15991
Mark Jansen [Mon, 4 Jan 2021 21:08:48 +0000 (22:08 +0100)]
[NTOS:MM] Stubplement cookie generation for drivers
Katayama Hirofumi MZ [Sat, 3 Apr 2021 11:38:25 +0000 (20:38 +0900)]
[BROWSEUI] Fix auto-completion on relative paths (#3578)
Fix the CLSID_ACListISF object about relative paths. If the given path is relative at CACListISF::Expand, then convert it to a full path. CORE-9281
Katayama Hirofumi MZ [Sat, 3 Apr 2021 07:56:49 +0000 (16:56 +0900)]
[BROWSEUI_APITEST] Strengthen ACListISF testcase (#3577)
Analyze CLSID_ACListISF's behavior about relative paths. CORE-9281
Eric Kohl [Sat, 3 Apr 2021 07:38:07 +0000 (09:38 +0200)]
[NTOS:EX] Use RtlCutoverTimeToSystemTime to determine the current time zone id
CORE-14658
Mark Jansen [Fri, 2 Apr 2021 23:54:57 +0000 (01:54 +0200)]
[SERVICES] Fix booting with DPH enabled
RegSetValueExW tries to read one extra character after the buffer,
to see if a REG_SZ is null terminated
Mark Jansen [Fri, 2 Apr 2021 23:43:48 +0000 (01:43 +0200)]
[UMPNPMGR] Fix remaining length calculation
Hervé Poussineau [Fri, 2 Apr 2021 22:51:23 +0000 (00:51 +0200)]
[SETUPAPI] Fix wrong buffer size given to CM_Get_Device_ID_List_ExW
This buffer overflow was introduced in previous commit.
Hervé Poussineau [Fri, 2 Apr 2021 18:00:31 +0000 (20:00 +0200)]
[SETUPAPI] Use CM_* functions to get list of devices
- this prevents duplicating the code with umpnpmgr::PNP_GetDeviceList
- we can enumerate devices on other computers
This is part of the bugfix for CORE-17529
Katayama Hirofumi MZ [Fri, 2 Apr 2021 08:04:43 +0000 (17:04 +0900)]
[SHELL32] Auto-completion on Properties for Shortcut (#3574)
Enable auto-completion on "Properties for Shortcut files". CORE-9281
Katayama Hirofumi MZ [Fri, 2 Apr 2021 02:06:01 +0000 (11:06 +0900)]
[NEWDEV] Enable auto-completion on Hardware Wizard (#3573)
Realize auto-completion on Hardware Wizard. CORE-9281
Katayama Hirofumi MZ [Thu, 1 Apr 2021 23:58:09 +0000 (08:58 +0900)]
[NEWDEV] Use new UI dialog for browsing folder
Add BIF_USENEWUI flag to BROWSEINFO. CORE-9281
Katayama Hirofumi MZ [Thu, 1 Apr 2021 13:50:32 +0000 (22:50 +0900)]
[NOTEPAD][WORDPAD][MSPAINT]... Use newer file open dialog (#3571)
Use new-style file open/save-as dialog.
- Add OFN_EXPLORER flag to OPENFILENAME structure in notepad, wordpad, mspaint, clipbrd, mmc, mplay32, mscutils, regedit, winhlp32, progman, shellbtrfs, cryptui, shell32, setupapi, vgafontedit, infinst, and vfdlib modules.
Katayama Hirofumi MZ [Wed, 31 Mar 2021 21:41:24 +0000 (06:41 +0900)]
[COMDLG32] Enable auto-completion on comdlg32 (#3564)
Auto-completion will be enabled when the user opens "Open" or "Save As" dialog of the common dialogs. CORE-9281
NOTE: The relative pathes, "..\" and "\" are not working. Those are bugs in CLSID_ACListISF.
Jérôme Gardou [Mon, 22 Mar 2021 11:39:08 +0000 (12:39 +0100)]
[WIN32K] Fix getting long value from float object
Most importantly, do not shift 32-bit integers by 32 or more.
Jérôme Gardou [Wed, 17 Mar 2021 17:43:59 +0000 (18:43 +0100)]
[WIN32K] More cleanup & improvements
Use FLOATOBJs to perform device<->world transformations, avoiding use of XFORMOBJ all the time
Remove unused macros & functions
Jérôme Gardou [Wed, 17 Mar 2021 15:21:58 +0000 (16:21 +0100)]
[WIN32K] Use INTERNAL_LPTODP in IntLPtoDP
Instead of initializing a XFORMOBJ and whatnot
Jérôme Gardou [Wed, 31 Mar 2021 14:17:02 +0000 (16:17 +0200)]
[WIN32K] Rewrite PATH_Ellipse & PATH_RoundRect using integer arithmetics
Jérôme Gardou [Wed, 31 Mar 2021 14:13:59 +0000 (16:13 +0200)]
[WIN32K] Reduce use of FPU in path implementation with use of FLOATOBJs
Jérôme Gardou [Wed, 31 Mar 2021 14:55:30 +0000 (16:55 +0200)]
[WIN32K] Fix brain-fail of mine
Copying e.g. (2;2);(6;6) to (0;0);(4;4) also needs to have an intermediate buffer.
Jérôme Gardou [Wed, 31 Mar 2021 13:02:20 +0000 (15:02 +0200)]
[WIN32K] Fix case when buffers overlap in 1BPP -> 1BPP DIB copy
Logic by Doug Lyons
CORE-17520
Jérôme Gardou [Wed, 31 Mar 2021 07:59:44 +0000 (09:59 +0200)]
[WIN32K] Fix off-by-one errors
Spotted by Doug Lyons
CORE-17520
Jérôme Gardou [Mon, 8 Feb 2021 13:33:08 +0000 (14:33 +0100)]
[NTOS:MM] Properly fail for invalid sizes of data section mappings
Jérôme Gardou [Thu, 11 Feb 2021 17:15:25 +0000 (18:15 +0100)]
[NTOS:MM] Fix compilation when PFN tracing is enabled
Jérôme Gardou [Wed, 10 Feb 2021 11:26:31 +0000 (12:26 +0100)]
[KDGDB] Break and ignore when being prompted.
Jérôme Gardou [Thu, 22 Oct 2020 13:26:21 +0000 (15:26 +0200)]
[NTOS/MM] Remove an outdated check
Jérôme Gardou [Tue, 30 Mar 2021 14:20:25 +0000 (16:20 +0200)]
[NTOS:MM] Fix PFN tracing
Katayama Hirofumi MZ [Mon, 29 Mar 2021 21:50:32 +0000 (06:50 +0900)]
[BROWSEUI] Enable AutoAppend of auto-completion (#3552)
Fix and improve Auto-Append of auto-completion. CORE-9281
- Implement CAutoComplete::DoAutoAppend method.
Eric Kohl [Sun, 28 Mar 2021 14:20:10 +0000 (16:20 +0200)]
[WIDL] Do not transfer an explicit primitive binding handle to the server
This enables us to run WIDL-generated code on Windows XP again.
This patch has already been sent upstream.
Jérôme Gardou [Thu, 25 Mar 2021 10:52:22 +0000 (11:52 +0100)]
[LIBCNTPR] Fix a typo
There is no console to display to.
Serge Gautherie [Thu, 25 Mar 2021 10:51:29 +0000 (11:51 +0100)]
[ATL] CWindowImplBaseT::WindowProc(): Narrow 2 ATLASSERT() down (#3529)
Addendum to
e076e05. CORE-17505
George Bișoc [Sat, 13 Mar 2021 19:45:15 +0000 (20:45 +0100)]
[NTOS:SE] Specify the code section of SepCreateSystemProcessToken as INIT
This function is used during the Security kernel module phase initialisation to set up the system process token which the phase initialisation procedure in itself is stored in the INIT section. With that being said, do the same for SepCreateSystemProcessToken too and add a header documentation as an addition.
George Bișoc [Sat, 13 Mar 2021 19:32:18 +0000 (20:32 +0100)]
[NTOS:SE] Create the anonymous logon tokens on Security initialisation phase
George Bișoc [Sat, 13 Mar 2021 19:11:58 +0000 (20:11 +0100)]
[NTOS:SE] Implement SepCreateSystemAnonymousLogonToken and SepCreateSystemAnonymousLogonTokenNoEveryone functions
These private functions are needed to set up two different kinds of system's anonymous logon tokens: one that includes everyone in the group and the other that doesn't. These functions are needed as next step closer to the
implementation of NtImpersonateAnonymousToken system call.
George Bișoc [Sat, 13 Mar 2021 13:33:15 +0000 (14:33 +0100)]
[NTOS:SE] Set up an ACL and SD for the anonymous logon
Katayama Hirofumi MZ [Wed, 24 Mar 2021 22:42:24 +0000 (07:42 +0900)]
[BROWSEUI] Support ACO_USETAB and SHACF_USETAB on auto-completion (#3549)
Support Tab key on auto-completion. CORE-9281
Jérôme Gardou [Tue, 16 Feb 2021 16:17:57 +0000 (17:17 +0100)]
[NTOS:CC] Wake up lazy scan after inserting elements in the list.
Jérôme Gardou [Tue, 16 Feb 2021 10:26:25 +0000 (11:26 +0100)]
[NTOS:CC] Be verbose about why we defer writes
Jérôme Gardou [Wed, 24 Mar 2021 13:26:15 +0000 (14:26 +0100)]
[CMAKE] Declare KD stub Dlls as kerneldll
Serge Gautherie [Thu, 12 Nov 2020 00:22:46 +0000 (01:22 +0100)]
[SYSSETUP] security.c: Remove 3 useless casts
And
* Make 1 cast more explicit.
* Fix 1 'SamSetInformationUser' copypasta in DPRINT1() text.
* Optimize 1 '.MaximumLength' assignment.
Jérôme Gardou [Thu, 18 Feb 2021 10:36:14 +0000 (11:36 +0100)]
[NTOS:CC] Rewrite CcPostDeferredWrites
This allows to post small writes if there are any, and avoid holding the list lock for a long time.
Jérôme Gardou [Thu, 11 Mar 2021 15:27:54 +0000 (16:27 +0100)]
[NTOS:KE] Explicitly cast -1 to ULONG
Jérôme Gardou [Thu, 11 Mar 2021 15:27:08 +0000 (16:27 +0100)]
[NTOS] Remove a definition which is redundant with ndk
Jérôme Gardou [Thu, 11 Mar 2021 15:26:28 +0000 (16:26 +0100)]
[NTOS:KE] Use PNT_TIB as argument in KeSetTebBase
Jérôme Gardou [Thu, 11 Mar 2021 15:08:34 +0000 (16:08 +0100)]
[SDK:INCLUDE] Cast to type instead of PVOID
For C++ header compatibility
Jérôme Gardou [Thu, 11 Mar 2021 15:06:32 +0000 (16:06 +0100)]
[XDK] Undefine some defines once they are not needed
Konrad Dybcio [Wed, 24 Mar 2021 06:32:11 +0000 (07:32 +0100)]
[HHPCOMP] Add ARM (32-bit) types (#3548)
ARM32 seems to use the same type defines as i386 and friends.
Let's allow the thing to be compiled again!
CORE-17517
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Jérôme Gardou [Tue, 23 Mar 2021 17:35:13 +0000 (18:35 +0100)]
[CSRSRV] Fix comment
Jérôme Gardou [Tue, 23 Mar 2021 17:15:23 +0000 (18:15 +0100)]
[CSRSRV] Fix locking logic when destroying threads & processes
Jérôme Gardou [Tue, 23 Mar 2021 08:54:46 +0000 (09:54 +0100)]
[CMAKE] Move toolchain specific handling to set_module_type_toolchain
+ style fixes
Jérôme Gardou [Thu, 18 Mar 2021 08:48:22 +0000 (09:48 +0100)]
[CMAKE] Put .rsrc section after the INIT section on drivers, like link.exe does
Jérôme Gardou [Wed, 24 Feb 2021 10:47:18 +0000 (11:47 +0100)]
[CMAKE] Use the "kernel" module type for ntoskrnl and ntkrnlmp
Jérôme Gardou [Wed, 24 Feb 2021 10:46:53 +0000 (11:46 +0100)]
[CMAKE] Add the kernel module type
Take this as an occasion to use target_link_options more
Jérôme Gardou [Wed, 24 Feb 2021 09:20:18 +0000 (10:20 +0100)]
[CMAKE] Fixup of driver sections in GCC builds
Also introduce a helper variable to list KMode modules
Jérôme Gardou [Wed, 24 Feb 2021 09:14:40 +0000 (10:14 +0100)]
[SDK:TOOLS] Add --driver option to pefixup
For now, this adds IMAGE_SCN_MEM_DISCARDABLE to the INIT section, and IMAGE_SCN_MEM_NOT_PAGED to sections which are not named PAGE or .reloc
Jérôme Gardou [Tue, 23 Feb 2021 17:29:13 +0000 (18:29 +0100)]
[CMAKE] Restore using LD linker script with GCC
Jérôme Gardou [Tue, 23 Feb 2021 17:26:43 +0000 (18:26 +0100)]
[CMAKE] Put INIT section before .reloc and not after.
CORE-14683
Jérôme Gardou [Mon, 22 Mar 2021 14:59:15 +0000 (15:59 +0100)]
[WIN32K] Rewrite DIB1BPP -> DIB1BPP copy
Simpler is sometimes better.
Fixes some crashes & memory corruptions happening because of all those broken loops.
Jérôme Gardou [Mon, 22 Mar 2021 09:01:39 +0000 (10:01 +0100)]
[NTOS:MM] Fix integer arithmetics
Serge Gautherie [Sun, 21 Mar 2021 03:01:22 +0000 (04:01 +0100)]
[SYSSETUP][TIMEDATE] Use exact setTimer() timeouts, to stay in sync (#3355)
CORE-13121
Katayama Hirofumi MZ [Sat, 20 Mar 2021 05:04:02 +0000 (14:04 +0900)]
[BROWSEUI] Fix return value on sanity check of auto-completion (#3544)
Reduce failures on sanity check of auto-completion. CORE-9281
- Return E_FAIL rather than E_INVALIDARG in sanity check of CAutoComplete::Init (IAutoComplete::Init).
Katayama Hirofumi MZ [Sat, 20 Mar 2021 04:18:47 +0000 (13:18 +0900)]
[BROWSEUI] Fix auto-completion on VK_DELETE (#3543)
Reduce failures against Delete key on auto-completion. CORE-9281
Mark Jansen [Fri, 19 Mar 2021 23:28:07 +0000 (00:28 +0100)]
[SYSSETUP] SamQueryInformationUser expects a pointer
Piotr Hetnarowicz [Sun, 14 Mar 2021 13:16:25 +0000 (14:16 +0100)]
Update dll/cpl/hdwwiz/lang/pl-PL.rc
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Piotr Hetnarowicz [Sun, 14 Mar 2021 13:16:13 +0000 (14:16 +0100)]
Update dll/cpl/hdwwiz/lang/pl-PL.rc
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Piotr Hetnarowicz [Fri, 12 Mar 2021 07:29:34 +0000 (08:29 +0100)]
Update pl-PL.rc
Piotr Hetnarowicz [Fri, 12 Mar 2021 08:46:37 +0000 (09:46 +0100)]
[MMSYSCPL] Update Polish [pl-PL] translation
Jérôme Gardou [Fri, 19 Mar 2021 13:22:16 +0000 (14:22 +0100)]
[SYSSETUP] Install nettcpip.inf
CORE-17514
Jérôme Gardou [Fri, 19 Mar 2021 09:15:31 +0000 (10:15 +0100)]
[NDK][XDK] Use decimal literals for MINxxxx defines
Because myLongLong < MINLONG is supposed to behave like you'd expect
Victor Perevertkin [Fri, 19 Mar 2021 06:14:05 +0000 (09:14 +0300)]
Victor Perevertkin [Fri, 19 Mar 2021 05:59:42 +0000 (08:59 +0300)]
[UMPNPMGR] Install drivers for all devices available on boot
Don't wait for their events to appear, just retrieve the list and
install drivers. This fixes the installation of manually reported device
nodes
CORE-17212 CORE-17398
Victor Perevertkin [Fri, 19 Mar 2021 04:57:41 +0000 (07:57 +0300)]
[NTOS:PNP] Initialize DeviceDesc and LocationInformation registry fields
for manually reported devices, as it is required by the newdev.dll
for installing drivers from INF files
CORE-17212 CORE-17398
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Katayama Hirofumi MZ [Thu, 18 Mar 2021 23:30:10 +0000 (08:30 +0900)]
[SHELL32] Fix assertion failure in CDirectoryWatcher.cpp
CORE-17511
Mark Jansen [Wed, 17 Mar 2021 20:16:57 +0000 (21:16 +0100)]
[SYSSETUP] SamQueryInformationDomain expects a pointer
Victor Perevertkin [Thu, 18 Mar 2021 22:07:22 +0000 (01:07 +0300)]
[NTOS:IO][NTOS:PNP] Fix incorrect usage of IopGetRegistryValue
KEY_VALUE_FULL_INFORMATION was not always freed properly
Jérôme Gardou [Thu, 18 Mar 2021 10:48:09 +0000 (11:48 +0100)]
[NTOS:MM] Silence noisy DPRINTs
Jérôme Gardou [Thu, 18 Mar 2021 08:15:48 +0000 (09:15 +0100)]
[NTOS:MM] Use a define for the big pool table occupation rate