reactos.git
14 months ago[CSRSRV] Only when CSRSRV is compiled in debugging mode, should we display debugging...
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 20:53:49 +0000 (22:53 +0200)]
[CSRSRV] Only when CSRSRV is compiled in debugging mode, should we display debugging messages and support debug breakpoints.

Also, trigger the less fatal breakpoints only if CSRSS/CSRSRV is being
debugged (the 'BeingDebugged' flag is set in the current PEB). This will
avoid any unhandled breakpoint exceptions when testing/fuzzing running
debug builds of ReactOS without any debugger attached.

14 months ago[CSRSRV] s/LPWSTR/PWSTR/ as the former is not NT type.
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 20:38:51 +0000 (22:38 +0200)]
[CSRSRV] s/LPWSTR/PWSTR/ as the former is not NT type.

14 months ago[SYSDM.CPL] fr-FR Resize & Reposition 3 buttons CORE-16595
Joachim Henze [Mon, 13 Apr 2020 23:34:34 +0000 (01:34 +0200)]
[SYSDM.CPL] fr-FR Resize & Reposition 3 buttons CORE-16595

to avoid text truncation of the button
"Environment Variables"

14 months ago[CONSRV] Move process-initialization-specific functions from handle.c into console.c .
Hermès Bélusca-Maïto [Mon, 13 Apr 2020 21:24:55 +0000 (23:24 +0200)]
[CONSRV] Move process-initialization-specific functions from handle.c into console.c .

- Move ConSrvInitHandlesTable() & rename it ConSrvInitProcessHandles()
  since its purpose is to initialize the standard input, output and
  error handles for a console process.

- Move ConSrvAllocateConsole(), ConSrvInheritConsole() and
  ConSrvRemoveConsole().

14 months ago[DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3
Joachim Henze [Mon, 13 Apr 2020 22:42:33 +0000 (00:42 +0200)]
[DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3

Leave english strings untouched regarding space before colon.
Thanks to HBelusca for review as well.
I hope next one translating these will take care still.

14 months ago[DXDIAG] fr-FR Translation Addendum CORE-12477
Joachim Henze [Mon, 13 Apr 2020 22:06:48 +0000 (00:06 +0200)]
[DXDIAG] fr-FR Translation Addendum CORE-12477

Addendum to 0.4.14-dev-1405-g
dcc6dcb0bd6cb076fabe6fe0a45f9556eed1b379

Readd all spaces before the colons that I removed,
as that is a french speciality and was correct,
and also add some more of those that were missing even
before my commit (was inconsistent).

Thanks to Serge Gautherie, Thomas Faber and hpoussin
for the review.

14 months ago[MSPAINT] fr-FR Translate some menu items CORE-12357
Joachim Henze [Mon, 13 Apr 2020 21:27:52 +0000 (23:27 +0200)]
[MSPAINT] fr-FR Translate some menu items CORE-12357

14 months ago[MSCTF_WINETEST] Skip crashing test when it fails
Mark Jansen [Mon, 13 Apr 2020 20:44:56 +0000 (22:44 +0200)]
[MSCTF_WINETEST] Skip crashing test when it fails
CORE-16797

14 months ago[DXDIAG] Less text truncation for all languages
Joachim Henze [Mon, 13 Apr 2020 20:43:37 +0000 (22:43 +0200)]
[DXDIAG] Less text truncation for all languages

Manually Tweaked fr-FR the most, see CORE-12477
Manually Tweaked de-DE enlarged a buttons size
For All Languages harmonized " :"->":"

For All Languages harmonized the maximized available space
for dynamic strings in 2nd tab right side from 100->120

14 months ago[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796
Thomas Faber [Mon, 13 Apr 2020 15:55:00 +0000 (17:55 +0200)]
[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796

14 months agoFix build.
Hermès Bélusca-Maïto [Mon, 13 Apr 2020 16:10:54 +0000 (18:10 +0200)]
Fix build.

14 months ago[CONSRV] Convenience fixes.
Hermès Bélusca-Maïto [Sun, 12 Apr 2020 17:03:30 +0000 (19:03 +0200)]
[CONSRV] Convenience fixes.

- Simplify screen-buffers initialization.
- Get rid of this CONSOLE_SCREEN_BUFFER_VTBL virtual table.
- Move ConsoleInput to a proper header.

14 months ago[SHELL32] No french translation from "right click drag'n'drop"
Eric Kohl [Mon, 13 Apr 2020 13:41:13 +0000 (15:41 +0200)]
[SHELL32] No french translation from "right click drag'n'drop"

CORE-16815

14 months ago[SHELL32] Fix missing french translation for "Command prompt here"
Eric Kohl [Mon, 13 Apr 2020 13:27:47 +0000 (15:27 +0200)]
[SHELL32] Fix missing french translation for "Command prompt here"

CORE-16855

14 months ago[DEVMGR] Do not add the 'Resources' page to the device properties if the device does...
Eric Kohl [Mon, 13 Apr 2020 10:33:58 +0000 (12:33 +0200)]
[DEVMGR] Do not add the 'Resources' page to the device properties if the device does not have any resources

14 months ago[IPCONFIG] Improvements to ipconfig
Eric Kohl [Mon, 13 Apr 2020 09:25:09 +0000 (11:25 +0200)]
[IPCONFIG] Improvements to ipconfig

- Simplify the cleanup-code in ShowInfo
- Print the 'Primary DNS suffix' and the 'DNS Suffix Search List'
- Move the /registerdns message into its own function

14 months ago[SHELL32] Follow-up No.3 of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 04:19:12 +0000 (13:19 +0900)]
[SHELL32] Follow-up No.3 of #2539

Improve a comment in CreateNotificationParamAndSend.
CORE-13950

14 months ago[SHELL32] Follow-up No.2 of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 04:06:15 +0000 (13:06 +0900)]
[SHELL32] Follow-up No.2 of #2539

Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950

14 months ago[SHELL32] Follow-up of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 01:41:26 +0000 (10:41 +0900)]
[SHELL32] Follow-up of #2539

Improve comment. CORE-13950

14 months ago[SHELL32] Shell notify rework for simplicity and readability (#2539)
Katayama Hirofumi MZ [Mon, 13 Apr 2020 01:36:24 +0000 (10:36 +0900)]
[SHELL32] Shell notify rework for simplicity and readability (#2539)

Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950

14 months ago[WINMM] Fix crashing winetest
Mark Jansen [Sun, 12 Apr 2020 23:41:02 +0000 (01:41 +0200)]
[WINMM] Fix crashing winetest
CORE-16795
CORE-16806

14 months ago[BOOTDATA] Add FsType into default unattend.inf template
Victor Perevertkin [Sun, 12 Apr 2020 14:23:17 +0000 (17:23 +0300)]
[BOOTDATA] Add FsType into default unattend.inf template

14 months ago[CONSRV] Introduce a set of macros CON_API / CON_API_NOCONSOLE for wrapping around...
Hermès Bélusca-Maïto [Sun, 12 Apr 2020 10:45:31 +0000 (12:45 +0200)]
[CONSRV] Introduce a set of macros CON_API / CON_API_NOCONSOLE for wrapping around the repetitive prologue/epilogue of every console CSR API entrypoint.

All the per-API message structure unpacking and console validation done
with ConSrvGetConsole() is now automatically generated using the macros,
so that the actual implementation of each API can be done independently
of how the console object is obtained.

This could also allow reusing these API implementations with a different
mechanism for obtaining the console without changing anything in them.

14 months ago[TRAVIS] Fix inconsistent git clone depth in CI
Saibamen [Sun, 12 Apr 2020 13:36:07 +0000 (15:36 +0200)]
[TRAVIS] Fix inconsistent git clone depth in CI

14 months ago[PSDK] fix typedef PLSA_AP_CALL_PACKAGE_PASSTHROUGH (ntsecpkg.h)
Andreas Maier [Sat, 11 Apr 2020 21:05:37 +0000 (23:05 +0200)]
[PSDK] fix typedef PLSA_AP_CALL_PACKAGE_PASSTHROUGH (ntsecpkg.h)

14 months ago[TIMEDATE] Pervent running multiple NTP updates at once
Eric Kohl [Sun, 12 Apr 2020 11:11:33 +0000 (13:11 +0200)]
[TIMEDATE] Pervent running multiple NTP updates at once

- Run the NTP uptate from a separate thread
- Do not accept another update until the current one has finished

CORE-16835

14 months ago[User32] Return Default Window Procedure for WM_DEVICECHANGE
James Tabor [Sat, 11 Apr 2020 22:58:38 +0000 (17:58 -0500)]
[User32] Return Default Window Procedure for WM_DEVICECHANGE

See CORE-16492.

14 months ago[User32] Implement Device Event Message handler
James Tabor [Sat, 11 Apr 2020 22:41:26 +0000 (17:41 -0500)]
[User32] Implement Device Event Message handler

Need a way to send WM_DEVICECHANGE from the Service manager application.
Next step is to process it in the Client/Server Run-time Subsystem.
See CORE-16492.

14 months ago[ACPI] Properly return a single alternative in Bus_PDO_QueryResourceRequirements... 2502/head
Thomas Faber [Sun, 5 Apr 2020 21:02:57 +0000 (23:02 +0200)]
[ACPI] Properly return a single alternative in Bus_PDO_QueryResourceRequirements. CORE-12892 CORE-14688

In ACPI resource descriptors, alternatives are marked with
StartDependent tags. Only the last set is terminated with EndDependent.
Therefore, since we only return the first alternative list for now,
ignore the first StartDependent tag and terminate enumeration at the second.

In the future we will need to build the full set of alternative lists here,
which will also make the unit test succeed fully.

This should fix random resource conflicts and make COM ports usable.

14 months ago[ACPI] Avoid unnecessary casts.
Thomas Faber [Sun, 5 Apr 2020 21:01:41 +0000 (23:01 +0200)]
[ACPI] Avoid unnecessary casts.

14 months ago[ACPI_APITEST] Add a unit test for Bus_PDO_QueryResourceRequirements. CORE-12892
Thomas Faber [Tue, 6 Aug 2019 17:54:40 +0000 (19:54 +0200)]
[ACPI_APITEST] Add a unit test for Bus_PDO_QueryResourceRequirements. CORE-12892

This will allow us to verify fixes made to function, which is quite broken.

14 months agoRemove the 'end_of_line' value. Addendum to 32db19f6 - PR #2528
Hermès BÉLUSCA - MAÏTO [Sat, 11 Apr 2020 15:56:23 +0000 (17:56 +0200)]
Remove the 'end_of_line' value. Addendum to 32db19f6 - PR #2528

According to https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#end_of_line
there is not yet any value to translate "use the native end-of-line" from the VCS.
So for the time being, let's follow the advice mentioned in the article:
> if you want to use native line endings between different operating systems it is better not to set this option and leave that task to the VCS.

14 months agoCreate .editorconfig (#2528)
Saibamen [Sat, 11 Apr 2020 15:40:36 +0000 (17:40 +0200)]
Create .editorconfig (#2528)

By Adam "Saibamen" Stachowicz.

14 months agoSimplify .gitignore (#2531)
Saibamen [Sat, 11 Apr 2020 15:40:16 +0000 (17:40 +0200)]
Simplify .gitignore (#2531)

By Adam "Saibamen" Stachowicz.

14 months ago[CONSRV] Finally fix CONSOLE vs. CONSRV_CONSOLE/WINSRV_CONSOLE stuff. CORE-9496
Hermès Bélusca-Maïto [Fri, 10 Apr 2020 18:37:28 +0000 (20:37 +0200)]
[CONSRV] Finally fix CONSOLE vs. CONSRV_CONSOLE/WINSRV_CONSOLE stuff. CORE-9496

What remains to be cleared up are the ugly casts.

14 months ago[WIN32SS] Get rid of "consrv_new".
Hermès Bélusca-Maïto [Fri, 10 Apr 2020 18:38:47 +0000 (20:38 +0200)]
[WIN32SS] Get rid of "consrv_new".

Any new features/architectural changes to the console will either be
done in separate branches, or incrementally in master within the
existing console module.

14 months agoUpdated release version on readme
Federico Pellegatta [Sat, 11 Apr 2020 10:11:14 +0000 (12:11 +0200)]
Updated release version on readme

14 months ago[ZIPFLDR] CORE-16838 Update de-DE translation
Joachim Henze [Sat, 11 Apr 2020 10:45:42 +0000 (12:45 +0200)]
[ZIPFLDR] CORE-16838 Update de-DE translation

14 months ago[SHELL32] Improve CChangeNotify::ShouldNotify more
Katayama Hirofumi MZ [Sat, 11 Apr 2020 02:55:06 +0000 (11:55 +0900)]
[SHELL32] Improve CChangeNotify::ShouldNotify more

Improved non-recursive cases.
CORE-13950

14 months ago[SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
Katayama Hirofumi MZ [Sat, 11 Apr 2020 00:27:45 +0000 (09:27 +0900)]
[SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify

CORE-13950

14 months ago[CMAKE][CONFIGURE] Enable runtime checks on MSVC by default. 2509/head
Victor Perevertkin [Thu, 9 Apr 2020 01:40:17 +0000 (04:40 +0300)]
[CMAKE][CONFIGURE] Enable runtime checks on MSVC by default.
Remove RTC switch from configure.cmd, now MSVC runtime checks are
supposed to be enabled/disabled via CMake define (-DRUNTIME_CHECKS=1)
Prepare for adding more dynamic analysis options

14 months ago[SHELL32] Make "Unable to get notification window" quiet
Katayama Hirofumi MZ [Fri, 10 Apr 2020 23:45:23 +0000 (08:45 +0900)]
[SHELL32] Make "Unable to get notification window" quiet

CORE-13950

14 months ago[DEVMGR] Remove ATLASSERTs from ListDevicesByType and RecurseChildDevices
Eric Kohl [Fri, 10 Apr 2020 18:58:02 +0000 (20:58 +0200)]
[DEVMGR] Remove ATLASSERTs from ListDevicesByType and RecurseChildDevices

Suggested by Mark Jansen. Thanks!

14 months ago[NETSHELL] Disable the 'Delete' menu item for physical network interfaces
Eric Kohl [Fri, 10 Apr 2020 17:34:38 +0000 (19:34 +0200)]
[NETSHELL] Disable the 'Delete' menu item for physical network interfaces

CORE-16821

14 months ago[ZIPFLDR] CORE-16823 fr-FR Translate 'Click next to extract'
Joachim Henze [Fri, 10 Apr 2020 16:59:15 +0000 (18:59 +0200)]
[ZIPFLDR] CORE-16823 fr-FR Translate 'Click next to extract'

14 months ago[STOBJECT] CORE-16598 fr-FR translation of 'Adjust Power Settings'
Joachim Henze [Fri, 10 Apr 2020 16:32:04 +0000 (18:32 +0200)]
[STOBJECT] CORE-16598 fr-FR translation of 'Adjust Power Settings'

14 months ago[BROWSEUI] Add 'm_' prefix to CExplorerBand members (#2524)
Katayama Hirofumi MZ [Fri, 10 Apr 2020 14:08:31 +0000 (23:08 +0900)]
[BROWSEUI] Add 'm_' prefix to CExplorerBand members (#2524)

Add 'm_' prefix to the variable members of class CExplorerBand for readability.
CORE-13950

14 months ago[SHELL32] Simplify CChangeNotify::ShouldNotify
Katayama Hirofumi MZ [Fri, 10 Apr 2020 12:57:58 +0000 (21:57 +0900)]
[SHELL32] Simplify CChangeNotify::ShouldNotify

CORE-13950

14 months ago[SHELL32] Improve CChangeNotify::ShouldNotify
Katayama Hirofumi MZ [Fri, 10 Apr 2020 12:51:22 +0000 (21:51 +0900)]
[SHELL32] Improve CChangeNotify::ShouldNotify

Shell change notification was not sent to My Documents.
CORE-13950

14 months ago[USBSTOR] Add missing compatible device id 5
Eric Kohl [Fri, 10 Apr 2020 11:40:10 +0000 (13:40 +0200)]
[USBSTOR] Add missing compatible device id 5

14 months ago[IPHLPAPI] Do not use free() on buffer allocated with HeapAlloc
Jérôme Gardou [Fri, 10 Apr 2020 09:23:58 +0000 (11:23 +0200)]
[IPHLPAPI] Do not use free() on buffer allocated with HeapAlloc

14 months ago[SHELLEXT][ZIPFLDR] SendTo Zip compressed folder needs notification
Katayama Hirofumi MZ [Fri, 10 Apr 2020 09:16:31 +0000 (18:16 +0900)]
[SHELLEXT][ZIPFLDR] SendTo Zip compressed folder needs notification

CORE-16818

14 months ago[W32TIME][BOOTDATA] Export SvchostEntry_W32Time() as an alias to W32TmServiceMain...
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 21:20:54 +0000 (23:20 +0200)]
[W32TIME][BOOTDATA] Export SvchostEntry_W32Time() as an alias to W32TmServiceMain, and use the former as the service entry point specified in the registry, for Windows compatibility.

14 months ago[NTOS] Add a #define __ROS_ROSSYM__ when using rossym
Hervé Poussineau [Thu, 9 Apr 2020 17:47:01 +0000 (19:47 +0200)]
[NTOS] Add a #define __ROS_ROSSYM__ when using rossym

Use it where needed.

14 months ago[TRANSLATION] Hungarian translation update (#2519)
Tibor Lajos Füzi [Thu, 9 Apr 2020 19:49:34 +0000 (21:49 +0200)]
[TRANSLATION] Hungarian translation update (#2519)

Hungarian translation update for solitaire, spider solitaire, winemine, task manager.

14 months ago[LIB:ARBITER] Addendum to 374f2b4d: Fix build.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 18:37:01 +0000 (20:37 +0200)]
[LIB:ARBITER] Addendum to 374f2b4d: Fix build.

- No need to use a PCH when compiling a 1-file library.
- Add the _NTSYSTEM_ definition.

- Since the arbiter.h file is to be included by the users of this
  library, namely only kernel-mode NT components (incl. NTOS), there
  is no need to include the standard kernel-mode headers in it.
  Include these headers instead in the private implementation of the
  library, arbiter.c.

14 months ago[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)
Serge Gautherie [Thu, 9 Apr 2020 17:42:00 +0000 (19:42 +0200)]
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)

Import
https://source.winehq.org/git/wine.git/commit/83acbb79c1a059cbfec58fbb05619e7a6f703f2d

Related to CORE-13950

14 months ago[HALX86][PCIX] Statically link HALx86 and PCIX to the arbiter library. (#2471) 2471/head
Vadim Galyant [Thu, 9 Apr 2020 17:19:00 +0000 (19:19 +0200)]
[HALX86][PCIX] Statically link HALx86 and PCIX to the arbiter library. (#2471)

14 months ago[NTOS][SDK:LIB] Add a Resources Arbiter library, to be used by bus drivers (acpi...
Vadim Galyant [Thu, 26 Mar 2020 14:45:59 +0000 (18:45 +0400)]
[NTOS][SDK:LIB] Add a Resources Arbiter library, to be used by bus drivers (acpi, pci), kernel and legacy hal (PIC HAL). (#2471)

14 months ago[MSGINA] Redraw only the animation bar scroll (#2518)
Bișoc George [Thu, 9 Apr 2020 17:06:00 +0000 (19:06 +0200)]
[MSGINA] Redraw only the animation bar scroll (#2518)

Invalidating and updating the whole window is a waste of computation resources and may cause certain controls notably the text string control to flicker. So instead, just invalidate the specific portion of the client area which is the animation bar.

14 months ago[MSGINA] gui: Remove superfluous DLG_DATA.TimerID (#2505)
Serge Gautherie [Thu, 9 Apr 2020 16:54:15 +0000 (18:54 +0200)]
[MSGINA] gui: Remove superfluous DLG_DATA.TimerID (#2505)

And use a timer ID define, with a positive value; report SetTimer() failure.

14 months ago[TRANSLATION] Add and update Indonesian translations (#2506)
Mas Ahmad Muhammad [Thu, 9 Apr 2020 16:49:45 +0000 (23:49 +0700)]
[TRANSLATION] Add and update Indonesian translations (#2506)

- CMDUTILS: attrib, label (update translation)
- USETUP (add translation)
- HOTPLUG (add translation)
- CONSRV  (update translation)
- USERSRV (update translation)
- USER32  (update translation)
- ACLUI  (update translation)
- LICCPA  (update translation)
- SUBST  (update translation)
- REGSVR32  (update translation)
- REGEDIT-CLB  (update translation)
- ACPPAGE  (update translation)
- TIMEDATE  (update translation)
- SOLITAIRE  (update translation)
- FDEBUG  (update translation)
- SYSSETUP (update translation)

14 months ago[SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file)
Joachim Henze [Thu, 9 Apr 2020 16:16:24 +0000 (18:16 +0200)]
[SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file)

14 months ago[TRANSLATION] Multiple minor fixes and addings. (#2516)
Julen Urizar Compains [Thu, 9 Apr 2020 16:13:46 +0000 (18:13 +0200)]
[TRANSLATION] Multiple minor fixes and addings. (#2516)

- Applications: eventvwr, fltmgr, servman.
- rosapps: arping, CTM, fontsub, fraginator, imagesoft, systeminfo, vcdcontroltool, vgafontedit.
- CPLs: desk.cpl.
- ReactOS Setup GUI app.
- Screensavers: butterflies, maze, Starfield.
- System: NTVDM, printing/monitors/localmon; the freeze dialog in user32, the error strings in usersrv.

14 months ago[SHELL32_APITEST] Add SHAppBarMessage testcase (#2517)
Katayama Hirofumi MZ [Thu, 9 Apr 2020 15:57:08 +0000 (00:57 +0900)]
[SHELL32_APITEST] Add SHAppBarMessage testcase (#2517)

Add a testcase for shell32!SHAppBarMessage function. CORE-7237

14 months ago[BOOTVID] Addendum to 5f2ca473: Forgot to include the precompiled header.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 15:45:40 +0000 (17:45 +0200)]
[BOOTVID] Addendum to 5f2ca473: Forgot to include the precompiled header.

14 months ago[FREELDR] Add parsing boot options from .ini files. (#2511) 2511/head
Vadim Galyant [Wed, 8 Apr 2020 16:20:03 +0000 (20:20 +0400)]
[FREELDR] Add parsing boot options from .ini files. (#2511)

Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
14 months ago[APISETS] Forward _seh_filter_{dll,exe} (#2513)
William Kent [Thu, 9 Apr 2020 14:13:33 +0000 (10:13 -0400)]
[APISETS] Forward _seh_filter_{dll,exe} (#2513)

Since these functions are forwarded to a different function name, update.py misses them.

The choice of target comes from Wine:
https://github.com/wine-mirror/wine/blob/a98ca88dd1139ad8e16e63fbb349c2fc5e9ad332/dlls/ucrtbase/ucrtbase.spec#L1877-L1878

14 months ago[DRWTSN32] Recognize EXCEPTION_WINE_STUB (#2514)
William Kent [Thu, 9 Apr 2020 14:11:31 +0000 (10:11 -0400)]
[DRWTSN32] Recognize EXCEPTION_WINE_STUB (#2514)

DrWtsn32.exe recognizes several standard exception codes, and prints their names in the crash log. However, EXCEPTION_WINE_STUB is not in this list, and as such it is treated as an unknown error and printed as "--". Having this error code given a name at the start of the crash dump is useful, as it allows me to identify calls to unimplemented issues more readily.

14 months ago[SDK:SUBSYS] conmsg.h: Some DWORDs -> ULONGs.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 12:24:52 +0000 (14:24 +0200)]
[SDK:SUBSYS] conmsg.h: Some DWORDs -> ULONGs.

14 months ago[FLTMGR][NDK] Fix typos.
Hermès Bélusca-Maïto [Thu, 9 Apr 2020 12:23:27 +0000 (14:23 +0200)]
[FLTMGR][NDK] Fix typos.

14 months ago[BOOTVID] Code refactoring. (#2510) 2510/head
Dmitry Borisov [Wed, 8 Apr 2020 05:42:05 +0000 (11:42 +0600)]
[BOOTVID] Code refactoring. (#2510)

- Abstract the VGA and LCD code.
- Create a common file for all platforms.

14 months ago[BOOTVID] Move the VGA code into the PC directory. (#2510)
Dmitry Borisov [Wed, 8 Apr 2020 05:25:11 +0000 (11:25 +0600)]
[BOOTVID] Move the VGA code into the PC directory. (#2510)

14 months ago[BOOTVID][NTOSKRNL][HALX86] Move hardcoded coordinates of bootvid into one place... 2504/head
Dmitry Borisov [Mon, 6 Apr 2020 21:48:01 +0000 (03:48 +0600)]
[BOOTVID][NTOSKRNL][HALX86] Move hardcoded coordinates of bootvid into one place. (#2504)

Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
14 months ago[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)
Katayama Hirofumi MZ [Thu, 9 Apr 2020 07:56:54 +0000 (16:56 +0900)]
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)

- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391

14 months ago[CMAKE] Add --gc-sections flag to GCC linker.
Victor Perevertkin [Thu, 9 Apr 2020 01:02:06 +0000 (04:02 +0300)]
[CMAKE] Add --gc-sections flag to GCC linker.
This returns C++ binaries size to normal (on GCC 8.4).
I don't see any noticable effect of this on GCC 4.7.2

CORE-16670

14 months ago[ROSAUTOTEST] Revert 9ff3adb. This fixes MSVC build.
Victor Perevertkin [Thu, 9 Apr 2020 00:04:44 +0000 (03:04 +0300)]
[ROSAUTOTEST] Revert 9ff3adb. This fixes MSVC build.

This reverts commit 9ff3adb7d7c6636a1d040d8e53f7203e9d1815a3.

14 months ago[SHELL32] Follow-up of #2432
Katayama Hirofumi MZ [Wed, 8 Apr 2020 23:19:47 +0000 (08:19 +0900)]
[SHELL32] Follow-up of #2432

Fixed hang of FireFox.

14 months ago[ROSAUTOTEST] Change custom auto_array_ptr to std::unique_ptr
Victor Perevertkin [Wed, 8 Apr 2020 23:08:10 +0000 (02:08 +0300)]
[ROSAUTOTEST] Change custom auto_array_ptr to std::unique_ptr

14 months ago[SHELL32] Implement shell change notification (#2432)
Katayama Hirofumi MZ [Wed, 8 Apr 2020 22:30:14 +0000 (07:30 +0900)]
[SHELL32] Implement shell change notification (#2432)

- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950

14 months ago[User32] Fix Dialog Hang
James Tabor [Wed, 8 Apr 2020 19:49:38 +0000 (14:49 -0500)]
[User32] Fix Dialog Hang

Patch by JIRA contributor I_Kill_Bugs. See CORE-5078.

Also: https://bugs.winehq.org/show_bug.cgi?id=48749

14 months ago[SHIMLIB] Fix gcc8 build crashing when using shims 2507/head
Mark Jansen [Tue, 7 Apr 2020 18:47:47 +0000 (20:47 +0200)]
[SHIMLIB] Fix gcc8 build crashing when using shims

14 months ago[TCPIP] Remove duplicate declarations from ticonsts.h
Victor Perevertkin [Sat, 21 Dec 2019 01:02:47 +0000 (04:02 +0300)]
[TCPIP] Remove duplicate declarations from ticonsts.h

14 months ago[SDK][IP] Pass IP options to ReceiveDatagramHandler
Victor Perevertkin [Fri, 20 Dec 2019 20:19:41 +0000 (23:19 +0300)]
[SDK][IP] Pass IP options to ReceiveDatagramHandler

14 months ago[TCPIP] Implement IOCTL_ICMP_ECHO_REQUEST in tcpip.sys
Victor Perevertkin [Mon, 18 Nov 2019 17:55:10 +0000 (20:55 +0300)]
[TCPIP] Implement IOCTL_ICMP_ECHO_REQUEST in tcpip.sys
Also clean up ICMP handling code in sdk/lib/drivers/ip
CORE-10760

14 months ago[IPHLPAPI] Make icmp functions use IOCTL_ICMP_ECHO_REQUEST from tcpip.sys
Victor Perevertkin [Mon, 18 Nov 2019 17:54:03 +0000 (20:54 +0300)]
[IPHLPAPI] Make icmp functions use IOCTL_ICMP_ECHO_REQUEST from tcpip.sys
This adds missing features like using events and APCs within IcmpSendEcho2
functions and others.
CORE-10742 CORE-14411

Co-authored-by: Tim Crawford <crawfxrd@gmail.com>
14 months ago[SDK][IP] Fix formatting
Victor Perevertkin [Fri, 22 Nov 2019 19:04:56 +0000 (22:04 +0300)]
[SDK][IP] Fix formatting

14 months ago[TCPIP][FORMATTING] Format TiDispatch function. No functional changes
Victor Perevertkin [Sat, 16 Nov 2019 23:29:55 +0000 (02:29 +0300)]
[TCPIP][FORMATTING] Format TiDispatch function. No functional changes

14 months ago[USETUP] de-DE Whitespace nitpicking CORE-16792
Joachim Henze [Mon, 6 Apr 2020 19:28:45 +0000 (21:28 +0200)]
[USETUP] de-DE Whitespace nitpicking CORE-16792

To harmonize it to 3 separator-spaces how it is done
historically in other dlgs.

14 months ago[USETUP] de-DE Fix typo CORE-16792
Joachim Henze [Mon, 6 Apr 2020 18:55:18 +0000 (20:55 +0200)]
[USETUP] de-DE Fix typo CORE-16792

Fix typo in my last changeset
0.4.14-dev-1323-g
d079342e0a0684b4fb6530ee7ea4728f2a0ae985

14 months ago[USETUP] de-DE Overhaul german translation CORE-16792
Joachim Henze [Mon, 6 Apr 2020 18:49:44 +0000 (20:49 +0200)]
[USETUP] de-DE Overhaul german translation CORE-16792

14 months ago[USETUP] de-DE Split a line of text into two parts CORE-16791
Joachim Henze [Mon, 6 Apr 2020 15:11:45 +0000 (17:11 +0200)]
[USETUP] de-DE Split a line of text into two parts CORE-16791

14 months ago[TRANSLATION] Updating Spanish translation (#2503)
Julen Urizar Compains [Mon, 6 Apr 2020 11:17:20 +0000 (13:17 +0200)]
[TRANSLATION] Updating Spanish translation (#2503)

Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.

- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".

14 months ago[NTOS:MM] Since the _MMPTE_SUBSECTION structure for x86 (without PAE) uses the Subsec... 2425/head
Vadim Galyant [Fri, 24 Jan 2020 00:29:40 +0000 (09:29 +0900)]
[NTOS:MM] Since the _MMPTE_SUBSECTION structure for x86 (without PAE) uses the SubsectionAddressLow truncated by the least significant three bits, the _CONTROL_AREA, _LARGE_CONTROL_AREA, _SUBSECTION, _MSUBSECTION structures must be 8-byte aligned.
Corresponding checks in MmArmInitSystem() have been removed.

14 months ago[NTOS:MM] In MmArmInitSystem, perform self-tests after per-arch initialization.
Thomas Faber [Sun, 8 Mar 2020 19:05:02 +0000 (20:05 +0100)]
[NTOS:MM] In MmArmInitSystem, perform self-tests after per-arch initialization.

Mm(Non)PagedPoolStart won't be initialized otherwise, making the tests
pretty pointless.

14 months ago[NTOS:MM] Initialize MmSubsectionBase on x86 builds. CORE-16731
Thomas Faber [Sun, 8 Mar 2020 19:03:33 +0000 (20:03 +0100)]
[NTOS:MM] Initialize MmSubsectionBase on x86 builds. CORE-16731

Spotted by Vadim Galyant.

14 months ago[NTOS:MM] Get rid of unnecessary MmZeroingPageThreadActive. 2372/head
Thomas Faber [Sat, 22 Feb 2020 11:31:54 +0000 (12:31 +0100)]
[NTOS:MM] Get rid of unnecessary MmZeroingPageThreadActive.

14 months ago[NTOS:MM] Fix MmZeroingPageThreadActive race condition.
Thomas Faber [Sun, 16 Feb 2020 19:23:07 +0000 (20:23 +0100)]
[NTOS:MM] Fix MmZeroingPageThreadActive race condition.

If a thread calls MiInsertPageInFreeList after the zero page thread has
woken up from its wait but before it acquired the PFN lock,
MmZeroingPageEvent might get set again even though there is no additional
work to be done.
By setting MmZeroingPageThreadActive together with the event, the variable
correctly indicates for future callers that the zero thread will process
newly added free pages.

This partially reverts r72990.

14 months ago[NTOS:PO] Call power IRP handlers at PASSIVE_LEVEL when needed. CORE-11648 CORE-16704 2376/head
Thomas Faber [Sun, 23 Feb 2020 15:18:18 +0000 (16:18 +0100)]
[NTOS:PO] Call power IRP handlers at PASSIVE_LEVEL when needed. CORE-11648 CORE-16704

This means we now correctly handle the DO_POWER_PAGABLE flag.
In particular, Windows's usbhub.sys calls KeDelayExecutionThread from a
power IRP dispatch routine. We now handle this correctly.

14 months ago[Win32SS] Fix Mask for Draw Frame States
James Tabor [Mon, 6 Apr 2020 02:11:44 +0000 (21:11 -0500)]
[Win32SS] Fix Mask for Draw Frame States

Fixes drawing of caption bar buttons.

See CORE-8808.