reactos.git
11 months ago[TRANSLATION] Updated Polish translation in USETUP (#848)
Paweł Cholewa [Sun, 9 Sep 2018 20:28:02 +0000 (22:28 +0200)]
[TRANSLATION] Updated Polish translation in USETUP (#848)

11 months ago[USETUP] Italian translation update
Bișoc George [Sun, 9 Sep 2018 17:37:10 +0000 (19:37 +0200)]
[USETUP] Italian translation update

11 months ago[USETUP] Romanian translation update
Bișoc George [Sun, 9 Sep 2018 17:36:24 +0000 (19:36 +0200)]
[USETUP] Romanian translation update

11 months ago[BIDITEXT] Add more demo code. (#842) 842/head
Baruch Rutman [Fri, 7 Sep 2018 07:59:59 +0000 (10:59 +0300)]
[BIDITEXT] Add more demo code. (#842)

Add code that demonstrates the use of the lpOrder and lpCaretPos struct members of GCP_RESULTS w/ and  w/o GCP_REORDER flag.
Changed demo string literals to arrays containing character unicode values.

11 months ago[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842)
Baruch Rutman [Fri, 7 Sep 2018 07:45:35 +0000 (10:45 +0300)]
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842)

- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
  if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.

11 months ago[WIN32SS][COMCTL32] Fix button text Y positioning (#766)
Katayama Hirofumi MZ [Sun, 9 Sep 2018 15:37:37 +0000 (00:37 +0900)]
[WIN32SS][COMCTL32] Fix button text Y positioning (#766)

Fixes the vertical position of button text.
CORE-14906

11 months ago[NETAPI32] Implement NetGroupAddUser and NetGroupDelUser
Eric Kohl [Sun, 9 Sep 2018 15:33:03 +0000 (17:33 +0200)]
[NETAPI32] Implement NetGroupAddUser and NetGroupDelUser

11 months ago[SETUP][REACTOS] Added Vietnamese translation. (#716)
Nguyễn Thanh Sơn [Sun, 9 Sep 2018 15:34:21 +0000 (22:34 +0700)]
[SETUP][REACTOS] Added Vietnamese translation. (#716)

11 months ago[USETUP] Update French translation.
Hermès Bélusca-Maïto [Sun, 9 Sep 2018 15:24:38 +0000 (17:24 +0200)]
[USETUP] Update French translation.

11 months ago[USETUP] Implement the shutdown timeout progress bar. (#833) 833/head
Bișoc George [Wed, 22 Aug 2018 09:10:18 +0000 (11:10 +0200)]
[USETUP] Implement the shutdown timeout progress bar. (#833)

- Add the MUI ID resource.
- Implement the shutdown timeout progress bar function and the TimeOut string handler.
- Add the resource string to other resource languages.

11 months ago[NTOSKRNL] Move data mapping implementation to an internel helper
Pierre Schweitzer [Sun, 9 Sep 2018 09:14:42 +0000 (11:14 +0200)]
[NTOSKRNL] Move data mapping implementation to an internel helper

11 months ago[NETAPI32] Implement NetGroupSetInfo
Eric Kohl [Sun, 9 Sep 2018 11:39:01 +0000 (13:39 +0200)]
[NETAPI32] Implement NetGroupSetInfo

11 months ago[NETAPI32] Implement NetGroupAdd and NetGroupDel
Eric Kohl [Sun, 9 Sep 2018 09:52:08 +0000 (11:52 +0200)]
[NETAPI32] Implement NetGroupAdd and NetGroupDel

11 months ago[USBHUB_NEW][USBPORT] Fix buffer size calculation for multi-sz values in IRP_MN_QUERY_ID.
Vadim Galyant [Sat, 8 Sep 2018 18:52:06 +0000 (20:52 +0200)]
[USBHUB_NEW][USBPORT] Fix buffer size calculation for multi-sz values in IRP_MN_QUERY_ID.

Also fix some copypasta'd DPRINTs.

11 months ago[NETAPI] Implement NetGroupGetInfo
Eric Kohl [Sun, 9 Sep 2018 07:40:11 +0000 (09:40 +0200)]
[NETAPI] Implement NetGroupGetInfo

11 months ago[PSDK] Add missing struct _GROUP_INFO_3 to lmaccess.h
Eric Kohl [Sat, 8 Sep 2018 20:21:15 +0000 (22:21 +0200)]
[PSDK] Add missing struct _GROUP_INFO_3 to lmaccess.h

11 months ago[NETAPI] Implement NetGroupEnum
Eric Kohl [Sat, 8 Sep 2018 18:55:13 +0000 (20:55 +0200)]
[NETAPI] Implement NetGroupEnum

11 months ago[SAMSRV] Fix SamrQueryInformationGroup
Eric Kohl [Sat, 8 Sep 2018 17:23:00 +0000 (19:23 +0200)]
[SAMSRV] Fix SamrQueryInformationGroup

- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.

11 months ago[KMTESTS:CC] Fix two failing tests on WHS bot
Pierre Schweitzer [Sat, 8 Sep 2018 13:19:45 +0000 (15:19 +0200)]
[KMTESTS:CC] Fix two failing tests on WHS bot

11 months ago[NET] Implement the group command
Eric Kohl [Sat, 8 Sep 2018 12:14:13 +0000 (14:14 +0200)]
[NET] Implement the group command

11 months ago[SDK] Make gen_baseaddress.py compatible with Python 3.
Thomas Faber [Sat, 8 Sep 2018 09:10:51 +0000 (11:10 +0200)]
[SDK] Make gen_baseaddress.py compatible with Python 3.

11 months ago[USBUHCI_NEW] Add license headers.
Thomas Faber [Sat, 8 Sep 2018 08:13:43 +0000 (10:13 +0200)]
[USBUHCI_NEW] Add license headers.

11 months ago[USBOHCI_NEW] Add license headers.
Thomas Faber [Sat, 8 Sep 2018 08:12:39 +0000 (10:12 +0200)]
[USBOHCI_NEW] Add license headers.

11 months ago[DDK] Add NT6+ implementation for Rx*PrefixTableLock macros
Pierre Schweitzer [Sat, 8 Sep 2018 08:05:41 +0000 (10:05 +0200)]
[DDK] Add NT6+ implementation for Rx*PrefixTableLock macros

11 months ago[USBOHCI_NEW][USBUHCI_NEW] Avoid unnecessary/incorrect status defines.
Thomas Faber [Sun, 2 Sep 2018 17:39:46 +0000 (19:39 +0200)]
[USBOHCI_NEW][USBUHCI_NEW] Avoid unnecessary/incorrect status defines.

11 months ago[KMTESTS:FLTMGR] Hide FltMgrLoad and FltMgrReg
Serge Gautherie [Sat, 1 Sep 2018 15:50:23 +0000 (17:50 +0200)]
[KMTESTS:FLTMGR] Hide FltMgrLoad and FltMgrReg

And add "// TODO: WIP/untested/crashes."

ROSTESTS-299

11 months ago[CPL][DESK] Update monitor resource (#816)
Abdulganiev Rafael [Fri, 7 Sep 2018 07:43:36 +0000 (11:43 +0400)]
[CPL][DESK] Update monitor resource (#816)

[DESK.CPL] Update monitor resource

11 months ago[LIBTIRPC] Fix CVE-2018-14622 by backporting its fix
Pierre Schweitzer [Wed, 5 Sep 2018 19:44:47 +0000 (21:44 +0200)]
[LIBTIRPC] Fix CVE-2018-14622 by backporting its fix

CORE-15005

11 months ago[NTOSKRNL] Don't raise a status when parameters are invalid on file mapping
Pierre Schweitzer [Mon, 3 Sep 2018 06:12:58 +0000 (08:12 +0200)]
[NTOSKRNL] Don't raise a status when parameters are invalid on file mapping

11 months ago[NTOSKRNL] When allocating a new BCB, save it in a list
Pierre Schweitzer [Sun, 2 Sep 2018 12:37:47 +0000 (14:37 +0200)]
[NTOSKRNL] When allocating a new BCB, save it in a list

This list is stored in the shared map. Later, this will allow
reusing BCB when appropriate

11 months ago[SDK] Generate msvc baseaddresses from an RTC build
Mark Jansen [Wed, 5 Sep 2018 19:38:26 +0000 (21:38 +0200)]
[SDK] Generate msvc baseaddresses from an RTC build

11 months ago[CMLIB] Fix compiling as NT6+ (#840)
Serge Gautherie [Wed, 5 Sep 2018 18:18:14 +0000 (20:18 +0200)]
[CMLIB] Fix compiling as NT6+ (#840)

Addendum to r70582 (734bc291).
CORE-12596

11 months ago[MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count
Eric Kohl [Tue, 4 Sep 2018 22:10:54 +0000 (00:10 +0200)]
[MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count

11 months ago[MSV1_0] Use the account expiration time and check account expiration on logon
Eric Kohl [Tue, 4 Sep 2018 21:15:15 +0000 (23:15 +0200)]
[MSV1_0] Use the account expiration time and check account expiration on logon

11 months ago[IDL] Implement parts of SamrSetInformationUser.UserInternal2Information
Eric Kohl [Tue, 4 Sep 2018 20:42:07 +0000 (22:42 +0200)]
[IDL] Implement parts of SamrSetInformationUser.UserInternal2Information

11 months ago[IDL] Add some Flags SamrSetInformationUser.UserInternal2Information
Eric Kohl [Tue, 4 Sep 2018 20:41:04 +0000 (22:41 +0200)]
[IDL] Add some Flags SamrSetInformationUser.UserInternal2Information

11 months ago[FONTEXT] Add Italian translation (#831)
Bișoc George [Tue, 4 Sep 2018 20:02:44 +0000 (22:02 +0200)]
[FONTEXT] Add Italian translation (#831)

11 months ago[ACCESS] Fix some truncated strings in French resource (#838)
Bișoc George [Mon, 3 Sep 2018 12:14:57 +0000 (14:14 +0200)]
[ACCESS] Fix some truncated strings in French resource (#838)

11 months ago[SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information
Eric Kohl [Sun, 2 Sep 2018 15:53:29 +0000 (17:53 +0200)]
[SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information

11 months ago[MSGINA] Update russian translation (#834)
Stanislav Motylkov [Sun, 2 Sep 2018 13:59:33 +0000 (16:59 +0300)]
[MSGINA] Update russian translation (#834)

Addendum to 6f4d70b.

11 months ago[IDL] Add the undocumented struct _SAMPR_USER_INTERNAL2_INFORMATION to sam.idl
Eric Kohl [Sun, 2 Sep 2018 09:58:30 +0000 (11:58 +0200)]
[IDL] Add the  undocumented struct _SAMPR_USER_INTERNAL2_INFORMATION to sam.idl

11 months ago[KMTESTS:CC] Add tests showing our CcMapData/CcPinRead raise invalid status
Pierre Schweitzer [Sun, 2 Sep 2018 09:48:16 +0000 (11:48 +0200)]
[KMTESTS:CC] Add tests showing our CcMapData/CcPinRead raise invalid status

11 months ago[WIN32K:NTUSER] co_UserDestroyWindow(): Simplify the destruction of the owned windows.
Hermès Bélusca-Maïto [Sat, 1 Sep 2018 21:45:11 +0000 (23:45 +0200)]
[WIN32K:NTUSER] co_UserDestroyWindow(): Simplify the destruction of the owned windows.

11 months ago[WIN32K:NTUSER] Optimize IntWinListOwnedPopups() a little bit. Improve a trace.
Hermès Bélusca-Maïto [Sat, 1 Sep 2018 21:42:11 +0000 (23:42 +0200)]
[WIN32K:NTUSER] Optimize IntWinListOwnedPopups() a little bit. Improve a trace.

11 months ago[WIN32K:NTUSER] Code formatting only.
Hermès Bélusca-Maïto [Sat, 1 Sep 2018 21:39:38 +0000 (23:39 +0200)]
[WIN32K:NTUSER] Code formatting only.

11 months ago[KMTESTS:CC] Add tests for BCB extension
Pierre Schweitzer [Sat, 1 Sep 2018 19:52:39 +0000 (21:52 +0200)]
[KMTESTS:CC] Add tests for BCB extension

11 months ago[KMTESTS:CC] Add more tests crossing CcPinRead and CcMapData
Pierre Schweitzer [Sat, 1 Sep 2018 19:26:24 +0000 (21:26 +0200)]
[KMTESTS:CC] Add more tests crossing CcPinRead and CcMapData

11 months ago[MSGINA] Display the 'account expired' message when a user tries to log on using...
Eric Kohl [Sat, 1 Sep 2018 19:08:14 +0000 (21:08 +0200)]
[MSGINA] Display the 'account expired' message when a user tries to log on using an expired account.

11 months ago[USBOHCI_NEW] Avoid storing pointers as ULONG and physical addresses as pointers.
Thomas Faber [Sat, 1 Sep 2018 16:23:25 +0000 (18:23 +0200)]
[USBOHCI_NEW] Avoid storing pointers as ULONG and physical addresses as pointers.

11 months ago[USBHUB_NEW] Fix x64 warnings.
Thomas Faber [Sat, 1 Sep 2018 16:01:40 +0000 (18:01 +0200)]
[USBHUB_NEW] Fix x64 warnings.

11 months ago[USBUHCI_NEW] Bring-in the USB UHCI miniport driver created by Vadim Galyant. (#245)
Amine Khaldi [Sat, 1 Sep 2018 15:45:45 +0000 (16:45 +0100)]
[USBUHCI_NEW] Bring-in the USB UHCI miniport driver created by Vadim Galyant. (#245)

11 months ago[KERNEL32] fix spec file for -version=0x600+
Denis Malikov [Sat, 25 Aug 2018 15:26:18 +0000 (22:26 +0700)]
[KERNEL32] fix spec file for -version=0x600+

CORE-12596

11 months ago[GDI32_APITEST:GetTextFace] Replace tabs by spaces.
Hermès Bélusca-Maïto [Sat, 1 Sep 2018 15:18:03 +0000 (17:18 +0200)]
[GDI32_APITEST:GetTextFace] Replace tabs by spaces.

11 months ago[GDI32_APITEST] Add tests for GetTextFaceAliasW(), based on Katayama Hirofumi MZ...
Doug Lyons [Sat, 1 Sep 2018 15:13:50 +0000 (17:13 +0200)]
[GDI32_APITEST] Add tests for GetTextFaceAliasW(), based on Katayama Hirofumi MZ's tests from CORE-14926.

CORE-14995

11 months ago[KERNEL32] Shhhh!
Pierre Schweitzer [Sat, 1 Sep 2018 13:46:44 +0000 (15:46 +0200)]
[KERNEL32] Shhhh!

11 months ago[KMTESTS:CC] Add tests for PIN_EXCLUSIVE
Pierre Schweitzer [Sat, 1 Sep 2018 13:22:41 +0000 (15:22 +0200)]
[KMTESTS:CC] Add tests for PIN_EXCLUSIVE

11 months ago[KMTESTS:CC] Add a test for pinning without access
Pierre Schweitzer [Sat, 1 Sep 2018 10:40:24 +0000 (12:40 +0200)]
[KMTESTS:CC] Add a test for pinning without access

11 months ago[NTOSKRNL] Fail on pinning when there's no pin access set
Pierre Schweitzer [Sat, 1 Sep 2018 10:39:05 +0000 (12:39 +0200)]
[NTOSKRNL] Fail on pinning when there's no pin access set

Instead of assert, now, CcPinRead will just fail. This is
not consistent without Windows behavior, but still better
than asserting while testing!

11 months ago[KMTESTS:CC] Add tests for PIN_IF_BCB flag
Pierre Schweitzer [Sat, 1 Sep 2018 10:29:09 +0000 (12:29 +0200)]
[KMTESTS:CC] Add tests for PIN_IF_BCB flag

11 months ago[KMTESTS:CC] Duplicate tests for CcPinRead
Pierre Schweitzer [Sat, 1 Sep 2018 10:20:17 +0000 (12:20 +0200)]
[KMTESTS:CC] Duplicate tests for CcPinRead

To be extended.

11 months ago[KMTESTS:CC] Add missing FsRtlEnter/ExitFileSystem() calls
Pierre Schweitzer [Sat, 1 Sep 2018 10:18:51 +0000 (12:18 +0200)]
[KMTESTS:CC] Add missing FsRtlEnter/ExitFileSystem() calls

Spotted by Thomas

11 months ago[KMTESTS:CC] That wasn't meant to be committed
Pierre Schweitzer [Sat, 1 Sep 2018 08:10:09 +0000 (10:10 +0200)]
[KMTESTS:CC] That wasn't meant to be committed

11 months ago[COMCTL32_WINETEST] treeview.c: Skip test_right_click() 827/head
Serge Gautherie [Mon, 27 Aug 2018 17:12:56 +0000 (19:12 +0200)]
[COMCTL32_WINETEST] treeview.c: Skip test_right_click()

until CORE-14975 is fixed upstream and WINESYNC.

CORE-14975

11 months ago[KMTESTS:CC] Add a test to show we map our buffers wrong in CC
Pierre Schweitzer [Fri, 31 Aug 2018 21:29:59 +0000 (23:29 +0200)]
[KMTESTS:CC] Add a test to show we map our buffers wrong in CC

That is expected (cf. CORE-14259)

11 months ago[KMTESTS:CC] Remove dummy leftover
Pierre Schweitzer [Fri, 31 Aug 2018 21:08:25 +0000 (23:08 +0200)]
[KMTESTS:CC] Remove dummy leftover

11 months ago[KMTESTS:CC] Extended previous test to show an overlap is enough
Pierre Schweitzer [Fri, 31 Aug 2018 21:07:46 +0000 (23:07 +0200)]
[KMTESTS:CC] Extended previous test to show an overlap is enough

11 months ago[KMTESTS:CC] Add a test that shows that our CC implementation duplicates BCB
Pierre Schweitzer [Fri, 31 Aug 2018 21:01:06 +0000 (23:01 +0200)]
[KMTESTS:CC] Add a test that shows that our CC implementation duplicates BCB

It should instead reuse BCBs when mapping something already mapped.

11 months ago[NTOSKRNL] Fix a typo
Pierre Schweitzer [Fri, 31 Aug 2018 17:48:03 +0000 (19:48 +0200)]
[NTOSKRNL] Fix a typo

11 months ago[NTOSKRNL] Warn about unimplemented feature in CcMapData() (in all callers)
Pierre Schweitzer [Fri, 31 Aug 2018 17:43:04 +0000 (19:43 +0200)]
[NTOSKRNL] Warn about unimplemented feature in CcMapData() (in all callers)

Currently, our CcMapData() behavior (same goes for CcPinRead()) is broken
and is the total opposite of what Windows kernel does. By default, the later
will let you map a view in memory without even attempting to bring its
data in memory. On first access, there will be a fault and memory will
be read from the hardware and brought to memory. If you want to force read
on mapping/pinning, you have to set the MAP_NO_READ (or PIN_NO_READ) flag
where kernel will fault on your behalf (hence the need for MAP_WAIT/PIN_WAIT).

On ReactOS, by default, on mapping (and thus pinning), we will force a view
read so that data is in memory. The way our cache memory is managed at the
moment seems not to allow to fault on invalid access and if we don't force
read, the memory content will just be zeroed.
So trying to match Windows behavior, by default, now CcMapData() will enforce
the MAP_NO_READ flag and warn once about this behavior change.

11 months ago[KMTESTS] Re-enable kmtest_.exe installation (#389)
Serge Gautherie [Fri, 31 Aug 2018 06:46:48 +0000 (08:46 +0200)]
[KMTESTS] Re-enable kmtest_.exe installation (#389)

ExPools and other tests don't break Windows Server 2003 anymore.

Revert r73535, so KmTests run on "Test WHS" bot.

CORE-12657

11 months ago[MODULES] Order the cmake inclusions alphabetically as we're used to everywhere else.
Hermès Bélusca-Maïto [Thu, 30 Aug 2018 20:54:49 +0000 (22:54 +0200)]
[MODULES] Order the cmake inclusions alphabetically as we're used to everywhere else.

11 months ago[REACTOS] Introduce a "DEBUGFORMAT" environment variable that allows to select differ... 793/head
Hermès Bélusca-Maïto [Sun, 5 Nov 2017 20:15:08 +0000 (21:15 +0100)]
[REACTOS] Introduce a "DEBUGFORMAT" environment variable that allows to select different debug trace formats.
CORE-12671

- The default format is used when no format name is specified: this is
  the one we use so far in ReactOS:

    <debug_class>:(<file>:<line>) <message>

  with "debug_class" being "trace", "warn", "err".

- The "wine" format is the one used by Wine. It can be used when trying
  to diff-compare traces for a module with the corresponding one
  obtained from a Wine run. It can also be useful because the logging of
  Wine-synced code assumes that the function names are automatically
  added by the helper macros "FIXME()", "TRACE()", "WARN()" or "ERR()",
  and not manually inside the logging string given to these macros:
  for example:

    FIXME("(%params) message\n", params);

  displays:

    fixme:<module>:SomeFunc(params) message

- The "extended" (or "ext") format is very noisy and tries to output a
  lot of information; it is a hybrid of the previous two formats:

    <debug_class>:(<file>:<line>):<channel>:SomeFunc <message>

Support for displaying the current process ID is added in
addition to the already existing support for thread ID.

11 months ago[WIN32SS][FONT] Fix GetTextFace function and related (#829)
Katayama Hirofumi MZ [Thu, 30 Aug 2018 12:34:03 +0000 (21:34 +0900)]
[WIN32SS][FONT] Fix GetTextFace function and related (#829)

Google Chrome with -no-sandbox parameter in ReactOS wouldn't display the web page because first-chance exception raised.
CORE-14926

- Remove FullName, Style, and FaceName members from TEXTOBJ structure.
- Add TextFace member into TEXTOBJ structure.
- Add MatchFontName() and MatchFontNames() helper functions.
- Fix GetTextFace() and related.

11 months ago[FONT][SETUP] Add 'Tms Rmn' and 'Times' font substitutes (#830)
Katayama Hirofumi MZ [Thu, 30 Aug 2018 11:07:22 +0000 (20:07 +0900)]
[FONT][SETUP] Add 'Tms Rmn' and 'Times' font substitutes (#830)

Add "Tms Rmn" and "Times" font substitutes (same as "Times New Roman"). Windows has these substitutes, hence we also need those to remain compatible.

11 months ago[CMAKE] Update baseaddress files to match latest changes.
David Quintana [Thu, 30 Aug 2018 01:45:40 +0000 (03:45 +0200)]
[CMAKE] Update baseaddress files to match latest changes.

11 months ago[STORAHCI] Fix MSVC "uninitialized local variable" error (C4700) (#828)
Katayama Hirofumi MZ [Wed, 29 Aug 2018 22:50:06 +0000 (07:50 +0900)]
[STORAHCI] Fix MSVC "uninitialized local variable" error (C4700) (#828)

See also PR #821.

11 months ago[SDK] Duplicate English messages as Polish Messages (#826)
Katayama Hirofumi MZ [Wed, 29 Aug 2018 22:46:02 +0000 (07:46 +0900)]
[SDK] Duplicate English messages as Polish Messages (#826)

11 months ago[MC] Fix VS2017 build.
David Quintana [Wed, 29 Aug 2018 22:26:47 +0000 (00:26 +0200)]
[MC] Fix VS2017 build.

11 months ago[NET] Initialize a new users primary group ID in order to fix logon failures
Eric Kohl [Wed, 29 Aug 2018 20:03:53 +0000 (22:03 +0200)]
[NET] Initialize a new users primary group ID in order to fix logon failures

11 months ago[NET] Fix indentation
Eric Kohl [Sun, 26 Aug 2018 22:43:34 +0000 (00:43 +0200)]
[NET] Fix indentation

11 months ago[CDFS] Revert 9d0596a
Pierre Schweitzer [Wed, 29 Aug 2018 06:32:08 +0000 (08:32 +0200)]
[CDFS] Revert 9d0596a

The appropriate fix was the previous one, where the macro
for checking legal chars have been fixed.

Thanks to MS for their review :-).

CORE-14067

11 months ago[SDK] Fix the implementation of the FsRtlIsAnsiCharacter* macros.
Pierre Schweitzer [Wed, 29 Aug 2018 06:30:18 +0000 (08:30 +0200)]
[SDK] Fix the implementation of the FsRtlIsAnsiCharacter* macros.

These macros should be implemented using the FsRtlTestAnsiCharacter() macro
that performs extended tests, especially for buffer overruns.
This fixes FsRtlIsAnsiCharacterWild(), FsRtlIsAnsiCharacterLegalFat(),
FsRtlIsAnsiCharacterLegalHpfs(), FsRtlIsAnsiCharacterLegalNtfs().

CORE-14067

11 months ago[SHELL32] Fix typo in comment
Joachim Henze [Tue, 28 Aug 2018 12:24:49 +0000 (14:24 +0200)]
[SHELL32] Fix typo in comment

11 months ago[TCPSVCS] Remove hardcoded C drive letter (#800)
Katayama Hirofumi MZ [Tue, 28 Aug 2018 10:45:03 +0000 (19:45 +0900)]
[TCPSVCS] Remove hardcoded C drive letter (#800)

CORE-13228, CORE-13235

For USETUP, add a comment about why the code uses it when adding a boot-sector boot entry to NTLDR. CORE-13226

11 months ago[CDFS] Properly check for legal names in CdIsLegalName()
Pierre Schweitzer [Tue, 28 Aug 2018 05:48:44 +0000 (07:48 +0200)]
[CDFS] Properly check for legal names in CdIsLegalName()

Up to now, it was working by chance. Indeed, due to the invalid
ASCII check performed before calling FsRtlIsAnsiCharacterLegalHpfs(), the
macro is improperly called and overruns the FsRtlLegalAnsiCharacterArray
buffer. Fortunately, up to now, right after that buffer in kernel binary
there are strings which are more or less consistent with the flags that
are expected by the macro, causing a decent behavior of
FsRtlIsAnsiCharacterLegalHpfs() even for extended ASCII characters
(whereas FsRtlIsAnsiCharacterLegalHpfs() is only designed for ASCII
characters). But this is a totally out of control and wrong behavior.
A single change in the way the kernel was built could have caused the
CDFS driver not to work as previously.

I have made the choice to allow any extended ASCII character as done
for the unicode characters. This is a good compromise to avoid drastic
regressions for users having extended ASCII characters in their CD
file names.

This imports proposed upstream commit 1b6b625641dffb49951e60398e1a9c672318ea71
See pull request https://github.com/Microsoft/Windows-driver-samples/pull/278

CORE-14067

11 months ago[USETUP] Progress-bar: minor improvements.
Hermès Bélusca-Maïto [Mon, 27 Aug 2018 21:55:58 +0000 (23:55 +0200)]
[USETUP] Progress-bar: minor improvements.

- Simplify the usage of the PUPDATE_PROGRESS callback.

- Add the possibility of specifying an initial non-zero StepCount when
  creating the progress-bar (using the -Ex version), so that it can be
  initially drawn with the expected initial count.
  Of course ProgressSetStepCount() can continue to be used.

11 months ago[LDR] Load kernel32 in LdrpInitializeProcess. 805/head
Mark Jansen [Thu, 23 Aug 2018 22:15:02 +0000 (00:15 +0200)]
[LDR] Load kernel32 in LdrpInitializeProcess.
This allows kernel32 to register itself for manifest probing when loading dlls
CORE-9219

11 months ago[NTDLL_APITEST] Various small fixes
Mark Jansen [Thu, 23 Aug 2018 12:53:57 +0000 (14:53 +0200)]
[NTDLL_APITEST] Various small fixes
- Add a missing file
- Add convenience targets for MSVC_IDE
- Remove whitespace at the end of the lines

11 months ago[COMCTL32] Unregister some classes that were registered. 811/head
Mark Jansen [Fri, 24 Aug 2018 13:59:57 +0000 (15:59 +0200)]
[COMCTL32] Unregister some classes that were registered.
This should help fix some crashes.

11 months ago[MAGNIFY] Fix the magnification ratio bug for CORE-14946 (#823)
LuRenJia [Mon, 27 Aug 2018 12:36:28 +0000 (20:36 +0800)]
[MAGNIFY] Fix the magnification ratio bug for CORE-14946 (#823)

This bug was caused by leaving the magnify window unrefreshed when updating the "Magnification Level" ComboBox.
CORE-14946

11 months ago[SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog...
Katayama Hirofumi MZ [Mon, 27 Aug 2018 10:21:51 +0000 (19:21 +0900)]
[SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824)

CORE-14974

11 months ago[SHELL32] Check the result from PathUnExpandEnvStringsW 817/head
Mark Jansen [Sun, 26 Aug 2018 20:38:27 +0000 (22:38 +0200)]
[SHELL32] Check the result from PathUnExpandEnvStringsW

11 months ago[SHELL32] Remove some mostly dead code from CShellLink
Mark Jansen [Sun, 26 Aug 2018 20:37:49 +0000 (22:37 +0200)]
[SHELL32] Remove some mostly dead code from CShellLink

11 months ago[SDK][CRT] Fix _ismbblead undefined error on MSVC 818/head
Katayama Hirofumi MZ [Mon, 27 Aug 2018 01:12:55 +0000 (10:12 +0900)]
[SDK][CRT] Fix _ismbblead undefined error on MSVC

11 months ago[TIMEOUT] Fix a typo.
Hermès Bélusca-Maïto [Sun, 26 Aug 2018 22:25:48 +0000 (00:25 +0200)]
[TIMEOUT] Fix a typo.

11 months ago[USETUP] Implement a basic console 'input queue' and implement PeekConsoleInput(...
Hermès Bélusca-Maïto [Sun, 26 Aug 2018 22:22:07 +0000 (00:22 +0200)]
[USETUP] Implement a basic console 'input queue' and implement PeekConsoleInput() and CONSOLE_ConInKeyPeek() around it.

11 months ago[LSASRV] LsapLogonUser creates an impersonation token for a network logon
Eric Kohl [Sun, 26 Aug 2018 22:19:10 +0000 (00:19 +0200)]
[LSASRV] LsapLogonUser creates an impersonation token for a network logon

11 months ago[SAMSRV] Simplify the initialization of the account expiration time
Eric Kohl [Sun, 26 Aug 2018 22:12:44 +0000 (00:12 +0200)]
[SAMSRV] Simplify the initialization of the account expiration time

11 months ago[SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser
Eric Kohl [Sun, 26 Aug 2018 22:11:21 +0000 (00:11 +0200)]
[SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser

11 months ago[NTOSKRNL] Properly reset pinning state on pinning failure
Pierre Schweitzer [Sun, 26 Aug 2018 20:56:25 +0000 (22:56 +0200)]
[NTOSKRNL] Properly reset pinning state on pinning failure