Pierre Schweitzer [Mon, 19 Aug 2019 08:44:56 +0000 (10:44 +0200)]
[NTOSKRNL] Handle symlink parsing when it's bound to a specific object
Katayama Hirofumi MZ [Sun, 18 Aug 2019 13:46:56 +0000 (22:46 +0900)]
[NOTEPAD] Encoding detection (#1852)
CORE-15548
In notepad, if there is no BOM in the input file, then judge the text encoding.
Eric Kohl [Sun, 18 Aug 2019 12:54:12 +0000 (14:54 +0200)]
[MSV1_0] Add SpLsaModeInitialize and SpUserModeInitialize.
SpLsaModeInitialize and SpUserModeInitialize will provide access to SSPI functions. LSASRV will soon access the LsaAp functions via SpLsaModeInialize.
Hermès Bélusca-Maïto [Sun, 18 Aug 2019 13:23:23 +0000 (15:23 +0200)]
[FREELDR] Demote the ArcOpen() trace in WinLdrLoadImage() to a warning only.
Hermès Bélusca-Maïto [Fri, 16 Aug 2019 16:14:19 +0000 (18:14 +0200)]
[FFS] Silence some only-informative KdPrints.
Katayama Hirofumi MZ [Sun, 18 Aug 2019 09:53:37 +0000 (18:53 +0900)]
[COMCTL32_APITEST] Add propsheetv6 testcase (#1853)
The proof of #1842. Property sheet does unchange the page after WM_INITDIALOG. CORE-16280
Bișoc George [Wed, 13 Feb 2019 16:13:48 +0000 (17:13 +0100)]
[USETUP] Localize the rest of the hardcoded error message strings
Stanislav Motylkov [Sat, 17 Aug 2019 17:03:39 +0000 (20:03 +0300)]
[HAL] Xbox needs more PCI blacklisting!
CORE-16216
Serge Gautherie [Sat, 17 Aug 2019 16:20:51 +0000 (18:20 +0200)]
[CMAKE] KDBG and _WINKD_ do not need a value
Serge Gautherie [Fri, 4 May 2018 21:25:24 +0000 (23:25 +0200)]
[IPHLPAPI] icmp.c: Complete sync with Wine Staging 1.7.55
- Restore a missing brace.
- Mark all our differences (at that time). Please inspect them.
CORE-10536
Andrew Cook [Fri, 15 Feb 2019 01:33:13 +0000 (12:33 +1100)]
Search for host-tools path
Allows source-relative paths
Andrew Cook [Wed, 13 Feb 2019 10:06:49 +0000 (21:06 +1100)]
Add WITH_HOST_TOOLS option
Required for cross-compiling with msvc as only one target
architecture is available at a time in the dev prompt
Andrew Cook [Mon, 1 Oct 2018 11:07:44 +0000 (21:07 +1000)]
Rework host tools
Now configured at the same time as reactos and only
one list of targets to maintain
Correctly rebuilds when a tool changes (tested widl)
Serge Gautherie [Sat, 8 Jun 2019 02:16:20 +0000 (04:16 +0200)]
[NTOS:IO] iomgr.c: Add a missing '#if defined(KDBG)'
Victor Martinez [Sat, 17 Aug 2019 13:44:57 +0000 (16:44 +0300)]
[UDFS] Avoid freeing Vcb when it couldn't have been allocated in UDFPnpSurpriseRemove()
CORE-11203
Victor Martinez [Sat, 17 Aug 2019 13:39:55 +0000 (16:39 +0300)]
[UDFS] Fix NewCFBName leakage in UDFFirstOpenFile()
CORE-11098
Victor Martinez [Sat, 17 Aug 2019 13:30:21 +0000 (16:30 +0300)]
[UDFS] Fix accessing an already freed pointer in UDFMarkAllocatedAsNotXXX()
CORE-11182
Victor Martinez [Sat, 17 Aug 2019 12:52:19 +0000 (15:52 +0300)]
[UDFS] Don't access OldInIcb after being freed
CORE-11199
Bișoc George [Sun, 4 Aug 2019 09:21:28 +0000 (11:21 +0200)]
[DESK] Change the property "Screensaver" page on text change
If the user takes action on the edit box control of "Screensaver" dialog page, enable the "Apply" property button.
CORE-16280
Victor Martinez [Sat, 17 Aug 2019 12:43:24 +0000 (15:43 +0300)]
[UDFS] Fix uninitialized variable
CORE-11216
Katayama Hirofumi MZ [Sat, 17 Aug 2019 11:02:57 +0000 (20:02 +0900)]
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
Andreas Maier [Fri, 21 Jun 2019 09:58:07 +0000 (11:58 +0200)]
[COMCTL32] remove unused theme_*.c files.
Thomas Faber [Sat, 20 Jul 2019 20:20:33 +0000 (22:20 +0200)]
[RSYM] When determining the current function, always prefer COFF symbols if they're closer.
Stanislav Motylkov [Fri, 16 Aug 2019 23:36:17 +0000 (02:36 +0300)]
[FREELDR] Add missing VideoSetTextCursorPosition handler for Xbox
This fixes null pointer call bug, which was revealed in
85d44fc. Spotted by Mark Jansen. CORE-16216
Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
Shy Zedaka [Fri, 16 Aug 2019 13:16:41 +0000 (16:16 +0300)]
[TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt
Stanislav Motylkov [Fri, 16 Aug 2019 18:00:25 +0000 (21:00 +0300)]
[FREELDR] Add Serial ports detection in DetectIsaBios() (#1829)
CORE-16216
Pierre Schweitzer [Fri, 16 Aug 2019 17:54:44 +0000 (19:54 +0200)]
[SDK] As sole author of the file, relicense it as LPGL
It allows third party developers (such as Mark Harmstone :-)) to use it
Victor Perevertkin [Fri, 16 Aug 2019 17:37:11 +0000 (20:37 +0300)]
[USBOHCI_NEW] Fix unused variable
Jose Carlos Jesus [Fri, 16 Aug 2019 16:47:08 +0000 (18:47 +0200)]
[CONSOLE] New Portuguese Translation
Jose Carlos Jesus [Mon, 5 Aug 2019 23:20:18 +0000 (00:20 +0100)]
[DESKMON] Update Portuguese Translation
Jose Carlos Jesus [Mon, 5 Aug 2019 23:14:11 +0000 (00:14 +0100)]
[DESK] New Portuguese translation
Jose Carlos Jesus [Sat, 3 Aug 2019 16:55:09 +0000 (17:55 +0100)]
[SHELL][COMCTL32] pt_PT_Translation Improvements
Jose Carlos Jesus [Sat, 3 Aug 2019 16:52:05 +0000 (17:52 +0100)]
[HDWWIZ] New pt_PT_Translation
Stanislav Motylkov [Fri, 16 Aug 2019 17:14:10 +0000 (20:14 +0300)]
[FREELDR] Add PCI BIOS emulation and PCI bus enumeration for Xbox (#1830)
CORE-16216 CORE-16308
Oleg Dubinskiy [Fri, 16 Aug 2019 17:11:04 +0000 (20:11 +0300)]
[AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826)
Rename RosAudioSrv to AudioSrv in audio service itself and in all system components which are related to this, same as it done in Win2k3.
It allows MS DxDiag to detect the system audio service correctly, so it becomes possible to run DirectSound test properly with MS dsound.dll, although it works with some minor errors and only in older VirtualBox versions, ~ up to 5.1.38 (and in other emulators as well).
CORE-16307
Stanislav Motylkov [Thu, 27 Jun 2019 23:38:10 +0000 (02:38 +0300)]
[USBOHCI_NEW] Refactor OHCI_AbortTransfer function
- Added SAL annotation
- Simplified local variables
- Replace counterintuitive `do {} while ()` loops with nice `for` loops
- Get rid of goto and its label, it can be simply avoided
Andrew Boyarshin [Sun, 25 Nov 2018 06:47:11 +0000 (13:47 +0700)]
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown
They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.
Stanislav Motylkov [Mon, 12 Aug 2019 09:23:25 +0000 (12:23 +0300)]
[HAL] Add Xbox Hardware Abstraction Layer
- Create xbox.cmake based on legacy.cmake and pic.cmake
- Revive Xbox HAL files and add them to the build
- Fix boot with Xbox HAL, add missing parts from halinit_up.c
- Code style and debug logging improvements in pcibus.c
- Allow to choose Xbox HAL in usetup
CORE-16216
Andreas Maier [Fri, 19 Apr 2019 19:00:27 +0000 (21:00 +0200)]
[JSCRIPT] import wine commits "stub + implement Enumerator()"
https://source.winehq.org/git/wine.git/commit/
6630bc4096870d1586e6d431b93dd74eb7ce017d
https://source.winehq.org/git/wine.git/commit/
a015c626438dc8cba445242c68d4175f381b2128
CORE-13810
Mark Jansen [Fri, 16 Aug 2019 14:29:20 +0000 (16:29 +0200)]
[W32TIME] The interval is specified in seconds, but we need milliseconds
Waritnan Sookbuntherng [Tue, 11 Dec 2018 15:25:16 +0000 (22:25 +0700)]
[COMCTL32] Checking size grip bounds in x-axis only
Waritnan Sookbuntherng [Tue, 11 Dec 2018 15:22:47 +0000 (22:22 +0700)]
[COMCTL32] Hide size grip when the parent window is maximized
Serge Gautherie [Sat, 29 Jun 2019 13:14:39 +0000 (15:14 +0200)]
[NETSTAT] '-p UDP' depends on '-a'
Sylvain Deverre [Thu, 8 Aug 2019 20:09:13 +0000 (22:09 +0200)]
[NTFS] Correctly find attributes stored in another file record in MFT (and referenced in data stream)
Katayama Hirofumi MZ [Fri, 16 Aug 2019 08:01:03 +0000 (17:01 +0900)]
Revert "[WININET_APITEST] Add Download testcase (#1832)" (#1839)
This reverts commit
7464241adabfbdfec5a058697632a8d3938479fb.
Katayama Hirofumi MZ [Fri, 16 Aug 2019 07:57:40 +0000 (16:57 +0900)]
[ROSAPPS][NETREG] Fix build
James Tabor [Fri, 16 Aug 2019 02:39:26 +0000 (21:39 -0500)]
Update Headers for Printing and Other
Add missing flags and function types. Fix typos.
Andreas Maier [Sat, 1 Jun 2019 17:09:44 +0000 (19:09 +0200)]
[COMCTL32] Saturated images: Take mask-images in account.
This fixes CORE-14209 - Some icons not drawn in IDA Free
Andreas Maier [Fri, 31 May 2019 08:15:06 +0000 (10:15 +0200)]
[COMCTL32] Improve failure cases.
Serge Gautherie [Sat, 8 Jun 2019 01:03:40 +0000 (03:03 +0200)]
[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()
Also add 'static' on MiniDisplayPacket2().
Bișoc George [Tue, 16 Jul 2019 15:35:30 +0000 (17:35 +0200)]
[OSK] General refactoring
- Replace the existing header files in favour to a pre-compiled header instead. Furthermore, move all the function prototypes in the pre-compiled header.
- As per the prototype definitions, LoadDataFromRegistry() and SaveDataToRegistry() mustn't accept any number of parameters.
- Rename rsrc.rc to osk.rc (main resource file) as most of user-mode applications name have their main resource as the same application's name anyways.
- When querying and saving the data to registry, use only one value, greatly reducing the bloat of variables (as per the Hermes Belusca's request on #1729 PR).
- Update the header description reflecting the official ReactOS Coding style guidelines.
Adam Słaboń [Sat, 13 Jul 2019 15:29:46 +0000 (17:29 +0200)]
[THEMES][LUNAR] Update
Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.
Shy Zedaka [Sun, 4 Aug 2019 20:54:51 +0000 (23:54 +0300)]
[SHELL32] Run Dialog Text Fix
Paweł Cholewa [Thu, 15 Aug 2019 17:07:05 +0000 (19:07 +0200)]
[TASKMGR] Implement proper process tree ending
* Implement ShutdownProcessTree in endproc.c which recursively kills process trees
* Include tlhelp32.h in precomp.h
* Check if the child process can be shut down
Serge Gautherie [Thu, 25 Apr 2019 01:22:16 +0000 (03:22 +0200)]
[NTOSKRNL] Move DPRINT1("Thread wants too much stack\n") around
To KiUserModeCallout() from MmGrowKernelStackEx().
As suggested by Thomas Faber:
"MmGrowKernelStackEx really shouldn't be DPRINT'ing."
CORE-14494
Timo Kreuzer [Sat, 27 Jul 2019 07:58:38 +0000 (09:58 +0200)]
[FREELDR] Improve debug output
Timo Kreuzer [Sat, 27 Jul 2019 07:32:29 +0000 (09:32 +0200)]
[NTOS:MM] MmSizeOfSystemCacheInPages is ULONG_PTR, not ULONG
Fixes failed assertion on x64.
Timo Kreuzer [Thu, 27 Jun 2019 16:05:55 +0000 (18:05 +0200)]
[NTOS:KE:I386] Fix parameter description for KiSwapContext
Timo Kreuzer [Sun, 2 Jun 2019 07:45:45 +0000 (09:45 +0200)]
[NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking minor
Minor function indices are not unique, they are subfunctions, so without first checking the major function, they are ambiguous.
Timo Kreuzer [Sat, 1 Jun 2019 12:42:14 +0000 (14:42 +0200)]
[BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64
Timo Kreuzer [Mon, 22 Apr 2019 11:03:24 +0000 (13:03 +0200)]
[PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE
Timo Kreuzer [Mon, 20 Aug 2018 15:11:40 +0000 (17:11 +0200)]
[TDI] Improve spec file
Timo Kreuzer [Mon, 20 Aug 2018 14:02:44 +0000 (16:02 +0200)]
[PSDK] Fix #ifdef in winuser.h
Timo Kreuzer [Thu, 12 Jul 2018 11:23:04 +0000 (13:23 +0200)]
[VIDEOPRT] Fix order of some exports
Timo Kreuzer [Thu, 12 Jul 2018 13:54:52 +0000 (15:54 +0200)]
[NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop in ExAllocateLocallyUniqueId
Timo Kreuzer [Sun, 11 Feb 2018 20:53:03 +0000 (21:53 +0100)]
[WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1
Timo Kreuzer [Thu, 4 Jan 2018 17:29:24 +0000 (18:29 +0100)]
[NTOS:IO] Improve an alignment
Timo Kreuzer [Thu, 28 Dec 2017 17:35:30 +0000 (18:35 +0100)]
[KSUSER] Improve pointer arithmetics
Katayama Hirofumi MZ [Thu, 15 Aug 2019 14:10:06 +0000 (23:10 +0900)]
[SHELL32] Fix Desktop Properties menu item action (#1833)
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.
The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
Denis Malikov [Sun, 18 Nov 2018 16:51:20 +0000 (23:51 +0700)]
[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it
Serge Gautherie [Thu, 15 Aug 2019 13:42:34 +0000 (15:42 +0200)]
[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6
CORE-12596
Timo Kreuzer [Sat, 20 Jul 2019 15:34:24 +0000 (17:34 +0200)]
[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code
Timo Kreuzer [Mon, 20 Aug 2018 15:42:27 +0000 (17:42 +0200)]
[REACTOS] Fix MSVC printf format warnings
Mark Jansen [Wed, 27 Mar 2019 22:09:36 +0000 (23:09 +0100)]
[DBGHELP_APITEST] Add rsym+pdb tests on loaded modules
Also reorder some stuff to make the tests more alike
Timo Kreuzer [Sun, 26 May 2019 13:00:21 +0000 (15:00 +0200)]
[REACTOS] Fix SIZE_T related warnings
Timo Kreuzer [Sun, 11 Feb 2018 18:22:30 +0000 (19:22 +0100)]
[VIDEOPRT] Implement support for INT10 on x64 using the newly implemented HAL functions.
Timo Kreuzer [Sun, 11 Feb 2018 13:01:43 +0000 (14:01 +0100)]
[VIDEOPRT] Fixes for x64
Timo Kreuzer [Sun, 11 Feb 2018 12:49:14 +0000 (13:49 +0100)]
[VIDEOPRT] Call IntInt10CallBios from VideoPortInt10, instead of code duplication
Timo Kreuzer [Sun, 11 Feb 2018 12:43:05 +0000 (13:43 +0100)]
[VIDEOPRT] [FORMATTING] No code change
Timo Kreuzer [Sun, 11 Feb 2018 18:21:01 +0000 (19:21 +0100)]
[HAL] Implement amd64 BIOS call support
The code uses FAST486 to emulate the BIOS code.
Timo Kreuzer [Sun, 11 Feb 2018 15:43:51 +0000 (16:43 +0100)]
[NDK] Add BIOS call API for amd64
Shy Zedaka [Mon, 5 Aug 2019 21:01:24 +0000 (00:01 +0300)]
[Translation] More Hebrew Translations
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
Andrew Boyarshin [Sun, 25 Nov 2018 07:11:04 +0000 (14:11 +0700)]
[NTOSKRNL][PS] Implement NtQueueApcThreadEx and use it in NtQueueApcThread
Actually rename NtQueueApcThread to NtQueueApcThreadEx and ignore one additional parameter for now.
Mark Jansen [Thu, 8 Aug 2019 19:01:19 +0000 (21:01 +0200)]
[SHELL32] CDefView: Improve the context menu positioning
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
Katayama Hirofumi MZ [Thu, 15 Aug 2019 08:50:57 +0000 (17:50 +0900)]
[WININET_APITEST] Add Download testcase (#1832)
CORE-16310
Katayama Hirofumi MZ [Thu, 15 Aug 2019 01:23:50 +0000 (10:23 +0900)]
[MEDIA][FONTS] Add Baltic MS Sans Serif (ssee1257.fon) CORE-16166
Hermès Bélusca-Maïto [Wed, 14 Aug 2019 13:59:01 +0000 (15:59 +0200)]
[FREELDR] Minor fixes.
- Add some forgotten, or move some misplaced ArcClose() calls so as
to avoid leakages in failure paths. (Thanks to Serge Gautherie for
having caught some of them.)
- Simplify some code; remove unneeded casts; use string-safe functions.
Hermès Bélusca-Maïto [Tue, 13 Aug 2019 15:34:57 +0000 (17:34 +0200)]
[FREELDR] Minor enhancements for disk/partition boot and UI.
- Factor out disk & partition opening in LoadAndBootPartition() and
LoadAndBootDrive() into a LoadAndBootPartitionOrDrive() helper.
- Use ARC paths and ArcOpen()/ArcRead() instead of calling the
machine-specific BIOS-oriented DiskGetPartitionEntry() and
MachDiskReadLogicalSectors() functions to open the disk/partition
and read their boot sectors.
- Don't forget to close the opened boot sector file in LoadAndBootBootSector().
- Add assertions for DiskReadBufferSize in PcMemFinalizeMemoryMap()
and EnumerateHarddisks().
- x86/amd64 only:
* Add a DisableA20 helper for disabling the A20 line, before rebooting
back, or chain-load a boot sector, into 16-bit world.
Also pulse the output port of the keyboard controller to clear out
its state after having set the state of the A20 line.
* In addition to disabling the A20 line when rebooting or chain-loading
a boot sector, reset the video back to 80x25 text mode.
- Reset the cursor position back to the origin when initializing or
terminating the TUI.
Bișoc George [Mon, 12 Aug 2019 18:58:39 +0000 (20:58 +0200)]
[OSK] Romanian translation update (#1820)
Katayama Hirofumi MZ [Mon, 12 Aug 2019 14:10:47 +0000 (23:10 +0900)]
[ATL_APITEST] Simplify code by using ok_int etc. (#1824)
Simplify the code by using ok_int, ok_long etc.
Katayama Hirofumi MZ [Mon, 12 Aug 2019 13:19:55 +0000 (22:19 +0900)]
[MEDIA][FONTS] Total adjustment of MS Sans Serif
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:31:44 +0000 (19:31 +0900)]
[SDK][INCLUDE] Update msgdump.h and winxx.h
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:24:08 +0000 (19:24 +0900)]
[ATL_APITEST] Add 'atltest.h' and use it (#1822)
- Add "atltest.h" header file for common use in atl_apitest.
- Delete the duplicated and simplify.
Mark Jansen [Fri, 9 Aug 2019 22:22:03 +0000 (00:22 +0200)]
[ATL] Add a minimal CAtlArray implementation
Mark Jansen [Fri, 9 Aug 2019 19:25:16 +0000 (21:25 +0200)]
[ATL_APITEST] Add simple test for CAtlArray
Mark Jansen [Fri, 9 Aug 2019 19:24:33 +0000 (21:24 +0200)]
[ATL_APITEST] Change proj files to have a different intermediate dir
Mark Jansen [Fri, 9 Aug 2019 17:14:43 +0000 (19:14 +0200)]
[ATL][ATL_APITEST] Add CAtlList::InsertBefore/After + test
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 20:06:27 +0000 (22:06 +0200)]
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 16:56:40 +0000 (18:56 +0200)]
[FREELDR] Move files where they are only used.
- Merge fade.c/palette.c/video.c into video.c and move it into UI.
- Move inffile.c into NTLDR.
Katayama Hirofumi MZ [Sun, 11 Aug 2019 00:36:39 +0000 (09:36 +0900)]
[MEDIA][FONTS] Add Arabic MS Sans Serif (ssee1256.fon)
CORE-16166